hyrax 2.6.0 → 2.9.0

data/spec/controllers/hyrax/homepage_controller_spec.rb

@@ -1,138 +0,0 @@
-RSpec.describe Hyrax::HomepageController, type: :controller do
-  routes { Hyrax::Engine.routes }
-
-  describe "#index" do
-    let(:user) { create(:user) }
-
-    before do
-      sign_in user
-    end
-
-    context 'with existing featured researcher' do
-      let!(:frodo) { ContentBlock.create!(name: ContentBlock::NAME_REGISTRY[:researcher], value: 'Frodo Baggins', created_at: Time.zone.now) }
-
-      it 'finds the featured researcher' do
-        get :index
-        expect(response).to be_success
-        expect(assigns(:featured_researcher)).to eq frodo
-      end
-    end
-
-    context 'with no featured researcher' do
-      it "sets featured researcher" do
-        get :index
-        expect(response).to be_success
-        assigns(:featured_researcher).tap do |researcher|
-          expect(researcher).to be_kind_of ContentBlock
-          expect(researcher.name).to eq 'featured_researcher'
-        end
-      end
-    end
-
-    it "sets marketing text" do
-      get :index
-      expect(response).to be_success
-      assigns(:marketing_text).tap do |marketing|
-        expect(marketing).to be_kind_of ContentBlock
-        expect(marketing.name).to eq 'marketing_text'
-      end
-    end
-
-    it "does not include other user's private documents in recent documents" do
-      get :index
-      expect(response).to be_success
-      titles = assigns(:recent_documents).map { |d| d['title_tesim'][0] }
-      expect(titles).not_to include('Test Private Document')
-    end
-
-    it "includes only GenericWork objects in recent documents" do
-      get :index
-      assigns(:recent_documents).each do |doc|
-        expect(doc[Solrizer.solr_name("has_model", :symbol)]).to eql ["GenericWork"]
-      end
-    end
-
-    context "with a document not created this second", clean_repo: true do
-      before do
-        gw3 = GenericWork.new(title: ['Test 3 Document'], read_groups: ['public'])
-        gw3.apply_depositor_metadata('mjg36')
-        # stubbing to_solr so we know we have something that didn't create in the current second
-        old_to_solr = gw3.method(:to_solr)
-        allow(gw3).to receive(:to_solr) do
-          old_to_solr.call.merge(
-            Solrizer.solr_name('system_create', :stored_sortable, type: :date) => 1.day.ago.iso8601,
-            Solrizer.solr_name('date_uploaded', :stored_sortable, type: :date) => 1.day.ago.iso8601
-          )
-        end
-        gw3.save
-      end
-
-      it "sets recent documents in the right order" do
-        get :index
-        expect(response).to be_success
-        expect(assigns(:recent_documents).length).to be <= 4
-        create_times = assigns(:recent_documents).map { |d| d['date_uploaded_dtsi'] }
-        expect(create_times).to eq create_times.sort.reverse
-      end
-    end
-
-    context "with collections" do
-      let(:presenter) { double }
-      let(:repository) { double }
-      let(:collection_results) { double(documents: ['collection results']) }
-
-      before do
-        allow(controller).to receive(:repository).and_return(repository)
-        allow(controller).to receive(:search_results).and_return([nil, ['recent document']])
-        allow(controller.repository).to receive(:search).with(an_instance_of(Hyrax::CollectionSearchBuilder))
-                                                        .and_return(collection_results)
-      end
-
-      it "initializes the presenter with ability and a list of collections" do
-        expect(Hyrax::HomepagePresenter).to receive(:new).with(Ability,
-                                                               ["collection results"])
-                                                         .and_return(presenter)
-        get :index
-        expect(response).to be_success
-        expect(assigns(:presenter)).to eq presenter
-      end
-    end
-
-    context "with featured works" do
-      let!(:my_work) { create(:work, user: user) }
-
-      before do
-        FeaturedWork.create!(work_id: my_work.id)
-      end
-
-      it "sets featured works" do
-        get :index
-        expect(response).to be_success
-        expect(assigns(:featured_work_list)).to be_kind_of FeaturedWorkList
-      end
-    end
-
-    it "sets announcement content block" do
-      get :index
-      expect(response).to be_success
-      assigns(:announcement_text).tap do |announcement|
-        expect(announcement).to be_kind_of ContentBlock
-        expect(announcement.name).to eq 'announcement_text'
-      end
-    end
-
-    context "without solr" do
-      before do
-        allow(controller).to receive(:repository).and_return(instance_double(Blacklight::Solr::Repository))
-        allow(controller.repository).to receive(:search).and_raise Blacklight::Exceptions::InvalidRequest
-      end
-
-      it "errors gracefully" do
-        get :index
-        expect(response).to be_success
-        expect(assigns(:admin_sets)).to be_blank
-        expect(assigns(:recent_documents)).to be_blank
-      end
-    end
-  end
-end

data/spec/controllers/hyrax/leases_controller_spec.rb

@@ -1,117 +0,0 @@
-RSpec.describe Hyrax::LeasesController do
-  let(:user) { create(:user) }
-  let(:a_work) { create(:generic_work, user: user) }
-  let(:not_my_work) { create(:generic_work) }
-
-  before { sign_in user }
-
-  describe '#index' do
-    context 'when I am NOT a repository manager' do
-      it 'redirects' do
-        get :index
-        expect(response).to redirect_to root_path
-      end
-    end
-    context 'when I am a repository manager' do
-      let(:user) { create(:user, groups: ['admin']) }
-
-      it 'shows me the page' do
-        expect(controller).to receive(:add_breadcrumb).with('Home', root_path)
-        expect(controller).to receive(:add_breadcrumb).with('Dashboard', dashboard_path)
-        expect(controller).to receive(:add_breadcrumb).with('Manage Leases', leases_path)
-
-        get :index
-        expect(response).to be_success
-        expect(response).to render_template('dashboard')
-      end
-    end
-  end
-
-  describe '#edit' do
-    context 'when I do not have edit permissions for the object' do
-      it 'redirects' do
-        get :edit, params: { id: not_my_work }
-        expect(response.status).to eq 302
-        expect(flash[:alert]).to eq 'You are not authorized to access this page.'
-      end
-    end
-    context 'when I have permission to edit the object' do
-      it 'shows me the page' do
-        expect(controller).to receive(:add_breadcrumb).with('Home', root_path)
-        expect(controller).to receive(:add_breadcrumb).with('Dashboard', dashboard_path)
-        expect(controller).to receive(:add_breadcrumb).with('Manage Leases', leases_path)
-        expect(controller).to receive(:add_breadcrumb).with('Update Lease', '#')
-
-        get :edit, params: { id: a_work }
-        expect(response).to be_success
-        expect(response).to render_template('dashboard')
-      end
-    end
-  end
-
-  describe '#destroy' do
-    context 'when I do not have edit permissions for the object' do
-      it 'denies access' do
-        get :destroy, params: { id: not_my_work }
-        expect(response).to fail_redirect_and_flash(root_path, 'You are not authorized to access this page.')
-      end
-    end
-
-    context 'when I have permission to edit the object' do
-      let(:actor) { double('lease actor') }
-
-      before do
-        allow(Hyrax::Actors::LeaseActor).to receive(:new).with(a_work).and_return(actor)
-      end
-
-      context 'that has no files' do
-        it 'deactivates the lease and redirects' do
-          expect(actor).to receive(:destroy)
-          get :destroy, params: { id: a_work }
-          expect(response).to redirect_to edit_lease_path(a_work)
-        end
-      end
-
-      context 'with files' do
-        before do
-          a_work.members << create(:file_set)
-          a_work.save!
-        end
-
-        it 'deactivates the lease and redirects' do
-          expect(actor).to receive(:destroy)
-          get :destroy, params: { id: a_work }
-          expect(response).to redirect_to confirm_permission_path(a_work)
-        end
-      end
-    end
-  end
-
-  describe '#update' do
-    context 'when I have permission to edit the object' do
-      let(:file_set) { create(:file_set, visibility: Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PUBLIC) }
-      let(:expiration_date) { Time.zone.today + 2 }
-
-      before do
-        a_work.members << file_set
-        a_work.visibility = Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_AUTHENTICATED
-        a_work.visibility_during_lease = Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PUBLIC
-        a_work.visibility_after_lease = Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_AUTHENTICATED
-        a_work.lease_expiration_date = expiration_date.to_s
-        a_work.lease.save(validate: false)
-        a_work.save(validate: false)
-      end
-
-      context 'with an expired lease' do
-        let(:expiration_date) { Time.zone.today - 2 }
-
-        it 'deactivates lease, update the visibility and redirect' do
-          patch :update, params: { batch_document_ids: [a_work.id], leases: { '0' => { copy_visibility: a_work.id } } }
-          expect(a_work.reload.visibility).to eq Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_AUTHENTICATED
-          expect(file_set.reload.visibility).to eq Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_AUTHENTICATED
-          expect(response).to redirect_to leases_path
-        end
-      end
-    end
-  end
-end

data/spec/controllers/hyrax/my/collections_controller_spec.rb

@@ -1,36 +0,0 @@
-RSpec.describe Hyrax::My::CollectionsController, type: :controller do
-  describe "logged in user" do
-    describe "#index" do
-      let(:user) { create(:user) }
-      let(:response) { instance_double(Blacklight::Solr::Response, response: { 'numFound' => 3 }) }
-      let(:doc_list) { [double(id: 123), double(id: 456)] }
-
-      before do
-        sign_in user
-      end
-
-      it "shows the search results and sets breadcrumbs" do
-        expect(controller).to receive(:search_results).with(ActionController::Parameters).and_return([response, doc_list])
-
-        expect(controller).to receive(:add_breadcrumb).with('Home', root_path(locale: 'en'))
-        expect(controller).to receive(:add_breadcrumb).with('Dashboard', dashboard_path(locale: 'en'))
-        expect(controller).to receive(:add_breadcrumb).with('Collections', my_collections_path(locale: 'en'))
-
-        get :index, params: { per_page: 2 }
-        expect(assigns[:document_list].length).to eq 2
-      end
-    end
-  end
-
-  describe "#search_facet_path" do
-    subject { controller.send(:search_facet_path, id: 'keyword_sim') }
-
-    it { is_expected.to eq "/dashboard/my/collections/facet/keyword_sim?locale=en" }
-  end
-
-  describe "#search_builder_class" do
-    subject { controller.search_builder_class }
-
-    it { is_expected.to eq Hyrax::My::CollectionsSearchBuilder }
-  end
-end

data/spec/controllers/hyrax/my/highlights_controller_spec.rb

@@ -1,53 +0,0 @@
-RSpec.describe Hyrax::My::HighlightsController, type: :controller do
-  describe "logged in user" do
-    let(:user) { create(:user) }
-
-    before { sign_in user }
-
-    describe "#index" do
-      before do
-        user.trophies.create(work_id: highlighted_work.id)
-        other_user.trophies.create(work_id: unrelated_highlighted_work.id)
-      end
-
-      let(:other_user) { create(:user) }
-      let(:highlighted_work) { create(:generic_work, user: user) }
-      let!(:normal_work) { create(:generic_work, user: user) }
-      let(:unrelated_highlighted_work) do
-        create(:generic_work, user: other_user).tap do |r|
-          r.edit_users += [user.user_key]
-          r.save!
-        end
-      end
-
-      it "paginates" do
-        work1 = create(:work, user: user)
-        work2 = create(:work, user: user)
-        user.trophies.create!(work_id: work1.id)
-        user.trophies.create!(work_id: work2.id)
-        get :index, params: { per_page: 2 }
-        expect(assigns[:document_list].length).to eq 2
-        get :index, params: { per_page: 2, page: 2 }
-        expect(assigns[:document_list].length).to be >= 1
-      end
-
-      it "shows the correct files" do
-        get :index
-        expect(response).to be_successful
-        # shows documents I've highlighted
-        expect(assigns[:document_list].map(&:id)).to include(highlighted_work.id)
-        # doesn't show non-highlighted files
-        expect(assigns[:document_list].map(&:id)).not_to include(normal_work.id)
-        # doesn't show other users' highlighted files
-        expect(assigns[:document_list].map(&:id)).not_to include(unrelated_highlighted_work.id)
-      end
-    end
-
-    describe "when user has no highlights" do
-      it "skips the call to Solr" do
-        expect(controller).not_to receive(:search_results)
-        get :index
-      end
-    end
-  end
-end

data/spec/controllers/hyrax/my/shares_controller_spec.rb

@@ -1,47 +0,0 @@
-RSpec.describe Hyrax::My::SharesController, type: :controller do
-  describe "logged in user" do
-    let(:user) { create(:user) }
-
-    before do
-      sign_in user
-    end
-
-    describe "#index" do
-      let(:other_user)   { create(:user) }
-      let(:someone_else) { create(:user) }
-
-      let!(:my_work)                  { create(:work, user: user) }
-      let!(:unshared_work)            { create(:work, user: other_user) }
-      let!(:shared_with_me)           { create(:work, user: other_user, edit_users: [user, other_user]) }
-      let!(:read_shared_with_me)      { create(:work, user: other_user, read_users: [user, other_user]) }
-      let!(:shared_with_someone_else) { create(:work, user: other_user, edit_users: [someone_else, other_user]) }
-      let!(:my_collection)            { create(:public_collection_lw, user: user) }
-
-      it "responds with success" do
-        get :index
-        expect(response).to be_successful
-      end
-
-      context "with multiple pages of results" do
-        before { 2.times { create(:work, user: other_user, edit_users: [user, other_user]) } }
-        it "paginates" do
-          get :index, params: { per_page: 2 }
-          expect(assigns[:document_list].length).to eq 2
-          get :index, params: { per_page: 2, page: 2 }
-          expect(assigns[:document_list].length).to be >= 1
-        end
-      end
-
-      it "shows only documents that are shared with me via edit access" do
-        get :index
-        expect(assigns[:document_list].map(&:id)).to contain_exactly(shared_with_me.id)
-      end
-    end
-  end
-
-  describe "#search_facet_path" do
-    subject { controller.send(:search_facet_path, id: 'keyword_sim') }
-
-    it { is_expected.to eq "/dashboard/shares/facet/keyword_sim?locale=en" }
-  end
-end

data/spec/controllers/hyrax/my/works_controller_spec.rb

@@ -1,54 +0,0 @@
-RSpec.describe Hyrax::My::WorksController, type: :controller do
-  let(:user) { create(:user) }
-
-  before { sign_in user }
-
-  describe "#index" do
-    let(:response) { instance_double(Blacklight::Solr::Response, response: { 'numFound' => 3 }) }
-    let(:doc_list) { [double(id: 123), double(id: 456)] }
-    let(:my_collection) { instance_double(SolrDocument) }
-    let(:collection_service) { instance_double(Hyrax::CollectionsService) }
-
-    before do
-      allow(Hyrax::CollectionsService).to receive(:new).and_return(collection_service)
-      allow(Hyrax::Works::ManagedWorksService).to receive(:managed_works_count).and_return(1)
-    end
-
-    it "shows search results and breadcrumbs" do
-      expect(controller).to receive(:search_results).with(ActionController::Parameters).and_return([response, doc_list])
-      expect(controller).to receive(:add_breadcrumb).with('Home', root_path(locale: 'en'))
-      expect(controller).to receive(:add_breadcrumb).with('Dashboard', dashboard_path(locale: 'en'))
-      expect(controller).to receive(:add_breadcrumb).with('Works', my_works_path(locale: 'en'))
-      expect(collection_service).to receive(:search_results).with(:deposit).and_return([my_collection])
-      get :index, params: { per_page: 2 }
-      expect(assigns[:document_list].length).to eq 2
-      expect(assigns[:user_collections]).to contain_exactly(my_collection)
-      expect(assigns[:managed_works_count]).to eq 1
-    end
-  end
-
-  describe "#search_builder_class" do
-    subject { controller.search_builder_class }
-
-    it { is_expected.to eq Hyrax::My::WorksSearchBuilder }
-  end
-
-  describe "#collections_service" do
-    subject { controller.send(:collections_service) }
-
-    it { is_expected.to be_an_instance_of Hyrax::CollectionsService }
-  end
-
-  context "when add_works_to_collection is provided" do
-    it "sets add_works_to_collection ivar" do
-      get :index, params: { add_works_to_collection: '12345' }
-      expect(assigns(:add_works_to_collection)).to eql('12345')
-    end
-  end
-
-  describe "#search_facet_path" do
-    subject { controller.send(:search_facet_path, id: 'keyword_sim') }
-
-    it { is_expected.to eq "/dashboard/my/works/facet/keyword_sim?locale=en" }
-  end
-end