hyrax 2.6.0 → 2.9.0

data/spec/services/hyrax/statistics/file_sets/by_format_spec.rb

@@ -1,29 +0,0 @@
-RSpec.describe Hyrax::Statistics::FileSets::ByFormat, :clean_repo do
-  describe ".query" do
-    let(:fs1) { build(:file_set, id: '1234567') }
-    let(:fs2) { build(:file_set, id: '2345678') }
-    let(:fs3) { build(:file_set, id: '3456789') }
-    let(:fs4) { build(:file_set, id: '4567890') }
-
-    before do
-      allow(fs1).to receive_messages(mime_type: 'text/plain', format_label: ["plain text"])
-      fs1.update_index
-      allow(fs2).to receive_messages(mime_type: 'image/jpg', format_label: ["JPEG image"])
-      fs2.update_index
-      allow(fs3).to receive_messages(mime_type: 'image/tiff', format_label: ["TIFF image"])
-      fs3.update_index
-      allow(fs4).to receive_messages(mime_type: 'image/jpg', format_label: ["JPEG image"])
-      fs4.update_index
-    end
-
-    subject { described_class.query }
-
-    it "is a list of categories" do
-      expect(subject).to eq [{ label: 'jpg (JPEG image)', data: 2 },
-                             { label: 'plain (plain text)', data: 1 },
-                             { label: 'tiff (TIFF image)', data: 1 }]
-      expect(subject.first.label).to eq 'jpg (JPEG image)'
-      expect(subject.first.value).to eq 2
-    end
-  end
-end

data/spec/services/hyrax/statistics/query_service_spec.rb

@@ -1,112 +0,0 @@
-RSpec.describe Hyrax::Statistics::QueryService, :clean_repo do
-  let(:service) { described_class.new }
-
-  describe "#count" do
-    let!(:work) { create(:generic_work) }
-
-    subject { service.count }
-
-    it { is_expected.to eq 1 }
-  end
-
-  describe "find_by_date_created" do
-    let!(:work) { create(:generic_work) }
-
-    subject { service.find_by_date_created(start_date, end_date) }
-
-    context "with no start date" do
-      let(:start_date) { nil }
-      let(:end_date) { nil }
-
-      it { is_expected.to eq [] }
-    end
-
-    context "with no end date" do
-      let(:start_date) { 1.day.ago }
-      let(:end_date) { nil }
-
-      it { is_expected.to eq [work] }
-    end
-
-    context "with an end date" do
-      let(:start_date) { 1.day.ago }
-      let(:end_date) { Time.zone.now }
-
-      it { is_expected.to eq [work] }
-    end
-  end
-
-  describe "where_registered" do
-    subject { service.where_registered }
-
-    let!(:work) { create(:generic_work, read_groups: read_groups) }
-
-    context "when file is private" do
-      let(:read_groups) { ["private"] }
-
-      it { is_expected.to eq [] }
-    end
-
-    context "when file is public" do
-      let(:read_groups) { ["public"] }
-
-      it { is_expected.to eq [] }
-    end
-
-    context "when file is registered" do
-      let(:read_groups) { ["registered"] }
-
-      it { is_expected.to eq [work] }
-    end
-  end
-
-  describe "where_public" do
-    subject { service.where_public }
-
-    let!(:work) { create(:generic_work, read_groups: read_groups) }
-
-    context "when file is private" do
-      let(:read_groups) { ["private"] }
-
-      it { is_expected.to eq [] }
-    end
-
-    context "when file is public" do
-      let(:read_groups) { ["public"] }
-
-      it { is_expected.to eq [work] }
-    end
-
-    context "when file is registered" do
-      let(:read_groups) { ["registered"] }
-
-      it { is_expected.to eq [] }
-    end
-  end
-
-  describe "#find_registered_in_date_range" do
-    subject { service.find_registered_in_date_range(start_date, end_date) }
-
-    let(:start_date) { 1.day.ago }
-    let(:end_date) { Time.zone.now }
-
-    it "is a relation" do
-      allow(service).to receive(:build_date_query).with(start_date, end_date).and_return('date query')
-      expect(subject).to be_kind_of ActiveFedora::Relation
-      expect(subject.values).to eq(where: ["(date query)", "_query_:\"{!field f=read_access_group_ssim}registered\""])
-    end
-  end
-
-  describe "#find_public_in_date_range" do
-    subject { service.find_public_in_date_range(start_date, end_date) }
-
-    let(:start_date) { 1.day.ago }
-    let(:end_date) { Time.zone.now }
-
-    it "is a relation" do
-      allow(service).to receive(:build_date_query).with(start_date, end_date).and_return('date query')
-      expect(subject).to be_kind_of ActiveFedora::Relation
-      expect(subject.values).to eq(where: ["(date query)", "_query_:\"{!field f=read_access_group_ssim}public\""])
-    end
-  end
-end

data/spec/services/hyrax/statistics/system_stats_spec.rb

@@ -1,45 +0,0 @@
-RSpec.describe Hyrax::Statistics::SystemStats do
-  let(:user1) { create(:user) }
-  let(:start_date) { nil }
-  let(:end_date) { nil }
-
-  describe ".recent_users" do
-    let!(:user2) { create(:user) }
-
-    let(:two_days_ago_date) { 2.days.ago.beginning_of_day }
-    let(:one_day_ago_date) { 1.day.ago.end_of_day }
-
-    let(:depositor_count) { nil }
-
-    subject { described_class.recent_users(limit: depositor_count, start_date: start_date, end_date: end_date) }
-
-    context "without dates" do
-      let(:mock_order) { double }
-      let(:mock_limit) { double }
-
-      it "defaults to latest 5 users" do
-        expect(mock_order).to receive(:limit).with(5).and_return(mock_limit)
-        expect(User).to receive(:order).with('created_at DESC').and_return(mock_order)
-        is_expected.to eq mock_limit
-      end
-    end
-
-    context "with start date" do
-      let(:start_date) { two_days_ago_date }
-
-      it "allows queries  without an end date " do
-        expect(User).to receive(:recent_users).with(two_days_ago_date, nil).and_return([user2])
-        is_expected.to eq([user2])
-      end
-    end
-    context "with start date and end date" do
-      let(:start_date) { two_days_ago_date }
-      let(:end_date) { one_day_ago_date }
-
-      it "queries" do
-        expect(User).to receive(:recent_users).with(two_days_ago_date, one_day_ago_date).and_return([user2])
-        is_expected.to eq([user2])
-      end
-    end
-  end
-end

data/spec/services/hyrax/statistics/users/over_time_spec.rb

@@ -1,22 +0,0 @@
-RSpec.describe Hyrax::Statistics::Users::OverTime do
-  before do
-    create(:user, created_at: 1.week.ago)
-    create(:user, created_at: 1.week.ago)
-    create(:user, created_at: 2.weeks.ago)
-  end
-
-  let(:instance) do
-    described_class.new(x_min: 3.weeks.ago,
-                        x_output: ->(x) { x.strftime('%b %-d') })
-  end
-
-  describe "#points" do
-    subject { instance.points }
-
-    it "has the counts" do
-      expect(subject.size).to eq 4
-      expect(subject.to_a.first.last).to eq 1
-      expect(subject.to_a.second.last).to eq 2
-    end
-  end
-end

data/spec/services/hyrax/statistics/works/by_depositor_spec.rb

@@ -1,24 +0,0 @@
-RSpec.describe Hyrax::Statistics::Works::ByDepositor do
-  describe ".query", :clean_repo do
-    let(:user1) { create(:user) }
-    let(:user2) { create(:user) }
-
-    before do
-      gf = build(:generic_work, user: user1, id: '1234567')
-      gf.update_index
-      gf = build(:generic_work, user: user2, id: '2345678')
-      gf.update_index
-      gf = build(:generic_work, user: user1, id: '3456789')
-      gf.update_index
-      gf = build(:generic_work, user: user1, id: '4567890')
-      gf.update_index
-    end
-
-    subject { described_class.query }
-
-    it "is a list of categories" do
-      expect(subject).to eq [{ label: user1.user_key, data: 3 },
-                             { label: user2.user_key, data: 1 }]
-    end
-  end
-end

data/spec/services/hyrax/statistics/works/by_resource_type_spec.rb

@@ -1,28 +0,0 @@
-RSpec.describe Hyrax::Statistics::Works::ByResourceType do
-  let(:service) { described_class.new }
-  let(:user) { create(:user) }
-
-  describe "#query", :clean_repo do
-    before do
-      # Creating factories here led to failures found within
-      # https://travis-ci.org/samvera/hyrax/jobs/454752377
-      # One should be able to invoke create(:generic_work)...
-      # ...however, there are difficulties here which relate to the "terms"
-      # requestHandler
-      # @see https://github.com/samvera/hyrax/issues/3491
-      GenericWork.create(title: ['test'], resource_type: ['Conference Proceeding']).save!
-      GenericWork.create(title: ['test'], resource_type: ['Conference Proceeding']).save!
-      GenericWork.create(title: ['test'], resource_type: ['Image']).save!
-      GenericWork.create(title: ['test'], resource_type: ['Journal']).save!
-    end
-
-    subject { service.query }
-
-    it "is a list of categories" do
-      expect(subject).to eq [{ label: 'Conference Proceeding', data: 2 },
-                             { label: 'Image', data: 1 },
-                             { label: 'Journal', data: 1 }]
-      expect(subject.to_json).to eq "[{\"label\":\"Conference Proceeding\",\"data\":2},{\"label\":\"Image\",\"data\":1},{\"label\":\"Journal\",\"data\":1}]"
-    end
-  end
-end

data/spec/services/hyrax/statistics/works/count_spec.rb

@@ -1,33 +0,0 @@
-RSpec.describe Hyrax::Statistics::Works::Count do
-  describe ".by_permission", :clean_repo do
-    let(:user1) { build(:user, id: 1) }
-    let(:yesterday) { 1.day.ago }
-
-    before do
-      build(:public_generic_work, user: user1, id: "pdf1223").update_index
-      build(:public_generic_work, user: user1, id: "wav1223").update_index
-      build(:public_generic_work, user: user1, id: "mp31223", create_date: [2.days.ago]).update_index
-      build(:registered_generic_work, user: user1, id: "reg1223").update_index
-      build(:generic_work, user: user1, id: "private1223").update_index
-      Collection.new(id: "ccc123") do |c|
-        c.apply_depositor_metadata(user1)
-        c.update_index
-      end
-    end
-
-    # Consolidated these tests as they are rather slow when run in sequence
-    it "retrieves by no date given, a start date given, and an end date given" do
-      no_date_range_given = described_class.by_permission(start_date: nil, end_date: nil)
-      expect(no_date_range_given).to include(public: 3, private: 1, registered: 1, total: 5)
-
-      start_date = yesterday.beginning_of_day
-      start_date_given = described_class.by_permission(start_date: start_date, end_date: nil)
-      expect(start_date_given).to include(public: 2, private: 1, registered: 1, total: 4)
-
-      start_date = 2.days.ago.beginning_of_day
-      end_date = yesterday.end_of_day
-      start_date_and_end_date_given = described_class.by_permission(start_date: start_date, end_date: end_date)
-      expect(start_date_and_end_date_given).to include(public: 1, private: 0, registered: 0, total: 1)
-    end
-  end
-end

data/spec/services/hyrax/statistics/works/over_time_spec.rb

@@ -1,17 +0,0 @@
-RSpec.describe Hyrax::Statistics::Works::OverTime do
-  let(:service) { described_class.new }
-
-  describe "#points", :clean_repo do
-    before do
-      create(:generic_work)
-    end
-
-    subject { service.points }
-
-    it "is a list of points" do
-      expect(subject.size).to eq 5
-      expect(subject.first[1]).to eq 0
-      expect(subject.to_a.last[1]).to eq 1
-    end
-  end
-end

data/spec/services/hyrax/thumbnail_path_service_spec.rb

@@ -1,55 +0,0 @@
-RSpec.describe Hyrax::ThumbnailPathService do
-  include Hyrax::FactoryHelpers
-
-  subject { described_class.call(object) }
-
-  context "with a FileSet" do
-    let(:object) { build(:file_set, id: '999') }
-
-    before do
-      allow(object).to receive(:original_file).and_return(original_file)
-      # https://github.com/samvera/active_fedora/issues/1251
-      allow(object).to receive(:persisted?).and_return(true)
-    end
-    context "that has a thumbnail" do
-      let(:original_file) { mock_file_factory(mime_type: 'image/jpeg') }
-
-      before { allow(File).to receive(:exist?).and_return(true) }
-      it { is_expected.to eq '/downloads/999?file=thumbnail' }
-    end
-
-    context "that is an audio" do
-      let(:original_file) { mock_file_factory(mime_type: 'audio/x-wav') }
-
-      it { is_expected.to match %r{/assets/audio-.+.png} }
-    end
-
-    context "that has no thumbnail" do
-      let(:original_file) { mock_model('MockOriginal', mime_type: nil) }
-
-      it { is_expected.to match %r{/assets/default-.+.png} }
-    end
-  end
-
-  context "with a Work" do
-    context "that has a thumbnail" do
-      let(:object)         { GenericWork.new(thumbnail_id: '999') }
-      let(:representative) { build(:file_set, id: '999') }
-      let(:original_file)  { mock_file_factory(mime_type: 'image/jpeg') }
-
-      before do
-        allow(File).to receive(:exist?).and_return(true)
-        allow(ActiveFedora::Base).to receive(:find).with('999').and_return(representative)
-        allow(representative).to receive(:original_file).and_return(original_file)
-      end
-
-      it { is_expected.to eq '/downloads/999?file=thumbnail' }
-    end
-
-    context "that doesn't have a representative" do
-      let(:object) { FileSet.new }
-
-      it { is_expected.to match %r{/assets/default-.+.png} }
-    end
-  end
-end

data/spec/services/hyrax/tolerant_select_service_spec.rb

@@ -1,80 +0,0 @@
-RSpec.describe Hyrax::TolerantSelectService do
-  subject(:select_service) { described_class.new(authority_name) }
-
-  let(:authority) { FakeAuthority }
-  let(:authority_name) { 'fake_authority' }
-  let(:authority_map) { [] }
-
-  before do
-    allow(Qa::Authorities::Local)
-      .to receive(:subauthority_for)
-      .with(authority_name)
-      .and_return(authority.new(authority_map))
-  end
-
-  shared_context 'with terms' do
-    let(:authority_map) do
-      [HashWithIndifferentAccess.new(term: 'Active Label', label: 'Active Label', id: 'active-id', active: true),
-       HashWithIndifferentAccess.new(term: 'Inactive Label', label: 'Inactive Label', id: 'inactive-id', active: false),
-       HashWithIndifferentAccess.new(label: 'Active No Term', id: 'active-no-term-id', active: true),
-       HashWithIndifferentAccess.new(term: 'No Active Flag Term', label: 'No Active Flag Label', id: 'no-active-flag-id')]
-    end
-  end
-
-  describe '#active?' do
-    it 'is false for missing id' do
-      expect(select_service.active?('fake_id')).to be_falsey
-    end
-
-    context 'with terms' do
-      include_context 'with terms'
-
-      it 'is true for an active term' do
-        expect(select_service.active?('active-id')).to be true
-      end
-
-      it 'is false for an inactive term' do
-        expect(select_service.active?('inactive-id')).to be_falsey
-      end
-
-      it 'defaults to true for a term with no flag' do
-        expect(select_service.active?('no-active-flag-id')).to be true
-      end
-    end
-  end
-
-  describe '#select_all_options' do
-    it 'is empty' do
-      expect(select_service.select_all_options).to be_empty
-    end
-
-    context 'with terms' do
-      include_context 'with terms'
-
-      it 'contains all labels and ids' do
-        expect(select_service.select_all_options)
-          .to contain_exactly(['Active Label', 'active-id'],
-                              ['Inactive Label', 'inactive-id'],
-                              ['Active No Term', 'active-no-term-id'],
-                              ['No Active Flag Label', 'no-active-flag-id'])
-      end
-    end
-  end
-
-  describe '#select_active_options' do
-    it 'is empty' do
-      expect(select_service.select_active_options).to be_empty
-    end
-
-    context 'with terms' do
-      include_context 'with terms'
-
-      it 'contains active labels and ids' do
-        expect(select_service.select_active_options)
-          .to contain_exactly(['Active Label', 'active-id'],
-                              ['Active No Term', 'active-no-term-id'],
-                              ['No Active Flag Label', 'no-active-flag-id'])
-      end
-    end
-  end
-end