hyrax 2.6.0 → 2.9.0

data/spec/factories/proxy_deposit_requests.rb

@@ -1,6 +0,0 @@
-# Read about factories at https://github.com/thoughtbot/factory_bot
-
-FactoryBot.define do
-  factory :proxy_deposit_request do
-  end
-end

data/spec/factories/single_use_links.rb

@@ -1,13 +0,0 @@
-FactoryBot.define do
-  factory :single_use_link do
-    factory :show_link do
-      itemId { 'fs-id' }
-      path { '/concerns/generic_work/1234' }
-    end
-
-    factory :download_link do
-      itemId { 'fs-id' }
-      path { '/downloads/1234' }
-    end
-  end
-end

data/spec/factories/sipity_entities.rb

@@ -1,7 +0,0 @@
-FactoryBot.define do
-  factory :sipity_entity, class: Sipity::Entity do
-    proxy_for_global_id { 'gid://internal/Mock/1' }
-    workflow { workflow_state.workflow }
-    workflow_state
-  end
-end

data/spec/factories/uploaded_files.rb

@@ -1,5 +0,0 @@
-FactoryBot.define do
-  factory :uploaded_file, class: Hyrax::UploadedFile do
-    user
-  end
-end

data/spec/factories/users.rb

@@ -1,59 +0,0 @@
-FactoryBot.define do
-  factory :user do
-    sequence(:email) { |n| "user#{n}@example.com" }
-    password { 'password' }
-
-    transient do
-      # Allow for custom groups when a user is instantiated.
-      # @example create(:user, groups: 'avacado')
-      groups { [] }
-    end
-
-    # TODO: Register the groups for the given user key such that we can remove the following from other specs:
-    #   `allow(::User.group_service).to receive(:byname).and_return(user.user_key => ['admin'])``
-    after(:build) do |user, evaluator|
-      # In case we have the instance but it has not been persisted
-      ::RSpec::Mocks.allow_message(user, :groups).and_return(Array.wrap(evaluator.groups))
-      # Given that we are stubbing the class, we need to allow for the original to be called
-      ::RSpec::Mocks.allow_message(user.class.group_service, :fetch_groups).and_call_original
-      # We need to ensure that each instantiation of the admin user behaves as expected.
-      # This resolves the issue of both the created object being used as well as re-finding the created object.
-      ::RSpec::Mocks.allow_message(user.class.group_service, :fetch_groups).with(user: user).and_return(Array.wrap(evaluator.groups))
-    end
-
-    factory :admin do
-      groups { ['admin'] }
-    end
-
-    factory :user_with_mail do
-      after(:create) do |user|
-        # Create examples of single file successes and failures
-        (1..10).each do |number|
-          file = MockFile.new(number.to_s, "Single File #{number}")
-          User.batch_user.send_message(user, 'File 1 could not be updated. You do not have sufficient privileges to edit it.', file.to_s, false)
-          User.batch_user.send_message(user, 'File 1 has been saved', file.to_s, false)
-        end
-
-        # Create examples of mulitple file successes and failures
-        files = []
-        (1..50).each do |number|
-          files << MockFile.new(number.to_s, "File #{number}")
-        end
-        User.batch_user.send_message(user, 'These files could not be updated. You do not have sufficient privileges to edit them.', 'Batch upload permission denied', false)
-        User.batch_user.send_message(user, 'These files have been saved', 'Batch upload complete', false)
-      end
-    end
-  end
-
-  trait :guest do
-    guest { true }
-  end
-end
-
-class MockFile
-  attr_accessor :to_s, :id
-  def initialize(id, string)
-    self.id = id
-    self.to_s = string
-  end
-end

data/spec/factories/workflow_actions.rb

@@ -1,6 +0,0 @@
-FactoryBot.define do
-  factory :workflow_action, class: Sipity::WorkflowAction do
-    workflow
-    name { 'submit' }
-  end
-end

data/spec/factories/workflow_states.rb

@@ -1,6 +0,0 @@
-FactoryBot.define do
-  factory :workflow_state, class: Sipity::WorkflowState do
-    workflow
-    name { 'initial' }
-  end
-end

data/spec/factories/workflows.rb

@@ -1,6 +0,0 @@
-FactoryBot.define do
-  factory :workflow, class: Sipity::Workflow do
-    sequence(:name) { |n| "generic_work-#{n}" }
-    permission_template
-  end
-end

data/spec/factory_tests/adminsets_factory_spec.rb

@@ -1,132 +0,0 @@
-RSpec.describe 'AdminSets Factory' do # rubocop:disable RSpec/DescribeClass
-  let(:user) { build(:user, email: 'user@example.com') }
-  let(:user_mgr) { build(:user, email: 'user_mgr@example.com') }
-  let(:user_dep) { build(:user, email: 'user_dep@example.com') }
-  let(:user_vw) { build(:user, email: 'user_vw@example.com') }
-
-  describe 'build' do
-    context 'with_permission_template' do
-      it 'will not create a permission template or access when it is the default value of false' do
-        expect { build(:adminset_lw) }.not_to change { Hyrax::PermissionTemplate.count }
-        expect { build(:adminset_lw) }.not_to change { Hyrax::PermissionTemplateAccess.count }
-      end
-
-      it 'will create a permission template and one access for the creating user when set to true' do
-        expect { build(:adminset_lw, with_permission_template: true) }.to change { Hyrax::PermissionTemplate.count }.by(1)
-        expect { build(:adminset_lw, with_permission_template: true) }.to change { Hyrax::PermissionTemplateAccess.count }.by(1)
-      end
-
-      it 'will create a permission template and access for each user specified when it is set to attributes identifying access' do
-        expect { build(:adminset_lw, with_permission_template: { manage_users: [user_mgr] }) }.to change { Hyrax::PermissionTemplate.count }.by(1)
-        expect { build(:adminset_lw, with_permission_template: { manage_users: [user_mgr] }) }.to change { Hyrax::PermissionTemplateAccess.count }.by(2)
-        expect { build(:adminset_lw, with_permission_template: { manage_users: [user_mgr], deposit_users: [user_dep], view_users: [user_vw] }) }
-          .to change { Hyrax::PermissionTemplate.count }.by(1)
-        expect { build(:adminset_lw, with_permission_template: { manage_users: [user_mgr], deposit_users: [user_dep], view_users: [user_vw] }) }
-          .to change { Hyrax::PermissionTemplateAccess.count }.by(4)
-      end
-    end
-
-    context 'with_solr_document' do
-      it 'will not create a solr document by default' do
-        adminset = build(:adminset_lw)
-        expect(adminset.id).to eq nil # no real way to confirm a solr document wasn't created if the admin set doesn't have an id
-      end
-
-      context 'true' do
-        let(:adminset) { build(:adminset_lw, with_solr_document: true) }
-
-        subject { ActiveFedora::SolrService.get("id:#{adminset.id}")["response"]["docs"].first }
-
-        it 'will create a solr document' do
-          expect(subject["id"]).to eq adminset.id
-          expect(subject["has_model_ssim"].first).to eq "AdminSet"
-          expect(subject["edit_access_person_ssim"]).not_to be_blank
-        end
-      end
-
-      context 'true and with_permission_template defines additional access' do
-        let(:adminset) do
-          build(:adminset_lw, user: user,
-                              with_solr_document: true,
-                              with_permission_template: { manage_users: [user_mgr],
-                                                          deposit_users: [user_dep],
-                                                          view_users: [user_vw] })
-        end
-
-        subject { ActiveFedora::SolrService.get("id:#{adminset.id}")["response"]["docs"].first }
-
-        it 'will created a solr document' do
-          expect(subject["id"]).to eq adminset.id
-          expect(subject["has_model_ssim"].first).to eq "AdminSet"
-          expect(subject["edit_access_person_ssim"]).to include(user.user_key, user_mgr.user_key)
-          expect(subject["read_access_person_ssim"]).to include(user_dep.user_key, user_vw.user_key)
-        end
-      end
-    end
-  end
-
-  describe 'create' do
-    # with_solr_document is tested by build
-    # with_permission_template is tested by build except that the permission template is always created for `create`
-
-    context 'with_permission_template: false' do
-      it 'will create a permission template and access even when it is the default value of false' do
-        expect { create(:adminset_lw) }.to change { Hyrax::PermissionTemplate.count }.by(1)
-        expect { create(:adminset_lw) }.to change { Hyrax::PermissionTemplateAccess.count }.by(1)
-      end
-    end
-  end
-
-  describe 'default_adminset' do
-    let(:default_adminset) { build(:default_adminset) }
-    let(:solrdoc) { ActiveFedora::SolrService.get("id:#{default_adminset.id}")["response"]["docs"].first }
-    let(:permission_template) { default_adminset.permission_template }
-
-    it 'will create the default adminset with expected metadata' do
-      expect(default_adminset.id).to eq AdminSet::DEFAULT_ID
-      expect(default_adminset.title).to eq AdminSet::DEFAULT_TITLE
-    end
-
-    it 'will create solr doc with no access' do
-      expect(solrdoc["id"]).to eq default_adminset.id
-      expect(solrdoc["has_model_ssim"].first).to eq "AdminSet"
-      expect(solrdoc["edit_access_person_ssim"].count).to eq 1 # creator automatically assigned by factory
-      expect(solrdoc["read_access_person_ssim"]).to eq nil
-      expect(solrdoc["edit_access_group_ssim"]).to include(::Ability.admin_group_name)
-      expect(solrdoc["read_access_group_ssim"]).to eq nil
-    end
-
-    it 'will create permission template with registered users as depositors' do
-      expect(permission_template.agent_ids_for(access: 'deposit', agent_type: 'group'))
-        .to include(::Ability.registered_group_name)
-      expect(permission_template.agent_ids_for(access: 'manage', agent_type: 'group'))
-        .to include(::Ability.admin_group_name)
-    end
-  end
-
-  describe 'build no_solr_grants_adminset' do
-    let(:permissions) do
-      { manage_users: [user_mgr],
-        deposit_users: [user_dep],
-        view_users: [user_vw] }
-    end
-    let(:legacy_adminset) { build(:no_solr_grants_adminset, user: user, with_permission_template: permissions) }
-    let(:solrdoc) { ActiveFedora::SolrService.get("id:#{legacy_adminset.id}")["response"]["docs"].first }
-
-    it 'will create a permission template with all access' do
-      expect { build(:no_solr_grants_adminset, user: user, with_permission_template: permissions) }
-        .to change { Hyrax::PermissionTemplate.count }.by(1)
-      expect { build(:no_solr_grants_adminset, user: user, with_permission_template: permissions) }
-        .to change { Hyrax::PermissionTemplateAccess.count }.by(4)
-    end
-
-    it 'will create solr doc with creator access only' do
-      expect(solrdoc["id"]).to eq legacy_adminset.id
-      expect(solrdoc["has_model_ssim"].first).to eq "AdminSet"
-      expect(solrdoc["edit_access_person_ssim"]).to eq [user.user_key]
-      expect(solrdoc["read_access_person_ssim"]).to eq nil
-      expect(solrdoc["edit_access_group_ssim"]).to eq nil
-      expect(solrdoc["read_access_group_ssim"]).to eq nil
-    end
-  end
-end

data/spec/factory_tests/collections_factory_spec.rb

@@ -1,212 +0,0 @@
-RSpec.describe 'Collections Factory' do # rubocop:disable RSpec/DescribeClass
-  let(:user) { build(:user, email: 'user@example.com') }
-  let(:user_mgr) { build(:user, email: 'user_mgr@example.com') }
-  let(:user_dep) { build(:user, email: 'user_dep@example.com') }
-  let(:user_vw) { build(:user, email: 'user_vw@example.com') }
-  let(:collection_type) { create(:collection_type) }
-
-  describe 'build' do
-    context 'with collection_type_settings and/or collection_type_gid' do
-      it 'will use the default User Collection type when neither is specified' do
-        col = build(:collection_lw)
-        expect(col.collection_type.title).to eq 'User Collection'
-        expect(col.collection_type.machine_id).to eq 'user_collection'
-      end
-
-      it 'uses collection type for passed in collection_type_gid when collection_type_settings is nil' do
-        col = build(:collection_lw, collection_type_gid: collection_type.gid)
-        expect(col.collection_type_gid).to eq collection_type.gid
-      end
-
-      it 'ignores collection_type_gid when collection_type_settings is set to attributes identifying settings' do
-        col = build(:collection_lw, collection_type_settings: [:not_discoverable, :not_sharable], collection_type_gid: collection_type.gid)
-        expect(col.collection_type_gid).not_to eq collection_type.gid
-      end
-
-      it 'will create a collection type when collection_type_settings is set to attributes identifying settings' do
-        expect { build(:collection_lw, collection_type_settings: [:discoverable]) }.to change { Hyrax::CollectionType.count }.by(1)
-        expect { build(:collection_lw, collection_type_settings: [:not_discoverable, :not_sharable]) }.to change { Hyrax::CollectionType.count }.by(1)
-      end
-
-      it 'will create a collection type with specified settings when collection_type_settings is set to attributes identifying settings' do
-        col = build(:collection_lw, collection_type_settings: [:not_discoverable, :not_sharable, :not_brandable, :nestable])
-        expect(col.collection_type.discoverable?).to be false
-        expect(col.collection_type.sharable?).to be false
-        expect(col.collection_type.brandable?).to be false
-        expect(col.collection_type.nestable?).to be true
-      end
-    end
-
-    context 'with_permission_template' do
-      it 'will not create a permission template or access when it is the default value of false' do
-        expect { build(:collection_lw) }.not_to change { Hyrax::PermissionTemplate.count }
-        expect { build(:collection_lw) }.not_to change { Hyrax::PermissionTemplateAccess.count }
-      end
-
-      it 'will create a permission template and one access for the creating user when set to true' do
-        expect { build(:collection_lw, with_permission_template: true) }.to change { Hyrax::PermissionTemplate.count }.by(1)
-        expect { build(:collection_lw, with_permission_template: true) }.to change { Hyrax::PermissionTemplateAccess.count }.by(1)
-      end
-
-      it 'will create a permission template and access for each user specified when it is set to attributes identifying access' do
-        expect { build(:collection_lw, with_permission_template: { manage_users: [user_mgr] }) }.to change { Hyrax::PermissionTemplate.count }.by(1)
-        expect { build(:collection_lw, with_permission_template: { manage_users: [user_mgr] }) }.to change { Hyrax::PermissionTemplateAccess.count }.by(2)
-        expect { build(:collection_lw, with_permission_template: { manage_users: [user_mgr], deposit_users: [user_dep], view_users: [user_vw] }) }
-          .to change { Hyrax::PermissionTemplate.count }.by(1)
-        expect { build(:collection_lw, with_permission_template: { manage_users: [user_mgr], deposit_users: [user_dep], view_users: [user_vw] }) }
-          .to change { Hyrax::PermissionTemplateAccess.count }.by(4)
-      end
-    end
-
-    context 'with_solr_document' do
-      it 'will not create a solr document by default' do
-        col = build(:collection_lw)
-        expect(col.id).to eq nil # no real way to confirm a solr document wasn't created if the collection doesn't have an id
-      end
-
-      context 'true' do
-        let(:col) { build(:collection_lw, with_solr_document: true) }
-
-        subject { ActiveFedora::SolrService.get("id:#{col.id}")["response"]["docs"].first }
-
-        it 'will create a solr document' do
-          expect(subject["id"]).to eq col.id
-          expect(subject["has_model_ssim"].first).to eq "Collection"
-          expect(subject["edit_access_person_ssim"]).not_to be_blank
-        end
-      end
-
-      context 'true and with_permission_template defines additional access' do
-        let(:col) do
-          build(:collection_lw, user: user,
-                                with_solr_document: true,
-                                with_permission_template: { manage_users: [user_mgr],
-                                                            deposit_users: [user_dep],
-                                                            view_users: [user_vw] })
-        end
-
-        subject { ActiveFedora::SolrService.get("id:#{col.id}")["response"]["docs"].first }
-
-        it 'will create a solr document' do
-          expect(subject["id"]).to eq col.id
-          expect(subject["has_model_ssim"].first).to eq "Collection"
-          expect(subject["edit_access_person_ssim"]).to include(user.user_key, user_mgr.user_key)
-          expect(subject["read_access_person_ssim"]).to include(user_dep.user_key, user_vw.user_key)
-        end
-      end
-    end
-
-    context 'with_nesting_attributes' do
-      let(:collection_type) { create(:collection_type) }
-      let(:blacklight_config) { CatalogController.blacklight_config }
-      let(:repository) { Blacklight::Solr::Repository.new(blacklight_config) }
-      let(:current_ability) { instance_double(Ability, admin?: true) }
-      let(:scope) { double('Scope', can?: true, current_ability: current_ability, repository: repository, blacklight_config: blacklight_config) }
-      let(:solr_doc) { ActiveFedora::SolrService.get("id:#{col.id}")["response"]["docs"].first }
-      let(:nesting_attributes) do
-        Hyrax::Collections::NestedCollectionQueryService::NestingAttributes.new(id: col.id, scope: scope)
-      end
-
-      context 'without additional permissions' do
-        let(:col) do
-          build(:collection_lw, id: 'Collection123',
-                                collection_type_gid: collection_type.gid,
-                                with_nesting_attributes: { ancestors: ['Parent_1'],
-                                                           parent_ids: ['Parent_1'],
-                                                           pathnames: ['Parent_1/Collection123'],
-                                                           depth: 2 })
-        end
-
-        it 'will persist a queryable solr document with the given attributes' do
-          expect(nesting_attributes.id).to eq('Collection123')
-          expect(nesting_attributes.parents).to eq(['Parent_1'])
-          expect(nesting_attributes.pathnames).to eq(['Parent_1/Collection123'])
-          expect(nesting_attributes.ancestors).to eq(['Parent_1'])
-          expect(nesting_attributes.depth).to eq(2)
-          expect(solr_doc["id"]).to eq col.id
-          expect(solr_doc["has_model_ssim"].first).to eq "Collection"
-          expect(solr_doc["edit_access_person_ssim"]).to include(col.depositor)
-        end
-      end
-
-      context ' and with_permission_template' do
-        let(:col) do
-          build(:collection_lw, id: 'Collection123',
-                                collection_type_gid: collection_type.gid,
-                                with_nesting_attributes: { ancestors: ['Parent_1'],
-                                                           parent_ids: ['Parent_1'],
-                                                           pathnames: ['Parent_1/Collection123'],
-                                                           depth: 2 },
-                                with_permission_template: { manage_users: [user_mgr],
-                                                            deposit_users: [user_dep],
-                                                            view_users: [user_vw] })
-        end
-
-        it 'will persist a queryable solr document with the given attributes' do
-          expect(nesting_attributes.id).to eq('Collection123')
-          expect(nesting_attributes.parents).to eq(['Parent_1'])
-          expect(nesting_attributes.pathnames).to eq(['Parent_1/Collection123'])
-          expect(nesting_attributes.ancestors).to eq(['Parent_1'])
-          expect(nesting_attributes.depth).to eq(2)
-          expect(solr_doc["id"]).to eq col.id
-          expect(solr_doc["has_model_ssim"].first).to eq "Collection"
-          expect(solr_doc["edit_access_person_ssim"]).to include(col.depositor, user_mgr.user_key)
-          expect(solr_doc["read_access_person_ssim"]).to include(user_dep.user_key, user_vw.user_key)
-        end
-      end
-
-      context 'and with_permission_template and with_solr_document' do
-        let(:col) do
-          build(:collection_lw, id: 'Collection123',
-                                collection_type_gid: collection_type.gid,
-                                with_nesting_attributes: { ancestors: ['Parent_1'],
-                                                           parent_ids: ['Parent_1'],
-                                                           pathnames: ['Parent_1/Collection123'],
-                                                           depth: 2 },
-                                with_permission_template: { manage_users: [user_mgr],
-                                                            deposit_users: [user_dep],
-                                                            view_users: [user_vw] },
-                                with_solr_document: true)
-        end
-
-        it 'will persist a queryable solr document with the given attributes' do
-          expect(nesting_attributes.id).to eq('Collection123')
-          expect(nesting_attributes.parents).to eq(['Parent_1'])
-          expect(nesting_attributes.pathnames).to eq(['Parent_1/Collection123'])
-          expect(nesting_attributes.ancestors).to eq(['Parent_1'])
-          expect(nesting_attributes.depth).to eq(2)
-          expect(solr_doc["id"]).to eq col.id
-          expect(solr_doc["has_model_ssim"].first).to eq "Collection"
-          expect(solr_doc["edit_access_person_ssim"]).to include(col.depositor, user_mgr.user_key)
-          expect(solr_doc["read_access_person_ssim"]).to include(user_dep.user_key, user_vw.user_key)
-        end
-      end
-    end
-  end
-
-  describe 'create' do
-    # collection_type_settings and collection_type_gid are tested by `build` and are the same for `build` and `create`
-    # with_solr_document is tested by build
-    # with_permission_template is tested by build except that the permission template is always created for `create`
-    # with_nested_attributes not supported for create
-
-    context 'with_permission_template' do
-      it 'will create a permission template and access even when it is the default value of false' do
-        expect { create(:collection_lw) }.to change { Hyrax::PermissionTemplate.count }.by(1)
-        expect { create(:collection_lw) }.to change { Hyrax::PermissionTemplateAccess.count }.by(1)
-      end
-    end
-
-    context 'when including nesting indexing', with_nested_reindexing: true do
-      # Nested indexing requires that the user's permissions be saved
-      # on the Fedora object... if simply in local memory, they are
-      # lost when the adapter pulls the object from Fedora to reindex.
-      let(:user) { create(:user) }
-      let(:collection) { create(:collection_lw, user: user) }
-
-      it 'will authorize the creating user' do
-        expect(user.can?(:edit, collection)).to be true
-      end
-    end
-  end
-end