hyrax 2.6.0 → 2.7.0

data/spec/views/hyrax/dashboard/_sidebar.html.erb_spec.rb

@@ -1,132 +0,0 @@
-RSpec.describe 'hyrax/dashboard/_sidebar.html.erb', type: :view do
-  let(:user) { stub_model(User, user_key: 'mjg', name: 'Foobar') }
-  let(:read_admin_dashboard) { false }
-  let(:manage_any_admin_set) { false }
-  let(:review_submissions) { false }
-  let(:manage_user) { false }
-  let(:update_appearance) { false }
-  let(:manage_feature) { false }
-  let(:manage_workflow) { false }
-  let(:manage_collection_types) { false }
-
-  before do
-    allow(view).to receive(:signed_in?).and_return(true)
-    allow(view).to receive(:current_user).and_return(user)
-    assign(:user, user)
-    allow(view).to receive(:can?).with(:read, :admin_dashboard).and_return(read_admin_dashboard)
-    allow(view).to receive(:can?).with(:manage_any, AdminSet).and_return(manage_any_admin_set)
-    allow(view).to receive(:can?).with(:review, :submissions).and_return(review_submissions)
-    allow(view).to receive(:can?).with(:manage, User).and_return(manage_user)
-    allow(view).to receive(:can?).with(:update, :appearance).and_return(update_appearance)
-    allow(view).to receive(:can?).with(:manage, Hyrax::Feature).and_return(manage_feature)
-    allow(view).to receive(:can?).with(:manage, Sipity::WorkflowResponsibility).and_return(manage_workflow)
-    allow(view).to receive(:can?).with(:manage, :collection_types).and_return(manage_collection_types)
-  end
-
-  context 'with any user' do
-    before { render }
-    subject { rendered }
-
-    it { is_expected.to have_content 'Foobar' }
-    it { is_expected.to have_content t('hyrax.admin.sidebar.activity') }
-    it { is_expected.to have_content t('hyrax.admin.sidebar.user_activity') }
-    it { is_expected.to have_link t('hyrax.admin.sidebar.profile') }
-    it { is_expected.to have_link t('hyrax.admin.sidebar.notifications') }
-    it { is_expected.to have_link t('hyrax.admin.sidebar.transfers') }
-    it { is_expected.to have_link t('hyrax.admin.sidebar.collections') }
-    it { is_expected.to have_link t('hyrax.admin.sidebar.works') }
-  end
-
-  context 'with a user who can read the admin dash' do
-    let(:read_admin_dashboard) { true }
-
-    before { render }
-    subject { rendered }
-
-    it { is_expected.to have_link t('hyrax.admin.sidebar.statistics') }
-    it { is_expected.to have_link t('hyrax.embargoes.index.manage_embargoes') }
-    it { is_expected.to have_link t('hyrax.leases.index.manage_leases') }
-  end
-
-  context 'with a user who can review submissions' do
-    let(:review_submissions) { true }
-
-    before { render }
-    subject { rendered }
-
-    it { is_expected.to have_link t('hyrax.admin.sidebar.workflow_review') }
-  end
-
-  context 'with a user who can manage users' do
-    let(:manage_user) { true }
-
-    before { render }
-    subject { rendered }
-
-    it { is_expected.to have_link t('hyrax.admin.sidebar.users') }
-  end
-
-  context 'with a user who can update appearance' do
-    let(:update_appearance) { true }
-
-    before { render }
-    subject { rendered }
-
-    it { is_expected.to have_content t('hyrax.admin.sidebar.configuration') }
-    it { is_expected.to have_link t('hyrax.admin.sidebar.appearance') }
-  end
-
-  context 'with a user who can manage features' do
-    let(:manage_feature) { true }
-
-    before { render }
-    subject { rendered }
-
-    it { is_expected.to have_content t('hyrax.admin.sidebar.configuration') }
-    it { is_expected.to have_link t('hyrax.admin.sidebar.pages') }
-    it { is_expected.to have_link t('hyrax.admin.sidebar.content_blocks') }
-    it { is_expected.to have_link t('hyrax.admin.sidebar.technical') }
-  end
-
-  context 'with a user who can manage workflow' do
-    let(:manage_workflow) { true }
-
-    before { render }
-    subject { rendered }
-
-    it { is_expected.to have_content t('hyrax.admin.sidebar.configuration') }
-    it { is_expected.to have_link t('hyrax.admin.sidebar.workflow_roles') }
-  end
-
-  context 'with a user who can manage collection types' do
-    let(:manage_collection_types) { true }
-
-    before { render }
-    subject { rendered }
-
-    it { is_expected.to have_content t('hyrax.admin.sidebar.configuration') }
-    it { is_expected.to have_link t('hyrax.admin.sidebar.collection_types') }
-  end
-
-  context 'when proxy deposits are enabled' do
-    before do
-      allow(Flipflop).to receive(:proxy_deposit?).and_return(true)
-      render
-    end
-
-    subject { rendered }
-
-    it { is_expected.to have_link t('hyrax.dashboard.manage_proxies') }
-  end
-
-  context 'when proxy deposits are disabled' do
-    before do
-      allow(Flipflop).to receive(:proxy_deposit?).and_return(false)
-      render
-    end
-
-    subject { rendered }
-
-    it { is_expected.not_to have_link t('hyrax.dashboard.manage_proxies') }
-  end
-end

data/spec/views/hyrax/dashboard/collections/_default_group.html.erb_spec.rb

@@ -1,43 +0,0 @@
-RSpec.describe 'hyrax/dashboard/collections/_default_group.html.erb', type: :view do
-  let(:ability) { double }
-
-  before do
-    allow(view).to receive(:docs).and_return([])
-    allow(view).to receive(:current_ability).and_return(ability)
-    stub_template 'hyrax/my/_list_collections.html.erb' => 'collection row'
-  end
-
-  context 'Managed Collections' do
-    before do
-      allow(ability).to receive(:admin?).and_return(false)
-      render
-    end
-
-    it 'shows collection table headings' do
-      expect(rendered).to have_text('Title')
-      expect(rendered).to have_text('Access')
-      expect(rendered).to have_text('Type')
-      expect(rendered).to have_text('Visibility')
-      expect(rendered).to have_text('Items')
-      expect(rendered).to have_text('Last modified')
-      expect(rendered).to have_text('Actions')
-    end
-  end
-
-  context 'All Collections' do
-    before do
-      allow(ability).to receive(:admin?).and_return(true)
-      render
-    end
-
-    it "doesn't show access" do
-      expect(rendered).to have_text('Title')
-      expect(rendered).not_to have_text('Access')
-      expect(rendered).to have_text('Type')
-      expect(rendered).to have_text('Visibility')
-      expect(rendered).to have_text('Items')
-      expect(rendered).to have_text('Last modified')
-      expect(rendered).to have_text('Actions')
-    end
-  end
-end

data/spec/views/hyrax/dashboard/collections/_form.html.erb_spec.rb

@@ -1,60 +0,0 @@
-RSpec.describe 'hyrax/dashboard/collections/_form.html.erb', type: :view do
-  let(:collection) { Collection.new }
-  let(:collection_form) { Hyrax::Forms::CollectionForm.new(collection, double, double) }
-  let(:banner_info) { { file: "banner.gif", alttext: "Banner alt text" } }
-  let(:logo_info) { [{ file: "logo.gif", alttext: "Logo alt text", linkurl: "http://abc.com" }] }
-
-  before do
-    allow(collection).to receive(:open_access?).and_return(true)
-    allow(collection).to receive(:authenticated_only_access?).and_return(false)
-    allow(collection).to receive(:private_access?).and_return(false)
-    controller.request.path_parameters[:id] = 'j12345'
-    assign(:form, collection_form)
-    assign(:collection, collection)
-    assign(:banner_info, banner_info)
-    assign(:logo_info, logo_info)
-    # Stub route because view specs don't handle engine routes
-    allow(view).to receive(:collections_path).and_return("/collections")
-    allow(controller).to receive(:current_user).and_return(stub_model(User))
-    allow(collection_form).to receive(:display_additional_fields?).and_return(additional_fields)
-    allow(collection_form).to receive(:discovery).and_return([])
-  end
-
-  context 'with secondary terms' do
-    let(:additional_fields) { true }
-
-    before do
-      render
-    end
-    it "draws the metadata fields for collection" do
-      expect(rendered).to have_selector("input#collection_title")
-      expect(rendered).to have_selector("span.required-tag", text: "required")
-      expect(rendered).not_to have_selector("div#additional_title.multi_value")
-      expect(rendered).to have_selector("input#collection_creator.multi_value")
-      expect(rendered).to have_selector("textarea#collection_description")
-      expect(rendered).to have_selector("input#collection_contributor")
-      expect(rendered).to have_selector("input#collection_keyword")
-      expect(rendered).to have_selector("input#collection_subject")
-      expect(rendered).to have_selector("input#collection_publisher")
-      expect(rendered).to have_selector("input#collection_date_created")
-      expect(rendered).to have_selector("input#collection_language")
-      expect(rendered).to have_selector("input#collection_identifier")
-      expect(rendered).to have_selector("input#collection_based_near")
-      expect(rendered).to have_selector("input#collection_related_url")
-      expect(rendered).to have_selector("select#collection_license")
-      expect(rendered).to have_selector("select#collection_resource_type")
-      expect(rendered).not_to have_selector("input#collection_visibility")
-      expect(rendered).to have_content('Additional fields')
-    end
-  end
-  context 'with no secondary terms' do
-    let(:additional_fields) { false }
-
-    before do
-      render
-    end
-    it 'does not render additional fields button' do
-      expect(rendered).not_to have_content('Additional fields')
-    end
-  end
-end

data/spec/views/hyrax/dashboard/collections/_form_branding.html.erb_spec.rb

@@ -1,23 +0,0 @@
-RSpec.describe 'hyrax/dashboard/collections/_form_branding.html.erb', type: :view do
-  let(:banner_info) { { file: "banner.gif" } }
-  let(:logo_info) { [{ file: "logo.gif", alttext: "Logo alt text", linkurl: "http://abc.com" }] }
-
-  let(:form_builder) { double("FormBuilder", object: form) }
-  let(:form) do
-    instance_double(Hyrax::Forms::CollectionForm,
-                    banner_info: banner_info,
-                    logo_info: logo_info)
-  end
-
-  before do
-    assign(:form, form)
-    render 'hyrax/dashboard/collections/form_branding', f: form_builder
-  end
-
-  it "displays branding information for a collection" do
-    expect(rendered).to include('banner.gif')
-    expect(rendered).to include('logo.gif')
-    expect(rendered).to include('Logo alt text')
-    expect(rendered).to include('http://abc.com')
-  end
-end

data/spec/views/hyrax/dashboard/collections/_form_discovery.erb_spec.rb

@@ -1,67 +0,0 @@
-RSpec.describe 'hyrax/dashboard/collections/_form_discovery.html.erb', type: :view do
-  let(:collection) { Collection.new }
-  let(:collection_form) { Hyrax::Forms::CollectionForm.new(collection, double, double) }
-
-  let(:form) do
-    view.simple_form_for(collection, url: '/update') do |fs_form|
-      return fs_form
-    end
-  end
-
-  context "collection has open access" do
-    before do
-      allow(collection).to receive(:open_access?).and_return(true)
-      allow(collection).to receive(:authenticated_only_access?).and_return(false)
-      allow(collection).to receive(:private_access?).and_return(false)
-      controller.request.path_parameters[:id] = 'j12345'
-      assign(:form, collection_form)
-      assign(:collection, collection)
-      allow(view).to receive(:f).and_return(form)
-      render
-    end
-
-    it "check open access is set" do
-      expect(rendered).to have_selector('input[type=radio][name="collection[visibility]"][value=open][checked=true]')
-      expect(rendered).to have_selector('input[type=radio][name="collection[visibility]"][value=authenticated]')
-      expect(rendered).to have_selector('input[type=radio][name="collection[visibility]"][value=restricted]')
-    end
-  end
-
-  context "collection has authenticated access" do
-    before do
-      allow(collection).to receive(:open_access?).and_return(false)
-      allow(collection).to receive(:authenticated_only_access?).and_return(true)
-      allow(collection).to receive(:private_access?).and_return(false)
-      controller.request.path_parameters[:id] = 'j12345'
-      assign(:form, collection_form)
-      assign(:collection, collection)
-      allow(view).to receive(:f).and_return(form)
-      render
-    end
-
-    it "check authenticated access is set" do
-      expect(rendered).to have_selector('input[type=radio][name="collection[visibility]"][value=open]')
-      expect(rendered).to have_selector('input[type=radio][name="collection[visibility]"][value=authenticated][checked=true]')
-      expect(rendered).to have_selector('input[type=radio][name="collection[visibility]"][value=restricted]')
-    end
-  end
-
-  context "collection has restricted access" do
-    before do
-      allow(collection).to receive(:open_access?).and_return(false)
-      allow(collection).to receive(:authenticated_only_access?).and_return(false)
-      allow(collection).to receive(:private_access?).and_return(true)
-      controller.request.path_parameters[:id] = 'j12345'
-      assign(:form, collection_form)
-      assign(:collection, collection)
-      allow(view).to receive(:f).and_return(form)
-      render
-    end
-
-    it "check restricted access is set" do
-      expect(rendered).to have_selector('input[type=radio][name="collection[visibility]"][value=open]')
-      expect(rendered).to have_selector('input[type=radio][name="collection[visibility]"][value=authenticated]')
-      expect(rendered).to have_selector('input[type=radio][name="collection[visibility]"][value=restricted][checked=true]')
-    end
-  end
-end

data/spec/views/hyrax/dashboard/collections/_form_for_select_collection.html.erb_spec.rb

@@ -1,47 +0,0 @@
-RSpec.describe 'hyrax/dashboard/collections/_form_for_select_collection.html.erb', type: :view do
-  let(:collections) do
-    [
-      { id: 1234, create_date: Time.zone.parse('Thu, 13 Aug 2015 14:20:22 +0100') },
-      { id: 1235, create_date: Time.zone.parse('Thu, 13 Aug 2015 14:18:22 +0100') },
-      { id: 1236, create_date: Time.zone.parse('Thu, 13 Aug 2015 14:16:22 +0100') },
-      { id: 1237, create_date: Time.zone.parse('Thu, 13 Aug 2015 14:29:22 +0100') }
-    ]
-  end
-  let(:solr_collections) do
-    collections.map do |c|
-      doc = { id: c[:id],
-              "has_model_ssim" => ["Collection"],
-              "title_tesim" => ["Title 1"],
-              "system_create_dtsi" => c[:create_date].to_s }
-      SolrDocument.new(doc)
-    end
-  end
-
-  let(:page) { Capybara::Node::Simple.new(rendered) }
-
-  before do
-    # Stub route because view specs don't handle engine routes
-    allow(view).to receive(:collection_path).and_return("/collection/123")
-    allow(view).to receive(:new_dashboard_collection_path).and_return("/collection/new")
-
-    allow(view).to receive(:user_collections).and_return(solr_collections)
-  end
-
-  it "uses autocomplete" do
-    render
-    expect(page).to have_selector('input[data-autocomplete-url="/authorities/search/collections?access=deposit"]')
-  end
-
-  context 'when a collection is specified' do
-    let(:collection_id) { collections[2][:id] }
-    let(:collection_label) { collections[2]["title_tesim"] }
-
-    it "selects the right collection when instructed to do so" do
-      assign(:add_works_to_collection, collection_id)
-      assign(:add_works_to_collection_label, collection_label)
-      render
-      expect(page).to have_selector "#member_of_collection_ids[value=\"#{collection_id}\"]", visible: false
-      expect(page).to have_selector "#member_of_collection_label", text: collection_label
-    end
-  end
-end

data/spec/views/hyrax/dashboard/collections/_form_share.erb_spec.rb

@@ -1,22 +0,0 @@
-RSpec.describe 'hyrax/dashboard/collections/_form_share.html.erb', type: :view do
-  let(:template) { stub_model(Hyrax::PermissionTemplate) }
-  let(:pt_form) do
-    instance_double(Hyrax::Forms::PermissionTemplateForm,
-                    model_name: template.model_name,
-                    to_key: template.to_key,
-                    access_grants: template.access_grants)
-  end
-  let(:collection) { stub_model(Collection, share_applies_to_new_works?: false) }
-
-  before do
-    assign(:collection, collection)
-    @form = instance_double(Hyrax::Forms::CollectionForm,
-                            to_model: collection,
-                            permission_template: pt_form,
-                            id: '1234xyz')
-    render
-  end
-  it "has the required selectors" do
-    expect(rendered).to have_selector('#participants #user-participants-form input[type=text]')
-  end
-end

data/spec/views/hyrax/dashboard/collections/_form_share_table.html.erb_spec.rb

@@ -1,108 +0,0 @@
-RSpec.describe 'hyrax/dashboard/collections/_form_share_table.html.erb', type: :view do
-  let(:template) { stub_model(Hyrax::PermissionTemplate) }
-  let(:user) { create(:user) }
-  let(:access_grant) { stub_model(Hyrax::PermissionTemplateAccess) }
-  let(:collection) { stub_model(Collection, share_applies_to_new_works?: false) }
-  let(:pt_form) do
-    instance_double(Hyrax::Forms::PermissionTemplateForm,
-                    model_name: template.model_name,
-                    to_key: template.to_key,
-                    access_grants: [access_grant])
-  end
-
-  before do
-    assign(:collection, collection)
-    @form = instance_double(Hyrax::Forms::CollectionForm,
-                            to_model: stub_model(Collection),
-                            permission_template: pt_form)
-    # Ignore the delete button link
-    allow(view).to receive(:admin_permission_template_access_path).and_return("/admin/permission_template_accesses/123")
-  end
-
-  describe "Manager shares table" do
-    before do
-      render 'form_share_table', access: "managers", filter: :manage?
-    end
-
-    context "managers exist" do
-      let(:access_grant) do
-        stub_model(Hyrax::PermissionTemplateAccess,
-                   agent_type: 'user',
-                   agent_id: user.user_key,
-                   access: 'manage')
-      end
-
-      it "lists the managers in the table" do
-        expect(rendered).to have_selector("h3", text: "Managers")
-        expect(rendered).to have_selector("table tbody", text: user.user_key)
-      end
-    end
-    context "no managers exist" do
-      let(:access_grant) { stub_model(Hyrax::PermissionTemplateAccess) }
-
-      it "displays a message and no table" do
-        expect(rendered).to have_selector("h3", text: "Managers")
-        expect(rendered).not_to have_selector("table")
-        expect(rendered).to have_content("No managers have been added to this collection.")
-      end
-    end
-  end
-
-  describe "Viewer shares table" do
-    before do
-      render 'form_share_table', access: "viewers", filter: :view?
-    end
-
-    context "viewers exist" do
-      let(:access_grant) do
-        stub_model(Hyrax::PermissionTemplateAccess,
-                   agent_type: 'user',
-                   agent_id: user.user_key,
-                   access: 'view')
-      end
-
-      it "lists the viewers in the table" do
-        expect(rendered).to have_selector("h3", text: "Viewers")
-        expect(rendered).to have_selector("table tbody", text: user.user_key)
-      end
-    end
-    context "no viewers exist" do
-      let(:access_grant) { stub_model(Hyrax::PermissionTemplateAccess) }
-
-      it "displays a message and no table" do
-        expect(rendered).to have_selector("h3", text: "Viewers")
-        expect(rendered).not_to have_selector("table")
-        expect(rendered).to have_content("No viewers have been added to this collection.")
-      end
-    end
-  end
-
-  describe "Depositor shares table" do
-    before do
-      render 'form_share_table', access: "depositors", filter: :deposit?
-    end
-
-    context "depositors exist" do
-      let(:access_grant) do
-        stub_model(Hyrax::PermissionTemplateAccess,
-                   agent_type: 'user',
-                   agent_id: user.user_key,
-                   access: 'deposit')
-      end
-
-      it "lists the depositors in the table" do
-        expect(rendered).to have_selector("h3", text: "Depositors")
-        expect(rendered).to have_selector("table tbody", text: user.user_key)
-      end
-    end
-    context "no depositors exist" do
-      let(:access_grant) { stub_model(Hyrax::PermissionTemplateAccess) }
-
-      it "displays a message and no table" do
-        expect(rendered).to have_selector("h3", text: "Depositors")
-        expect(rendered).not_to have_selector("table")
-        expect(rendered).to have_content("No depositors have been added to this collection.")
-      end
-    end
-  end
-end