hyrax 2.6.0 → 2.7.0

data/spec/actors/hyrax/actors/create_with_files_actor_spec.rb

@@ -1,60 +0,0 @@
-RSpec.describe Hyrax::Actors::CreateWithFilesActor do
-  let(:user) { create(:user) }
-  let(:ability) { ::Ability.new(user) }
-  let(:work) { create(:generic_work, user: user) }
-  let(:env) { Hyrax::Actors::Environment.new(work, ability, attributes) }
-  let(:terminator) { Hyrax::Actors::Terminator.new }
-  let(:uploaded_file1) { create(:uploaded_file, user: user) }
-  let(:uploaded_file2) { create(:uploaded_file, user: user) }
-  let(:uploaded_file_ids) { [uploaded_file1.id, uploaded_file2.id] }
-  let(:attributes) { { uploaded_files: uploaded_file_ids } }
-
-  subject(:middleware) do
-    stack = ActionDispatch::MiddlewareStack.new.tap do |middleware|
-      middleware.use described_class
-    end
-    stack.build(terminator)
-  end
-
-  [:create, :update].each do |mode|
-    context "on #{mode}" do
-      before do
-        allow(terminator).to receive(mode).and_return(true)
-      end
-      context "when uploaded_file_ids include nil" do
-        let(:uploaded_file_ids) { [nil, uploaded_file1.id, nil] }
-
-        it "will discard those nil values when attempting to find the associated UploadedFile" do
-          expect(AttachFilesToWorkJob).to receive(:perform_later)
-          expect(Hyrax::UploadedFile).to receive(:find).with([uploaded_file1.id]).and_return([uploaded_file1])
-          middleware.public_send(mode, env)
-        end
-      end
-
-      context "when uploaded_file_ids belong to me" do
-        it "attaches files" do
-          expect(AttachFilesToWorkJob).to receive(:perform_later).with(GenericWork, [uploaded_file1, uploaded_file2], {})
-          expect(middleware.public_send(mode, env)).to be true
-        end
-      end
-
-      context "when uploaded_file_ids don't belong to me" do
-        let(:uploaded_file2) { create(:uploaded_file) }
-
-        it "doesn't attach files" do
-          expect(AttachFilesToWorkJob).not_to receive(:perform_later)
-          expect(middleware.public_send(mode, env)).to be false
-        end
-      end
-
-      context "when no uploaded_file" do
-        let(:attributes) { {} }
-
-        it "doesn't invoke job" do
-          expect(AttachFilesToWorkJob).not_to receive(:perform_later)
-          expect(middleware.public_send(mode, env)).to be true
-        end
-      end
-    end
-  end
-end

data/spec/actors/hyrax/actors/create_with_files_ordered_members_actor_spec.rb

@@ -1,41 +0,0 @@
-RSpec.describe Hyrax::Actors::CreateWithFilesOrderedMembersActor do
-  let(:user) { create(:user) }
-  let(:ability) { ::Ability.new(user) }
-  let(:work) { create(:generic_work, user: user) }
-  let(:env) { Hyrax::Actors::Environment.new(work, ability, attributes) }
-  let(:terminator) { Hyrax::Actors::Terminator.new }
-  let(:uploaded_file1) { create(:uploaded_file, user: user) }
-  let(:uploaded_file2) { create(:uploaded_file, user: user) }
-  let(:uploaded_file_ids) { [uploaded_file1.id, uploaded_file2.id] }
-  let(:attributes) { { uploaded_files: uploaded_file_ids } }
-
-  subject(:middleware) do
-    stack = ActionDispatch::MiddlewareStack.new.tap do |middleware|
-      middleware.use described_class
-    end
-    stack.build(terminator)
-  end
-
-  [:create, :update].each do |mode|
-    context "on #{mode}" do
-      before do
-        allow(terminator).to receive(mode).and_return(true)
-      end
-      context "when uploaded_file" do
-        it "invoke the job" do
-          expect(AttachFilesToWorkWithOrderedMembersJob).to receive(:perform_later)
-          middleware.public_send(mode, env)
-        end
-      end
-
-      context "when no uploaded_file" do
-        let(:uploaded_file_ids) { [] }
-
-        it "doesn't invoke job" do
-          expect(AttachFilesToWorkWithOrderedMembersJob).not_to receive(:perform_later)
-          expect(middleware.public_send(mode, env)).to be true
-        end
-      end
-    end
-  end
-end

data/spec/actors/hyrax/actors/create_with_remote_files_actor_spec.rb

@@ -1,136 +0,0 @@
-RSpec.describe Hyrax::Actors::CreateWithRemoteFilesActor do
-  let(:terminator) { Hyrax::Actors::Terminator.new }
-  let(:actor) { stack.build(terminator) }
-  let(:stack) do
-    ActionDispatch::MiddlewareStack.new.tap do |middleware|
-      middleware.use described_class
-    end
-  end
-  let(:user) { create(:user) }
-  let(:ability) { Ability.new(user) }
-  let(:work) { create(:generic_work, user: user) }
-  let(:url1) { "https://dl.dropbox.com/fake/blah-blah.filepicker-demo.txt.txt" }
-  let(:url2) { "https://dl.dropbox.com/fake/blah-blah.Getting%20Started.pdf" }
-  let(:file) { "file:///local/file/here.txt" }
-
-  let(:remote_files) do
-    [{ url: url1,
-       expires: "2014-03-31T20:37:36.214Z",
-       file_name: "filepicker-demo.txt.txt" },
-     { url: url2,
-       expires: "2014-03-31T20:37:36.731Z",
-       file_name: "Getting+Started.pdf" }]
-  end
-  let(:attributes) { { remote_files: remote_files } }
-  let(:environment) { Hyrax::Actors::Environment.new(work, ability, attributes) }
-
-  before do
-    allow(terminator).to receive(:create).and_return(true)
-  end
-
-  context "with source uris that are remote" do
-    let(:remote_files) do
-      [{ url: url1,
-         expires: "2014-03-31T20:37:36.214Z",
-         file_name: "filepicker-demo.txt.txt" },
-       { url: url2,
-         expires: "2014-03-31T20:37:36.731Z",
-         file_name: "Getting+Started.pdf" }]
-    end
-
-    it "attaches files" do
-      expect(ImportUrlJob).to receive(:perform_later).with(FileSet, Hyrax::Operation, {}).twice
-      expect(actor.create(environment)).to be true
-    end
-  end
-
-  context "with source URIs that are remote and contain encoded parameters" do
-    let(:url1) { "https://dl.dropbox.com/fake/file?param1=%28example%29&param2=%5Bexample2%5D" }
-
-    before do
-      allow(::FileSet).to receive(:new).and_call_original
-    end
-
-    it "preserves the encoded parameters in the URIs" do
-      expect(ImportUrlJob).to receive(:perform_later).with(FileSet, Hyrax::Operation, {}).twice
-      expect(actor.create(environment)).to be true
-      expect(::FileSet).to have_received(:new).with(import_url: "https://dl.dropbox.com/fake/file?param1=%28example%29&param2=%5Bexample2%5D", label: "filepicker-demo.txt.txt")
-    end
-  end
-
-  context "with source uris that are remote bearing auth headers" do
-    let(:remote_files) do
-      [{ url: url1,
-         expires: "2014-03-31T20:37:36.214Z",
-         file_name: "filepicker-demo.txt.txt",
-         auth_header: { 'Authorization' => 'Bearer access-token' } },
-       { url: url2,
-         expires: "2014-03-31T20:37:36.731Z",
-         file_name: "Getting+Started.pdf",
-         auth_header: { 'Authorization' => 'Bearer access-token' } }]
-    end
-
-    it "attaches files" do
-      expect(ImportUrlJob).to receive(:perform_later).with(FileSet, Hyrax::Operation, 'Authorization' => 'Bearer access-token').twice
-      expect(actor.create(environment)).to be true
-    end
-  end
-
-  context "with source uris that are local files" do
-    let(:remote_files) do
-      [{ url: file,
-         expires: "2014-03-31T20:37:36.214Z",
-         file_name: "here.txt" }]
-    end
-
-    before do
-      allow(Hyrax.config).to receive(:whitelisted_ingest_dirs).and_return(["/local/file/"])
-    end
-
-    it "attaches files" do
-      expect(IngestLocalFileJob).to receive(:perform_later).with(FileSet, "/local/file/here.txt", user)
-      expect(actor.create(environment)).to be true
-    end
-
-    context "with files from non-whitelisted directories" do
-      let(:file) { "file:///local/otherdir/test.txt" }
-
-      it "doesn't attach files" do
-        expect(actor).to receive(:validate_remote_url).and_call_original
-        expect(IngestLocalFileJob).not_to receive(:perform_later)
-        expect(actor.create(environment)).to be false
-      end
-    end
-
-    context "with spaces" do
-      let(:file) { "file:///local/file/ pigs .txt" }
-
-      it "attaches files" do
-        expect(IngestLocalFileJob).to receive(:perform_later).with(FileSet, "/local/file/ pigs .txt", user)
-        expect(actor.create(environment)).to be true
-      end
-    end
-  end
-
-  describe "#validate_remote_url" do
-    before do
-      allow(Hyrax.config).to receive(:whitelisted_ingest_dirs).and_return(['/test/', '/local/file/'])
-    end
-
-    it "accepts file: urls in whitelisted directories" do
-      expect(actor.send(:validate_remote_url, URI('file:///local/file/test.txt'))).to be true
-      expect(actor.send(:validate_remote_url, URI('file:///local/file/subdirectory/test.txt'))).to be true
-      expect(actor.send(:validate_remote_url, URI('file:///test/test.txt'))).to be true
-    end
-
-    it "rejects file: urls outside whitelisted directories" do
-      expect(actor.send(:validate_remote_url, URI('file:///tmp/test.txt'))).to be false
-      expect(actor.send(:validate_remote_url, URI('file:///test/../tmp/test.txt'))).to be false
-      expect(actor.send(:validate_remote_url, URI('file:///test/'))).to be false
-    end
-
-    it "accepts other types of urls" do
-      expect(actor.send(:validate_remote_url, URI('https://example.com/test.txt'))).to be true
-    end
-  end
-end

data/spec/actors/hyrax/actors/create_with_remote_files_ordered_members_actor_spec.rb

@@ -1,49 +0,0 @@
-RSpec.describe Hyrax::Actors::CreateWithRemoteFilesOrderedMembersActor do
-  let(:terminator) { Hyrax::Actors::Terminator.new }
-  let(:actor) { stack.build(terminator) }
-  let(:stack) do
-    ActionDispatch::MiddlewareStack.new.tap do |middleware|
-      middleware.use described_class
-    end
-  end
-  let(:user) { create(:user) }
-  let(:ability) { Ability.new(user) }
-  let(:work) { create(:generic_work, user: user) }
-  let(:url1) { "https://dl.dropbox.com/fake/blah-blah.filepicker-demo.txt.txt" }
-  let(:url2) { "https://dl.dropbox.com/fake/blah-blah.Getting%20Started.pdf" }
-
-  let(:remote_files) do
-    [{ url: url1,
-       expires: "2014-03-31T20:37:36.214Z",
-       file_name: "filepicker-demo.txt.txt" },
-     { url: url2,
-       expires: "2014-03-31T20:37:36.731Z",
-       file_name: "Getting+Started.pdf" }]
-  end
-  let(:attributes) { { remote_files: remote_files } }
-  let(:environment) { Hyrax::Actors::Environment.new(work, ability, attributes) }
-
-  before do
-    allow(terminator).to receive(:create).and_return(true)
-  end
-
-  context "with two file_sets" do
-    let(:remote_files) do
-      [{ url: url1,
-         expires: "2014-03-31T20:37:36.214Z",
-         file_name: "filepicker-demo.txt.txt" },
-       { url: url2,
-         expires: "2014-03-31T20:37:36.731Z",
-         file_name: "Getting+Started.pdf" }]
-    end
-
-    it "attaches files and passes ordered_members to OrderedMembersActor in correct order" do
-      expect(Hyrax::Actors::OrderedMembersActor).to receive(:new).with([FileSet, FileSet], user).and_return(Hyrax::Actors::OrderedMembersActor)
-      expect(Hyrax::Actors::OrderedMembersActor).to receive(:attach_ordered_members_to_work).with(work)
-      expect(ImportUrlJob).to receive(:perform_later).with(FileSet, Hyrax::Operation, {}).twice
-      expect(actor.create(environment)).to be true
-      expect(actor.ordered_members.first.label).to eq('filepicker-demo.txt.txt')
-      expect(actor.ordered_members.last.label).to eq('Getting+Started.pdf')
-    end
-  end
-end

data/spec/actors/hyrax/actors/default_admin_set_actor_spec.rb

@@ -1,81 +0,0 @@
-RSpec.describe Hyrax::Actors::DefaultAdminSetActor do
-  let(:depositor) { create(:user) }
-  let(:depositor_ability) { ::Ability.new(depositor) }
-  let(:work) { build(:generic_work) }
-  let(:admin_set) { build(:admin_set, id: 'admin_set_1') }
-  let(:permission_template) { create(:permission_template, source_id: admin_set.id) }
-  let(:env) { Hyrax::Actors::Environment.new(work, depositor_ability, attributes) }
-
-  let(:terminator) { Hyrax::Actors::Terminator.new }
-
-  subject(:middleware) do
-    stack = ActionDispatch::MiddlewareStack.new.tap do |middleware|
-      middleware.use described_class
-    end
-    stack.build(terminator)
-  end
-
-  describe "#create" do
-    context "when admin_set_id is blank" do
-      let(:attributes) { { admin_set_id: '' } }
-      let(:default_id) { AdminSet::DEFAULT_ID }
-
-      it "creates the default AdminSet with a PermissionTemplate and an ActiveWorkflow then calls the next actor with the default admin set id" do
-        expect(terminator).to receive(:create).with(Hyrax::Actors::Environment) do |k|
-          expect(k.attributes).to eq("admin_set_id" => default_id)
-          true
-        end
-        expect(AdminSet).to receive(:find_or_create_default_admin_set_id).and_return(default_id)
-        middleware.create(env)
-      end
-    end
-
-    context "when admin_set_id is provided" do
-      let(:attributes) { { admin_set_id: admin_set.id } }
-
-      it "uses the provided id, ensures a permission template, and returns true" do
-        expect(terminator).to receive(:create).with(Hyrax::Actors::Environment) do |k|
-          expect(k.attributes).to eq("admin_set_id" => admin_set.id)
-          true
-        end
-        expect(AdminSet).not_to receive(:find_or_create_default_admin_set_id)
-        expect do
-          expect(middleware.create(env)).to be true
-        end.to change { Hyrax::PermissionTemplate.count }.by(1)
-      end
-    end
-  end
-
-  describe '#update' do
-    before do
-      work.admin_set_id = admin_set.id
-    end
-    context "when admin_set_id is missing" do
-      let(:attributes) { { title: 'new title' } }
-      let(:default_id) { AdminSet::DEFAULT_ID }
-
-      it "gets the admin set id fro the work" do
-        expect(terminator).to receive(:update).with(Hyrax::Actors::Environment) do |k|
-          expect(k.attributes).to eq('title' => 'new title', 'admin_set_id' => admin_set.id)
-          true
-        end
-        expect(AdminSet).not_to receive(:find_or_create_default_admin_set_id)
-        expect(middleware.update(env)).to be true
-      end
-    end
-
-    context "when admin_set_id is provided" do
-      let(:admin_set2) { build(:admin_set, id: 'admin_set_2') }
-      let(:attributes) { { title: 'new title', admin_set_id: admin_set2.id } }
-
-      it "uses the provided id, ensures a permission template, and returns true" do
-        expect(terminator).to receive(:update).with(Hyrax::Actors::Environment) do |k|
-          expect(k.attributes).to eq('title' => 'new title', 'admin_set_id' => admin_set2.id)
-          true
-        end
-        expect(AdminSet).not_to receive(:find_or_create_default_admin_set_id)
-        expect(middleware.update(env)).to be true
-      end
-    end
-  end
-end

data/spec/actors/hyrax/actors/embargo_actor_spec.rb

@@ -1,37 +0,0 @@
-RSpec.describe Hyrax::Actors::EmbargoActor do
-  let(:actor) { described_class.new(work) }
-
-  let(:work) do
-    GenericWork.new do |work|
-      work.apply_depositor_metadata 'foo'
-      work.title = ["test"]
-      work.visibility = Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_AUTHENTICATED
-      work.visibility_during_embargo = Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_AUTHENTICATED
-      work.visibility_after_embargo = Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PUBLIC
-      work.embargo_release_date = release_date.to_s
-      work.save(validate: false)
-    end
-  end
-
-  describe "#destroy" do
-    context "with an active embargo" do
-      let(:release_date) { Time.zone.today + 2 }
-
-      it "removes the embargo" do
-        actor.destroy
-        expect(work.reload.embargo_release_date).to be_nil
-        expect(work.visibility).to eq Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_AUTHENTICATED
-      end
-    end
-
-    context 'with an expired embargo' do
-      let(:release_date) { Time.zone.today - 2 }
-
-      it "removes the embargo" do
-        actor.destroy
-        expect(work.reload.embargo_release_date).to be_nil
-        expect(work.visibility).to eq Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PUBLIC
-      end
-    end
-  end
-end

data/spec/actors/hyrax/actors/featured_work_actor_spec.rb

@@ -1,38 +0,0 @@
-RSpec.describe Hyrax::Actors::FeaturedWorkActor do
-  let(:ability) { ::Ability.new(depositor) }
-  let(:env) { Hyrax::Actors::Environment.new(work, ability, attributes) }
-  let(:terminator) { Hyrax::Actors::Terminator.new }
-  let(:depositor) { create(:user) }
-  let(:work) { create(:work) }
-  let(:attributes) { {} }
-  let!(:feature) { FeaturedWork.create(work_id: work.id) }
-
-  subject(:middleware) do
-    stack = ActionDispatch::MiddlewareStack.new.tap do |middleware|
-      middleware.use described_class
-    end
-    stack.build(terminator)
-  end
-
-  describe "#destroy" do
-    it 'removes all the features' do
-      expect { middleware.destroy(env) }.to change { FeaturedWork.where(work_id: work.id).count }.from(1).to(0)
-    end
-  end
-
-  describe "#update" do
-    context "of a public work" do
-      let(:work) { create(:public_work) }
-
-      it "does not modify the features" do
-        expect { middleware.update(env) }.not_to change { FeaturedWork.where(work_id: work.id).count }
-      end
-    end
-
-    context "of a private work" do
-      it "removes the features" do
-        expect { middleware.update(env) }.to change { FeaturedWork.where(work_id: work.id).count }.from(1).to(0)
-      end
-    end
-  end
-end