hyrax 2.6.0 → 2.7.0

data/spec/services/hyrax/collections_service_spec.rb

@@ -1,62 +0,0 @@
-RSpec.describe Hyrax::CollectionsService do
-  let(:controller) { ::CatalogController.new }
-
-  let(:context) do
-    double(current_ability: Ability.new(user1),
-           repository: controller.repository,
-           blacklight_config: controller.blacklight_config)
-  end
-
-  let(:service) { described_class.new(context) }
-  let(:user1) { build(:user) }
-
-  describe "#search_results", :clean_repo do
-    subject { service.search_results(access) }
-
-    let(:user2) { build(:user) }
-    let!(:collection1) do
-      build(:private_collection_lw, id: 'col-1-own', title: ['user1 created'], user: user1,
-                                    with_permission_template: true, with_solr_document: true)
-    end
-    let!(:collection2) do
-      build(:private_collection_lw, id: 'col-2-mgr', title: ['user2 shares manage access with user1'], user: user2,
-                                    with_permission_template: { manage_users: [user1] }, with_solr_document: true)
-    end
-    let!(:collection3) do
-      build(:private_collection_lw, id: 'col-3-dep', title: ['user2 shares deposit access with user1'], user: user2,
-                                    with_permission_template: { deposit_users: [user1] }, with_solr_document: true)
-    end
-    let!(:collection4) do
-      build(:private_collection_lw, id: 'col-4-view', title: ['user2 shares view access with user1'], user: user2,
-                                    with_permission_template: { view_users: [user1] }, with_solr_document: true)
-    end
-
-    before do
-      create(:admin_set, id: 'as-1', read_groups: ['public']) # this should never be returned.
-    end
-
-    context "with read access" do
-      let(:access) { :read }
-
-      it "returns four collections" do
-        expect(subject.map(&:id)).to match_array [collection1.id, collection2.id, collection3.id, collection4.id]
-      end
-    end
-
-    context "with edit access" do
-      let(:access) { :edit }
-
-      it "returns two collections" do
-        expect(subject.map(&:id)).to match_array [collection1.id, collection2.id]
-      end
-    end
-
-    context "with deposit access" do
-      let(:access) { :deposit }
-
-      it "returns one collections" do
-        expect(subject.map(&:id)).to match_array [collection1.id, collection2.id, collection3.id]
-      end
-    end
-  end
-end

data/spec/services/hyrax/curation_concern_spec.rb

@@ -1,18 +0,0 @@
-RSpec.describe Hyrax::CurationConcern do
-  let(:work) { GenericWork.new }
-  let(:user) { double(current_user: double) }
-
-  describe ".actor" do
-    subject { described_class.actor }
-
-    it { is_expected.to be_kind_of Hyrax::Actors::TransactionalRequest }
-  end
-
-  describe ".actor_factory" do
-    subject { described_class.actor_factory }
-
-    it "returns same ActionDispatch::MiddlewareStack instance" do
-      is_expected.to eq described_class.actor_factory
-    end
-  end
-end

data/spec/services/hyrax/database_migrator_spec.rb

@@ -1,20 +0,0 @@
-RSpec.describe Hyrax::DatabaseMigrator do
-  describe '.copy' do
-    let(:mock_migrator) { double }
-
-    it 'creates an instance and calls #copy' do
-      expect(described_class).to receive(:new).once.and_return(mock_migrator)
-      expect(mock_migrator).to receive(:copy).once
-      described_class.copy
-    end
-  end
-
-  describe '#copy' do
-    let(:migrations_count) { subject.send(:migrations).count }
-
-    it 'uses #migration_template to copy all migrations to app' do
-      expect(subject).to receive(:migration_template).exactly(migrations_count).times
-      subject.copy
-    end
-  end
-end

data/spec/services/hyrax/default_middleware_stack_spec.rb

@@ -1,36 +0,0 @@
-RSpec.describe Hyrax::DefaultMiddlewareStack do
-  let(:work) { GenericWork.new }
-  let(:user) { double(current_user: double) }
-
-  describe '.build_stack' do
-    subject { described_class.build_stack }
-
-    it "has the correct stack frames" do
-      expect(subject.middlewares).to eq [
-        Hyrax::Actors::TransactionalRequest,
-        Hyrax::Actors::OptimisticLockValidator,
-        Hyrax::Actors::CreateWithRemoteFilesActor,
-        Hyrax::Actors::CreateWithFilesActor,
-        Hyrax::Actors::CollectionsMembershipActor,
-        Hyrax::Actors::AddToWorkActor,
-        Hyrax::Actors::AttachMembersActor,
-        Hyrax::Actors::ApplyOrderActor,
-        Hyrax::Actors::DefaultAdminSetActor,
-        Hyrax::Actors::InterpretVisibilityActor,
-        Hyrax::Actors::TransferRequestActor,
-        Hyrax::Actors::ApplyPermissionTemplateActor,
-        Hyrax::Actors::CleanupFileSetsActor,
-        Hyrax::Actors::CleanupTrophiesActor,
-        Hyrax::Actors::FeaturedWorkActor,
-        Hyrax::Actors::ModelActor,
-        Hyrax::Actors::InitializeWorkflowActor
-      ]
-    end
-  end
-
-  describe 'Hyrax::CurationConcern.actor' do
-    it "calls the Hyrax::ActorFactory" do
-      expect(Hyrax::CurationConcern.actor).to be_instance_of Hyrax::Actors::TransactionalRequest
-    end
-  end
-end

data/spec/services/hyrax/derivative_path_spec.rb

@@ -1,65 +0,0 @@
-RSpec.describe Hyrax::DerivativePath do
-  let(:id)     { '123' }
-  let(:object) { double(id: id) }
-
-  before { allow(Hyrax.config).to receive(:derivatives_path).and_return('tmp') }
-
-  context "for a single path" do
-    let(:destination_name) { 'thumbnail' }
-
-    describe '.derivative_path_for_reference' do
-      subject { described_class.derivative_path_for_reference(object, destination_name) }
-
-      it { is_expected.to eq('tmp/12/3-thumbnail.jpeg') }
-    end
-
-    describe '#derivative_path' do
-      context "with an object" do
-        subject { described_class.new(object, destination_name).derivative_path }
-
-        it { is_expected.to eq('tmp/12/3-thumbnail.jpeg') }
-      end
-
-      context "with an id" do
-        subject { described_class.new(id, destination_name).derivative_path }
-
-        it { is_expected.to eq('tmp/12/3-thumbnail.jpeg') }
-      end
-    end
-  end
-
-  context "for multiple paths" do
-    before do
-      FileUtils.mkdir_p("tmp/12")
-      File.open("tmp/12/3-thumbnail.jpeg", 'w') do |f|
-        f.write "test"
-      end
-      File.open("tmp/12/4-thumbnail.jpeg", 'w') do |f|
-        f.write "test"
-      end
-    end
-    after do
-      FileUtils.rm_rf("tmp/12")
-    end
-
-    describe ".derivatives_for_reference" do
-      subject { described_class.derivatives_for_reference(object) }
-
-      it { is_expected.to eq(["tmp/12/3-thumbnail.jpeg"]) }
-    end
-
-    describe "#all_paths" do
-      context "with an object" do
-        subject { described_class.new(object, nil).all_paths }
-
-        it { is_expected.to eq(["tmp/12/3-thumbnail.jpeg"]) }
-      end
-
-      context "with an id" do
-        subject { described_class.new(id, nil).all_paths }
-
-        it { is_expected.to eq(["tmp/12/3-thumbnail.jpeg"]) }
-      end
-    end
-  end
-end

data/spec/services/hyrax/derivative_service_spec.rb

@@ -1,49 +0,0 @@
-require 'hyrax/specs/shared_specs'
-
-RSpec.describe Hyrax::DerivativeService do
-  let(:valid_file_set) { FileSet.new }
-
-  subject { described_class.new(file_set) }
-
-  it_behaves_like "a Hyrax::DerivativeService"
-  before do
-    @cached_services = described_class.services
-  end
-  after do
-    described_class.services = @cached_services
-  end
-
-  describe ".services=" do
-    it "allows you to set the available services" do
-      described_class.services = [Hyrax::FileSetDerivativesService, Hyrax::FileSetDerivativesService]
-      expect(described_class.services).to eq [Hyrax::FileSetDerivativesService, Hyrax::FileSetDerivativesService]
-    end
-    it "defaults to an array" do
-      expect(described_class.services).to eq [Hyrax::FileSetDerivativesService]
-    end
-  end
-
-  describe ".for" do
-    before do
-      described_class.services = [Hyrax::FileSetDerivativesService]
-    end
-    context "when a FileSet matches the requirements of a service" do
-      let(:file_set) do
-        FileSet.new.tap do |f|
-          allow(f).to receive(:mime_type).and_return(FileSet.image_mime_types.first)
-        end
-      end
-
-      it "returns it" do
-        expect(described_class.for(file_set)).to be_instance_of Hyrax::FileSetDerivativesService
-      end
-    end
-    context "when a FileSet matches no services" do
-      let(:file_set) { FileSet.new }
-
-      it "returns a base DerivativeService" do
-        expect(described_class.for(file_set)).to be_instance_of described_class
-      end
-    end
-  end
-end

data/spec/services/hyrax/embargo_service_spec.rb

@@ -1,59 +0,0 @@
-RSpec.describe Hyrax::EmbargoService do
-  subject { described_class }
-
-  let(:future_date) { 2.days.from_now }
-  let(:past_date) { 2.days.ago }
-
-  let!(:work_with_expired_embargo1) do
-    build(:work, embargo_release_date: past_date.to_s).tap do |work|
-      work.save(validate: false)
-    end
-  end
-
-  let!(:work_with_expired_embargo2) do
-    build(:work, embargo_release_date: past_date.to_s).tap do |work|
-      work.save(validate: false)
-    end
-  end
-
-  let!(:work_with_embargo_in_effect) { create(:work, embargo_release_date: future_date.to_s) }
-  let!(:work_without_embargo) { create(:generic_work) }
-
-  describe '#assets_with_expired_embargoes' do
-    it 'returns an array of assets with expired embargoes' do
-      returned_pids = subject.assets_with_expired_embargoes.map(&:id)
-      expect(returned_pids).to include work_with_expired_embargo1.id, work_with_expired_embargo2.id
-      expect(returned_pids).not_to include work_with_embargo_in_effect.id, work_without_embargo.id
-    end
-  end
-
-  describe '#assets_under_embargo' do
-    it 'returns all assets with embargo release date set' do
-      returned_pids = subject.assets_under_embargo.map(&:id)
-      expect(returned_pids).to include work_with_expired_embargo1.id, work_with_expired_embargo2.id, work_with_embargo_in_effect.id
-      expect(returned_pids).not_to include work_without_embargo.id
-    end
-  end
-
-  describe '#assets_with_deactivated_embargoes' do
-    let(:id) { Noid::Rails::Service.new.mint }
-    let(:attributes) do
-      { 'embargo_history_ssim' => ['This is in the past'],
-        'id' => id }
-    end
-
-    before do
-      ActiveFedora::SolrService.add(attributes)
-      ActiveFedora::SolrService.commit
-    end
-
-    it 'returns all assets with embargo history set' do
-      returned_pids = subject.assets_with_deactivated_embargoes.map(&:id)
-      expect(returned_pids).to include id
-      expect(returned_pids).not_to include(work_without_embargo.id,
-                                           work_with_expired_embargo1.id,
-                                           work_with_expired_embargo2.id,
-                                           work_with_embargo_in_effect.id)
-    end
-  end
-end

data/spec/services/hyrax/file_set_csv_service_spec.rb

@@ -1,83 +0,0 @@
-RSpec.describe Hyrax::FileSetCSVService do
-  let(:mock_file) do
-    Hydra::PCDM::File.new
-  end
-  let(:file) do
-    FileSet.new(id: '123abc', title: ['My Title'], creator: ['Von, Creator'],
-                resource_type: ['Book', 'Other'], license: ['Mine']) do |f|
-      f.apply_depositor_metadata('jilluser@example.com')
-    end
-  end
-  let(:solr_document) { SolrDocument.new(file.to_solr) }
-
-  before do
-    allow(mock_file).to receive(:mime_type).and_return('application/pdf')
-    allow(file).to receive(:resource_type).and_return(['Book', 'Other'])
-    allow(file).to receive(:original_file).and_return(mock_file)
-  end
-
-  context "when using the defaults" do
-    let(:csv_service) { described_class.new(solr_document) }
-
-    describe "csv" do
-      subject { csv_service.csv }
-
-      it { is_expected.to eq "123abc,My Title,jilluser@example.com,\"Von, Creator\",restricted,Book|Other,Mine,pdf\n" }
-      it "parses as valid csv" do
-        expect(CSV.parse(subject)).to eq([["123abc", "My Title", "jilluser@example.com", "Von, Creator", "restricted", "Book|Other", "Mine", "pdf"]])
-      end
-    end
-
-    describe "csv_header" do
-      subject { csv_service.csv_header }
-
-      it { is_expected.to eq "id,title,depositor,creator,visibility,resource_type,license,file_format\n" }
-    end
-  end
-
-  context "when specifying terms" do
-    let(:csv_service) { described_class.new(file, [:id, :title, :resource_type]) }
-
-    describe "csv" do
-      subject { csv_service.csv }
-
-      it { is_expected.to eq "123abc,My Title,Book|Other\n" }
-    end
-    describe "csv_header" do
-      subject { csv_service.csv_header }
-
-      it { is_expected.to eq "id,title,resource_type\n" }
-    end
-  end
-
-  context "when specifying separator" do
-    let(:csv_service) { described_class.new(solr_document, nil, '&&') }
-
-    describe "csv" do
-      subject { csv_service.csv }
-
-      it { is_expected.to eq "123abc,My Title,jilluser@example.com,\"Von, Creator\",restricted,Book&&Other,Mine,pdf\n" }
-    end
-
-    describe "csv_header" do
-      subject { csv_service.csv_header }
-
-      it { is_expected.to eq "id,title,depositor,creator,visibility,resource_type,license,file_format\n" }
-    end
-  end
-
-  context "when specifying terms and separator" do
-    let(:csv_service) { described_class.new(file, [:id, :title, :resource_type], '*$*') }
-
-    describe "csv" do
-      subject { csv_service.csv }
-
-      it { is_expected.to eq "123abc,My Title,Book*$*Other\n" }
-    end
-    describe "csv_header" do
-      subject { csv_service.csv_header }
-
-      it { is_expected.to eq "id,title,resource_type\n" }
-    end
-  end
-end

data/spec/services/hyrax/file_set_derivatives_service_spec.rb

@@ -1,13 +0,0 @@
-require 'hyrax/specs/shared_specs'
-
-RSpec.describe Hyrax::FileSetDerivativesService do
-  let(:valid_file_set) do
-    FileSet.new.tap do |f|
-      allow(f).to receive(:mime_type).and_return(FileSet.image_mime_types.first)
-    end
-  end
-
-  subject { described_class.new(file_set) }
-
-  it_behaves_like "a Hyrax::DerivativeService"
-end

data/spec/services/hyrax/file_set_fixity_check_service_spec.rb

@@ -1,129 +0,0 @@
-RSpec.describe Hyrax::FileSetFixityCheckService do
-  let(:f)                 { create(:file_set, content: File.open(fixture_path + '/world.png')) }
-  let(:service_by_object) { described_class.new(f) }
-  let(:service_by_id)     { described_class.new(f.id) }
-
-  describe "async_jobs: false" do
-    let(:service_by_object) { described_class.new(f, async_jobs: false) }
-    let(:service_by_id)     { described_class.new(f.id, async_jobs: false) }
-
-    describe '#fixity_check' do
-      subject { service_by_object.fixity_check }
-
-      context 'when a file has two versions' do
-        before do
-          Hyrax::VersioningService.create(f.original_file) # create a second version -- the factory creates the first version when it attaches +content+
-        end
-        specify 'returns two log results' do
-          expect(subject.values.flatten.length).to eq(2)
-        end
-
-        context "with latest_version_only" do
-          let(:service_by_object) { described_class.new(f, async_jobs: false, latest_version_only: true) }
-
-          specify "returns one log result" do
-            expect(subject.values.length).to eq(1)
-          end
-        end
-      end
-
-      context "existing check and disabled max_days_between_fixity_checks" do
-        let(:service_by_object) { described_class.new(f, async_jobs: false, max_days_between_fixity_checks: -1) }
-        let(:service_by_id)     { described_class.new(f.id, async_jobs: false, max_days_between_fixity_checks: -1) }
-        let!(:existing_record) do
-          ChecksumAuditLog.create!(passed: true, file_set_id: f.id, checked_uri: f.original_file.versions.first.label, file_id: f.original_file.id)
-        end
-
-        it "re-checks" do
-          existing_record
-          expect(subject.length).to eq 1
-          expect(subject.values.flatten.first.id).not_to eq(existing_record.id)
-          expect(subject.values.flatten.first.created_at).to be > existing_record.created_at
-        end
-      end
-    end
-
-    describe '#fixity_check_file' do
-      subject { service_by_object.send(:fixity_check_file, f.original_file) }
-
-      specify 'returns a single result' do
-        expect(subject.length).to eq(1)
-      end
-      describe 'non-versioned file with latest version only' do
-        let(:service_by_object) { described_class.new(f, async_jobs: false, latest_version_only: true) }
-
-        before do
-          allow(f.original_file).to receive(:has_versions?).and_return(false)
-        end
-
-        subject { service_by_object.send(:fixity_check_file, f.original_file) }
-
-        specify 'returns a single result' do
-          expect(subject.length).to eq(1)
-        end
-      end
-    end
-
-    describe '#fixity_check_file_version' do
-      subject { service_by_object.send(:fixity_check_file_version, f.original_file.id, f.original_file.uri.to_s) }
-
-      specify 'returns a single ChecksumAuditLog for the given file' do
-        expect(subject).to be_kind_of ChecksumAuditLog
-        expect(subject.file_set_id).to eq(f.id)
-        expect(subject.checked_uri).to eq(f.original_file.uri)
-      end
-    end
-  end
-
-  describe '#logged_fixity_status' do
-    around do |example|
-      # Deprecation.silence is supposed to be a thing, but I can't get it to work
-      original = Deprecation.default_deprecation_behavior
-      Deprecation.default_deprecation_behavior = :silence
-      example.run
-      Deprecation.default_deprecation_behavior = original
-    end
-
-    context "with an object" do
-      subject { service_by_object.logged_fixity_status }
-
-      it "doesn't trigger fixity checks" do
-        expect(service_by_object).not_to receive(:fixity_check_file)
-        expect(subject).to eq "Fixity checks have not yet been run on this object"
-      end
-
-      context "when no fixity check is passing" do
-        before do
-          ChecksumAuditLog.create!(passed: true, file_set_id: f.id, checked_uri: f.original_file.versions.first.label, file_id: 'original_file')
-        end
-
-        it "reports the fixity check result" do
-          expect(subject).to include "passed"
-        end
-      end
-
-      context "when most recent fixity check is passing" do
-        before do
-          ChecksumAuditLog.create!(passed: false, file_set_id: f.id, checked_uri: f.original_file.versions.first.label, file_id: 'original_file', created_at: 1.day.ago)
-          ChecksumAuditLog.create!(passed: true, file_set_id: f.id, checked_uri: f.original_file.versions.first.label, file_id: 'original_file')
-        end
-
-        it "records the fixity check result" do
-          expect(subject).to include "passed"
-        end
-      end
-
-      context "with an id" do
-        subject { service_by_id.logged_fixity_status }
-
-        before do
-          ChecksumAuditLog.create!(passed: true, file_set_id: f.id, checked_uri: f.original_file.versions.first.label, file_id: 'original_file')
-        end
-
-        it "records the fixity result" do
-          expect(subject).to include "passed"
-        end
-      end
-    end
-  end
-end