hyrax 2.6.0 → 2.7.0

data/spec/features/proxy_spec.rb

@@ -1,25 +0,0 @@
-RSpec.describe 'proxy', type: :feature do
-  let(:user) { create(:user) }
-  let(:second_user) { create(:user) }
-
-  describe 'add proxy in profile', :js do
-    it "creates a proxy" do
-      sign_in user
-      click_link "Your activity"
-      within 'div#proxy_management' do
-        click_link "Manage Proxies"
-      end
-      expect(first("td.depositor-name")).to be_nil
-
-      # BEGIN create_proxy_using_partial
-      find('a.select2-choice').click
-      find(".select2-input").set(second_user.user_key)
-      expect(page).to have_css("div.select2-result-label")
-      find("div.select2-result-label").click
-      # END create_proxy_using_partial
-
-      expect(page).to have_css('td.depositor-name', text: second_user.user_key)
-      expect(page).to have_link('Delete Proxy')
-    end
-  end
-end

data/spec/features/search_spec.rb

@@ -1,62 +0,0 @@
-RSpec.describe 'searching' do
-  let(:user) { create :user }
-  let(:subject_value) { 'mustache' }
-  let!(:work) do
-    create(:public_work,
-           title: ["Toothbrush"],
-           keyword: [subject_value, 'taco'],
-           user: user)
-  end
-
-  let!(:collection) do
-    create(:public_collection_lw, title: ['collection title abc'], description: [subject_value], user: user, members: [work])
-  end
-
-  context "as a public user", :clean_repo do
-    it "using the gallery view" do
-      visit '/'
-      fill_in "search-field-header", with: "Toothbrush"
-      click_button "search-submit-header"
-      expect(page).to have_content "1 entry found"
-      within "#search-results" do
-        expect(page).to have_content "Toothbrush"
-      end
-
-      click_link "Gallery"
-      expect(page).to have_content "Filtering by: Toothbrush"
-      within "#documents" do
-        expect(page).to have_content "Toothbrush"
-      end
-    end
-
-    it "only searches all and does not display search options for dashboard files" do
-      visit '/'
-
-      # it "does not display search options for dashboard files" do
-      # This section was tested on its own, and required a full setup.
-      within(".input-group-btn") do
-        expect(page).not_to have_content("All")
-        expect(page).not_to have_content("My Works")
-        expect(page).not_to have_content("My Collections")
-        expect(page).not_to have_content("My Shares")
-      end
-
-      expect(page).not_to have_css("a[data-search-label*=All]", visible: false)
-      expect(page).not_to have_css("a[data-search-label*='My Works']", visible: false)
-      expect(page).not_to have_css("a[data-search-label*='My Collections']", visible: false)
-      expect(page).not_to have_css("a[data-search-label*='My Highlights']", visible: false)
-      expect(page).not_to have_css("a[data-search-label*='My Shares']", visible: false)
-
-      fill_in "search-field-header", with: subject_value
-      click_button("Go")
-
-      expect(page).to have_content('Search Results')
-      expect(page).to have_content "Toothbrush"
-      expect(page).to have_content('collection title abc')
-      expect(page).to have_selector("//img")
-
-      expect(page.body).to include "<span itemprop=\"keywords\"><a href=\"/catalog?f%5Bkeyword_sim%5D%5B%5D=taco&amp;locale=en\">taco</a></span>"
-      expect(page.body).to include "<span itemprop=\"keywords\"><a href=\"/catalog?f%5Bkeyword_sim%5D%5B%5D=mustache&amp;locale=en\">mustache</a></span>"
-    end
-  end
-end

data/spec/features/static_pages_spec.rb

@@ -1,7 +0,0 @@
-RSpec.describe "The static pages" do
-  it do
-    visit root_path
-    click_link "About"
-    click_link "Help"
-  end
-end

data/spec/features/users_spec.rb

@@ -1,48 +0,0 @@
-RSpec.describe "User Profile", type: :feature do
-  before do
-    sign_in user
-  end
-  let(:user) { create(:user) }
-  let(:profile_path) { Hyrax::Engine.routes.url_helpers.user_path(user, locale: 'en') }
-
-  context 'when visiting user profile with highlighted works' do
-    let(:work) { create(:work, user: user) }
-
-    before do
-      user.trophies.create!(work_id: work.id)
-    end
-
-    it 'page should be editable' do
-      visit profile_path
-      expect(page).to have_content(user.email)
-
-      within '.highlighted-works' do
-        expect(page).to have_link(work.to_s)
-      end
-
-      within '.panel-user' do
-        click_link 'Edit Profile'
-      end
-      fill_in 'user_twitter_handle', with: 'curatorOfData'
-      click_button 'Save Profile'
-      expect(page).to have_content 'Your profile has been updated'
-      expect(page).to have_link('curatorOfData', href: 'http://twitter.com/curatorOfData')
-    end
-  end
-
-  context 'user profile' do
-    let!(:dewey) { create(:user, display_name: 'Melvil Dewey') }
-    let(:dewey_path) { Hyrax::Engine.routes.url_helpers.user_path(dewey, locale: 'en') }
-
-    it 'is searchable' do
-      visit profile_path
-      click_link 'View Users'
-      expect(page).to have_xpath("//td/a[@href='#{profile_path}']")
-      expect(page).to have_xpath("//td/a[@href='#{dewey_path}']")
-      fill_in 'user_search', with: 'Dewey'
-      click_button "user_submit"
-      expect(page).not_to have_xpath("//td/a[@href='#{profile_path}']")
-      expect(page).to have_xpath("//td/a[@href='#{dewey_path}']")
-    end
-  end
-end

data/spec/features/work_generator_spec.rb

@@ -1,29 +0,0 @@
-require 'rails/generators'
-require 'redlock'
-
-RSpec.describe 'Creating a new Work' do
-  before do
-    Rails::Generators.invoke('hyrax:work', ['Catapult', '--quiet'], destination_root: Rails.root)
-    load "#{EngineCart.destination}/app/indexers/catapult_indexer.rb"
-    load "#{EngineCart.destination}/app/models/catapult.rb"
-    load "#{EngineCart.destination}/app/presenters/hyrax/catapult_presenter.rb"
-    load "#{EngineCart.destination}/app/controllers/hyrax/catapults_controller.rb"
-    load "#{EngineCart.destination}/app/actors/hyrax/actors/catapult_actor.rb"
-    load "#{EngineCart.destination}/app/forms/hyrax/catapult_form.rb"
-    load "#{EngineCart.destination}/config/initializers/hyrax.rb"
-    load "#{EngineCart.destination}/config/routes.rb"
-    load "app/helpers/hyrax/url_helper.rb"
-  end
-
-  after do
-    Rails::Generators.invoke('hyrax:work', ['Catapult', '--quiet'], behavior: :revoke, destination_root: Rails.root)
-  end
-
-  it 'catapults should behave like generic works' do
-    expect(Hyrax.config.curation_concerns).to include Catapult
-    expect(defined? Hyrax::Actors::CatapultActor).to eq 'constant'
-    expect(Hyrax::CatapultsController.show_presenter).to eq Hyrax::CatapultPresenter
-    expect(defined? Hyrax::CatapultForm).to eq 'constant'
-    expect(Catapult.indexer).to eq CatapultIndexer
-  end
-end

data/spec/features/work_show_spec.rb

@@ -1,148 +0,0 @@
-RSpec.describe "work show view" do
-  include Selectors::Dashboard
-
-  let(:work_path) { "/concern/generic_works/#{work.id}" }
-
-  before do
-    create(:sipity_entity, proxy_for_global_id: work.to_global_id.to_s)
-  end
-
-  context "as the work owner" do
-    let(:work) do
-      create(:work,
-             with_admin_set: true,
-             title: ["Magnificent splendor", "Happy little trees"],
-             source: ["The Internet"],
-             based_near: ["USA"],
-             user: user,
-             ordered_members: [file_set],
-             representative_id: file_set.id)
-    end
-    let(:user) { create(:user) }
-    let(:file_set) { create(:file_set, user: user, title: ['A Contained FileSet'], content: file) }
-    let(:file) { File.open(fixture_path + '/world.png') }
-    let(:multi_membership_type_1) { create(:collection_type, :allow_multiple_membership, title: 'Multi-membership 1') }
-    let!(:collection) { create(:collection_lw, user: user, collection_type_gid: multi_membership_type_1.gid) }
-
-    before do
-      sign_in user
-      visit work_path
-    end
-
-    it "shows work content and all editor buttons and links" do
-      expect(page).to have_selector 'h2', text: 'Magnificent splendor'
-      expect(page).to have_selector 'h2', text: 'Happy little trees'
-      expect(page).to have_selector 'li', text: 'The Internet'
-      expect(page).to have_selector 'dt', text: 'Location'
-      expect(page).not_to have_selector 'dt', text: 'Based near'
-      expect(page).to have_selector 'button', text: 'Attach Child', count: 1
-      expect(page).to have_link 'Analytics'
-      expect(page).to have_link 'Edit'
-      expect(page).to have_link 'Delete'
-      expect(page).to have_selector 'button', text: 'Add to collection', count: 1
-
-      # Displays FileSets already attached to this work
-      within '.related-files' do
-        expect(page).to have_selector '.attribute-filename', text: 'A Contained FileSet'
-      end
-
-      # IIIF manifest does not include locale query param
-      expect(find('div.viewer:first')['data-uri']).to eq "http://www.example.com/concern/generic_works/#{work.id}/manifest"
-    end
-
-    it "allows adding work to a collection", clean_repo: true, js: true do
-      optional 'ability to get capybara to find css select2-result (see Issue #3038)' if ci_build?
-      click_button "Add to collection" # opens the modal
-      # Really ensure that this Collection model is persisted
-      Collection.all.map(&:destroy!)
-      persisted_collection = create(:collection_lw, user: user, collection_type_gid: multi_membership_type_1.gid)
-      select_member_of_collection(persisted_collection)
-      click_button 'Save changes'
-
-      # forwards to collection show page
-      expect(page).to have_content persisted_collection.title.first
-      expect(page).to have_content work.title.first
-      expect(page).to have_selector '.alert-success', text: 'Collection was successfully updated.'
-    end
-  end
-
-  context "as the work viewer" do
-    let(:work) do
-      create(:public_work,
-             with_admin_set: true,
-             title: ["Magnificent splendor", "Happy little trees"],
-             source: ["The Internet"],
-             based_near: ["USA"],
-             user: user,
-             ordered_members: [file_set],
-             representative_id: file_set.id)
-    end
-    let(:user) { create(:user) }
-    let(:viewer) { create(:user) }
-    let(:file_set) { create(:file_set, user: user, title: ['A Contained FileSet'], content: file) }
-    let(:file) { File.open(fixture_path + '/world.png') }
-    let(:multi_membership_type_1) { create(:collection_type, :allow_multiple_membership, title: 'Multi-membership 1') }
-    let!(:collection) { create(:collection_lw, user: viewer, collection_type_gid: multi_membership_type_1.gid) }
-
-    before do
-      sign_in viewer
-      visit work_path
-    end
-
-    it "shows work content and only Analytics and Add to collection buttons" do
-      expect(page).to have_selector 'h2', text: 'Magnificent splendor'
-      expect(page).to have_selector 'h2', text: 'Happy little trees'
-      expect(page).to have_selector 'li', text: 'The Internet'
-      expect(page).to have_selector 'dt', text: 'Location'
-      expect(page).not_to have_selector 'dt', text: 'Based near'
-      expect(page).not_to have_selector 'button', text: 'Attach Child', count: 1
-      expect(page).to have_link 'Analytics'
-      expect(page).not_to have_link 'Edit'
-      expect(page).not_to have_link 'Delete'
-      expect(page).to have_selector 'button', text: 'Add to collection', count: 1
-    end
-
-    it "allows adding work to a collection", clean_repo: true, js: true do
-      optional 'ability to get capybara to find css select2-result (see Issue #3038)' if ci_build?
-      click_button "Add to collection" # opens the modal
-      select_member_of_collection(collection)
-      click_button 'Save changes'
-
-      # forwards to collection show page
-      expect(page).to have_content collection.title.first
-      expect(page).to have_content work.title.first
-      expect(page).to have_selector '.alert-success', text: 'Collection was successfully updated.'
-    end
-  end
-
-  context "as a user who is not logged in" do
-    let(:work) { create(:public_generic_work, title: ["Magnificent splendor"], source: ["The Internet"], based_near: ["USA"]) }
-    let(:page_title) { { text: "Generic Work | Magnificent splendor | ID: #{work.id} | Hyrax" }.to_param }
-
-    before do
-      visit work_path
-    end
-
-    it "shows a work" do
-      expect(page).to have_selector 'h2', text: 'Magnificent splendor'
-      expect(page).to have_selector 'li', text: 'The Internet'
-      expect(page).to have_selector 'dt', text: 'Location'
-      expect(page).not_to have_selector 'dt', text: 'Based near'
-
-      # Doesn't have the upload form for uploading more files
-      expect(page).not_to have_selector "form#fileupload"
-
-      # has some social media buttons
-      expect(page).to have_link '', href: "https://twitter.com/intent/tweet/?#{page_title}&url=http%3A%2F%2Fwww.example.com%2Fconcern%2Fgeneric_works%2F#{work.id}"
-
-      # exports EndNote
-      expect(page).to have_link 'EndNote'
-      click_link 'EndNote'
-      expect(page).to have_content '%0 Generic Work'
-      expect(page).to have_content '%T Magnificent splendor'
-      expect(page).to have_content '%R http://localhost/files/'
-      expect(page).to have_content '%~ Hyrax'
-      expect(page).to have_content '%W Institution'
-    end
-  end
-end

data/spec/features/workflow_roles_spec.rb

@@ -1,46 +0,0 @@
-RSpec.describe "Manage workflow roles", type: :feature do
-  let(:user) { create(:admin) }
-  let(:one_step_workflow) do
-    {
-      workflows: [
-        {
-          name: "one_step",
-          label: "One-step mediated deposit workflow",
-          description: "A single-step workflow for mediated deposit",
-          actions: [
-            {
-              name: "deposit",
-              from_states: [],
-              transition_to: "pending_review"
-            },
-            {
-              name: "approve",
-              from_states: [
-                {
-                  names: ["pending_review"],
-                  roles: ["approving"]
-                }
-              ],
-              transition_to: "deposited",
-              methods: [
-                "Hyrax::Workflow::ActivateObject"
-              ]
-            }
-          ]
-        }
-      ]
-    }
-  end
-  let(:permission_template) { create(:permission_template) }
-
-  before do
-    Hyrax::Workflow::WorkflowImporter.generate_from_hash(data: one_step_workflow.as_json, permission_template: permission_template)
-    Hyrax::Workflow::PermissionGenerator.call(roles: Sipity::Role.all, workflow: Sipity::Workflow.last, agents: user)
-  end
-
-  it "shows the roles" do
-    login_as(user, scope: :user)
-    visit '/admin/workflow_roles'
-    expect(page).to have_content 'approving (one_step)'
-  end
-end

data/spec/features/workflow_state_changes_spec.rb

@@ -1,59 +0,0 @@
-RSpec.describe "Workflow state changes", type: :feature do
-  let(:workflow_name) { 'with_comment' }
-  let(:approving_user) { create(:admin) }
-  let(:depositing_user) { create(:admin) }
-  let(:admin_set) { create(:admin_set, edit_users: [depositing_user.user_key]) }
-  let(:one_step_workflow) do
-    {
-      workflows: [
-        {
-          name: workflow_name,
-          label: "One-step mediated deposit workflow",
-          description: "A single-step workflow for mediated deposit",
-          actions: [
-            {
-              name: "deposit", from_states: [], transition_to: "pending_review"
-            }, {
-              name: "approve", from_states: [{ names: ["pending_review"], roles: ["approving"] }],
-              transition_to: "deposited",
-              methods: ["Hyrax::Workflow::ActivateObject"]
-            }, {
-              name: "leave_a_comment", from_states: [{ names: ["pending_review"], roles: ["approving"] }]
-            }
-          ]
-        }
-      ]
-    }
-  end
-
-  let(:workflow) { Sipity::Workflow.find_by!(name: workflow_name, permission_template: permission_template) }
-  let(:work) { create(:work, user: depositing_user, admin_set: admin_set) }
-  let(:permission_template) { create(:permission_template, source_id: admin_set.id) }
-
-  before do
-    allow(::User.group_service).to receive(:byname).and_return(depositing_user.user_key => ['admin'], approving_user.user_key => ['admin'])
-    Hyrax::Workflow::WorkflowImporter.generate_from_hash(data: one_step_workflow, permission_template: permission_template)
-    permission_template.available_workflows.first.update!(active: true)
-    Hyrax::Workflow::PermissionGenerator.call(roles: 'approving', workflow: workflow, agents: approving_user)
-    # Need to instantiate the Sipity::Entity for the given work. This is necessary as I'm not creating the work via the UI.
-    Hyrax::Workflow::WorkflowFactory.create(work, {}, depositing_user)
-  end
-
-  describe 'leaving a comment for non-state changing' do
-    it 'will not advance the state' do
-      login_as(approving_user, scope: :user)
-      visit hyrax_generic_work_path(work)
-
-      expect do
-        the_comment = 'I am leaving a great comment. A bigly comment. The best comment.'
-        page.choose('workflow_action[name]', option: 'leave_a_comment')
-
-        page.within('.workflow-comments') do
-          page.fill_in('workflow_action_comment', with: the_comment)
-          page.click_on('Submit')
-        end
-        expect(page).to have_content(the_comment)
-      end.not_to change { work.to_sipity_entity.reload.workflow_state_name }
-    end
-  end
-end

data/spec/fixtures/authorities/licenses.yml

@@ -1,13 +0,0 @@
-terms:
-    - id: demo_id_01
-      term: First Active Term
-      active: true
-    - id: demo_id_02
-      term: Second Active Term
-      active: true
-    - id: demo_id_03
-      term: Third is an Inactive Term
-      active: false
-    - id: demo_id_04
-      term: Fourth is an Inactive Term
-      active: false