hybrid_platforms_conductor 33.9.0 → 33.9.4

data/spec/hybrid_platforms_conductor_test/cmdb_plugins/test_cmdb_others_2.rb

@@ -30,14 +30,14 @@ module HybridPlatformsConductorTest
       #     Nodes for which the property can't be fetched can be ommitted.
       def get_others(nodes, metadata)
         record_call(:get_others, nodes, metadata)
-        nodes.map do |node|
+        nodes.to_h do |node|
           [
             node,
             {
               downcase: "__#{node}__"
             }
           ]
-        end.to_h
+        end
       end
 
       # Register a call to be checked by the tests later
@@ -48,7 +48,7 @@ module HybridPlatformsConductorTest
       def record_call(method, *args)
         @calls = [] unless defined?(@calls)
         # Create a shallow copy of the args, just to make sure they won't get changed by later code
-        @calls << [method] + Marshal.load(Marshal.dump(args))
+        @calls << ([method] + Marshal.load(Marshal.dump(args)))
       end
 
     end

data/spec/hybrid_platforms_conductor_test/docs_spec.rb

@@ -3,7 +3,7 @@ describe 'Documentation' do
   it 'makes sure all Markdown links are valid' do
     check_stdout = `bundle exec tools/check_md README.md #{Dir.glob('docs/**/*.md').join(' ')}`.split("\n")
     summary_idx = check_stdout.index { |line| line =~ /^\d+ errors:$/ }
-    expect(summary_idx).not_to eq(nil), "Could not parse check output: #{check_stdout.join("\n")}"
+    expect(summary_idx).not_to be_nil, "Could not parse check output: #{check_stdout.join("\n")}"
     expect(check_stdout[summary_idx]).to eq('0 errors:'), "Invalid links found: #{check_stdout[summary_idx..].join("\n")}"
   end
 

data/spec/hybrid_platforms_conductor_test/executables/check_node_spec.rb

@@ -13,7 +13,7 @@ describe 'check-node executable' do
   it 'checks a given node' do
     with_test_platform_for_check_node do
       expect(test_deployer).to receive(:deploy_on).with('node') do
-        expect(test_deployer.use_why_run).to eq true
+        expect(test_deployer.use_why_run).to be true
         test_deployer.stdout_device << "Check ok\n"
         { 'node' => [0, "Check ok\n", ''] }
       end

data/spec/hybrid_platforms_conductor_test/executables/deploy_spec.rb

@@ -13,7 +13,7 @@ describe 'deploy executable' do
   it 'deploys a given node' do
     with_test_platform_for_deploy do
       expect(test_deployer).to receive(:deploy_on).with(['node']) do
-        expect(test_deployer.use_why_run).to eq false
+        expect(test_deployer.use_why_run).to be false
         test_deployer.stdout_device << "Deploy ok\n"
         { 'node' => [0, "Deploy ok\n", ''] }
       end

data/spec/hybrid_platforms_conductor_test/executables/nodes_to_deploy_spec.rb

@@ -190,6 +190,81 @@ describe 'nodes_to_deploy executable' do
     end
   end
 
+  it 'considers nodes having the same invalid commit ids in their logs to be deployed' do
+    with_test_platform_for_nodes_to_deploy do
+      expect(test_deployer).to receive(:deployment_info_from).with(%w[node1 node2]).and_return(
+        'node1' => {
+          services: %w[service1],
+          deployment_info: {
+            repo_name_0: 'platform',
+            commit_id_0: 'abcdef1',
+            exit_status: 0
+          },
+          exit_status: 0,
+          stdout: '',
+          stderr: ''
+        },
+        'node2' => {
+          services: %w[service2],
+          deployment_info: {
+            repo_name_0: 'platform',
+            commit_id_0: 'abcdef1',
+            exit_status: 0
+          },
+          exit_status: 0,
+          stdout: '',
+          stderr: ''
+        }
+      )
+      expect(test_nodes_handler).to receive(:impacted_nodes_from_git_diff).with('platform', from_commit: 'abcdef1', to_commit: 'master') do
+        raise HybridPlatformsConductor::NodesHandler::GitError, 'Mocked git error due to an invalid commit id'
+      end
+      exit_code, stdout = run 'nodes_to_deploy'
+      expect(exit_code).to eq 0
+      expect(stdout).to eq <<~EO_STDOUT
+        ===== Nodes to deploy =====
+        node1
+        node2
+      EO_STDOUT
+    end
+  end
+
+  it 'considers nodes having unknown platforms in their logs to be deployed' do
+    with_test_platform_for_nodes_to_deploy do
+      expect(test_deployer).to receive(:deployment_info_from).with(%w[node1 node2]).and_return(
+        'node1' => {
+          services: %w[service1],
+          deployment_info: {
+            repo_name_0: 'unknown_platform',
+            commit_id_0: 'abcdef1',
+            exit_status: 0
+          },
+          exit_status: 0,
+          stdout: '',
+          stderr: ''
+        },
+        'node2' => {
+          services: %w[service2],
+          deployment_info: {
+            repo_name_0: 'platform',
+            commit_id_0: 'abcdef2',
+            exit_status: 0
+          },
+          exit_status: 0,
+          stdout: '',
+          stderr: ''
+        }
+      )
+      expect(test_nodes_handler).to receive(:impacted_nodes_from_git_diff).with('platform', from_commit: 'abcdef2', to_commit: 'master').and_return [%w[], [], [], false]
+      exit_code, stdout = run 'nodes_to_deploy'
+      expect(exit_code).to eq 0
+      expect(stdout).to eq <<~EO_STDOUT
+        ===== Nodes to deploy =====
+        node1
+      EO_STDOUT
+    end
+  end
+
   it 'ignores impacts if asked' do
     with_test_platform_for_nodes_to_deploy do
       exit_code, stdout = run 'nodes_to_deploy', '--ignore-deployed-info'

data/spec/hybrid_platforms_conductor_test/executables/options/cmd_runner_spec.rb

@@ -13,7 +13,7 @@ describe 'executables\' Cmd Runner options' do
   it 'displays commands instead of running them' do
     with_test_platform_for_cmd_runner_options do
       expect_actions_executor_runs([proc do
-        expect(test_cmd_runner.dry_run).to eq true
+        expect(test_cmd_runner.dry_run).to be true
         {}
       end])
       exit_code, stdout, stderr = run 'run', '--node', 'node', '--command', 'echo Hello', '--show-commands'

data/spec/hybrid_platforms_conductor_test/executables/options/deployer_spec.rb

@@ -13,7 +13,7 @@ describe 'executables\' Deployer options' do
   it 'uses parallel mode' do
     with_test_platform_for_deployer_options do
       expect(test_deployer).to receive(:deploy_on).with(['node']) do
-        expect(test_deployer.concurrent_execution).to eq true
+        expect(test_deployer.concurrent_execution).to be true
         {}
       end
       exit_code, _stdout, stderr = run 'deploy', '--node', 'node', '--parallel'
@@ -25,7 +25,7 @@ describe 'executables\' Deployer options' do
   it 'uses why-run' do
     with_test_platform_for_deployer_options do
       expect(test_deployer).to receive(:deploy_on).with(['node']) do
-        expect(test_deployer.use_why_run).to eq true
+        expect(test_deployer.use_why_run).to be true
         {}
       end
       exit_code, _stdout, stderr = run 'deploy', '--node', 'node', '--why-run'

data/spec/hybrid_platforms_conductor_test/executables/options/nodes_handler_spec.rb

@@ -63,6 +63,7 @@ describe 'executables\' Nodes Handler options' do
   it 'displays info about nodes' do
     with_test_platform_for_nodes_handler_options do
       with_cmd_runner_mocked [
+        ['command -v getent', proc { [0, '', ''] }],
         ['getent hosts my_host15.my_domain', proc { [0, '192.168.42.15 my_host16.my_domain', ''] }],
         ['getent hosts my_host16.my_domain', proc { [0, '192.168.42.16 my_host16.my_domain', ''] }]
       ] do

data/spec/hybrid_platforms_conductor_test/executables/options/tests_runner_spec.rb

@@ -61,7 +61,7 @@ describe 'executables\' Tests Runner options' do
   it 'uses current run_logs instead of executing new check-nodes' do
     with_test_platform({}) do
       expect(test_tests_runner).to receive(:run_tests).with([]) do
-        expect(test_tests_runner.skip_run).to eq true
+        expect(test_tests_runner.skip_run).to be true
         0
       end
       exit_code, stdout, stderr = run 'test', '--test', 'my_test', '--skip-run'

data/spec/hybrid_platforms_conductor_test/executables/report_spec.rb

@@ -47,6 +47,7 @@ describe 'report executable' do
       }
     ) do
       with_cmd_runner_mocked [
+        ['command -v getent', proc { [0, '', ''] }],
         ['getent hosts node.domain.com', proc { [0, '192.168.0.1 node.domain.com', ''] }]
       ] do
         exit_code, stdout, stderr = run 'report', '--node', 'node'

data/spec/hybrid_platforms_conductor_test/executables/run_spec.rb

@@ -73,7 +73,7 @@ describe 'run executable' do
   it 'executes a single command on several nodes' do
     with_test_platform_for_run do
       expect_actions_executor_runs([proc do |actions, timeout: nil, concurrent: false, log_to_dir: 'run_logs', log_to_stdout: true|
-        expect(concurrent).to eq false
+        expect(concurrent).to be false
         expect(actions).to eq(%w[node1 node2] => [{ remote_bash: ['echo Hello'] }])
         test_actions_executor.stdout_device << "Hello\nHello\n"
         { 'node1' => [0, "Hello\nHello\n", ''] }
@@ -133,7 +133,7 @@ describe 'run executable' do
   it 'executes in parallel' do
     with_test_platform_for_run do
       expect_actions_executor_runs([proc do |actions, timeout: nil, concurrent: false, log_to_dir: 'run_logs', log_to_stdout: true|
-        expect(concurrent).to eq true
+        expect(concurrent).to be true
         expect(actions).to eq(%w[node1 node2] => [{ remote_bash: ['echo Hello'] }])
         test_actions_executor.stdout_device << "Hello\nHello\n"
         { 'node1' => [0, "Hello\nHello\n", ''] }

data/spec/hybrid_platforms_conductor_test/helpers/actions_executor_helpers.rb

@@ -58,7 +58,7 @@ module HybridPlatformsConductorTest
       def with_connections_mocked_on(expected_nodes)
         expect(test_actions_executor).to receive(:with_connections_prepared_to) do |nodes, no_exception: false, &client_code|
           expect(nodes.sort).to eq expected_nodes.sort
-          client_code.call nodes.map { |node| [node, test_actions_executor.connector(:test_connector)] }.to_h
+          client_code.call(nodes.to_h { |node| [node, test_actions_executor.connector(:test_connector)] })
         end
         yield
       end

data/spec/hybrid_platforms_conductor_test/helpers/cmdb_helpers.rb

@@ -21,12 +21,12 @@ module HybridPlatformsConductorTest
       def register_test_cmdb(cmdb_names = [:test_cmdb])
         register_plugins(
           :cmdb,
-          cmdb_names.map do |plugin_id|
+          cmdb_names.to_h do |plugin_id|
             [
               plugin_id,
               HybridPlatformsConductorTest::CmdbPlugins.const_get(plugin_id.to_s.split('_').collect(&:capitalize).join.to_sym)
             ]
-          end.to_h
+          end
         )
       end
 

data/spec/hybrid_platforms_conductor_test/helpers/connector_ssh_helpers.rb

@@ -105,7 +105,7 @@ module HybridPlatformsConductorTest
               { optional: with_control_master_destroy_optional }
             ]
           end
-          ssh_commands_once + ssh_commands_per_connection * node_connection_info[:times]
+          ssh_commands_once + (ssh_commands_per_connection * node_connection_info[:times])
         end.flatten(1)
       end
 

data/spec/hybrid_platforms_conductor_test/helpers/deployer_helpers.rb

@@ -40,10 +40,10 @@ module HybridPlatformsConductorTest
       # * Hash<String, [Integer or Symbol, String, String] >: Expected result of those expected actions
       def expect_actions_to_deploy_on(actions, nodes, check: false, sudo: 'sudo -u root', expected_actions: [], mocked_result: nil)
         nodes = [nodes] if nodes.is_a?(String)
-        mocked_result = nodes.map { |node| [node, [0, "#{check ? 'Check' : 'Deploy'} successful", '']] }.to_h if mocked_result.nil?
+        mocked_result = nodes.to_h { |node| [node, [0, "#{check ? 'Check' : 'Deploy'} successful", '']] } if mocked_result.nil?
         expect(actions.size).to eq nodes.size
         nodes.each do |node|
-          expect(actions.key?(node)).to eq true
+          expect(actions.key?(node)).to be true
           expect(actions[node].size).to eq(2 + expected_actions.size)
           expect_action_to_lock_node(actions[node][0], node, sudo: sudo)
           expect(actions[node][1..-2]).to eq expected_actions
@@ -62,10 +62,10 @@ module HybridPlatformsConductorTest
         nodes = [nodes] if nodes.is_a?(String)
         expect(actions.size).to eq nodes.size
         nodes.each do |node|
-          expect(actions.key?(node)).to eq true
+          expect(actions.key?(node)).to be true
           expect_action_to_unlock_node(actions[node], node, sudo: sudo)
         end
-        nodes.map { |node| [node, [0, 'Release mutex successful', '']] }.to_h
+        nodes.to_h { |node| [node, [0, 'Release mutex successful', '']] }
       end
 
       # Expect a given set of actions to upload log files on a list of nodes (using the test_log log plugin)
@@ -77,10 +77,10 @@ module HybridPlatformsConductorTest
         nodes = [nodes] if nodes.is_a?(String)
         expect(actions.size).to eq nodes.size
         nodes.each do |node|
-          expect(actions.key?(node)).to eq true
+          expect(actions.key?(node)).to be true
           expect(actions[node]).to eq [{ bash: "echo Save test logs to #{node}" }]
         end
-        nodes.map { |node| [node, [0, 'Logs uploaded', '']] }.to_h
+        nodes.to_h { |node| [node, [0, 'Logs uploaded', '']] }
       end
 
       # Get a test Deployer
@@ -325,7 +325,7 @@ module HybridPlatformsConductorTest
         expect_actions_executor_runs(statuses.map do |status|
           status = { 'node' => status } if status.is_a?(Array)
           expected_actions_for_deploy_on(
-            services: status.keys.map { |node| [node, %w[service]] }.to_h,
+            services: status.keys.to_h { |node| [node, %w[service]] },
             mocked_deploy_result: status
           )
         end.flatten)

data/spec/hybrid_platforms_conductor_test/helpers/platforms_handler_helpers.rb

@@ -14,7 +14,7 @@ module HybridPlatformsConductorTest
       #   * Parameters::
       #     * *repositories* (Hash<String,String>): Path to the repositories, per repository name
       def with_repositories(names = [], as_git: false)
-        repositories = names.map { |name| [name, "#{Dir.tmpdir}/hpc_test/#{name}"] }.to_h
+        repositories = names.to_h { |name| [name, "#{Dir.tmpdir}/hpc_test/#{name}"] }
         repositories.each_value do |dir|
           FileUtils.rm_rf dir
           FileUtils.mkdir_p dir
@@ -91,12 +91,12 @@ module HybridPlatformsConductorTest
               "#{platform_type}_platform path: '#{dir}'#{platforms_info[platform].key?(:name) ? ", name: '#{platforms_info[platform][:name]}'" : ''}"
             end.join("\n") + "\n#{additional_config}"
           ) do
-            register_platform_handlers(platform_types.map do |platform_type|
+            register_platform_handlers(platform_types.to_h do |platform_type|
               [
                 platform_type,
                 HybridPlatformsConductorTest::PlatformHandlerPlugins.const_get(platform_type.to_s.split('_').collect(&:capitalize).join.to_sym)
               ]
-            end.to_h)
+            end)
             self.test_platforms_info = platforms_info
             yield repositories
           end

data/spec/hybrid_platforms_conductor_test/helpers/provisioner_proxmox_helpers.rb

@@ -97,7 +97,7 @@ module HybridPlatformsConductorTest
           expect(user).to eq proxmox_user
           expect(password).to eq proxmox_password
           expect(realm).to eq proxmox_realm
-          expect(options[:verify_ssl]).to eq false
+          expect(options[:verify_ssl]).to be false
           proxmox = instance_double ::Proxmox::Proxmox
           # Mock initialization
           expect(proxmox).to receive(:logger=).and_return(nil)
@@ -137,7 +137,7 @@ module HybridPlatformsConductorTest
           expect(user).to eq proxmox_user
           expect(password).to eq proxmox_password
           expect(realm).to eq 'pam'
-          expect(options[:verify_ssl]).to eq false
+          expect(options[:verify_ssl]).to be false
           proxmox = instance_double ::Proxmox::Proxmox
           # Mock initialization
           expect(proxmox).to receive(:logger=).and_return(nil)
@@ -180,7 +180,7 @@ module HybridPlatformsConductorTest
           expect(user).to eq proxmox_user
           expect(password).to eq proxmox_password
           expect(realm).to eq 'pam'
-          expect(options[:verify_ssl]).to eq false
+          expect(options[:verify_ssl]).to be false
           proxmox = instance_double ::Proxmox::Proxmox
           # Mock initialization
           expect(proxmox).to receive(:logger=).and_return(nil)
@@ -215,7 +215,7 @@ module HybridPlatformsConductorTest
           expect(user).to eq proxmox_user
           expect(password).to eq proxmox_password
           expect(realm).to eq 'pam'
-          expect(options[:verify_ssl]).to eq false
+          expect(options[:verify_ssl]).to be false
           proxmox = instance_double ::Proxmox::Proxmox
           # Mock initialization
           expect(proxmox).to receive(:logger=).and_return(nil)
@@ -252,7 +252,7 @@ module HybridPlatformsConductorTest
           expect(user).to eq proxmox_user
           expect(password).to eq proxmox_password
           expect(realm).to eq 'pam'
-          expect(options[:verify_ssl]).to eq false
+          expect(options[:verify_ssl]).to be false
           proxmox = instance_double ::Proxmox::Proxmox
           # Mock initialization
           expect(proxmox).to receive(:logger=).and_return(nil)
@@ -494,8 +494,8 @@ module HybridPlatformsConductorTest
         mock_proxmox_calls_with(
           mocked_pve_nodes.map do |pve_nodes|
             # Complete pve_nodes with default values
-            pve_nodes = pve_nodes.map do |pve_node_name, pve_node_info|
-              pve_node_info[:lxc_containers] = (pve_node_info.key?(:lxc_containers) ? pve_node_info[:lxc_containers] : {}).map do |vm_id, vm_info|
+            pve_nodes = pve_nodes.to_h do |pve_node_name, pve_node_info|
+              pve_node_info[:lxc_containers] = (pve_node_info.key?(:lxc_containers) ? pve_node_info[:lxc_containers] : {}).to_h do |vm_id, vm_info|
                 [
                   vm_id,
                   {
@@ -510,7 +510,7 @@ module HybridPlatformsConductorTest
                     environment: 'test_env'
                   }.merge(vm_info)
                 ]
-              end.to_h
+              end
               [
                 pve_node_name,
                 {
@@ -519,14 +519,14 @@ module HybridPlatformsConductorTest
                   storage_total: 100 * 1024 * 1024 * 1024
                 }.merge(pve_node_info)
               ]
-            end.to_h
+            end
             proc do |url, pve_node, user, password, realm, options|
               expect(url).to eq 'https://my-proxmox.my-domain.com:8006/api2/json/'
               expect(pve_node).to eq 'my-proxmox'
               expect(user).to eq proxmox_user
               expect(password).to eq proxmox_password
               expect(realm).to eq proxmox_realm
-              expect(options[:verify_ssl]).to eq false
+              expect(options[:verify_ssl]).to be false
               proxmox = instance_double ::Proxmox::Proxmox
               # Mock getting status of a container
               allow(proxmox).to receive(:get) do |path|
@@ -647,8 +647,7 @@ module HybridPlatformsConductorTest
               block.nil? ? remaining_leftovers : remaining_leftovers.each(&block)
             when %r{^/sys/fs/cgroup/\*/lxc/(.+)$}
               vm_id_str = Regexp.last_match(1)
-              file_pattern = %r{^/sys/fs/cgroup/.+/lxc/#{Regexp.escape(vm_id_str)}$}
-              matched_files = remaining_leftovers.select { |file| file =~ file_pattern }
+              matched_files = remaining_leftovers.grep(%r{^/sys/fs/cgroup/.+/lxc/#{Regexp.escape(vm_id_str)}$})
               block.nil? ? matched_files : matched_files.each(&block)
             else
               original_glob.call(dir, &block)

data/spec/hybrid_platforms_conductor_test/helpers/serverless_chef_helpers.rb

@@ -27,12 +27,12 @@ module HybridPlatformsConductorTest
             FileUtils.cp_r "#{__dir__}/../serverless_chef_repositories/#{names[name]}/.", repository
           end
           with_platforms(repositories.values.map { |repository| "serverless_chef_platform path: '#{repository}'\n" }.join + additional_config) do
-            repositories = names.keys.map do |name|
+            repositories = names.keys.to_h do |name|
               [
                 test_platforms_handler.platform(name),
                 repositories[name]
               ]
-            end.to_h
+            end
             test_platforms_handler.inject_dependencies(
               nodes_handler: test_nodes_handler,
               actions_executor: test_actions_executor

data/spec/hybrid_platforms_conductor_test/mocked_lib/my_test_gem_with_lib/sub1/lib/sub2/hpc_plugins/test_plugin_type_3/test_plugin_id_5.rb

@@ -0,0 +1,34 @@
+module HybridPlatformsConductorTest
+
+  module MockedLib
+
+    module MyTestGemWithLib
+
+      module Sub1
+
+        module Lib
+
+          module Sub2
+
+            module HpcPlugins
+
+              module TestPluginType3
+
+                class TestPluginId5 < HybridPlatformsConductor::TestPluginType3
+                end
+
+              end
+
+            end
+
+          end
+
+        end
+
+      end
+
+    end
+
+  end
+
+end

data/spec/hybrid_platforms_conductor_test/shared_examples/deployer.rb

@@ -24,7 +24,7 @@ shared_examples 'a deployer' do
     with_platform_to_deploy(expect_local_environment: true) do
       test_deployer.local_environment = true
       expect(test_deployer.deploy_on('node')).to eq('node' => expected_deploy_result)
-      expect(test_deployer.local_environment).to eq true
+      expect(test_deployer.local_environment).to be true
     end
   end
 

data/spec/hybrid_platforms_conductor_test/test_connector.rb

@@ -140,7 +140,7 @@ module HybridPlatformsConductorTest
       extra_opts[:sudo] = sudo if sudo
       extra_opts[:owner] = owner if owner
       extra_opts[:group] = group if group
-      @calls << [:remote_copy, from, to] + (extra_opts.empty? ? [] : [extra_opts])
+      @calls << ([:remote_copy, from, to] + (extra_opts.empty? ? [] : [extra_opts]))
       @remote_copy_code&.call(@stdout_io, @stderr_io, self)
     end
 

data/spec/hybrid_platforms_conductor_test/test_log_plugin.rb

@@ -5,7 +5,7 @@ module HybridPlatformsConductorTest
 
     class << self
 
-      attr_accessor :calls
+      attr_accessor(*%i[calls mocked_logs])
 
     end
 
@@ -89,7 +89,7 @@ module HybridPlatformsConductorTest
         stdout: stdout,
         stderr: stderr
       }
-      {
+      TestLogPlugin.mocked_logs[node] || {
         services: %w[unknown],
         deployment_info: {
           user: 'test_user'

data/spec/hybrid_platforms_conductor_test.rb

@@ -58,6 +58,7 @@ require 'hybrid_platforms_conductor_test/test_plugins/several_checks'
 require 'hybrid_platforms_conductor_test/test_provisioner'
 require 'hybrid_platforms_conductor_test/test_secrets_reader_plugin'
 require 'hybrid_platforms_conductor_test/tests_report_plugin'
+require 'active_support/core_ext/module'
 
 module HybridPlatformsConductorTest
 
@@ -145,6 +146,7 @@ module HybridPlatformsConductorTest
         HybridPlatformsConductorTest::TestPlugins::NodeCheck.only_on_nodes = nil
         HybridPlatformsConductorTest::TestPlugins::SeveralChecks.runs = []
         HybridPlatformsConductorTest::TestLogPlugin.calls = []
+        HybridPlatformsConductorTest::TestLogPlugin.mocked_logs = {}
         HybridPlatformsConductorTest::TestLogNoReadPlugin.calls = []
         HybridPlatformsConductorTest::TestSecretsReaderPlugin.calls = []
         HybridPlatformsConductorTest::TestSecretsReaderPlugin.deployer = nil