hybrid_platforms_conductor 33.9.0 → 33.9.4

data/spec/hybrid_platforms_conductor_test/api/services_handler/package_spec.rb

@@ -10,7 +10,7 @@ describe HybridPlatformsConductor::ServicesHandler do
           package: proc do |services:, secrets:, local_environment:|
             expect(services).to eq('node1' => %w[service1])
             expect(secrets).to eq({})
-            expect(local_environment).to eq false
+            expect(local_environment).to be false
           end
         }
       ) do
@@ -31,7 +31,7 @@ describe HybridPlatformsConductor::ServicesHandler do
           package: proc do |services:, secrets:, local_environment:|
             expect(services).to eq('node1' => %w[service1])
             expect(secrets).to eq({})
-            expect(local_environment).to eq false
+            expect(local_environment).to be false
             nbr_calls += 1
           end
         }
@@ -56,7 +56,7 @@ describe HybridPlatformsConductor::ServicesHandler do
           package: proc do |services:, secrets:, local_environment:|
             expect(services).to eq('node1' => %w[service1])
             expect(secrets).to eq({})
-            expect(local_environment).to eq false
+            expect(local_environment).to be false
             nbr_calls += 1
           end
         }
@@ -91,7 +91,7 @@ describe HybridPlatformsConductor::ServicesHandler do
           package: proc do |services:, secrets:, local_environment:|
             expect(services).to eq('node1' => %w[service1])
             expect(secrets).to eq('my_secret' => 'value')
-            expect(local_environment).to eq false
+            expect(local_environment).to be false
           end
         }
       ) do
@@ -111,7 +111,7 @@ describe HybridPlatformsConductor::ServicesHandler do
           package: proc do |services:, secrets:, local_environment:|
             expect(services).to eq('node1' => %w[service1])
             expect(secrets).to eq({})
-            expect(local_environment).to eq true
+            expect(local_environment).to be true
           end
         }
       ) do
@@ -137,7 +137,7 @@ describe HybridPlatformsConductor::ServicesHandler do
             package: proc do |services:, secrets:, local_environment:|
               expect(services).to eq('node1' => %w[service1])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
+              expect(local_environment).to be false
               nbr_calls['platform1'] += 1
             end
           },
@@ -147,7 +147,7 @@ describe HybridPlatformsConductor::ServicesHandler do
             package: proc do |services:, secrets:, local_environment:|
               expect(services).to eq('node2' => %w[service2])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
+              expect(local_environment).to be false
               nbr_calls['platform2'] += 1
             end
           },
@@ -157,7 +157,7 @@ describe HybridPlatformsConductor::ServicesHandler do
             package: proc do |services:, secrets:, local_environment:|
               expect(services).to eq('node3' => %w[service3])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
+              expect(local_environment).to be false
               nbr_calls['platform3'] += 1
             end
           }
@@ -190,7 +190,7 @@ describe HybridPlatformsConductor::ServicesHandler do
             package: proc do |services:, secrets:, local_environment:|
               expect(services).to eq('node1' => %w[service1])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
+              expect(local_environment).to be false
               nbr_calls['platform1'] += 1
             end
           },
@@ -200,7 +200,7 @@ describe HybridPlatformsConductor::ServicesHandler do
             package: proc do |services:, secrets:, local_environment:|
               expect(services).to eq('node2' => %w[service2])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
+              expect(local_environment).to be false
               nbr_calls['platform2'] += 1
             end
           },
@@ -210,7 +210,7 @@ describe HybridPlatformsConductor::ServicesHandler do
             package: proc do |services:, secrets:, local_environment:|
               expect(services).to eq('node1' => %w[service3])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
+              expect(local_environment).to be false
               nbr_calls['platform3'] += 1
             end
           }
@@ -243,7 +243,7 @@ describe HybridPlatformsConductor::ServicesHandler do
             package: proc do |services:, secrets:, local_environment:|
               expect(services).to eq('node' => %w[service1 service2])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
+              expect(local_environment).to be false
               nbr_calls['platform1'] += 1
             end
           },
@@ -253,7 +253,7 @@ describe HybridPlatformsConductor::ServicesHandler do
             package: proc do |services:, secrets:, local_environment:|
               expect(services).to eq('node' => %w[service3])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
+              expect(local_environment).to be false
               nbr_calls['platform2'] += 1
             end
           },
@@ -263,7 +263,7 @@ describe HybridPlatformsConductor::ServicesHandler do
             package: proc do |services:, secrets:, local_environment:|
               expect(services).to eq('node' => %w[service5 service6])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
+              expect(local_environment).to be false
               nbr_calls['platform3'] += 1
             end
           }
@@ -296,7 +296,7 @@ describe HybridPlatformsConductor::ServicesHandler do
             package: proc do |services:, secrets:, local_environment:|
               expect(services).to eq('node1' => %w[service1])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
+              expect(local_environment).to be false
               nbr_calls['platform1'] += 1
             end
           },
@@ -306,7 +306,7 @@ describe HybridPlatformsConductor::ServicesHandler do
             package: proc do |services:, secrets:, local_environment:|
               expect(services).to eq('node2' => %w[service2])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
+              expect(local_environment).to be false
               nbr_calls['platform2'] += 1
             end
           },
@@ -316,7 +316,7 @@ describe HybridPlatformsConductor::ServicesHandler do
             package: proc do |services:, secrets:, local_environment:|
               expect(services).to eq('node3' => %w[service3])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
+              expect(local_environment).to be false
               nbr_calls['platform3'] += 1
             end
           }
@@ -355,7 +355,7 @@ describe HybridPlatformsConductor::ServicesHandler do
           package: proc do |services:, secrets:, local_environment:|
             expect(services).to eq('node1' => %w[service1])
             expect(secrets).to eq(expected_secrets)
-            expect(local_environment).to eq false
+            expect(local_environment).to be false
             nbr_calls += 1
           end
         }

data/spec/hybrid_platforms_conductor_test/api/services_handler/prepare_for_deploy_spec.rb

@@ -11,8 +11,8 @@ describe HybridPlatformsConductor::ServicesHandler do
           prepare_for_deploy: proc do |services:, secrets:, local_environment:, why_run:|
             expect(services).to eq('node1' => %w[service1])
             expect(secrets).to eq({})
-            expect(local_environment).to eq false
-            expect(why_run).to eq false
+            expect(local_environment).to be false
+            expect(why_run).to be false
             called = true
           end
         }
@@ -23,7 +23,7 @@ describe HybridPlatformsConductor::ServicesHandler do
           local_environment: false,
           why_run: false
         )
-        expect(called).to eq true
+        expect(called).to be true
       end
     end
 
@@ -36,8 +36,8 @@ describe HybridPlatformsConductor::ServicesHandler do
           prepare_for_deploy: proc do |services:, secrets:, local_environment:, why_run:|
             expect(services).to eq('node1' => %w[service1])
             expect(secrets).to eq('my_secret' => 'value')
-            expect(local_environment).to eq false
-            expect(why_run).to eq false
+            expect(local_environment).to be false
+            expect(why_run).to be false
             called = true
           end
         }
@@ -48,7 +48,7 @@ describe HybridPlatformsConductor::ServicesHandler do
           local_environment: false,
           why_run: false
         )
-        expect(called).to eq true
+        expect(called).to be true
       end
     end
 
@@ -61,8 +61,8 @@ describe HybridPlatformsConductor::ServicesHandler do
           prepare_for_deploy: proc do |services:, secrets:, local_environment:, why_run:|
             expect(services).to eq('node1' => %w[service1])
             expect(secrets).to eq({})
-            expect(local_environment).to eq true
-            expect(why_run).to eq false
+            expect(local_environment).to be true
+            expect(why_run).to be false
             called = true
           end
         }
@@ -73,7 +73,7 @@ describe HybridPlatformsConductor::ServicesHandler do
           local_environment: true,
           why_run: false
         )
-        expect(called).to eq true
+        expect(called).to be true
       end
     end
 
@@ -86,8 +86,8 @@ describe HybridPlatformsConductor::ServicesHandler do
           prepare_for_deploy: proc do |services:, secrets:, local_environment:, why_run:|
             expect(services).to eq('node1' => %w[service1])
             expect(secrets).to eq({})
-            expect(local_environment).to eq false
-            expect(why_run).to eq true
+            expect(local_environment).to be false
+            expect(why_run).to be true
             called = true
           end
         }
@@ -98,7 +98,7 @@ describe HybridPlatformsConductor::ServicesHandler do
           local_environment: false,
           why_run: true
         )
-        expect(called).to eq true
+        expect(called).to be true
       end
     end
 
@@ -116,8 +116,8 @@ describe HybridPlatformsConductor::ServicesHandler do
             prepare_for_deploy: proc do |services:, secrets:, local_environment:, why_run:|
               expect(services).to eq('node1' => %w[service1])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
-              expect(why_run).to eq false
+              expect(local_environment).to be false
+              expect(why_run).to be false
               called['platform1'] = true
             end
           },
@@ -127,8 +127,8 @@ describe HybridPlatformsConductor::ServicesHandler do
             prepare_for_deploy: proc do |services:, secrets:, local_environment:, why_run:|
               expect(services).to eq('node2' => %w[service2])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
-              expect(why_run).to eq false
+              expect(local_environment).to be false
+              expect(why_run).to be false
               called['platform2'] = true
             end
           },
@@ -138,8 +138,8 @@ describe HybridPlatformsConductor::ServicesHandler do
             prepare_for_deploy: proc do |services:, secrets:, local_environment:, why_run:|
               expect(services).to eq('node3' => %w[service3])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
-              expect(why_run).to eq false
+              expect(local_environment).to be false
+              expect(why_run).to be false
               called['platform3'] = true
             end
           }
@@ -173,8 +173,8 @@ describe HybridPlatformsConductor::ServicesHandler do
             prepare_for_deploy: proc do |services:, secrets:, local_environment:, why_run:|
               expect(services).to eq('node1' => %w[service1])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
-              expect(why_run).to eq false
+              expect(local_environment).to be false
+              expect(why_run).to be false
               called['platform1'] = true
             end
           },
@@ -184,8 +184,8 @@ describe HybridPlatformsConductor::ServicesHandler do
             prepare_for_deploy: proc do |services:, secrets:, local_environment:, why_run:|
               expect(services).to eq('node2' => %w[service2])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
-              expect(why_run).to eq false
+              expect(local_environment).to be false
+              expect(why_run).to be false
               called['platform2'] = true
             end
           },
@@ -195,8 +195,8 @@ describe HybridPlatformsConductor::ServicesHandler do
             prepare_for_deploy: proc do |services:, secrets:, local_environment:, why_run:|
               expect(services).to eq('node1' => %w[service3])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
-              expect(why_run).to eq false
+              expect(local_environment).to be false
+              expect(why_run).to be false
               called['platform3'] = true
             end
           }
@@ -230,8 +230,8 @@ describe HybridPlatformsConductor::ServicesHandler do
             prepare_for_deploy: proc do |services:, secrets:, local_environment:, why_run:|
               expect(services).to eq('node' => %w[service1 service2])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
-              expect(why_run).to eq false
+              expect(local_environment).to be false
+              expect(why_run).to be false
               called['platform1'] = true
             end
           },
@@ -241,8 +241,8 @@ describe HybridPlatformsConductor::ServicesHandler do
             prepare_for_deploy: proc do |services:, secrets:, local_environment:, why_run:|
               expect(services).to eq('node' => %w[service3])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
-              expect(why_run).to eq false
+              expect(local_environment).to be false
+              expect(why_run).to be false
               called['platform2'] = true
             end
           },
@@ -252,8 +252,8 @@ describe HybridPlatformsConductor::ServicesHandler do
             prepare_for_deploy: proc do |services:, secrets:, local_environment:, why_run:|
               expect(services).to eq('node' => %w[service5 service6])
               expect(secrets).to eq({})
-              expect(local_environment).to eq false
-              expect(why_run).to eq false
+              expect(local_environment).to be false
+              expect(why_run).to be false
               called['platform3'] = true
             end
           }

data/spec/hybrid_platforms_conductor_test/api/tests_runner/common_spec.rb

@@ -140,7 +140,7 @@ describe HybridPlatformsConductor::TestsRunner do
       register_test_plugins(test_tests_runner, several_tests: HybridPlatformsConductorTest::TestPlugins::SeveralChecks)
       # Mock the Actions Executor and Deployer expected calls
       expect(test_deployer).to receive(:deploy_on).with(%w[node11 node12 node21 node22]).once do
-        expect(test_deployer.use_why_run).to eq true
+        expect(test_deployer.use_why_run).to be true
         {
           'node11' => [0, 'node11 check ok', 'node11 stderr'],
           'node12' => [0, 'node12 check ok', 'node12 stderr'],
@@ -153,7 +153,7 @@ describe HybridPlatformsConductor::TestsRunner do
         expect(actions.size).to eq node_suffixes.size
         node_suffixes.each do |node_suffix|
           node = "node#{node_suffix}"
-          expect(actions.key?(node)).to eq true
+          expect(actions.key?(node)).to be true
           expect(actions[node].size).to eq 1
           expect(actions[node][:remote_bash]).to eq [
             'echo \'===== TEST COMMAND EXECUTION ===== Separator generated by Hybrid Platforms Conductor test framework =====\'',
@@ -162,7 +162,7 @@ describe HybridPlatformsConductor::TestsRunner do
             'echo "$?"'
           ]
         end
-        node_suffixes.map do |node_suffix|
+        node_suffixes.to_h do |node_suffix|
           [
             "node#{node_suffix}",
             [
@@ -178,7 +178,7 @@ describe HybridPlatformsConductor::TestsRunner do
               EO_STDERR
             ]
           ]
-        end.to_h
+        end
       end])
       # Run everything
       test_tests_runner.tests = [:several_tests]
@@ -207,7 +207,7 @@ describe HybridPlatformsConductor::TestsRunner do
     with_test_platform({ tests: { specific_platform_handler_test: SpecificPlatformHandlerTest } }) do
       test_tests_runner.tests = [:specific_platform_handler_test]
       expect(test_tests_runner.run_tests([])).to eq 0
-      expect(SpecificPlatformHandlerTest.run).to eq true
+      expect(SpecificPlatformHandlerTest.run).to be true
     end
   end
 

data/spec/hybrid_platforms_conductor_test/api/tests_runner/node_check_spec.rb

@@ -26,7 +26,7 @@ describe HybridPlatformsConductor::TestsRunner do
       with_test_platform_for_node_check_tests do
         test_tests_runner.tests = [:node_check_test]
         expect(test_deployer).to receive(:deploy_on).with(%w[node11 node12 node21 node22]).once do
-          expect(test_deployer.use_why_run).to eq true
+          expect(test_deployer.use_why_run).to be true
           {
             'node11' => [0, 'node11 check ok', 'node11 stderr'],
             'node12' => [0, 'node12 check ok', 'node12 stderr'],
@@ -48,7 +48,7 @@ describe HybridPlatformsConductor::TestsRunner do
       with_test_platform_for_node_check_tests do
         test_tests_runner.tests = [:node_check_test]
         expect(test_deployer).to receive(:deploy_on).with(%w[node12 node22]).once do
-          expect(test_deployer.use_why_run).to eq true
+          expect(test_deployer.use_why_run).to be true
           {
             'node12' => [0, 'node12 check ok', 'node12 stderr'],
             'node22' => [0, 'node22 check ok', 'node22 stderr']
@@ -66,7 +66,7 @@ describe HybridPlatformsConductor::TestsRunner do
       with_test_platform_for_node_check_tests do
         test_tests_runner.tests = %i[node_check_test node_check_test_2]
         expect(test_deployer).to receive(:deploy_on).with(%w[node11 node12 node21 node22]).once do
-          expect(test_deployer.use_why_run).to eq true
+          expect(test_deployer.use_why_run).to be true
           {
             'node11' => [0, 'node11 check ok', 'node11 stderr'],
             'node12' => [0, 'node12 check ok', 'node12 stderr'],
@@ -92,7 +92,7 @@ describe HybridPlatformsConductor::TestsRunner do
       with_test_platform_for_node_check_tests do
         test_tests_runner.tests = [:node_check_test]
         expect(test_deployer).to receive(:deploy_on).with(%w[node11 node12 node21 node22]).once do
-          expect(test_deployer.use_why_run).to eq true
+          expect(test_deployer.use_why_run).to be true
           {
             'node11' => [0, 'node11 check ok', 'node11 stderr'],
             'node12' => [1, 'node12 check ok', 'node12 stderr'],
@@ -114,7 +114,7 @@ describe HybridPlatformsConductor::TestsRunner do
       with_test_platform_for_node_check_tests do
         test_tests_runner.tests = [:node_check_test]
         expect(test_deployer).to receive(:deploy_on).with(%w[node11 node12 node21 node22]).once do
-          expect(test_deployer.use_why_run).to eq true
+          expect(test_deployer.use_why_run).to be true
           {
             'node11' => [0, 'node11 check ok', 'node11 stderr'],
             'node12' => [1, 'node12 check ok', 'node12 stderr'],
@@ -178,7 +178,7 @@ describe HybridPlatformsConductor::TestsRunner do
         HybridPlatformsConductorTest::TestPlugins::NodeCheck.only_on_nodes = %w[node12 node22]
         test_tests_runner.tests = [:node_check_test]
         expect(test_deployer).to receive(:deploy_on).with(%w[node12 node22]).once do
-          expect(test_deployer.use_why_run).to eq true
+          expect(test_deployer.use_why_run).to be true
           {
             'node12' => [0, 'node12 check ok', 'node12 stderr'],
             'node22' => [0, 'node22 check ok', 'node22 stderr']

data/spec/hybrid_platforms_conductor_test/api/tests_runner/node_ssh_spec.rb

@@ -34,7 +34,7 @@ describe HybridPlatformsConductor::TestsRunner do
       expect(actions.size).to eq node_suffixes.size
       node_suffixes.each do |node_suffix|
         node = "node#{node_suffix}"
-        expect(actions.key?(node)).to eq true
+        expect(actions.key?(node)).to be true
         expect(actions[node].size).to eq 1
         expect(actions[node][:remote_bash]).to eq [
           'echo \'===== TEST COMMAND EXECUTION ===== Separator generated by Hybrid Platforms Conductor test framework =====\'',
@@ -43,7 +43,7 @@ describe HybridPlatformsConductor::TestsRunner do
           'echo "$?"'
         ]
       end
-      node_suffixes.map do |node_suffix|
+      node_suffixes.to_h do |node_suffix|
         [
           "node#{node_suffix}",
           [
@@ -59,7 +59,7 @@ describe HybridPlatformsConductor::TestsRunner do
             EO_STDERR
           ]
         ]
-      end.to_h
+      end
     end
 
     it 'executes SSH node tests once per node with the correct command' do
@@ -120,7 +120,7 @@ describe HybridPlatformsConductor::TestsRunner do
           expect(actions.size).to eq node_suffixes.size
           node_suffixes.each do |node_suffix|
             node = "node#{node_suffix}"
-            expect(actions.key?(node)).to eq true
+            expect(actions.key?(node)).to be true
             expect(actions[node].size).to eq 1
             expect(actions[node][:remote_bash]).to eq [
               'echo \'===== TEST COMMAND EXECUTION ===== Separator generated by Hybrid Platforms Conductor test framework =====\'',
@@ -133,7 +133,7 @@ describe HybridPlatformsConductor::TestsRunner do
               'echo "$?"'
             ]
           end
-          node_suffixes.map do |node_suffix|
+          node_suffixes.to_h do |node_suffix|
             [
               "node#{node_suffix}",
               [
@@ -154,7 +154,7 @@ describe HybridPlatformsConductor::TestsRunner do
                 EO_STDERR
               ]
             ]
-          end.to_h
+          end
         end])
         test_tests_runner.tests = %i[node_ssh_test node_ssh_test_2]
         ssh_executions = []

data/spec/hybrid_platforms_conductor_test/api/tests_runner/reports_spec.rb

@@ -208,7 +208,7 @@ describe HybridPlatformsConductor::TestsRunner do
       with_test_platforms_for_reports_test do
         # Mock the Actions Executor and Deployer expected calls
         expect(test_deployer).to receive(:deploy_on).with(%w[node11 node12 node21 node22]).once do
-          expect(test_deployer.use_why_run).to eq true
+          expect(test_deployer.use_why_run).to be true
           {
             'node11' => [0, 'node11 check ok', 'node11 stderr'],
             'node12' => [0, 'node12 check ok', 'node12 stderr'],
@@ -221,7 +221,7 @@ describe HybridPlatformsConductor::TestsRunner do
           expect(actions.size).to eq node_suffixes.size
           node_suffixes.each do |node_suffix|
             node = "node#{node_suffix}"
-            expect(actions.key?(node)).to eq true
+            expect(actions.key?(node)).to be true
             expect(actions[node].size).to eq 1
             expect(actions[node][:remote_bash]).to eq [
               'echo \'===== TEST COMMAND EXECUTION ===== Separator generated by Hybrid Platforms Conductor test framework =====\'',
@@ -230,7 +230,7 @@ describe HybridPlatformsConductor::TestsRunner do
               'echo "$?"'
             ]
           end
-          node_suffixes.map do |node_suffix|
+          node_suffixes.to_h do |node_suffix|
             [
               "node#{node_suffix}",
               [
@@ -246,7 +246,7 @@ describe HybridPlatformsConductor::TestsRunner do
                 EO_STDERR
               ]
             ]
-          end.to_h
+          end
         end])
         # Run everything
         test_tests_runner.tests = [:several_tests]

data/spec/hybrid_platforms_conductor_test/cmdb_plugins/test_cmdb.rb

@@ -40,7 +40,7 @@ module HybridPlatformsConductorTest
       #     Nodes for which the property can't be fetched can be ommitted.
       def get_upcase(nodes, metadata)
         record_call(:get_upcase, nodes, metadata)
-        nodes.map { |node| [node, node.upcase] }.to_h
+        nodes.to_h { |node| [node, node.upcase] }
       end
 
       # Get a specific property for a given set of nodes.
@@ -55,7 +55,7 @@ module HybridPlatformsConductorTest
       #     Nodes for which the property can't be fetched can be ommitted.
       def get_double(nodes, metadata)
         record_call(:get_double, nodes, metadata)
-        nodes.map { |node| [node, node * 2] }.to_h
+        nodes.to_h { |node| [node, node * 2] }
       end
 
       # Get a specific property for a given set of nodes.
@@ -70,7 +70,7 @@ module HybridPlatformsConductorTest
       #     Nodes for which the property can't be fetched can be ommitted.
       def get_reversed_double(nodes, metadata)
         record_call(:get_reversed_double, nodes, metadata)
-        nodes.map { |node| [node, metadata[node][:double].reverse] }.to_h
+        nodes.to_h { |node| [node, metadata[node][:double].reverse] }
       end
 
       # Get a specific property for a given set of nodes.
@@ -85,7 +85,7 @@ module HybridPlatformsConductorTest
       #     Nodes for which the property can't be fetched can be ommitted.
       def get_reversed_downcase(nodes, metadata)
         record_call(:get_reversed_downcase, nodes, metadata)
-        nodes.map { |node| [node, metadata[node][:downcase] ? metadata[node][:downcase].reverse : 'UNKNOWN'] }.to_h
+        nodes.to_h { |node| [node, metadata[node][:downcase] ? metadata[node][:downcase].reverse : 'UNKNOWN'] }
       end
 
       # Get a specific property for a given set of nodes.
@@ -115,7 +115,7 @@ module HybridPlatformsConductorTest
       #     Nodes for which the property can't be fetched can be ommitted.
       def get_same_comment(nodes, metadata)
         record_call(:get_same_comment, nodes, metadata)
-        nodes.map { |node| [node, "Comment for #{node}"] }.to_h
+        nodes.to_h { |node| [node, "Comment for #{node}"] }
       end
 
       # Get a specific property for a given set of nodes.
@@ -130,7 +130,7 @@ module HybridPlatformsConductorTest
       #     Nodes for which the property can't be fetched can be ommitted.
       def get_different_comment(nodes, metadata)
         record_call(:get_different_comment, nodes, metadata)
-        nodes.map { |node| [node, 'Comment from test_cmdb'] }.to_h
+        nodes.to_h { |node| [node, 'Comment from test_cmdb'] }
       end
 
       # Get a specific property for a given set of nodes.
@@ -145,7 +145,7 @@ module HybridPlatformsConductorTest
       #     Nodes for which the property can't be fetched can be ommitted.
       def get_different_comment_2(nodes, metadata)
         record_call(:get_different_comment_2, nodes, metadata)
-        nodes.map { |node| [node, 'Comment2 from test_cmdb'] }.to_h
+        nodes.to_h { |node| [node, 'Comment2 from test_cmdb'] }
       end
 
       # Register a call to be checked by the tests later
@@ -156,7 +156,7 @@ module HybridPlatformsConductorTest
       def record_call(method, *args)
         @calls = [] unless defined?(@calls)
         # Create a shallow copy of the args, just to make sure they won't get changed by later code
-        @calls << [method] + Marshal.load(Marshal.dump(args))
+        @calls << ([method] + Marshal.load(Marshal.dump(args)))
       end
 
     end

data/spec/hybrid_platforms_conductor_test/cmdb_plugins/test_cmdb_2.rb

@@ -27,7 +27,7 @@ module HybridPlatformsConductorTest
       def get_nothing(nodes, metadata)
         record_call(:get_nothing, nodes, metadata)
         # Here we return something to test that if the first one fails we have the second CMDB
-        nodes.map { |node| [node, "#{node} has nothing"] }.to_h
+        nodes.to_h { |node| [node, "#{node} has nothing"] }
       end
 
       # Get a specific property for a given set of nodes.
@@ -42,7 +42,7 @@ module HybridPlatformsConductorTest
       #     Nodes for which the property can't be fetched can be ommitted.
       def get_same_comment(nodes, metadata)
         record_call(:get_same_comment, nodes, metadata)
-        nodes.map { |node| [node, "Comment for #{node}"] }.to_h
+        nodes.to_h { |node| [node, "Comment for #{node}"] }
       end
 
       # Get a specific property for a given set of nodes.
@@ -57,7 +57,7 @@ module HybridPlatformsConductorTest
       #     Nodes for which the property can't be fetched can be ommitted.
       def get_different_comment(nodes, metadata)
         record_call(:get_different_comment, nodes, metadata)
-        nodes.map { |node| [node, 'Comment from test_cmdb_2'] }.to_h
+        nodes.to_h { |node| [node, 'Comment from test_cmdb_2'] }
       end
 
       # Get a specific property for a given set of nodes.
@@ -72,7 +72,7 @@ module HybridPlatformsConductorTest
       #     Nodes for which the property can't be fetched can be ommitted.
       def get_different_comment_2(nodes, metadata)
         record_call(:get_different_comment_2, nodes, metadata)
-        nodes.map { |node| [node, 'Comment2 from test_cmdb_2'] }.to_h
+        nodes.to_h { |node| [node, 'Comment2 from test_cmdb_2'] }
       end
 
       # Register a call to be checked by the tests later
@@ -83,7 +83,7 @@ module HybridPlatformsConductorTest
       def record_call(method, *args)
         @calls = [] unless defined?(@calls)
         # Create a shallow copy of the args, just to make sure they won't get changed by later code
-        @calls << [method] + Marshal.load(Marshal.dump(args))
+        @calls << ([method] + Marshal.load(Marshal.dump(args)))
       end
 
     end

data/spec/hybrid_platforms_conductor_test/cmdb_plugins/test_cmdb_others.rb

@@ -30,7 +30,7 @@ module HybridPlatformsConductorTest
       #     Nodes for which the property can't be fetched can be ommitted.
       def get_others(nodes, metadata)
         record_call(:get_others, nodes, metadata)
-        nodes.map do |node|
+        nodes.to_h do |node|
           [
             node,
             {
@@ -39,7 +39,7 @@ module HybridPlatformsConductorTest
               nothing: "#{node} has another nothing"
             }
           ]
-        end.to_h
+        end
       end
 
       # Register a call to be checked by the tests later
@@ -50,7 +50,7 @@ module HybridPlatformsConductorTest
       def record_call(method, *args)
         @calls = [] unless defined?(@calls)
         # Create a shallow copy of the args, just to make sure they won't get changed by later code
-        @calls << [method] + Marshal.load(Marshal.dump(args))
+        @calls << ([method] + Marshal.load(Marshal.dump(args)))
       end
 
     end