hybrid_platforms_conductor 33.9.0 → 33.9.4

data/lib/hybrid_platforms_conductor/plugins.rb

@@ -75,10 +75,11 @@ module HybridPlatformsConductor
     # Register plugins by parsing gems
     def register_plugins_from_gems
       # Require all possible files that could define such a plugin, from all gems
-      files_regexp = %r{lib/(.*hpc_plugins/#{Regexp.escape(@plugins_type.to_s)}/[^/]+)\.rb$}
-      Gem.loaded_specs.each do |gem_name, gem_specs|
+      Gem.loaded_specs.clone.each do |gem_name, gem_specs|
+        gem_path = gem_specs.full_gem_path
+        files_regexp = %r{#{Regexp.escape(gem_path)}/lib/(.*hpc_plugins/#{Regexp.escape(@plugins_type.to_s)}/[^/]+)\.rb$}
         # Careful to not use gem_specs.files here as if your gem name contains "-" or other weird characters, files won't appear in the gemspec list.
-        Dir.glob("#{gem_specs.full_gem_path}/lib/**/*.rb").each do |file|
+        Dir.glob("#{gem_path}/lib/**/*.rb").each do |file|
           next unless file =~ files_regexp
 
           require_name = Regexp.last_match(1)

data/lib/hybrid_platforms_conductor/tests_runner.rb

@@ -524,14 +524,14 @@ module HybridPlatformsConductor
           nodes_to_test = selected_tests.map(&:node).uniq.sort
           @outputs =
             if @skip_run
-              nodes_to_test.map do |node|
+              nodes_to_test.to_h do |node|
                 run_log_file_name = "#{@config.hybrid_platforms_dir}/run_logs/#{node}.stdout"
                 [
                   node,
                   # TODO: Find a way to also save stderr and the status code
                   [0, File.exist?(run_log_file_name) ? File.read(run_log_file_name) : nil, '']
                 ]
-              end.to_h
+              end
             else
               # Why-run deploy on all nodes
               @deployer.concurrent_execution = !log_debug?

data/lib/hybrid_platforms_conductor/topographer.rb

@@ -112,15 +112,14 @@ module HybridPlatformsConductor
       # Parse plugins
       @plugins = Dir.
         glob("#{__dir__}/topographer/plugins/*.rb").
-        map do |file_name|
+        to_h do |file_name|
           plugin_name = File.basename(file_name)[0..-4].to_sym
           require file_name
           [
             plugin_name,
             Topographer::Plugins.const_get(plugin_name.to_s.split('_').collect(&:capitalize).join.to_sym)
           ]
-        end.
-        to_h
+        end
 
       @ips_to_host = known_ips.clone
 
@@ -132,11 +131,11 @@ module HybridPlatformsConductor
       ]
       @nodes_handler.prefetch_metadata_of @nodes_handler.known_nodes, metadata_properties
       @nodes_handler.known_nodes.each do |hostname|
-        @node_metadata[hostname] = metadata_properties.map { |property| [property, @nodes_handler.metadata_of(hostname, property)] }.to_h
+        @node_metadata[hostname] = metadata_properties.to_h { |property| [property, @nodes_handler.metadata_of(hostname, property)] }
       end
 
       # Small cache of hostnames used a lot to parse JSON
-      @known_nodes = @nodes_handler.known_nodes.map { |hostname| [hostname, nil] }.to_h
+      @known_nodes = @nodes_handler.known_nodes.to_h { |hostname| [hostname, nil] }
       # Cache of objects being used a lot in parsing for performance
       @non_word_regexp = /\W+/
       @ip_regexp = %r{(\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3})(/(\d{1,2})|[^\d/]|$)}
@@ -600,7 +599,7 @@ module HybridPlatformsConductor
       @ips_mask[ip_def] = {} unless @ips_mask.key?(ip_def)
       unless @ips_mask[ip_def].key?(ip_mask)
         # For performance, keep a cache of all the IPAddress::IPv4 objects
-        @ip_v4_cache = known_ips.keys.map { |ip, _node| [ip, IPAddress::IPv4.new(ip)] }.to_h unless defined?(@ip_v4_cache)
+        @ip_v4_cache = known_ips.keys.to_h { |ip, _node| [ip, IPAddress::IPv4.new(ip)] } unless defined?(@ip_v4_cache)
         ip_range = IPAddress::IPv4.new("#{ip_def}/#{ip_mask}")
         @ips_mask[ip_def][ip_mask] = @ip_v4_cache.select { |_ip, ipv4| ip_range.include?(ipv4) }.keys
       end

data/lib/hybrid_platforms_conductor/version.rb

@@ -1,5 +1,5 @@
 module HybridPlatformsConductor
 
-  VERSION = '33.9.0'
+  VERSION = '33.9.4'
 
 end

data/spec/hybrid_platforms_conductor_test/api/actions_executor/actions/bash_spec.rb

@@ -54,7 +54,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
             },
             log_to_dir: logs_dir
           )
-          expect(File.exist?("#{logs_dir}/node.stdout")).to eq true
+          expect(File.exist?("#{logs_dir}/node.stdout")).to be true
           expect(File.read("#{logs_dir}/node.stdout")).to eq "TestStdout\nTestStderr\n"
         end
       end

data/spec/hybrid_platforms_conductor_test/api/actions_executor/actions/ruby_spec.rb

@@ -18,7 +18,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
             }
           )['node']
         ).to eq [0, 'TestStdout', 'TestStderr']
-        expect(executed).to eq true
+        expect(executed).to be true
       end
     end
 
@@ -38,7 +38,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
             timeout: 1
           )['node']
         ).to eq [:timeout, '', '']
-        expect(executed).to eq false
+        expect(executed).to be false
       end
     end
 
@@ -54,7 +54,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
             } },
             log_to_dir: logs_dir
           )
-          expect(File.exist?("#{logs_dir}/node.stdout")).to eq true
+          expect(File.exist?("#{logs_dir}/node.stdout")).to be true
           expect(File.read("#{logs_dir}/node.stdout")).to eq "TestStdout\nTestStderr\n"
         end
       end
@@ -68,7 +68,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
             {
               'node' => {
                 ruby: proc do |stdout, stderr, action|
-                  expect(action.is_a?(HybridPlatformsConductor::HpcPlugins::Action::Ruby)).to eq true
+                  expect(action.is_a?(HybridPlatformsConductor::HpcPlugins::Action::Ruby)).to be true
                   stdout << 'TestStdout'
                   stderr << 'TestStderr'
                   executed = true
@@ -77,7 +77,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
             }
           )['node']
         ).to eq [0, 'TestStdout', 'TestStderr']
-        expect(executed).to eq true
+        expect(executed).to be true
       end
     end
 
@@ -90,7 +90,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
               'node' => {
                 ruby: {
                   code: proc do |stdout, stderr, _action, connector|
-                    expect(connector.is_a?(HybridPlatformsConductorTest::TestConnector)).to eq true
+                    expect(connector.is_a?(HybridPlatformsConductorTest::TestConnector)).to be true
                     stdout << 'TestStdout'
                     stderr << 'TestStderr'
                     executed = true
@@ -101,7 +101,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
             }
           )['node']
         ).to eq [0, 'TestStdout', 'TestStderr']
-        expect(executed).to eq true
+        expect(executed).to be true
       end
     end
 
@@ -125,7 +125,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
             }
           )['node']
         ).to eq [0, 'TestStdout', 'TestStderr']
-        expect(executed).to eq true
+        expect(executed).to be true
       end
     end
 

data/spec/hybrid_platforms_conductor_test/api/actions_executor/connectors/ssh/cli_options_spec.rb

@@ -60,7 +60,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
       it 'does not use the SSH control master' do
         with_test_platform_for_cli do
           expect_actions_executor_runs [proc do
-            expect(test_connector.ssh_use_control_master).to eq false
+            expect(test_connector.ssh_use_control_master).to be false
             {}
           end]
           exit_code, stdout, stderr = run 'run', '--node', 'node', '--command', 'echo Hello', '--ssh-no-control-master'
@@ -73,7 +73,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
       it 'does not use strict host key checking' do
         with_test_platform_for_cli do
           expect_actions_executor_runs [proc do
-            expect(test_connector.ssh_strict_host_key_checking).to eq false
+            expect(test_connector.ssh_strict_host_key_checking).to be false
             {}
           end]
           exit_code, stdout, stderr = run 'run', '--node', 'node', '--command', 'echo Hello', '--ssh-no-host-key-checking'
@@ -111,7 +111,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
       it 'expects passwords to be input' do
         with_test_platform_for_cli do
           expect_actions_executor_runs [proc do
-            expect(test_connector.auth_password).to eq true
+            expect(test_connector.auth_password).to be true
             {}
           end]
           exit_code, stdout, stderr = run 'run', '--node', 'node', '--command', 'echo Hello', '--password'

data/spec/hybrid_platforms_conductor_test/api/actions_executor/connectors/ssh/connections_spec.rb

@@ -536,14 +536,14 @@ describe HybridPlatformsConductor::ActionsExecutor do
               test_connector.with_connection_to(['node']) do
                 test_connector.prepare_for('node', nil, stdout, stderr)
                 ssh_exec_2 = test_connector.ssh_exec
-                expect(File.exist?(ssh_exec_1)).to eq true
-                expect(File.exist?(ssh_exec_2)).to eq true
+                expect(File.exist?(ssh_exec_1)).to be true
+                expect(File.exist?(ssh_exec_2)).to be true
               end
-              expect(File.exist?(ssh_exec_1)).to eq true
-              expect(File.exist?(ssh_exec_2)).to eq false
+              expect(File.exist?(ssh_exec_1)).to be true
+              expect(File.exist?(ssh_exec_2)).to be false
             end
-            expect(File.exist?(ssh_exec_1)).to eq false
-            expect(File.exist?(ssh_exec_2)).to eq false
+            expect(File.exist?(ssh_exec_1)).to be false
+            expect(File.exist?(ssh_exec_2)).to be false
           end
         end
       end
@@ -590,13 +590,13 @@ describe HybridPlatformsConductor::ActionsExecutor do
               ['which env', proc { [0, "/usr/bin/env\n", ''] }],
               ['ssh -V 2>&1', proc { [0, "OpenSSH_7.4p1 Debian-10+deb9u7, OpenSSL 1.0.2u  20 Dec 2019\n", ''] }]
             ] +
-              [[
+              ([[
                 %r{^.+/ssh -o BatchMode=yes -o ControlMaster=yes -o ControlPersist=yes hpc\.node true$},
                 proc do
                   nbr_boot_messages += 1
                   [255, '', "System is booting up. See pam_nologin(8)\nAuthentication failed.\n"]
                 end
-              ]] * 3 +
+              ]] * 3) +
               ssh_expected_commands_for({ 'node' => { connection: '192.168.42.42', user: 'test_user' } })
           ) do
             test_connector.ssh_user = 'test_user'

data/spec/hybrid_platforms_conductor_test/api/actions_executor/connectors/ssh/global_helpers_spec.rb

@@ -246,7 +246,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
             Host hpc.node1
               Hostname 192.168.42.1
           EO_SSH_CONFIG
-          expect(ssh_config_for('node2', nodes: %w[node1 node3])).to eq nil
+          expect(ssh_config_for('node2', nodes: %w[node1 node3])).to be_nil
         end
       end
 

data/spec/hybrid_platforms_conductor_test/api/actions_executor/helpers_spec.rb

@@ -11,14 +11,14 @@ describe HybridPlatformsConductor::ActionsExecutor do
     it 'returns if a user has privileged access on a node' do
       with_test_platform({ nodes: { 'node' => {} } }) do
         test_actions_executor.connector(:ssh).ssh_user = 'test_user'
-        expect(test_actions_executor.privileged_access?('node')).to eq false
+        expect(test_actions_executor.privileged_access?('node')).to be false
       end
     end
 
     it 'returns if a user has privileged access on a node when connecting with root' do
       with_test_platform({ nodes: { 'node' => {} } }) do
         test_actions_executor.connector(:ssh).ssh_user = 'root'
-        expect(test_actions_executor.privileged_access?('node')).to eq true
+        expect(test_actions_executor.privileged_access?('node')).to be true
       end
     end
 
@@ -28,7 +28,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
           ['whoami', proc { [0, 'test_user', ''] }]
         ] do
           test_actions_executor.connector(:ssh).ssh_user = 'test_user'
-          expect(test_actions_executor.privileged_access?('node')).to eq false
+          expect(test_actions_executor.privileged_access?('node')).to be false
         end
       end
     end
@@ -39,7 +39,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
           ['whoami', proc { [0, 'root', ''] }]
         ] do
           test_actions_executor.connector(:ssh).ssh_user = 'test_user'
-          expect(test_actions_executor.privileged_access?('node')).to eq true
+          expect(test_actions_executor.privileged_access?('node')).to be true
         end
       end
     end

data/spec/hybrid_platforms_conductor_test/api/actions_executor/timeout_spec.rb

@@ -15,7 +15,7 @@ describe HybridPlatformsConductor::ActionsExecutor do
         expect(test_actions_executor.execute_actions(
           {
             'node' => { test_action: { code: proc do |stdout, _stderr, action|
-              expect(action.timeout).to eq nil
+              expect(action.timeout).to be_nil
               stdout << 'Hello'
             end } }
           }

data/spec/hybrid_platforms_conductor_test/api/cmd_runner_spec.rb

@@ -168,7 +168,7 @@ describe HybridPlatformsConductor::CmdRunner do
       cmd_runner = test_cmd_runner
       cmd_runner.dry_run = true
       expect(cmd_runner.run_cmd("echo TestContent >#{repository}/test_file")).to eq [0, '', '']
-      expect(File.exist?("#{repository}/test_file")).to eq false
+      expect(File.exist?("#{repository}/test_file")).to be false
     end
   end
 
@@ -177,7 +177,7 @@ describe HybridPlatformsConductor::CmdRunner do
       cmd_runner = test_cmd_runner
       cmd_runner.dry_run = true
       expect(cmd_runner.run_cmd("echo TestContent >#{repository}/test_file", expected_code: 2)).to eq [2, '', '']
-      expect(File.exist?("#{repository}/test_file")).to eq false
+      expect(File.exist?("#{repository}/test_file")).to be false
     end
   end
 
@@ -190,13 +190,13 @@ describe HybridPlatformsConductor::CmdRunner do
   it 'returns non-root user when user is not root' do
     cmd_runner = test_cmd_runner
     expect(cmd_runner).to receive(:run_cmd).with('whoami', log_to_stdout: false).and_return [0, 'not_root', '']
-    expect(cmd_runner.root?).to eq false
+    expect(cmd_runner.root?).to be false
   end
 
   it 'returns root user when user is root' do
     cmd_runner = test_cmd_runner
     expect(cmd_runner).to receive(:run_cmd).with('whoami', log_to_stdout: false).and_return [0, 'root', '']
-    expect(cmd_runner.root?).to eq true
+    expect(cmd_runner.root?).to be true
   end
 
   it 'returns the correct executable prefix' do

data/spec/hybrid_platforms_conductor_test/api/deployer/deploy_spec.rb

@@ -196,6 +196,50 @@ describe HybridPlatformsConductor::Deployer do
         end
       end
 
+      it 'gets deployment info from log plugins returning UTF-8 characters' do
+        with_test_platform_for_deploy_tests({ nodes: { 'node' => {} } }) do
+          HybridPlatformsConductorTest::TestLogPlugin.mocked_logs = {
+            'node' => {
+              deployment_info: { user: 'test_user' },
+              exit_status: 666,
+              services: %w[unknown],
+              stderr: 'stderrの展開テストログ',
+              stdout: 'stdoutの展開テストログ'
+            }
+          }
+          expect_actions_executor_runs [
+            # Expect the actions to get log files
+            proc do |actions_per_nodes|
+              expect(actions_per_nodes).to eq('node' => [{ bash: 'echo Read logs for node' }])
+              # Simulate the fact that data returned by the ssh system calls can contain UTF-8 chars, but is perceived as binary
+              { 'node' => [42, 'ログファイルはstdoutを読み取ります'.force_encoding('BINARY'), 'ログファイルはstderrを読み取ります'.force_encoding('BINARY')] }
+            end
+          ]
+          expect(test_deployer.deployment_info_from('node')).to eq(
+            'node' => {
+              deployment_info: { user: 'test_user' },
+              exit_status: 666,
+              services: %w[unknown],
+              stderr: 'stderrの展開テストログ',
+              stdout: 'stdoutの展開テストログ'
+            }
+          )
+          expect(HybridPlatformsConductorTest::TestLogPlugin.calls).to eq [
+            {
+              method: :actions_to_read_logs,
+              node: 'node'
+            },
+            {
+              method: :logs_for,
+              node: 'node',
+              exit_status: 42,
+              stdout: 'ログファイルはstdoutを読み取ります',
+              stderr: 'ログファイルはstderrを読み取ります'
+            }
+          ]
+        end
+      end
+
       it 'gets deployment info from log plugins not having actions_to_read_logs' do
         with_test_platform_for_deploy_tests({ nodes: { 'node' => {} } }, additional_config: 'send_logs_to :test_log_no_read') do
           expect(test_deployer.deployment_info_from('node')).to eq(

data/spec/hybrid_platforms_conductor_test/api/deployer/log_plugins/remote_fs_spec.rb

@@ -34,7 +34,7 @@ describe HybridPlatformsConductor::Deployer do
                 expect(actions_per_nodes['node'][0].keys.sort).to eq %i[ruby remote_bash].sort
                 expect(actions_per_nodes['node'][0][:remote_bash]).to eq 'sudo -u root mkdir -p /var/log/deployments && sudo -u root chmod 600 /var/log/deployments'
                 expect(actions_per_nodes['node'][1].keys.sort).to eq %i[scp].sort
-                expect(actions_per_nodes['node'][1][:scp].delete(:sudo)).to eq true
+                expect(actions_per_nodes['node'][1][:scp].delete(:sudo)).to be true
                 expect(actions_per_nodes['node'][1][:scp].delete(:owner)).to eq 'root'
                 expect(actions_per_nodes['node'][1][:scp].delete(:group)).to eq 'root'
                 expect(actions_per_nodes['node'][1][:scp].size).to eq 1
@@ -44,7 +44,7 @@ describe HybridPlatformsConductor::Deployer do
                 expect(actions_per_nodes['node'][2][:remote_bash]).to eq "sudo -u root chmod 600 /var/log/deployments/#{File.basename(tmp_log_file)}"
                 # Call the Ruby codes to be tested
                 actions_per_nodes['node'][0][:ruby].call
-                expect(File.exist?(tmp_log_file)).to eq true
+                expect(File.exist?(tmp_log_file)).to be true
                 file_content_regexp = Regexp.new <<~EOREGEXP
                   repo_name_0: platform
                   commit_id_0: 123456
@@ -62,7 +62,7 @@ describe HybridPlatformsConductor::Deployer do
                 expect(File.read(tmp_log_file)).to match file_content_regexp
                 actions_per_nodes['node'][2][:ruby].call
                 # Check temporary log file gets deleted for security reasons
-                expect(File.exist?(tmp_log_file)).to eq false
+                expect(File.exist?(tmp_log_file)).to be false
               end
             ]
             expect(test_deployer.deploy_on('node')).to eq('node' => [0, 'Deploy successful stdout', 'Deploy successful stderr'])
@@ -93,7 +93,7 @@ describe HybridPlatformsConductor::Deployer do
                 expect(actions_per_nodes['node'][0].keys.sort).to eq %i[ruby remote_bash].sort
                 expect(actions_per_nodes['node'][0][:remote_bash]).to eq 'mkdir -p /var/log/deployments && chmod 600 /var/log/deployments'
                 expect(actions_per_nodes['node'][1].keys.sort).to eq %i[scp].sort
-                expect(actions_per_nodes['node'][1][:scp].delete(:sudo)).to eq false
+                expect(actions_per_nodes['node'][1][:scp].delete(:sudo)).to be false
                 expect(actions_per_nodes['node'][1][:scp].delete(:owner)).to eq 'root'
                 expect(actions_per_nodes['node'][1][:scp].delete(:group)).to eq 'root'
                 expect(actions_per_nodes['node'][1][:scp].size).to eq 1
@@ -103,7 +103,7 @@ describe HybridPlatformsConductor::Deployer do
                 expect(actions_per_nodes['node'][2][:remote_bash]).to eq "chmod 600 /var/log/deployments/#{File.basename(tmp_log_file)}"
                 # Call the Ruby codes to be tested
                 actions_per_nodes['node'][0][:ruby].call
-                expect(File.exist?(tmp_log_file)).to eq true
+                expect(File.exist?(tmp_log_file)).to be true
                 file_content_regexp = Regexp.new <<~EOREGEXP
                   repo_name_0: platform
                   commit_id_0: 123456
@@ -121,7 +121,7 @@ describe HybridPlatformsConductor::Deployer do
                 expect(File.read(tmp_log_file)).to match file_content_regexp
                 actions_per_nodes['node'][2][:ruby].call
                 # Check temporary log file gets deleted for security reasons
-                expect(File.exist?(tmp_log_file)).to eq false
+                expect(File.exist?(tmp_log_file)).to be false
               end
             ]
             expect(test_deployer.deploy_on('node')).to eq('node' => [0, 'Deploy successful stdout', 'Deploy successful stderr'])
@@ -150,7 +150,7 @@ describe HybridPlatformsConductor::Deployer do
               expect(actions_per_nodes['node'][0].keys.sort).to eq %i[ruby remote_bash].sort
               expect(actions_per_nodes['node'][0][:remote_bash]).to eq 'sudo -u root mkdir -p /var/log/deployments && sudo -u root chmod 600 /var/log/deployments'
               expect(actions_per_nodes['node'][1].keys.sort).to eq %i[scp].sort
-              expect(actions_per_nodes['node'][1][:scp].delete(:sudo)).to eq true
+              expect(actions_per_nodes['node'][1][:scp].delete(:sudo)).to be true
               expect(actions_per_nodes['node'][1][:scp].delete(:owner)).to eq 'root'
               expect(actions_per_nodes['node'][1][:scp].delete(:group)).to eq 'root'
               expect(actions_per_nodes['node'][1][:scp].size).to eq 1
@@ -160,7 +160,7 @@ describe HybridPlatformsConductor::Deployer do
               expect(actions_per_nodes['node'][2][:remote_bash]).to eq "sudo -u root chmod 600 /var/log/deployments/#{File.basename(tmp_log_file)}"
               # Call the Ruby codes to be tested
               actions_per_nodes['node'][0][:ruby].call
-              expect(File.exist?(tmp_log_file)).to eq true
+              expect(File.exist?(tmp_log_file)).to be true
               file_content_regexp = Regexp.new <<~EOREGEXP
                 repo_name_0: platform
                 commit_id_0: 123456
@@ -178,7 +178,7 @@ describe HybridPlatformsConductor::Deployer do
               expect(File.read(tmp_log_file)).to match file_content_regexp
               actions_per_nodes['node'][2][:ruby].call
               # Check temporary log file gets deleted for security reasons
-              expect(File.exist?(tmp_log_file)).to eq false
+              expect(File.exist?(tmp_log_file)).to be false
             end
           ]
           with_cmd_runner_mocked [
@@ -211,7 +211,7 @@ describe HybridPlatformsConductor::Deployer do
               expect(actions_per_nodes['node'][0].keys.sort).to eq %i[ruby remote_bash].sort
               expect(actions_per_nodes['node'][0][:remote_bash]).to eq 'mkdir -p /var/log/deployments && chmod 600 /var/log/deployments'
               expect(actions_per_nodes['node'][1].keys.sort).to eq %i[scp].sort
-              expect(actions_per_nodes['node'][1][:scp].delete(:sudo)).to eq false
+              expect(actions_per_nodes['node'][1][:scp].delete(:sudo)).to be false
               expect(actions_per_nodes['node'][1][:scp].delete(:owner)).to eq 'root'
               expect(actions_per_nodes['node'][1][:scp].delete(:group)).to eq 'root'
               expect(actions_per_nodes['node'][1][:scp].size).to eq 1
@@ -221,7 +221,7 @@ describe HybridPlatformsConductor::Deployer do
               expect(actions_per_nodes['node'][2][:remote_bash]).to eq "chmod 600 /var/log/deployments/#{File.basename(tmp_log_file)}"
               # Call the Ruby codes to be tested
               actions_per_nodes['node'][0][:ruby].call
-              expect(File.exist?(tmp_log_file)).to eq true
+              expect(File.exist?(tmp_log_file)).to be true
               file_content_regexp = Regexp.new <<~EOREGEXP
                 repo_name_0: platform
                 commit_id_0: 123456
@@ -239,7 +239,7 @@ describe HybridPlatformsConductor::Deployer do
               expect(File.read(tmp_log_file)).to match file_content_regexp
               actions_per_nodes['node'][2][:ruby].call
               # Check temporary log file gets deleted for security reasons
-              expect(File.exist?(tmp_log_file)).to eq false
+              expect(File.exist?(tmp_log_file)).to be false
             end
           ]
           with_cmd_runner_mocked [

data/spec/hybrid_platforms_conductor_test/api/deployer/provisioner_spec.rb

@@ -14,7 +14,7 @@ describe HybridPlatformsConductor::Deployer do
         expect(Socket).to receive(:tcp).with('172.17.0.1', 22, { connect_timeout: 1 }).and_yield
         provisioner = nil
         test_deployer.with_test_provisioned_instance(:test_provisioner, 'node', environment: 'hpc_testing_provisioner') do |sub_test_deployer, test_instance|
-          expect(sub_test_deployer.local_environment).to eq true
+          expect(sub_test_deployer.local_environment).to be true
           provisioner = test_instance
           expect(test_instance.node).to eq 'node'
           expect(test_instance.environment).to match(/^#{Regexp.escape(`whoami`.strip)}_hpc_testing_provisioner_\d+_\d+_\w+$/)
@@ -33,7 +33,7 @@ describe HybridPlatformsConductor::Deployer do
         expect(Socket).to receive(:tcp).with('172.17.0.1', 22, { connect_timeout: 666 }).and_yield
         provisioner = nil
         test_deployer.with_test_provisioned_instance(:test_provisioner, 'node', environment: 'hpc_testing_provisioner') do |sub_test_deployer, test_instance|
-          expect(sub_test_deployer.local_environment).to eq true
+          expect(sub_test_deployer.local_environment).to be true
           provisioner = test_instance
           expect(test_instance.node).to eq 'node'
           expect(test_instance.environment).to match(/^#{Regexp.escape(`whoami`.strip)}_hpc_testing_provisioner_\d+_\d+_\w+$/)
@@ -65,8 +65,8 @@ describe HybridPlatformsConductor::Deployer do
         expect(Socket).to receive(:tcp).with('172.17.0.1', 22, { connect_timeout: 1 }).and_yield
         test_deployer.with_test_provisioned_instance(:test_provisioner, 'node1', environment: 'hpc_testing_provisioner') do |sub_test_deployer, test_instance|
           sub_nodes_handler = sub_test_deployer.instance_variable_get(:@nodes_handler)
-          expect(sub_nodes_handler.get_ssh_session_exec_of('node1')).to eq true
-          expect(sub_nodes_handler.get_ssh_session_exec_of('node2')).to eq false
+          expect(sub_nodes_handler.get_ssh_session_exec_of('node1')).to be true
+          expect(sub_nodes_handler.get_ssh_session_exec_of('node2')).to be false
           ssh_transforms = test_instance.instance_variable_get(:@config).ssh_connection_transforms
           expect(ssh_transforms.size).to eq 1
           expect(ssh_transforms[0][:nodes_selectors_stack]).to eq [%w[node2]]
@@ -90,8 +90,8 @@ describe HybridPlatformsConductor::Deployer do
         expect(Socket).to receive(:tcp).with('172.17.0.1', 22, { connect_timeout: 1 }).and_yield
         test_deployer.with_test_provisioned_instance(:test_provisioner, 'node1', environment: 'hpc_testing_provisioner') do |sub_test_deployer|
           sub_nodes_handler = sub_test_deployer.instance_variable_get(:@nodes_handler)
-          expect(sub_nodes_handler.get_local_node_of('node1')).to eq false
-          expect(sub_nodes_handler.get_local_node_of('node2')).to eq true
+          expect(sub_nodes_handler.get_local_node_of('node1')).to be false
+          expect(sub_nodes_handler.get_local_node_of('node2')).to be true
         end
       end
     end
@@ -132,7 +132,7 @@ describe HybridPlatformsConductor::Deployer do
         expect(Socket).to receive(:tcp).with('172.17.0.1', 22, { connect_timeout: 1 }).and_yield
         provisioner = nil
         test_deployer.with_test_provisioned_instance(:test_provisioner, 'node', environment: 'hpc_testing_provisioner', reuse_instance: true) do |sub_test_deployer, test_instance|
-          expect(sub_test_deployer.local_environment).to eq true
+          expect(sub_test_deployer.local_environment).to be true
           provisioner = test_instance
           expect(test_instance.node).to eq 'node'
           expect(test_instance.environment).to eq "#{`whoami`.strip}_hpc_testing_provisioner"
@@ -150,7 +150,7 @@ describe HybridPlatformsConductor::Deployer do
         expect(Socket).to receive(:tcp).with('172.17.0.1', 22, { connect_timeout: 1 }).and_yield
         provisioner = nil
         test_deployer.with_test_provisioned_instance(:test_provisioner, 'node', environment: 'hpc_testing_provisioner', reuse_instance: true) do |sub_test_deployer, test_instance|
-          expect(sub_test_deployer.local_environment).to eq true
+          expect(sub_test_deployer.local_environment).to be true
           provisioner = test_instance
           expect(test_instance.node).to eq 'node'
           expect(test_instance.environment).to eq "#{`whoami`.strip}_hpc_testing_provisioner"

data/spec/hybrid_platforms_conductor_test/api/deployer/provisioners/docker_spec.rb

@@ -48,7 +48,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Docker do
       instance.wait_for_state! :created
       begin
         # Test that the instance is created
-        expect(::Docker::Container.all(all: true).find { |container| container.info['Names'].include? "/hpc_docker_container_node_#{environment}" }).not_to eq nil
+        expect(::Docker::Container.all(all: true).find { |container| container.info['Names'].include? "/hpc_docker_container_node_#{environment}" }).not_to be_nil
         expect(instance.state).to eq :created
       ensure
         # Clean the Docker containers if needed