hybrid_platforms_conductor 33.9.0 → 33.9.4

data/spec/hybrid_platforms_conductor_test/api/deployer/provisioners/proxmox/reserve_proxmox_container/expired_containers_spec.rb

@@ -14,7 +14,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
                 memory_total: 4 * 1024 * 1024 * 1024,
                 lxc_containers: {
                   # Make sure it is expired
-                  1000 => { ip: '192.168.0.100', maxmem: 1024 * 1024 * 1024, creation_date: (Time.now - 31 * 24 * 60 * 60).utc }
+                  1000 => { ip: '192.168.0.100', maxmem: 1024 * 1024 * 1024, creation_date: (Time.now - (31 * 24 * 60 * 60)).utc }
                 }
               }
             }
@@ -29,7 +29,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
 
       it 'expires a VM when there are not enough free resources on a PVE node' do
         with_sync_node do
-          creation_date = (Time.now - 31 * 24 * 60 * 60).utc
+          creation_date = (Time.now - (31 * 24 * 60 * 60)).utc
           mock_proxmox(
             mocked_pve_nodes: {
               'pve_node_name' => {
@@ -81,7 +81,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
                     maxmem: 4 * 1024 * 1024 * 1024,
                     status: 'stopped',
                     # Make sure it is expired
-                    creation_date: (Time.now - 31 * 24 * 60 * 60).utc
+                    creation_date: (Time.now - (31 * 24 * 60 * 60)).utc
                   }
                 }
               }
@@ -117,7 +117,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
                 memory_total: 8 * 1024 * 1024 * 1024,
                 lxc_containers: {
                   1000 => { ip: '192.168.0.100', maxmem: 2 * 1024 * 1024 * 1024, creation_date: Time.now.utc },
-                  1001 => { ip: '192.168.0.101', maxmem: 4 * 1024 * 1024 * 1024, creation_date: (Time.now - 31 * 24 * 60 * 60).utc },
+                  1001 => { ip: '192.168.0.101', maxmem: 4 * 1024 * 1024 * 1024, creation_date: (Time.now - (31 * 24 * 60 * 60)).utc },
                   1002 => { ip: '192.168.0.102', maxmem: 2 * 1024 * 1024 * 1024, creation_date: Time.now.utc }
                 }
               }
@@ -154,7 +154,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
                 memory_total: 6 * 1024 * 1024 * 1024,
                 lxc_containers: {
                   1000 => { ip: '192.168.0.100', maxmem: 2 * 1024 * 1024 * 1024, creation_date: Time.now.utc },
-                  1001 => { ip: '192.168.0.101', maxmem: 2 * 1024 * 1024 * 1024, creation_date: (Time.now - 31 * 24 * 60 * 60).utc },
+                  1001 => { ip: '192.168.0.101', maxmem: 2 * 1024 * 1024 * 1024, creation_date: (Time.now - (31 * 24 * 60 * 60)).utc },
                   1002 => { ip: '192.168.0.102', maxmem: 2 * 1024 * 1024 * 1024, creation_date: Time.now.utc }
                 }
               }
@@ -185,8 +185,8 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
                 memory_total: 8 * 1024 * 1024 * 1024,
                 lxc_containers: {
                   1000 => { ip: '192.168.0.100', maxmem: 2 * 1024 * 1024 * 1024, creation_date: Time.now.utc },
-                  1001 => { ip: '192.168.0.101', maxmem: 4 * 1024 * 1024 * 1024, creation_date: (Time.now - 31 * 24 * 60 * 60).utc },
-                  1002 => { ip: '192.168.0.102', maxmem: 2 * 1024 * 1024 * 1024, creation_date: (Time.now - 31 * 24 * 60 * 60).utc }
+                  1001 => { ip: '192.168.0.101', maxmem: 4 * 1024 * 1024 * 1024, creation_date: (Time.now - (31 * 24 * 60 * 60)).utc },
+                  1002 => { ip: '192.168.0.102', maxmem: 2 * 1024 * 1024 * 1024, creation_date: (Time.now - (31 * 24 * 60 * 60)).utc }
                 }
               }
             }
@@ -224,8 +224,8 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
                 memory_total: 8 * 1024 * 1024 * 1024,
                 lxc_containers: {
                   1000 => { ip: '192.168.0.100', maxmem: 2 * 1024 * 1024 * 1024, creation_date: Time.now.utc },
-                  1001 => { ip: '192.168.0.101', maxmem: 4 * 1024 * 1024 * 1024, creation_date: (Time.now - 31 * 24 * 60 * 60).utc },
-                  2002 => { ip: '192.168.0.102', maxmem: 2 * 1024 * 1024 * 1024, creation_date: (Time.now - 31 * 24 * 60 * 60).utc }
+                  1001 => { ip: '192.168.0.101', maxmem: 4 * 1024 * 1024 * 1024, creation_date: (Time.now - (31 * 24 * 60 * 60)).utc },
+                  2002 => { ip: '192.168.0.102', maxmem: 2 * 1024 * 1024 * 1024, creation_date: (Time.now - (31 * 24 * 60 * 60)).utc }
                 }
               }
             }
@@ -261,14 +261,14 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
               'pve_node_1' => {
                 memory_total: 16 * 1024 * 1024 * 1024,
                 lxc_containers: {
-                  1000 => { ip: '192.168.0.100', maxmem: 14 * 1024 * 1024 * 1024, creation_date: (Time.now - 31 * 24 * 60 * 60).utc }
+                  1000 => { ip: '192.168.0.100', maxmem: 14 * 1024 * 1024 * 1024, creation_date: (Time.now - (31 * 24 * 60 * 60)).utc }
                 }
               },
               # But this node has still a bit of resources left without expiring VMs
               'pve_node_2' => {
                 memory_total: 16 * 1024 * 1024 * 1024,
                 lxc_containers: {
-                  1001 => { ip: '192.168.0.101', maxmem: 10 * 1024 * 1024 * 1024, creation_date: (Time.now - 31 * 24 * 60 * 60).utc }
+                  1001 => { ip: '192.168.0.101', maxmem: 10 * 1024 * 1024 * 1024, creation_date: (Time.now - (31 * 24 * 60 * 60)).utc }
                 }
               }
             }
@@ -302,14 +302,14 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
                 memory_total: 16 * 1024 * 1024 * 1024,
                 lxc_containers: {
                   1000 => { ip: '192.168.0.100', maxmem: 8 * 1024 * 1024 * 1024, creation_date: Time.now.utc },
-                  1001 => { ip: '192.168.0.101', maxmem: 6 * 1024 * 1024 * 1024, creation_date: (Time.now - 31 * 24 * 60 * 60).utc }
+                  1001 => { ip: '192.168.0.101', maxmem: 6 * 1024 * 1024 * 1024, creation_date: (Time.now - (31 * 24 * 60 * 60)).utc }
                 }
               },
               'pve_node_2' => {
                 memory_total: 16 * 1024 * 1024 * 1024,
                 lxc_containers: {
                   1002 => { ip: '192.168.0.102', maxmem: 10 * 1024 * 1024 * 1024, creation_date: Time.now.utc },
-                  1003 => { ip: '192.168.0.103', maxmem: 4 * 1024 * 1024 * 1024, creation_date: (Time.now - 31 * 24 * 60 * 60).utc }
+                  1003 => { ip: '192.168.0.103', maxmem: 4 * 1024 * 1024 * 1024, creation_date: (Time.now - (31 * 24 * 60 * 60)).utc }
                 }
               }
             }
@@ -359,7 +359,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
                 memory_total: 16 * 1024 * 1024 * 1024,
                 lxc_containers: {
                   1000 => { ip: '192.168.0.100', maxmem: 1 * 1024 * 1024 * 1024, creation_date: Time.now.utc },
-                  1001 => { ip: '192.168.0.101', maxmem: 1 * 1024 * 1024 * 1024, creation_date: (Time.now - 31 * 24 * 60 * 60).utc },
+                  1001 => { ip: '192.168.0.101', maxmem: 1 * 1024 * 1024 * 1024, creation_date: (Time.now - (31 * 24 * 60 * 60)).utc },
                   1002 => { ip: '192.168.0.102', maxmem: 1 * 1024 * 1024 * 1024, creation_date: Time.now.utc }
                 }
               }
@@ -415,7 +415,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
               'pve_node_2' => {
                 memory_total: 2 * 1024 * 1024 * 1024,
                 lxc_containers: {
-                  1001 => { ip: '192.168.0.101', maxmem: 1 * 1024 * 1024 * 1024, creation_date: (Time.now - 31 * 24 * 60 * 60).utc }
+                  1001 => { ip: '192.168.0.101', maxmem: 1 * 1024 * 1024 * 1024, creation_date: (Time.now - (31 * 24 * 60 * 60)).utc }
                 }
               }
             }
@@ -463,7 +463,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
                 memory_total: 16 * 1024 * 1024 * 1024,
                 lxc_containers: {
                   1000 => { ip: '192.168.0.100', maxmem: 1 * 1024 * 1024 * 1024, creation_date: Time.now.utc },
-                  1001 => { ip: '192.168.0.101', maxmem: 1 * 1024 * 1024 * 1024, creation_date: (Time.now - 31 * 24 * 60 * 60).utc },
+                  1001 => { ip: '192.168.0.101', maxmem: 1 * 1024 * 1024 * 1024, creation_date: (Time.now - (31 * 24 * 60 * 60)).utc },
                   1002 => { ip: '192.168.0.102', maxmem: 1 * 1024 * 1024 * 1024, creation_date: Time.now.utc }
                 }
               }
@@ -521,7 +521,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
               'pve_node_2' => {
                 memory_total: 2 * 1024 * 1024 * 1024,
                 lxc_containers: {
-                  1001 => { ip: '192.168.0.101', maxmem: 1 * 1024 * 1024 * 1024, creation_date: (Time.now - 31 * 24 * 60 * 60).utc }
+                  1001 => { ip: '192.168.0.101', maxmem: 1 * 1024 * 1024 * 1024, creation_date: (Time.now - (31 * 24 * 60 * 60)).utc }
                 }
               }
             }
@@ -571,7 +571,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
                 memory_total: 16 * 1024 * 1024 * 1024,
                 lxc_containers: {
                   1000 => { ip: '192.168.0.100', maxmem: 1 * 1024 * 1024 * 1024, creation_date: Time.now.utc },
-                  1001 => { ip: '192.168.0.101', maxmem: 1 * 1024 * 1024 * 1024, creation_date: (Time.now - 31 * 24 * 60 * 60).utc },
+                  1001 => { ip: '192.168.0.101', maxmem: 1 * 1024 * 1024 * 1024, creation_date: (Time.now - (31 * 24 * 60 * 60)).utc },
                   1002 => { ip: '192.168.0.102', maxmem: 1 * 1024 * 1024 * 1024, creation_date: Time.now.utc }
                 }
               }
@@ -634,7 +634,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
               'pve_node_2' => {
                 memory_total: 2 * 1024 * 1024 * 1024,
                 lxc_containers: {
-                  1001 => { ip: '192.168.0.101', maxmem: 1 * 1024 * 1024 * 1024, creation_date: (Time.now - 31 * 24 * 60 * 60).utc }
+                  1001 => { ip: '192.168.0.101', maxmem: 1 * 1024 * 1024 * 1024, creation_date: (Time.now - (31 * 24 * 60 * 60)).utc }
                 }
               }
             }
@@ -748,7 +748,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
       it 'does not expire a VM that is stopped for some time even when it is not used for debug purposes' do
         with_sync_node do
           mock_proxmox(
-            mocked_pve_nodes: [{
+            mocked_pve_nodes: ([{
               # 2 seconds separate each run.
               # Make sure the third and later runs mock the container as running instead of stopped
               'pve_node_name' => {
@@ -765,8 +765,8 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
                   }
                 }
               }
-            }] * 2 +
-            [{
+            }] * 2) +
+            ([{
               # 2 seconds separate each run.
               # Make sure the third and later runs mock the container as running instead of stopped
               'pve_node_name' => {
@@ -783,7 +783,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
                   }
                 }
               }
-            }] * 2
+            }] * 2)
           )
           # Timeout for a non-debug stopped container to be considered expired is 3 seconds in tests
           expect(call_reserve_proxmox_container(2, 1024, 1, max_retries: 4, wait_before_retry: 2)).to eq(error: 'not_enough_resources')
@@ -796,7 +796,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
           creation_date_1 = (Time.now - 20).utc
           creation_date_2 = (Time.now - 10).utc
           mock_proxmox(
-            mocked_pve_nodes: [{
+            mocked_pve_nodes: ([{
               # 2 seconds separate each run.
               # Make sure the third and later runs mock the container as another one, still stopped
               'pve_node_name' => {
@@ -812,8 +812,8 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
                   }
                 }
               }
-            }] * 2 +
-            [{
+            }] * 2) +
+            ([{
               # 2 seconds separate each run.
               # Make sure the third and later runs mock the container as another one, still stopped
               'pve_node_name' => {
@@ -829,7 +829,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
                   }
                 }
               }
-            }] * 2
+            }] * 2)
           )
           # Timeout for a non-debug stopped container to be considered expired is 3 seconds in tests
           expect(call_reserve_proxmox_container(2, 1024, 1, max_retries: 4, wait_before_retry: 2)).to eq(error: 'not_enough_resources')

data/spec/hybrid_platforms_conductor_test/api/deployer/provisioners/proxmox/reserve_proxmox_container/retries_spec.rb

@@ -52,7 +52,7 @@ describe HybridPlatformsConductor::HpcPlugins::Provisioner::Proxmox do
         with_sync_node do
           mock_proxmox(mocked_pve_nodes: [{ 'pve_node_name' => { error_strings: ['NOK: error code = 500'] * 5 } }])
           result = call_reserve_proxmox_container(2, 1024, 4, config: { api_max_retries: 4 })
-          expect(result[:error]).not_to eq nil
+          expect(result[:error]).not_to be_nil
           expect(result[:error]).to match(%r{Unhandled exception from reserve_proxmox_container: Proxmox API get nodes/pve_node_name/lxc returns NOK: error code = 500 continuously \(tried 5 times\)})
           expect_proxmox_actions_to_be [
             [:create_ticket],

data/spec/hybrid_platforms_conductor_test/api/nodes_handler/cmdbs/host_ip_spec.rb

@@ -17,6 +17,7 @@ describe HybridPlatformsConductor::NodesHandler do
     it 'returns a host IP when hostname is set' do
       with_test_platform({ nodes: { 'test_node' => {} } }) do
         with_cmd_runner_mocked [
+          ['command -v getent', proc { [0, '', ''] }],
           ['getent hosts my_domain.my_host', proc { [0, '192.168.42.42 my_domain.my_host', ''] }]
         ] do
           expect(cmdb(:host_ip).get_host_ip(['test_node'], { 'test_node' => { hostname: 'my_domain.my_host' } })).to eq('test_node' => '192.168.42.42')
@@ -24,9 +25,21 @@ describe HybridPlatformsConductor::NodesHandler do
       end
     end
 
+    it 'returns a host IP when hostname is set without getenv' do
+      with_test_platform({ nodes: { 'test_node' => {} } }) do
+        with_cmd_runner_mocked [
+          ['command -v getent', proc { [1, '', ''] }],
+          ['host my_domain.my_host | grep \'has address\'', proc { [0, 'my_domain.my_host has address 192.168.42.42', ''] }]
+        ] do
+          expect(cmdb(:host_ip).get_host_ip(['test_node'], { 'test_node' => { hostname: 'my_domain.my_host' } })).to eq('test_node' => '192.168.42.42')
+        end
+      end
+    end
+
     it 'does not return a host IP when getent can\'t retrieve it' do
       with_test_platform({ nodes: { 'test_node' => {} } }) do
         with_cmd_runner_mocked [
+          ['command -v getent', proc { [0, '', ''] }],
           ['getent hosts my_domain.my_host', proc { [0, '', ''] }]
         ] do
           expect(cmdb(:host_ip).get_host_ip(['test_node'], { 'test_node' => { hostname: 'my_domain.my_host' } })).to eq({})
@@ -34,6 +47,17 @@ describe HybridPlatformsConductor::NodesHandler do
       end
     end
 
+    it 'does not return a host IP when getent can\'t retrieve it without getenv' do
+      with_test_platform({ nodes: { 'test_node' => {} } }) do
+        with_cmd_runner_mocked [
+          ['command -v getent', proc { [1, '', ''] }],
+          ['host my_domain.my_host | grep \'has address\'', proc { [1, '', ''] }]
+        ] do
+          expect(cmdb(:host_ip).get_host_ip(['test_node'], { 'test_node' => { hostname: 'my_domain.my_host' } })).to eq({})
+        end
+      end
+    end
+
     it 'returns a host IPs for the maximum hosts it can from the list' do
       with_test_platform(
         {
@@ -46,6 +70,7 @@ describe HybridPlatformsConductor::NodesHandler do
         }
       ) do
         with_cmd_runner_mocked [
+          ['command -v getent', proc { [0, '', ''] }],
           ['getent hosts my_domain.my_host1', proc { [0, '192.168.42.1 my_domain.my_host1', ''] }],
           ['getent hosts my_domain.my_host2', proc { [0, '', ''] }],
           ['getent hosts my_domain.my_host4', proc { [0, '192.168.42.4 my_domain.my_host4', ''] }]

data/spec/hybrid_platforms_conductor_test/api/nodes_handler/cmdbs_plugins_api_spec.rb

@@ -56,7 +56,7 @@ describe HybridPlatformsConductor::NodesHandler do
 
     it 'returns nodes metadata using dynamic method even on non-existant properties' do
       with_cmdb_test_platform do
-        expect(test_nodes_handler.get_downcase_of('node1')).to eq nil
+        expect(test_nodes_handler.get_downcase_of('node1')).to be_nil
       end
     end
 
@@ -245,7 +245,7 @@ describe HybridPlatformsConductor::NodesHandler do
         additional_config: 'master_cmdbs(test_cmdb_2: :different_comment)'
       ) do
         expect(test_nodes_handler.get_different_comment_of('node1')).to eq 'Comment from test_cmdb_2'
-        expect(cmdb(:test_cmdb).calls).to eq nil
+        expect(cmdb(:test_cmdb).calls).to be_nil
         expect(cmdb(:test_cmdb_2).calls).to eq [
           [:get_different_comment, ['node1'], {}]
         ]
@@ -385,7 +385,7 @@ describe HybridPlatformsConductor::NodesHandler do
 
     it 'does not cache metadata from others method when they are not the required property' do
       with_cmdb_test_platform(cmdbs: %i[test_cmdb test_cmdb_others]) do
-        expect(test_nodes_handler.get_unknown_of('node1')).to eq nil
+        expect(test_nodes_handler.get_unknown_of('node1')).to be_nil
         expect(cmdb(:test_cmdb_others).calls).to eq [
           [:get_others, ['node1'], {}]
         ]
@@ -400,7 +400,7 @@ describe HybridPlatformsConductor::NodesHandler do
     it 'does not refuse conflicts between CMDBs and overriden values' do
       with_cmdb_test_platform(cmdbs: %i[test_cmdb_others]) do
         test_nodes_handler.override_metadata_of 'node1', :downcase, 'OVERIDDEN'
-        expect(test_nodes_handler.get_unknown_of('node1')).to eq nil
+        expect(test_nodes_handler.get_unknown_of('node1')).to be_nil
         expect(test_nodes_handler.get_downcase_of('node1')).to eq 'OVERIDDEN'
       end
     end
@@ -409,7 +409,7 @@ describe HybridPlatformsConductor::NodesHandler do
       with_cmdb_test_platform do
         test_nodes_handler.override_metadata_of 'node1', :upcase, 'OVERIDDEN'
         expect(test_nodes_handler.metadata_of('node1', :upcase)).to eq 'OVERIDDEN'
-        expect(cmdb(:test_cmdb).calls).to eq nil
+        expect(cmdb(:test_cmdb).calls).to be_nil
       end
     end
 

data/spec/hybrid_platforms_conductor_test/api/platform_handlers/serverless_chef/inventory_spec.rb

@@ -12,7 +12,7 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
 
       it 'returns no nodes list' do
         with_serverless_chef_platforms('empty') do |platform|
-          expect(platform.respond_to?(:known_nodes_lists)).to eq false
+          expect(platform.respond_to?(:known_nodes_lists)).to be false
         end
       end
 

data/spec/hybrid_platforms_conductor_test/api/platform_handlers/serverless_chef/packaging_spec.rb

@@ -90,7 +90,7 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
           with_packaging_mocked(repository) do
             platform.package(services: { 'node' => %w[test_policy] }, secrets: {}, local_environment: false)
             gems_file = "#{repository}/dist/prod/test_policy/gems.json"
-            expect(File.exist?(gems_file)).to eq true
+            expect(File.exist?(gems_file)).to be true
             expect(JSON.parse(File.read(gems_file))).to eq []
           end
         end
@@ -110,7 +110,7 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
           with_packaging_mocked(repository) do
             platform.package(services: { 'node' => %w[test_policy] }, secrets: { secret: 'value' }, local_environment: false)
             secret_file = "#{repository}/dist/prod/test_policy/data_bags/hpc_secrets/hpc_secrets.json"
-            expect(File.exist?(secret_file)).to eq true
+            expect(File.exist?(secret_file)).to be true
             expect(JSON.parse(File.read(secret_file))).to eq(
               'id' => 'hpc_secrets',
               'secret' => 'value'
@@ -124,7 +124,7 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
           with_packaging_mocked(repository, policy_file: 'policyfiles/test_policy.local.rb', env: 'local') do
             platform.package(services: { 'node' => %w[test_policy] }, secrets: {}, local_environment: true)
             local_policy_file = "#{repository}/policyfiles/test_policy.local.lock.json"
-            expect(File.exist?(local_policy_file)).to eq true
+            expect(File.exist?(local_policy_file)).to be true
             expect(JSON.parse(File.read(local_policy_file))).to eq('run_list' => ['recipe[test_cookbook]'])
           end
         end
@@ -247,7 +247,7 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
           ) do
             platform.package(services: { 'node1' => %w[test_policy_1] }, secrets: {}, local_environment: false)
             gems_file = "#{repository}/dist/prod/test_policy_1/gems.json"
-            expect(File.exist?(gems_file)).to eq true
+            expect(File.exist?(gems_file)).to be true
             expect(JSON.parse(File.read(gems_file)).sort).to eq [
               ['my_gem_1', '0.0.1'],
               ['my_gem_2', '0.0.2'],
@@ -266,7 +266,7 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
           with_packaging_mocked(repository, data_bags: true) do
             platform.package(services: { 'node' => %w[test_policy] }, secrets: {}, local_environment: false)
             data_bag_file = "#{repository}/dist/prod/test_policy/data_bags/my_bag/my_item.json"
-            expect(File.exist?(data_bag_file)).to eq true
+            expect(File.exist?(data_bag_file)).to be true
             expect(JSON.parse(File.read(data_bag_file))).to eq(
               'id' => 'my_item',
               'content' => 'Bag content'
@@ -284,7 +284,7 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
           with_packaging_mocked(repository, policy_file: 'policyfiles/test_policy.local.rb', env: 'local') do
             platform.package(services: { 'node' => %w[test_policy] }, secrets: {}, local_environment: true)
             local_policy_file = "#{repository}/policyfiles/test_policy.local.lock.json"
-            expect(File.exist?(local_policy_file)).to eq true
+            expect(File.exist?(local_policy_file)).to be true
             expect(JSON.parse(File.read(local_policy_file))).to eq(
               'run_list' => [
                 'hpc_test::before_run',
@@ -302,7 +302,7 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
           with_packaging_mocked(repository, policy_file: 'policyfiles/test_policy.local.rb', env: 'local') do
             platform.package(services: { 'node' => %w[test_policy] }, secrets: {}, local_environment: true)
             local_policy_file = "#{repository}/policyfiles/test_policy.local.lock.json"
-            expect(File.exist?(local_policy_file)).to eq true
+            expect(File.exist?(local_policy_file)).to be true
             expect(JSON.parse(File.read(local_policy_file))).to eq(
               'run_list' => [
                 'hpc_test::before_run',
@@ -319,7 +319,7 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
           with_packaging_mocked(repository, policy_file: 'policyfiles/test_policy.local.rb', env: 'local') do
             platform.package(services: { 'node' => %w[test_policy] }, secrets: {}, local_environment: true)
             local_policy_file = "#{repository}/policyfiles/test_policy.local.lock.json"
-            expect(File.exist?(local_policy_file)).to eq true
+            expect(File.exist?(local_policy_file)).to be true
             expect(JSON.parse(File.read(local_policy_file))).to eq(
               'run_list' => [
                 'recipe[test_cookbook]',
@@ -343,7 +343,7 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
           ) do
             platform.package(services: { 'node' => %w[test_policy] }, secrets: {}, local_environment: true)
             testadmin_key_pub = Dir.glob("#{repository}/dist/local/test_policy/cookbook_artifacts/hpc_test-*/files/default/testadmin.key.pub").first
-            expect(testadmin_key_pub).not_to eq nil
+            expect(testadmin_key_pub).not_to be_nil
             expect(File.read(testadmin_key_pub)).to eq 'ssh-rsa 12345 testadmin@test.com'
           end
         end

data/spec/hybrid_platforms_conductor_test/api/platform_handlers/serverless_chef/services_deployment_spec.rb

@@ -168,7 +168,7 @@ describe HybridPlatformsConductor::HpcPlugins::PlatformHandler::ServerlessChef d
           )
           expect(platform.actions_to_deploy_on('node', 'test_policy', use_why_run: false)).to eq expected_actions_to_deploy_chef(repository)
           attributes_file = "#{repository}/dist/prod/test_policy/nodes/node.json"
-          expect(File.exist?(attributes_file)).to eq true
+          expect(File.exist?(attributes_file)).to be true
           expect(JSON.parse(File.read(attributes_file))).to eq(
             'description' => 'Single test node',
             'image' => 'debian_9',

data/spec/hybrid_platforms_conductor_test/api/platforms_handler_spec.rb

@@ -138,7 +138,7 @@ describe HybridPlatformsConductor::PlatformsHandler do
         'platform3' => { platform_type: :test }
       }
     ) do
-      expect(test_platforms_handler.platform('platform4')).to eq nil
+      expect(test_platforms_handler.platform('platform4')).to be_nil
     end
   end
 

data/spec/hybrid_platforms_conductor_test/api/plugins_spec.rb

@@ -7,6 +7,9 @@ module HybridPlatformsConductor
   class TestPluginType2 < Plugin
   end
 
+  class TestPluginType3 < Plugin
+  end
+
 end
 
 module HybridPlatformsConductorTest
@@ -122,7 +125,7 @@ describe HybridPlatformsConductor::Plugins do
       plugins[:new_plugin] = HybridPlatformsConductorTest::RandomClassWithValidation
       expect(plugins.keys).to eq [:new_plugin]
       expect(plugins[:new_plugin]).to eq HybridPlatformsConductorTest::RandomClassWithValidation
-      expect(HybridPlatformsConductorTest::RandomClassWithValidation.validation_done).to eq true
+      expect(HybridPlatformsConductorTest::RandomClassWithValidation.validation_done).to be true
     end
   end
 
@@ -133,7 +136,7 @@ describe HybridPlatformsConductor::Plugins do
       HybridPlatformsConductorTest::RandomClassWithValidation.validation_result = false
       plugins[:new_plugin] = HybridPlatformsConductorTest::RandomClassWithValidation
       expect(plugins.keys).to eq []
-      expect(HybridPlatformsConductorTest::RandomClassWithValidation.validation_done).to eq true
+      expect(HybridPlatformsConductorTest::RandomClassWithValidation.validation_done).to be true
     end
   end
 
@@ -162,6 +165,31 @@ describe HybridPlatformsConductor::Plugins do
     end
   end
 
+  it 'discovers automatically plugins of a given type in the hpc_plugins directory of a gem even if lib is used in the gem\'s installation path' do
+    with_test_platform({}) do
+      # Mock the discovery of Ruby gems
+      expect(Gem).to receive(:loaded_specs) do
+        my_test_gem_spec = instance_double Gem::Specification
+        expect(my_test_gem_spec).to receive(:full_gem_path).and_return('path/to/__gem_full_path__/in/lib/sub')
+        expect(Dir).to receive(:glob).with('path/to/__gem_full_path__/in/lib/sub/lib/**/*.rb').and_return [
+          'path/to/__gem_full_path__/in/lib/sub/lib/my_test_gem_with_lib/sub1/lib/sub2/hpc_plugins/test_plugin_type_3/test_plugin_id_5.rb'
+        ]
+        {
+          'my_test_gem_with_lib' => my_test_gem_spec
+        }
+      end
+      # Alter the load path to mock an extra Rubygem
+      $LOAD_PATH.unshift "#{__dir__}/../mocked_lib"
+      begin
+        plugins = described_class.new(:test_plugin_type_3, logger: logger, logger_stderr: logger)
+        expect(plugins.keys).to eq [:test_plugin_id_5]
+        expect(plugins[:test_plugin_id_5]).to eq HybridPlatformsConductorTest::MockedLib::MyTestGemWithLib::Sub1::Lib::Sub2::HpcPlugins::TestPluginType3::TestPluginId5
+      ensure
+        $LOAD_PATH.shift
+      end
+    end
+  end
+
   it 'discovers automatically several plugins of different types in the hpc_plugins directories of several gems' do
     with_test_platform({}) do
       # Mock the discovery of Ruby gems

data/spec/hybrid_platforms_conductor_test/api/services_handler/deploy_allowed_spec.rb

@@ -34,14 +34,14 @@ describe HybridPlatformsConductor::ServicesHandler do
     it 'allows deployment in local environment' do
       with_test_platform_for_services_test do
         with_cmd_runner_mocked([]) do
-          expect(test_services_handler.deploy_allowed?(services: { 'node1' => %w[service1] }, local_environment: true)).to eq nil
+          expect(test_services_handler.deploy_allowed?(services: { 'node1' => %w[service1] }, local_environment: true)).to be_nil
         end
       end
     end
 
     it 'allows deployment if branch is on master' do
       with_test_platform_for_services_test do
-        expect(test_services_handler.deploy_allowed?(services: { 'node1' => %w[service1] }, local_environment: false)).to eq nil
+        expect(test_services_handler.deploy_allowed?(services: { 'node1' => %w[service1] }, local_environment: false)).to be_nil
       end
     end
 
@@ -52,7 +52,7 @@ describe HybridPlatformsConductor::ServicesHandler do
           deployable_services: %w[service1]
         }
       ) do
-        expect(test_services_handler.deploy_allowed?(services: { 'node1' => %w[service1] }, local_environment: false)).to eq nil
+        expect(test_services_handler.deploy_allowed?(services: { 'node1' => %w[service1] }, local_environment: false)).to be_nil
       end
     end
 
@@ -62,7 +62,7 @@ describe HybridPlatformsConductor::ServicesHandler do
           git = Git.open(repository)
           git.add_remote('another_remote', remote_repo).fetch
           git.checkout('remotes/another_remote/master')
-          expect(test_services_handler.deploy_allowed?(services: { 'node1' => %w[service1] }, local_environment: false)).to eq nil
+          expect(test_services_handler.deploy_allowed?(services: { 'node1' => %w[service1] }, local_environment: false)).to be_nil
         end
       end
     end
@@ -70,7 +70,7 @@ describe HybridPlatformsConductor::ServicesHandler do
     it 'allows deployment if branch is on master even if not checked-out' do
       with_test_platform_for_services_test do |repository|
         Git.open(repository).branch('other_branch').checkout
-        expect(test_services_handler.deploy_allowed?(services: { 'node1' => %w[service1] }, local_environment: false)).to eq nil
+        expect(test_services_handler.deploy_allowed?(services: { 'node1' => %w[service1] }, local_environment: false)).to be_nil
       end
     end
 
@@ -95,7 +95,7 @@ describe HybridPlatformsConductor::ServicesHandler do
             services: { 'node1' => %w[service1], 'node2' => %w[service2], 'node3' => %w[service3] },
             local_environment: false
           )
-        ).to eq nil
+        ).to be_nil
       end
     end
 
@@ -137,7 +137,7 @@ describe HybridPlatformsConductor::ServicesHandler do
             services: { 'node1' => %w[service1 service3] },
             local_environment: false
           )
-        ).to eq nil
+        ).to be_nil
       end
     end