gooddata 0.6.49 → 0.6.50

data/spec/unit/models/blueprint/schema_builder_spec.rb

@@ -1,14 +1,12 @@
 # encoding: UTF-8
 #
-# Copyright (c) 2010-2015 GoodData Corporation. All rights reserved.
+# Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
 # This source code is licensed under the BSD-style license found in the
 # LICENSE file in the root directory of this source tree.
 
-require 'pry'
 require 'gooddata/models/model'
 
 describe GoodData::Model::SchemaBuilder do
-
   it "should create a schema" do
     builder = GoodData::Model::SchemaBuilder.new("a_title")
     blueprint = builder.to_blueprint
@@ -21,7 +19,7 @@ describe GoodData::Model::SchemaBuilder do
     builder.add_fact("amount", :title => "Amount")
 
     blueprint = builder.to_blueprint
-    blueprint.attributes.count == 1
+    expect(blueprint.attributes.count).to eq(1)
   end
 
   it "should be able to create from block" do
@@ -32,7 +30,7 @@ describe GoodData::Model::SchemaBuilder do
     end
 
     blueprint = builder.to_blueprint
-    blueprint.attributes.count == 1
-    blueprint.facts.count == 1
+    expect(blueprint.attributes.count).to eq(1)
+    expect(blueprint.facts.count).to eq(1)
   end
-end
+end

data/spec/unit/models/blueprint/to_wire_spec.rb

@@ -1,6 +1,6 @@
 # encoding: UTF-8
 #
-# Copyright (c) 2010-2015 GoodData Corporation. All rights reserved.
+# Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
 # This source code is licensed under the BSD-style license found in the
 # LICENSE file in the root directory of this source tree.
 
@@ -9,7 +9,6 @@ require 'gooddata'
 include GoodData::Model
 
 describe GoodData::Model::ProjectBlueprint do
-
   before(:each) do
     @spec = JSON.parse(File.read("./spec/data/blueprints/big_blueprint_not_pruned.json"), :symbolize_names => true)
     @blueprint = GoodData::Model::ProjectBlueprint.new(@spec)
@@ -26,13 +25,13 @@ describe GoodData::Model::ProjectBlueprint do
 
     it 'it should turn into wire another project' do
       spec = JSON.parse(File.read("./spec/data/blueprints/test_project_model_spec.json"), :symbolize_names => true)
-      res = ToWire.to_wire(spec)
+      ToWire.to_wire(spec)
     end
 
     it 'should create manifest' do
       spec = JSON.parse(File.read("./spec/data/blueprints/test_blueprint.json"), :symbolize_names => true)
       wire_spec = JSON.parse(File.read("./spec/data/wire_models/test_blueprint.json"), :symbolize_names => true)
-      manifest_spec = JSON.parse(File.read("./spec/data/manifests/test_blueprint.json"))
+      JSON.parse(File.read("./spec/data/manifests/test_blueprint.json"))
       expect(ToWire.to_wire(spec)).to eq wire_spec
     end
   end
@@ -42,71 +41,95 @@ describe GoodData::Model::ProjectBlueprint do
       dataset = ProjectBlueprint.find_dataset(@spec, 'dataset.stage_history')
 
       result = ToWire.anchor_to_wire(@spec, dataset)
-      expect(result).to eq ({
+      expect(result).to eq(
         attribute: {
           identifier: "attr.dataset.stage_history.factsof",
           title: "Records of stage_history",
-          folder: "stage_history"}})
+          folder: "stage_history"
+        }
+      )
     end
 
     it 'should generate anchor with label' do
       dataset = ProjectBlueprint.find_dataset(@spec, 'dataset.opportunityanalysis')
       result = ToWire.anchor_to_wire(nil, dataset)
-      expect(result).to eq ({
+      expect(result).to eq(
         attribute: {
-          :identifier=>"attr.opportunityanalysis.techoppanalysis",
-          :title=>"Tech Opp. Analysis",
-          :folder=>"Opportunity Benchmark",
-          :labels=>[
-            {:label=>
-             {:identifier=>"label.opportunityanalysis.techoppanalysis",
-              :title=>"Tech Opp. Analysis",
-              :type=>"GDC.text",
-              :dataType=>"VARCHAR(128)"}}],
-          :defaultLabel=>"label.opportunityanalysis.techoppanalysis"}})
+          :identifier => "attr.opportunityanalysis.techoppanalysis",
+          :title => "Tech Opp. Analysis",
+          :folder => "Opportunity Benchmark",
+          :labels => [
+            {
+              :label => {
+                :identifier => "label.opportunityanalysis.techoppanalysis",
+                :title => "Tech Opp. Analysis",
+                :type => "GDC.text",
+                :dataType => "VARCHAR(128)"
+              }
+            }
+          ],
+          :defaultLabel => "label.opportunityanalysis.techoppanalysis"
+        }
+      )
     end
   end
 
   describe '#anchor_to_attribute' do
     it 'should generate attribute without label' do
       dataset = ProjectBlueprint.find_dataset(@spec, 'dataset.stage_history')
-      a = DatasetBlueprint.attributes(dataset).find {|a| a[:id] == 'attr.stage_history.currentstatus'}
+      a = DatasetBlueprint.attributes(dataset).find { |attribute| attribute[:id] == 'attr.stage_history.currentstatus' }
       result = ToWire.attribute_to_wire(dataset, a)
-      expect(result).to eq ({
-        :attribute=>
-        {:identifier=>"attr.stage_history.currentstatus",
-         :title=>"Current Stage",
-         :folder=>"stage_history",
-         :labels=>
-          [{:label=>
-             {:identifier=>"label.stage_history.currentstatus",
-              :title=>"Current Stage",
-              :type=>"GDC.text",
-              :dataType=>"VARCHAR(128)"}}],
-          :defaultLabel=>"label.stage_history.currentstatus"}})
+      expect(result).to eq(
+        :attribute => {
+          :identifier => "attr.stage_history.currentstatus",
+          :title => "Current Stage",
+          :folder => "stage_history",
+          :labels => [
+            {
+              :label => {
+                :identifier => "label.stage_history.currentstatus",
+                :title => "Current Stage",
+                :type => "GDC.text",
+                :dataType => "VARCHAR(128)"
+              }
+            }
+          ],
+          :defaultLabel => "label.stage_history.currentstatus"
+        }
+      )
     end
 
     it 'should generate attributes with label' do
       dataset = ProjectBlueprint.find_dataset(@spec, 'dataset.opportunityanalysis')
-      a = DatasetBlueprint.attributes(dataset).find {|a| a[:id] == 'attr.opportunityanalysis.month'}
+      a = DatasetBlueprint.attributes(dataset).find { |attribute| attribute[:id] == 'attr.opportunityanalysis.month' }
 
       result = ToWire.attribute_to_wire(dataset, a)
-      expect(result).to eq ({:attribute=>
-        {:identifier=>"attr.opportunityanalysis.month",
-         :title=>"Month",
-         :folder=>"Opportunity Benchmark",
-         :labels=>
-          [{:label=>
-             {:identifier=>"label.opportunityanalysis.month",
-              :title=>"Month",
-              :type=>"GDC.text",
-              :dataType=>"VARCHAR(128)"}},
-           {:label=>
-             {:identifier=>"label.opportunityanalysis.month.monthsortingnew",
-              :title=>"MonthSortingNew",
-              :type=>"GDC.text",
-              :dataType=>"INT"}}],
-          :defaultLabel=>"label.opportunityanalysis.month" }})
+      expect(result).to eq(
+        :attribute => {
+          :identifier => "attr.opportunityanalysis.month",
+          :title => "Month",
+          :folder => "Opportunity Benchmark",
+          :labels => [
+            {
+              :label => {
+                :identifier => "label.opportunityanalysis.month",
+                :title => "Month",
+                :type => "GDC.text",
+                :dataType => "VARCHAR(128)"
+              }
+            },
+            {
+              :label => {
+                :identifier => "label.opportunityanalysis.month.monthsortingnew",
+                :title => "MonthSortingNew",
+                :type => "GDC.text",
+                :dataType => "INT"
+              }
+            }
+          ],
+          :defaultLabel => "label.opportunityanalysis.month"
+        }
+      )
     end
   end
 
@@ -121,13 +144,15 @@ describe GoodData::Model::ProjectBlueprint do
         gd_data_type: "DECIMAL(12,2)"
       }
       result = ToWire.fact_to_wire(nil, fact_def)
-      expect(result).to eq ({
+      expect(result).to eq(
         fact: {
           identifier: "fact.stage_history.stage_velocity",
           title: "Stage Velocity",
           dataType: "DECIMAL(12,2)",
           folder: "My Folder",
-          description: "Velocity description"}})
+          description: "Velocity description"
+        }
+      )
     end
   end
 
@@ -163,12 +188,8 @@ describe GoodData::Model::ProjectBlueprint do
 
   describe '#date_dimension_to_wire' do
     it 'should be able to generate date dimension' do
-      res = ToWire.date_dimension_to_wire(@spec, {
-        type: "date_dimension",
-        id: "timeline",
-        title: "Timeline"
-      })
-      expect(res).to eq({:dateDimension=>{:name=>"timeline", :title=>"Timeline"}})
+      res = ToWire.date_dimension_to_wire(@spec, type: "date_dimension", id: "timeline", title: "Timeline")
+      expect(res).to eq(:dateDimension => { :name => "timeline", :title => "Timeline" })
     end
   end
 end

data/spec/unit/models/domain_spec.rb

@@ -1,6 +1,6 @@
 # encoding: UTF-8
 #
-# Copyright (c) 2010-2015 GoodData Corporation. All rights reserved.
+# Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
 # This source code is licensed under the BSD-style license found in the
 # LICENSE file in the root directory of this source tree.
 
@@ -30,7 +30,7 @@ describe GoodData::Domain do
       args = {
         :domain => ConnectionHelper::DEFAULT_DOMAIN,
         :login => "gemtest_#{rand(1e6)}@gooddata.com",
-        :password => CryptoHelper.generate_password,
+        :password => CryptoHelper.generate_password
       }
 
       @user = GoodData::Domain.add_user(args)
@@ -70,7 +70,7 @@ describe GoodData::Domain do
 
   describe '#create_users' do
     it 'Creates new users from list' do
-      list = (0..1).to_a.map { |i| ProjectHelper.create_random_user(@client) }
+      list = (0..1).to_a.map { ProjectHelper.create_random_user(@client) }
       res = @domain.create_users(list)
 
       # no errors
@@ -91,7 +91,6 @@ describe GoodData::Domain do
       modes = user.authentication_modes
       possible_modes = [:sso, :password]
 
-
       user.first_name = name.reverse
       choice = SpecHelper.random_choice(possible_modes, user.authentication_modes)
       user.authentication_modes = choice
@@ -108,7 +107,7 @@ describe GoodData::Domain do
       expect(reverted_user.authentication_modes).to eq modes
     end
 
-    it 'Fails with an exception if you try to create a user that is in a different domain' do
+    it 'Fails with an exception if you try to create a user that is in a different domain', broken: true do
       user = ProjectHelper.create_random_user(@client)
       user.login = 'svarovsky@gooddata.com'
       expect do

data/spec/unit/models/execution_spec.rb

@@ -1,25 +1,26 @@
 # encoding: UTF-8
 #
-# Copyright (c) 2010-2015 GoodData Corporation. All rights reserved.
+# Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
 # This source code is licensed under the BSD-style license found in the
 # LICENSE file in the root directory of this source tree.
 
 require 'gooddata/models/schedule'
 
 describe GoodData::Execution do
-
   before(:each) do
-    @data = {"execution"=>
-      {"startTime"=>"2015-02-27T15:44:21.759Z",
-       "endTime"=>"2015-02-27T15:47:49.383Z",
-       "log"=>
-        "/gdc/projects/tk3b994vmdpcb0xjwexc9moen8t5bpiw/dataload/processes/2b031451-b1a2-4039-8e36-0672542a0e60/executions/54f090d5e4b0c9cbdcb0f45b/log",
-       "status"=>"OK",
-       "trigger"=>"MANUAL",
-       "links"=>
-        {"self"=>
-          "/gdc/projects/tk3b994vmdpcb0xjwexc9moen8t5bpiw/schedules/54f08d1de4b0c9cbdcb0f323/executions/54f090d5e4b0c9cbdcb0f45b"},
-       "createdTime"=>"2015-02-27T15:44:21.361Z"}}
+    @data = {
+      "execution" => {
+        "startTime" => "2015-02-27T15:44:21.759Z",
+        "endTime" => "2015-02-27T15:47:49.383Z",
+        "log" => "/gdc/projects/tk3b994vmdpcb0xjwexc9moen8t5bpiw/dataload/processes/2b031451-b1a2-4039-8e36-0672542a0e60/executions/54f090d5e4b0c9cbdcb0f45b/log",
+        "status" => "OK",
+        "trigger" => "MANUAL",
+        "links" => {
+          "self" => "/gdc/projects/tk3b994vmdpcb0xjwexc9moen8t5bpiw/schedules/54f08d1de4b0c9cbdcb0f323/executions/54f090d5e4b0c9cbdcb0f45b"
+        },
+       "createdTime" => "2015-02-27T15:44:21.361Z"
+      }
+    }
     @execution = GoodData::Execution.new(@data)
   end
 
@@ -32,7 +33,7 @@ describe GoodData::Execution do
 
   describe '#error?' do
     it 'returns true if executione errored out' do
-      expect(@execution.error?).to be_falsy
+      expect(@execution.error?).to be_falsey
     end
   end
 
@@ -64,7 +65,7 @@ describe GoodData::Execution do
 
   describe '#running?' do
     it 'returns false if executione is already finished' do
-      expect(@execution.running?).to be_falsy
+      expect(@execution.running?).to be_falsey
     end
 
     it 'returns true if executione is currently finished' do

data/spec/unit/models/from_wire_spec.rb

@@ -1,6 +1,6 @@
 # encoding: UTF-8
 #
-# Copyright (c) 2010-2015 GoodData Corporation. All rights reserved.
+# Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
 # This source code is licensed under the BSD-style license found in the
 # LICENSE file in the root directory of this source tree.
 
@@ -9,7 +9,6 @@ require 'gooddata'
 include GoodData::Model
 
 describe GoodData::Model::FromWire do
-
   before(:each) do
     @model_view = MultiJson.load(File.read('./spec/data/wire_models/model_view.json'))
     @blueprint = FromWire.from_wire(@model_view)
@@ -26,6 +25,7 @@ describe GoodData::Model::FromWire do
           title: "Month",
           folder: "Opportunity Benchmark",
           description: nil,
+          order_by: "label.opportunityanalysis.month.monthsortingnew - ASC"
         },
         {
           type: :label,
@@ -43,7 +43,8 @@ describe GoodData::Model::FromWire do
           title: "MonthSortingNew",
           gd_data_type: "INT",
           gd_type: "GDC.text"
-        }])
+        }
+      ])
     end
 
     it "should be able to parse the anchor" do
@@ -55,7 +56,7 @@ describe GoodData::Model::FromWire do
           id: "attr.opportunityanalysis.techoppanalysis",
           title: "Tech Opp. Analysis",
           folder: "Opportunity Benchmark",
-          description: nil,
+          description: nil
         },
         {
           type: :label,
@@ -65,7 +66,8 @@ describe GoodData::Model::FromWire do
           gd_data_type: "VARCHAR(128)",
           gd_type: "GDC.text",
           default_label: true
-        }])
+        }
+      ])
     end
   end
 
@@ -102,7 +104,8 @@ describe GoodData::Model::FromWire do
           id: "attr.opportunityanalysis.month",
           title: "Month",
           description: nil,
-          folder: "Opportunity Benchmark"
+          folder: "Opportunity Benchmark",
+          order_by: "label.opportunityanalysis.month.monthsortingnew - ASC"
         },
         {
           type: :label,
@@ -143,7 +146,7 @@ describe GoodData::Model::FromWire do
     it "should be able to parse the attributes with no labels" do
       model = @model_view['projectModelView']['model']['projectModel']['datasets'][7]
       x = FromWire.parse_attributes(model)
-      expect(x.to_set).to eq Set.new()
+      expect(x.to_set).to eq Set.new
     end
   end
 
@@ -151,13 +154,15 @@ describe GoodData::Model::FromWire do
     it "should be able to parse the anchor without label" do
       model = @model_view['projectModelView']['model']['projectModel']['datasets'].first
       x = FromWire.parse_anchor(model)
-      expect(x.to_set).to eq Set.new([{
-        type: :anchor,
-        id: "attr.stage_history.factsof",
-        title: "Records of stage_history",
-        description: nil,
-        folder: nil
-      }])
+      expect(x.to_set).to eq Set.new([
+        {
+          type: :anchor,
+          id: "attr.stage_history.factsof",
+          title: "Records of stage_history",
+          description: nil,
+          folder: nil
+        }
+      ])
     end
 
     it "should be able to parse the anchor out of dataset when there are multiple labels" do
@@ -180,7 +185,7 @@ describe GoodData::Model::FromWire do
           gd_type: "GDC.text",
           default_label: true
         },
-        { 
+        {
           type: :label,
           id: "label.opp_records.factsof",
           reference: "attr.opp_records.factsof",
@@ -247,7 +252,7 @@ describe GoodData::Model::FromWire do
   describe '#from_wire' do
     it 'should be able to parse dataset' do
       model_view = MultiJson.load(File.read('./spec/data/wire_models/nu_model.json'))
-      bp = GoodData::Model::FromWire.from_wire(model_view)
+      GoodData::Model::FromWire.from_wire(model_view)
     end
   end
 
@@ -256,7 +261,7 @@ describe GoodData::Model::FromWire do
   end
 
   it "should have a datatype if defined" do
-    dataset = @blueprint.datasets.find {|d| d.id == 'dataset.account' }
+    dataset = @blueprint.datasets.find { |d| d.id == 'dataset.account' }
     dataset.labels_for_attribute('attr.account.accountemployeecount')
 
     dataset = @blueprint.find_dataset('dataset.stage_history')
@@ -290,7 +295,7 @@ describe GoodData::Model::FromWire do
 
   it "should be able to parse description from both attributes and facts" do
     expect(@blueprint.find_dataset('dataset.opportunity').anchor.description).to eq 'This is opportunity attribute description'
-    expect(@blueprint.find_dataset('dataset.stage_history').facts.find {|f| f.id == 'fact.stage_history.stage_velocity'}.description).to eq 'Velocity description'
-    expect(@blueprint.find_dataset('dataset.opp_owner').attributes.find {|f| f.id == 'attr.opp_owner.region'}.description).to eq 'Owner Region description'
+    expect(@blueprint.find_dataset('dataset.stage_history').facts.find { |f| f.id == 'fact.stage_history.stage_velocity' }.description).to eq 'Velocity description'
+    expect(@blueprint.find_dataset('dataset.opp_owner').attributes.find { |f| f.id == 'attr.opp_owner.region' }.description).to eq 'Owner Region description'
   end
 end