gooddata 0.6.49 → 0.6.50

data/spec/integration/deprecated_load_spec.rb

@@ -1,6 +1,6 @@
 # encoding: UTF-8
 #
-# Copyright (c) 2010-2015 GoodData Corporation. All rights reserved.
+# Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
 # This source code is licensed under the BSD-style license found in the
 # LICENSE file in the root directory of this source tree.
 
@@ -8,7 +8,7 @@ require 'gooddata'
 
 describe "Full project implementation", :constraint => 'slow' do
   before(:all) do
-    @client = ConnectionHelper::create_default_connection
+    @client = ConnectionHelper.create_default_connection
     @blueprint = GoodData::Model::ProjectBlueprint.build("my_bp") do |p|
       p.add_dataset("dataset.repos") do |d|
         d.add_anchor("attr.repository")
@@ -32,10 +32,11 @@ describe "Full project implementation", :constraint => 'slow' do
       ["label.repository.name", "label.attribute1.name", "some_numbers"],
       [1, "tomas@gooddata.com", 10],
       [2, "petr@gooddata.com", 20],
-      [3, "jirka@gooddata.com", 30]]
+      [3, "jirka@gooddata.com", 30]
+    ]
     @project.upload(devs_data, @blueprint, 'dataset.repos')
-    vals = @project.labels('label.repository.name').values.to_a.map {|l| l[:value]}
-    expect(vals).to eq ["1", "2", "3"]
+    vals = @project.labels('label.repository.name').values.to_a.map { |label| label[:value] }
+    expect(vals).to eq %w(1 2 3)
   end
 
   it 'should upload the data when you deprecate attribute with remote blueprint' do
@@ -50,9 +51,10 @@ describe "Full project implementation", :constraint => 'slow' do
       [1, "tomas@gooddata.com", 10],
       [2, "petr@gooddata.com", 20],
       [3, "jirka@gooddata.com", 30],
-      [4, "jindrich@gooddata.com", 40]]
+      [4, "jindrich@gooddata.com", 40]
+    ]
     @project.upload(devs_data, @project.blueprint, 'dataset.repos')
-    vals = @project.labels('label.repository.name').values.to_a.map {|l| l[:value]}
-    expect(vals).to eq ["1", "2", "3", "4"]
+    vals = @project.labels('label.repository.name').values.to_a.map { |label| label[:value] }
+    expect(vals).to eq %w(1 2 3 4)
   end
-end
+end

data/spec/integration/full_process_schedule_spec.rb

@@ -1,6 +1,6 @@
 # encoding: UTF-8
 #
-# Copyright (c) 2010-2015 GoodData Corporation. All rights reserved.
+# Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
 # This source code is licensed under the BSD-style license found in the
 # LICENSE file in the root directory of this source tree.
 
@@ -27,7 +27,7 @@ describe "Full process and schedule exercise", :constraint => 'slow' do
   }
 
   before(:all) do
-    @client = ConnectionHelper::create_default_connection
+    @client = ConnectionHelper.create_default_connection
     @project = @client.create_project(title: 'Project for schedule testing', auth_token: ConnectionHelper::GD_PROJECT_TOKEN, environment: ProjectHelper::ENVIRONMENT)
     @process = @project.deploy_process('./spec/data/ruby_process',
                                        type: 'RUBY',
@@ -36,7 +36,6 @@ describe "Full process and schedule exercise", :constraint => 'slow' do
     @process_cc = @project.deploy_process('./spec/data/cc',
                                           type: 'graph',
                                           name: 'Test ETL Process (CC)')
-
   end
 
   after(:all) do
@@ -44,7 +43,8 @@ describe "Full process and schedule exercise", :constraint => 'slow' do
     ProcessHelper.remove_old_processes(@project)
 
     # @process.delete if @process
-    # @project.delete if @project
+    @project.delete if @project
+    GoodData::ChannelConfiguration.all.map(&:delete)
 
     @client.disconnect
   end
@@ -63,7 +63,6 @@ describe "Full process and schedule exercise", :constraint => 'slow' do
   end
 
   it "should be able to grab executables" do
-
     expect(@process.executables).to eq ['process.rb']
   end
 
@@ -221,7 +220,7 @@ describe "Full process and schedule exercise", :constraint => 'slow' do
       schedule = process.create_schedule('0 15 27 7 *', process.executables.first, hidden_params: COMPLEX_PARAMS)
       result = schedule.execute
       # expect(result.status).to eq :ok
-      log = result.log
+      result.log
       expect(process.schedules.count).to eq 1
     ensure
       schedule && schedule.delete
@@ -258,9 +257,11 @@ describe "Full process and schedule exercise", :constraint => 'slow' do
 
   it "should be able to redeploy directly" do
     begin
-      process1 = @project.deploy_process('./spec/data/hello_world_process/hello_world.zip',
-                                        type: 'RUBY',
-                                        name: 'Test ETL zipped file Process')
+      process1 = @project.deploy_process(
+        './spec/data/hello_world_process/hello_world.zip',
+        type: 'RUBY',
+        name: 'Test ETL zipped file Process'
+      )
 
       process2 = process1.deploy('./spec/data/ruby_process/process.rb')
       expect(process1.executables).not_to eq process2.executables
@@ -278,16 +279,15 @@ describe "Full process and schedule exercise", :constraint => 'slow' do
     end
   end
 
-
   it 'should be able to clone with etl' do
     begin
       # Deploy two schedules
       process = @project.processes.first
       schedule_first = process.create_schedule('0 15 27 7 *', process.executables.first)
       schedule_second = process.create_schedule('0 15 27 8 *', process.executables.first)
-      cloned_project = GoodData::Project.clone_with_etl(@project)
-      a = @project.processes.flat_map {|p| p.schedules.map {|s| [p.name, s.name]}}
-      b = cloned_project.processes.flat_map {|p| p.schedules.map {|s| [p.name, s.name]}}
+      cloned_project = GoodData::Project.clone_with_etl(@project, auth_token: ConnectionHelper::GD_PROJECT_TOKEN)
+      a = @project.processes.flat_map { |p| p.schedules.map { |s| [p.name, s.name] } }
+      b = cloned_project.processes.flat_map { |p| p.schedules.map { |s| [p.name, s.name] } }
       expect(a).to eq b
     ensure
       cloned_project && cloned_project.delete
@@ -295,4 +295,73 @@ describe "Full process and schedule exercise", :constraint => 'slow' do
       schedule_second && schedule_second.delete
     end
   end
+
+  it 'should have no notification when creating a new process' do
+    begin
+      process = @project.deploy_process('./spec/data/ruby_params_process', type: 'RUBY', name: 'Ruby params process')
+      expect(process.notification_rules).to eq []
+    ensure
+      process && process.delete
+    end
+  end
+
+  it 'should be able to add a notification rule' do
+    begin
+      process = @project.deploy_process('./spec/data/ruby_params_process', type: 'RUBY', name: 'Ruby params process')
+      old_notification_rules = process.notification_rules
+      notification_rule = process.create_notification_rule(email: ConnectionHelper::DEFAULT_USERNAME, events: GoodData::Subscription::PROCESS_SUCCESS_EVENT)
+      expect(notification_rule.class).to be GoodData::NotificationRule
+      expect(old_notification_rules).not_to include(notification_rule)
+      new_notification_rules = process.notification_rules
+      expect(new_notification_rules).to include(notification_rule)
+      expect(old_notification_rules.length + 1).to eq new_notification_rules.length
+    ensure
+      notification_rule && notification_rule.delete
+      process && process.delete
+    end
+  end
+
+  it 'should be able to remove a notification rule' do
+    begin
+      process = @project.deploy_process('./spec/data/ruby_params_process', type: 'RUBY', name: 'Ruby params process')
+      old_notification_rules = process.notification_rules
+      notification_rule = process.create_notification_rule(email: ConnectionHelper::DEFAULT_USERNAME, events: GoodData::Subscription::PROCESS_SUCCESS_EVENT)
+      notification_rule.delete
+      new_notification_rules = process.notification_rules
+      expect(new_notification_rules).to eq old_notification_rules
+    ensure
+      process && process.delete
+    end
+  end
+
+  it 'should be able to edit a notification rule' do
+    begin
+      process = @project.deploy_process('./spec/data/ruby_params_process', type: 'RUBY', name: 'Ruby params process')
+      notification_rule = process.create_notification_rule(email: ConnectionHelper::DEFAULT_USERNAME, events: GoodData::Subscription::PROCESS_SUCCESS_EVENT)
+      expect(notification_rule.email).to eq ConnectionHelper::DEFAULT_USERNAME
+      expect(notification_rule.subject).to eq 'Email subject'
+      expect(notification_rule.body).to eq 'Email body'
+      expect(notification_rule.events).to eq [GoodData::Subscription::PROCESS_SUCCESS_EVENT]
+
+      notification_rule = GoodData::NotificationRule[notification_rule.notification_rule_id, project: @project, process: process, client: @client]
+      notification_rule.events = [GoodData::Subscription::PROCESS_SUCCESS_EVENT, GoodData::Subscription::PROCESS_STARTED_EVENT]
+      notification_rule.save
+
+      expect(process.notification_rules.first.events).to eq [GoodData::Subscription::PROCESS_SUCCESS_EVENT, GoodData::Subscription::PROCESS_STARTED_EVENT]
+    ensure
+      notification_rule && notification_rule.delete
+      process && process.delete
+    end
+  end
+
+  it 'should be able to get all notification rules' do
+    begin
+      process = @project.deploy_process('./spec/data/ruby_params_process', type: 'RUBY', name: 'Ruby params process')
+      notification_rule = process.create_notification_rule(email: ConnectionHelper::DEFAULT_USERNAME, events: GoodData::Subscription::PROCESS_SUCCESS_EVENT)
+      expect(process.notification_rules).to eq [notification_rule]
+    ensure
+      notification_rule && notification_rule.delete
+      process && process.delete
+    end
+  end
 end

data/spec/integration/full_project_spec.rb

@@ -1,6 +1,6 @@
 # encoding: UTF-8
 #
-# Copyright (c) 2010-2015 GoodData Corporation. All rights reserved.
+# Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
 # This source code is licensed under the BSD-style license found in the
 # LICENSE file in the root directory of this source tree.
 
@@ -10,7 +10,7 @@ describe "Full project implementation", :constraint => 'slow' do
   before(:all) do
     @spec = JSON.parse(File.read("./spec/data/blueprints/test_project_model_spec.json"), :symbolize_names => true)
     @invalid_spec = JSON.parse(File.read("./spec/data/blueprints/invalid_blueprint.json"), :symbolize_names => true)
-    @client = ConnectionHelper::create_default_connection
+    @client = ConnectionHelper.create_default_connection
     @blueprint = GoodData::Model::ProjectBlueprint.new(@spec)
     @invalid_blueprint = GoodData::Model::ProjectBlueprint.new(@invalid_spec)
 
@@ -24,9 +24,9 @@ describe "Full project implementation", :constraint => 'slow' do
   end
 
   it "should not build an invalid model" do
-    expect {
+    expect do
       @client.create_project_from_blueprint(@invalid_spec, auth_token: ConnectionHelper::GD_PROJECT_TOKEN, environment: ProjectHelper::ENVIRONMENT)
-    }.to raise_error(GoodData::ValidationError)
+    end.to raise_error(GoodData::ValidationError)
   end
 
   it "should do nothing if the project is updated with the same blueprint" do
@@ -49,7 +49,7 @@ describe "Full project implementation", :constraint => 'slow' do
     expect(results).to eq []
 
     # When we change the model using the original blueprint. Basically change the title back.
-    results = @project.update_from_blueprint(@spec)
+    @project.update_from_blueprint(@spec)
     # It should offer no changes using the original blueprint
     results = GoodData::Model::ProjectCreator.migrate_datasets(@spec, project: @project, client: @client, dry_run: true)
     expect(results).to eq []
@@ -95,32 +95,34 @@ describe "Full project implementation", :constraint => 'slow' do
   end
 
   it "should load the data" do
-    GoodData.with_project(@project) do |p|
+    GoodData.with_project(@project) do
       # blueprint = GoodData::Model::ProjectBlueprint.new(@spec)
       commits_data = [
-        ["lines_changed","committed_on","dev_id","repo_id"],
-        [1,"01/01/2014",1,1],
-        [3,"01/02/2014",2,2],
-        [5,"05/02/2014",3,1]]
+        %w(lines_changed committed_on dev_id repo_id),
+        [1, "01/01/2014", 1, 1],
+        [3, "01/02/2014", 2, 2],
+        [5, "05/02/2014", 3, 1]
+      ]
       @project.upload(commits_data, @blueprint, 'dataset.commits')
 
       devs_data = [
-        ["dev_id", "email"],
+        %w(dev_id email),
         [1, "tomas@gooddata.com"],
         [2, "petr@gooddata.com"],
-        [3, "jirka@gooddata.com"]]
+        [3, "jirka@gooddata.com"]
+      ]
       @project.upload(devs_data, @blueprint, 'dataset.devs')
     end
   end
 
   it "it silently ignores extra columns" do
-    GoodData.with_project(@project) do |p|
+    GoodData.with_project(@project) do
       blueprint = GoodData::Model::ProjectBlueprint.new(@spec)
       commits_data = [
-        ["lines_changed","committed_on","dev_id","repo_id", "extra_column"],
-        [1,"01/01/2014",1,1,"something"],
-        [3,"01/02/2014",2,2,"something"],
-        [5,"05/02/2014",3,1,"something else"]
+        %w(lines_changed committed_on dev_id repo_id extra_column),
+        [1, "01/01/2014", 1, 1, "something"],
+        [3, "01/02/2014", 2, 2, "something"],
+        [5, "05/02/2014", 3, 1, "something else"]
       ]
       @project.upload(commits_data, blueprint, 'dataset.commits')
     end
@@ -128,40 +130,46 @@ describe "Full project implementation", :constraint => 'slow' do
 
   context "it should give you a reasonable error message" do
     it "if you omit a column" do
-      GoodData.with_project(@project) do |p|
+      GoodData.with_project(@project) do
         blueprint = GoodData::Model::ProjectBlueprint.new(@spec)
         commits_data = [
-          ["lines_changed","committed_on","dev_id"],
-          [1,"01/01/2014",1],
-          [3,"01/02/2014",2],
-          [5,"05/02/2014",3]
+          %w(lines_changed committed_on dev_id),
+          [1, "01/01/2014", 1],
+          [3, "01/02/2014", 2],
+          [5, "05/02/2014", 3]
         ]
-        expect {@project.upload(commits_data, blueprint, 'dataset.commits')}.to raise_error(/repo_id/)
+        expect do
+          @project.upload(commits_data, blueprint, 'dataset.commits')
+        end.to raise_error(/repo_id/)
       end
     end
     it "if you give it a malformed CSV" do
-      GoodData.with_project(@project) do |p|
+      GoodData.with_project(@project) do
         blueprint = GoodData::Model::ProjectBlueprint.new(@spec)
         # 4 cols in header but not in the data
         commits_data = [
-          ["lines_changed","committed_on","dev_id","repo_id"],
-          [1,"01/01/2014",1],
-          [3,"01/02/2014",2],
-          [5,"05/02/2014",3]
+          %w(lines_changed committed_on dev_id repo_id),
+          [1, "01/01/2014", 1],
+          [3, "01/02/2014", 2],
+          [5, "05/02/2014", 3]
         ]
-        expect {@project.upload(commits_data, blueprint, 'dataset.commits')}.to raise_error(/Number of columns/)
+        expect do
+          @project.upload(commits_data, blueprint, 'dataset.commits')
+        end.to raise_error(/Number of columns/)
       end
     end
     it "if you give it wrong date format" do
-      GoodData.with_project(@project) do |p|
+      GoodData.with_project(@project) do
         blueprint = GoodData::Model::ProjectBlueprint.new(@spec)
         commits_data = [
-          ["lines_changed","committed_on","dev_id","repo_id"],
-          [1,"01/01/2014",1,1],
-          [3,"45/50/2014",2,2],
-          [5,"05/02/2014",3,1]
+          %w(lines_changed committed_on dev_id repo_id),
+          [1, "01/01/2014", 1, 1],
+          [3, "45/50/2014", 2, 2],
+          [5, "05/02/2014", 3, 1]
         ]
-        expect {@project.upload(commits_data, blueprint, 'dataset.commits')}.to raise_error(%r{45/50/2014})
+        expect do
+          @project.upload(commits_data, blueprint, 'dataset.commits')
+        end.to raise_error(%r{45/50/2014})
       end
     end
   end
@@ -247,9 +255,9 @@ describe "Full project implementation", :constraint => 'slow' do
     rd = r.latest_report_definition
     rd.content['chart'] = { 'styles' => { 'global' => { 'colorMapping' => 1 } } }
 
-    expect(GoodData::Helpers.get_path(rd.content, %w(chart styles global))).to eq ({ 'colorMapping' => 1 })
+    expect(GoodData::Helpers.get_path(rd.content, %w(chart styles global))).to eq('colorMapping' => 1)
     rd.reset_color_mapping!
-    expect(GoodData::Helpers.get_path(rd.content, %w(chart styles global))).to eq ({ 'colorMapping' => [] })
+    expect(GoodData::Helpers.get_path(rd.content, %w(chart styles global))).to eq('colorMapping' => [])
     r.delete
     res = m.used_by
     res.each do |dependency|
@@ -393,12 +401,13 @@ describe "Full project implementation", :constraint => 'slow' do
 
   it "should load the data" do
     devs_data = [
-      ["dev_id", "email"],
-      [4, "josh@gooddata.com"]]
+      %w(dev_id email),
+      [4, "josh@gooddata.com"]
+    ]
     @project.upload(devs_data, @blueprint, 'dataset.devs', mode: 'INCREMENTAL')
   end
 
-  it "should have more users"  do
+  it "should have more users" do
     attribute = @project.attributes('attr.devs.dev_id')
     expect(attribute.attribute?).to be true
     expect(attribute.create_metric.execute).to eq 4
@@ -469,14 +478,14 @@ describe "Full project implementation", :constraint => 'slow' do
 
   it "should be able to give you values for" do
     attribute = @project.attributes('attr.devs.dev_id')
-    values = attribute.labels.find { |l| l.identifier == 'label.devs.dev_id.email'}.values.to_a
+    values = attribute.labels.find { |l| l.identifier == 'label.devs.dev_id.email' }.values.to_a
     id = values.find { |v| v[:value] == 'tomas@gooddata.com' }[:uri][-1].to_i
     expect(attribute.values_for(id)).to eq ['tomas@gooddata.com', '1']
   end
 
   it "should be able to find specific element and give you the primary label value" do
     attribute = @project.attributes('attr.devs.dev_id')
-    values = attribute.labels.find { |l| l.identifier == 'label.devs.dev_id.email'}.values.to_a
+    values = attribute.labels.find { |l| l.identifier == 'label.devs.dev_id.email' }.values.to_a
     uri = values.find { |v| v[:value] == 'tomas@gooddata.com' }[:uri]
     expect(@project.find_attribute_element_value(uri)).to eq 'tomas@gooddata.com'
   end
@@ -527,12 +536,12 @@ describe "Full project implementation", :constraint => 'slow' do
       expect(cloned_metric).to be_nil
 
       result = @project.transfer_objects(m, project: [cloned_project], batch_size: 1)
-      expect(result).to eq [{project: cloned_project, result: true}]
+      expect(result).to eq [{ project: cloned_project, result: true }]
 
       # should work with pids
       result = @project.transfer_objects(m, project: [cloned_project.pid], batch_size: 1)
       expect(result.first[:result]).to be_truthy
-    ensure    
+    ensure
       cloned_project.delete
     end
   end
@@ -560,7 +569,7 @@ describe "Full project implementation", :constraint => 'slow' do
     r.save
     def_uris = r.definition_uris
     r.delete
-    expect { def_uris.each {|uri| @client.get(uri)} }.to raise_error(RestClient::ResourceNotFound)
+    expect { def_uris.each { |uri| @client.get(uri) } }.to raise_error(RestClient::ResourceNotFound)
   end
 
   it 'should be possible to delete data from a dataset' do
@@ -569,4 +578,17 @@ describe "Full project implementation", :constraint => 'slow' do
     dataset.delete_data
     expect(dataset.attributes.first.create_metric.execute).to be_nil
   end
+
+  it 'shoule be able to create project from blueprint support attribute sort order' do
+    begin
+      attr_sort_order_spec = JSON.parse(File.read("./spec/data/blueprints/attribute_sort_order_blueprint.json"), :symbolize_names => true)
+      attr_sort_order_blueprint = GoodData::Model::ProjectBlueprint.new(attr_sort_order_spec)
+
+      project = @client.create_project_from_blueprint(attr_sort_order_blueprint, token: ConnectionHelper::GD_PROJECT_TOKEN, environment: ProjectHelper::ENVIRONMENT)
+      attribute = project.blueprint.datasets('dataset.id').attributes('attr.id.name')
+      expect(attribute.order_by).to eq 'label.id.name.name_label_2 - DESC'
+    ensure
+      project && project.delete
+    end
+  end
 end

data/spec/integration/lcm_spec.rb

@@ -0,0 +1,41 @@
+# encoding: UTF-8
+#
+# Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
+# This source code is licensed under the BSD-style license found in the
+# LICENSE file in the root directory of this source tree.
+
+require 'gooddata'
+
+describe GoodData::LCM, :constraint => 'slow' do
+  before(:all) do
+    @client = ConnectionHelper.create_default_connection
+  end
+
+  after(:all) do
+    @client && @client.disconnect
+  end
+
+  it 'should be able to transfer attribute drill paths' do
+    begin
+      spec = JSON.parse(File.read("./spec/data/blueprints/attribute_sort_order_blueprint.json"), :symbolize_names => true)
+      blueprint = GoodData::Model::ProjectBlueprint.new(spec)
+
+      source_project = @client.create_project_from_blueprint(blueprint, token: ConnectionHelper::GD_PROJECT_TOKEN, environment: ProjectHelper::ENVIRONMENT)
+      target_project = @client.create_project_from_blueprint(source_project.blueprint, token: ConnectionHelper::GD_PROJECT_TOKEN, environment: ProjectHelper::ENVIRONMENT)
+
+      name_attribute_source = source_project.attributes('attr.id.name')
+      id_attribute_source = source_project.attributes('attr.id.id')
+      name_attribute_source.drill_down(id_attribute_source)
+
+      GoodData::LCM.transfer_attribute_drillpaths(source_project, target_project)
+
+      name_attribute_target = target_project.attributes('attr.id.name')
+      id_attribute_target = target_project.attributes('attr.id.id')
+      name_attribute_target.drill_down(id_attribute_target)
+      expect(target_project.labels(name_attribute_target.content['drillDownStepAttributeDF']).attribute_uri).to eq id_attribute_target.meta['uri']
+    ensure
+      source_project && source_project.delete
+      target_project && target_project.delete
+    end
+  end
+end