gooddata 0.6.49 → 0.6.50

data/spec/unit/helpers_spec.rb

@@ -1,6 +1,6 @@
 # encoding: UTF-8
 #
-# Copyright (c) 2010-2015 GoodData Corporation. All rights reserved.
+# Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
 # This source code is licensed under the BSD-style license found in the
 # LICENSE file in the root directory of this source tree.
 
@@ -17,14 +17,18 @@ describe GoodData::Helpers do
   describe '#running_on_windows?' do
     it 'works' do
       result = GoodData::Helpers.running_on_windows?
+      # rubocop:disable Style/DoubleNegation
       !!result.should == result
+      # rubocop:enable Style/DoubleNegation
     end
   end
 
   describe '#running_on_mac?' do
     it 'works' do
       result = GoodData::Helpers.running_on_a_mac?
+      # rubocop:disable Style/DoubleNegation
       !!result.should == result
+      # rubocop:enable Style/DoubleNegation
     end
   end
 
@@ -45,7 +49,7 @@ describe GoodData::Helpers do
       params = {
         'param' => 'value',
         'number_param' => 5,
-        'gd_encoded_params' => '{"deep": {"deeper": "deep value"}}',
+        'gd_encoded_params' => '{"deep": {"deeper": "deep value"}}'
       }
       expected_result = {
         'param' => 'value',
@@ -74,6 +78,139 @@ describe GoodData::Helpers do
       result = GoodData::Helpers.decode_params(params)
       expect(result).to eq(expected_result)
     end
+
+    it 'decodes the reference parameters in gd_encoded_params in String form' do
+      params = {
+        'param' => 'value',
+        'number_param' => 5,
+        'ads_password' => 'ads_123',
+        'my_password' => 'login_123',
+        'gd_encoded_params' => '{"login_username": "login_user", "login_password": "${my_password}", "data01": "\\\\${my_password}", "data02":"abc\\\\def"}'
+      }
+      expected_result = {
+        'param' => 'value',
+        'number_param' => 5,
+        'ads_password' => 'ads_123',
+        'my_password' => 'login_123',
+        'login_username' => 'login_user',
+        'login_password' => 'login_123',
+        'data01' => '\\login_123',
+        'data02' => 'abc\\def'
+      }
+      result = GoodData::Helpers.decode_params(params, :resolve_reference_params => true)
+      expect(result).to eq(expected_result)
+    end
+
+    it 'decodes the reference parameters in gd_encoded_params in Hash form' do
+      params = {
+        'param' => 'value',
+        'number_param' => 5,
+        'ads_password' => 'ads_123',
+        'my_password' => 'login_123',
+        'gd_encoded_params' => { "login_username" => "login_user", "login_password" => "${my_password}", "data01" => "\\\\${my_password}", "data02" => "abc\\def" }
+      }
+      expected_result = {
+        'param' => 'value',
+        'number_param' => 5,
+        'ads_password' => 'ads_123',
+        'my_password' => 'login_123',
+        'login_username' => 'login_user',
+        'login_password' => 'login_123',
+        'data01' => '\\login_123',
+        'data02' => 'abc\\def'
+      }
+      result = GoodData::Helpers.decode_params(params, :resolve_reference_params => true)
+      expect(result).to eq(expected_result)
+    end
+
+    it 'decodes escape the reference parameters in gd_encoded_params in String form' do
+      params = {
+        'param' => 'value',
+        'number_param' => 5,
+        'ads_password' => 'ads_123',
+        'my_password' => 'login_123',
+        'gd_encoded_params' => '{"login_username": "login_user", "data01": "\\${abc}"}'
+      }
+      expected_result = {
+        'param' => 'value',
+        'number_param' => 5,
+        'ads_password' => 'ads_123',
+        'my_password' => 'login_123',
+        'login_username' => 'login_user',
+        'data01' => '${abc}'
+      }
+      result = GoodData::Helpers.decode_params(params, :resolve_reference_params => true)
+      expect(result).to eq(expected_result)
+    end
+
+    it 'decodes escape the reference parameters in gd_encoded_params in Hash form' do
+      params = {
+        'param' => 'value',
+        'number_param' => 5,
+        'ads_password' => 'ads_123',
+        'my_password' => 'login_123',
+        'gd_encoded_params' => { "login_username" => "login_user", "data01" => "\\${abc}" }
+      }
+      expected_result = {
+        'param' => 'value',
+        'number_param' => 5,
+        'ads_password' => 'ads_123',
+        'my_password' => 'login_123',
+        'login_username' => 'login_user',
+        'data01' => '${abc}'
+      }
+      result = GoodData::Helpers.decode_params(params, :resolve_reference_params => true)
+      expect(result).to eq(expected_result)
+    end
+
+    it 'decodes the reference parameters in nested block in gd_encoded_params in String form' do
+      params = {
+        'param' => 'value',
+        'number_param' => 5,
+        'ads_password' => 'ads_123',
+        'my_password' => 'login_123',
+        'gd_encoded_params' => '{"login_username": "login_user", "login_password": "${my_password}", "ads_client": {"username": "ads_user", "password": "${ads_password}"}}'
+      }
+      expected_result = {
+        'param' => 'value',
+        'number_param' => 5,
+        'ads_password' => 'ads_123',
+        'my_password' => 'login_123',
+        'login_username' => 'login_user',
+        'login_password' => 'login_123',
+        'ads_client' => {
+          'username' => 'ads_user',
+          'password' => 'ads_123'
+        }
+      }
+      result = GoodData::Helpers.decode_params(params, :resolve_reference_params => true)
+      expect(result).to eq(expected_result)
+    end
+
+    it 'decodes the reference parameters in nested block in gd_encoded_params in Hash form' do
+      params = {
+        'param' => 'value',
+        'number_param' => 5,
+        'ads_password' => 'ads_123',
+        'my_password' => 'login_123',
+        'gd_encoded_params' => { "login_username" => "login_user", "login_password" => "${my_password}", "ads_client" => { "username" => "ads_user", "password" => "${ads_password}" } }
+      }
+      expected_result = {
+        'param' => 'value',
+        'number_param' => 5,
+        'ads_password' => 'ads_123',
+        'my_password' => 'login_123',
+        'login_username' => 'login_user',
+        'login_password' => 'login_123',
+        'ads_client' => {
+          'username' => 'ads_user',
+          'password' => 'ads_123'
+        }
+      }
+      result = GoodData::Helpers.decode_params(params, :resolve_reference_params => true)
+      expect(result).to eq(expected_result)
+    end
+
     it 'throws an error when data params is not a valid json' do
       params = {
         'param' => 'value',

data/spec/unit/models/blueprint/attribute_sort_by_spec.rb

@@ -0,0 +1,20 @@
+# encoding: UTF-8
+#
+# Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
+# This source code is licensed under the BSD-style license found in the
+# LICENSE file in the root directory of this source tree.
+
+require 'gooddata'
+
+describe GoodData::Model::AttributeBlueprintField do
+  before(:each) do
+    @model_view = MultiJson.load(File.read('./spec/data/wire_models/attribute_sort_by_model.json'))
+    @blueprint = GoodData::Model::FromWire.from_wire(@model_view)
+    @dataset = @blueprint.datasets('dataset.id')
+    @attribute = @dataset.attributes('attr.id.name')
+  end
+
+  it 'should return label id and direction of sorted attribute' do
+    expect(@attribute.order_by).to eq 'label.id.name.name_label_2 - DESC'
+  end
+end

data/spec/unit/models/blueprint/attributes_spec.rb

@@ -1,13 +1,12 @@
 # encoding: UTF-8
 #
-# Copyright (c) 2010-2015 GoodData Corporation. All rights reserved.
+# Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
 # This source code is licensed under the BSD-style license found in the
 # LICENSE file in the root directory of this source tree.
 
 require 'gooddata'
 
 describe GoodData::Model::AttributeBlueprintField do
-
   before(:each) do
     @model_view = MultiJson.load(File.read('./spec/data/wire_models/model_view.json'))
     @blueprint = GoodData::Model::FromWire.from_wire(@model_view)

data/spec/unit/models/blueprint/dataset_spec.rb

@@ -1,13 +1,12 @@
 # encoding: UTF-8
 #
-# Copyright (c) 2010-2015 GoodData Corporation. All rights reserved.
+# Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
 # This source code is licensed under the BSD-style license found in the
 # LICENSE file in the root directory of this source tree.
 
 require 'gooddata'
 
 describe GoodData::Model::DatasetBlueprint do
-
   before(:each) do
     @model_view = MultiJson.load(File.read('./spec/data/wire_models/model_view.json'))
     @blueprint = GoodData::Model::FromWire.from_wire(@model_view)
@@ -80,7 +79,7 @@ describe GoodData::Model::DatasetBlueprint do
   describe '#references' do
     it 'should return references on dataset' do
       expect(@dataset.references.count).to eq 2
-      expect(@dataset.references.map {|r| r.data[:dataset]}).to eq [
+      expect(@dataset.references.map { |r| r.data[:dataset] }).to eq [
         'dataset.opp_records',
         'dataset.consolidatedmarketingstatus'
       ]

data/spec/unit/models/blueprint/labels_spec.rb

@@ -1,13 +1,12 @@
 # encoding: UTF-8
 #
-# Copyright (c) 2010-2015 GoodData Corporation. All rights reserved.
+# Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
 # This source code is licensed under the BSD-style license found in the
 # LICENSE file in the root directory of this source tree.
 
 require 'gooddata'
 
 describe GoodData::Model::LabelBlueprintField do
-
   before(:each) do
     @model_view = MultiJson.load(File.read('./spec/data/wire_models/model_view.json'))
     @blueprint = GoodData::Model::FromWire.from_wire(@model_view)

data/spec/unit/models/blueprint/project_blueprint_spec.rb

@@ -1,13 +1,12 @@
 # encoding: UTF-8
 #
-# Copyright (c) 2010-2015 GoodData Corporation. All rights reserved.
+# Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
 # This source code is licensed under the BSD-style license found in the
 # LICENSE file in the root directory of this source tree.
 
 require 'gooddata'
 
 describe GoodData::Model::ProjectBlueprint do
-
   before(:each) do
     @blueprint = GoodData::Model::ProjectBlueprint.from_json('./spec/data/blueprints/test_project_model_spec.json')
     @invalid_blueprint = GoodData::Model::ProjectBlueprint.from_json('./spec/data/blueprints/invalid_blueprint.json')
@@ -38,7 +37,7 @@ describe GoodData::Model::ProjectBlueprint do
       end
       expect(bp.valid?).to be_falsey
       errors = bp.validate
-      expect(errors.map {|x| x[:type]}.to_set).to eq [:attribute_without_label, :more_than_on_anchor].to_set
+      expect(errors.map { |x| x[:type] }.to_set).to eq [:attribute_without_label, :more_than_on_anchor].to_set
       expect(errors.count).to eq 2
     end
 
@@ -80,7 +79,7 @@ describe GoodData::Model::ProjectBlueprint do
           d.add_fact('more_numbers')
         end
       end
-      bp.valid?.should == true
+      bp.valid?.should be_truthy
       errors = bp.validate
       expect(errors.count).to eq 0
       facts = bp.to_wire[:diffRequest][:targetModel][:projectModel][:datasets].first[:dataset][:facts]
@@ -92,7 +91,7 @@ describe GoodData::Model::ProjectBlueprint do
       expect(@invalid_blueprint.valid?).to eq false
     end
   end
-  
+
   describe '#validate' do
     it 'valid blueprint should give you empty array of errors' do
       expect(@blueprint.validate).to be_empty
@@ -101,11 +100,13 @@ describe GoodData::Model::ProjectBlueprint do
     it 'invalid blueprint should give you list of violating references' do
       errors = @invalid_blueprint.validate
       expect(errors.size).to eq 1
-      expect(errors).to eq([{
-        :type=>:wrong_label_reference,
-        :label=>"some_label_id",
-        :wrong_reference=>"attr.repos.repo_id                 ERROR"
-        }])
+      expect(errors).to eq([
+        {
+          :type => :wrong_label_reference,
+          :label => "some_label_id",
+          :wrong_reference => "attr.repos.repo_id                 ERROR"
+        }
+      ])
     end
 
     it 'invalid label is caught correctly' do
@@ -124,18 +125,18 @@ describe GoodData::Model::ProjectBlueprint do
       expect(errors.count).to eq 3
       expect(errors).to eq [
         {
-          :type=>:wrong_label_reference,
-          :label=>"label.attribute1.name",
-          :wrong_reference=>"attr.attribute23123"
+          :type => :wrong_label_reference,
+          :label => "label.attribute1.name",
+          :wrong_reference => "attr.attribute23123"
         },
         {
-          :type=>:wrong_label_reference,
-          :label=>"label.attribute1.ssn",
-          :wrong_reference=>"attr.attribute23123"
+          :type => :wrong_label_reference,
+          :label => "label.attribute1.ssn",
+          :wrong_reference => "attr.attribute23123"
         },
         {
-          :type=>:attribute_without_label,
-          :attribute=>"attr.attribute1"
+          :type => :attribute_without_label,
+          :attribute => "attr.attribute1"
         }
       ]
     end
@@ -274,7 +275,7 @@ describe GoodData::Model::ProjectBlueprint do
       expect(@blueprint.facts.count).to eq 1
     end
   end
-  
+
   describe '#labels' do
     it 'Anchor on repos should have a label' do
       expect(@repos.anchor.labels.size).to eq 1
@@ -286,7 +287,7 @@ describe GoodData::Model::ProjectBlueprint do
 
     it "should return labels form all datasets" do
       expect(@blueprint.labels.count).to eq 4
-    end    
+    end
   end
 
   describe '#attributes_and_anchors' do
@@ -297,7 +298,7 @@ describe GoodData::Model::ProjectBlueprint do
 
   describe '#merge' do
     it "should be able to merge models without mutating the original" do
-      additional_blueprint = GoodData::Model::ProjectBlueprint.from_json("./spec/data/blueprints/additional_dataset_module.json") 
+      additional_blueprint = GoodData::Model::ProjectBlueprint.from_json("./spec/data/blueprints/additional_dataset_module.json")
       expect(@blueprint.datasets.count).to eq 3
       new_bp = @blueprint.merge(additional_blueprint)
       expect(@blueprint.datasets.count).to eq 3
@@ -373,15 +374,15 @@ describe GoodData::Model::ProjectBlueprint do
           d.add_date('created_on')
         end
       end
-      expect {
-        c = a.merge(b)
-      }.to raise_exception 'Unable to merge date dimensions created_on with defintion {:type=>:date_dimension, :urn=>nil, :id=>"created_on", :title=>"title B"} with {:type=>:date_dimension, :urn=>nil, :id=>"created_on", :title=>"title A"}'
+      expect do
+        a.merge(b)
+      end.to raise_exception 'Unable to merge date dimensions created_on with defintion {:type=>:date_dimension, :urn=>nil, :id=>"created_on", :title=>"title B"} with {:type=>:date_dimension, :urn=>nil, :id=>"created_on", :title=>"title A"}'
     end
   end
 
   describe '#merge!' do
     it "should be able to merge models" do
-      additional_blueprint = GoodData::Model::ProjectBlueprint.from_json("./spec/data/blueprints/additional_dataset_module.json") 
+      additional_blueprint = GoodData::Model::ProjectBlueprint.from_json("./spec/data/blueprints/additional_dataset_module.json")
       expect(@blueprint.datasets.count).to eq 3
       @blueprint.merge!(additional_blueprint)
       expect(@blueprint.datasets.count).to eq 4
@@ -399,8 +400,6 @@ describe GoodData::Model::ProjectBlueprint do
     expect(@blueprint.datasets.count).to eq 4
   end
 
-
-
   it "should be able to serialize itself to a hash" do
     ser = @blueprint.to_hash
     ser.is_a?(Hash)
@@ -440,7 +439,7 @@ describe GoodData::Model::ProjectBlueprint do
         d.add_date('opportunity_comitted', dataset: 'committed_on')
       end
     end
-    expect(bp.datasets.flat_map { |d| d.find_columns_by_type(:date) }.map { |a| a.format }).to eq [GoodData::Model::DEFAULT_DATE_FORMAT]
+    expect(bp.datasets.flat_map { |d| d.find_columns_by_type(:date) }.map(&:format)).to eq [GoodData::Model::DEFAULT_DATE_FORMAT]
   end
 
   it 'blueprint can be set with explicit date' do
@@ -458,7 +457,7 @@ describe GoodData::Model::ProjectBlueprint do
       end
     end
     expect(bp.valid?).to be_truthy
-    expect(bp.datasets.flat_map { |d| d.find_columns_by_type(:date) }.map { |a| a.format }).to eq ['yyyy/MM/dd']
+    expect(bp.datasets.flat_map { |d| d.find_columns_by_type(:date) }.map(&:format)).to eq ['yyyy/MM/dd']
   end
 
   describe '#remove' do
@@ -501,21 +500,21 @@ describe GoodData::Model::ProjectBlueprint do
     end
 
     it 'crashes gracefully when nonexistent field is being moved' do
-      expect {
+      expect do
         @blueprint.move!('nonexistent_field', 'dataset.commits', 'dataset.repos')
-      }.to raise_exception 'Column nonexistent_field cannot be found in dataset dataset.commits'
+      end.to raise_exception 'Column nonexistent_field cannot be found in dataset dataset.commits'
     end
 
     it 'crashes gracefully when datasets does not exist' do
-      expect {
+      expect do
         @blueprint.move!('nonexistent_field', 'dataset.A', 'dataset.repos')
-      }.to raise_exception 'Dataset "dataset.A" could not be found'
+      end.to raise_exception 'Dataset "dataset.A" could not be found'
     end
 
     it 'crashes gracefully when datasets does not exist' do
-      expect {
+      expect do
         @blueprint.move!('nonexistent_field', 'dataset.commits', 'dataset.B')
-      }.to raise_exception 'Dataset "dataset.B" could not be found'
+      end.to raise_exception 'Dataset "dataset.B" could not be found'
     end
   end
 

data/spec/unit/models/blueprint/reference_spec.rb

@@ -1,13 +1,12 @@
 # encoding: UTF-8
 #
-# Copyright (c) 2010-2015 GoodData Corporation. All rights reserved.
+# Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
 # This source code is licensed under the BSD-style license found in the
 # LICENSE file in the root directory of this source tree.
 
 require 'gooddata'
 
 describe GoodData::Model::ReferenceBlueprintField do
-
   before(:each) do
     @model_view = MultiJson.load(File.read('./spec/data/wire_models/model_view.json'))
     @blueprint = GoodData::Model::FromWire.from_wire(@model_view)