gooddata 0.6.49 → 0.6.50

data/spec/integration/user_group_spec.rb

@@ -1,6 +1,6 @@
 # encoding: UTF-8
 #
-# Copyright (c) 2010-2015 GoodData Corporation. All rights reserved.
+# Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
 # This source code is licensed under the BSD-style license found in the
 # LICENSE file in the root directory of this source tree.
 
@@ -11,11 +11,11 @@ describe GoodData::UserGroup do
     @user_group_name = 'My Test Group'
     @user_group_description = 'My Test Description'
 
-    @client = ConnectionHelper::create_default_connection
+    @client = ConnectionHelper.create_default_connection
     @project = @client.create_project(title: 'UserGroup Testing Project', token: ConnectionHelper::GD_PROJECT_TOKEN, environment: ProjectHelper::ENVIRONMENT)
     @domain = @client.domain(ConnectionHelper::DEFAULT_DOMAIN)
 
-    users = (1..5).to_a.map do |x|
+    users = (1..5).to_a.map do
       {
         user: ProjectHelper.create_random_user(@client),
         role: 'Admin'
@@ -29,7 +29,7 @@ describe GoodData::UserGroup do
   end
 
   after(:all) do
-    @group && @group.delete
+    # @group && @group.delete
     @project && @project.delete
     @client.disconnect
   end
@@ -49,7 +49,7 @@ describe GoodData::UserGroup do
       @group.add_member(users)
 
       new_count = @group.members.to_a.length
-      expect(new_count).to eq (old_count + 1)
+      expect(new_count).to eq(old_count + 1)
 
       group_members = @group.members.to_a
 
@@ -124,4 +124,24 @@ describe GoodData::UserGroup do
       expect(@group.description).to eq new_description
     end
   end
+
+  describe '#save' do
+    it 'updates existing group' do
+      new_description = 'This is new description'
+      @group.description = new_description
+      @group.save
+      @group = @project.user_groups(@group.obj_id)
+      expect(@group.description).to eq new_description
+    end
+  end
+
+  describe '.create' do
+    it 'sets client attribute' do
+      expect(@group.client).not_to be_nil
+    end
+
+    it 'sets project attribute' do
+      expect(@group.project).not_to be_nil
+    end
+  end
 end

data/spec/integration/variables_spec.rb

@@ -1,6 +1,6 @@
 # encoding: UTF-8
 #
-# Copyright (c) 2010-2015 GoodData Corporation. All rights reserved.
+# Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
 # This source code is licensed under the BSD-style license found in the
 # LICENSE file in the root directory of this source tree.
 
@@ -9,7 +9,7 @@ require 'gooddata'
 describe "Variables implementation", :constraint => 'slow' do
   before(:all) do
     @spec = JSON.parse(File.read("./spec/data/blueprints/test_project_model_spec.json"), :symbolize_names => true)
-    @client = ConnectionHelper::create_default_connection
+    @client = ConnectionHelper.create_default_connection
     blueprint = GoodData::Model::ProjectBlueprint.new(@spec)
     @project = @client.create_project_from_blueprint(blueprint, :token => ConnectionHelper::GD_PROJECT_TOKEN, environment: ProjectHelper::ENVIRONMENT)
     @domain = @client.domain(ConnectionHelper::DEFAULT_DOMAIN)
@@ -17,21 +17,22 @@ describe "Variables implementation", :constraint => 'slow' do
     @label = GoodData::Attribute.find_first_by_title('Dev', client: @client, project: @project).label_by_name('email')
 
     commits_data = [
-      ["lines_changed","committed_on","dev_id","repo_id"],
-      [1,"01/01/2014",1,1],
-      [3,"01/02/2014",2,2],
-      [5,"05/02/2014",3,1]]
+      %w(lines_changed committed_on dev_id repo_id),
+      [1, "01/01/2014", 1, 1],
+      [3, "01/02/2014", 2, 2],
+      [5, "05/02/2014", 3, 1]
+    ]
     @project.upload(commits_data, blueprint, 'dataset.commits')
-    
+
     devs_data = [
-      ["dev_id", "email"],
+      %w(dev_id email),
       [1, "tomas@gooddata.com"],
       [2, "petr@gooddata.com"],
-      [3, "jirka@gooddata.com"]]
+      [3, "jirka@gooddata.com"]
+    ]
     @project.upload(devs_data, blueprint, 'dataset.devs')
-    
-    @variable = @project.create_variable(title: 'uaaa', attribute: @label.attribute).save
 
+    @variable = @project.create_variable(title: 'uaaa', attribute: @label.attribute).save
   end
 
   after(:all) do
@@ -39,7 +40,7 @@ describe "Variables implementation", :constraint => 'slow' do
   end
 
   after(:each) do
-    @variable.user_values.select {|x| x.level == :user}.pmap &:delete
+    @variable.user_values.select { |x| x.level == :user }.pmap(&:delete)
   end
 
   it "should create a variable filter" do
@@ -51,14 +52,14 @@ describe "Variables implementation", :constraint => 'slow' do
     # [5.0                | 3.0               | 1.0               ]
     @project.add_variable_permissions(filters, @variable)
     r = @project.compute_report(left: [metric], top: [@label.attribute], filters: [@variable])
-    r.include_column?(['tomas@gooddata.com', 1]).should == true
-    r.include_column?(['jirka@gooddata.com', 5]).should == true
-    r.include_column?(['petr@gooddata.com', 3]).should == false
+    expect(r.include_column?(['tomas@gooddata.com', 1])).to be_truthy
+    expect(r.include_column?(['jirka@gooddata.com', 5])).to be_truthy
+    expect(r.include_column?(['petr@gooddata.com', 3])).to be_falsy
 
     r = @project.compute_report(left: [metric], top: [@label.attribute])
-    r.include_column?(['tomas@gooddata.com', 1]).should == true
-    r.include_column?(['jirka@gooddata.com', 5]).should == true
-    r.include_column?(['petr@gooddata.com', 3]).should == true
+    expect(r.include_column?(['tomas@gooddata.com', 1])).to be_truthy
+    expect(r.include_column?(['jirka@gooddata.com', 5])).to be_truthy
+    expect(r.include_column?(['petr@gooddata.com', 3])).to be_truthy
   end
 
   it "should fail when asked to set a user not in project. No filters should be set up." do
@@ -79,7 +80,7 @@ describe "Variables implementation", :constraint => 'slow' do
     @project.add_variable_permissions(filters, @variable)
     expect(@variable.user_values.count).to eq 1
   end
-  
+
   it "should pass and set only users that are in the projects if asked" do
     filters = [
       ['nonexistent_user@gooddata.com', @label.uri, 'tomas@gooddata.com'],
@@ -88,22 +89,23 @@ describe "Variables implementation", :constraint => 'slow' do
     @project.add_variable_permissions(filters, @variable, users_must_exist: false)
     expect(@variable.user_values.count).to eq 1
   end
-  
+
   it "should fail when asked to set a value not in the proejct" do
     filters = [
       [ConnectionHelper::DEFAULT_USERNAME, @label.uri, '%^&*( nonexistent value', 'tomas@gooddata.com'],
-      [ConnectionHelper::DEFAULT_USERNAME, @label.uri, 'tomas@gooddata.com']]
+      [ConnectionHelper::DEFAULT_USERNAME, @label.uri, 'tomas@gooddata.com']
+    ]
     expect do
       @project.add_variable_permissions(filters, @variable)
     end.to raise_error
     expect(@variable.user_values.count).to eq 0
   end
-  
+
   it "should add a filter with nonexistent values when asked" do
     filters = [[ConnectionHelper::DEFAULT_USERNAME, @label.uri, '%^&*( nonexistent value', 'jirka@gooddata.com']]
     @project.add_variable_permissions(filters, @variable, ignore_missing_values: true)
-  
-    expect(@variable.user_values.pmap {|m| m.pretty_expression}).to eq ["[Dev] IN ([jirka@gooddata.com])"]
+
+    expect(@variable.user_values.pmap(&:pretty_expression)).to eq ["[Dev] IN ([jirka@gooddata.com])"]
     expect(@variable.user_values.count).to eq 1
   end
 
@@ -111,7 +113,7 @@ describe "Variables implementation", :constraint => 'slow' do
     filters = [[ConnectionHelper::DEFAULT_USERNAME, @label.uri, "tomas@gooddata.com"]]
     @project.add_variable_permissions(filters, @variable)
     perms = @variable.user_values
-    pretty = perms.pmap {|f| [f.related.login, f.pretty_expression]}
+    pretty = perms.pmap { |f| [f.related.login, f.pretty_expression] }
     expect(perms.first.related).to eq @client.user
     expect(pretty).to eq [[ConnectionHelper::DEFAULT_USERNAME, "[Dev] IN ([tomas@gooddata.com])"]]
   end
@@ -124,7 +126,7 @@ describe "Variables implementation", :constraint => 'slow' do
       [user_with_already_set_up_filter.login, @label.uri, "tomas@gooddata.com"]
     ]
     @project.add_variable_permissions(filters, @variable)
-    expect(@variable.user_values.map {|f| [f.related.login, f.pretty_expression] })
+    expect(@variable.user_values.map { |f| [f.related.login, f.pretty_expression] })
       .to eq [[ConnectionHelper::DEFAULT_USERNAME, "[Dev] IN ([tomas@gooddata.com])"]]
 
     # Now let's add user filter to a different user. If we do not explicitely state that
@@ -135,16 +137,16 @@ describe "Variables implementation", :constraint => 'slow' do
       [another_user.login, @label.uri, "tomas@gooddata.com"]
     ]
     @project.add_variable_permissions(new_filters, @variable)
-    expect(@variable.user_values.map {|f| [f.related.login, f.pretty_expression] })
+    expect(@variable.user_values.map { |f| [f.related.login, f.pretty_expression] })
       .to eq [[another_user.login, "[Dev] IN ([tomas@gooddata.com])"]]
   end
 
   it "should set up false if all values are nonexistent" do
-    metric = GoodData::Fact.find_first_by_title('Lines Changed', client: @client, project: @project).create_metric
+    # metric = GoodData::Fact.find_first_by_title('Lines Changed', client: @client, project: @project).create_metric
     filters = [[ConnectionHelper::DEFAULT_USERNAME, @label.uri, "NONEXISTENT1", "NONEXISTENT2", "NONEXISTENT3"]]
     @project.add_variable_permissions(filters, @variable, ignore_missing_values: true)
     # expect(metric.execute).to eq 9
-    expect(@variable.user_values.map {|f| [f.related.login, f.pretty_expression] })
+    expect(@variable.user_values.map { |f| [f.related.login, f.pretty_expression] })
       .to eq [[ConnectionHelper::DEFAULT_USERNAME, "TRUE"]]
 
     @project.add_variable_permissions(filters, @variable, ignore_missing_values: true, restrict_if_missing_all_values: true)
@@ -160,7 +162,7 @@ describe "Variables implementation", :constraint => 'slow' do
       [user_with_already_set_up_filter.login, @label.uri, "tomas@gooddata.com"]
     ]
     @project.add_variable_permissions(filters, @variable)
-    expect(@variable.user_values.map {|f| [f.related.login, f.pretty_expression] })
+    expect(@variable.user_values.map { |f| [f.related.login, f.pretty_expression] })
       .to eq [[ConnectionHelper::DEFAULT_USERNAME, "[Dev] IN ([tomas@gooddata.com])"]]
     # Now let's add user filter to a different user. If we do not explicitely state that
     # user_with_already_set_up_filter should keep his filter it will be removed
@@ -170,12 +172,12 @@ describe "Variables implementation", :constraint => 'slow' do
       [another_user.login, @label.uri, "tomas@gooddata.com"]
     ]
     @project.add_variable_permissions(new_filters, @variable, do_not_touch_filters_that_are_not_mentioned: true)
-    expect(@variable.user_values.map {|f| [f.related.login, f.pretty_expression] })
+    expect(@variable.user_values.map { |f| [f.related.login, f.pretty_expression] })
       .to include([ConnectionHelper::DEFAULT_USERNAME, "[Dev] IN ([tomas@gooddata.com])"],
                   [another_user.login, "[Dev] IN ([tomas@gooddata.com])"])
   end
 
-  it "should be able to update the filter value in place" do
+  it "should be able to update the filter value in place", broken: true do
     pending 'FIXME: We cannot swap filters yet'
 
     filters = [[ConnectionHelper::DEFAULT_USERNAME, @label.uri, "tomas@gooddata.com", "jirka@gooddata.com"]]

data/spec/logging_in_logging_out_spec.rb

@@ -1,16 +1,14 @@
 # encoding: UTF-8
 #
-# Copyright (c) 2010-2015 GoodData Corporation. All rights reserved.
+# Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
 # This source code is licensed under the BSD-style license found in the
 # LICENSE file in the root directory of this source tree.
 
 require 'gooddata'
-require 'pry'
 
 describe GoodData::Rest::Connection, :constraint => 'slow' do
-
   it "should log in and disconnect" do
-    client = ConnectionHelper::create_default_connection
+    client = ConnectionHelper.create_default_connection
     expect(client).to be_kind_of(GoodData::Rest::Client)
 
     client.get("/gdc/md")
@@ -61,7 +59,7 @@ describe GoodData::Rest::Connection, :constraint => 'slow' do
   end
 
   it "should log in and disconnect with SST" do
-    regular_client = ConnectionHelper::create_default_connection
+    regular_client = ConnectionHelper.create_default_connection
     sst = regular_client.connection.sst_token
 
     sst_client = GoodData.connect(sst_token: sst, verify_ssl: false)
@@ -72,7 +70,7 @@ describe GoodData::Rest::Connection, :constraint => 'slow' do
   end
 
   it "should log in and disconnect with SST with additional params" do
-    regular_client = ConnectionHelper::create_default_connection
+    regular_client = ConnectionHelper.create_default_connection
     sst = regular_client.connection.sst_token
 
     sst_client = GoodData.connect(sst_token: sst, verify_ssl: false, webdav_server: 'https://some_random_server/')
@@ -84,8 +82,8 @@ describe GoodData::Rest::Connection, :constraint => 'slow' do
   end
 
   it "should be able to regenerate TT" do
-    regular_client = ConnectionHelper::create_default_connection
-    projects = regular_client.projects
+    regular_client = ConnectionHelper.create_default_connection
+    regular_client.projects
     regular_client.connection.headers.delete(:x_gdc_authtt)
     regular_client.get('/gdc/md')
     expect(regular_client.connection.headers).to have_key :x_gdc_authtt

data/spec/spec_helper.rb

@@ -1,6 +1,6 @@
 # encoding: UTF-8
 #
-# Copyright (c) 2010-2015 GoodData Corporation. All rights reserved.
+# Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
 # This source code is licensed under the BSD-style license found in the
 # LICENSE file in the root directory of this source tree.
 
@@ -75,9 +75,9 @@ RSpec.configure do |config|
   end
 end
 
-SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
+SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter.new(
   SimpleCov::Formatter::HTMLFormatter
-]
+)
 
 SimpleCov.start do
   add_filter 'spec/'

data/spec/unit/bricks/bricks_spec.rb

@@ -1,6 +1,6 @@
 # encoding: UTF-8
 #
-# Copyright (c) 2010-2015 GoodData Corporation. All rights reserved.
+# Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
 # This source code is licensed under the BSD-style license found in the
 # LICENSE file in the root directory of this source tree.
 
@@ -8,7 +8,7 @@ require 'gooddata/bricks/bricks'
 
 describe GoodData::Bricks::Brick do
   it "Has GoodData::Bricks::Brick class" do
-    GoodData::Bricks::Brick.should_not == nil
+    GoodData::Bricks::Brick.should_not be(nil)
   end
 
   describe '#version' do
@@ -22,8 +22,7 @@ describe GoodData::Bricks::Brick do
 
   it "should be possible to execute custom brick" do
     class CustomBrick < GoodData::Bricks::Brick
-
-      def call(params)
+      def call(_params)
         puts 'hello'
       end
     end

data/spec/unit/bricks/middleware/aws_middelware_spec.rb

@@ -1,6 +1,6 @@
 # encoding: UTF-8
 #
-# Copyright (c) 2010-2015 GoodData Corporation. All rights reserved.
+# Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
 # This source code is licensed under the BSD-style license found in the
 # LICENSE file in the root directory of this source tree.
 
@@ -10,32 +10,28 @@ require 'gooddata/bricks/middleware/aws_middleware'
 
 describe GoodData::Bricks::AWSMiddleware do
   it 'should do nothing if the key "aws_client" is not there at all' do
-    middleware = GoodData::Bricks::AWSMiddleware.new(app: lambda {|params| 'Doing nothing'})
+    middleware = GoodData::Bricks::AWSMiddleware.new(app: ->(_params) { 'Doing nothing' })
     middleware.call({})
   end
 
   it 'should fail gracefully if value aws_client param not present even though the key is' do
-    middleware = GoodData::Bricks::AWSMiddleware.new(app: lambda {|params| 'Doing nothing'})
+    middleware = GoodData::Bricks::AWSMiddleware.new(app: -> { 'Doing nothing' })
     expect do
       middleware.call('aws_client' => nil)
     end.to raise_exception 'Unable to connect to AWS. Parameter "aws_client" seems to be empty'
   end
 
   it 'should fail gracefully if value secret_access_key is missing' do
-    middleware = GoodData::Bricks::AWSMiddleware.new(app: lambda {|params| 'Doing nothing'})
+    middleware = GoodData::Bricks::AWSMiddleware.new(app: -> { 'Doing nothing' })
     expect do
-      middleware.call('aws_client' => {
-        'access_key_id' => 'something'
-      })
+      middleware.call('aws_client' => { 'access_key_id' => 'something' })
     end.to raise_exception 'Unable to connect to AWS. Parameter "secret_access_key" is missing'
   end
 
   it 'should fail gracefully if value access_key_id is missing' do
-    middleware = GoodData::Bricks::AWSMiddleware.new(app: lambda {|params| 'Doing nothing'})
+    middleware = GoodData::Bricks::AWSMiddleware.new(app: -> { 'Doing nothing' })
     expect do
-      middleware.call('aws_client' => {
-        'secret_access_key' => 'something'
-      })
+      middleware.call('aws_client' => { 'secret_access_key' => 'something' })
     end.to raise_exception 'Unable to connect to AWS. Parameter "access_key_id" is missing'
   end
 
@@ -43,9 +39,6 @@ describe GoodData::Bricks::AWSMiddleware do
     middleware = GoodData::Bricks::AWSMiddleware.new(app: lambda do |params|
       expect(params['aws_client']['s3_client']).to be_kind_of(AWS::S3)
     end)
-    middleware.call('aws_client' => {
-      'secret_access_key' => 'something',
-      'access_key_id' => 'something'
-    })
+    middleware.call('aws_client' => { 'secret_access_key' => 'something', 'access_key_id' => 'something' })
   end
 end

data/spec/unit/bricks/middleware/bench_middleware_spec.rb

@@ -1,6 +1,6 @@
 # encoding: UTF-8
 #
-# Copyright (c) 2010-2015 GoodData Corporation. All rights reserved.
+# Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
 # This source code is licensed under the BSD-style license found in the
 # LICENSE file in the root directory of this source tree.
 
@@ -10,6 +10,6 @@ require 'gooddata/bricks/middleware/bench_middleware'
 
 describe GoodData::Bricks::BenchMiddleware do
   it "Has GoodData::Bricks::BenchMiddleware class" do
-    GoodData::Bricks::BenchMiddleware.should_not == nil
+    GoodData::Bricks::BenchMiddleware.should_not be(nil)
   end
 end

data/spec/unit/bricks/middleware/bulk_salesforce_middleware_spec.rb

@@ -1,6 +1,6 @@
 # encoding: UTF-8
 #
-# Copyright (c) 2010-2015 GoodData Corporation. All rights reserved.
+# Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
 # This source code is licensed under the BSD-style license found in the
 # LICENSE file in the root directory of this source tree.
 
@@ -10,6 +10,6 @@ require 'gooddata/bricks/middleware/bulk_salesforce_middleware'
 
 describe GoodData::Bricks::BulkSalesforceMiddleware do
   it "Has GoodData::Bricks::BulkSalesforceMiddleware class" do
-    GoodData::Bricks::BulkSalesforceMiddleware.should_not == nil
+    GoodData::Bricks::BulkSalesforceMiddleware.should_not be(nil)
   end
 end

data/spec/unit/bricks/middleware/gooddata_middleware_spec.rb

@@ -1,6 +1,6 @@
 # encoding: UTF-8
 #
-# Copyright (c) 2010-2015 GoodData Corporation. All rights reserved.
+# Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
 # This source code is licensed under the BSD-style license found in the
 # LICENSE file in the root directory of this source tree.
 
@@ -10,6 +10,6 @@ require 'gooddata/bricks/middleware/gooddata_middleware'
 
 describe GoodData::Bricks::GoodDataMiddleware do
   it "Has GoodData::Bricks::GoodDataMiddleware class" do
-    GoodData::Bricks::GoodDataMiddleware.should_not == nil
+    GoodData::Bricks::GoodDataMiddleware.should_not be(nil)
   end
 end

data/spec/unit/bricks/middleware/logger_middleware_spec.rb

@@ -1,6 +1,6 @@
 # encoding: UTF-8
 #
-# Copyright (c) 2010-2015 GoodData Corporation. All rights reserved.
+# Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
 # This source code is licensed under the BSD-style license found in the
 # LICENSE file in the root directory of this source tree.
 
@@ -10,6 +10,6 @@ require 'gooddata/bricks/middleware/logger_middleware'
 
 describe GoodData::Bricks::LoggerMiddleware do
   it "Has GoodData::Bricks::LoggerMiddleware class" do
-    GoodData::Bricks::LoggerMiddleware.should_not == nil
+    GoodData::Bricks::LoggerMiddleware.should_not be(nil)
   end
 end