gocardless_pro 1.0.3 → 1.0.4

data/spec/services/creditors_service_spec.rb

@@ -3,393 +3,350 @@ require 'spec_helper'
 describe GoCardlessPro::Services::CreditorsService do
   let(:client) do
     GoCardlessPro::Client.new(
-      access_token: "SECRET_TOKEN"
+      access_token: 'SECRET_TOKEN'
     )
   end
 
-  
-  
-  
-    
-
-    
-    describe "#create" do
+  describe '#create' do
     subject(:post_create_response) { client.creditors.create(params: new_resource) }
-      context "with a valid request" do
-        let(:new_resource) do
-          {
-          
-          "address_line1" => "address_line1-input",
-          "address_line2" => "address_line2-input",
-          "address_line3" => "address_line3-input",
-          "city" => "city-input",
-          "country_code" => "country_code-input",
-          "created_at" => "created_at-input",
-          "id" => "id-input",
-          "links" => "links-input",
-          "name" => "name-input",
-          "postal_code" => "postal_code-input",
-          "region" => "region-input",
-          }
-        end
+    context 'with a valid request' do
+      let(:new_resource) do
+        {
+
+          'address_line1' => 'address_line1-input',
+          'address_line2' => 'address_line2-input',
+          'address_line3' => 'address_line3-input',
+          'city' => 'city-input',
+          'country_code' => 'country_code-input',
+          'created_at' => 'created_at-input',
+          'id' => 'id-input',
+          'links' => 'links-input',
+          'name' => 'name-input',
+          'postal_code' => 'postal_code-input',
+          'region' => 'region-input'
+        }
+      end
 
-        before do
-          stub_request(:post, %r(.*api.gocardless.com/creditors)).
-          with(
+      before do
+        stub_request(:post, %r{.*api.gocardless.com/creditors})
+          .with(
             body: {
-              "creditors" => {
-                
-                "address_line1" => "address_line1-input",
-                "address_line2" => "address_line2-input",
-                "address_line3" => "address_line3-input",
-                "city" => "city-input",
-                "country_code" => "country_code-input",
-                "created_at" => "created_at-input",
-                "id" => "id-input",
-                "links" => "links-input",
-                "name" => "name-input",
-                "postal_code" => "postal_code-input",
-                "region" => "region-input",
-                }
+              'creditors' => {
+
+                'address_line1' => 'address_line1-input',
+                'address_line2' => 'address_line2-input',
+                'address_line3' => 'address_line3-input',
+                'city' => 'city-input',
+                'country_code' => 'country_code-input',
+                'created_at' => 'created_at-input',
+                'id' => 'id-input',
+                'links' => 'links-input',
+                'name' => 'name-input',
+                'postal_code' => 'postal_code-input',
+                'region' => 'region-input'
+              }
             }
-          ).
-          to_return(
+          )
+          .to_return(
             body: {
-              "creditors" => {
-                
-                "address_line1" => "address_line1-input",
-                "address_line2" => "address_line2-input",
-                "address_line3" => "address_line3-input",
-                "city" => "city-input",
-                "country_code" => "country_code-input",
-                "created_at" => "created_at-input",
-                "id" => "id-input",
-                "links" => "links-input",
-                "name" => "name-input",
-                "postal_code" => "postal_code-input",
-                "region" => "region-input",
+              'creditors' =>
+
+                {
+
+                  'address_line1' => 'address_line1-input',
+                  'address_line2' => 'address_line2-input',
+                  'address_line3' => 'address_line3-input',
+                  'city' => 'city-input',
+                  'country_code' => 'country_code-input',
+                  'created_at' => 'created_at-input',
+                  'id' => 'id-input',
+                  'links' => 'links-input',
+                  'name' => 'name-input',
+                  'postal_code' => 'postal_code-input',
+                  'region' => 'region-input'
                 }
-            }.to_json,
-            :headers => {'Content-Type' => 'application/json'}
-          )
-        end
-
-        it "creates and returns the resource" do
-          expect(post_create_response).to be_a(GoCardlessPro::Resources::Creditor)
-        end
-      end
-
-      context "with a request that returns a validation error" do
-        let(:new_resource) { {} }
 
-        before do
-          stub_request(:post, %r(.*api.gocardless.com/creditors)).to_return(
-            body: {
-              error: {
-                type: 'validation_failed',
-                code: 422,
-                errors: [
-                  { message: 'test error message', field: 'test_field' }
-                ]
-              }
             }.to_json,
-            headers: {'Content-Type' => 'application/json'},
-            status: 422
+            headers: { 'Content-Type' => 'application/json' }
           )
-        end
-
-        it "throws the correct error" do
-          expect { post_create_response }.to raise_error(GoCardlessPro::ValidationError)
-        end
       end
-    end
-    
-  
-    
 
-    
-    describe "#list" do
-      describe "with no filters" do
-        subject(:get_list_response) { client.creditors.list }
-
-        before do
-          stub_request(:get, %r(.*api.gocardless.com/creditors)).to_return(
-            body: {
-              "creditors" => [{
-                
-                "address_line1" => "address_line1-input",
-                "address_line2" => "address_line2-input",
-                "address_line3" => "address_line3-input",
-                "city" => "city-input",
-                "country_code" => "country_code-input",
-                "created_at" => "created_at-input",
-                "id" => "id-input",
-                "links" => "links-input",
-                "name" => "name-input",
-                "postal_code" => "postal_code-input",
-                "region" => "region-input",
-                }],
-                meta: {
-                  cursors: {
-                    before: nil,
-                    after: "ABC123"
-                  }
-                }
-            }.to_json,
-            :headers => {'Content-Type' => 'application/json'}
-          )
-        end
-
-        it "wraps each item in the resource class" do
-          expect(get_list_response.records.map { |x| x.class }.uniq.first).to eq(GoCardlessPro::Resources::Creditor)
-
-          
-          
-          expect(get_list_response.records.first.address_line1).to eq("address_line1-input")
-          
-          
-          
-          expect(get_list_response.records.first.address_line2).to eq("address_line2-input")
-          
-          
-          
-          expect(get_list_response.records.first.address_line3).to eq("address_line3-input")
-          
-          
-          
-          expect(get_list_response.records.first.city).to eq("city-input")
-          
-          
-          
-          expect(get_list_response.records.first.country_code).to eq("country_code-input")
-          
-          
-          
-          expect(get_list_response.records.first.created_at).to eq("created_at-input")
-          
-          
-          
-          expect(get_list_response.records.first.id).to eq("id-input")
-          
-          
-          
-          
-          
-          expect(get_list_response.records.first.name).to eq("name-input")
-          
-          
-          
-          expect(get_list_response.records.first.postal_code).to eq("postal_code-input")
-          
-          
-          
-          expect(get_list_response.records.first.region).to eq("region-input")
-          
-          
-        end
-
-        it "exposes the cursors for before and after" do
-          expect(get_list_response.before).to eq(nil)
-          expect(get_list_response.after).to eq("ABC123")
-        end
-
-        specify { expect(get_list_response.api_response.headers).to eql('content-type' => 'application/json') }
+      it 'creates and returns the resource' do
+        expect(post_create_response).to be_a(GoCardlessPro::Resources::Creditor)
       end
     end
 
-    describe "#all" do
-      let!(:first_response_stub) do
-        stub_request(:get, %r(.*api.gocardless.com/creditors$)).to_return(
+    context 'with a request that returns a validation error' do
+      let(:new_resource) { {} }
+
+      before do
+        stub_request(:post, %r{.*api.gocardless.com/creditors}).to_return(
           body: {
-            "creditors" => [{
-              
-              "address_line1" => "address_line1-input",
-              "address_line2" => "address_line2-input",
-              "address_line3" => "address_line3-input",
-              "city" => "city-input",
-              "country_code" => "country_code-input",
-              "created_at" => "created_at-input",
-              "id" => "id-input",
-              "links" => "links-input",
-              "name" => "name-input",
-              "postal_code" => "postal_code-input",
-              "region" => "region-input",
-            }],
-            meta: {
-              cursors: { after: 'AB345' },
-              limit: 1
+            error: {
+              type: 'validation_failed',
+              code: 422,
+              errors: [
+                { message: 'test error message', field: 'test_field' }
+              ]
             }
           }.to_json,
-          :headers => {'Content-Type' => 'application/json'}
+          headers: { 'Content-Type' => 'application/json' },
+          status: 422
         )
       end
 
-      let!(:second_response_stub) do
-        stub_request(:get, %r(.*api.gocardless.com/creditors\?after=AB345)).to_return(
+      it 'throws the correct error' do
+        expect { post_create_response }.to raise_error(GoCardlessPro::ValidationError)
+      end
+    end
+  end
+
+  describe '#list' do
+    describe 'with no filters' do
+      subject(:get_list_response) { client.creditors.list }
+
+      before do
+        stub_request(:get, %r{.*api.gocardless.com/creditors}).to_return(
           body: {
-            "creditors" => [{
-              
-              "address_line1" => "address_line1-input",
-              "address_line2" => "address_line2-input",
-              "address_line3" => "address_line3-input",
-              "city" => "city-input",
-              "country_code" => "country_code-input",
-              "created_at" => "created_at-input",
-              "id" => "id-input",
-              "links" => "links-input",
-              "name" => "name-input",
-              "postal_code" => "postal_code-input",
-              "region" => "region-input",
+            'creditors' => [{
+
+              'address_line1' => 'address_line1-input',
+              'address_line2' => 'address_line2-input',
+              'address_line3' => 'address_line3-input',
+              'city' => 'city-input',
+              'country_code' => 'country_code-input',
+              'created_at' => 'created_at-input',
+              'id' => 'id-input',
+              'links' => 'links-input',
+              'name' => 'name-input',
+              'postal_code' => 'postal_code-input',
+              'region' => 'region-input'
             }],
             meta: {
-              limit: 2,
-              cursors: {}
+              cursors: {
+                before: nil,
+                after: 'ABC123'
+              }
             }
           }.to_json,
-          :headers => {'Content-Type' => 'application/json'}
+          headers: { 'Content-Type' => 'application/json' }
         )
       end
 
-      it "automatically makes the extra requests" do
-        expect(client.creditors.all.to_a.length).to eq(2)
-        expect(first_response_stub).to have_been_requested
-        expect(second_response_stub).to have_been_requested
+      it 'wraps each item in the resource class' do
+        expect(get_list_response.records.map(&:class).uniq.first).to eq(GoCardlessPro::Resources::Creditor)
+
+        expect(get_list_response.records.first.address_line1).to eq('address_line1-input')
+
+        expect(get_list_response.records.first.address_line2).to eq('address_line2-input')
+
+        expect(get_list_response.records.first.address_line3).to eq('address_line3-input')
+
+        expect(get_list_response.records.first.city).to eq('city-input')
+
+        expect(get_list_response.records.first.country_code).to eq('country_code-input')
+
+        expect(get_list_response.records.first.created_at).to eq('created_at-input')
+
+        expect(get_list_response.records.first.id).to eq('id-input')
+
+        expect(get_list_response.records.first.name).to eq('name-input')
+
+        expect(get_list_response.records.first.postal_code).to eq('postal_code-input')
+
+        expect(get_list_response.records.first.region).to eq('region-input')
+      end
+
+      it 'exposes the cursors for before and after' do
+        expect(get_list_response.before).to eq(nil)
+        expect(get_list_response.after).to eq('ABC123')
       end
+
+      specify { expect(get_list_response.api_response.headers).to eql('content-type' => 'application/json') }
+    end
+  end
+
+  describe '#all' do
+    let!(:first_response_stub) do
+      stub_request(:get, %r{.*api.gocardless.com/creditors$}).to_return(
+        body: {
+          'creditors' => [{
+
+            'address_line1' => 'address_line1-input',
+            'address_line2' => 'address_line2-input',
+            'address_line3' => 'address_line3-input',
+            'city' => 'city-input',
+            'country_code' => 'country_code-input',
+            'created_at' => 'created_at-input',
+            'id' => 'id-input',
+            'links' => 'links-input',
+            'name' => 'name-input',
+            'postal_code' => 'postal_code-input',
+            'region' => 'region-input'
+          }],
+          meta: {
+            cursors: { after: 'AB345' },
+            limit: 1
+          }
+        }.to_json,
+        headers: { 'Content-Type' => 'application/json' }
+      )
     end
 
-    
-  
-    
+    let!(:second_response_stub) do
+      stub_request(:get, %r{.*api.gocardless.com/creditors\?after=AB345}).to_return(
+        body: {
+          'creditors' => [{
+
+            'address_line1' => 'address_line1-input',
+            'address_line2' => 'address_line2-input',
+            'address_line3' => 'address_line3-input',
+            'city' => 'city-input',
+            'country_code' => 'country_code-input',
+            'created_at' => 'created_at-input',
+            'id' => 'id-input',
+            'links' => 'links-input',
+            'name' => 'name-input',
+            'postal_code' => 'postal_code-input',
+            'region' => 'region-input'
+          }],
+          meta: {
+            limit: 2,
+            cursors: {}
+          }
+        }.to_json,
+        headers: { 'Content-Type' => 'application/json' }
+      )
+    end
+
+    it 'automatically makes the extra requests' do
+      expect(client.creditors.all.to_a.length).to eq(2)
+      expect(first_response_stub).to have_been_requested
+      expect(second_response_stub).to have_been_requested
+    end
+  end
 
-    
-    describe "#get" do
-      let(:id) { "ID123" }
+  describe '#get' do
+    let(:id) { 'ID123' }
 
-      subject(:get_response) { client.creditors.get(id) }
+    subject(:get_response) { client.creditors.get(id) }
 
-      context "passing in a custom header" do
-        let!(:stub) do
-          stub_url = "/creditors/:identity".gsub(':identity', id)
-          stub_request(:get, %r(.*api.gocardless.com#{stub_url})).
-          with(headers: { 'Foo' => 'Bar' }).
-          to_return(
+    context 'passing in a custom header' do
+      let!(:stub) do
+        stub_url = '/creditors/:identity'.gsub(':identity', id)
+        stub_request(:get, /.*api.gocardless.com#{stub_url}/)
+          .with(headers: { 'Foo' => 'Bar' })
+          .to_return(
             body: {
-              "creditors" => {
-                
-                "address_line1" => "address_line1-input",
-                "address_line2" => "address_line2-input",
-                "address_line3" => "address_line3-input",
-                "city" => "city-input",
-                "country_code" => "country_code-input",
-                "created_at" => "created_at-input",
-                "id" => "id-input",
-                "links" => "links-input",
-                "name" => "name-input",
-                "postal_code" => "postal_code-input",
-                "region" => "region-input",
+              'creditors' => {
+
+                'address_line1' => 'address_line1-input',
+                'address_line2' => 'address_line2-input',
+                'address_line3' => 'address_line3-input',
+                'city' => 'city-input',
+                'country_code' => 'country_code-input',
+                'created_at' => 'created_at-input',
+                'id' => 'id-input',
+                'links' => 'links-input',
+                'name' => 'name-input',
+                'postal_code' => 'postal_code-input',
+                'region' => 'region-input'
               }
             }.to_json,
-            :headers => {'Content-Type' => 'application/json'}
+            headers: { 'Content-Type' => 'application/json' }
           )
-        end
-
-        subject(:get_response) do
-          client.creditors.get(id, headers: {
-            'Foo' => 'Bar'
-          })
-        end
-
-        it "includes the header" do
-          get_response
-          expect(stub).to have_been_requested
-        end
       end
 
-      context "when there is a creditor to return" do
-        before do
-          stub_url = "/creditors/:identity".gsub(':identity', id)
-          stub_request(:get, %r(.*api.gocardless.com#{stub_url})).to_return(
-            body: {
-              "creditors" => {
-                
-                "address_line1" => "address_line1-input",
-                "address_line2" => "address_line2-input",
-                "address_line3" => "address_line3-input",
-                "city" => "city-input",
-                "country_code" => "country_code-input",
-                "created_at" => "created_at-input",
-                "id" => "id-input",
-                "links" => "links-input",
-                "name" => "name-input",
-                "postal_code" => "postal_code-input",
-                "region" => "region-input",
-              }
-            }.to_json,
-            :headers => {'Content-Type' => 'application/json'}
-          )
-        end
+      subject(:get_response) do
+        client.creditors.get(id, headers: {
+                               'Foo' => 'Bar'
+                             })
+      end
 
-        it "wraps the response in a resource" do
-          expect(get_response).to be_a(GoCardlessPro::Resources::Creditor)
-        end
+      it 'includes the header' do
+        get_response
+        expect(stub).to have_been_requested
       end
+    end
 
-      context "when nothing is returned" do
-        before do
-          stub_url = "/creditors/:identity".gsub(':identity', id)
-          stub_request(:get, %r(.*api.gocardless.com#{stub_url})).to_return(
-            body: "",
-            headers: { 'Content-Type' => 'application/json' }
-          )
-        end
+    context 'when there is a creditor to return' do
+      before do
+        stub_url = '/creditors/:identity'.gsub(':identity', id)
+        stub_request(:get, /.*api.gocardless.com#{stub_url}/).to_return(
+          body: {
+            'creditors' => {
+
+              'address_line1' => 'address_line1-input',
+              'address_line2' => 'address_line2-input',
+              'address_line3' => 'address_line3-input',
+              'city' => 'city-input',
+              'country_code' => 'country_code-input',
+              'created_at' => 'created_at-input',
+              'id' => 'id-input',
+              'links' => 'links-input',
+              'name' => 'name-input',
+              'postal_code' => 'postal_code-input',
+              'region' => 'region-input'
+            }
+          }.to_json,
+          headers: { 'Content-Type' => 'application/json' }
+        )
+      end
 
-        it "returns nil" do
-          expect(get_response).to be_nil
-        end
+      it 'wraps the response in a resource' do
+        expect(get_response).to be_a(GoCardlessPro::Resources::Creditor)
       end
     end
 
-    
-  
-    
+    context 'when nothing is returned' do
+      before do
+        stub_url = '/creditors/:identity'.gsub(':identity', id)
+        stub_request(:get, /.*api.gocardless.com#{stub_url}/).to_return(
+          body: '',
+          headers: { 'Content-Type' => 'application/json' }
+        )
+      end
 
-    
-    describe "#update" do
-      subject(:put_update_response) { client.creditors.update(id, params: update_params) }
-      let(:id) { "ABC123" }
+      it 'returns nil' do
+        expect(get_response).to be_nil
+      end
+    end
+  end
 
-      context "with a valid request" do
-        let(:update_params) { { "hello" => "world" } }
+  describe '#update' do
+    subject(:put_update_response) { client.creditors.update(id, params: update_params) }
+    let(:id) { 'ABC123' }
 
-        let!(:stub) do
-          stub_url = "/creditors/:identity".gsub(':identity', id)
-          stub_request(:put, %r(.*api.gocardless.com#{stub_url})).to_return(
-            body: {
-              "creditors" => {
-                
-                "address_line1" => "address_line1-input",
-                "address_line2" => "address_line2-input",
-                "address_line3" => "address_line3-input",
-                "city" => "city-input",
-                "country_code" => "country_code-input",
-                "created_at" => "created_at-input",
-                "id" => "id-input",
-                "links" => "links-input",
-                "name" => "name-input",
-                "postal_code" => "postal_code-input",
-                "region" => "region-input",
-              }
-            }.to_json,
-            :headers => {'Content-Type' => 'application/json'}
-          )
-        end
+    context 'with a valid request' do
+      let(:update_params) { { 'hello' => 'world' } }
+
+      let!(:stub) do
+        stub_url = '/creditors/:identity'.gsub(':identity', id)
+        stub_request(:put, /.*api.gocardless.com#{stub_url}/).to_return(
+          body: {
+            'creditors' => {
+
+              'address_line1' => 'address_line1-input',
+              'address_line2' => 'address_line2-input',
+              'address_line3' => 'address_line3-input',
+              'city' => 'city-input',
+              'country_code' => 'country_code-input',
+              'created_at' => 'created_at-input',
+              'id' => 'id-input',
+              'links' => 'links-input',
+              'name' => 'name-input',
+              'postal_code' => 'postal_code-input',
+              'region' => 'region-input'
+            }
+          }.to_json,
+          headers: { 'Content-Type' => 'application/json' }
+        )
+      end
 
-        it "updates and returns the resource" do
-          expect(put_update_response).to be_a(GoCardlessPro::Resources::Creditor)
-          expect(stub).to have_been_requested
-        end
+      it 'updates and returns the resource' do
+        expect(put_update_response).to be_a(GoCardlessPro::Resources::Creditor)
+        expect(stub).to have_been_requested
       end
     end
-    
-  
+  end
 end