gocardless_pro 1.0.3 → 1.0.4

data/lib/gocardless_pro/services/customer_bank_accounts_service.rb

@@ -37,6 +37,7 @@ module GoCardlessPro
         response = make_request(:post, path, options)
 
         return if response.body.nil?
+
         Resources::CustomerBankAccount.new(unenvelope_body(response.body), response)
       end
 
@@ -74,11 +75,12 @@ module GoCardlessPro
       # @param identity       # Unique identifier, beginning with "BA".
       # @param options [Hash] parameters as a hash, under a params key.
       def get(identity, options = {})
-        path = sub_url('/customer_bank_accounts/:identity',           'identity' => identity)
+        path = sub_url('/customer_bank_accounts/:identity', 'identity' => identity)
 
         response = make_request(:get, path, options)
 
         return if response.body.nil?
+
         Resources::CustomerBankAccount.new(unenvelope_body(response.body), response)
       end
 
@@ -89,7 +91,7 @@ module GoCardlessPro
       # @param identity       # Unique identifier, beginning with "BA".
       # @param options [Hash] parameters as a hash, under a params key.
       def update(identity, options = {})
-        path = sub_url('/customer_bank_accounts/:identity',           'identity' => identity)
+        path = sub_url('/customer_bank_accounts/:identity', 'identity' => identity)
 
         params = options.delete(:params) || {}
         options[:params] = {}
@@ -97,6 +99,7 @@ module GoCardlessPro
         response = make_request(:put, path, options)
 
         return if response.body.nil?
+
         Resources::CustomerBankAccount.new(unenvelope_body(response.body), response)
       end
 
@@ -113,7 +116,7 @@ module GoCardlessPro
       # @param identity       # Unique identifier, beginning with "BA".
       # @param options [Hash] parameters as a hash, under a params key.
       def disable(identity, options = {})
-        path = sub_url('/customer_bank_accounts/:identity/actions/disable',           'identity' => identity)
+        path = sub_url('/customer_bank_accounts/:identity/actions/disable', 'identity' => identity)
 
         params = options.delete(:params) || {}
         options[:params] = {}
@@ -121,6 +124,7 @@ module GoCardlessPro
         response = make_request(:post, path, options)
 
         return if response.body.nil?
+
         Resources::CustomerBankAccount.new(unenvelope_body(response.body), response)
       end
 

data/lib/gocardless_pro/services/customers_service.rb

@@ -22,6 +22,7 @@ module GoCardlessPro
         response = make_request(:post, path, options)
 
         return if response.body.nil?
+
         Resources::Customer.new(unenvelope_body(response.body), response)
       end
 
@@ -59,11 +60,12 @@ module GoCardlessPro
       # @param identity       # Unique identifier, beginning with "CU".
       # @param options [Hash] parameters as a hash, under a params key.
       def get(identity, options = {})
-        path = sub_url('/customers/:identity',           'identity' => identity)
+        path = sub_url('/customers/:identity', 'identity' => identity)
 
         response = make_request(:get, path, options)
 
         return if response.body.nil?
+
         Resources::Customer.new(unenvelope_body(response.body), response)
       end
 
@@ -74,7 +76,7 @@ module GoCardlessPro
       # @param identity       # Unique identifier, beginning with "CU".
       # @param options [Hash] parameters as a hash, under a params key.
       def update(identity, options = {})
-        path = sub_url('/customers/:identity',           'identity' => identity)
+        path = sub_url('/customers/:identity', 'identity' => identity)
 
         params = options.delete(:params) || {}
         options[:params] = {}
@@ -82,6 +84,7 @@ module GoCardlessPro
         response = make_request(:put, path, options)
 
         return if response.body.nil?
+
         Resources::Customer.new(unenvelope_body(response.body), response)
       end
 

data/lib/gocardless_pro/services/events_service.rb

@@ -43,11 +43,12 @@ module GoCardlessPro
       # @param identity       # Unique identifier, beginning with "EV".
       # @param options [Hash] parameters as a hash, under a params key.
       def get(identity, options = {})
-        path = sub_url('/events/:identity',           'identity' => identity)
+        path = sub_url('/events/:identity', 'identity' => identity)
 
         response = make_request(:get, path, options)
 
         return if response.body.nil?
+
         Resources::Event.new(unenvelope_body(response.body), response)
       end
 

data/lib/gocardless_pro/services/mandate_pdfs_service.rb

@@ -21,7 +21,7 @@ module GoCardlessPro
       # header to the relevant [ISO
       # 639-1](http://en.wikipedia.org/wiki/List_of_ISO_639-1_codes#Partial_ISO_639_table)
       # language code. Supported languages are Dutch, English, French, German,
-      # Italian, Portuguese and Spanish.
+      # Italian, Portuguese, Spanish and Swedish.
       # Example URL: /mandate_pdfs
       # @param options [Hash] parameters as a hash, under a params key.
       def create(options = {})
@@ -33,6 +33,7 @@ module GoCardlessPro
         response = make_request(:post, path, options)
 
         return if response.body.nil?
+
         Resources::MandatePdf.new(unenvelope_body(response.body), response)
       end
 

data/lib/gocardless_pro/services/mandates_service.rb

@@ -22,11 +22,12 @@ module GoCardlessPro
         response = make_request(:post, path, options)
 
         return if response.body.nil?
+
         Resources::Mandate.new(unenvelope_body(response.body), response)
       end
 
       # Returns a [cursor-paginated](#overview-cursor-pagination) list of your
-      # mandates. Except where stated, these filters can only be used one at a time.
+      # mandates.
       # Example URL: /mandates
       # @param options [Hash] parameters as a hash, under a params key.
       def list(options = {})
@@ -59,11 +60,12 @@ module GoCardlessPro
       # @param identity       # Unique identifier, beginning with "MD".
       # @param options [Hash] parameters as a hash, under a params key.
       def get(identity, options = {})
-        path = sub_url('/mandates/:identity',           'identity' => identity)
+        path = sub_url('/mandates/:identity', 'identity' => identity)
 
         response = make_request(:get, path, options)
 
         return if response.body.nil?
+
         Resources::Mandate.new(unenvelope_body(response.body), response)
       end
 
@@ -73,7 +75,7 @@ module GoCardlessPro
       # @param identity       # Unique identifier, beginning with "MD".
       # @param options [Hash] parameters as a hash, under a params key.
       def update(identity, options = {})
-        path = sub_url('/mandates/:identity',           'identity' => identity)
+        path = sub_url('/mandates/:identity', 'identity' => identity)
 
         params = options.delete(:params) || {}
         options[:params] = {}
@@ -81,6 +83,7 @@ module GoCardlessPro
         response = make_request(:put, path, options)
 
         return if response.body.nil?
+
         Resources::Mandate.new(unenvelope_body(response.body), response)
       end
 
@@ -95,7 +98,7 @@ module GoCardlessPro
       # @param identity       # Unique identifier, beginning with "MD".
       # @param options [Hash] parameters as a hash, under a params key.
       def cancel(identity, options = {})
-        path = sub_url('/mandates/:identity/actions/cancel',           'identity' => identity)
+        path = sub_url('/mandates/:identity/actions/cancel', 'identity' => identity)
 
         params = options.delete(:params) || {}
         options[:params] = {}
@@ -103,6 +106,7 @@ module GoCardlessPro
         response = make_request(:post, path, options)
 
         return if response.body.nil?
+
         Resources::Mandate.new(unenvelope_body(response.body), response)
       end
 
@@ -123,7 +127,7 @@ module GoCardlessPro
       # @param identity       # Unique identifier, beginning with "MD".
       # @param options [Hash] parameters as a hash, under a params key.
       def reinstate(identity, options = {})
-        path = sub_url('/mandates/:identity/actions/reinstate',           'identity' => identity)
+        path = sub_url('/mandates/:identity/actions/reinstate', 'identity' => identity)
 
         params = options.delete(:params) || {}
         options[:params] = {}
@@ -131,6 +135,7 @@ module GoCardlessPro
         response = make_request(:post, path, options)
 
         return if response.body.nil?
+
         Resources::Mandate.new(unenvelope_body(response.body), response)
       end
 

data/lib/gocardless_pro/services/payments_service.rb

@@ -15,8 +15,8 @@ module GoCardlessPro
       # This
       # fails with a `mandate_is_inactive` error if the linked
       # [mandate](#core-endpoints-mandates) is cancelled or has failed. Payments can
-      # be created against `pending_submission` and `submitted` as well as `active`
-      # mandates.
+      # be created against mandates with status of: `pending_customer_approval`,
+      # `pending_submission`, `submitted`, and `active`.
       # Example URL: /payments
       # @param options [Hash] parameters as a hash, under a params key.
       def create(options = {})
@@ -28,6 +28,7 @@ module GoCardlessPro
         response = make_request(:post, path, options)
 
         return if response.body.nil?
+
         Resources::Payment.new(unenvelope_body(response.body), response)
       end
 
@@ -65,11 +66,12 @@ module GoCardlessPro
       # @param identity       # Unique identifier, beginning with "PM".
       # @param options [Hash] parameters as a hash, under a params key.
       def get(identity, options = {})
-        path = sub_url('/payments/:identity',           'identity' => identity)
+        path = sub_url('/payments/:identity', 'identity' => identity)
 
         response = make_request(:get, path, options)
 
         return if response.body.nil?
+
         Resources::Payment.new(unenvelope_body(response.body), response)
       end
 
@@ -79,7 +81,7 @@ module GoCardlessPro
       # @param identity       # Unique identifier, beginning with "PM".
       # @param options [Hash] parameters as a hash, under a params key.
       def update(identity, options = {})
-        path = sub_url('/payments/:identity',           'identity' => identity)
+        path = sub_url('/payments/:identity', 'identity' => identity)
 
         params = options.delete(:params) || {}
         options[:params] = {}
@@ -87,6 +89,7 @@ module GoCardlessPro
         response = make_request(:put, path, options)
 
         return if response.body.nil?
+
         Resources::Payment.new(unenvelope_body(response.body), response)
       end
 
@@ -101,7 +104,7 @@ module GoCardlessPro
       # @param identity       # Unique identifier, beginning with "PM".
       # @param options [Hash] parameters as a hash, under a params key.
       def cancel(identity, options = {})
-        path = sub_url('/payments/:identity/actions/cancel',           'identity' => identity)
+        path = sub_url('/payments/:identity/actions/cancel', 'identity' => identity)
 
         params = options.delete(:params) || {}
         options[:params] = {}
@@ -109,6 +112,7 @@ module GoCardlessPro
         response = make_request(:post, path, options)
 
         return if response.body.nil?
+
         Resources::Payment.new(unenvelope_body(response.body), response)
       end
 
@@ -129,7 +133,7 @@ module GoCardlessPro
       # @param identity       # Unique identifier, beginning with "PM".
       # @param options [Hash] parameters as a hash, under a params key.
       def retry(identity, options = {})
-        path = sub_url('/payments/:identity/actions/retry',           'identity' => identity)
+        path = sub_url('/payments/:identity/actions/retry', 'identity' => identity)
 
         params = options.delete(:params) || {}
         options[:params] = {}
@@ -137,6 +141,7 @@ module GoCardlessPro
         response = make_request(:post, path, options)
 
         return if response.body.nil?
+
         Resources::Payment.new(unenvelope_body(response.body), response)
       end
 

data/lib/gocardless_pro/services/payouts_service.rb

@@ -46,11 +46,12 @@ module GoCardlessPro
       # @param identity       # Unique identifier, beginning with "PO".
       # @param options [Hash] parameters as a hash, under a params key.
       def get(identity, options = {})
-        path = sub_url('/payouts/:identity',           'identity' => identity)
+        path = sub_url('/payouts/:identity', 'identity' => identity)
 
         response = make_request(:get, path, options)
 
         return if response.body.nil?
+
         Resources::Payout.new(unenvelope_body(response.body), response)
       end
 

data/lib/gocardless_pro/services/redirect_flows_service.rb

@@ -11,7 +11,7 @@ module GoCardlessPro
     # Service for making requests to the RedirectFlow endpoints
     class RedirectFlowsService < BaseService
       # Creates a redirect flow object which can then be used to redirect your
-      # customer to the GoCardless Pro hosted payment pages.
+      # customer to the GoCardless hosted payment pages.
       # Example URL: /redirect_flows
       # @param options [Hash] parameters as a hash, under a params key.
       def create(options = {})
@@ -23,6 +23,7 @@ module GoCardlessPro
         response = make_request(:post, path, options)
 
         return if response.body.nil?
+
         Resources::RedirectFlow.new(unenvelope_body(response.body), response)
       end
 
@@ -32,11 +33,12 @@ module GoCardlessPro
       # @param identity       # Unique identifier, beginning with "RE".
       # @param options [Hash] parameters as a hash, under a params key.
       def get(identity, options = {})
-        path = sub_url('/redirect_flows/:identity',           'identity' => identity)
+        path = sub_url('/redirect_flows/:identity', 'identity' => identity)
 
         response = make_request(:get, path, options)
 
         return if response.body.nil?
+
         Resources::RedirectFlow.new(unenvelope_body(response.body), response)
       end
 
@@ -56,7 +58,7 @@ module GoCardlessPro
       # @param identity       # Unique identifier, beginning with "RE".
       # @param options [Hash] parameters as a hash, under a params key.
       def complete(identity, options = {})
-        path = sub_url('/redirect_flows/:identity/actions/complete',           'identity' => identity)
+        path = sub_url('/redirect_flows/:identity/actions/complete', 'identity' => identity)
 
         params = options.delete(:params) || {}
         options[:params] = {}
@@ -64,6 +66,7 @@ module GoCardlessPro
         response = make_request(:post, path, options)
 
         return if response.body.nil?
+
         Resources::RedirectFlow.new(unenvelope_body(response.body), response)
       end
 

data/lib/gocardless_pro/services/refunds_service.rb

@@ -40,6 +40,7 @@ module GoCardlessPro
         response = make_request(:post, path, options)
 
         return if response.body.nil?
+
         Resources::Refund.new(unenvelope_body(response.body), response)
       end
 
@@ -77,11 +78,12 @@ module GoCardlessPro
       # @param identity       # Unique identifier, beginning with "RF".
       # @param options [Hash] parameters as a hash, under a params key.
       def get(identity, options = {})
-        path = sub_url('/refunds/:identity',           'identity' => identity)
+        path = sub_url('/refunds/:identity', 'identity' => identity)
 
         response = make_request(:get, path, options)
 
         return if response.body.nil?
+
         Resources::Refund.new(unenvelope_body(response.body), response)
       end
 
@@ -91,7 +93,7 @@ module GoCardlessPro
       # @param identity       # Unique identifier, beginning with "RF".
       # @param options [Hash] parameters as a hash, under a params key.
       def update(identity, options = {})
-        path = sub_url('/refunds/:identity',           'identity' => identity)
+        path = sub_url('/refunds/:identity', 'identity' => identity)
 
         params = options.delete(:params) || {}
         options[:params] = {}
@@ -99,6 +101,7 @@ module GoCardlessPro
         response = make_request(:put, path, options)
 
         return if response.body.nil?
+
         Resources::Refund.new(unenvelope_body(response.body), response)
       end
 

data/lib/gocardless_pro/services/subscriptions_service.rb

@@ -22,6 +22,7 @@ module GoCardlessPro
         response = make_request(:post, path, options)
 
         return if response.body.nil?
+
         Resources::Subscription.new(unenvelope_body(response.body), response)
       end
 
@@ -59,11 +60,12 @@ module GoCardlessPro
       # @param identity       # Unique identifier, beginning with "SB".
       # @param options [Hash] parameters as a hash, under a params key.
       def get(identity, options = {})
-        path = sub_url('/subscriptions/:identity',           'identity' => identity)
+        path = sub_url('/subscriptions/:identity', 'identity' => identity)
 
         response = make_request(:get, path, options)
 
         return if response.body.nil?
+
         Resources::Subscription.new(unenvelope_body(response.body), response)
       end
 
@@ -73,7 +75,7 @@ module GoCardlessPro
       # @param identity       # Unique identifier, beginning with "SB".
       # @param options [Hash] parameters as a hash, under a params key.
       def update(identity, options = {})
-        path = sub_url('/subscriptions/:identity',           'identity' => identity)
+        path = sub_url('/subscriptions/:identity', 'identity' => identity)
 
         params = options.delete(:params) || {}
         options[:params] = {}
@@ -81,6 +83,7 @@ module GoCardlessPro
         response = make_request(:put, path, options)
 
         return if response.body.nil?
+
         Resources::Subscription.new(unenvelope_body(response.body), response)
       end
 
@@ -95,7 +98,7 @@ module GoCardlessPro
       # @param identity       # Unique identifier, beginning with "SB".
       # @param options [Hash] parameters as a hash, under a params key.
       def cancel(identity, options = {})
-        path = sub_url('/subscriptions/:identity/actions/cancel',           'identity' => identity)
+        path = sub_url('/subscriptions/:identity/actions/cancel', 'identity' => identity)
 
         params = options.delete(:params) || {}
         options[:params] = {}
@@ -103,6 +106,7 @@ module GoCardlessPro
         response = make_request(:post, path, options)
 
         return if response.body.nil?
+
         Resources::Subscription.new(unenvelope_body(response.body), response)
       end
 

data/lib/gocardless_pro/version.rb

@@ -4,5 +4,5 @@ end
 
 module GoCardlessPro
   # Current version of the GC gem
-  VERSION = '1.0.3'
+  VERSION = '1.0.4'
 end

data/spec/api_response_spec.rb

@@ -2,13 +2,13 @@ require 'spec_helper'
 require 'json'
 
 describe GoCardlessPro::ApiResponse do
-  describe "wrapping a Faraday response" do
+  describe 'wrapping a Faraday response' do
     let(:content_type) { 'application/json' }
 
     let(:stubbed) do
       Faraday::Adapter::Test::Stubs.new do |stub|
-        stub.get('/testing') do |env|
-          [200, { 'Content-Type' => content_type}, { test: true }.to_json]
+        stub.get('/testing') do |_env|
+          [200, { 'Content-Type' => content_type }, { test: true }.to_json]
         end
       end
     end
@@ -23,6 +23,6 @@ describe GoCardlessPro::ApiResponse do
     specify do
       expect(api_response.headers).to eql('Content-Type' => content_type)
     end
-    specify { expect(api_response.body).to eql("test" => true) }
+    specify { expect(api_response.body).to eql('test' => true) }
   end
 end