gocardless_pro 1.0.3 → 1.0.4

data/spec/api_service_spec.rb

@@ -1,72 +1,70 @@
 require 'spec_helper'
 
 describe GoCardlessPro::ApiService do
-  subject(:service) { described_class.new("https://api.example.com", "secret_token") }
+  subject(:service) { described_class.new('https://api.example.com', 'secret_token') }
 
-  it "uses basic auth" do
-    stub = stub_request(:get, 'https://api.example.com/customers').
-      with(headers: { "Authorization" => "Bearer secret_token" })
-    service.make_request(:get, "/customers")
+  it 'uses basic auth' do
+    stub = stub_request(:get, 'https://api.example.com/customers')
+           .with(headers: { 'Authorization' => 'Bearer secret_token' })
+    service.make_request(:get, '/customers')
     expect(stub).to have_been_requested
   end
 
-  describe "making a get request without any parameters" do
-    it "is expected to call the correct stub" do
+  describe 'making a get request without any parameters' do
+    it 'is expected to call the correct stub' do
       stub = stub_request(:get, /.*api.example.com\/customers/)
-      service.make_request(:get, "/customers")
+      service.make_request(:get, '/customers')
       expect(stub).to have_been_requested
     end
   end
 
-  describe "making a get request with query parameters" do
-    it "correctly passes the query parameters" do
+  describe 'making a get request with query parameters' do
+    it 'correctly passes the query parameters' do
       stub = stub_request(:get, /.*api.example.com\/customers\?a=1&b=2/)
-      service.make_request(:get, "/customers", params: { a: 1, b: 2 })
+      service.make_request(:get, '/customers', params: { a: 1, b: 2 })
       expect(stub).to have_been_requested
     end
   end
 
-  describe "making a post request with some data" do
-    it "passes the data in as the post body" do
-      stub = stub_request(:post, /.*api.example.com\/customers/).
-        with(body: { given_name: "Jack", family_name: "Franklin" })
-      service.make_request(:post, "/customers", params: {
-        given_name: "Jack",
-        family_name: "Franklin"
-      })
+  describe 'making a post request with some data' do
+    it 'passes the data in as the post body' do
+      stub = stub_request(:post, /.*api.example.com\/customers/)
+             .with(body: { given_name: 'Jack', family_name: 'Franklin' })
+      service.make_request(:post, '/customers', params: {
+                             given_name: 'Jack',
+                             family_name: 'Franklin'
+                           })
       expect(stub).to have_been_requested
     end
   end
 
-  describe "making a post request with data and custom header" do
-    it "passes the data in as the post body" do
-      stub = stub_request(:post, /.*api.example.com\/customers/).
-        with(
-          body: { given_name: "Jack", family_name: "Franklin" },
-          headers: { 'Foo' => 'Bar' }
-        )
+  describe 'making a post request with data and custom header' do
+    it 'passes the data in as the post body' do
+      stub = stub_request(:post, /.*api.example.com\/customers/)
+             .with(
+               body: { given_name: 'Jack', family_name: 'Franklin' },
+               headers: { 'Foo' => 'Bar' }
+             )
 
-      service.make_request(:post, "/customers", {
-        params: {
-          given_name: "Jack",
-          family_name: "Franklin"
-        },
-        headers: {
-          'Foo' => 'Bar'
-        }
-      })
+      service.make_request(:post, '/customers', params: {
+                             given_name: 'Jack',
+                             family_name: 'Franklin'
+                           },
+                                                headers: {
+                                                  'Foo' => 'Bar'
+                                                })
       expect(stub).to have_been_requested
     end
   end
 
-  describe "making a put request with some data" do
-    it "passes the data in as the request body" do
-      stub = stub_request(:put, /.*api.example.com\/customers\/CU123/).
-        with(body: { given_name: "Jack", family_name: "Franklin" })
-      service.make_request(:put, "/customers/CU123", params: {
-        given_name: "Jack",
-        family_name: "Franklin"
-      })
+  describe 'making a put request with some data' do
+    it 'passes the data in as the request body' do
+      stub = stub_request(:put, /.*api.example.com\/customers\/CU123/)
+             .with(body: { given_name: 'Jack', family_name: 'Franklin' })
+      service.make_request(:put, '/customers/CU123', params: {
+                             given_name: 'Jack',
+                             family_name: 'Franklin'
+                           })
       expect(stub).to have_been_requested
     end
   end

data/spec/client_spec.rb

@@ -10,10 +10,10 @@ describe GoCardlessPro::Client do
     }
   end
 
-  context "when initialised without an Access Token" do
+  context 'when initialised without an Access Token' do
     let(:environment) { :live }
     let(:token) { nil }
 
-    it { is_expected.to raise_error("No Access Token given to GoCardless Client") }
+    it { is_expected.to raise_error('No Access Token given to GoCardless Client') }
   end
 end

data/spec/error_spec.rb

@@ -5,40 +5,49 @@ describe GoCardlessPro::Error do
 
   let(:api_error) do
     {
-      "documentation_url" => "https://developer.gocardless.com/pro#validation_failed",
-      "message" => "Validation failed",
-      "type" => "validation_failed",
-      "code" => 422,
-      "request_id" => "dd50eaaf-8213-48fe-90d6-5466872efbc4",
-      "errors" => [
+      'documentation_url' => 'https://developer.gocardless.com/pro#validation_failed',
+      'message' => 'Validation failed',
+      'type' => 'validation_failed',
+      'code' => 422,
+      'request_id' => 'dd50eaaf-8213-48fe-90d6-5466872efbc4',
+      'errors' => [
         {
-          "message" => "must be a number",
-          "field" => "branch_code"
+          'message' => 'must be a number',
+          'field' => 'branch_code'
         }, {
-          "message" => "is the wrong length (should be 8 characters)",
-          "field" => "branch_code"
+          'message' => 'is the wrong length (should be 8 characters)',
+          'field' => 'branch_code'
         }
       ]
     }
   end
 
   specify do
-    expect(error.documentation_url).to eq("https://developer.gocardless.com/pro#validation_failed")
+    expect(error.documentation_url).to eq('https://developer.gocardless.com/pro#validation_failed')
   end
 
-  specify { expect(error.message).to eq("Validation failed") }
-  specify { expect(error.type).to eq("validation_failed") }
+  specify { expect(error.message).to eq('Validation failed') }
+  specify do
+    expect(error.to_s)
+      .to eq('branch_code must be a number, '\
+          'branch_code is the wrong length (should be 8 characters)')
+  end
+  specify { expect(error.type).to eq('validation_failed') }
   specify { expect(error.code).to eq(422) }
-  specify { expect(error.request_id).to eq("dd50eaaf-8213-48fe-90d6-5466872efbc4") }
+  specify { expect(error.request_id).to eq('dd50eaaf-8213-48fe-90d6-5466872efbc4') }
   specify do
     expect(error.errors).to eq([
       {
-        "message" => "must be a number",
-        "field" => "branch_code"
+        'message' => 'must be a number',
+        'field' => 'branch_code'
       }, {
-        "message" => "is the wrong length (should be 8 characters)",
-        "field" => "branch_code"
+        'message' => 'is the wrong length (should be 8 characters)',
+        'field' => 'branch_code'
       }
     ])
   end
+
+  context 'when initializing an error with a string' do
+    specify { expect { described_class.new('FOO') }.to raise_error(ArgumentError) }
+  end
 end

data/spec/resources/bank_details_lookup_spec.rb

@@ -1,51 +1,36 @@
 require 'spec_helper'
 
 describe GoCardlessPro::Resources::BankDetailsLookup do
-  describe "initialising" do
+  describe 'initialising' do
     let(:data) do
       {
-      
-        
-          "available_debit_schemes" => "available_debit_schemes-input",
-        
-      
-        
-          "bank_name" => "bank_name-input",
-        
-      
-        
-          "bic" => "bic-input",
-        
-      
+
+        'available_debit_schemes' => 'available_debit_schemes-input',
+
+        'bank_name' => 'bank_name-input',
+
+        'bic' => 'bic-input'
+
       }
     end
 
-    it "can be initialized from an unenveloped response" do
+    it 'can be initialized from an unenveloped response' do
       resource = described_class.new(data)
-      
-       
-       expect(resource.available_debit_schemes).to eq("available_debit_schemes-input")
-       
-       
-       
-       expect(resource.bank_name).to eq("bank_name-input")
-       
-       
-       
-       expect(resource.bic).to eq("bic-input")
-       
-       
+
+      expect(resource.available_debit_schemes).to eq('available_debit_schemes-input')
+
+      expect(resource.bank_name).to eq('bank_name-input')
+
+      expect(resource.bic).to eq('bic-input')
     end
 
-    it "can handle new attributes without erroring" do
-      data["foo"] = "bar"
+    it 'can handle new attributes without erroring' do
+      data['foo'] = 'bar'
       expect { described_class.new(data) }.to_not raise_error
     end
 
-    
-
-    describe "#to_h" do
-      it "returns a hash representing the resource" do
+    describe '#to_h' do
+      it 'returns a hash representing the resource' do
         expect(described_class.new(data).to_h).to eq(data)
       end
     end

data/spec/resources/creditor_bank_account_spec.rb

@@ -1,123 +1,78 @@
 require 'spec_helper'
 
 describe GoCardlessPro::Resources::CreditorBankAccount do
-  describe "initialising" do
+  describe 'initialising' do
     let(:data) do
       {
-      
-        
-          "account_holder_name" => "account_holder_name-input",
-        
-      
-        
-          "account_number_ending" => "account_number_ending-input",
-        
-      
-        
-          "bank_name" => "bank_name-input",
-        
-      
-        
-          "country_code" => "country_code-input",
-        
-      
-        
-          "created_at" => "created_at-input",
-        
-      
-        
-          "currency" => "currency-input",
-        
-      
-        
-          "enabled" => "enabled-input",
-        
-      
-        
-          "id" => "id-input",
-        
-      
-        
-        "links" => {
-          
-            "creditor" => "creditor-input",
-          
+
+        'account_holder_name' => 'account_holder_name-input',
+
+        'account_number_ending' => 'account_number_ending-input',
+
+        'bank_name' => 'bank_name-input',
+
+        'country_code' => 'country_code-input',
+
+        'created_at' => 'created_at-input',
+
+        'currency' => 'currency-input',
+
+        'enabled' => 'enabled-input',
+
+        'id' => 'id-input',
+
+        'links' => {
+
+          'creditor' => 'creditor-input'
+
         },
-        
-      
-        
-          "metadata" => "metadata-input",
-        
-      
+
+        'metadata' => 'metadata-input'
+
       }
     end
 
-    it "can be initialized from an unenveloped response" do
+    it 'can be initialized from an unenveloped response' do
       resource = described_class.new(data)
-      
-       
-       expect(resource.account_holder_name).to eq("account_holder_name-input")
-       
-       
-       
-       expect(resource.account_number_ending).to eq("account_number_ending-input")
-       
-       
-       
-       expect(resource.bank_name).to eq("bank_name-input")
-       
-       
-       
-       expect(resource.country_code).to eq("country_code-input")
-       
-       
-       
-       expect(resource.created_at).to eq("created_at-input")
-       
-       
-       
-       expect(resource.currency).to eq("currency-input")
-       
-       
-       
-       expect(resource.enabled).to eq("enabled-input")
-       
-       
-       
-       expect(resource.id).to eq("id-input")
-       
-       
-       
-         
-           expect(resource.links.creditor).to eq("creditor-input")
-         
-       
-       
-       
-       expect(resource.metadata).to eq("metadata-input")
-       
-       
+
+      expect(resource.account_holder_name).to eq('account_holder_name-input')
+
+      expect(resource.account_number_ending).to eq('account_number_ending-input')
+
+      expect(resource.bank_name).to eq('bank_name-input')
+
+      expect(resource.country_code).to eq('country_code-input')
+
+      expect(resource.created_at).to eq('created_at-input')
+
+      expect(resource.currency).to eq('currency-input')
+
+      expect(resource.enabled).to eq('enabled-input')
+
+      expect(resource.id).to eq('id-input')
+
+      expect(resource.links.creditor).to eq('creditor-input')
+
+      expect(resource.metadata).to eq('metadata-input')
     end
 
-    it "can handle new attributes without erroring" do
-      data["foo"] = "bar"
+    it 'can handle new attributes without erroring' do
+      data['foo'] = 'bar'
       expect { described_class.new(data) }.to_not raise_error
     end
 
-    
-    it "can handle new link attributes without erroring" do
-      data["links"]["foo"] = "bar"
+    it 'can handle new link attributes without erroring' do
+      data['links']['foo'] = 'bar'
       expect { described_class.new(data) }.to_not raise_error
     end
 
-    it "can handle a nil links value" do
-      data["links"] = nil
+    it 'can handle a nil links value' do
+      data['links'] = nil
       expect { described_class.new(data).links }.to_not raise_error
     end
-    
 
-    describe "#to_h" do
-      it "returns a hash representing the resource" do
+    describe '#to_h' do
+      it 'returns a hash representing the resource' do
         expect(described_class.new(data).to_h).to eq(data)
       end
     end

data/spec/resources/creditor_spec.rb

@@ -1,139 +1,90 @@
 require 'spec_helper'
 
 describe GoCardlessPro::Resources::Creditor do
-  describe "initialising" do
+  describe 'initialising' do
     let(:data) do
       {
-      
-        
-          "address_line1" => "address_line1-input",
-        
-      
-        
-          "address_line2" => "address_line2-input",
-        
-      
-        
-          "address_line3" => "address_line3-input",
-        
-      
-        
-          "city" => "city-input",
-        
-      
-        
-          "country_code" => "country_code-input",
-        
-      
-        
-          "created_at" => "created_at-input",
-        
-      
-        
-          "id" => "id-input",
-        
-      
-        
-        "links" => {
-          
-            "default_eur_payout_account" => "default_eur_payout_account-input",
-          
-            "default_gbp_payout_account" => "default_gbp_payout_account-input",
-          
-            "default_sek_payout_account" => "default_sek_payout_account-input",
-          
+
+        'address_line1' => 'address_line1-input',
+
+        'address_line2' => 'address_line2-input',
+
+        'address_line3' => 'address_line3-input',
+
+        'city' => 'city-input',
+
+        'country_code' => 'country_code-input',
+
+        'created_at' => 'created_at-input',
+
+        'id' => 'id-input',
+
+        'links' => {
+
+          'default_eur_payout_account' => 'default_eur_payout_account-input',
+
+          'default_gbp_payout_account' => 'default_gbp_payout_account-input',
+
+          'default_sek_payout_account' => 'default_sek_payout_account-input'
+
         },
-        
-      
-        
-          "name" => "name-input",
-        
-      
-        
-          "postal_code" => "postal_code-input",
-        
-      
-        
-          "region" => "region-input",
-        
-      
+
+        'name' => 'name-input',
+
+        'postal_code' => 'postal_code-input',
+
+        'region' => 'region-input'
+
       }
     end
 
-    it "can be initialized from an unenveloped response" do
+    it 'can be initialized from an unenveloped response' do
       resource = described_class.new(data)
-      
-       
-       expect(resource.address_line1).to eq("address_line1-input")
-       
-       
-       
-       expect(resource.address_line2).to eq("address_line2-input")
-       
-       
-       
-       expect(resource.address_line3).to eq("address_line3-input")
-       
-       
-       
-       expect(resource.city).to eq("city-input")
-       
-       
-       
-       expect(resource.country_code).to eq("country_code-input")
-       
-       
-       
-       expect(resource.created_at).to eq("created_at-input")
-       
-       
-       
-       expect(resource.id).to eq("id-input")
-       
-       
-       
-         
-           expect(resource.links.default_eur_payout_account).to eq("default_eur_payout_account-input")
-         
-           expect(resource.links.default_gbp_payout_account).to eq("default_gbp_payout_account-input")
-         
-           expect(resource.links.default_sek_payout_account).to eq("default_sek_payout_account-input")
-         
-       
-       
-       
-       expect(resource.name).to eq("name-input")
-       
-       
-       
-       expect(resource.postal_code).to eq("postal_code-input")
-       
-       
-       
-       expect(resource.region).to eq("region-input")
-       
-       
+
+      expect(resource.address_line1).to eq('address_line1-input')
+
+      expect(resource.address_line2).to eq('address_line2-input')
+
+      expect(resource.address_line3).to eq('address_line3-input')
+
+      expect(resource.city).to eq('city-input')
+
+      expect(resource.country_code).to eq('country_code-input')
+
+      expect(resource.created_at).to eq('created_at-input')
+
+      expect(resource.id).to eq('id-input')
+
+      expect(resource.links.default_eur_payout_account).to eq('default_eur_payout_account-input')
+
+      expect(resource.links.default_gbp_payout_account).to eq('default_gbp_payout_account-input')
+
+      expect(resource.links.default_sek_payout_account).to eq('default_sek_payout_account-input')
+
+      expect(resource.name).to eq('name-input')
+
+      expect(resource.postal_code).to eq('postal_code-input')
+
+      expect(resource.region).to eq('region-input')
     end
 
-    it "can handle new attributes without erroring" do
-      data["foo"] = "bar"
+    it 'can handle new attributes without erroring' do
+      data['foo'] = 'bar'
       expect { described_class.new(data) }.to_not raise_error
     end
 
-    
-    it "can handle new link attributes without erroring" do
-      data["links"]["foo"] = "bar"
+    it 'can handle new link attributes without erroring' do
+      data['links']['foo'] = 'bar'
       expect { described_class.new(data) }.to_not raise_error
     end
 
-    it "can handle a nil links value" do
-      data["links"] = nil
+    it 'can handle a nil links value' do
+      data['links'] = nil
       expect { described_class.new(data).links }.to_not raise_error
     end
-    
 
-    describe "#to_h" do
-      it "returns a hash representing the resource" do
+    describe '#to_h' do
+      it 'returns a hash representing the resource' do
         expect(described_class.new(data).to_h).to eq(data)
       end
     end