gocardless_pro 1.0.3 → 1.0.4

data/spec/response_spec.rb

@@ -1,102 +1,101 @@
 require 'spec_helper'
 
 describe GoCardlessPro::Response do
-
   subject(:response) { described_class.new(raw_response) }
   let(:default_headers) do
     { 'Content-Type' => 'application/json' }
   end
 
-  context "when the response is not an error" do
+  context 'when the response is not an error' do
     let(:raw_response) do
-      double("response",
-        headers: default_headers,
-        status: 200,
-        body: { customers: [] }.to_json
-      )
+      double('response',
+             headers: default_headers,
+             status: 200,
+             body: { customers: [] }.to_json
+            )
     end
 
-    it "returns the body parsed into a hash" do
-      expect(response.body).to eq("customers" => [])
+    it 'returns the body parsed into a hash' do
+      expect(response.body).to eq('customers' => [])
     end
   end
 
-  context "when the response is empty" do
+  context 'when the response is empty' do
     let(:raw_response) do
-      double("response", headers: default_headers, status: 204, body: '')
+      double('response', headers: default_headers, status: 204, body: '')
     end
 
-    it "returns nil" do
+    it 'returns nil' do
       expect(response.body).to be_nil
     end
   end
 
-  context "when the resonse is a validation error" do
+  context 'when the resonse is a validation error' do
     let(:raw_response) do
-      double("response",
-        headers: default_headers,
-        status: 400,
-        body: { error: { type: 'validation_failed' } }.to_json
-      )
+      double('response',
+             headers: default_headers,
+             status: 400,
+             body: { error: { type: 'validation_failed' } }.to_json
+            )
     end
 
-    it "raises a ValidationError" do
+    it 'raises a ValidationError' do
       expect { response.body }.to raise_error(GoCardlessPro::ValidationError)
     end
   end
 
-  context "when the resonse is a gocardless error" do
+  context 'when the resonse is a gocardless error' do
     let(:raw_response) do
-      double("response",
-        headers: default_headers,
-        status: 400,
-        body: { error: { type: 'gocardless' } }.to_json
-      )
+      double('response',
+             headers: default_headers,
+             status: 400,
+             body: { error: { type: 'gocardless' } }.to_json
+            )
     end
 
-    it "raises a ValidationError" do
+    it 'raises a ValidationError' do
       expect { response.body }.to raise_error(GoCardlessPro::GoCardlessError)
     end
   end
 
-  context "when the resonse is an invalid api usage error" do
+  context 'when the resonse is an invalid api usage error' do
     let(:raw_response) do
-      double("response",
-        headers: default_headers,
-        status: 400,
-        body: { error: { type: 'invalid_api_usage' } }.to_json
-      )
+      double('response',
+             headers: default_headers,
+             status: 400,
+             body: { error: { type: 'invalid_api_usage' } }.to_json
+            )
     end
 
-    it "raises a ValidationError" do
+    it 'raises a ValidationError' do
       expect { response.body }.to raise_error(GoCardlessPro::InvalidApiUsageError)
     end
   end
 
   context "when the response isn't JSON" do
     let(:raw_response) do
-      double("response",
-        headers: {},
-        status: 400,
-        body: '',
-      )
+      double('response',
+             headers: {},
+             status: 400,
+             body: ''
+            )
     end
 
-    it "raises an ApiError" do
+    it 'raises an ApiError' do
       expect { response.body }.to raise_error(GoCardlessPro::ApiError)
     end
   end
 
-  context "when the response is an invalid state error" do
+  context 'when the response is an invalid state error' do
     let(:raw_response) do
-      double("response",
-        headers: default_headers,
-        status: 400,
-        body: { error: { type: 'invalid_state' } }.to_json
-      )
+      double('response',
+             headers: default_headers,
+             status: 400,
+             body: { error: { type: 'invalid_state' } }.to_json
+            )
     end
 
-    it "raises a ValidationError" do
+    it 'raises a ValidationError' do
       expect { response.body }.to raise_error(GoCardlessPro::InvalidStateError)
     end
   end

data/spec/services/bank_details_lookups_service_spec.rb

@@ -3,82 +3,77 @@ require 'spec_helper'
 describe GoCardlessPro::Services::BankDetailsLookupsService do
   let(:client) do
     GoCardlessPro::Client.new(
-      access_token: "SECRET_TOKEN"
+      access_token: 'SECRET_TOKEN'
     )
   end
 
-  
-  
-  
-    
-
-    
-    describe "#create" do
+  describe '#create' do
     subject(:post_create_response) { client.bank_details_lookups.create(params: new_resource) }
-      context "with a valid request" do
-        let(:new_resource) do
-          {
-          
-          "available_debit_schemes" => "available_debit_schemes-input",
-          "bank_name" => "bank_name-input",
-          "bic" => "bic-input",
-          }
-        end
+    context 'with a valid request' do
+      let(:new_resource) do
+        {
+
+          'available_debit_schemes' => 'available_debit_schemes-input',
+          'bank_name' => 'bank_name-input',
+          'bic' => 'bic-input'
+        }
+      end
 
-        before do
-          stub_request(:post, %r(.*api.gocardless.com/bank_details_lookups)).
-          with(
+      before do
+        stub_request(:post, %r{.*api.gocardless.com/bank_details_lookups})
+          .with(
             body: {
-              "bank_details_lookups" => {
-                
-                "available_debit_schemes" => "available_debit_schemes-input",
-                "bank_name" => "bank_name-input",
-                "bic" => "bic-input",
-                }
+              'bank_details_lookups' => {
+
+                'available_debit_schemes' => 'available_debit_schemes-input',
+                'bank_name' => 'bank_name-input',
+                'bic' => 'bic-input'
+              }
             }
-          ).
-          to_return(
+          )
+          .to_return(
             body: {
-              "bank_details_lookups" => {
-                
-                "available_debit_schemes" => "available_debit_schemes-input",
-                "bank_name" => "bank_name-input",
-                "bic" => "bic-input",
+              'bank_details_lookups' =>
+
+                {
+
+                  'available_debit_schemes' => 'available_debit_schemes-input',
+                  'bank_name' => 'bank_name-input',
+                  'bic' => 'bic-input'
                 }
+
             }.to_json,
-            :headers => {'Content-Type' => 'application/json'}
+            headers: { 'Content-Type' => 'application/json' }
           )
-        end
+      end
 
-        it "creates and returns the resource" do
-          expect(post_create_response).to be_a(GoCardlessPro::Resources::BankDetailsLookup)
-        end
+      it 'creates and returns the resource' do
+        expect(post_create_response).to be_a(GoCardlessPro::Resources::BankDetailsLookup)
       end
+    end
 
-      context "with a request that returns a validation error" do
-        let(:new_resource) { {} }
+    context 'with a request that returns a validation error' do
+      let(:new_resource) { {} }
 
-        before do
-          stub_request(:post, %r(.*api.gocardless.com/bank_details_lookups)).to_return(
-            body: {
-              error: {
-                type: 'validation_failed',
-                code: 422,
-                errors: [
-                  { message: 'test error message', field: 'test_field' }
-                ]
-              }
-            }.to_json,
-            headers: {'Content-Type' => 'application/json'},
-            status: 422
-          )
-        end
+      before do
+        stub_request(:post, %r{.*api.gocardless.com/bank_details_lookups}).to_return(
+          body: {
+            error: {
+              type: 'validation_failed',
+              code: 422,
+              errors: [
+                { message: 'test error message', field: 'test_field' }
+              ]
+            }
+          }.to_json,
+          headers: { 'Content-Type' => 'application/json' },
+          status: 422
+        )
+      end
 
-        it "throws the correct error" do
-          expect { post_create_response }.to raise_error(GoCardlessPro::ValidationError)
-        end
+      it 'throws the correct error' do
+        expect { post_create_response }.to raise_error(GoCardlessPro::ValidationError)
       end
     end
-    
-  
+  end
 end

data/spec/services/creditor_bank_accounts_service_spec.rb

@@ -3,417 +3,373 @@ require 'spec_helper'
 describe GoCardlessPro::Services::CreditorBankAccountsService do
   let(:client) do
     GoCardlessPro::Client.new(
-      access_token: "SECRET_TOKEN"
+      access_token: 'SECRET_TOKEN'
     )
   end
 
-  
-  
-  
-    
-
-    
-    describe "#create" do
+  describe '#create' do
     subject(:post_create_response) { client.creditor_bank_accounts.create(params: new_resource) }
-      context "with a valid request" do
-        let(:new_resource) do
-          {
-          
-          "account_holder_name" => "account_holder_name-input",
-          "account_number_ending" => "account_number_ending-input",
-          "bank_name" => "bank_name-input",
-          "country_code" => "country_code-input",
-          "created_at" => "created_at-input",
-          "currency" => "currency-input",
-          "enabled" => "enabled-input",
-          "id" => "id-input",
-          "links" => "links-input",
-          "metadata" => "metadata-input",
-          }
-        end
+    context 'with a valid request' do
+      let(:new_resource) do
+        {
+
+          'account_holder_name' => 'account_holder_name-input',
+          'account_number_ending' => 'account_number_ending-input',
+          'bank_name' => 'bank_name-input',
+          'country_code' => 'country_code-input',
+          'created_at' => 'created_at-input',
+          'currency' => 'currency-input',
+          'enabled' => 'enabled-input',
+          'id' => 'id-input',
+          'links' => 'links-input',
+          'metadata' => 'metadata-input'
+        }
+      end
 
-        before do
-          stub_request(:post, %r(.*api.gocardless.com/creditor_bank_accounts)).
-          with(
+      before do
+        stub_request(:post, %r{.*api.gocardless.com/creditor_bank_accounts})
+          .with(
             body: {
-              "creditor_bank_accounts" => {
-                
-                "account_holder_name" => "account_holder_name-input",
-                "account_number_ending" => "account_number_ending-input",
-                "bank_name" => "bank_name-input",
-                "country_code" => "country_code-input",
-                "created_at" => "created_at-input",
-                "currency" => "currency-input",
-                "enabled" => "enabled-input",
-                "id" => "id-input",
-                "links" => "links-input",
-                "metadata" => "metadata-input",
-                }
+              'creditor_bank_accounts' => {
+
+                'account_holder_name' => 'account_holder_name-input',
+                'account_number_ending' => 'account_number_ending-input',
+                'bank_name' => 'bank_name-input',
+                'country_code' => 'country_code-input',
+                'created_at' => 'created_at-input',
+                'currency' => 'currency-input',
+                'enabled' => 'enabled-input',
+                'id' => 'id-input',
+                'links' => 'links-input',
+                'metadata' => 'metadata-input'
+              }
             }
-          ).
-          to_return(
+          )
+          .to_return(
             body: {
-              "creditor_bank_accounts" => {
-                
-                "account_holder_name" => "account_holder_name-input",
-                "account_number_ending" => "account_number_ending-input",
-                "bank_name" => "bank_name-input",
-                "country_code" => "country_code-input",
-                "created_at" => "created_at-input",
-                "currency" => "currency-input",
-                "enabled" => "enabled-input",
-                "id" => "id-input",
-                "links" => "links-input",
-                "metadata" => "metadata-input",
+              'creditor_bank_accounts' =>
+
+                {
+
+                  'account_holder_name' => 'account_holder_name-input',
+                  'account_number_ending' => 'account_number_ending-input',
+                  'bank_name' => 'bank_name-input',
+                  'country_code' => 'country_code-input',
+                  'created_at' => 'created_at-input',
+                  'currency' => 'currency-input',
+                  'enabled' => 'enabled-input',
+                  'id' => 'id-input',
+                  'links' => 'links-input',
+                  'metadata' => 'metadata-input'
                 }
-            }.to_json,
-            :headers => {'Content-Type' => 'application/json'}
-          )
-        end
-
-        it "creates and returns the resource" do
-          expect(post_create_response).to be_a(GoCardlessPro::Resources::CreditorBankAccount)
-        end
-      end
-
-      context "with a request that returns a validation error" do
-        let(:new_resource) { {} }
 
-        before do
-          stub_request(:post, %r(.*api.gocardless.com/creditor_bank_accounts)).to_return(
-            body: {
-              error: {
-                type: 'validation_failed',
-                code: 422,
-                errors: [
-                  { message: 'test error message', field: 'test_field' }
-                ]
-              }
             }.to_json,
-            headers: {'Content-Type' => 'application/json'},
-            status: 422
+            headers: { 'Content-Type' => 'application/json' }
           )
-        end
-
-        it "throws the correct error" do
-          expect { post_create_response }.to raise_error(GoCardlessPro::ValidationError)
-        end
       end
-    end
-    
-  
-    
-
-    
-    describe "#list" do
-      describe "with no filters" do
-        subject(:get_list_response) { client.creditor_bank_accounts.list }
 
-        before do
-          stub_request(:get, %r(.*api.gocardless.com/creditor_bank_accounts)).to_return(
-            body: {
-              "creditor_bank_accounts" => [{
-                
-                "account_holder_name" => "account_holder_name-input",
-                "account_number_ending" => "account_number_ending-input",
-                "bank_name" => "bank_name-input",
-                "country_code" => "country_code-input",
-                "created_at" => "created_at-input",
-                "currency" => "currency-input",
-                "enabled" => "enabled-input",
-                "id" => "id-input",
-                "links" => "links-input",
-                "metadata" => "metadata-input",
-                }],
-                meta: {
-                  cursors: {
-                    before: nil,
-                    after: "ABC123"
-                  }
-                }
-            }.to_json,
-            :headers => {'Content-Type' => 'application/json'}
-          )
-        end
-
-        it "wraps each item in the resource class" do
-          expect(get_list_response.records.map { |x| x.class }.uniq.first).to eq(GoCardlessPro::Resources::CreditorBankAccount)
-
-          
-          
-          expect(get_list_response.records.first.account_holder_name).to eq("account_holder_name-input")
-          
-          
-          
-          expect(get_list_response.records.first.account_number_ending).to eq("account_number_ending-input")
-          
-          
-          
-          expect(get_list_response.records.first.bank_name).to eq("bank_name-input")
-          
-          
-          
-          expect(get_list_response.records.first.country_code).to eq("country_code-input")
-          
-          
-          
-          expect(get_list_response.records.first.created_at).to eq("created_at-input")
-          
-          
-          
-          expect(get_list_response.records.first.currency).to eq("currency-input")
-          
-          
-          
-          expect(get_list_response.records.first.enabled).to eq("enabled-input")
-          
-          
-          
-          expect(get_list_response.records.first.id).to eq("id-input")
-          
-          
-          
-          
-          
-          expect(get_list_response.records.first.metadata).to eq("metadata-input")
-          
-          
-        end
-
-        it "exposes the cursors for before and after" do
-          expect(get_list_response.before).to eq(nil)
-          expect(get_list_response.after).to eq("ABC123")
-        end
-
-        specify { expect(get_list_response.api_response.headers).to eql('content-type' => 'application/json') }
+      it 'creates and returns the resource' do
+        expect(post_create_response).to be_a(GoCardlessPro::Resources::CreditorBankAccount)
       end
     end
 
-    describe "#all" do
-      let!(:first_response_stub) do
-        stub_request(:get, %r(.*api.gocardless.com/creditor_bank_accounts$)).to_return(
+    context 'with a request that returns a validation error' do
+      let(:new_resource) { {} }
+
+      before do
+        stub_request(:post, %r{.*api.gocardless.com/creditor_bank_accounts}).to_return(
           body: {
-            "creditor_bank_accounts" => [{
-              
-              "account_holder_name" => "account_holder_name-input",
-              "account_number_ending" => "account_number_ending-input",
-              "bank_name" => "bank_name-input",
-              "country_code" => "country_code-input",
-              "created_at" => "created_at-input",
-              "currency" => "currency-input",
-              "enabled" => "enabled-input",
-              "id" => "id-input",
-              "links" => "links-input",
-              "metadata" => "metadata-input",
-            }],
-            meta: {
-              cursors: { after: 'AB345' },
-              limit: 1
+            error: {
+              type: 'validation_failed',
+              code: 422,
+              errors: [
+                { message: 'test error message', field: 'test_field' }
+              ]
             }
           }.to_json,
-          :headers => {'Content-Type' => 'application/json'}
+          headers: { 'Content-Type' => 'application/json' },
+          status: 422
         )
       end
 
-      let!(:second_response_stub) do
-        stub_request(:get, %r(.*api.gocardless.com/creditor_bank_accounts\?after=AB345)).to_return(
+      it 'throws the correct error' do
+        expect { post_create_response }.to raise_error(GoCardlessPro::ValidationError)
+      end
+    end
+  end
+
+  describe '#list' do
+    describe 'with no filters' do
+      subject(:get_list_response) { client.creditor_bank_accounts.list }
+
+      before do
+        stub_request(:get, %r{.*api.gocardless.com/creditor_bank_accounts}).to_return(
           body: {
-            "creditor_bank_accounts" => [{
-              
-              "account_holder_name" => "account_holder_name-input",
-              "account_number_ending" => "account_number_ending-input",
-              "bank_name" => "bank_name-input",
-              "country_code" => "country_code-input",
-              "created_at" => "created_at-input",
-              "currency" => "currency-input",
-              "enabled" => "enabled-input",
-              "id" => "id-input",
-              "links" => "links-input",
-              "metadata" => "metadata-input",
+            'creditor_bank_accounts' => [{
+
+              'account_holder_name' => 'account_holder_name-input',
+              'account_number_ending' => 'account_number_ending-input',
+              'bank_name' => 'bank_name-input',
+              'country_code' => 'country_code-input',
+              'created_at' => 'created_at-input',
+              'currency' => 'currency-input',
+              'enabled' => 'enabled-input',
+              'id' => 'id-input',
+              'links' => 'links-input',
+              'metadata' => 'metadata-input'
             }],
             meta: {
-              limit: 2,
-              cursors: {}
+              cursors: {
+                before: nil,
+                after: 'ABC123'
+              }
             }
           }.to_json,
-          :headers => {'Content-Type' => 'application/json'}
+          headers: { 'Content-Type' => 'application/json' }
         )
       end
 
-      it "automatically makes the extra requests" do
-        expect(client.creditor_bank_accounts.all.to_a.length).to eq(2)
-        expect(first_response_stub).to have_been_requested
-        expect(second_response_stub).to have_been_requested
+      it 'wraps each item in the resource class' do
+        expect(get_list_response.records.map(&:class).uniq.first).to eq(GoCardlessPro::Resources::CreditorBankAccount)
+
+        expect(get_list_response.records.first.account_holder_name).to eq('account_holder_name-input')
+
+        expect(get_list_response.records.first.account_number_ending).to eq('account_number_ending-input')
+
+        expect(get_list_response.records.first.bank_name).to eq('bank_name-input')
+
+        expect(get_list_response.records.first.country_code).to eq('country_code-input')
+
+        expect(get_list_response.records.first.created_at).to eq('created_at-input')
+
+        expect(get_list_response.records.first.currency).to eq('currency-input')
+
+        expect(get_list_response.records.first.enabled).to eq('enabled-input')
+
+        expect(get_list_response.records.first.id).to eq('id-input')
+
+        expect(get_list_response.records.first.metadata).to eq('metadata-input')
+      end
+
+      it 'exposes the cursors for before and after' do
+        expect(get_list_response.before).to eq(nil)
+        expect(get_list_response.after).to eq('ABC123')
       end
+
+      specify { expect(get_list_response.api_response.headers).to eql('content-type' => 'application/json') }
+    end
+  end
+
+  describe '#all' do
+    let!(:first_response_stub) do
+      stub_request(:get, %r{.*api.gocardless.com/creditor_bank_accounts$}).to_return(
+        body: {
+          'creditor_bank_accounts' => [{
+
+            'account_holder_name' => 'account_holder_name-input',
+            'account_number_ending' => 'account_number_ending-input',
+            'bank_name' => 'bank_name-input',
+            'country_code' => 'country_code-input',
+            'created_at' => 'created_at-input',
+            'currency' => 'currency-input',
+            'enabled' => 'enabled-input',
+            'id' => 'id-input',
+            'links' => 'links-input',
+            'metadata' => 'metadata-input'
+          }],
+          meta: {
+            cursors: { after: 'AB345' },
+            limit: 1
+          }
+        }.to_json,
+        headers: { 'Content-Type' => 'application/json' }
+      )
     end
 
-    
-  
-    
+    let!(:second_response_stub) do
+      stub_request(:get, %r{.*api.gocardless.com/creditor_bank_accounts\?after=AB345}).to_return(
+        body: {
+          'creditor_bank_accounts' => [{
+
+            'account_holder_name' => 'account_holder_name-input',
+            'account_number_ending' => 'account_number_ending-input',
+            'bank_name' => 'bank_name-input',
+            'country_code' => 'country_code-input',
+            'created_at' => 'created_at-input',
+            'currency' => 'currency-input',
+            'enabled' => 'enabled-input',
+            'id' => 'id-input',
+            'links' => 'links-input',
+            'metadata' => 'metadata-input'
+          }],
+          meta: {
+            limit: 2,
+            cursors: {}
+          }
+        }.to_json,
+        headers: { 'Content-Type' => 'application/json' }
+      )
+    end
 
-    
-    describe "#get" do
-      let(:id) { "ID123" }
+    it 'automatically makes the extra requests' do
+      expect(client.creditor_bank_accounts.all.to_a.length).to eq(2)
+      expect(first_response_stub).to have_been_requested
+      expect(second_response_stub).to have_been_requested
+    end
+  end
 
-      subject(:get_response) { client.creditor_bank_accounts.get(id) }
+  describe '#get' do
+    let(:id) { 'ID123' }
 
-      context "passing in a custom header" do
-        let!(:stub) do
-          stub_url = "/creditor_bank_accounts/:identity".gsub(':identity', id)
-          stub_request(:get, %r(.*api.gocardless.com#{stub_url})).
-          with(headers: { 'Foo' => 'Bar' }).
-          to_return(
-            body: {
-              "creditor_bank_accounts" => {
-                
-                "account_holder_name" => "account_holder_name-input",
-                "account_number_ending" => "account_number_ending-input",
-                "bank_name" => "bank_name-input",
-                "country_code" => "country_code-input",
-                "created_at" => "created_at-input",
-                "currency" => "currency-input",
-                "enabled" => "enabled-input",
-                "id" => "id-input",
-                "links" => "links-input",
-                "metadata" => "metadata-input",
-              }
-            }.to_json,
-            :headers => {'Content-Type' => 'application/json'}
-          )
-        end
-
-        subject(:get_response) do
-          client.creditor_bank_accounts.get(id, headers: {
-            'Foo' => 'Bar'
-          })
-        end
-
-        it "includes the header" do
-          get_response
-          expect(stub).to have_been_requested
-        end
-      end
+    subject(:get_response) { client.creditor_bank_accounts.get(id) }
 
-      context "when there is a creditor_bank_account to return" do
-        before do
-          stub_url = "/creditor_bank_accounts/:identity".gsub(':identity', id)
-          stub_request(:get, %r(.*api.gocardless.com#{stub_url})).to_return(
+    context 'passing in a custom header' do
+      let!(:stub) do
+        stub_url = '/creditor_bank_accounts/:identity'.gsub(':identity', id)
+        stub_request(:get, /.*api.gocardless.com#{stub_url}/)
+          .with(headers: { 'Foo' => 'Bar' })
+          .to_return(
             body: {
-              "creditor_bank_accounts" => {
-                
-                "account_holder_name" => "account_holder_name-input",
-                "account_number_ending" => "account_number_ending-input",
-                "bank_name" => "bank_name-input",
-                "country_code" => "country_code-input",
-                "created_at" => "created_at-input",
-                "currency" => "currency-input",
-                "enabled" => "enabled-input",
-                "id" => "id-input",
-                "links" => "links-input",
-                "metadata" => "metadata-input",
+              'creditor_bank_accounts' => {
+
+                'account_holder_name' => 'account_holder_name-input',
+                'account_number_ending' => 'account_number_ending-input',
+                'bank_name' => 'bank_name-input',
+                'country_code' => 'country_code-input',
+                'created_at' => 'created_at-input',
+                'currency' => 'currency-input',
+                'enabled' => 'enabled-input',
+                'id' => 'id-input',
+                'links' => 'links-input',
+                'metadata' => 'metadata-input'
               }
             }.to_json,
-            :headers => {'Content-Type' => 'application/json'}
+            headers: { 'Content-Type' => 'application/json' }
           )
-        end
-
-        it "wraps the response in a resource" do
-          expect(get_response).to be_a(GoCardlessPro::Resources::CreditorBankAccount)
-        end
       end
 
-      context "when nothing is returned" do
-        before do
-          stub_url = "/creditor_bank_accounts/:identity".gsub(':identity', id)
-          stub_request(:get, %r(.*api.gocardless.com#{stub_url})).to_return(
-            body: "",
-            headers: { 'Content-Type' => 'application/json' }
-          )
-        end
+      subject(:get_response) do
+        client.creditor_bank_accounts.get(id, headers: {
+                                            'Foo' => 'Bar'
+                                          })
+      end
 
-        it "returns nil" do
-          expect(get_response).to be_nil
-        end
+      it 'includes the header' do
+        get_response
+        expect(stub).to have_been_requested
       end
     end
 
-    
-  
-    
-
-    
-    describe "#disable" do
-      
-      
-        subject(:post_response) { client.creditor_bank_accounts.disable(resource_id) }
-      
-      let(:resource_id) { "ABC123" }
-
-      let!(:stub) do
-        # /creditor_bank_accounts/%v/actions/disable
-        stub_url = "/creditor_bank_accounts/:identity/actions/disable".gsub(':identity', resource_id)
-        stub_request(:post, %r(.*api.gocardless.com#{stub_url})).to_return(
+    context 'when there is a creditor_bank_account to return' do
+      before do
+        stub_url = '/creditor_bank_accounts/:identity'.gsub(':identity', id)
+        stub_request(:get, /.*api.gocardless.com#{stub_url}/).to_return(
           body: {
-            "creditor_bank_accounts" => {
-              
-              "account_holder_name" => "account_holder_name-input",
-              "account_number_ending" => "account_number_ending-input",
-              "bank_name" => "bank_name-input",
-              "country_code" => "country_code-input",
-              "created_at" => "created_at-input",
-              "currency" => "currency-input",
-              "enabled" => "enabled-input",
-              "id" => "id-input",
-              "links" => "links-input",
-              "metadata" => "metadata-input",
+            'creditor_bank_accounts' => {
+
+              'account_holder_name' => 'account_holder_name-input',
+              'account_number_ending' => 'account_number_ending-input',
+              'bank_name' => 'bank_name-input',
+              'country_code' => 'country_code-input',
+              'created_at' => 'created_at-input',
+              'currency' => 'currency-input',
+              'enabled' => 'enabled-input',
+              'id' => 'id-input',
+              'links' => 'links-input',
+              'metadata' => 'metadata-input'
             }
           }.to_json,
-          headers: {'Content-Type' => 'application/json'},
+          headers: { 'Content-Type' => 'application/json' }
         )
       end
 
-      it "wraps the response and calls the right endpoint" do
-        expect(post_response).to be_a(GoCardlessPro::Resources::CreditorBankAccount)
+      it 'wraps the response in a resource' do
+        expect(get_response).to be_a(GoCardlessPro::Resources::CreditorBankAccount)
+      end
+    end
 
-        expect(stub).to have_been_requested
+    context 'when nothing is returned' do
+      before do
+        stub_url = '/creditor_bank_accounts/:identity'.gsub(':identity', id)
+        stub_request(:get, /.*api.gocardless.com#{stub_url}/).to_return(
+          body: '',
+          headers: { 'Content-Type' => 'application/json' }
+        )
       end
 
-      context "when the request needs a body and custom header" do
-        
-          let(:body) { { foo: 'bar' } }
-          let(:headers) { { 'Foo' => 'Bar' } }
-          subject(:post_response) { client.creditor_bank_accounts.disable(resource_id, body, headers) }
-        
-        let(:resource_id) { "ABC123" }
-
-        let!(:stub) do
-          # /creditor_bank_accounts/%v/actions/disable
-          stub_url = "/creditor_bank_accounts/:identity/actions/disable".gsub(':identity', resource_id)
-          stub_request(:post, %r(.*api.gocardless.com#{stub_url})).
-          with(
+      it 'returns nil' do
+        expect(get_response).to be_nil
+      end
+    end
+  end
+
+  describe '#disable' do
+    subject(:post_response) { client.creditor_bank_accounts.disable(resource_id) }
+
+    let(:resource_id) { 'ABC123' }
+
+    let!(:stub) do
+      # /creditor_bank_accounts/%v/actions/disable
+      stub_url = '/creditor_bank_accounts/:identity/actions/disable'.gsub(':identity', resource_id)
+      stub_request(:post, /.*api.gocardless.com#{stub_url}/).to_return(
+        body: {
+          'creditor_bank_accounts' => {
+
+            'account_holder_name' => 'account_holder_name-input',
+            'account_number_ending' => 'account_number_ending-input',
+            'bank_name' => 'bank_name-input',
+            'country_code' => 'country_code-input',
+            'created_at' => 'created_at-input',
+            'currency' => 'currency-input',
+            'enabled' => 'enabled-input',
+            'id' => 'id-input',
+            'links' => 'links-input',
+            'metadata' => 'metadata-input'
+          }
+        }.to_json,
+        headers: { 'Content-Type' => 'application/json' }
+      )
+    end
+
+    it 'wraps the response and calls the right endpoint' do
+      expect(post_response).to be_a(GoCardlessPro::Resources::CreditorBankAccount)
+
+      expect(stub).to have_been_requested
+    end
+
+    context 'when the request needs a body and custom header' do
+      let(:body) { { foo: 'bar' } }
+      let(:headers) { { 'Foo' => 'Bar' } }
+      subject(:post_response) { client.creditor_bank_accounts.disable(resource_id, body, headers) }
+
+      let(:resource_id) { 'ABC123' }
+
+      let!(:stub) do
+        # /creditor_bank_accounts/%v/actions/disable
+        stub_url = '/creditor_bank_accounts/:identity/actions/disable'.gsub(':identity', resource_id)
+        stub_request(:post, /.*api.gocardless.com#{stub_url}/)
+          .with(
             body: { foo: 'bar' },
             headers: { 'Foo' => 'Bar' }
           ).to_return(
             body: {
-              "creditor_bank_accounts" => {
-                
-                "account_holder_name" => "account_holder_name-input",
-                "account_number_ending" => "account_number_ending-input",
-                "bank_name" => "bank_name-input",
-                "country_code" => "country_code-input",
-                "created_at" => "created_at-input",
-                "currency" => "currency-input",
-                "enabled" => "enabled-input",
-                "id" => "id-input",
-                "links" => "links-input",
-                "metadata" => "metadata-input",
+              'creditor_bank_accounts' => {
+
+                'account_holder_name' => 'account_holder_name-input',
+                'account_number_ending' => 'account_number_ending-input',
+                'bank_name' => 'bank_name-input',
+                'country_code' => 'country_code-input',
+                'created_at' => 'created_at-input',
+                'currency' => 'currency-input',
+                'enabled' => 'enabled-input',
+                'id' => 'id-input',
+                'links' => 'links-input',
+                'metadata' => 'metadata-input'
               }
             }.to_json,
-            headers: {'Content-Type' => 'application/json'},
+            headers: { 'Content-Type' => 'application/json' }
           )
-        end
       end
     end
-    
-  
+  end
 end