gitlab 4.2.0 → 4.3.0

data/spec/gitlab/client/issues_spec.rb

@@ -8,11 +8,11 @@ describe Gitlab::Client do
         @issues = Gitlab.issues(3)
       end
 
-      it "should get the correct resource" do
+      it "gets the correct resource" do
         expect(a_get("/projects/3/issues")).to have_been_made
       end
 
-      it "should return a paginated response of project's issues" do
+      it "returns a paginated response of project's issues" do
         expect(@issues).to be_a Gitlab::PaginatedResponse
         expect(@issues.first.project_id).to eq(3)
       end
@@ -24,11 +24,11 @@ describe Gitlab::Client do
         @issues = Gitlab.issues('gitlab-org/gitlab-ce')
       end
 
-      it "should get the correct resource" do
+      it "gets the correct resource" do
         expect(a_get("/projects/gitlab-org%2Fgitlab-ce/issues")).to have_been_made
       end
 
-      it "should return a paginated response of project's issues" do
+      it "returns a paginated response of project's issues" do
         expect(@issues).to be_a Gitlab::PaginatedResponse
         expect(@issues.first.project_id).to eq(3)
       end
@@ -40,11 +40,11 @@ describe Gitlab::Client do
         @issues = Gitlab.issues
       end
 
-      it "should get the correct resource" do
+      it "gets the correct resource" do
         expect(a_get("/issues")).to have_been_made
       end
 
-      it "should return a paginated response of user's issues" do
+      it "returns a paginated response of user's issues" do
         expect(@issues).to be_a Gitlab::PaginatedResponse
         expect(@issues.first.closed).to be_falsey
         expect(@issues.first.author.name).to eq("John Smith")
@@ -58,11 +58,11 @@ describe Gitlab::Client do
       @issue = Gitlab.issue(3, 33)
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_get("/projects/3/issues/33")).to have_been_made
     end
 
-    it "should return information about an issue" do
+    it "returns information about an issue" do
       expect(@issue.project_id).to eq(3)
       expect(@issue.assignee.name).to eq("Jack Smith")
     end
@@ -74,12 +74,12 @@ describe Gitlab::Client do
       @issue = Gitlab.create_issue(3, 'title')
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_post("/projects/3/issues").
         with(body: { title: 'title' })).to have_been_made
     end
 
-    it "should return information about a created issue" do
+    it "returns information about a created issue" do
       expect(@issue.project_id).to eq(3)
       expect(@issue.assignee.name).to eq("Jack Smith")
     end
@@ -91,12 +91,12 @@ describe Gitlab::Client do
       @issue = Gitlab.edit_issue(3, 33, title: 'title')
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_put("/projects/3/issues/33").
         with(body: { title: 'title' })).to have_been_made
     end
 
-    it "should return information about an edited issue" do
+    it "returns information about an edited issue" do
       expect(@issue.project_id).to eq(3)
       expect(@issue.assignee.name).to eq("Jack Smith")
     end
@@ -108,12 +108,12 @@ describe Gitlab::Client do
       @issue = Gitlab.close_issue(3, 33)
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_put("/projects/3/issues/33").
         with(body: { state_event: 'close' })).to have_been_made
     end
 
-    it "should return information about an closed issue" do
+    it "returns information about an closed issue" do
       expect(@issue.project_id).to eq(3)
       expect(@issue.assignee.name).to eq("Jack Smith")
     end
@@ -125,12 +125,12 @@ describe Gitlab::Client do
       @issue = Gitlab.reopen_issue(3, 33)
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_put("/projects/3/issues/33").
         with(body: { state_event: 'reopen' })).to have_been_made
     end
 
-    it "should return information about an reopened issue" do
+    it "returns information about an reopened issue" do
       expect(@issue.project_id).to eq(3)
       expect(@issue.assignee.name).to eq("Jack Smith")
     end
@@ -142,11 +142,11 @@ describe Gitlab::Client do
       @issue = Gitlab.subscribe_to_issue(3, 33)
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_post("/projects/3/issues/33/subscribe")).to have_been_made
     end
 
-    it "should return information about the subscribed issue" do
+    it "returns information about the subscribed issue" do
       expect(@issue.project_id).to eq(3)
       expect(@issue.assignee.name).to eq("Jack Smith")
     end
@@ -158,11 +158,11 @@ describe Gitlab::Client do
       @issue = Gitlab.unsubscribe_from_issue(3, 33)
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_post("/projects/3/issues/33/unsubscribe")).to have_been_made
     end
 
-    it "should return information about the unsubscribed issue" do
+    it "returns information about the unsubscribed issue" do
       expect(@issue.project_id).to eq(3)
       expect(@issue.assignee.name).to eq("Jack Smith")
     end
@@ -174,13 +174,112 @@ describe Gitlab::Client do
       @issue = Gitlab.delete_issue(3, 33)
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_delete("/projects/3/issues/33")).to have_been_made
     end
 
-    it "should return information about a deleted issue" do
+    it "returns information about a deleted issue" do
       expect(@issue.project_id).to eq(3)
       expect(@issue.id).to eq(33)
     end
   end
+
+  describe ".move_issue" do
+    before do
+      stub_post("/projects/3/issues/33/move", "issue")
+      @issue = Gitlab.move_issue(3, 33, to_project_id: '4')
+    end
+
+    it "gets the correct resource" do
+      expect(a_post("/projects/3/issues/33/move").
+        with(body: { to_project_id: '4' })).to have_been_made
+      end
+
+    it "returns information about the moved issue" do
+      expect(@issue.project_id).to eq(3)
+      expect(@issue.assignee.name).to eq("Jack Smith")
+    end
+  end
+
+  describe ".estimate_time_of_issue" do
+    before do
+      stub_post("/projects/3/issues/33/time_estimate", "issue")
+      @issue = Gitlab.estimate_time_of_issue(3, 33, '3h30m')
+    end
+
+    it "gets the correct resource" do
+      expect(a_post("/projects/3/issues/33/time_estimate").
+        with(body: { duration: '3h30m' })).to have_been_made
+      end
+
+    it "returns information about the estimated issue" do
+      expect(@issue.project_id).to eq(3)
+      expect(@issue.assignee.name).to eq("Jack Smith")
+    end
+  end
+
+  describe ".reset_time_estimate_of_issue" do
+    before do
+      stub_post("/projects/3/issues/33/reset_time_estimate", "issue")
+      @issue = Gitlab.reset_time_estimate_of_issue(3, 33)
+    end
+
+    it "gets the correct resource" do
+      expect(a_post("/projects/3/issues/33/reset_time_estimate")).to have_been_made
+    end
+
+    it "returns information about the estimated issue" do
+      expect(@issue.project_id).to eq(3)
+      expect(@issue.assignee.name).to eq("Jack Smith")
+    end
+  end
+
+  describe ".add_time_spent_on_issue" do
+    before do
+      stub_post("/projects/3/issues/33/add_spent_time", "issue")
+      @issue = Gitlab.add_time_spent_on_issue(3, 33, '3h30m')
+    end
+
+    it "gets the correct resource" do
+      expect(a_post("/projects/3/issues/33/add_spent_time").
+        with(body: { duration: '3h30m' })).to have_been_made
+      end
+
+    it "returns information about the estimated issue" do
+      expect(@issue.project_id).to eq(3)
+      expect(@issue.assignee.name).to eq("Jack Smith")
+    end
+  end
+
+  describe ".reset_time_spent_on_issue" do
+    before do
+      stub_post("/projects/3/issues/33/reset_spent_time", "issue")
+      @issue = Gitlab.reset_time_spent_on_issue(3, 33)
+    end
+
+    it "gets the correct resource" do
+      expect(a_post("/projects/3/issues/33/reset_spent_time")).to have_been_made
+    end
+
+    it "returns information about the estimated issue" do
+      expect(@issue.project_id).to eq(3)
+      expect(@issue.assignee.name).to eq("Jack Smith")
+    end
+  end
+
+  describe ".time_stats_for_issue" do
+    before do
+      stub_get("/projects/3/issues/33/time_stats", "issue")
+      @issue = Gitlab.time_stats_for_issue(3, 33)
+    end
+
+    it "gets the correct resource" do
+      expect(a_get("/projects/3/issues/33/time_stats")).to have_been_made
+    end
+
+    it "returns information about the issue" do
+      expect(@issue.project_id).to eq(3)
+      expect(@issue.assignee.name).to eq("Jack Smith")
+    end
+  end
 end

data/spec/gitlab/client/jobs_spec.rb

@@ -7,7 +7,7 @@ describe Gitlab::Client do
       @projects = Gitlab.jobs(1)
     end
 
-    it 'should get the correct resource' do
+    it 'gets the correct resource' do
       expect(a_get('/projects/1/jobs')).to have_been_made
     end
   end
@@ -18,7 +18,7 @@ describe Gitlab::Client do
       @projects = Gitlab.jobs(1, scope: %w[created running])
     end
 
-    it 'should get the correct resource' do
+    it 'gets the correct resource' do
       expect(a_get('/projects/1/jobs?scope[]=created&scope[]=running')).to have_been_made
     end
   end
@@ -28,7 +28,7 @@ describe Gitlab::Client do
       stub_get('/projects/1/pipelines/1/jobs', 'pipeline_jobs')
       @projects = Gitlab.pipeline_jobs(1, 1)
     end
-    it 'should get the correct resource' do
+    it 'gets the correct resource' do
       expect(a_get('/projects/1/pipelines/1/jobs')).to have_been_made
     end
   end
@@ -38,7 +38,7 @@ describe Gitlab::Client do
       stub_get('/projects/1/pipelines/1/jobs?scope[]=running&scope[]=created', 'pipeline_jobs')
       @projects = Gitlab.pipeline_jobs(1, 1, scope: %w[running created])
     end
-    it 'should get the correct resource' do
+    it 'gets the correct resource' do
       expect(a_get('/projects/1/pipelines/1/jobs?scope[]=running&scope[]=created')).to have_been_made
     end
   end
@@ -48,7 +48,7 @@ describe Gitlab::Client do
       stub_get('/projects/1/jobs/1', 'job')
       @projects = Gitlab.job(1, 1)
     end
-    it 'should get the correct resource' do
+    it 'gets the correct resource' do
       expect(a_get('/projects/1/jobs/1')).to have_been_made
     end
   end
@@ -58,7 +58,7 @@ describe Gitlab::Client do
       stub_get('/projects/1/jobs/1/artifacts', 'job')
       @projects = Gitlab.job_artifacts(1, 1)
     end
-    it 'should get the correct resource' do
+    it 'gets the correct resource' do
       expect(a_get('/projects/1/jobs/1/artifacts')).to have_been_made
     end
   end
@@ -68,7 +68,7 @@ describe Gitlab::Client do
       stub_get('/projects/1/jobs/artifacts/master/download?job=Release%20Build', 'job')
       @projects = Gitlab.job_artifacts_download(1, 'master', 'Release Build')
     end
-    it 'should get the correct resource' do
+    it 'gets the correct resource' do
       expect(a_get('/projects/1/jobs/artifacts/master/download?job=Release%20Build')).to have_been_made
     end
   end
@@ -78,7 +78,7 @@ describe Gitlab::Client do
       stub_get('/projects/1/jobs/1/trace', 'job_trace')
       @projects = Gitlab.job_trace(1, 1)
     end
-    it 'should get the correct resource' do
+    it 'gets the correct resource' do
       expect(a_get('/projects/1/jobs/1/trace')).to have_been_made
     end
   end
@@ -88,7 +88,7 @@ describe Gitlab::Client do
       stub_post('/projects/1/jobs/1/cancel', 'job')
       @projects = Gitlab.job_cancel(1, 1)
     end
-    it 'should get the correct resource' do
+    it 'gets the correct resource' do
       expect(a_post('/projects/1/jobs/1/cancel')).to have_been_made
     end
   end
@@ -98,7 +98,7 @@ describe Gitlab::Client do
       stub_post('/projects/1/jobs/1/retry', 'job')
       @projects = Gitlab.job_retry(1, 1)
     end
-    it 'should get the correct resource' do
+    it 'gets the correct resource' do
       expect(a_post('/projects/1/jobs/1/retry')).to have_been_made
     end
   end
@@ -108,7 +108,7 @@ describe Gitlab::Client do
       stub_post('/projects/1/jobs/1/erase', 'job')
       @projects = Gitlab.job_erase(1, 1)
     end
-    it 'should get the correct resource' do
+    it 'gets the correct resource' do
       expect(a_post('/projects/1/jobs/1/erase')).to have_been_made
     end
   end
@@ -118,7 +118,7 @@ describe Gitlab::Client do
       stub_post('/projects/1/jobs/1/play', 'job')
       @projects = Gitlab.job_play(1, 1)
     end
-    it 'should get the correct resource' do
+    it 'gets the correct resource' do
       expect(a_post('/projects/1/jobs/1/play')).to have_been_made
     end
   end
@@ -128,7 +128,7 @@ describe Gitlab::Client do
       stub_post('/projects/1/jobs/1/artifacts/keep', 'job')
       @projects = Gitlab.job_artifacts_keep(1, 1)
     end
-    it 'should get the correct resource' do
+    it 'gets the correct resource' do
       expect(a_post('/projects/1/jobs/1/artifacts/keep')).to have_been_made
     end
   end

data/spec/gitlab/client/keys_spec.rb

@@ -7,11 +7,11 @@ describe Gitlab::Client do
       @key = Gitlab.key(1)
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_get("/keys/1")).to have_been_made
     end
 
-    it "should return information about a key" do
+    it "returns information about a key" do
       expect(@key.id).to eq(1)
       expect(@key.title).to eq("narkoz@helium")
     end

data/spec/gitlab/client/labels_spec.rb

@@ -7,11 +7,11 @@ describe Gitlab::Client do
       @labels = Gitlab.labels(3)
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_get("/projects/3/labels")).to have_been_made
     end
 
-    it "should return a paginated response of project's labels" do
+    it "returns a paginated response of project's labels" do
       expect(@labels).to be_a Gitlab::PaginatedResponse
       expect(@labels.first.name).to eq("Backlog")
     end
@@ -23,12 +23,12 @@ describe Gitlab::Client do
       @label = Gitlab.delete_label(3, "Backlog")
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_delete("/projects/3/labels").
              with(body: { name: 'Backlog' })).to have_been_made
     end
 
-    it "should return information about a deleted snippet" do
+    it "returns information about a deleted snippet" do
       expect(@label.name).to eq("Backlog")
     end
   end
@@ -39,12 +39,12 @@ describe Gitlab::Client do
       @label = Gitlab.edit_label(3, "TODO", new_name: 'Backlog')
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_put("/projects/3/labels").
              with(body: { name: 'TODO', new_name: "Backlog" })).to have_been_made
     end
 
-    it "should return information about an edited label" do
+    it "returns information about an edited label" do
       expect(@label.name).to eq("Backlog")
     end
   end
@@ -55,12 +55,12 @@ describe Gitlab::Client do
       @label = Gitlab.create_label(3, 'Backlog', '#DD10AA')
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_post("/projects/3/labels").
              with(body: { name: 'Backlog', color: '#DD10AA' })).to have_been_made
     end
 
-    it "should return information about a created label" do
+    it "returns information about a created label" do
       expect(@label.name).to eq('Backlog')
       expect(@label.color).to eq('#DD10AA')
     end
@@ -72,11 +72,11 @@ describe Gitlab::Client do
       @label = Gitlab.subscribe_to_label(3, 'Backlog')
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_post("/projects/3/labels/Backlog/subscribe")).to have_been_made
     end
 
-    it "should return information about the label subscribed to" do
+    it "returns information about the label subscribed to" do
       expect(@label.name).to eq('Backlog')
       expect(@label.subscribed).to eq(true)
     end
@@ -88,11 +88,11 @@ describe Gitlab::Client do
       @label = Gitlab.unsubscribe_from_label(3, 'Backlog')
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_post("/projects/3/labels/Backlog/unsubscribe")).to have_been_made
     end
 
-    it "should return information about the label subscribed to" do
+    it "returns information about the label subscribed to" do
       expect(@label.name).to eq('Backlog')
       expect(@label.subscribed).to eq(false)
     end