gitlab 4.2.0 → 4.3.0

data/spec/fixtures/pipeline_schedule_variable.json

@@ -0,0 +1,5 @@
+{
+  "key": "NEW_VARIABLE",
+  "value": "new value"
+}
+

data/spec/fixtures/pipeline_schedule_variable_update.json

@@ -0,0 +1,5 @@
+{
+  "key": "NEW_VARIABLE",
+  "value": "update value"
+}
+

data/spec/fixtures/pipeline_schedules.json

@@ -0,0 +1,22 @@
+[
+  {
+    "id": 13,
+    "description": "Test schedule pipeline",
+    "ref": "master",
+    "cron": "* * * * *",
+    "cron_timezone": "Asia/Tokyo",
+    "next_run_at": "2017-05-19T13:41:00.000Z",
+    "active": true,
+    "created_at": "2017-05-19T13:31:08.849Z",
+    "updated_at": "2017-05-19T13:40:17.727Z",
+    "owner": {
+      "name": "Administrator",
+      "username": "root",
+      "id": 1,
+      "state": "active",
+      "avatar_url": "http://www.gravatar.com/avatar/e64c7d89f26bd1972efa854d13d7dd61?s=80&d=identicon",
+      "web_url": "https://gitlab.example.com/root"
+    }
+  }
+]
+

data/spec/gitlab/api_spec.rb

@@ -0,0 +1,11 @@
+require 'spec_helper'
+
+describe Gitlab::API do
+  let(:default_headers) { subject.class.default_options[:headers] }
+
+  describe ".default_options[:headers]" do
+    it "has 'User-Agent'" do
+      expect(default_headers).to include('User-Agent' => Gitlab::Configuration::DEFAULT_USER_AGENT)
+    end
+  end
+end

data/spec/gitlab/cli_helpers_spec.rb

@@ -2,35 +2,34 @@ require 'spec_helper'
 
 describe Gitlab::CLI::Helpers do
   describe ".method_owners" do
-    before do
-      @methods = Gitlab::CLI::Helpers.method_owners
-    end
-    it "should return Array of Hashes containing method names and owners" do
-      expect(@methods).to be_a Array
-      expect(@methods.all? { |m| m.is_a? Hash }).to be true
-      expect(@methods.all? { |m| m.keys.sort === [:name, :owner] }).to be true
+    let(:methods) { Gitlab::CLI::Helpers.method_owners }
+
+    it "returns Array of Hashes containing method names and owners" do
+      expect(methods).to be_a Array
+      expect(methods.all? { |m| m.is_a? Hash }).to be true
+      expect(methods.all? { |m| m.keys.sort == %i(name owner) }).to be true
     end
   end
 
   describe ".valid_command?" do
-    it "should return true when command is valid" do
-      expect(Gitlab::CLI::Helpers.valid_command? 'merge_requests').to be_truthy
+    it "returns true when command is valid" do
+      expect(Gitlab::CLI::Helpers.valid_command?('merge_requests')).to be_truthy
     end
-    it "should return false when command is NOT valid" do
-      expect(Gitlab::CLI::Helpers.valid_command? 'mmmmmerge_requests').to be_falsy
+    it "returns false when command is NOT valid" do
+      expect(Gitlab::CLI::Helpers.valid_command?('mmmmmerge_requests')).to be_falsy
     end
   end
 
   describe ".symbolize_keys" do
     context "when input is a Hash" do
-      it "should return a Hash with symbols for keys" do
+      it "returns a Hash with symbols for keys" do
         hash = { 'key1' => 'val1', 'key2' => 'val2' }
         symbolized_hash = Gitlab::CLI::Helpers.symbolize_keys(hash)
         expect(symbolized_hash).to eq(key1: 'val1', key2: 'val2')
       end
     end
     context "when input is NOT a Hash" do
-      it "should return input untouched" do
+      it "returns input untouched" do
         array = [1, 2, 3]
         new_array = Gitlab::CLI::Helpers.symbolize_keys(array)
         expect(new_array).to eq([1, 2, 3])
@@ -40,7 +39,7 @@ describe Gitlab::CLI::Helpers do
 
   describe ".yaml_load" do
     context "when argument is a YAML string" do
-      it "should return Ruby objects" do
+      it "returns Ruby objects" do
         argument = "{foo: bar, sna: fu}"
         output = Gitlab::CLI::Helpers.yaml_load argument
         expect(output).to eq('foo' => 'bar', 'sna' => 'fu')
@@ -48,7 +47,7 @@ describe Gitlab::CLI::Helpers do
     end
 
     context "when input is NOT valid YAML" do
-      it "should raise" do
+      it "raises a TypeError" do
         ruby_array = [1, 2, 3, 4]
         expect { Gitlab::CLI::Helpers.yaml_load ruby_array }.to raise_error TypeError
       end

data/spec/gitlab/cli_spec.rb

@@ -4,14 +4,14 @@ require 'json'
 describe Gitlab::CLI do
   describe ".run" do
     context "when command is version" do
-      it "should show gem version" do
+      it "shows gem version" do
         output = capture_output { Gitlab::CLI.run('-v') }
         expect(output).to eq("Gitlab Ruby Gem #{Gitlab::VERSION}\n")
       end
     end
 
     context "when command is info" do
-      it "should show environment info" do
+      it "shows environment info" do
         output = capture_output { Gitlab::CLI.run('info') }
         expect(output).to include("Gitlab endpoint is")
         expect(output).to include("Gitlab private token is")
@@ -21,7 +21,7 @@ describe Gitlab::CLI do
     end
 
     context "when command is help" do
-      it "should show available actions" do
+      it "shows available actions" do
         output = capture_output { Gitlab::CLI.run('help') }
         expect(output).to include('Help Topics')
         expect(output).to include('MergeRequests')
@@ -34,11 +34,11 @@ describe Gitlab::CLI do
         @output = capture_output { Gitlab::CLI.run('user') }
       end
 
-      it "should show executed command" do
+      it "shows executed command" do
         expect(@output).to include('Gitlab.user')
       end
 
-      it "should show user data" do
+      it "shows user data" do
         expect(@output).to include('name')
         expect(@output).to include('John Smith')
       end
@@ -50,11 +50,11 @@ describe Gitlab::CLI do
         @output = capture_output { Gitlab::CLI.run('users') }
       end
 
-      it "should show executed command" do
+      it "shows executed command" do
         expect(@output).to include('Gitlab.users')
       end
 
-      it "should show users data" do
+      it "shows users data" do
         expect(@output).to include('name')
         expect(@output).to include('John Smith')
         expect(@output).to include('Jack Smith')
@@ -70,7 +70,7 @@ describe Gitlab::CLI do
         @output = capture_output { Gitlab::CLI.start(args) }
       end
 
-      it "should show user data with excluded fields" do
+      it "shows user data with excluded fields" do
         expect(@output).to_not include('John Smith')
         expect(@output).to include('bio')
         expect(@output).to include('created_at')
@@ -84,7 +84,7 @@ describe Gitlab::CLI do
         @output = capture_output { Gitlab::CLI.start(args) }
       end
 
-      it "should render output as json" do
+      it "renders output as json" do
         expect(JSON.parse(@output)['result']).to eq(JSON.parse(File.read(File.dirname(__FILE__) + '/../fixtures/user.json')))
         expect(JSON.parse(@output)['cmd']).to eq('Gitlab.user')
       end
@@ -97,7 +97,7 @@ describe Gitlab::CLI do
         @output = capture_output { Gitlab::CLI.start(args) }
       end
 
-      it "should show user data with required fields" do
+      it "shows user data with required fields" do
         expect(@output).to include('id')
         expect(@output).to include('name')
         expect(@output).to include('email')
@@ -108,7 +108,7 @@ describe Gitlab::CLI do
     end
 
     context "fetch project with namespace/repo" do
-      it "should encode delimiter" do
+      it "encodes delimiter" do
         stub_get("/projects/gitlab-org%2Fgitlab-ce", "project")
         args = ['project', 'gitlab-org/gitlab-ce']
         @output = capture_output { Gitlab::CLI.start(args) }

data/spec/gitlab/client/award_emojis_spec.rb

@@ -5,14 +5,14 @@ describe Gitlab::Client do
     context 'when issue award emojis' do
       before do
         stub_get("/projects/1/issues/80/award_emoji", "issue_award_emojis")
-        @emojis = Gitlab.award_emojis(1, 80, 'issue') 
+        @emojis = Gitlab.award_emojis(1, 80, 'issue')
       end
 
-      it "should get the correct resources" do
+      it "gets the correct resources" do
         expect(a_get("/projects/1/issues/80/award_emoji")).to have_been_made
       end
 
-      it "should return a paginated response of issue award emojis" do
+      it "returns a paginated response of issue award emojis" do
         expect(@emojis).to be_a Gitlab::PaginatedResponse
         expect(@emojis.first.awardable_id).to eq(80)
         expect(@emojis.first.awardable_type).to eq("Issue")
@@ -22,14 +22,14 @@ describe Gitlab::Client do
     context 'when merge request award emojis' do
       before do
         stub_get("/projects/1/merge_requests/80/award_emoji", "merge_request_award_emojis")
-        @emojis = Gitlab.award_emojis(1, 80, 'merge_request') 
+        @emojis = Gitlab.award_emojis(1, 80, 'merge_request')
       end
 
-      it "should get the correct resources" do
+      it "gets the correct resources" do
         expect(a_get("/projects/1/merge_requests/80/award_emoji")).to have_been_made
       end
 
-      it "should return a paginated response of merge request award emojis" do
+      it "returns a paginated response of merge request award emojis" do
         expect(@emojis).to be_a Gitlab::PaginatedResponse
         expect(@emojis.first.awardable_id).to eq(80)
         expect(@emojis.first.awardable_type).to eq("MergeRequest")
@@ -39,14 +39,14 @@ describe Gitlab::Client do
     context 'when snippet award emojis' do
       before do
         stub_get("/projects/1/snippets/80/award_emoji", "snippet_award_emojis")
-        @emojis = Gitlab.award_emojis(1, 80, 'snippet') 
+        @emojis = Gitlab.award_emojis(1, 80, 'snippet')
       end
 
-      it "should get the correct resources" do
+      it "gets the correct resources" do
         expect(a_get("/projects/1/snippets/80/award_emoji")).to have_been_made
       end
 
-      it "should return a paginated response of snippet award emojis" do
+      it "returns a paginated response of snippet award emojis" do
         expect(@emojis).to be_a Gitlab::PaginatedResponse
         expect(@emojis.first.awardable_id).to eq(80)
         expect(@emojis.first.awardable_type).to eq("Snippet")
@@ -58,14 +58,14 @@ describe Gitlab::Client do
     context 'when issue note award emojis' do
       before do
         stub_get("/projects/1/issues/80/notes/1/award_emoji", "note_award_emojis")
-        @note_emojis = Gitlab.note_award_emojis(1, 80, 'issue', 1) 
+        @note_emojis = Gitlab.note_award_emojis(1, 80, 'issue', 1)
       end
 
-      it "should get the correct resources" do
+      it "gets the correct resources" do
         expect(a_get("/projects/1/issues/80/notes/1/award_emoji")).to have_been_made
       end
 
-      it "should return a paginated response of issue note award emojis" do
+      it "returns a paginated response of issue note award emojis" do
         expect(@note_emojis).to be_a Gitlab::PaginatedResponse
         expect(@note_emojis.first.awardable_id).to eq(1)
         expect(@note_emojis.first.awardable_type).to eq("Note")
@@ -75,14 +75,14 @@ describe Gitlab::Client do
     context 'when merge request note award emojis' do
       before do
         stub_get("/projects/1/merge_requests/80/notes/1/award_emoji", "note_award_emojis")
-        @note_emojis = Gitlab.note_award_emojis(1, 80, 'merge_request', 1) 
+        @note_emojis = Gitlab.note_award_emojis(1, 80, 'merge_request', 1)
       end
 
-      it "should get the correct resources" do
+      it "gets the correct resources" do
         expect(a_get("/projects/1/merge_requests/80/notes/1/award_emoji")).to have_been_made
       end
 
-      it "should return a paginated response of merge request note award emojis" do
+      it "returns a paginated response of merge request note award emojis" do
         expect(@note_emojis).to be_a Gitlab::PaginatedResponse
         expect(@note_emojis.first.awardable_id).to eq(1)
         expect(@note_emojis.first.awardable_type).to eq("Note")
@@ -92,14 +92,14 @@ describe Gitlab::Client do
     context 'when snippet note award emojis' do
       before do
         stub_get("/projects/1/snippets/80/notes/1/award_emoji", "note_award_emojis")
-        @note_emojis = Gitlab.note_award_emojis(1, 80, 'snippet', 1) 
+        @note_emojis = Gitlab.note_award_emojis(1, 80, 'snippet', 1)
       end
 
-      it "should get the correct resources" do
+      it "gets the correct resources" do
         expect(a_get("/projects/1/snippets/80/notes/1/award_emoji")).to have_been_made
       end
 
-      it "should return a paginated response of snippet note award emojis" do
+      it "returns a paginated response of snippet note award emojis" do
         expect(@note_emojis).to be_a Gitlab::PaginatedResponse
         expect(@note_emojis.first.awardable_id).to eq(1)
         expect(@note_emojis.first.awardable_type).to eq("Note")
@@ -111,14 +111,14 @@ describe Gitlab::Client do
     context 'when issue award emoji' do
       before do
         stub_get("/projects/1/issues/80/award_emoji/4", "issue_award_emoji")
-        @emoji = Gitlab.award_emoji(1, 80, 'issue', 4) 
+        @emoji = Gitlab.award_emoji(1, 80, 'issue', 4)
       end
 
-      it "should get the correct resource" do
+      it "gets the correct resource" do
         expect(a_get("/projects/1/issues/80/award_emoji/4")).to have_been_made
       end
 
-      it "should return information about an issue award emoji" do
+      it "returns information about an issue award emoji" do
         expect(@emoji.id).to eq(4)
         expect(@emoji.awardable_type).to eq("Issue")
         expect(@emoji.awardable_id).to eq(80)
@@ -128,14 +128,14 @@ describe Gitlab::Client do
     context 'when merge request award emoji' do
       before do
         stub_get("/projects/1/merge_requests/80/award_emoji/4", "merge_request_award_emoji")
-        @emoji = Gitlab.award_emoji(1, 80, 'merge_request', 4) 
+        @emoji = Gitlab.award_emoji(1, 80, 'merge_request', 4)
       end
 
-      it "should get the correct resource" do
+      it "gets the correct resource" do
         expect(a_get("/projects/1/merge_requests/80/award_emoji/4")).to have_been_made
       end
 
-      it "should return information about a merge request award emoji" do
+      it "returns information about a merge request award emoji" do
         expect(@emoji.id).to eq(4)
         expect(@emoji.awardable_type).to eq("MergeRequest")
         expect(@emoji.awardable_id).to eq(80)
@@ -145,14 +145,14 @@ describe Gitlab::Client do
     context 'when snippet award emoji' do
       before do
         stub_get("/projects/1/snippets/80/award_emoji/4", "snippet_award_emoji")
-        @emoji = Gitlab.award_emoji(1, 80, 'snippet', 4) 
+        @emoji = Gitlab.award_emoji(1, 80, 'snippet', 4)
       end
 
-      it "should get the correct resource" do
+      it "gets the correct resource" do
         expect(a_get("/projects/1/snippets/80/award_emoji/4")).to have_been_made
       end
 
-      it "should return information about a snippet award emoji" do
+      it "returns information about a snippet award emoji" do
         expect(@emoji.id).to eq(4)
         expect(@emoji.awardable_type).to eq("Snippet")
         expect(@emoji.awardable_id).to eq(80)
@@ -164,14 +164,14 @@ describe Gitlab::Client do
     context 'when issue note award emoji' do
       before do
         stub_get("/projects/1/issues/80/notes/1/award_emoji/4", "note_award_emoji")
-        @note_emoji = Gitlab.note_award_emoji(1, 80, 'issue', 1, 4) 
+        @note_emoji = Gitlab.note_award_emoji(1, 80, 'issue', 1, 4)
       end
 
-      it "should get the correct resource" do
+      it "gets the correct resource" do
         expect(a_get("/projects/1/issues/80/notes/1/award_emoji/4")).to have_been_made
       end
 
-      it "should return information about an issue note award emoji" do
+      it "returns information about an issue note award emoji" do
         expect(@note_emoji.id).to eq(4)
         expect(@note_emoji.awardable_type).to eq("Note")
         expect(@note_emoji.awardable_id).to eq(1)
@@ -181,14 +181,14 @@ describe Gitlab::Client do
     context 'when merge request note award emoji' do
       before do
         stub_get("/projects/1/merge_requests/80/notes/1/award_emoji/4", "note_award_emoji")
-        @note_emoji = Gitlab.note_award_emoji(1, 80, 'merge_request', 1, 4) 
+        @note_emoji = Gitlab.note_award_emoji(1, 80, 'merge_request', 1, 4)
       end
 
-      it "should get the correct resource" do
+      it "gets the correct resource" do
         expect(a_get("/projects/1/merge_requests/80/notes/1/award_emoji/4")).to have_been_made
       end
 
-      it "should return information about a merge request note award emoji" do
+      it "returns information about a merge request note award emoji" do
         expect(@note_emoji.id).to eq(4)
         expect(@note_emoji.awardable_type).to eq("Note")
         expect(@note_emoji.awardable_id).to eq(1)
@@ -198,14 +198,14 @@ describe Gitlab::Client do
     context 'when snippet note award emoji' do
       before do
         stub_get("/projects/1/snippets/80/notes/1/award_emoji/4", "note_award_emoji")
-        @note_emoji = Gitlab.note_award_emoji(1, 80, 'snippet', 1, 4) 
+        @note_emoji = Gitlab.note_award_emoji(1, 80, 'snippet', 1, 4)
       end
 
-      it "should get the correct resource" do
+      it "gets the correct resource" do
         expect(a_get("/projects/1/snippets/80/notes/1/award_emoji/4")).to have_been_made
       end
 
-      it "should return information about a snippet note award emoji" do
+      it "returns information about a snippet note award emoji" do
         expect(@note_emoji.id).to eq(4)
         expect(@note_emoji.awardable_type).to eq("Note")
         expect(@note_emoji.awardable_id).to eq(1)
@@ -220,12 +220,12 @@ describe Gitlab::Client do
         @emoji = Gitlab.create_award_emoji(1, 80, "issue", "blowfish")
       end
 
-      it "should get the correct resource" do
+      it "gets the correct resource" do
         expect(a_post("/projects/1/issues/80/award_emoji").
           with(body: { name: 'blowfish' })).to have_been_made
       end
 
-      it "should return correct information about the created issue award emoji" do
+      it "returns correct information about the created issue award emoji" do
         expect(@emoji.name).to eq('blowfish')
         expect(@emoji.awardable_type).to eq('Issue')
       end
@@ -237,12 +237,12 @@ describe Gitlab::Client do
         @emoji = Gitlab.create_award_emoji(1, 80, "merge_request", "blowfish")
       end
 
-      it "should get the correct resource" do
+      it "gets the correct resource" do
         expect(a_post("/projects/1/merge_requests/80/award_emoji").
           with(body: { name: 'blowfish' })).to have_been_made
       end
 
-      it "should return correct information about the created merge request award emoji" do
+      it "returns correct information about the created merge request award emoji" do
         expect(@emoji.name).to eq('blowfish')
         expect(@emoji.awardable_type).to eq('MergeRequest')
       end
@@ -254,12 +254,12 @@ describe Gitlab::Client do
         @emoji = Gitlab.create_award_emoji(1, 80, "snippet", "blowfish")
       end
 
-      it "should get the correct resource" do
+      it "gets the correct resource" do
         expect(a_post("/projects/1/snippets/80/award_emoji").
           with(body: { name: 'blowfish' })).to have_been_made
       end
 
-      it "should return correct information about the created snippet award emoji" do
+      it "returns correct information about the created snippet award emoji" do
         expect(@emoji.name).to eq('blowfish')
         expect(@emoji.awardable_type).to eq('Snippet')
       end
@@ -273,12 +273,12 @@ describe Gitlab::Client do
         @note_emoji = Gitlab.create_note_award_emoji(1, 80, "issue", 1, "mood_bubble_lightning")
       end
 
-      it "should get the correct resource" do
+      it "gets the correct resource" do
         expect(a_post("/projects/1/issues/80/notes/1/award_emoji").
           with(body: { name: 'mood_bubble_lightning' })).to have_been_made
       end
 
-      it "should return correct information about the created issue note award emoji" do
+      it "returns correct information about the created issue note award emoji" do
         expect(@note_emoji.name).to eq('mood_bubble_lightning')
         expect(@note_emoji.awardable_type).to eq('Note')
       end
@@ -290,12 +290,12 @@ describe Gitlab::Client do
         @note_emoji = Gitlab.create_note_award_emoji(1, 80, "merge_request", 1, "mood_bubble_lightning")
       end
 
-      it "should get the correct resource" do
+      it "gets the correct resource" do
         expect(a_post("/projects/1/merge_requests/80/notes/1/award_emoji").
           with(body: { name: 'mood_bubble_lightning' })).to have_been_made
       end
 
-      it "should return correct information about the created merge request note award emoji" do
+      it "returns correct information about the created merge request note award emoji" do
         expect(@note_emoji.name).to eq('mood_bubble_lightning')
         expect(@note_emoji.awardable_type).to eq('Note')
       end
@@ -307,12 +307,12 @@ describe Gitlab::Client do
         @note_emoji = Gitlab.create_note_award_emoji(1, 80, "snippet", 1, "mood_bubble_lightning")
       end
 
-      it "should get the correct resource" do
+      it "gets the correct resource" do
         expect(a_post("/projects/1/snippets/80/notes/1/award_emoji").
           with(body: { name: 'mood_bubble_lightning' })).to have_been_made
       end
 
-      it "should return correct information about the created snippet note award emoji" do
+      it "returns correct information about the created snippet note award emoji" do
         expect(@note_emoji.name).to eq('mood_bubble_lightning')
         expect(@note_emoji.awardable_type).to eq('Note')
       end
@@ -326,7 +326,7 @@ describe Gitlab::Client do
         @emoji = Gitlab.delete_award_emoji(1, 80, "issue", 4)
       end
 
-      it "should get the correct resource" do
+      it "gets the correct resource" do
         expect(a_delete("/projects/1/issues/80/award_emoji/4")).to have_been_made
       end
     end
@@ -337,7 +337,7 @@ describe Gitlab::Client do
         @emoji = Gitlab.delete_award_emoji(1, 80, "merge_request", 4)
       end
 
-      it "should get the correct resource" do
+      it "gets the correct resource" do
         expect(a_delete("/projects/1/merge_requests/80/award_emoji/4")).to have_been_made
       end
     end
@@ -348,7 +348,7 @@ describe Gitlab::Client do
         @emoji = Gitlab.delete_award_emoji(1, 80, "snippet", 4)
       end
 
-      it "should get the correct resource" do
+      it "gets the correct resource" do
         expect(a_delete("/projects/1/snippets/80/award_emoji/4")).to have_been_made
       end
     end
@@ -361,7 +361,7 @@ describe Gitlab::Client do
         @note_emoji = Gitlab.delete_note_award_emoji(1, 80, "issue", 1, 4)
       end
 
-      it "should get the correct resource" do
+      it "gets the correct resource" do
         expect(a_delete("/projects/1/issues/80/notes/1/award_emoji/4")).to have_been_made
       end
     end
@@ -372,7 +372,7 @@ describe Gitlab::Client do
         @note_emoji = Gitlab.delete_note_award_emoji(1, 80, "merge_request", 1, 4)
       end
 
-      it "should get the correct resource" do
+      it "gets the correct resource" do
         expect(a_delete("/projects/1/merge_requests/80/notes/1/award_emoji/4")).to have_been_made
       end
     end
@@ -383,9 +383,9 @@ describe Gitlab::Client do
         @note_emoji = Gitlab.delete_note_award_emoji(1, 80, "snippet", 1, 4)
       end
 
-      it "should get the correct resource" do
+      it "gets the correct resource" do
         expect(a_delete("/projects/1/snippets/80/notes/1/award_emoji/4")).to have_been_made
       end
     end
   end
-end
+end