gitlab 4.2.0 → 4.3.0

data/spec/gitlab/client/repositories_spec.rb

@@ -1,12 +1,12 @@
 require 'spec_helper'
 
 describe Gitlab::Client do
-  it { should respond_to :repo_tags }
-  it { should respond_to :repo_create_tag }
-  it { should respond_to :repo_branches }
-  it { should respond_to :repo_branch }
-  it { should respond_to :repo_tree }
-  it { should respond_to :repo_compare }
+  it { is_expected.to respond_to :repo_tags }
+  it { is_expected.to respond_to :repo_create_tag }
+  it { is_expected.to respond_to :repo_branches }
+  it { is_expected.to respond_to :repo_branch }
+  it { is_expected.to respond_to :repo_tree }
+  it { is_expected.to respond_to :repo_compare }
 
   describe ".tags" do
     before do
@@ -14,11 +14,11 @@ describe Gitlab::Client do
       @tags = Gitlab.tags(3)
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_get("/projects/3/repository/tags")).to have_been_made
     end
 
-    it "should return a paginated response of repository tags" do
+    it "returns a paginated response of repository tags" do
       expect(@tags).to be_a Gitlab::PaginatedResponse
       expect(@tags.first.name).to eq("v2.8.2")
     end
@@ -31,11 +31,11 @@ describe Gitlab::Client do
         @tag = Gitlab.create_tag(3, 'v1.0.0', '2695effb5807a22ff3d138d593fd856244e155e7')
       end
 
-      it "should get the correct resource" do
+      it "gets the correct resource" do
         expect(a_post("/projects/3/repository/tags")).to have_been_made
       end
 
-      it "should return information about a new repository tag" do
+      it "returns information about a new repository tag" do
         expect(@tag.name).to eq("v1.0.0")
         expect(@tag.message).to eq(nil)
       end
@@ -47,11 +47,11 @@ describe Gitlab::Client do
         @tag = Gitlab.create_tag(3, 'v1.1.0', '2695effb5807a22ff3d138d593fd856244e155e7', 'Release 1.1.0')
       end
 
-      it "should get the correct resource" do
+      it "gets the correct resource" do
         expect(a_post("/projects/3/repository/tags")).to have_been_made
       end
 
-      it "should return information about a new repository tag" do
+      it "returns information about a new repository tag" do
         expect(@tag.name).to eq("v1.1.0")
         expect(@tag.message).to eq("Release 1.1.0")
       end
@@ -64,11 +64,11 @@ describe Gitlab::Client do
       @tree = Gitlab.tree(3)
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_get("/projects/3/repository/tree")).to have_been_made
     end
 
-    it "should return a paginated response of repository tree files (root level)" do
+    it "returns a paginated response of repository tree files (root level)" do
       expect(@tree).to be_a Gitlab::PaginatedResponse
       expect(@tree.first.name).to eq("app")
     end
@@ -81,12 +81,12 @@ describe Gitlab::Client do
       @diff = Gitlab.compare(3, 'master', 'feature')
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_get("/projects/3/repository/compare").
         with(query: { from: "master", to: "feature" })).to have_been_made
     end
 
-    it "should get diffs of a merge request" do
+    it "gets diffs of a merge request" do
       expect(@diff.diffs).to be_kind_of Array
       expect(@diff.diffs.last["new_path"]).to eq "files/js/application.js"
     end

data/spec/gitlab/client/repository_files_spec.rb

@@ -7,11 +7,11 @@ describe Gitlab::Client do
       @file_contents = Gitlab.file_contents(3, "Gemfile")
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_get("/projects/3/repository/files/Gemfile/raw?ref=master")).to have_been_made
     end
 
-    it "should return file contents" do
+    it "returns file contents" do
       expect(@file_contents).to eq("source 'https://rubygems.org'\ngem 'rails', '4.1.2'\n")
     end
   end
@@ -22,11 +22,11 @@ describe Gitlab::Client do
       @file = Gitlab.get_file(3, 'README.md', 'master')
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_get("/projects/3/repository/files/README%2Emd?ref=master")).to have_been_made
     end
 
-    it "should return the base64 encoded file" do
+    it "returns the base64 encoded file" do
       expect(@file.file_path).to eq "README.md"
       expect(@file.ref).to eq "master"
       expect(@file.content).to eq "VGhpcyBpcyBhICpSRUFETUUqIQ==\n"
@@ -38,7 +38,7 @@ describe Gitlab::Client do
     let!(:request_stub) { stub_post(api_path, "repository_file") }
     let!(:file) { Gitlab.create_file(3, "path", "branch", "content", "commit message", author_name: "joe") }
 
-    it "should create the correct resource" do
+    it "creates the correct resource" do
       expected_parameters = {
         author_name: "joe",
         branch: "branch",
@@ -47,7 +47,7 @@ describe Gitlab::Client do
       expect(a_post(api_path).with(body: hash_including(expected_parameters))).to have_been_made
     end
 
-    it "should return information about the new file" do
+    it "returns information about the new file" do
       expect(file.file_path).to eq "path"
       expect(file.branch_name).to eq "branch"
     end
@@ -58,7 +58,7 @@ describe Gitlab::Client do
     let!(:request_stub) { stub_put(api_path, "repository_file") }
     let!(:file) { Gitlab.edit_file(3, "path", "branch", "content", "commit message", author_name: "joe") }
 
-    it "should update the correct resource" do
+    it "updates the correct resource" do
       expected_parameters = {
         author_name: "joe",
         branch: "branch",
@@ -67,7 +67,7 @@ describe Gitlab::Client do
       expect(a_put(api_path).with(body: hash_including(expected_parameters))).to have_been_made
     end
 
-    it "should return information about the new file" do
+    it "returns information about the new file" do
       expect(file.file_path).to eq "path"
       expect(file.branch_name).to eq "branch"
     end
@@ -78,7 +78,7 @@ describe Gitlab::Client do
     let!(:request_stub) { stub_delete(api_path, "repository_file") }
     let!(:file) { Gitlab.remove_file(3, "path", "branch", "commit message", author_name: "joe") }
 
-    it "should update the correct resource" do
+    it "updates the correct resource" do
       expected_parameters = {
         author_name: "joe",
         branch: "branch",
@@ -87,7 +87,7 @@ describe Gitlab::Client do
       expect(a_delete(api_path).with(body: hash_including(expected_parameters))).to have_been_made
     end
 
-    it "should return information about the new file" do
+    it "returns information about the new file" do
       expect(file.file_path).to eq "path"
       expect(file.branch_name).to eq "branch"
     end

data/spec/gitlab/client/runners_spec.rb

@@ -12,11 +12,11 @@ describe Gitlab::Client do
         @runner = Gitlab.runners
       end
 
-      it "should get the correct resource" do
+      it "gets the correct resource" do
         expect(a_get("/runners")).to have_been_made
       end
 
-      it "should return a paginated response of runners" do
+      it "returns a paginated response of runners" do
         expect(@runner).to be_a Gitlab::PaginatedResponse
         expect(@runner.first.id).to eq(6)
         expect(@runner.first.description).to eq('test-1-20150125')
@@ -29,11 +29,11 @@ describe Gitlab::Client do
         @runner = Gitlab.runners({scope: :online})
       end
 
-      it "should get the correct resource" do
+      it "gets the correct resource" do
         expect(a_get("/runners").with(query: { scope: :online })).to have_been_made
       end
 
-      it "should return a paginated response of runners" do
+      it "returns a paginated response of runners" do
         expect(@runner).to be_a Gitlab::PaginatedResponse
         expect(@runner.first.id).to eq(6)
         expect(@runner.first.description).to eq('test-1-20150125')
@@ -52,11 +52,11 @@ describe Gitlab::Client do
         @runner = Gitlab.all_runners
       end
 
-      it "should get the correct resource" do
+      it "gets the correct resource" do
         expect(a_get("/runners/all")).to have_been_made
       end
 
-      it "should return a paginated response of runners" do
+      it "returns a paginated response of runners" do
         expect(@runner).to be_a Gitlab::PaginatedResponse
         expect(@runner.first.id).to eq(6)
         expect(@runner.first.description).to eq('test-1-20150125')
@@ -69,11 +69,11 @@ describe Gitlab::Client do
         @runner = Gitlab.all_runners({scope: :online})
       end
 
-      it "should get the correct resource" do
+      it "gets the correct resource" do
         expect(a_get("/runners/all").with(query: { scope: :online })).to have_been_made
       end
 
-      it "should return a paginated response of runners" do
+      it "returns a paginated response of runners" do
         expect(@runner).to be_a Gitlab::PaginatedResponse
         expect(@runner.first.id).to eq(6)
         expect(@runner.first.description).to eq('test-1-20150125')
@@ -87,11 +87,11 @@ describe Gitlab::Client do
       @runners = Gitlab.runner(6)
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_get("/runners/6")).to have_been_made
     end
 
-    it "should return a response of a runner" do
+    it "returns a response of a runner" do
       expect(@runners).to be_a Gitlab::ObjectifiedHash
       expect(@runners.id).to eq(6)
       expect(@runners.description).to eq('test-1-20150125')
@@ -104,11 +104,11 @@ describe Gitlab::Client do
       @runner = Gitlab.update_runner(6, description: "abcefg" )
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_put("/runners/6").with(query: { description: "abcefg" })).to have_been_made
     end
 
-    it "should return an updated response of a runner" do
+    it "returns an updated response of a runner" do
       expect(@runner).to be_a Gitlab::ObjectifiedHash
       expect(@runner.description).to eq('abcefg')
     end
@@ -120,11 +120,11 @@ describe Gitlab::Client do
       @runner = Gitlab.delete_runner(6)
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_delete("/runners/6")).to have_been_made
     end
 
-    it "should return a response of the deleted runner" do
+    it "returns a response of the deleted runner" do
       expect(@runner).to be_a Gitlab::ObjectifiedHash
       expect(@runner.id).to eq(6)
     end
@@ -136,11 +136,11 @@ describe Gitlab::Client do
       @runners = Gitlab.project_runners(1)
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_get("/projects/1/runners")).to have_been_made
     end
 
-    it "should return a paginated response of runners" do
+    it "returns a paginated response of runners" do
       expect(@runners).to be_a Gitlab::PaginatedResponse
       expect(@runners.first.id).to eq(8)
       expect(@runners.first.description).to eq('test-2-20150125')
@@ -153,11 +153,11 @@ describe Gitlab::Client do
       @runner = Gitlab.project_enable_runner(1, 6)
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_post("/projects/1/runners")).to have_been_made
     end
 
-    it "should return a response of the enabled runner" do
+    it "returns a response of the enabled runner" do
       expect(@runner).to be_a Gitlab::ObjectifiedHash
       expect(@runner.id).to eq(6)
       expect(@runner.description).to eq('test-1-20150125')
@@ -170,16 +170,14 @@ describe Gitlab::Client do
       @runner = Gitlab.project_disable_runner(1, 6)
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_delete("/projects/1/runners/6")).to have_been_made
     end
 
-    it "should return a response of the disabled runner" do
+    it "returns a response of the disabled runner" do
       expect(@runner).to be_a Gitlab::ObjectifiedHash
       expect(@runner.id).to eq(6)
       expect(@runner.description).to eq('test-1-20150125')
     end
   end
-
-
 end

data/spec/gitlab/client/services_spec.rb

@@ -7,11 +7,11 @@ describe Gitlab::Client do
       @service = Gitlab.service(3, :redmine)
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_get("/projects/3/services/redmine")).to have_been_made
     end
 
-    it "should return a information about a service of project" do
+    it "returns a information about a service of project" do
       expect(@service.id).to eq 38
       expect(@service.title).to eq("Redmine")
       expect(@service.properties.project_url).to eq("https://example.com/projects/test_project/issue")
@@ -26,14 +26,14 @@ describe Gitlab::Client do
                                                     issues_url: 'https://example.com/issues/:id')
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       body = {new_issue_url: 'https://example.com/projects/test_project/issues/new',
               project_url: 'https://example.com/projects/test_project/issues',
               issues_url: 'https://example.com/issues/:id'}
       expect(a_put("/projects/3/services/redmine").with(body: body)).to have_been_made
     end
 
-    it "should return information about a new service" do
+    it "returns information about a new service" do
       expect(@service).to be_truthy
     end
   end
@@ -44,11 +44,11 @@ describe Gitlab::Client do
       @service = Gitlab.delete_service(3, :redmine)
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_delete("/projects/3/services/redmine")).to have_been_made
     end
 
-    it "should return information about a deleted service" do
+    it "returns information about a deleted service" do
       expect(@service).to be_truthy
     end
   end

data/spec/gitlab/client/snippets_spec.rb

@@ -7,11 +7,11 @@ describe Gitlab::Client do
       @snippets = Gitlab.snippets(3)
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_get("/projects/3/snippets")).to have_been_made
     end
 
-    it "should return a paginated response of project's snippets" do
+    it "returns a paginated response of project's snippets" do
       expect(@snippets).to be_a Gitlab::PaginatedResponse
       expect(@snippets.first.file_name).to eq("mailer_test.rb")
     end
@@ -23,11 +23,11 @@ describe Gitlab::Client do
       @snippet = Gitlab.snippet(3, 1)
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_get("/projects/3/snippets/1")).to have_been_made
     end
 
-    it "should return information about a snippet" do
+    it "returns information about a snippet" do
       expect(@snippet.file_name).to eq("mailer_test.rb")
       expect(@snippet.author.name).to eq("John Smith")
     end
@@ -39,12 +39,12 @@ describe Gitlab::Client do
       @snippet = Gitlab.create_snippet(3, title: 'API', file_name: 'api.rb', code: 'code')
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       body = { title: 'API', file_name: 'api.rb', code: 'code' }
       expect(a_post("/projects/3/snippets").with(body: body)).to have_been_made
     end
 
-    it "should return information about a new snippet" do
+    it "returns information about a new snippet" do
       expect(@snippet.file_name).to eq("mailer_test.rb")
       expect(@snippet.author.name).to eq("John Smith")
     end
@@ -56,12 +56,12 @@ describe Gitlab::Client do
       @snippet = Gitlab.edit_snippet(3, 1, file_name: 'mailer_test.rb')
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_put("/projects/3/snippets/1").
         with(body: { file_name: 'mailer_test.rb' })).to have_been_made
     end
 
-    it "should return information about an edited snippet" do
+    it "returns information about an edited snippet" do
       expect(@snippet.file_name).to eq("mailer_test.rb")
       expect(@snippet.author.name).to eq("John Smith")
     end
@@ -73,11 +73,11 @@ describe Gitlab::Client do
       @snippet = Gitlab.delete_snippet(3, 1)
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_delete("/projects/3/snippets/1")).to have_been_made
     end
 
-    it "should return information about a deleted snippet" do
+    it "returns information about a deleted snippet" do
       expect(@snippet.file_name).to eq("mailer_test.rb")
       expect(@snippet.author.name).to eq("John Smith")
     end
@@ -89,11 +89,11 @@ describe Gitlab::Client do
       @snippet_content = Gitlab.snippet_content(3, 1)
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_get("/projects/3/snippets/1/raw")).to have_been_made
     end
 
-    it "should return raw content of a snippet" do
+    it "returns raw content of a snippet" do
       expect(@snippet_content).to eq("#!/usr/bin/env ruby\n\nputs \"Cool snippet!\"\n")
     end
   end

data/spec/gitlab/client/system_hooks_spec.rb

@@ -1,10 +1,10 @@
 require 'spec_helper'
 
 describe Gitlab::Client do
-  it { should respond_to :system_hooks }
-  it { should respond_to :add_system_hook }
-  it { should respond_to :system_hook }
-  it { should respond_to :delete_system_hook }
+  it { is_expected.to respond_to :system_hooks }
+  it { is_expected.to respond_to :add_system_hook }
+  it { is_expected.to respond_to :system_hook }
+  it { is_expected.to respond_to :delete_system_hook }
 
   describe ".hooks" do
     before do
@@ -12,11 +12,11 @@ describe Gitlab::Client do
       @hooks = Gitlab.hooks
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_get("/hooks")).to have_been_made
     end
 
-    it "should return a paginated response of system hooks" do
+    it "returns a paginated response of system hooks" do
       expect(@hooks).to be_a Gitlab::PaginatedResponse
       expect(@hooks.first.url).to eq("http://example.com/hook")
     end
@@ -28,11 +28,11 @@ describe Gitlab::Client do
       @hook = Gitlab.add_hook("http://example.com/hook", token: 'secret-token')
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_post("/hooks").with(body: hash_including(token: 'secret-token'))).to have_been_made
     end
 
-    it "should return information about a added system hook" do
+    it "returns information about a added system hook" do
       expect(@hook.url).to eq("http://example.com/hook")
     end
   end
@@ -43,11 +43,11 @@ describe Gitlab::Client do
       @hook = Gitlab.hook(3)
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_get("/hooks/3")).to have_been_made
     end
 
-    it "should return information about a added system hook" do
+    it "returns information about a added system hook" do
       expect(@hook.url).to eq("http://example.com/hook")
     end
   end
@@ -58,11 +58,11 @@ describe Gitlab::Client do
       @hook = Gitlab.delete_hook(3)
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_delete("/hooks/3")).to have_been_made
     end
 
-    it "should return information about a deleted system hook" do
+    it "returns information about a deleted system hook" do
       expect(@hook.url).to eq("http://example.com/hook")
     end
   end