gitlab 4.2.0 → 4.3.0

data/spec/gitlab/client/boards_spec.rb

@@ -7,11 +7,11 @@ describe Gitlab::Client do
       @boards = Gitlab.boards(3)
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_get("/projects/3/boards")).to have_been_made
     end
 
-    it "should return a paginated response of project's boards" do
+    it "returns a paginated response of project's boards" do
       expect(@boards).to be_a Gitlab::PaginatedResponse
     end
   end
@@ -22,11 +22,11 @@ describe Gitlab::Client do
       @board_lists = Gitlab.board_lists(3, 1)
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_get("/projects/3/boards/1/lists")).to have_been_made
     end
 
-    it "should return a paginated response of board's lists" do
+    it "returns a paginated response of board's lists" do
       expect(@board_lists).to be_a Gitlab::PaginatedResponse
       expect(@board_lists.first.id).to eq(1)
     end
@@ -38,11 +38,11 @@ describe Gitlab::Client do
       @board_list = Gitlab.board_list(3, 1, 1)
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_get("/projects/3/boards/1/lists/1")).to have_been_made
     end
 
-    it "should return information about the list" do
+    it "returns information about the list" do
       expect(@board_list.id).to eq(1)
     end
   end
@@ -53,11 +53,11 @@ describe Gitlab::Client do
       @board_list = Gitlab.create_board_list(3, 1, 4)
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_post("/projects/3/boards/1/lists")).to have_been_made
     end
 
-    it "should return information about a created board" do
+    it "returns information about a created board" do
       expect(@board_list.position).to eq(1)
     end
   end
@@ -68,11 +68,11 @@ describe Gitlab::Client do
       @board_list = Gitlab.edit_board_list(3, 1, 1, 3)
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_put("/projects/3/boards/1/lists/1")).to have_been_made
     end
 
-    it "should return information about an edited board" do
+    it "returns information about an edited board" do
       expect(@board_list.id).to eq(1)
     end
   end
@@ -83,11 +83,11 @@ describe Gitlab::Client do
       @board_list = Gitlab.delete_board_list(3, 1, 1)
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_delete("/projects/3/boards/1/lists/1")).to have_been_made
     end
 
-    it "should return information about the deleted board list" do
+    it "returns information about the deleted board list" do
       expect(@board_list.id).to eq(1)
     end
   end

data/spec/gitlab/client/branches_spec.rb

@@ -1,10 +1,10 @@
 require 'spec_helper'
 
 describe Gitlab::Client do
-  it { should respond_to :repo_branches }
-  it { should respond_to :repo_branch }
-  it { should respond_to :repo_protect_branch }
-  it { should respond_to :repo_unprotect_branch }
+  it { is_expected.to respond_to :repo_branches }
+  it { is_expected.to respond_to :repo_branch }
+  it { is_expected.to respond_to :repo_protect_branch }
+  it { is_expected.to respond_to :repo_unprotect_branch }
 
   describe ".branches" do
     before do
@@ -12,11 +12,11 @@ describe Gitlab::Client do
       @branches = Gitlab.branches(3)
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_get("/projects/3/repository/branches")).to have_been_made
     end
 
-    it "should return a paginated response of repository branches" do
+    it "returns a paginated response of repository branches" do
       expect(@branches).to be_a Gitlab::PaginatedResponse
       expect(@branches.first.name).to eq("api")
     end
@@ -28,18 +28,18 @@ describe Gitlab::Client do
       @branch = Gitlab.branch(3, "api")
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_get("/projects/3/repository/branches/api")).to have_been_made
     end
 
-    it "should return information about a repository branch" do
+    it "returns information about a repository branch" do
       expect(@branch.name).to eq("api")
     end
   end
 
   describe ".protect_branch" do
     before do
-      stub_put("/projects/3/repository/branches/api/protect", "branch")
+      stub_post("/projects/3/protected_branches", "branch")
     end
 
     context "without options" do
@@ -47,11 +47,11 @@ describe Gitlab::Client do
         @branch = Gitlab.protect_branch(3, "api")
       end
 
-      it "should update the correct resource" do
-        expect(a_put("/projects/3/repository/branches/api/protect")).to have_been_made
+      it "updates the correct resource" do
+        expect(a_post("/projects/3/protected_branches")).to have_been_made
       end
 
-      it "should return information about a protected repository branch" do
+      it "returns information about a protected repository branch" do
         expect(@branch.name).to eq("api")
       end
     end
@@ -61,9 +61,9 @@ describe Gitlab::Client do
         @branch = Gitlab.protect_branch(3, "api", developers_can_push: true)
       end
 
-      it "should update the correct resource with the correct options" do
+      it "updates the correct resource with the correct options" do
         expect(
-          a_put("/projects/3/repository/branches/api/protect").with(body: { developers_can_push: 'true' })
+          a_post("/projects/3/protected_branches").with(body: { name: "api", developers_can_push: 'true' })
         ).to have_been_made
       end
     end
@@ -71,15 +71,15 @@ describe Gitlab::Client do
 
   describe ".unprotect_branch" do
     before do
-      stub_put("/projects/3/repository/branches/api/unprotect", "branch")
+      stub_delete("/projects/3/protected_branches/api","branch")
       @branch = Gitlab.unprotect_branch(3, "api")
     end
 
-    it "should get the correct resource" do
-      expect(a_put("/projects/3/repository/branches/api/unprotect")).to have_been_made
+    it "gets the correct resource" do
+      expect(a_delete("/projects/3/protected_branches/api")).to have_been_made
     end
 
-    it "should return information about an unprotected repository branch" do
+    it "returns information about an unprotected repository branch" do
       expect(@branch.name).to eq("api")
     end
   end
@@ -90,11 +90,11 @@ describe Gitlab::Client do
       @branch = Gitlab.create_branch(3, "api", "master")
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_post("/projects/3/repository/branches")).to have_been_made
     end
 
-    it "should return information about a new repository branch" do
+    it "returns information about a new repository branch" do
       expect(@branch.name).to eq("api")
     end
   end
@@ -105,11 +105,11 @@ describe Gitlab::Client do
       @branch = Gitlab.delete_branch(3, "api")
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_delete("/projects/3/repository/branches/api")).to have_been_made
     end
 
-    it "should return information about the deleted repository branch" do
+    it "returns information about the deleted repository branch" do
       expect(@branch.branch_name).to eq("api")
     end
   end

data/spec/gitlab/client/build_variables_spec.rb

@@ -7,11 +7,11 @@ describe Gitlab::Client do
       @variables = Gitlab.variables(3)
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_get("/projects/3/variables")).to have_been_made
     end
 
-    it "should return an array of project's variables" do
+    it "returns an array of project's variables" do
       expect(@variables).to be_a Gitlab::PaginatedResponse
       expect(@variables.first.key).to eq("TEST_VARIABLE_1")
       expect(@variables.first.value).to eq("TEST_1")
@@ -24,11 +24,11 @@ describe Gitlab::Client do
       @variable = Gitlab.variable(3, "VARIABLE")
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_get("/projects/3/variables/VARIABLE")).to have_been_made
     end
 
-    it "should return information about a variable" do
+    it "returns information about a variable" do
       expect(@variable.key).to eq("VARIABLE")
       expect(@variable.value).to eq("the value")
     end
@@ -40,12 +40,12 @@ describe Gitlab::Client do
       @variable = Gitlab.create_variable(3, "NEW_VARIABLE", "new value")
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       body = { key: "NEW_VARIABLE", value: "new value" }
       expect(a_post("/projects/3/variables").with(body: body)).to have_been_made
     end
 
-    it "should return information about a new variable" do
+    it "returns information about a new variable" do
       expect(@variable.key).to eq("VARIABLE")
       expect(@variable.value).to eq("the value")
     end
@@ -57,12 +57,12 @@ describe Gitlab::Client do
       @variable = Gitlab.update_variable(3, "UPD_VARIABLE", "updated value")
     end
 
-    it "should put the correct resource" do
+    it "puts the correct resource" do
       body = { value: "updated value" }
       expect(a_put("/projects/3/variables/UPD_VARIABLE").with(body: body)).to have_been_made
     end
 
-    it "should return information about an updated variable" do
+    it "returns information about an updated variable" do
       expect(@variable.key).to eq("VARIABLE")
       expect(@variable.value).to eq("the value")
     end
@@ -74,11 +74,94 @@ describe Gitlab::Client do
       @variable = Gitlab.remove_variable(3, "DEL_VARIABLE")
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_delete("/projects/3/variables/DEL_VARIABLE")).to have_been_made
     end
 
-    it "should return information about a deleted variable" do
+    it "returns information about a deleted variable" do
+      expect(@variable.key).to eq("VARIABLE")
+      expect(@variable.value).to eq("the value")
+    end
+  end
+
+  describe ".group_variables" do
+    before do
+      stub_get("/groups/3/variables", "variables")
+      @variables = Gitlab.group_variables(3)
+    end
+
+    it "gets the correct resource" do
+      expect(a_get("/groups/3/variables")).to have_been_made
+    end
+
+    it "returns an array of group's variables" do
+      expect(@variables).to be_a Gitlab::PaginatedResponse
+      expect(@variables.first.key).to eq("TEST_VARIABLE_1")
+      expect(@variables.first.value).to eq("TEST_1")
+    end
+  end
+
+  describe ".group_variable" do
+    before do
+      stub_get("/groups/3/variables/VARIABLE", "variable")
+      @variable = Gitlab.group_variable(3, "VARIABLE")
+    end
+
+    it "gets the correct resource" do
+      expect(a_get("/groups/3/variables/VARIABLE")).to have_been_made
+    end
+
+    it "returns information about a variable" do
+      expect(@variable.key).to eq("VARIABLE")
+      expect(@variable.value).to eq("the value")
+    end
+  end
+
+  describe ".create_group_variable" do
+    before do
+      stub_post("/groups/3/variables", "variable")
+      @variable = Gitlab.create_group_variable(3, "NEW_VARIABLE", "new value")
+    end
+
+    it "gets the correct resource" do
+      body = { key: "NEW_VARIABLE", value: "new value" }
+      expect(a_post("/groups/3/variables").with(body: body)).to have_been_made
+    end
+
+    it "returns information about a new variable" do
+      expect(@variable.key).to eq("VARIABLE")
+      expect(@variable.value).to eq("the value")
+    end
+  end
+
+  describe ".update_group_variable" do
+    before do
+      stub_put("/groups/3/variables/UPD_VARIABLE", "variable")
+      @variable = Gitlab.update_group_variable(3, "UPD_VARIABLE", "updated value")
+    end
+
+    it "puts the correct resource" do
+      body = { value: "updated value" }
+      expect(a_put("/groups/3/variables/UPD_VARIABLE").with(body: body)).to have_been_made
+    end
+
+    it "returns information about an updated variable" do
+      expect(@variable.key).to eq("VARIABLE")
+      expect(@variable.value).to eq("the value")
+    end
+  end
+
+  describe ".remove_group_variable" do
+    before do
+      stub_delete("/groups/3/variables/DEL_VARIABLE", "variable")
+      @variable = Gitlab.remove_group_variable(3, "DEL_VARIABLE")
+    end
+
+    it "gets the correct resource" do
+      expect(a_delete("/groups/3/variables/DEL_VARIABLE")).to have_been_made
+    end
+
+    it "returns information about a deleted variable" do
       expect(@variable.key).to eq("VARIABLE")
       expect(@variable.value).to eq("the value")
     end

data/spec/gitlab/client/builds_spec.rb

@@ -7,30 +7,30 @@ describe Gitlab::Client do
       @builds = Gitlab.builds(3)
     end
 
-    it "should get the correct resource" do
+    it "gets the correct resource" do
       expect(a_get("/projects/3/builds")).to have_been_made
     end
 
-    it "should return a paginated response of project's builds" do
+    it "returns a paginated response of project's builds" do
       expect(@builds).to be_a Gitlab::PaginatedResponse
     end
   end
-  
+
   describe ".build" do
     before do
       stub_get("/projects/3/builds/8", "build")
       @build = Gitlab.build(3, 8)
     end
-    
-    it "should get the correct resource" do
+
+    it "gets the correct resource" do
       expect(a_get("/projects/3/builds/8")).to have_been_made
     end
 
-    it "should return a single build" do
+    it "returns a single build" do
       expect(@build).to be_a Gitlab::ObjectifiedHash
     end
-    
-    it "should return information about a build" do
+
+    it "returns information about a build" do
       expect(@build.id).to eq(8)
       expect(@build.user.name).to eq("John Smith")
     end
@@ -46,22 +46,22 @@ describe Gitlab::Client do
           to_return(body: fixture.read, headers: { 'Content-Disposition' => "attachment; filename=artifacts.zip" })
         @build_artifacts = Gitlab.build_artifacts(3, 8)
       end
-      
-      it "should get the correct resource" do
+
+      it "gets the correct resource" do
         expect(a_get("/projects/3/builds/8/artifacts")).to have_been_made
       end
-      
-      it "should return a FileResponse" do
+
+      it "returns a FileResponse" do
         expect(@build_artifacts).to be_a Gitlab::FileResponse
       end
-      
-      it "should return a file with filename" do
+
+      it "returns a file with filename" do
         expect(@build_artifacts.filename).to eq "artifacts.zip"
       end
     end
 
     context "when bad request" do
-      it "should throw an exception" do
+      it "throws an exception" do
         stub_get("/projects/3/builds/8/artifacts", "error_project_not_found", 404)
         expect{ Gitlab.build_artifacts(3, 8) }.to raise_error(Gitlab::Error::NotFound, "Server responded with code 404, message: 404 Project Not Found. Request URI: #{Gitlab.endpoint}/projects/3/builds/8/artifacts")
       end
@@ -73,16 +73,16 @@ describe Gitlab::Client do
       stub_get("/projects/3/repository/commits/0ff3ae198f8601a285adcf5c0fff204ee6fba5fd/builds", "builds_commits")
       @builds_commits = Gitlab.commit_builds(3, "0ff3ae198f8601a285adcf5c0fff204ee6fba5fd")
     end
-    
-    it "should get the correct resource" do
+
+    it "gets the correct resource" do
       expect(a_get("/projects/3/repository/commits/0ff3ae198f8601a285adcf5c0fff204ee6fba5fd/builds")).to have_been_made
     end
 
-    it "should return a paginated response of commit builds" do
+    it "returns a paginated response of commit builds" do
       expect(@builds_commits).to be_a Gitlab::PaginatedResponse
     end
-    
-    it "should return information about the builds" do
+
+    it "returns information about the builds" do
       expect(@builds_commits.count).to eq(2)
     end
   end
@@ -94,35 +94,35 @@ describe Gitlab::Client do
       stub_post("/projects/3/builds/8/cancel", "build_cancel")
       @build_cancel = Gitlab.build_cancel(3, 8)
     end
-    
-    it "should get the correct resource" do
+
+    it "gets the correct resource" do
       expect(a_post("/projects/3/builds/8/cancel")).to have_been_made
     end
 
-    it "should return a single build" do
+    it "returns a single build" do
       expect(@build_cancel).to be_a Gitlab::ObjectifiedHash
     end
-    
-    it "should return information about a build" do
+
+    it "returns information about a build" do
       expect(@build_cancel.commit.author_name).to eq("John Smith")
     end
   end
-  
+
   describe ".build_retry" do
     before do
       stub_post("/projects/3/builds/69/retry", "build_retry")
       @build_retry = Gitlab.build_retry(3, 69)
     end
-    
-    it "should get the correct resource" do
+
+    it "gets the correct resource" do
       expect(a_post("/projects/3/builds/69/retry")).to have_been_made
     end
 
-    it "should return a single build" do
+    it "returns a single build" do
       expect(@build_retry).to be_a Gitlab::ObjectifiedHash
     end
-    
-    it "should return information about a build" do
+
+    it "returns information about a build" do
       expect(@build_retry.commit.author_name).to eq("John Smith")
     end
   end
@@ -132,16 +132,16 @@ describe Gitlab::Client do
       stub_post("/projects/3/builds/69/erase", "build_erase")
       @build_retry = Gitlab.build_erase(3, 69)
     end
-    
-    it "should get the correct resource" do
+
+    it "gets the correct resource" do
       expect(a_post("/projects/3/builds/69/erase")).to have_been_made
     end
 
-    it "should return a single build" do
+    it "returns a single build" do
       expect(@build_retry).to be_a Gitlab::ObjectifiedHash
     end
-    
-    it "should return information about a build" do
+
+    it "returns information about a build" do
       expect(@build_retry.commit.author_name).to eq("John Smith")
     end
   end