github_api 0.9.0 → 0.9.1

data/spec/github/users/followers/follow_spec.rb

@@ -18,7 +18,7 @@ describe Github::Users::Followers, '#follow' do
   after { reset_authentication_for(subject) }
 
   it "should raise error if gist id not present" do
-    expect { subject.follow nil }.to raise_error(ArgumentError)
+    expect { subject.follow }.to raise_error(ArgumentError)
   end
 
   it 'successfully unfollows a user' do

data/spec/github/users/followers/is_following_spec.rb

@@ -18,7 +18,7 @@ describe Github::Users::Followers, '#following?' do
   after { reset_authentication_for(subject) }
 
   it 'should raise error if username not present' do
-    expect { subject.following? nil }.to raise_error(ArgumentError)
+    expect { subject.following? }.to raise_error(ArgumentError)
   end
 
   it 'should perform request' do

data/spec/github/users/followers/unfollow_spec.rb

@@ -18,7 +18,7 @@ describe Github::Users::Followers, '#unfollow' do
   after { reset_authentication_for(subject) }
 
   it "should raise error if gist id not present" do
-    expect { subject.unfollow nil }.to raise_error(ArgumentError)
+    expect { subject.unfollow }.to raise_error(ArgumentError)
   end
 
   it 'successfully unfollows a user' do

data/spec/github/users/keys/delete_spec.rb

@@ -20,7 +20,7 @@ describe Github::Users::Keys, '#delete' do
     let(:status) { 204 }
 
     it "should fail to get resource without key id" do
-      expect { subject.delete nil }.to raise_error(ArgumentError)
+      expect { subject.delete }.to raise_error(ArgumentError)
     end
 
     it "should create resource successfully" do

data/spec/github/users/keys/get_spec.rb

@@ -22,7 +22,7 @@ describe Github::Users::Keys, '#get' do
     it { should respond_to :find }
 
     it "should fail to get resource without key id" do
-      expect { subject.get nil }.to raise_error(ArgumentError)
+      expect { subject.get }.to raise_error(ArgumentError)
     end
 
     it "should get the resource" do

data/spec/github/users/keys/update_spec.rb

@@ -29,7 +29,7 @@ describe Github::Users::Keys, '#update' do
     let(:status) { 201 }
 
     it "should fail to get resource without key id" do
-      expect { subject.update nil }.to raise_error(ArgumentError)
+      expect { subject.update }.to raise_error(ArgumentError)
     end
 
     it "should create resource successfully" do

data/spec/github/users/update_spec.rb

@@ -24,7 +24,7 @@ describe Github::Users, '#update' do
       "company" => "GitHub",
       "location" => "San Francisco",
       "hireable" => true,
-      "bio" => "There once...",
+      "bio" => "There once..."
     }
   }
 

data/spec/integration/arguments_spec.rb

@@ -0,0 +1,76 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe 'Arguments' do
+  let(:user) { 'peter-murach' }
+  let(:repo) { 'github-api' }
+  let(:api)  { Github::Issues.new :user => user, :repo => repo }
+  let(:body) { '[]' }
+  let(:status) { 200 }
+
+  subject { api.milestones }
+
+  context 'with existing arguments' do
+    let(:request_path) { "/repos/#{user}/#{repo}/milestones" }
+
+    before {
+      stub_get(request_path).to_return(:body => body, :status => status,
+        :headers => {:content_type => "application/json; charset=utf-8"})
+    }
+
+    it { subject.user.should == user }
+
+    it { subject.repo.should == repo }
+
+    it 'performs request' do
+      subject.list
+      a_get(request_path).should have_been_made
+    end
+
+    it "does not set argument to nil" do
+      subject.list
+      subject.user.should == user
+    end
+  end
+
+  context 'with new arguments' do
+    let(:milestone_id) { 11 }
+    let(:request_path) { "/repos/#{user}/#{repo}/milestones/#{milestone_id}" }
+
+    before {
+      stub_get(request_path).to_return(:body => body, :status => status,
+        :headers => {:content_type => "application/json; charset=utf-8"})
+    }
+
+    it { expect { subject.milestone_id }.to raise_error(NoMethodError) }
+
+    it {
+      subject.get user, repo, milestone_id
+      a_get(request_path).should have_been_made
+    }
+
+    it 'reads user & repo settings' do
+      subject.get :milestone_id => milestone_id
+      a_get(request_path).should have_been_made
+    end
+
+    it 'reads user & repo and requires milestone_id' do
+      expect { subject.get milestone_id }.to raise_error(ArgumentError)
+    end
+
+    it 'requires extra parameter' do
+      expect { subject.get user, repo }.to raise_error(ArgumentError)
+    end
+
+    it 'requires milestone_id to be set' do
+      expect { subject.get }.to raise_error(ArgumentError)
+    end
+
+    it 'creates setter' do
+      subject.get user, repo, milestone_id
+      subject.milestone_id.should == milestone_id
+    end
+
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: github_api
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.9.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,22 +9,22 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-02-18 00:00:00.000000000Z
+date: 2013-02-24 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: hashie
-  requirement: &2154928480 !ruby/object:Gem::Requirement
+  requirement: &2154681220 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.2.0
+        version: '2.0'
   type: :runtime
   prerelease: false
-  version_requirements: *2154928480
+  version_requirements: *2154681220
 - !ruby/object:Gem::Dependency
   name: faraday
-  requirement: &2154927980 !ruby/object:Gem::Requirement
+  requirement: &2154680720 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -32,10 +32,10 @@ dependencies:
         version: 0.8.1
   type: :runtime
   prerelease: false
-  version_requirements: *2154927980
+  version_requirements: *2154680720
 - !ruby/object:Gem::Dependency
   name: multi_json
-  requirement: &2154927520 !ruby/object:Gem::Requirement
+  requirement: &2154680260 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,10 +43,10 @@ dependencies:
         version: '1.4'
   type: :runtime
   prerelease: false
-  version_requirements: *2154927520
+  version_requirements: *2154680260
 - !ruby/object:Gem::Dependency
   name: oauth2
-  requirement: &2154927140 !ruby/object:Gem::Requirement
+  requirement: &2154679880 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2154927140
+  version_requirements: *2154679880
 - !ruby/object:Gem::Dependency
   name: nokogiri
-  requirement: &2154926600 !ruby/object:Gem::Requirement
+  requirement: &2154679340 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -65,10 +65,10 @@ dependencies:
         version: 1.5.2
   type: :runtime
   prerelease: false
-  version_requirements: *2154926600
+  version_requirements: *2154679340
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &2154926100 !ruby/object:Gem::Requirement
+  requirement: &2154678840 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,10 +76,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2154926100
+  version_requirements: *2154678840
 - !ruby/object:Gem::Dependency
   name: cucumber
-  requirement: &2154925640 !ruby/object:Gem::Requirement
+  requirement: &2154678380 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -87,10 +87,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2154925640
+  version_requirements: *2154678380
 - !ruby/object:Gem::Dependency
   name: webmock
-  requirement: &2154925180 !ruby/object:Gem::Requirement
+  requirement: &2154667660 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -98,10 +98,10 @@ dependencies:
         version: 1.9.0
   type: :development
   prerelease: false
-  version_requirements: *2154925180
+  version_requirements: *2154667660
 - !ruby/object:Gem::Dependency
   name: vcr
-  requirement: &2154924720 !ruby/object:Gem::Requirement
+  requirement: &2154667200 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -109,10 +109,10 @@ dependencies:
         version: 2.4.0
   type: :development
   prerelease: false
-  version_requirements: *2154924720
+  version_requirements: *2154667200
 - !ruby/object:Gem::Dependency
   name: simplecov
-  requirement: &2154924260 !ruby/object:Gem::Requirement
+  requirement: &2154666740 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -120,10 +120,10 @@ dependencies:
         version: 0.7.1
   type: :development
   prerelease: false
-  version_requirements: *2154924260
+  version_requirements: *2154666740
 - !ruby/object:Gem::Dependency
   name: guard
-  requirement: &2154923880 !ruby/object:Gem::Requirement
+  requirement: &2154666360 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -131,10 +131,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2154923880
+  version_requirements: *2154666360
 - !ruby/object:Gem::Dependency
   name: guard-rspec
-  requirement: &2154923420 !ruby/object:Gem::Requirement
+  requirement: &2154665900 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -142,10 +142,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2154923420
+  version_requirements: *2154665900
 - !ruby/object:Gem::Dependency
   name: guard-cucumber
-  requirement: &2154919140 !ruby/object:Gem::Requirement
+  requirement: &2154665480 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -153,10 +153,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2154919140
+  version_requirements: *2154665480
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &2154918720 !ruby/object:Gem::Requirement
+  requirement: &2154665060 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -164,10 +164,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2154918720
+  version_requirements: *2154665060
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &2154918300 !ruby/object:Gem::Requirement
+  requirement: &2154664640 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -175,7 +175,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2154918300
+  version_requirements: *2154664640
 description: ! ' Ruby wrapper that supports all of the GitHub API v3 methods(nearly
   200). It''s build in a modular way, that is, you can either instantiate the whole
   api wrapper Github.new or use parts of it e.i. Github::Repos.new if working solely
@@ -221,6 +221,7 @@ files:
 - features/cassettes/gists/star.yml
 - features/cassettes/gists/starred.yml
 - features/cassettes/gists/unstar.yml
+- features/cassettes/git_data/commits/get.yml
 - features/cassettes/git_data/references/all.yml
 - features/cassettes/git_data/references/all_tags.yml
 - features/cassettes/git_data/references/one.yml
@@ -322,6 +323,7 @@ files:
 - features/error_codes.feature
 - features/gists/comments.feature
 - features/gists.feature
+- features/git_data/commmits.feature
 - features/git_data/references.feature
 - features/github_api.feature
 - features/gitignore.feature
@@ -364,6 +366,7 @@ files:
 - lib/github_api/api/actions.rb
 - lib/github_api/api.rb
 - lib/github_api/api_factory.rb
+- lib/github_api/arguments.rb
 - lib/github_api/authorization.rb
 - lib/github_api/authorizations.rb
 - lib/github_api/client.rb
@@ -580,15 +583,16 @@ files:
 - spec/github/activity/watching/watched_spec.rb
 - spec/github/activity/watching/watching_spec.rb
 - spec/github/api/set_spec.rb
+- spec/github/api/with_spec.rb
 - spec/github/api_factory_spec.rb
 - spec/github/api_spec.rb
+- spec/github/arguments/parse_spec.rb
 - spec/github/authorization_spec.rb
 - spec/github/authorizations/create_spec.rb
 - spec/github/authorizations/delete_spec.rb
 - spec/github/authorizations/get_spec.rb
 - spec/github/authorizations/list_spec.rb
 - spec/github/authorizations/update_spec.rb
-- spec/github/authorizations_spec.rb
 - spec/github/client_spec.rb
 - spec/github/core_ext/hash_spec.rb
 - spec/github/deprecation_spec.rb
@@ -756,7 +760,10 @@ files:
 - spec/github/repos/languages_spec.rb
 - spec/github/repos/list_spec.rb
 - spec/github/repos/merging/merge_spec.rb
-- spec/github/repos/pub_sub_hubbub_spec.rb
+- spec/github/repos/pub_sub_hubbub/subscribe_service_spec.rb
+- spec/github/repos/pub_sub_hubbub/subscribe_spec.rb
+- spec/github/repos/pub_sub_hubbub/unsubscribe_service_spec.rb
+- spec/github/repos/pub_sub_hubbub/unsubscribe_spec.rb
 - spec/github/repos/statuses/create_spec.rb
 - spec/github/repos/statuses/list_spec.rb
 - spec/github/repos/statuses_spec.rb
@@ -795,6 +802,8 @@ files:
 - spec/github/validations_spec.rb
 - spec/github_spec.rb
 - spec/integration/activity_spec.rb
+- spec/integration/arguments_spec.rb
+- spec/integration/authorizations_spec.rb
 - spec/integration/gists_spec.rb
 - spec/integration/git_data_spec.rb
 - spec/integration/issues_spec.rb

data/spec/github/repos/pub_sub_hubbub_spec.rb

@@ -1,78 +0,0 @@
-require 'spec_helper'
-
-describe Github::Repos::PubSubHubbub do
-  let(:topic)  { "https://github.com/peter-murach/github/events/push"}
-  let(:callback) { "github://campfire?subdomain=github&room=Commits&token=abc123" }
-  let(:hub_inputs) {
-    {
-       "hub.mode" => 'subscribe',
-       "hub.topic" => topic,
-       "hub.callback" => callback,
-       "hub.verify"   => 'sync',
-       "hub.secret"   => ''
-    }
-  }
-
-  after { reset_authentication_for subject }
-
-  describe "subscribe" do
-    context "success" do
-      before do
-        subject.oauth_token = OAUTH_TOKEN
-        stub_post("/hub?access_token=#{OAUTH_TOKEN}").with(hub_inputs).
-          to_return(:body => '[]', :status => 200,
-            :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should subscribe to hub" do
-        subject.subscribe topic, callback
-        a_post("/hub?access_token=#{OAUTH_TOKEN}").with(hub_inputs).should have_been_made
-      end
-    end
-
-    context "failure" do
-      before do
-        subject.oauth_token = OAUTH_TOKEN
-        stub_post("/hub?access_token=#{OAUTH_TOKEN}").with(hub_inputs).
-          to_return(:body => '[]', :status => 404,
-            :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should fail to subscribe to hub" do
-        expect {
-          subject.subscribe topic, callback
-        }.to raise_error(Github::Error::NotFound)
-      end
-    end
-  end # subscribe
-
-  describe "unsubscribe" do
-    context "success" do
-      before do
-        subject.oauth_token = OAUTH_TOKEN
-        stub_post("/hub?access_token=#{OAUTH_TOKEN}").with(hub_inputs.merge("hub.mode" => 'unsubscribe')).
-        to_return(:body => '[]', :status => 200,
-          :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should subscribe to hub" do
-        subject.unsubscribe topic, callback
-        a_post("/hub?access_token=#{OAUTH_TOKEN}").with(hub_inputs).should have_been_made
-      end
-    end
-
-    context "failure" do
-      before do
-        subject.oauth_token = OAUTH_TOKEN
-        stub_post("/hub?access_token=#{OAUTH_TOKEN}").with(hub_inputs.merge("hub.mode" => 'unsubscribe')).
-          to_return(:body => '[]', :status => 404, :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should fail to subscribe to hub" do
-        expect {
-          subject.unsubscribe topic, callback
-        }.to raise_error(Github::Error::NotFound)
-      end
-    end
-  end # unsubscribe
-end # Github::Repos::PubSubHubbub