github_api 0.9.0 → 0.9.1

data/spec/github/authorizations/delete_spec.rb

@@ -23,7 +23,7 @@ describe Github::Authorizations, '#delete' do
 
     it "should fail to get resource without basic authentication" do
       reset_authentication_for subject
-      expect { subject.delete nil }.to raise_error(ArgumentError)
+      expect { subject.delete }.to raise_error(ArgumentError)
     end
 
     it "should delete resource successfully" do

data/spec/github/authorizations/get_spec.rb

@@ -22,7 +22,7 @@ describe Github::Authorizations, '#get' do
     let(:status) { 200 }
 
     it "should fail to get resource without authorization id" do
-      expect { subject.get nil }.to raise_error(ArgumentError)
+      expect { subject.get }.to raise_error(ArgumentError)
     end
 
     it "should get the resource" do

data/spec/github/error/validations_spec.rb

@@ -7,15 +7,15 @@ describe Github::Error::Validations do
     let(:error) { described_class.new(:username => nil) }
 
     it 'contains the problem in the message' do
-      error.message.should include "Attempted to send request with nil arguments"
+      error.message.should =~ /Attempted to send request with nil arguments/
     end
 
     it 'contains the summary in the message' do
-      error.message.should include "Each request expects certain number of arguments."
+      error.message.should =~ /Each request expects certain number of required arguments./
     end
 
     it 'contains the resolution in the message' do
-      error.message.should include "Double check that the provided arguments are set to some value."
+      error.message.should =~ /Double check that the provided arguments are set to some value/
     end
   end
 end # Github::Error::Validations

data/spec/github/gists/comments/list_spec.rb

@@ -20,7 +20,7 @@ describe Github::Gists::Comments, '#list' do
     it { should respond_to :all }
 
     it "throws error if gist id not provided" do
-      expect { subject.list nil}.to raise_error(ArgumentError)
+      expect { subject.list }.to raise_error(ArgumentError)
     end
 
     it "should get the resources" do

data/spec/github/gists/delete_spec.rb

@@ -16,7 +16,7 @@ describe Github::Gists, '#delete' do
   after { reset_authentication_for(subject) }
 
   it 'should raise error if gist id not present' do
-    expect { subject.delete nil }.to raise_error(ArgumentError)
+    expect { subject.delete }.to raise_error(ArgumentError)
   end
 
   it "should remove resource successfully" do

data/spec/github/gists/fork_spec.rb

@@ -16,7 +16,7 @@ describe Github::Gists, '#star' do
   after { reset_authentication_for(subject) }
 
   it "should fail to fork gist without gist id" do
-    expect { subject.fork(nil) }.to raise_error(ArgumentError)
+    expect { subject.fork }.to raise_error(ArgumentError)
   end
 
   it "should fork resource successfully" do

data/spec/github/gists/get_spec.rb

@@ -20,7 +20,7 @@ describe Github::Gists, '#get' do
     it { should respond_to :find }
 
     it "should fail to get resource without gist id" do
-      expect { subject.get nil }.to raise_error(ArgumentError)
+      expect { subject.get }.to raise_error(ArgumentError)
     end
 
     it "should get the resource" do

data/spec/github/gists/is_starred_spec.rb

@@ -18,6 +18,8 @@ describe Github::Gists, '#unstar' do
   context 'when gist is starred' do
     let(:status) { 204 }
 
+    it { expect { subject.starred? }.to raise_error(ArgumentError) }
+
     it 'should raise error if gist id not present' do
       expect { subject.starred? nil }.to raise_error(ArgumentError)
     end

data/spec/github/gists/star_spec.rb

@@ -16,7 +16,7 @@ describe Github::Gists, '#star' do
   after { reset_authentication_for(subject) }
 
   it "should raise error if gist id not present" do
-    expect { subject.star nil }.to raise_error(ArgumentError)
+    expect { subject.star }.to raise_error(ArgumentError)
   end
 
   it 'successfully stars a gist' do

data/spec/github/gists/unstar_spec.rb

@@ -16,7 +16,7 @@ describe Github::Gists, '#unstar' do
   after { reset_authentication_for(subject) }
 
   it "should raise error if gist id not present" do
-    expect { subject.unstar nil }.to raise_error(ArgumentError)
+    expect { subject.unstar }.to raise_error(ArgumentError)
   end
 
   it 'successfully stars a gist' do

data/spec/github/git_data/blobs/create_spec.rb

@@ -27,6 +27,8 @@ describe Github::GitData::Blobs, '#create' do
     let(:body) { fixture('git_data/blob_sha.json') }
     let(:status) { 201 }
 
+    it { expect { subject.create user }.to raise_error(ArgumentError) }
+
     it "should fail to create resource if 'content' input is missing" do
       expect {
         subject.create user, repo, inputs.except('content')

data/spec/github/git_data/blobs/get_spec.rb

@@ -23,7 +23,7 @@ describe Github::GitData::Blobs, '#get' do
     it { should respond_to :find }
 
     it "should fail to get resource without sha" do
-      expect { subject.get user, repo, nil }.to raise_error(ArgumentError)
+      expect { subject.get user, repo }.to raise_error(ArgumentError)
     end
 
     it "should get the resource" do

data/spec/github/git_data/commits/create_spec.rb

@@ -34,6 +34,8 @@ describe Github::GitData::Commits, '#get' do
     let(:body) { fixture('git_data/commit.json') }
     let(:status) { 201 }
 
+    it { expect { subject.create user }.to raise_error(ArgumentError)}
+
     it "should fail to create resource if 'message' input is missing" do
       expect {
         subject.create user, repo, inputs.except('message')

data/spec/github/git_data/commits/get_spec.rb

@@ -21,10 +21,10 @@ describe Github::GitData::Commits, '#get' do
 
     it { should respond_to :find }
 
+    it { expect { subject.get }.to raise_error(ArgumentError) }
+
     it "should fail to get resource without sha" do
-      expect {
-        subject.get user, repo, nil
-      }.to raise_error(ArgumentError)
+      expect { subject.get user, repo }.to raise_error(ArgumentError)
     end
 
     it "should get the resource" do

data/spec/github/git_data/references/create_spec.rb

@@ -29,7 +29,7 @@ describe Github::GitData::References, '#create' do
     it "should fail to create resource if 'ref' input is missing" do
       expect {
         subject.create user, repo, inputs.except('ref')
-      }.to raise_error(ArgumentError)
+      }.to raise_error(Github::Error::RequiredParams )
     end
 
     it "should fail to create resource if 'sha' input is missing" do

data/spec/github/git_data/references/delete_spec.rb

@@ -21,8 +21,10 @@ describe Github::GitData::References, '#delete' do
 
     it { should respond_to :remove }
 
+    it { expect { subject.delete }.to raise_error(ArgumentError) }
+
     it "should fail to delete resource if 'ref' input is missing" do
-      expect { subject.delete user, repo, nil }.to raise_error(ArgumentError)
+      expect { subject.delete user, repo }.to raise_error(ArgumentError)
     end
 
     it "should delete resource successfully" do

data/spec/github/git_data/tags/create_spec.rb

@@ -38,6 +38,8 @@ describe Github::GitData::Tags, '#create' do
     let(:body) { fixture('git_data/tag.json') }
     let(:status) { 201 }
 
+    it { expect { subject.create user }.to raise_error(ArgumentError) }
+
     it "should create resource successfully" do
       subject.create user, repo, inputs
       a_post(request_path).with(inputs).should have_been_made

data/spec/github/gitignore/get_spec.rb

@@ -22,7 +22,7 @@ describe Github::Gitignore, '#get' do
     it { should respond_to :find }
 
     it "should fail to get resource without key" do
-      expect { subject.get nil }.to raise_error(ArgumentError)
+      expect { subject.get }.to raise_error(ArgumentError)
     end
 
     it "should get the resource" do

data/spec/github/issues/events/get_spec.rb

@@ -21,8 +21,10 @@ describe Github::Issues::Events, '#list' do
 
     it { should respond_to :find }
 
+    it { expect { subject.get }.to raise_error(ArgumentError) }
+
     it "should fail to get resource without event id" do
-      expect { subject.get user, repo, nil }.to raise_error(ArgumentError)
+      expect { subject.get user, repo }.to raise_error(ArgumentError)
     end
 
     it "should get the resource" do

data/spec/github/issues/events/list_spec.rb

@@ -24,8 +24,10 @@ describe Github::Issues::Events, '#list' do
 
       it { subject.should respond_to :all }
 
+      it { expect { subject.list }.to raise_error(ArgumentError) }
+
       it "should fail to get resource without username" do
-        expect { subject.list }.to raise_error(ArgumentError)
+        expect { subject.list user }.to raise_error(ArgumentError)
       end
 
       it "should get the resources" do

data/spec/github/issues/labels/add_spec.rb

@@ -16,7 +16,7 @@ describe Github::Issues::Labels, '#add' do
   after { reset_authentication_for(subject) }
 
   let(:issue_id) { 1 }
-  let(:labels) { "Label 1" }
+  let(:label) { "Label 1" }
 
   context "labels added" do
     let(:body) { fixture('issues/labels.json') }
@@ -24,27 +24,27 @@ describe Github::Issues::Labels, '#add' do
 
     it "should fail to add labels if issue-id is missing" do
       expect {
-        subject.add user, repo, nil, labels
+        subject.add user, repo, nil, label
       }.to raise_error(ArgumentError)
     end
 
     it "should create resource successfully" do
-      subject.add user, repo, issue_id, labels
+      subject.add user, repo, issue_id, label
       a_post(request_path).should have_been_made
     end
 
     it "should return the resource" do
-      labels = subject.add user, repo, issue_id, labels
+      labels = subject.add user, repo, issue_id, label
       labels.first.should be_a Hashie::Mash
     end
 
     it "should get the label information" do
-      labels = subject.add user, repo, issue_id, labels
+      labels = subject.add user, repo, issue_id, label
       labels.first.name.should == 'bug'
     end
   end
 
   it_should_behave_like 'request failure' do
-    let(:requestable) { subject.add user, repo, issue_id, labels }
+    let(:requestable) { subject.add user, repo, issue_id, label }
   end
 end # add

data/spec/github/issues/labels/list_spec.rb

@@ -19,8 +19,10 @@ describe Github::Issues::Labels, '#list' do
   context "for this repository" do
     it { should respond_to :all }
 
+    it { expect { subject.list }.to raise_error(ArgumentError) }
+
     it "should fail to get resource without username" do
-      expect { subject.list nil, repo }.to raise_error(ArgumentError)
+      expect { subject.list user }.to raise_error(ArgumentError)
     end
 
     it "should get the resources" do

data/spec/github/issues/labels/replace_spec.rb

@@ -6,7 +6,7 @@ describe Github::Issues::Labels, '#replace' do
   let(:user) { 'peter-murach' }
   let(:repo) { 'github' }
   let(:issue_id) { 1 }
-  let(:labels) { "Label 1" }
+  let(:label) { "Label 1" }
   let(:request_path) { "/repos/#{user}/#{repo}/issues/#{issue_id}/labels" }
 
   before {
@@ -16,35 +16,34 @@ describe Github::Issues::Labels, '#replace' do
 
   after { reset_authentication_for(subject) }
 
-
   context "labels replaced" do
     let(:body) { fixture('issues/labels.json') }
     let(:status) { 200 }
 
     it "should fail to add labels if issue-id is missing" do
       expect {
-        subject.replace user, repo, nil, labels
+        subject.replace user, repo, nil, label
       }.to raise_error(ArgumentError)
     end
 
     it "should create resource successfully" do
-      subject.replace user, repo, issue_id, labels
+      subject.replace user, repo, issue_id, label
       a_put(request_path).should have_been_made
     end
 
     it "should return the resource" do
-      labels = subject.replace user, repo, issue_id, labels
+      labels = subject.replace user, repo, issue_id, label
       labels.first.should be_a Hashie::Mash
     end
 
     it "should get the label information" do
-      labels = subject.replace user, repo, issue_id, labels
+      labels = subject.replace user, repo, issue_id, label
       labels.first.name.should == 'bug'
     end
   end
 
   it_should_behave_like 'request failure' do
-    let(:requestable) { subject.replace user, repo, issue_id, labels }
+    let(:requestable) { subject.replace user, repo, issue_id, label }
   end
 
 end # replace

data/spec/github/issues/milestones/get_spec.rb

@@ -21,6 +21,8 @@ describe Github::Issues::Milestones, '#get' do
 
     it { subject.should respond_to :find }
 
+    it { expect { subject.get }.to raise_error(ArgumentError) }
+
     it "should fail to get resource without milestone id" do
       expect { subject.get user, repo, nil }.to raise_error(ArgumentError)
     end

data/spec/github/normalizer_spec.rb

@@ -1,20 +1,32 @@
 require 'spec_helper'
 require 'github_api/core_ext/hash'
 
-describe Github::Normalizer do
-  let(:github) { Github.new }
-  let(:repos_instance) { Github::Repos.new }
-  let(:hash) {  { :a => { :b => { :c => 1 } } }  }
+describe Github::Normalizer, '#normalize!' do
+  let(:hash) { { 'a' => { :b => { 'c' => 1 }, 'd' => [ 'a', { :e => 2 }] } } }
+
+  let(:klass) {
+    Class.new do
+      include Github::Normalizer
+    end
+  }
+
+  subject(:instance) { klass.new }
 
   context '#normalize!' do
     it 'converts hash keys to string' do
       ['a', 'b', 'c'].each do |key|
-        github.repos.normalize!(hash).all_keys.should include key
+        subject.normalize!(hash).all_keys.should include key
       end
       [:a, :b, :c].each do |key|
-        github.repos.normalize!(hash).all_keys.should_not include key
+        subject.normalize!(hash).all_keys.should_not include key
       end
     end
+
+    it "should stringify all the keys inside nested hash" do
+      actual = subject.normalize! hash
+      expected = { 'a' => { 'b'=> { 'c' => 1 }, 'd' => [ 'a', { 'e'=> 2 }] } }
+      actual.should be_eql expected
+    end
   end
 
 end # Github::Normalizer

data/spec/github/orgs/members/conceal_spec.rb

@@ -4,8 +4,8 @@ require 'spec_helper'
 
 describe Github::Orgs::Members, '#conceal' do
   let(:org)    { 'github' }
-  let(:member) { 'peter-murach' }
-  let(:request_path) { "/orgs/#{org}/public_members/#{member}" }
+  let(:user) { 'peter-murach' }
+  let(:request_path) { "/orgs/#{org}/public_members/#{user}" }
 
   before {
     stub_delete(request_path).to_return(:body => body, :status => status,
@@ -22,14 +22,16 @@ describe Github::Orgs::Members, '#conceal' do
       expect { subject.conceal }.to raise_error(ArgumentError)
     end
 
+    it { expect { subject.conceal org }.to raise_error(ArgumentError) }
+
     it "should get the resources" do
-      subject.conceal org, member
+      subject.conceal org, user
       a_delete(request_path).should have_been_made
     end
   end
 
   it_should_behave_like 'request failure' do
-    let(:requestable) { subject.conceal org, member }
+    let(:requestable) { subject.conceal org, user }
   end
 
 end # conceal

data/spec/github/orgs/members/delete_spec.rb

@@ -20,6 +20,8 @@ describe Github::Orgs::Members, '#delete' do
       expect { subject.delete }.to raise_error(ArgumentError)
     end
 
+    it { expect { subject.delete org }.to raise_error(ArgumentError) }
+
     it "should delete the resource" do
       subject.delete org, member
       a_delete(request_path).should have_been_made

data/spec/github/orgs/members/list_spec.rb

@@ -20,7 +20,7 @@ describe Github::Orgs::Members, '#list' do
     it { should respond_to :all }
 
     it "should fail to get resource without org name" do
-      expect { subject.list nil }.to raise_error(ArgumentError)
+      expect { subject.list }.to raise_error(ArgumentError)
     end
 
     it "should get the resources" do

data/spec/github/orgs/members/member_spec.rb

@@ -20,8 +20,10 @@ describe Github::Orgs::Members, '#member?' do
     context "this repo is being watched by the user" do
       let(:status) { 404 }
 
+      it { expect { subject.member? }.to raise_error(ArgumentError) }
+
       it "should fail validation " do
-        expect { subject.member?(nil, nil) }.to raise_error(ArgumentError)
+        expect { subject.member? org  }.to raise_error(ArgumentError)
       end
 
       it "should return false if resource not found" do