github_api 0.9.0 → 0.9.1

data/spec/github/repos/commits/get_spec.rb

@@ -21,10 +21,10 @@ describe Github::Repos::Commits, '#get' do
 
     it { should respond_to :find }
 
+    it { expect { subject.get }.to raise_error(ArgumentError) }
+
     it "should fail to get resource without sha key" do
-      expect {
-        subject.get user, repo, nil
-      }.to raise_error(ArgumentError)
+      expect { subject.get user, repo }.to raise_error(ArgumentError)
     end
 
     it "should get the resource" do

data/spec/github/repos/commits/list_spec.rb

@@ -20,9 +20,9 @@ describe Github::Repos::Commits, '#list' do
 
     it { should respond_to :all }
 
-    it "should fail to get resource without username" do
-      expect { subject.list }.to raise_error(ArgumentError)
-    end
+    it { expect { subject.list }.to raise_error(ArgumentError) }
+
+    it { expect { subject user }.to raise_error(ArgumentError) }
 
     it "should get the resources" do
       subject.list user, repo

data/spec/github/repos/contents/archive_spec.rb

@@ -19,8 +19,20 @@ describe Github::Repos::Contents, '#get' do
   let(:body) { '[]' }
   let(:status) { 302 }
 
+
   it "should get the resources" do
     subject.archive user, repo, :archive_format => archive_format, :ref => ref
     a_get(request_path).should have_been_made
   end
+
+  context 'with defaults' do
+    let(:request_path) { "/repos/#{user}/#{repo}/zipball/master" }
+
+    it { expect { subject.archive user }.to raise_error(ArgumentError) }
+
+    it 'should get the resource' do
+      subject.archive user, repo
+      a_get(request_path).should have_been_made
+    end
+  end
 end

data/spec/github/repos/contents/get_spec.rb

@@ -5,6 +5,7 @@ require 'spec_helper'
 describe Github::Repos::Contents, '#get' do
   let(:user) { 'peter-murach' }
   let(:repo) { 'github' }
+  let(:path) { 'README.md' }
   let(:request_path) { "/repos/#{user}/#{repo}/contents/#{path}" }
 
   before {
@@ -18,6 +19,10 @@ describe Github::Repos::Contents, '#get' do
   let(:body) { fixture('repos/content.json') }
   let(:status) { 200 }
 
+  it { expect { subject.get user, repo }.to raise_error(ArgumentError) }
+
+  it { expect { subject.get }.to raise_error(ArgumentError)}
+
   it "should get the resources" do
     subject.get user, repo, path
     a_get(request_path).should have_been_made

data/spec/github/repos/contributors_spec.rb

@@ -20,11 +20,16 @@ describe Github::Repos, '#contributors' do
     let(:status) { 200 }
 
     it "should raise error when no user/repo parameters" do
-      expect { subject.contributors nil, repo }.to raise_error(ArgumentError)
+      expect { subject.contributors }.to raise_error(ArgumentError)
     end
 
     it "should raise error when no repository" do
-      expect { subject.contributors user, nil }.to raise_error(ArgumentError)
+      expect { subject.contributors user }.to raise_error(ArgumentError)
+    end
+
+    it 'filters out unkown parameters' do
+      subject.contributors user, repo, :unknown => true
+      a_get(request_path).with({}).should have_been_made
     end
 
     it "should find resources" do

data/spec/github/repos/downloads/create_spec.rb

@@ -25,6 +25,10 @@ describe Github::Repos::Downloads, '#create' do
     let(:body)   { fixture('repos/download_s3.json') }
     let(:status) { 201}
 
+    it { expect { subject.create }.to raise_error(ArgumentError) }
+
+    it { expect { subject.create user }.to raise_error(ArgumentError) }
+
     it "should fail to create resource if 'name' input is missing" do
       expect {
         subject.create user, repo, inputs.except(:name)

data/spec/github/repos/downloads/delete_spec.rb

@@ -21,8 +21,12 @@ describe Github::Repos::Downloads, '#delete' do
     let(:body)   { "" }
     let(:status) { 204 }
 
+    it { should respond_to :remove }
+
+    it { expect { subject.delete }.to raise_error(ArgumentError) }
+
     it "should fail to delete without 'user/repo' parameters" do
-      expect { subject.delete }.to raise_error(ArgumentError)
+      expect { subject.delete user }.to raise_error(ArgumentError)
     end
 
     it "should fail to delete resource without 'download_id'" do

data/spec/github/repos/downloads/get_spec.rb

@@ -22,8 +22,10 @@ describe Github::Repos::Downloads, '#get' do
 
     it { should respond_to :find }
 
+    it { expect { subject.get }.to raise_error(ArgumentError) }
+
     it "should fail to get resource without download id" do
-      expect { subject.get user, repo, nil }.to raise_error(ArgumentError)
+      expect { subject.get user, repo }.to raise_error(ArgumentError)
     end
 
     it "should get the resource" do

data/spec/github/repos/downloads/list_spec.rb

@@ -21,8 +21,10 @@ describe Github::Repos::Downloads, '#list' do
 
     it { should respond_to :all }
 
+    it { expect { subject.list }.to raise_error(ArgumentError) }
+
     it "should fail to get resource without username" do
-      expect { subject.list }.to raise_error(ArgumentError)
+      expect { subject.list user }.to raise_error(ArgumentError)
     end
 
     it "should get the resources" do

data/spec/github/repos/forks/create_spec.rb

@@ -20,6 +20,8 @@ describe Github::Repos::Forks, '#create' do
     let(:body)   { fixture('repos/fork.json') }
     let(:status) { 202 }
 
+    it { expect { subject.create user }.to raise_error(ArgumentError) }
+
     it "should create resource successfully" do
       subject.create(user, repo, inputs)
       a_post(request_path).with(inputs).should have_been_made

data/spec/github/repos/forks/list_spec.rb

@@ -20,8 +20,10 @@ describe Github::Repos::Forks, '#list' do
 
     it { should respond_to :all }
 
+    it { expect { subject.list }.to raise_error(ArgumentError) }
+
     it "should fail to get resource without username" do
-      expect { subject.list }.to raise_error(ArgumentError)
+      expect { subject.list user }.to raise_error(ArgumentError)
     end
 
     it "should get the resources" do

data/spec/github/repos/hooks/edit_spec.rb

@@ -40,7 +40,7 @@ describe Github::Repos::Hooks, '#list' do
 
     it "should fail to edit resource without 'name' parameter" do
       expect{
-        subject.edit user, repo, inputs.except(:name)
+        subject.edit user, repo, hook_id, inputs.except(:name)
       }.to raise_error(Github::Error::RequiredParams)
     end
 

data/spec/github/repos/keys/delete_spec.rb

@@ -24,7 +24,7 @@ describe Github::Repos::Keys, '#delete' do
     end
 
     it "should fail to delete resource without key id" do
-      expect { subject.delete user, repo, nil }.to raise_error(ArgumentError)
+      expect { subject.delete user, repo }.to raise_error(ArgumentError)
     end
 
     it "should delete the resource" do

data/spec/github/repos/keys/edit_spec.rb

@@ -21,6 +21,8 @@ describe Github::Repos::Keys, '#edit' do
     let(:body) { fixture("repos/key.json") }
     let(:status) { 200 }
 
+    it { expect {subject.edit user, repo }.to raise_error(ArgumentError) }
+
     it "should edit the resource" do
       subject.edit user, repo, key_id, inputs
       a_patch(request_path).should have_been_made

data/spec/github/repos/keys/get_spec.rb

@@ -21,8 +21,10 @@ describe Github::Repos::Keys, '#get' do
 
     it { should respond_to :find }
 
+    it { expect { subject.get }.to raise_error(ArgumentError) }
+
     it "should fail to get resource without key" do
-      expect { subject.get user, repo, nil }.to raise_error(ArgumentError)
+      expect { subject.get user, repo }.to raise_error(ArgumentError)
     end
 
     it "should get the resource" do

data/spec/github/repos/keys/list_spec.rb

@@ -20,8 +20,10 @@ describe Github::Repos::Keys, '#list' do
 
     it { should respond_to :all }
 
-    it "should fail to get resource without username" do
-      expect { subject.list }.to raise_error(ArgumentError)
+    it { expect { subject.list }.to raise_error(ArgumentError) }
+
+    it "should fail to get resource without repository" do
+      expect { subject.list user }.to raise_error(ArgumentError)
     end
 
     it "should get the resources" do

data/spec/github/repos/list_spec.rb

@@ -88,7 +88,7 @@ describe Github::Repos, '#list' do
     end
   end
 
-  context "resource found for organization" do
+  context "resource found for a user" do
     let(:request_path) { "/users/#{user}/repos" }
 
     before {
@@ -96,6 +96,11 @@ describe Github::Repos, '#list' do
         :headers => {:content_type => "application/json; charset=utf-8"} )
     }
 
+    it "should filter the parameters" do
+      subject.list 'user' => user, :unkown => true
+      a_get(request_path).with({}).should have_been_made
+    end
+
     it "should get the resources" do
       subject.list :user => user
       a_get(request_path).should have_been_made

data/spec/github/repos/pub_sub_hubbub/subscribe_service_spec.rb

@@ -0,0 +1,27 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Repos::PubSubHubbub, '#subscribe_service' do
+  let(:topic)  { "https://github.com/peter-murach/github/events/push"}
+  let(:callback) { "github://campfire?subdomain=github&room=Commits" }
+  let(:user) { 'peter-murach' }
+  let(:repo) { 'github' }
+  let(:service) { 'campfire' }
+  let(:options) {
+    {
+      :subdomain => 'github',
+      :room => 'Commits'
+    }
+  }
+
+  after { reset_authentication_for subject }
+
+  it { expect { subject.subscribe_service }.to raise_error(ArgumentError) }
+
+  it "subscribes to service" do
+    subject.should_receive(:subscribe).with(topic, callback)
+    subject.subscribe_service user, repo, service, options
+  end
+
+end # subscribe_service

data/spec/github/repos/pub_sub_hubbub/subscribe_spec.rb

@@ -0,0 +1,51 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Repos::PubSubHubbub, '#subscribe' do
+  let(:topic)  { "https://github.com/peter-murach/github/events/push"}
+  let(:callback) { "github://campfire?subdomain=github&room=Commits&token=abc123" }
+  let(:hub_inputs) {
+    {
+       "hub.mode" => 'subscribe',
+       "hub.topic" => topic,
+       "hub.callback" => callback,
+       "hub.verify"   => 'sync',
+       "hub.secret"   => ''
+    }
+  }
+
+  let(:request_path) { "/hub?access_token=#{OAUTH_TOKEN}" }
+
+  before {
+    subject.oauth_token = OAUTH_TOKEN
+    stub_post(request_path).with(hub_inputs).
+      to_return(:body => '[]', :status => status,
+        :headers => {:content_type => "application/json; charset=utf-8"})
+
+  }
+
+  after { reset_authentication_for subject }
+
+  context "success" do
+    let(:status) { 200 }
+
+    it { expect { subject.subscribe }.to raise_error(ArgumentError) }
+
+    it { expect { subject.subscribe topic, nil}.to raise_error(ArgumentError) }
+
+    it "subscribes to hub" do
+      subject.subscribe topic, callback
+      a_post("/hub?access_token=#{OAUTH_TOKEN}").with(hub_inputs).should have_been_made
+    end
+
+    it "" do
+      subject.subscribe(topic, callback)
+    end
+  end
+
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.subscribe topic, callback }
+  end
+
+end # subscribe

data/spec/github/repos/pub_sub_hubbub/unsubscribe_service_spec.rb

@@ -0,0 +1,21 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Repos::PubSubHubbub, '#unsubscribe_service' do
+  let(:topic)  { "https://github.com/peter-murach/github/events/push"}
+  let(:callback) { "github://campfire" }
+  let(:user) { 'peter-murach' }
+  let(:repo) { 'github' }
+  let(:service) { 'campfire' }
+
+  after { reset_authentication_for subject }
+
+  it { expect { subject.unsubscribe_service }.to raise_error(ArgumentError) }
+
+  it "subscribes to service" do
+    subject.should_receive(:unsubscribe).with(topic, callback)
+    subject.unsubscribe_service user, repo, service
+  end
+
+end # unsubscribe_service

data/spec/github/repos/pub_sub_hubbub/unsubscribe_spec.rb

@@ -0,0 +1,58 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Repos::PubSubHubbub, '#unsubscribe' do
+  let(:topic)  { "https://github.com/peter-murach/github/events/push"}
+  let(:callback) { "github://campfire?subdomain=github&room=Commits&token=abc123" }
+  let(:hub_inputs) {
+    {
+       "hub.mode" => 'subscribe',
+       "hub.topic" => topic,
+       "hub.callback" => callback,
+       "hub.verify"   => 'sync',
+       "hub.secret"   => ''
+    }
+  }
+
+  let(:request_path) { "/hub?access_token=#{OAUTH_TOKEN}" }
+
+  before {
+    subject.oauth_token = OAUTH_TOKEN
+    stub_post(request_path).with(hub_inputs.merge("hub.mode" => 'unsubscribe')).
+      to_return(:body => '[]', :status => status,
+        :headers => {:content_type => "application/json; charset=utf-8"})
+
+  }
+
+  after { reset_authentication_for subject }
+
+  context "success" do
+    let(:status) { 200 }
+
+    it { expect { subject.unsubscribe }.to raise_error(ArgumentError) }
+
+    it "should subscribe to hub" do
+      subject.unsubscribe topic, callback
+      a_post("/hub?access_token=#{OAUTH_TOKEN}").with(hub_inputs).should have_been_made
+    end
+  end
+
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.unsubscribe topic, callback }
+  end
+
+#   context "failure" do
+#     before do
+#       subject.oauth_token = OAUTH_TOKEN
+#       stub_post("/hub?access_token=#{OAUTH_TOKEN}").with(hub_inputs.merge("hub.mode" => 'unsubscribe')).
+#         to_return(:body => '[]', :status => 404, :headers => {:content_type => "application/json; charset=utf-8"})
+#     end
+# 
+#     it "should fail to subscribe to hub" do
+#       expect {
+#         subject.unsubscribe topic, callback
+#       }.to raise_error(Github::Error::NotFound)
+#     end
+#   end
+end # unsubscribe

data/spec/github/repos/statuses/create_spec.rb

@@ -25,6 +25,8 @@ describe Github::Repos::Statuses, '#create' do
     let(:body) { fixture('repos/status.json') }
     let(:status) { 201 }
 
+    it { expect { subject.create user, repo }.to raise_error(ArgumentError) }
+
     it "should fail to create resource if 'state' input is missing" do
       expect {
         subject.create user, repo, sha, inputs.except('state')

data/spec/github/search_spec.rb

@@ -3,10 +3,9 @@
 require 'spec_helper'
 
 describe Github::Search do
-  let(:github) { Github.new }
   let(:keyword) { 'api' }
 
-  after { reset_authentication_for(github) }
+  after { reset_authentication_for(subject) }
 
   context "#issues" do
     let(:owner) { 'peter-murach' }
@@ -20,12 +19,17 @@ describe Github::Search do
     end
 
     it "should get the resources" do
-      github.search.issues :owner => owner, :repo => repo, :state => state, :keyword => keyword
+      subject.issues owner, repo, state, keyword
+      a_get("/legacy/issues/search/#{owner}/#{repo}/#{state}/#{keyword}").should have_been_made
+    end
+
+    it "should get the resources through params hash" do
+      subject.issues :owner => owner, :repo => repo, :state => state, :keyword => keyword
       a_get("/legacy/issues/search/#{owner}/#{repo}/#{state}/#{keyword}").should have_been_made
     end
 
     it "should get issue information" do
-      issues = github.search.issues :owner => owner, :repo => repo, :state => state, :keyword => keyword
+      issues = subject.issues :owner => owner, :repo => repo, :state => state, :keyword => keyword
       issues.issues.first.user.should == 'ckarbass'
     end
   end
@@ -37,13 +41,20 @@ describe Github::Search do
           :headers => {:content_type => "application/json; charset=utf-8"})
     end
 
+    it { expect { subject.repos }.to raise_error(ArgumentError) }
+
     it "should get the resources" do
-      github.search.repos :keyword => keyword
+      subject.repos keyword
+      a_get("/legacy/repos/search/#{keyword}").should have_been_made
+    end
+
+    it "should get the resource through params hash" do
+      subject.repos :keyword => keyword
       a_get("/legacy/repos/search/#{keyword}").should have_been_made
     end
 
     it "should get repository information" do
-      repos = github.search.repos :keyword => keyword
+      repos = subject.repos :keyword => keyword
       repos.repositories.first.username.should == 'mathiasbynens'
     end
   end
@@ -55,13 +66,15 @@ describe Github::Search do
           :headers => {:content_type => "application/json; charset=utf-8"})
     end
 
+    it { expect { subject.users }.to raise_error(ArgumentError) }
+
     it "should get the resources" do
-      github.search.users :keyword => keyword
+      subject.users :keyword => keyword
       a_get("/legacy/user/search/#{keyword}").should have_been_made
     end
 
     it "should get user information" do
-      users = github.search.users :keyword => keyword
+      users = subject.users :keyword => keyword
       users.users.first.username.should == 'techno'
     end
   end
@@ -73,13 +86,15 @@ describe Github::Search do
           :headers => {:content_type => "application/json; charset=utf-8"})
     end
 
+    it { expect { subject.email }.to raise_error(Github::Error::RequiredParams) }
+
     it "should get the resources" do
-      github.search.email :email => keyword
+      subject.email :email => keyword
       a_get("/legacy/user/email/#{keyword}").should have_been_made
     end
 
     it "should get user information" do
-      user = github.search.email :email => keyword
+      user = subject.email :email => keyword
       user.user.username.should == 'techno'
     end
   end