github_api 0.9.0 → 0.9.1

data/spec/github/orgs/members/publicize_spec.rb

@@ -22,6 +22,8 @@ describe Github::Orgs::Members, '#publicize' do
       expect { subject.publicize }.to raise_error(ArgumentError)
     end
 
+    it { expect { subject.publicize org }.to raise_error(ArgumentError) }
+
     it "should get the resources" do
       subject.publicize org, member
       a_put(request_path).should have_been_made

data/spec/github/orgs/teams/add_member_spec.rb

@@ -18,6 +18,8 @@ describe Github::Orgs::Teams, '#add_member' do
     let(:body) { '' }
     let(:status) { 204 }
 
+    it { expect { subject.add_member }.to raise_error(ArgumentError)}
+
     it "should fail to add resource if 'team_id' input is nil" do
       expect { subject.add_member nil, user }.to raise_error(ArgumentError)
     end

data/spec/github/orgs/teams/create_spec.rb

@@ -26,7 +26,7 @@ describe Github::Orgs::Teams, '#create' do
     let(:status) { 201 }
 
     it "should fail to create resource if 'org_name' param is missing" do
-      expect { subject.create nil, inputs }.to raise_error(ArgumentError)
+      expect { subject.create }.to raise_error(ArgumentError)
     end
 
     it "should failt to create resource if 'name' input is missing" do

data/spec/github/orgs/teams/delete_spec.rb

@@ -20,7 +20,7 @@ describe Github::Orgs::Teams, '#delete' do
     it { should respond_to :remove }
 
     it "should fail to delete without 'team_id' parameter" do
-      expect { subject.delete nil }.to raise_error(ArgumentError)
+      expect { subject.delete }.to raise_error(ArgumentError)
     end
 
     it "should delete the resource" do

data/spec/github/orgs/teams/edit_spec.rb

@@ -25,7 +25,7 @@ describe Github::Orgs::Teams, '#edit' do
     let(:status) { 200 }
 
     it "should fail to create resource if 'team name' param is missing" do
-      expect { subject.edit nil, inputs }.to raise_error(ArgumentError)
+      expect { subject.edit }.to raise_error(ArgumentError)
     end
 
     it "should failt to create resource if 'name' input is missing" do

data/spec/github/orgs/teams/get_spec.rb

@@ -18,7 +18,7 @@ describe Github::Orgs::Teams, '#get' do
     let(:status) { 200 }
 
     it "should fail to get resource without org name" do
-      expect { subject.get nil }.to raise_error(ArgumentError)
+      expect { subject.get }.to raise_error(ArgumentError)
     end
 
     it "should get the resource" do

data/spec/github/orgs/teams/list_spec.rb

@@ -18,7 +18,7 @@ describe Github::Orgs::Teams, '#list' do
     let(:status) { 200 }
 
     it "should fail to get resource without org name" do
-      expect { subject.list nil }.to raise_error(ArgumentError)
+      expect { subject.list }.to raise_error(ArgumentError)
     end
 
     it "should get the resources" do

data/spec/github/orgs/teams/team_member_spec.rb

@@ -18,8 +18,10 @@ describe Github::Orgs::Teams, '#team_member?' do
   context 'when user is a member' do
     let(:status) { 204 }
 
+    it { expect { subject.team_member?(team_id, nil)}.to raise_error(ArgumentError)}
+
     it "should fail validation " do
-      expect { subject.team_member?(nil, nil) }.to raise_error(ArgumentError)
+      expect { subject.team_member? }.to raise_error(ArgumentError)
     end
 
     it "should return true if resoure found" do

data/spec/github/parameter_filter_spec.rb

@@ -1,71 +1,32 @@
 require 'spec_helper'
 require 'github_api/core_ext/hash'
 
-describe Github::ParameterFilter do
-  let(:github) { Github.new }
-  let(:repos_instance) { Github::Repos.new }
-  let(:block) {
-    Proc.new do |repo|
-      repo = repos_instance
-    end
-  }
+describe Github::ParameterFilter, '#filter!' do
   let(:hash) {  { :a => { :b => { :c => 1 } } }  }
 
-  context '#filter!' do
-    it 'removes unwanted keys from hash' do
-      github.repos.filter!([:a], hash)
-      hash.all_keys.should     include :a
-      hash.all_keys.should_not include :b
-      hash.all_keys.should_not include :c
+  let(:klass) {
+    Class.new do
+      include Github::ParameterFilter
     end
+  }
 
-    it 'recursively filters inputs tree' do
-      github.repos.filter!([:a, :b], hash)
-      hash.all_keys.should_not include :c
-    end
+  subject(:instance) { klass.new }
 
-    it 'filters inputs tree only on top level' do
-      github.repos.filter!([:a, :b], hash, :recursive => false)
-      hash.all_keys.should include :c
-    end
+  it 'removes unwanted keys from hash' do
+    instance.filter!([:a], hash)
+    hash.all_keys.should     include :a
+    hash.all_keys.should_not include :b
+    hash.all_keys.should_not include :c
   end
 
-#   context '#process_params' do
-# 
-#     it 'correctly yields current api instance' do
-#       github.repos.should_receive(:process_params).and_yield repos_instance
-#       github.repos.process_params(&block).should eq repos_instance
-#     end
-#   end
-
-#   context '#normalize' do
-#     it 'should call normalize on passed block' do
-#       github.repos.process_params(&block).should respond_to :normalize
-#     end
-# 
-#     it 'should normalize params inside block' do
-#       github.repos.stub(:process_params).and_yield repos_instance
-#       github.repos.process_params do |repo|
-#         repo.normalize hash
-#       end
-#       hash.all_keys.should include 'a'
-#       hash.all_keys.should_not include :a
-#     end
-#   end
+  it 'recursively filters inputs tree' do
+    instance.filter!([:a, :b], hash)
+    hash.all_keys.should_not include :c
+  end
 
-#   context '#filter' do
-#     it 'should call filter on passed block' do
-#       github.repos.process_params(&block).should respond_to :filter
-#     end
-# 
-#     it 'should filter params inside block' do
-#       github.repos.stub(:process_params).and_yield repos_instance
-#       github.repos.process_params do |repo|
-#         repo.filter [:a], hash
-#       end
-#       hash.all_keys.should     include :a
-#       hash.all_keys.should_not include :b
-#     end
-#   end
+  it 'filters inputs tree only on top level' do
+    instance.filter!([:a, :b], hash, :recursive => false)
+    hash.all_keys.should include :c
+  end
 
 end # Github::ParameterFilter

data/spec/github/pull_requests/comments/create_spec.rb

@@ -30,8 +30,10 @@ describe Github::PullRequests::Comments, '#create' do
     let(:body) { fixture('pull_requests/comment.json') }
     let(:status) { 201 }
 
+    it { expect { subject.create }.to raise_error(ArgumentError) }
+
     it 'raises error when pull_request_id is missing' do
-      expect { subject.create user, repo, nil }.to raise_error(ArgumentError)
+      expect { subject.create user, repo }.to raise_error(ArgumentError)
     end
 
     it "should create resource successfully" do

data/spec/github/pull_requests/comments/delete_spec.rb

@@ -20,7 +20,7 @@ describe Github::PullRequests::Comments, '#delete' do
 
   context 'resource removed' do
     it 'should raise error if comment_id not present' do
-      expect { subject.delete user, repo, nil }.to raise_error(ArgumentError)
+      expect { subject.delete user, repo }.to raise_error(ArgumentError)
     end
 
     it "should remove resource successfully" do

data/spec/github/pull_requests/comments/edit_spec.rb

@@ -26,6 +26,8 @@ describe Github::PullRequests::Comments, '#edit' do
     let(:body) { fixture('pull_requests/comment.json') }
     let(:status) { 200 }
 
+    it { expect { subject.edit }.to raise_error(ArgumentError) }
+
     it "should edit resource successfully" do
       subject.edit user, repo, comment_id, inputs
       a_patch(request_path).with(inputs).should have_been_made

data/spec/github/pull_requests/comments/get_spec.rb

@@ -22,8 +22,10 @@ describe Github::PullRequests::Comments, '#get' do
 
     it { should respond_to :find }
 
+    it { expect { subject.get }.to raise_error(ArgumentError) }
+
     it "should fail to get resource without comment id" do
-      expect { subject.get user, repo, nil }.to raise_error(ArgumentError)
+      expect { subject.get user, repo }.to raise_error(ArgumentError)
     end
 
     it "should get the resource" do

data/spec/github/pull_requests/comments/list_spec.rb

@@ -21,8 +21,10 @@ describe Github::PullRequests::Comments, '#list' do
 
     it { should respond_to :all }
 
+    it { expect { subject.list }.to raise_error(ArgumentError) }
+
     it "throws error if comment id not provided" do
-      expect { subject.list user, nil }.to raise_error(ArgumentError)
+      expect { subject.list user }.to raise_error(ArgumentError)
     end
 
     it "should get the resources" do

data/spec/github/pull_requests/commits_spec.rb

@@ -19,9 +19,9 @@ describe Github::PullRequests, '#commits' do
     let(:body) { fixture('pull_requests/commits.json') }
     let(:status) { 200 }
 
-    it "throws error if pull_request_id not provided" do
-      expect { subject.commits user, repo, nil }.to raise_error(ArgumentError)
-    end
+    it { expect { subject.commits user, repo }.to raise_error(ArgumentError) }
+
+    it { expect { subject.commits }.to raise_error(ArgumentError) }
 
     it "should get the resources" do
       subject.commits user, repo, number

data/spec/github/pull_requests/create_spec.rb

@@ -29,6 +29,10 @@ describe Github::PullRequests, '#create' do
     let(:body) { fixture('pull_requests/pull_request.json') }
     let(:status) { 201 }
 
+    it { expect { subject.create }.to raise_error(ArgumentError) }
+
+    it { expect { subject.create user }.to raise_error(ArgumentError) }
+
     it "should create resource successfully" do
       subject.create user, repo, inputs
       a_post(request_path).with(inputs).should have_been_made

data/spec/github/pull_requests/files_spec.rb

@@ -19,6 +19,10 @@ describe Github::PullRequests, '#files' do
     let(:body) { fixture('pull_requests/files.json') }
     let(:status) { 200 }
 
+    it { expect { subject.files }.to raise_error(ArgumentError) }
+
+    it { expect { subject.files user }.to raise_error(ArgumentError) }
+
     it "should get the resources" do
       subject.files user, repo, number
       a_get(request_path).should have_been_made

data/spec/github/pull_requests/get_spec.rb

@@ -21,9 +21,9 @@ describe Github::PullRequests, '#get' do
 
     it { should respond_to :find }
 
-    it "should fail to get resource without pull_request id" do
-      expect { subject.get nil }.to raise_error(ArgumentError)
-    end
+    it { expect { subject.get }.to raise_error(ArgumentError) }
+
+    it { expect { subject.get user }.to raise_error(ArgumentError) }
 
     it "should get the resource" do
       subject.get user, repo, number

data/spec/github/pull_requests/list_spec.rb

@@ -22,9 +22,9 @@ describe Github::PullRequests, '#list' do
 
     it { should respond_to :all }
 
-    it "throws error if pull_request id not provided" do
-      expect { subject.list nil }.to raise_error(ArgumentError)
-    end
+    it { expect { subject.list }.to raise_error(ArgumentError) }
+
+    it { expect { subject.list user }.to raise_error(ArgumentError) }
 
     it "should get the resources" do
       subject.list user, repo, inputs

data/spec/github/pull_requests/merge_spec.rb

@@ -19,6 +19,8 @@ describe Github::PullRequests, '#merge' do
     let(:body) { fixture('pull_requests/merge_success.json') }
     let(:status) { 200 }
 
+    it { expect { subject.merge }.to raise_error(ArgumentError) }
+
     it 'performs request' do
       subject.merge user, repo, number
       a_put(request_path).should have_been_made

data/spec/github/pull_requests/merged_spec.rb

@@ -18,8 +18,10 @@ describe Github::PullRequests, '#merged?' do
         :headers => {:user_agent => subject.user_agent})
     }
 
+    it { expect { subject.merged? }.to raise_error(ArgumentError) }
+
     it "should fail validation " do
-      expect { subject.merged?(nil, nil, number) }.to raise_error(ArgumentError)
+      expect { subject.merged?(user, repo) }.to raise_error(ArgumentError)
     end
 
     it "should return false if resource not found" do

data/spec/github/pull_requests/update_spec.rb

@@ -28,6 +28,10 @@ describe Github::PullRequests, '#update' do
     let(:body)   { fixture('pull_requests/pull_request.json') }
     let(:status) { 201 }
 
+    it { expect { subject.update }.to raise_error(ArgumentError) }
+
+    it { expect { subject.update user }.to raise_error(ArgumentError) }
+
     it "should create resource successfully" do
       subject.update user, repo, number, inputs
       a_patch(request_path).with(inputs).should have_been_made

data/spec/github/repos/collaborators/add_spec.rb

@@ -20,8 +20,10 @@ describe Github::Repos::Collaborators, '#add' do
     let(:body) { '' }
     let(:status) { 204 }
 
+    it { expect { subject.add }.to raise_error(ArgumentError) }
+
     it "should fail to add resource if 'collaborator' input is missing" do
-      expect { subject.add user, repo, nil }.to raise_error(ArgumentError)
+      expect { subject.add user, repo }.to raise_error(ArgumentError)
     end
 
     it "should add resource successfully" do

data/spec/github/repos/collaborators/get_spec.rb

@@ -21,9 +21,7 @@ describe Github::Repos::Collaborators, '#collaborator?' do
     let(:status) { 204 }
 
     it "should fail to get resource without collaborator name" do
-      expect {
-        subject.collaborator? user, repo, nil
-      }.to raise_error(ArgumentError)
+      expect { subject.collaborator? user, repo }.to raise_error(ArgumentError)
     end
 
     it "should get the resource" do

data/spec/github/repos/collaborators/list_spec.rb

@@ -19,10 +19,14 @@ describe Github::Repos::Collaborators, '#list' do
     let(:body) { fixture('repos/collaborators.json') }
     let(:status) { 200 }
 
-    it "should fail to get resource without username" do
+    it "should fail to get resource without arguments" do
       expect { subject.list }.to raise_error(ArgumentError)
     end
 
+    it "failse to get resource with missing arguments" do
+      expect { subject.list user }.to raise_error(ArgumentError)
+    end
+
     it "should get the resources" do
       subject.list user, repo
       a_get(request_path).should have_been_made

data/spec/github/repos/collaborators/remove_spec.rb

@@ -20,8 +20,10 @@ describe Github::Repos::Collaborators, '#remove' do
     let(:body) { '' }
     let(:status) { 204 }
 
+    it { expect { subject.remove }.to raise_error(ArgumentError) }
+
     it "should fail to add resource if 'collaborator' input is missing" do
-      expect { subject.remove user, repo, nil }.to raise_error(ArgumentError)
+      expect { subject.remove user, repo }.to raise_error(ArgumentError)
     end
 
     it "should add resource successfully" do

data/spec/github/repos/comments/create_spec.rb

@@ -27,6 +27,10 @@ describe Github::Repos::Comments, '#create' do
     let(:body)   { fixture('repos/commit_comment.json') }
     let(:status) { 201 }
 
+    it { expect { subject.create user }.to raise_error(ArgumentError) }
+
+    it { expect { subject.create }.to raise_error(ArgumentError) }
+
     it "should fail to create resource if 'body' input is missing" do
       expect {
         subject.create user, repo, sha, inputs.except('body')

data/spec/github/repos/comments/delete_spec.rb

@@ -20,13 +20,13 @@ describe Github::Repos::Comments, '#delete' do
     let(:body) { '' }
     let(:status) { 204 }
 
-    it "should fail to delete without 'user/repo' parameters" do
+    it "should fail to delete without required arguments" do
       expect { subject.delete }.to raise_error(ArgumentError)
     end
 
     it "should fail to delete resource without 'comment_id'" do
       expect {
-        subject.delete user, repo, nil
+        subject.delete user, repo
       }.to raise_error(ArgumentError)
     end
 

data/spec/github/repos/comments/get_spec.rb

@@ -21,8 +21,12 @@ describe Github::Repos::Comments, '#get' do
 
     it { should respond_to(:find) }
 
-    it "should fail to get resource without comment id" do
-      expect { subject.get user, repo, nil }.to raise_error(ArgumentError)
+    it 'failse to get resource without required arguments' do
+      expect { subject.get }.to raise_error(ArgumentError)
+    end
+
+    it 'fails to get resource without all required arguments' do
+      expect { subject.get user }.to raise_error(ArgumentError)
     end
 
     it "should get the resource" do

data/spec/github/repos/commits/compare_spec.rb

@@ -18,10 +18,10 @@ describe Github::Repos::Commits, '#compare' do
 
   after { reset_authentication_for(subject) }
 
+  it { expect { subject.compare }.to raise_error(ArgumentError) }
+
   it "should fail to get resource without base" do
-    expect {
-      subject.compare user, repo, nil, head
-    }.to raise_error(ArgumentError)
+    expect { subject.compare user, repo, nil, head }.to raise_error(ArgumentError)
   end
 
   it "should compare successfully" do