github_api 0.8.11 → 0.9.0

data/spec/github_spec.rb

@@ -5,7 +5,7 @@ require 'spec_helper'
 describe Github do
 
   after do
-    subject.set_defaults
+    subject.reset!
     reset_authentication_for subject
   end
 
@@ -94,11 +94,6 @@ describe Github do
     it "should have set mime type to json" do
       subject.mime_type.should == :json
     end
-
-    it "should allow to set current api client" do
-      subject.should respond_to :api_client=
-      subject.should respond_to :api_client
-    end
   end
 
   describe ".configure" do

data/spec/{github/gists → integration}/gists_spec.rb

@@ -6,6 +6,8 @@ describe Github::Gists do
 
   after { reset_authentication_for subject }
 
+  it_should_behave_like 'api interface'
+
   its(:comments)   { should be_a Github::Gists::Comments }
 
 end # Github::Gists

data/spec/{github/issues → integration}/issues_spec.rb

@@ -6,6 +6,8 @@ describe Github::Issues do
 
   after { reset_authentication_for subject }
 
+  it_should_behave_like 'api interface'
+
   its(:assignees)  { should be_a Github::Issues::Assignees }
 
   its(:comments)   { should be_a Github::Issues::Comments }

data/spec/integration/options_spec.rb

@@ -5,31 +5,111 @@ require 'spec_helper'
 describe Github, 'options' do
   let(:default_adapter) { :net_http }
   let(:adapter) { :patron }
+  let(:token) { '123' }
   let(:options) { { :adapter => adapter  } }
 
+  context 'when different instances of the same class' do
+    it 'instantiates the same api classes with different options' do
+      repos  = Github::Repos.new
+      repos2 = Github::Repos.new options
 
-  context '' do
-#     let(:github) { Github.new options }
-#     let(:repos)  { Github::Repos.new }
-
-    it '' do
-#       repos = Github::Repos.new
-#       expect(repos.adapter).to eql default_adapter
-#       expect(Github.current_api).to eql repos
-# 
-#       github = Github.new options
-#       expect(github.adapter).to eql adapter
-#       expect(Github.current_api).to eql github
-# 
-#       expect(github.repos.adapter).to eql adapter
-#       expect(Github.current_api).to_not eql github
-#       expect(Github.current_api).to eql github.repos
-# 
-#       expect(repos.adapter).to eql default_adapter
-# 
-#       new_github = Github.new
-#       expect(new_github.adapter).to eql default_adapter
-#       expect(Github.current_api).to eql new_github
+      expect(repos.object_id).to_not eql(repos2.object_id)
+
+      expect(repos.adapter).to eql default_adapter
+      expect(repos2.adapter).to eql adapter
+
+      repos.adapter = adapter
+      repos2.adapter = default_adapter
+
+      expect(repos.adapter).to eql adapter
+      expect(repos2.adapter).to eql default_adapter
+    end
+
+    it 'instantiates the same clients with different options' do
+      client  = Github.new :oauth_token => 'client'
+      client2 = Github.new :oauth_token => 'client2'
+
+      expect(client.object_id).to_not eql(client2.object_id)
+
+      expect(client.oauth_token).to eql 'client'
+      expect(client2.oauth_token).to eql 'client2'
     end
   end
-end
+
+  context 'when different instances of the same chain' do
+    it "inherits properties from client and doesn't pass them up the tree" do
+      client = Github.new options
+      repos  = client.repos
+
+      expect(client.adapter).to eql(adapter)
+      expect(repos.adapter).to eql(adapter)
+
+      repos.adapter = default_adapter
+      expect(client.adapter).to eql(adapter)
+      expect(repos.adapter).to eql(default_adapter)
+
+      client.oauth_token = token
+      expect(client.oauth_token).to eql(token)
+      expect(repos.oauth_token).to be_nil
+    end
+
+    it "inherits properties from api and doesn't pass them up the tree" do
+      repos    = Github::Repos.new options
+      comments = repos.comments
+
+      expect(repos.adapter).to eql(adapter)
+      expect(comments.adapter).to eql(adapter)
+
+      comments.adapter = default_adapter
+      expect(repos.adapter).to eql(adapter)
+      expect(comments.adapter).to eql(default_adapter)
+
+      repos.oauth_token = token
+      expect(repos.oauth_token).to eql(token)
+      expect(comments.oauth_token).to be_nil
+    end
+  end
+
+  context 'when setting attributes through accessors' do
+    let(:default_endpoint) { 'https://api.github.com'}
+    let(:endpoint) { 'https://my-company/api/v3' }
+    let(:login) { 'Piotr' }
+
+    it 'sets login on correct instance' do
+      client = Github.new :login => login
+      expect(Github.login).to be_nil
+      expect(client.login).to eql login
+    end
+
+    it 'sets attribute' do
+      client = Github.new options
+      client.endpoint = endpoint
+      expect(Github.endpoint).to eql default_endpoint
+      expect(client.endpoint).to eql endpoint
+    end
+
+    it 'sets attribute through dsl' do
+      client = Github.new do |config|
+        config.endpoint = endpoint
+      end
+      expect(client.endpoint).to eql endpoint
+      repos = client.repos do |config|
+        config.adapter = adapter
+      end
+      expect(repos.endpoint).to eql endpoint
+      expect(repos.adapter).to eql adapter
+    end
+
+    it 'updates current_options through api setters' do
+      client = Github.new :endpoint => endpoint
+      expect(client.repos.current_options[:endpoint]).to eql endpoint
+      expect(client.repos.endpoint).to eql endpoint
+
+      client.repos.endpoint = default_endpoint
+
+      expect(client.repos.endpoint).to eql default_endpoint
+      expect(client.repos.current_options[:endpoint]).to eql default_endpoint
+    end
+  end
+
+end # options

data/spec/{github → integration}/repos_spec.rb

@@ -14,6 +14,8 @@ describe Github::Repos, 'integration' do
 
   its(:commits)       { should be_a Github::Repos::Commits }
 
+  its(:contents)      { should be_a Github::Repos::Contents }
+
   its(:downloads)     { should be_a Github::Repos::Downloads }
 
   its(:forks)         { should be_a Github::Repos::Forks }

data/spec/shared/array_of_resources_behaviour.rb

@@ -4,7 +4,7 @@ shared_examples_for 'an array of resources' do
 
   it "should return array of resources" do
     objects = requestable
-    objects.should be_an Array
+    objects.should be_a Enumerable
     objects.should have(1).items
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: github_api
 version: !ruby/object:Gem::Version
-  version: 0.8.11
+  version: 0.9.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-02-09 00:00:00.000000000Z
+date: 2013-02-18 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: hashie
-  requirement: &2154734500 !ruby/object:Gem::Requirement
+  requirement: &2154928480 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,10 +21,10 @@ dependencies:
         version: 1.2.0
   type: :runtime
   prerelease: false
-  version_requirements: *2154734500
+  version_requirements: *2154928480
 - !ruby/object:Gem::Dependency
   name: faraday
-  requirement: &2154734000 !ruby/object:Gem::Requirement
+  requirement: &2154927980 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -32,10 +32,10 @@ dependencies:
         version: 0.8.1
   type: :runtime
   prerelease: false
-  version_requirements: *2154734000
+  version_requirements: *2154927980
 - !ruby/object:Gem::Dependency
   name: multi_json
-  requirement: &2154733540 !ruby/object:Gem::Requirement
+  requirement: &2154927520 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,10 +43,10 @@ dependencies:
         version: '1.4'
   type: :runtime
   prerelease: false
-  version_requirements: *2154733540
+  version_requirements: *2154927520
 - !ruby/object:Gem::Dependency
   name: oauth2
-  requirement: &2154733160 !ruby/object:Gem::Requirement
+  requirement: &2154927140 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2154733160
+  version_requirements: *2154927140
 - !ruby/object:Gem::Dependency
   name: nokogiri
-  requirement: &2154732620 !ruby/object:Gem::Requirement
+  requirement: &2154926600 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -65,10 +65,10 @@ dependencies:
         version: 1.5.2
   type: :runtime
   prerelease: false
-  version_requirements: *2154732620
+  version_requirements: *2154926600
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &2154732120 !ruby/object:Gem::Requirement
+  requirement: &2154926100 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,10 +76,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2154732120
+  version_requirements: *2154926100
 - !ruby/object:Gem::Dependency
   name: cucumber
-  requirement: &2154731660 !ruby/object:Gem::Requirement
+  requirement: &2154925640 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -87,10 +87,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2154731660
+  version_requirements: *2154925640
 - !ruby/object:Gem::Dependency
   name: webmock
-  requirement: &2154731200 !ruby/object:Gem::Requirement
+  requirement: &2154925180 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -98,10 +98,10 @@ dependencies:
         version: 1.9.0
   type: :development
   prerelease: false
-  version_requirements: *2154731200
+  version_requirements: *2154925180
 - !ruby/object:Gem::Dependency
   name: vcr
-  requirement: &2154730740 !ruby/object:Gem::Requirement
+  requirement: &2154924720 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -109,10 +109,10 @@ dependencies:
         version: 2.4.0
   type: :development
   prerelease: false
-  version_requirements: *2154730740
+  version_requirements: *2154924720
 - !ruby/object:Gem::Dependency
   name: simplecov
-  requirement: &2154730280 !ruby/object:Gem::Requirement
+  requirement: &2154924260 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -120,10 +120,10 @@ dependencies:
         version: 0.7.1
   type: :development
   prerelease: false
-  version_requirements: *2154730280
+  version_requirements: *2154924260
 - !ruby/object:Gem::Dependency
   name: guard
-  requirement: &2154729900 !ruby/object:Gem::Requirement
+  requirement: &2154923880 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -131,10 +131,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2154729900
+  version_requirements: *2154923880
 - !ruby/object:Gem::Dependency
   name: guard-rspec
-  requirement: &2154729440 !ruby/object:Gem::Requirement
+  requirement: &2154923420 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -142,10 +142,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2154729440
+  version_requirements: *2154923420
 - !ruby/object:Gem::Dependency
   name: guard-cucumber
-  requirement: &2154729020 !ruby/object:Gem::Requirement
+  requirement: &2154919140 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -153,10 +153,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2154729020
+  version_requirements: *2154919140
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &2154728600 !ruby/object:Gem::Requirement
+  requirement: &2154918720 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -164,10 +164,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2154728600
+  version_requirements: *2154918720
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &2154728180 !ruby/object:Gem::Requirement
+  requirement: &2154918300 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -175,7 +175,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2154728180
+  version_requirements: *2154918300
 description: ! ' Ruby wrapper that supports all of the GitHub API v3 methods(nearly
   200). It''s build in a modular way, that is, you can either instantiate the whole
   api wrapper Github.new or use parts of it e.i. Github::Repos.new if working solely
@@ -187,6 +187,7 @@ extra_rdoc_files: []
 files:
 - Rakefile
 - features/activity/events.feature
+- features/activity/notifications.feature
 - features/activity/starring.feature
 - features/activity/watching.feature
 - features/cassettes/activity/events/issue.yml
@@ -197,6 +198,7 @@ files:
 - features/cassettes/activity/events/received.yml
 - features/cassettes/activity/events/repo.yml
 - features/cassettes/activity/events/user_org.yml
+- features/cassettes/activity/notifications/list_user.yml
 - features/cassettes/activity/starring/list.yml
 - features/cassettes/activity/starring/star.yml
 - features/cassettes/activity/starring/starred.yml
@@ -415,8 +417,8 @@ files:
 - lib/github_api/orgs.rb
 - lib/github_api/page_iterator.rb
 - lib/github_api/page_links.rb
-- lib/github_api/page_uri_processor.rb
 - lib/github_api/paged_request.rb
+- lib/github_api/pagination.rb
 - lib/github_api/parameter_filter.rb
 - lib/github_api/params_hash.rb
 - lib/github_api/pull_requests/comments.rb
@@ -440,13 +442,13 @@ files:
 - lib/github_api/request.rb
 - lib/github_api/requestable.rb
 - lib/github_api/resource.rb
-- lib/github_api/response/helpers.rb
+- lib/github_api/response/header.rb
 - lib/github_api/response/jsonize.rb
 - lib/github_api/response/mashify.rb
 - lib/github_api/response/raise_error.rb
 - lib/github_api/response/xmlize.rb
 - lib/github_api/response.rb
-- lib/github_api/result.rb
+- lib/github_api/response_wrapper.rb
 - lib/github_api/s3_uploader.rb
 - lib/github_api/say.rb
 - lib/github_api/scopes.rb
@@ -553,7 +555,6 @@ files:
 - spec/fixtures/users/keys.json
 - spec/fixtures/users/user.json
 - spec/fixtures/users/users.json
-- spec/github/activity/activity_spec.rb
 - spec/github/activity/events/issue_spec.rb
 - spec/github/activity/events/network_spec.rb
 - spec/github/activity/events/org_spec.rb
@@ -582,6 +583,11 @@ files:
 - spec/github/api_factory_spec.rb
 - spec/github/api_spec.rb
 - spec/github/authorization_spec.rb
+- spec/github/authorizations/create_spec.rb
+- spec/github/authorizations/delete_spec.rb
+- spec/github/authorizations/get_spec.rb
+- spec/github/authorizations/list_spec.rb
+- spec/github/authorizations/update_spec.rb
 - spec/github/authorizations_spec.rb
 - spec/github/client_spec.rb
 - spec/github/core_ext/hash_spec.rb
@@ -603,7 +609,6 @@ files:
 - spec/github/gists/edit_spec.rb
 - spec/github/gists/fork_spec.rb
 - spec/github/gists/get_spec.rb
-- spec/github/gists/gists_spec.rb
 - spec/github/gists/is_starred_spec.rb
 - spec/github/gists/list_spec.rb
 - spec/github/gists/star_spec.rb
@@ -615,7 +620,6 @@ files:
 - spec/github/git_data/commits/create_spec.rb
 - spec/github/git_data/commits/get_spec.rb
 - spec/github/git_data/commits_spec.rb
-- spec/github/git_data/git_data_spec.rb
 - spec/github/git_data/references/create_spec.rb
 - spec/github/git_data/references/delete_spec.rb
 - spec/github/git_data/references/get_spec.rb
@@ -645,7 +649,6 @@ files:
 - spec/github/issues/events/list_spec.rb
 - spec/github/issues/events_spec.rb
 - spec/github/issues/get_spec.rb
-- spec/github/issues/issues_spec.rb
 - spec/github/issues/labels/add_spec.rb
 - spec/github/issues/labels/create_spec.rb
 - spec/github/issues/labels/delete_spec.rb
@@ -673,7 +676,6 @@ files:
 - spec/github/orgs/members/member_spec.rb
 - spec/github/orgs/members/publicize_spec.rb
 - spec/github/orgs/members_spec.rb
-- spec/github/orgs/orgs_spec.rb
 - spec/github/orgs/teams/add_member_spec.rb
 - spec/github/orgs/teams/add_repo_spec.rb
 - spec/github/orgs/teams/create_spec.rb
@@ -688,9 +690,10 @@ files:
 - spec/github/orgs/teams/team_member_spec.rb
 - spec/github/orgs/teams/team_repo_spec.rb
 - spec/github/orgs/teams_spec.rb
-- spec/github/page_iterator_spec.rb
 - spec/github/page_links_spec.rb
 - spec/github/paged_request_spec.rb
+- spec/github/pagination/iterator/number_spec.rb
+- spec/github/pagination/iterator/sha_spec.rb
 - spec/github/parameter_filter_spec.rb
 - spec/github/pull_requests/comments/create_spec.rb
 - spec/github/pull_requests/comments/delete_spec.rb
@@ -705,7 +708,6 @@ files:
 - spec/github/pull_requests/list_spec.rb
 - spec/github/pull_requests/merge_spec.rb
 - spec/github/pull_requests/merged_spec.rb
-- spec/github/pull_requests/pull_requests_spec.rb
 - spec/github/pull_requests/update_spec.rb
 - spec/github/repos/branch_spec.rb
 - spec/github/repos/branches_spec.rb
@@ -760,12 +762,12 @@ files:
 - spec/github/repos/statuses_spec.rb
 - spec/github/repos/tags_spec.rb
 - spec/github/repos/teams_spec.rb
-- spec/github/repos_spec.rb
+- spec/github/request/endpoint_spec.rb
 - spec/github/request/jsonize_spec.rb
 - spec/github/request/oauth2_spec.rb
+- spec/github/request/request_spec.rb
 - spec/github/request_spec.rb
-- spec/github/response/helpers_spec.rb
-- spec/github/result_spec.rb
+- spec/github/response_wrapper_spec.rb
 - spec/github/s3_uploader_spec.rb
 - spec/github/scopes/list_spec.rb
 - spec/github/search_spec.rb
@@ -785,7 +787,6 @@ files:
 - spec/github/users/keys/update_spec.rb
 - spec/github/users/list_spec.rb
 - spec/github/users/update_spec.rb
-- spec/github/users/users_spec.rb
 - spec/github/utils/url_spec.rb
 - spec/github/validations/format_spec.rb
 - spec/github/validations/presence_spec.rb
@@ -793,7 +794,15 @@ files:
 - spec/github/validations/token_spec.rb
 - spec/github/validations_spec.rb
 - spec/github_spec.rb
+- spec/integration/activity_spec.rb
+- spec/integration/gists_spec.rb
+- spec/integration/git_data_spec.rb
+- spec/integration/issues_spec.rb
 - spec/integration/options_spec.rb
+- spec/integration/orgs_spec.rb
+- spec/integration/pull_requests_spec.rb
+- spec/integration/repos_spec.rb
+- spec/integration/users_spec.rb
 - spec/README.rdoc
 - spec/shared/api_interface_behaviour.rb
 - spec/shared/array_of_resources_behaviour.rb