github_api 0.8.11 → 0.9.0

data/spec/github/git_data/tags/create_spec.rb

@@ -45,7 +45,7 @@ describe Github::GitData::Tags, '#create' do
 
     it "should return the resource" do
       tag = subject.create user, repo, inputs
-      tag.should be_a Hashie::Mash
+      tag.should be_a Github::ResponseWrapper
     end
 
     it "should get the tag information" do

data/spec/github/git_data/tags/get_spec.rb

@@ -37,7 +37,7 @@ describe Github::GitData::Tags, '#get' do
 
     it "should return mash" do
       tag = subject.get user, repo, sha
-      tag.should be_a Hashie::Mash
+      tag.should be_a Github::ResponseWrapper
     end
   end
 

data/spec/github/git_data/trees/create_spec.rb

@@ -46,7 +46,7 @@ describe Github::GitData::Trees, '#create' do
 
     it "should return the resource" do
       tree_sha = subject.create user, repo, inputs
-      tree_sha.should be_a Hashie::Mash
+      tree_sha.should be_a Github::ResponseWrapper
     end
 
     it "should get the tree information" do

data/spec/github/git_data/trees/get_spec.rb

@@ -35,9 +35,9 @@ describe Github::GitData::Trees, '#get' do
       tree.sha.should eql sha
     end
 
-    it "should return mash" do
+    it "should return response wrapper" do
       tree = subject.get user, repo, sha
-      tree.should be_a Hashie::Mash
+      tree.should be_a Github::ResponseWrapper
     end
   end
 
@@ -56,9 +56,9 @@ describe Github::GitData::Trees, '#get' do
       tree.sha.should eql sha
     end
 
-    it "should return mash" do
+    it "should return response wrapper" do
       tree = subject.get user, repo, sha, 'recursive' => true
-      tree.should be_a Hashie::Mash
+      tree.should be_a Github::ResponseWrapper
     end
   end
 

data/spec/github/issues/comments/create_spec.rb

@@ -34,7 +34,7 @@ describe Github::Issues::Comments, '#create' do
 
     it "should return the resource" do
       comment = subject.create user, repo, issue_id, inputs
-      comment.should be_a Hashie::Mash
+      comment.should be_a Github::ResponseWrapper
     end
 
     it "should get the comment information" do

data/spec/github/issues/comments/edit_spec.rb

@@ -34,7 +34,7 @@ describe Github::Issues::Comments, '#edit' do
 
     it "should return the resource" do
       comment = subject.edit user, repo, comment_id, inputs
-      comment.should be_a Hashie::Mash
+      comment.should be_a Github::ResponseWrapper
     end
 
     it "should get the comment information" do

data/spec/github/issues/comments/get_spec.rb

@@ -38,7 +38,7 @@ describe Github::Issues::Comments, '#get' do
 
     it "should return mash" do
       comment = subject.get user, repo, comment_id
-      comment.should be_a Hashie::Mash
+      comment.should be_a Github::ResponseWrapper
     end
   end
 

data/spec/github/issues/create_spec.rb

@@ -44,7 +44,7 @@ describe Github::Issues, '#create' do
 
     it "should return the resource" do
       issue = subject.create user, repo, inputs
-      issue.should be_a Hashie::Mash
+      issue.should be_a Github::ResponseWrapper
     end
 
     it "should get the issue information" do

data/spec/github/issues/edit_spec.rb

@@ -45,7 +45,7 @@ describe Github::Issues, '#edit' do
 
     it "should return resource" do
       issue = subject.edit user, repo, issue_id, inputs
-      issue.should be_a Hashie::Mash
+      issue.should be_a Github::ResponseWrapper
     end
 
     it "should be able to retrieve information" do

data/spec/github/issues/events/get_spec.rb

@@ -38,7 +38,7 @@ describe Github::Issues::Events, '#list' do
 
     it "should return mash" do
       event = subject.get user, repo, event_id
-      event.should be_a Hashie::Mash
+      event.should be_a Github::ResponseWrapper
     end
   end
 

data/spec/github/issues/get_spec.rb

@@ -38,7 +38,7 @@ describe Github::Issues, '#get' do
 
     it "should return mash" do
       issue = subject.get user, repo, issue_id
-      issue.should be_a Hashie::Mash
+      issue.should be_a Github::ResponseWrapper
     end
   end
 

data/spec/github/issues/labels/create_spec.rb

@@ -44,7 +44,7 @@ describe Github::Issues::Labels, '#create' do
 
     it "should return the resource" do
       label = subject.create user, repo, inputs
-      label.should be_a Hashie::Mash
+      label.should be_a Github::ResponseWrapper
     end
 
     it "should get the label information" do

data/spec/github/issues/labels/get_spec.rb

@@ -37,7 +37,7 @@ describe Github::Issues::Labels, '#get' do
 
     it "should return mash" do
       label = subject.get user, repo, label_id
-      label.should be_a Hashie::Mash
+      label.should be_a Github::ResponseWrapper
     end
   end
 

data/spec/github/issues/labels/update_spec.rb

@@ -45,7 +45,7 @@ describe Github::Issues::Labels, '#update' do
 
     it "should return the resource" do
       label = subject.update user, repo, label_id, inputs
-      label.should be_a Hashie::Mash
+      label.should be_a Github::ResponseWrapper
     end
 
     it "should get the label information" do

data/spec/github/issues/milestones/create_spec.rb

@@ -40,7 +40,7 @@ describe Github::Issues::Milestones, '#create' do
 
     it "should return the resource" do
       milestone = subject.create user, repo, inputs
-      milestone.should be_a Hashie::Mash
+      milestone.should be_a Github::ResponseWrapper
     end
 
     it "should get the milestone information" do

data/spec/github/issues/milestones/delete_spec.rb

@@ -26,7 +26,7 @@ describe Github::Issues::Milestones, '#create' do
 
     it "should return the resource" do
       milestone = subject.delete user, repo, milestone_id
-      milestone.should be_a Hashie::Mash
+      milestone.should be_a Github::ResponseWrapper
     end
 
     it "should get the milestone information" do

data/spec/github/issues/milestones/get_spec.rb

@@ -38,7 +38,7 @@ describe Github::Issues::Milestones, '#get' do
 
     it "should return mash" do
       milestone = subject.get user, repo, milestone_id
-      milestone.should be_a Hashie::Mash
+      milestone.should be_a Github::ResponseWrapper
     end
   end
 

data/spec/github/issues/milestones/update_spec.rb

@@ -41,7 +41,7 @@ describe Github::Issues::Milestones, '#update' do
 
     it "should return the resource" do
       milestone = subject.update user, repo, milestone_id, inputs
-      milestone.should be_a Hashie::Mash
+      milestone.should be_a Github::ResponseWrapper
     end
 
     it "should get the milestone information" do

data/spec/github/orgs/edit_spec.rb

@@ -38,7 +38,7 @@ describe Github::Orgs, '#edit' do
 
     it "should return resource" do
       organisation = subject.edit org
-      organisation.should be_a Hashie::Mash
+      organisation.should be_a Github::ResponseWrapper
     end
 
     it "should be able to retrieve information" do

data/spec/github/orgs/get_spec.rb

@@ -33,7 +33,7 @@ describe Github::Orgs, '#get' do
 
     it "should return mash" do
       organisation = subject.get org
-      organisation.should be_a Hashie::Mash
+      organisation.should be_a Github::ResponseWrapper
     end
   end
 

data/spec/github/orgs/teams/create_spec.rb

@@ -42,7 +42,7 @@ describe Github::Orgs::Teams, '#create' do
 
     it "should return the resource" do
       team = subject.create org, inputs
-      team.should be_a Hashie::Mash
+      team.should be_a Github::ResponseWrapper
     end
 
     it "should get the team information" do

data/spec/github/orgs/teams/edit_spec.rb

@@ -41,7 +41,7 @@ describe Github::Orgs::Teams, '#edit' do
 
     it "should return the resource" do
       edited_team = subject.edit team, inputs
-      edited_team.should be_a Hashie::Mash
+      edited_team.should be_a Github::ResponseWrapper
     end
 
     it "should get the team information" do

data/spec/github/orgs/teams/get_spec.rb

@@ -34,7 +34,7 @@ describe Github::Orgs::Teams, '#get' do
 
     it "should return mash" do
       team_res = subject.get team
-      team_res.should be_a Hashie::Mash
+      team_res.should be_a Github::ResponseWrapper
     end
   end
 

data/spec/github/paged_request_spec.rb

@@ -2,39 +2,44 @@
 
 require 'spec_helper'
 
-describe Github::PagedRequest do
-  it { described_class.constants.should include :FIRST_PAGE }
-  it { described_class.constants.should include :PER_PAGE }
-  it { described_class.constants.should include :NOT_FOUND }
-
-  context 'page_request' do
-    let(:path) { '/repos' }
-    let(:client) { Github::Client }
-
-    before do
-      Github.stub(:api_client).and_return client
-      client.stub(:get_request)
+describe Github::PagedRequest, '#page_request' do
+  let(:current_api) { Github::Repos.new }
+  let(:path) { "/repositories/"}
+  let(:klass) {
+    klass = Class.new do
+      include Github::PagedRequest
     end
+  }
 
-    it 'sets default per_page when only custom page passed' do
-      Github.stub_chain(:api_client, :per_page).and_return nil
-      Github::PagedRequest.page_request path, {'page' => 3, 'per_page' => -1}
-      Github::PagedRequest.page.should eq 3
-      Github::PagedRequest.per_page.should eq 30
-    end
+  subject(:instance) { klass.new }
 
-    it 'sets default page when only custom per_page passed' do
-      Github.stub_chain(:api_client, :page).and_return nil
-      Github::PagedRequest.page_request path, {'per_page' => 33, 'page' => -1}
-      Github::PagedRequest.page.should eq 1
-      Github::PagedRequest.per_page.should eq 33
-    end
+  before {
+    instance.stub(:current_api).and_return current_api
+  }
 
-    it 'sends get request with passed parameters' do
-      Github::Client.should_receive(:get_request).
-        with(path, 'page' => 2, 'per_page' => 33)
-      Github::PagedRequest.page_request path, {'page' => 2, 'per_page' => 33}
-    end
+  it { klass.constants.should include :FIRST_PAGE }
+
+  it { klass.constants.should include :PER_PAGE }
+
+  it { klass.constants.should include :NOT_FOUND }
+
+  it { should respond_to(:page_request) }
+
+  it 'calls get_request on api current instance' do
+    current_api.should_receive(:get_request).with(path, {})
+    instance.page_request(path)
+  end
+
+  it 'sets default per_page when only custom page passed' do
+    current_api.should_receive(:get_request).
+      with(path, {'page' => 3, 'per_page' => 30})
+    instance.page_request(path, {'page' => 3, 'per_page' => -1})
+  end
+
+  it 'sets default page when only custom per_page passed' do
+    current_api.should_receive(:get_request).
+      with(path, {'page' => 1, 'per_page' => 33})
+    instance.page_request(path, {'page' => -1, 'per_page' => 33})
   end
 
 end # Github::PagedRequest

data/spec/github/pagination/iterator/number_spec.rb

@@ -0,0 +1,118 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::PageIterator, 'when number' do
+  let(:header) { {"Link" => "<https://api.github.com/users/wycats/repos?page=4&per_page=20>; rel=\"next\", <https://api.github.com/users/wycats/repos?page=6&per_page=20>; rel=\"last\", <https://api.github.com/users/wycats/repos?page=1&per_page=20>; rel=\"first\", <https://api.github.com/users/wycats/repos?page=2&per_page=20>; rel=\"prev\""}
+  }
+  let(:links) { Github::PageLinks.new(header) }
+
+  let(:first_link) { "https://api.github.com/users/wycats/repos?page=1&per_page=20" }
+  let(:next_link) { "https://api.github.com/users/wycats/repos?page=4&per_page=20" }
+  let(:prev_link) { "https://api.github.com/users/wycats/repos?page=2&per_page=20" }
+  let(:last_link) { "https://api.github.com/users/wycats/repos?page=6&per_page=20" }
+
+  let(:current_api) { Github::Repos.new }
+  let(:user)   { 'wycats' }
+  let(:response) { stub(:response).as_null_object }
+
+  subject(:instance) { described_class.new(links, current_api) }
+
+  before {
+    instance.stub(:has_next?).and_return true
+    stub_get("/users/#{user}/repos").
+      with(:query => { 'page' => '4', 'per_page' => '20'}).
+      to_return(:body => '', :status => 200, :headers => header)
+  }
+
+  it { described_class::ATTRIBUTES.should_not be_nil }
+
+  its(:first_page) { should eq 1 }
+
+  its(:first_page_uri) { should eq first_link }
+
+  its(:next_page) { should eq 4 }
+
+  its(:next_page_uri) { should eq next_link}
+
+  its(:prev_page) { should eq 2 }
+
+  its(:prev_page_uri) { should eq prev_link }
+
+  its(:last_page) { should eq 6 }
+
+  its(:last_page_uri) { should eq last_link }
+
+  context 'has_next?' do
+    it "return true when next_page_uri is present" do
+      expect(instance.has_next?).to be_true
+    end
+  end
+
+  context 'first page request' do
+    it 'returns nil if there are no more pages' do
+      instance.stub(:first_page_uri).and_return false
+      expect(instance.first).to be_nil
+    end
+
+    it 'performs request' do
+      instance.should_receive(:page_request).
+        with("/users/#{user}/repos", 'per_page' => 20, 'page' => 1).
+        and_return response
+      instance.first
+    end
+  end
+
+  context 'next page request' do
+    it 'returns nil if there are no more pages' do
+      instance.stub(:has_next?).and_return false
+      expect(instance.next).to be_nil
+    end
+
+    it 'performs request' do
+      instance.should_receive(:page_request).with("/users/#{user}/repos",
+          'page' => 4,'per_page' => 20).and_return response
+      instance.next
+    end
+  end
+
+  context 'prev page request' do
+    it 'returns nil if there are no more pages' do
+      instance.stub(:prev_page_uri).and_return false
+      expect(instance.prev).to be_nil
+    end
+
+    it 'performs request' do
+      instance.should_receive(:page_request).with("/users/#{user}/repos",
+          'page' => 2,'per_page' => 20).and_return response
+      instance.prev
+    end
+  end
+
+  context 'last page request' do
+    it 'returns nil if there are no more pages' do
+      instance.stub(:last_page_uri).and_return false
+      expect(instance.last).to be_nil
+    end
+
+    it 'performs request' do
+      instance.should_receive(:page_request).with("/users/#{user}/repos",
+          'page' => 6,'per_page' => 20).and_return response
+      instance.last
+    end
+  end
+
+  context 'get_page request' do
+    it 'returns nil if there are no more pages' do
+      instance.stub(:first_page_uri).and_return nil
+      instance.stub(:last_page_uri).and_return nil
+      expect(instance.get_page(5)).to be_nil
+    end
+
+    it 'performs request' do
+      instance.should_receive(:page_request).with("/users/#{user}/repos",
+          'page' => 2,'per_page' => 20).and_return response
+      instance.get_page(2)
+    end
+  end
+end

data/spec/github/pagination/iterator/sha_spec.rb

@@ -0,0 +1,67 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::PageIterator, 'when sha' do
+  let(:header) { {"Link" => "<https://api.github.com/repos/peter-murach/github/commits?last_sha=d1e503c02fa770859895dd0d12aedefa28b95723&per_page=30&sha=801d80dfd59bf1d2cb30a243799953ab683a3abd&top=801d80dfd59bf1d2cb30a243799953ab683a3abd>; rel=\"next\", <https://api.github.com/repos/peter-murach/github/commits?per_page=30&sha=801d80dfd59bf1d2cb30a243799953ab683a3abd>; rel=\"first\"" }
+  }
+  let(:links) { Github::PageLinks.new(header) }
+
+  let(:first_link) { "https://api.github.com/repos/peter-murach/github/commits?per_page=30&sha=801d80dfd59bf1d2cb30a243799953ab683a3abd" }
+  let(:next_link)  { "https://api.github.com/repos/peter-murach/github/commits?last_sha=d1e503c02fa770859895dd0d12aedefa28b95723&per_page=30&sha=801d80dfd59bf1d2cb30a243799953ab683a3abd&top=801d80dfd59bf1d2cb30a243799953ab683a3abd" }
+
+  let(:top_sha)  { '801d80dfd59bf1d2cb30a243799953ab683a3abd' }
+  let(:sha)      { '801d80dfd59bf1d2cb30a243799953ab683a3abd' }
+  let(:last_sha) { "d1e503c02fa770859895dd0d12aedefa28b95723"}
+
+  let(:current_api) { Github::Repos.new }
+  let(:user)   { 'wycats' }
+  let(:response) { stub(:response).as_null_object }
+
+  subject(:instance) { described_class.new(links, current_api) }
+
+  before {
+    instance.stub(:has_next?).and_return true
+    instance.stub(:next_page).and_return -1
+    stub_get("/repos/peter-murach/github/commits").
+      to_return(:body => '', :status => 200, :headers => header)
+  }
+
+  it { described_class::ATTRIBUTES.should_not be_nil }
+
+  its(:first_page) { should eq -1 }
+
+  its(:first_page_uri) { should eq first_link }
+
+  its(:next_page) { should eq -1 }
+
+  its(:next_page_uri) { should eq next_link}
+
+  its(:prev_page) { should eq -1 }
+
+  its(:prev_page_uri) { should be_nil }
+
+  its(:last_page) { should eq -1 }
+
+  its(:last_page_uri) { should be_nil }
+
+  context 'first page request' do
+    it 'performs request' do
+      instance.should_receive(:page_request).
+        with("/repos/peter-murach/github/commits",
+          'sha' => 'master', 'per_page' => 30).and_return response
+      instance.first
+    end
+  end
+
+  context 'next page request' do
+    it 'performs request' do
+      instance.should_receive(:page_request).
+        with("/repos/peter-murach/github/commits", 'last_sha' => last_sha,
+          'sha' => last_sha, 'per_page' => 30, 'top' => top_sha).
+        and_return response
+      instance.next
+    end
+  end
+
+end