github_api 0.8.11 → 0.9.0

data/spec/github/authorizations/update_spec.rb

@@ -0,0 +1,50 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Authorizations, '#update' do
+  let(:basic_auth) { 'login:password' }
+  let(:request_path) { "/authorizations/#{authorization_id}" }
+  let(:host) { "https://#{basic_auth}@api.github.com" }
+  let(:authorization_id) { 1 }
+  let(:inputs) { { :add_scopes => ['repo'] } }
+
+  before {
+    stub_patch(request_path, host).to_return(:body => body, :status => status,
+      :headers => {:content_type => "application/json; charset=utf-8"})
+  }
+
+  before { subject.basic_auth = basic_auth }
+
+  after { reset_authentication_for(subject) }
+
+  context "resouce updated" do
+    let(:body) { fixture('auths/authorization.json') }
+    let(:status) { 201 }
+
+    it "should fail to get resource without basic authentication" do
+      reset_authentication_for subject
+      expect { subject.update }.to raise_error(ArgumentError)
+    end
+
+    it "should update resource successfully" do
+      subject.update authorization_id, inputs
+      a_patch(request_path, host).with(inputs).should have_been_made
+    end
+
+    it "should return the resource" do
+      authorization = subject.update authorization_id, inputs
+      authorization.should be_a Github::ResponseWrapper
+    end
+
+    it "should get the authorization information" do
+      authorization = subject.update authorization_id, inputs
+      authorization.token.should == 'abc123'
+    end
+  end
+
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.update authorization_id, inputs }
+  end
+
+end # update

data/spec/github/authorizations_spec.rb

@@ -3,243 +3,9 @@
 require 'spec_helper'
 
 describe Github::Authorizations do
-  let(:github) { Github.new }
-  let(:basic_auth) { 'login:password' }
 
-  before do
-    github.basic_auth = basic_auth
-  end
+  after { reset_authentication_for subject }
 
-  after do
-    reset_authentication_for github
-  end
-
-  describe "authorizations" do
-    it { github.authorizations.should respond_to :all }
-
-    context "resource found" do
-      before do
-        stub_get("/authorizations", "https://#{basic_auth}@api.github.com").
-          to_return(:body => fixture('auths/authorizations.json'), :status => 200, :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-
-      it "should fail to get resource without basic authentication" do
-        reset_authentication_for github
-        expect { github.oauth.list }.to raise_error(ArgumentError)
-      end
-
-      it "should get the resources" do
-        github.oauth.list
-        a_get("/authorizations", "https://#{basic_auth}@api.github.com").should have_been_made
-      end
-
-      it "should return array of resources" do
-        authorizations = github.oauth.list
-        authorizations.should be_an Array
-        authorizations.should have(1).items
-      end
-
-      it "should be a mash type" do
-        authorizations = github.oauth.list
-        authorizations.first.should be_a Hashie::Mash
-      end
-
-      it "should get authorization information" do
-        authorizations = github.oauth.list
-        authorizations.first.token.should == 'abc123'
-      end
-
-      it "should yield to a block" do
-        github.oauth.should_receive(:list).and_yield('web')
-        github.oauth.list { |param| 'web' }
-      end
-    end
-
-    context "resource not found" do
-      before do
-        stub_get("/authorizations", "https://#{basic_auth}@api.github.com").
-          to_return(:body => "", :status => [404, "Not Found"])
-      end
-
-      it "should return 404 with a message 'Not Found'" do
-        expect { github.oauth.list }.to raise_error(Github::Error::NotFound)
-      end
-    end
-  end # authorizations
-
-  describe "#get" do
-    let(:authorization_id) { 1 }
-
-    context "resource found" do
-      before do
-        stub_get("/authorizations/#{authorization_id}", "https://#{basic_auth}@api.github.com").
-          to_return(:body => fixture('auths/authorization.json'), :status => 200, :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should fail to get resource without authorization id" do
-        expect { github.oauth.get nil }.to raise_error(ArgumentError)
-      end
-
-      it "should get the resource" do
-        github.oauth.get authorization_id
-        a_get("/authorizations/#{authorization_id}", "https://#{basic_auth}@api.github.com").should have_been_made
-      end
-
-      it "should get authorization information" do
-        authorization = github.oauth.get authorization_id
-        authorization.id.should == authorization_id
-        authorization.token.should == 'abc123'
-      end
-
-      it "should return mash" do
-        authorization = github.oauth.get authorization_id
-        authorization.should be_a Hashie::Mash
-      end
-    end
-
-    context "resource not found" do
-      before do
-        stub_get("/authorizations/#{authorization_id}", "https://#{basic_auth}@api.github.com").
-          to_return(:body => fixture('auths/authorization.json'), :status => 404, :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should fail to retrive resource" do
-        expect {
-          github.oauth.get authorization_id
-        }.to raise_error(Github::Error::NotFound)
-      end
-    end
-  end # list
-
-  describe "#create" do
-    let(:inputs) { { :scopes => ['repo'] } }
-
-    context "resouce created" do
-
-      it "should fail to get resource without basic authentication" do
-        reset_authentication_for github
-        expect { github.oauth.create }.to raise_error(ArgumentError)
-      end
-
-      before do
-        stub_post("/authorizations", "https://#{basic_auth}@api.github.com").with(inputs).
-          to_return(:body => fixture('auths/authorization.json'), :status => 201, :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should create resource successfully" do
-        github.oauth.create inputs
-        a_post("/authorizations", "https://#{basic_auth}@api.github.com").with(inputs).should have_been_made
-      end
-
-      it "should return the resource" do
-        authorization = github.oauth.create inputs
-        authorization.should be_a Hashie::Mash
-      end
-
-      it "should get the authorization information" do
-        authorization = github.oauth.create inputs
-        authorization.token.should == 'abc123'
-      end
-    end
-
-    context "failed to create resource" do
-      before do
-        stub_post("/authorizations", "https://#{basic_auth}@api.github.com").with(inputs).
-          to_return(:body => '', :status => 404, :headers => {:content_type => "application/json; charset=utf-8"})
-
-      end
-
-      it "should fail to retrieve resource" do
-        expect {
-          github.oauth.create inputs
-        }.to raise_error(Github::Error::NotFound)
-      end
-    end
-  end # create
-
-  describe "#update" do
-    let(:authorization_id) { 1 }
-    let(:inputs) { { :add_scopes => ['repo'] } }
-
-    context "resouce updated" do
-
-      it "should fail to get resource without basic authentication" do
-        reset_authentication_for github
-        expect { github.oauth.update }.to raise_error(ArgumentError)
-      end
-
-      before do
-        stub_patch("/authorizations/#{authorization_id}", "https://#{basic_auth}@api.github.com").with(inputs).
-          to_return(:body => fixture('auths/authorization.json'), :status => 201, :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should update resource successfully" do
-        github.oauth.update authorization_id, inputs
-        a_patch("/authorizations/#{authorization_id}", "https://#{basic_auth}@api.github.com").with(inputs).should have_been_made
-      end
-
-      it "should return the resource" do
-        authorization = github.oauth.update authorization_id, inputs
-        authorization.should be_a Hashie::Mash
-      end
-
-      it "should get the authorization information" do
-        authorization = github.oauth.update authorization_id, inputs
-        authorization.token.should == 'abc123'
-      end
-    end
-
-    context "failed to update resource" do
-      before do
-        stub_patch("/authorizations/#{authorization_id}", "https://#{basic_auth}@api.github.com").with(inputs).
-          to_return(:body => '', :status => 404, :headers => {:content_type => "application/json; charset=utf-8"})
-
-      end
-
-      it "should fail to retrieve resource" do
-        expect {
-          github.oauth.update authorization_id, inputs
-        }.to raise_error(Github::Error::NotFound)
-      end
-    end
-  end # update
-
-  describe "#delete" do
-    let(:authorization_id) { 1 }
-    let(:inputs) { { :add_scopes => ['repo'] } }
-
-    context "resouce deleted" do
-
-      it "should fail to get resource without basic authentication" do
-        reset_authentication_for github
-        expect { github.oauth.delete nil }.to raise_error(ArgumentError)
-      end
-
-      before do
-        stub_delete("/authorizations/#{authorization_id}", "https://#{basic_auth}@api.github.com").
-          to_return(:body => '', :status => 204, :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should delete resource successfully" do
-        github.oauth.delete authorization_id
-        a_delete("/authorizations/#{authorization_id}", "https://#{basic_auth}@api.github.com").should have_been_made
-      end
-    end
-
-    context "failed to create resource" do
-      before do
-        stub_delete("/authorizations/#{authorization_id}", "https://#{basic_auth}@api.github.com").
-          to_return(:body => '', :status => 404, :headers => {:content_type => "application/json; charset=utf-8"})
-
-      end
-
-      it "should fail to retrieve resource" do
-        expect {
-          github.oauth.delete authorization_id
-        }.to raise_error(Github::Error::NotFound)
-      end
-    end
-  end # delete
+  it_should_behave_like 'api interface'
 
 end # Github::Authorizations

data/spec/github/gists/comments/create_spec.rb

@@ -35,7 +35,7 @@ describe Github::Gists::Comments, '#create' do
 
     it "should return the resource" do
       comment = subject.create gist_id, inputs
-      comment.should be_a Hashie::Mash
+      comment.should be_a Github::ResponseWrapper
     end
 
     it "should get the comment information" do

data/spec/github/gists/comments/edit_spec.rb

@@ -36,7 +36,7 @@ describe Github::Gists::Comments, '#create' do
 
     it "should return the resource" do
       comment = subject.edit gist_id, comment_id, inputs
-      comment.should be_a Hashie::Mash
+      comment.should be_a Github::ResponseWrapper
     end
 
     it "should get the comment information" do

data/spec/github/gists/comments/get_spec.rb

@@ -37,7 +37,7 @@ describe Github::Gists::Comments, '#get' do
 
     it "should return mash" do
       comment = subject.get gist_id, comment_id
-      comment.should be_a Hashie::Mash
+      comment.should be_a Github::ResponseWrapper
     end
   end
 

data/spec/github/gists/create_spec.rb

@@ -48,7 +48,7 @@ describe Github::Gists, '#create' do
 
     it "should return the resource" do
       gist = subject.create inputs
-      gist.should be_a Hashie::Mash
+      gist.should be_a Github::ResponseWrapper
     end
 
     it "should get the gist information" do

data/spec/github/gists/edit_spec.rb

@@ -44,7 +44,7 @@ describe Github::Gists, '#edit' do
 
     it "should return the resource" do
       gist = subject.edit gist_id, inputs
-      gist.should be_a Hashie::Mash
+      gist.should be_a Github::ResponseWrapper
     end
 
     it "should get the gist information" do

data/spec/github/gists/fork_spec.rb

@@ -26,7 +26,7 @@ describe Github::Gists, '#star' do
 
   it "should return the resource" do
     gist = subject.fork gist_id
-    gist.should be_a Hashie::Mash
+    gist.should be_a Github::ResponseWrapper
   end
 
   it "should get the gist information" do

data/spec/github/gists/get_spec.rb

@@ -36,7 +36,7 @@ describe Github::Gists, '#get' do
 
     it "should return mash" do
       gist = subject.get gist_id
-      gist.should be_a Hashie::Mash
+      gist.should be_a Github::ResponseWrapper
     end
   end
 

data/spec/github/git_data/blobs/create_spec.rb

@@ -46,7 +46,7 @@ describe Github::GitData::Blobs, '#create' do
 
     it "should return the resource" do
       blob_sha = subject.create user, repo, inputs
-      blob_sha.should be_a Hashie::Mash
+      blob_sha.should be_a Github::ResponseWrapper
     end
 
     it "should get the blob information" do

data/spec/github/git_data/blobs/get_spec.rb

@@ -38,7 +38,7 @@ describe Github::GitData::Blobs, '#get' do
 
     it "should return mash" do
       blob = subject.get user, repo, sha
-      blob.should be_a Hashie::Mash
+      blob.should be_a Github::ResponseWrapper
     end
   end
 

data/spec/github/git_data/commits/create_spec.rb

@@ -59,7 +59,7 @@ describe Github::GitData::Commits, '#get' do
 
     it "should return the resource" do
       commit = subject.create user, repo, inputs
-      commit.should be_a Hashie::Mash
+      commit.should be_a Github::ResponseWrapper
     end
 
     it "should get the commit information" do

data/spec/github/git_data/commits/get_spec.rb

@@ -39,7 +39,7 @@ describe Github::GitData::Commits, '#get' do
 
     it "should return mash" do
       commit = subject.get user, repo, sha
-      commit.should be_a Hashie::Mash
+      commit.should be_a Github::ResponseWrapper
     end
   end
 

data/spec/github/git_data/references/create_spec.rb

@@ -38,10 +38,10 @@ describe Github::GitData::References, '#create' do
       }.to raise_error(Github::Error::RequiredParams)
     end
 
-    it "should fail to create resource if 'ref' is wrong" do
+    it "should fail to create resource if 'ref' is correct" do
       expect {
         subject.create user, repo, :ref => '/heads/master', :sha => '13t2a1r3'
-      }.to raise_error(ArgumentError)
+      }.not_to raise_error(ArgumentError)
     end
 
     it "should create resource successfully" do

data/spec/github/git_data/references/get_spec.rb

@@ -28,7 +28,7 @@ describe Github::GitData::References, '#get' do
     it "should fail to get resource with wrong ref" do
       expect {
         subject.get user, repo, '/branch'
-      }.to raise_error(ArgumentError)
+      }.not_to raise_error(ArgumentError)
     end
 
     it "should get the resource" do

data/spec/github/git_data/references/list_spec.rb

@@ -6,7 +6,7 @@ describe Github::GitData::References, '#list' do
   let(:user) { 'peter-murach' }
   let(:repo) { 'github' }
   let(:ref) { "heads/master" }
-  let(:request_path) { "/repos/#{user}/#{repo}/git/refs/#{ref}" }
+  let(:request_path) { "/repos/#{user}/#{repo}/git/refs/#{ref}".gsub(/(\/)+/, '/') }
 
   before {
     stub_get(request_path).to_return(:body => body, :status => status,
@@ -31,7 +31,7 @@ describe Github::GitData::References, '#list' do
       it "should fail to call" do
         expect {
           subject.list user, repo, :ref => ref
-        }.to raise_error(ArgumentError)
+        }.to_not raise_error(ArgumentError, /reference/)
       end
     end
 
@@ -41,7 +41,7 @@ describe Github::GitData::References, '#list' do
       it "should pass with valid reference" do
         expect {
           subject.list user, repo, :ref => ref
-        }.to_not raise_error(ArgumentError)
+        }.to_not raise_error(ArgumentError, /reference/)
       end
     end
 
@@ -51,7 +51,7 @@ describe Github::GitData::References, '#list' do
       it "should pass with valid reference" do
         expect {
           subject.list user, repo, :ref => ref
-        }.to_not raise_error(ArgumentError)
+        }.to_not raise_error(ArgumentError, /reference/)
       end
     end
 
@@ -61,7 +61,17 @@ describe Github::GitData::References, '#list' do
       it "should pass with valid reference" do
         expect {
           subject.list user, repo, :ref => ref
-        }.to_not raise_error(ArgumentError)
+        }.to_not raise_error(ArgumentError, /reference/)
+      end
+    end
+
+    context 'with valid renference and refs with leading slash' do
+      let(:ref) { '/refs/heads/lleger-refactor' }
+
+      it "should pass with valid reference" do
+        expect {
+          subject.list user, repo, :ref => ref
+        }.to_not raise_error(ArgumentError, /reference/)
       end
     end
 
@@ -72,7 +82,7 @@ describe Github::GitData::References, '#list' do
 
     it "should return array of resources" do
       references = subject.list user, repo, :ref => ref
-      references.should be_an Array
+      references.should be_an Enumerable
       references.should have(3).items
     end