github_api 0.8.11 → 0.9.0

data/spec/github/pull_requests/comments/create_spec.rb

@@ -41,7 +41,7 @@ describe Github::PullRequests::Comments, '#create' do
 
     it "should return the resource" do
       pull_request = subject.create user, repo, pull_request_id, inputs
-      pull_request.should be_a Hashie::Mash
+      pull_request.should be_a Github::ResponseWrapper
     end
 
     it "should get the request information" do

data/spec/github/pull_requests/comments/edit_spec.rb

@@ -33,7 +33,7 @@ describe Github::PullRequests::Comments, '#edit' do
 
     it "should return the resource" do
       comment = subject.edit user, repo, comment_id, inputs
-      comment.should be_a Hashie::Mash
+      comment.should be_a Github::ResponseWrapper
     end
 
     it "should get the comment information" do

data/spec/github/pull_requests/comments/get_spec.rb

@@ -39,7 +39,7 @@ describe Github::PullRequests::Comments, '#get' do
 
     it "should return mash" do
       comment = subject.get user, repo, comment_id
-      comment.should be_a Hashie::Mash
+      comment.should be_a Github::ResponseWrapper
     end
   end
 

data/spec/github/pull_requests/create_spec.rb

@@ -36,7 +36,7 @@ describe Github::PullRequests, '#create' do
 
     it "should return the resource" do
       pull_request = subject.create user, repo, inputs
-      pull_request.should be_a Hashie::Mash
+      pull_request.should be_a Github::ResponseWrapper
     end
 
     it "should get the request information" do

data/spec/github/pull_requests/get_spec.rb

@@ -38,7 +38,7 @@ describe Github::PullRequests, '#get' do
 
     it "should return mash" do
       pull_request = subject.get user, repo, number
-      pull_request.should be_a Hashie::Mash
+      pull_request.should be_a Github::ResponseWrapper
     end
   end
 

data/spec/github/pull_requests/update_spec.rb

@@ -35,7 +35,7 @@ describe Github::PullRequests, '#update' do
 
     it "should return the resource" do
       pull_request = subject.update user, repo, number, inputs
-      pull_request.should be_a Hashie::Mash
+      pull_request.should be_a Github::ResponseWrapper
     end
 
     it "should get the pull_request information" do

data/spec/github/repos/branch_spec.rb

@@ -26,7 +26,7 @@ describe Github::Repos, '#branch' do
 
     it "should return repository mash" do
       repo_branch = subject.branch user, repo, branch
-      repo_branch.should be_a Hashie::Mash
+      repo_branch.should be_a Github::ResponseWrapper
     end
 
     it "should get repository branch information" do

data/spec/github/repos/comments/create_spec.rb

@@ -40,7 +40,7 @@ describe Github::Repos::Comments, '#create' do
 
     it "should return the resource" do
       comment = subject.create user, repo, sha, inputs
-      comment.should be_a Hashie::Mash
+      comment.should be_a Github::ResponseWrapper
     end
 
     it "should get the commit comment information" do

data/spec/github/repos/comments/get_spec.rb

@@ -37,7 +37,7 @@ describe Github::Repos::Comments, '#get' do
 
     it "should return mash" do
       commit_comment = subject.get user, repo, comment_id
-      commit_comment.should be_a Hashie::Mash
+      commit_comment.should be_a Github::ResponseWrapper
     end
   end
 

data/spec/github/repos/comments/update_spec.rb

@@ -32,7 +32,7 @@ describe Github::Repos::Comments, '#update' do
 
     it "should return the resource" do
       comment = subject.update user, repo, comment_id, inputs
-      comment.should be_a Hashie::Mash
+      comment.should be_a Github::ResponseWrapper
     end
 
     it "should get the commit comment information" do

data/spec/github/repos/commits/get_spec.rb

@@ -39,7 +39,7 @@ describe Github::Repos::Commits, '#get' do
 
     it "should return mash" do
       commit = subject.get user, repo, sha
-      commit.should be_a Hashie::Mash
+      commit.should be_a Github::ResponseWrapper
     end
   end
 

data/spec/github/repos/create_spec.rb

@@ -48,7 +48,7 @@ describe Github::Repos, '#create' do
 
       it "should return mash type" do
         repository = subject.create inputs
-        repository.should be_a Hashie::Mash
+        repository.should be_a Github::ResponseWrapper
       end
     end
 

data/spec/github/repos/downloads/create_spec.rb

@@ -44,7 +44,7 @@ describe Github::Repos::Downloads, '#create' do
 
     it "should return the resource" do
       download = subject.create user, repo, inputs
-      download.should be_a Hashie::Mash
+      download.should be_a Github::ResponseWrapper
     end
 
     it "should get the download information" do

data/spec/github/repos/downloads/get_spec.rb

@@ -39,7 +39,7 @@ describe Github::Repos::Downloads, '#get' do
 
     it "should return mash" do
       download = subject.get user, repo, download_id
-      download.should be_a Hashie::Mash
+      download.should be_a Github::ResponseWrapper
     end
   end
 

data/spec/github/repos/edit_spec.rb

@@ -44,7 +44,7 @@ describe Github::Repos, '#edit' do
 
     it "should return resource" do
       repository = subject.edit user, repo, inputs
-      repository.should be_a Hashie::Mash
+      repository.should be_a Github::ResponseWrapper
     end
 
     it "should be able to retrieve information" do

data/spec/github/repos/forks/create_spec.rb

@@ -27,7 +27,7 @@ describe Github::Repos::Forks, '#create' do
 
     it "should return the resource" do
       fork = subject.create user, repo, inputs
-      fork.should be_a Hashie::Mash
+      fork.should be_a Github::ResponseWrapper
     end
 
     it "should get the fork information" do

data/spec/github/repos/get_spec.rb

@@ -35,7 +35,7 @@ describe Github::Repos, '#get' do
 
     it "should return repository mash" do
       repository = subject.get user, repo
-      repository.should be_a Hashie::Mash
+      repository.should be_a Github::ResponseWrapper
     end
 
     it "should get repository information" do

data/spec/github/repos/hooks/create_spec.rb

@@ -52,7 +52,7 @@ describe Github::Repos::Hooks, '#create' do
 
     it "should return the resource" do
       hook = subject.create user, repo, inputs
-      hook.should be_a Hashie::Mash
+      hook.should be_a Github::ResponseWrapper
     end
 
     it "should get the hook information" do

data/spec/github/repos/hooks/edit_spec.rb

@@ -61,7 +61,7 @@ describe Github::Repos::Hooks, '#list' do
 
     it "should return resource" do
       hook = subject.edit user, repo, hook_id, inputs
-      hook.should be_a Hashie::Mash
+      hook.should be_a Github::ResponseWrapper
     end
 
     it "should be able to retrieve information" do

data/spec/github/repos/hooks/get_spec.rb

@@ -38,7 +38,7 @@ describe Github::Repos::Hooks, '#get' do
 
     it "should return mash" do
       hook = subject.get user, repo, hook_id
-      hook.should be_a Hashie::Mash
+      hook.should be_a Github::ResponseWrapper
     end
   end
 

data/spec/github/repos/languages_spec.rb

@@ -33,7 +33,7 @@ describe Github::Repos, '#languages' do
 
     it "should return hash of languages" do
       languages = subject.languages user, repo
-      languages.should be_an Hash
+      languages.should be_an Github::ResponseWrapper
       languages.should have(2).keys
     end
 

data/spec/github/repos/merging/merge_spec.rb

@@ -42,7 +42,7 @@ describe Github::Repos::Merging, '#merge' do
 
     it "should return the resource" do
       merge = subject.merge user, repo, inputs
-      merge.should be_a Hashie::Mash
+      merge.should be_a Github::ResponseWrapper
     end
 
     it "should get the commit comment information" do

data/spec/github/repos/statuses/create_spec.rb

@@ -38,7 +38,7 @@ describe Github::Repos::Statuses, '#create' do
 
     it "should return the resource" do
       status = subject.create user, repo, sha, inputs
-      status.should be_a Hashie::Mash
+      status.should be_a Github::ResponseWrapper
     end
 
     it "should get the status information" do

data/spec/github/repos/tags_spec.rb

@@ -33,7 +33,7 @@ describe Github::Repos, '#tags' do
 
     it "should return array of resources" do
       tags = subject.tags user, repo
-      tags.should be_an Array
+      tags.should be_an Enumerable
       tags.should have(1).items
     end
 

data/spec/github/repos/teams_spec.rb

@@ -33,7 +33,7 @@ describe Github::Repos, '#teams' do
 
     it "should return array of resources" do
       teams = subject.teams user, repo
-      teams.should be_an Array
+      teams.should be_an Enumerable
       teams.should have(1).items
     end
 

data/spec/github/request/endpoint_spec.rb

@@ -0,0 +1,24 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::API, 'endpoint' do
+  let(:endpoint) { "https://my-company/api/v3/" }
+  let(:options) { {:endpoint => endpoint } }
+  let(:path)  { "/repos/GitHub/issues-dev/issues" }
+
+  subject(:api) { described_class.new(options) }
+
+  before {
+    stub_get(path, 'https://my-company/api/v3').
+      to_return(:body => "[]", :status => 200, :headers =>{})
+  }
+
+  its(:endpoint) { should == endpoint }
+
+  it "doesn't truncate endpoint" do
+    expect {
+      api.get_request(path)
+    }.not_to raise_error(WebMock::NetConnectNotAllowedError)
+  end
+end

data/spec/github/request/request_spec.rb

@@ -0,0 +1,38 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::API, '#request' do
+  let(:token) { "2fdsfdo23fsdf3omkhen34n2jh" }
+  let(:per_page) { 100 }
+  let(:path)  { "/api/v3/repos/GitHub/issues-dev/issues" }
+
+  let(:url_prefix) { "https://my-company/api/v3/repos/GitHub/issues-dev/issues?access_token=#{token}&page=2&per_page=#{per_page}" }
+
+  let(:conn) { Faraday::Connection.new }
+
+  before {
+    conn.url_prefix = url_prefix
+    stub_get(path, 'https://my-company').
+      with(:query => {'access_token' => token, :page => 2, :per_page => per_page}).
+      to_return(:body => "", :status => 200, :headers =>{})
+  }
+
+  subject { described_class.new() }
+
+  it 'sets connection path correctly' do
+    expect(conn.path_prefix).to eql(path)
+  end
+
+  it 'responds to get request' do
+    expect(subject).to respond_to(:get_request)
+  end
+
+  it 'handles enterprise uri correctly' do
+    subject.stub(:connection).and_return conn
+
+    expect {
+      subject.get_request(path)
+    }.not_to raise_error(WebMock::NetConnectNotAllowedError)
+  end
+end

data/spec/github/{result_spec.rb → response_wrapper_spec.rb}

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Github::Result do
+describe Github::ResponseWrapper do
   let(:github) { Github.new }
   let(:user)   { 'wycats' }
   let(:res)    { github.activity.events.public({ 'per_page' => 20 }) }
@@ -45,35 +45,35 @@ describe Github::Result do
   end
 
   it "should read response content_type " do
-    res.content_type.should match 'application/json'
+    res.headers.content_type.should match 'application/json'
   end
 
   it "should read response content_length " do
-    res.content_length.should match '344'
+    res.headers.content_length.should match '344'
   end
 
   it "should read response ratelimit limit" do
-    res.ratelimit_limit.should == '5000'
+    res.headers.ratelimit_limit.should == '5000'
   end
 
   it "should read response ratelimit remaining" do
-    res.ratelimit_remaining.should == '4999'
+    res.headers.ratelimit_remaining.should == '4999'
   end
 
   it "should read response status" do
-    res.status.should be 200
+    res.headers.status.should be 200
   end
 
   it 'should read response etag' do
-    res.etag.should eql "\"d9a88f20567726e29d35c6fae87cef2f\""
+    res.headers.etag.should eql "\"d9a88f20567726e29d35c6fae87cef2f\""
   end
 
   it 'should read response date' do
-    res.date.should eql "Sun, 05 Feb 2012 15:02:34 GMT"
+    res.headers.date.should eql "Sun, 05 Feb 2012 15:02:34 GMT"
   end
 
   it 'should read response server' do
-    res.server.should eql "nginx/1.0.4"
+    res.headers.server.should eql "nginx/1.0.4"
   end
 
   it "should assess successful" do
@@ -85,8 +85,9 @@ describe Github::Result do
   end
 
   context "pagination methods" do
-    let(:env) { {:response_headers => {}}}
-    let(:iterator) { Github::PageIterator.new(env) }
+    let(:links) { Github::PageLinks.new({}) }
+    let(:current_api) { stub(:api).as_null_object }
+    let(:iterator) { Github::PageIterator.new(links, current_api) }
 
     before do
       described_class.stub(:page_iterator).and_return iterator
@@ -98,8 +99,8 @@ describe Github::Result do
 
     %w[ next prev ].each do |link|
       context "#{link}_page" do
-        it "should return collection of resources" do
-          res.send(:"#{link}_page").should be_an Array
+        it "responds to #{link}_page request" do
+          res.send(:"#{link}_page").should be_nil
         end
 
         it 'should have no link information' do

data/spec/github/users/emails/list_spec.rb

@@ -29,7 +29,7 @@ describe Github::Users::Emails, '#list' do
 
     it "should return resource" do
       emails = subject.list
-      emails.should be_an Array
+      emails.should be_an Enumerable
       emails.should have(2).items
     end
 

data/spec/github/users/get_spec.rb

@@ -24,14 +24,9 @@ describe Github::Users, '#get' do
       a_get(request_path).should have_been_made
     end
 
-    it "should return resource" do
+    it "should be a response wrapper" do
       user_resource = subject.get :user => user
-      user_resource.should be_a Hash
-    end
-
-    it "should be a mash type" do
-      user_resource = subject.get :user => user
-      user_resource.should be_a Hashie::Mash
+      user_resource.should be_a Github::ResponseWrapper
     end
 
     it "should get org information" do

data/spec/github/users/keys/create_spec.rb

@@ -35,7 +35,7 @@ describe Github::Users::Keys, '#create' do
 
     it "should return the resource" do
       key = subject.create inputs
-      key.should be_a Hashie::Mash
+      key.should be_a Github::ResponseWrapper
     end
 
     it "should get the key information" do

data/spec/github/users/keys/get_spec.rb

@@ -39,7 +39,7 @@ describe Github::Users::Keys, '#get' do
 
     it "should return mash" do
       key = subject.get key_id
-      key.should be_a Hashie::Mash
+      key.should be_a Github::ResponseWrapper
     end
   end
 

data/spec/github/users/keys/update_spec.rb

@@ -40,7 +40,7 @@ describe Github::Users::Keys, '#update' do
 
     it "should return the resource" do
       key = subject.update key_id, inputs
-      key.should be_a Hashie::Mash
+      key.should be_a Github::ResponseWrapper
     end
 
     it "should get the key information" do

data/spec/github/users/update_spec.rb

@@ -40,7 +40,7 @@ describe Github::Users, '#update' do
 
     it "should return the resource" do
       user_resource = subject.update inputs
-      user_resource.should be_a Hashie::Mash
+      user_resource.should be_a Github::ResponseWrapper
     end
 
     it "should get the resource information" do