github_api 0.8.0 → 0.8.1

data/spec/github/repos/forks/create_spec.rb

@@ -36,14 +36,8 @@ describe Github::Repos::Forks, '#create' do
     end
   end
 
-  context "failed to create resource" do
-    let(:body)   { "" }
-    let(:status) { 404 }
-
-    it "should faile to retrieve resource" do
-      expect {
-        subject.create user, repo, inputs
-      }.to raise_error(Github::Error::NotFound)
-    end
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.create user, repo, inputs }
   end
+
 end # create

data/spec/github/repos/forks/list_spec.rb

@@ -14,7 +14,6 @@ describe Github::Repos::Forks, '#list' do
 
   after { reset_authentication_for(subject) }
 
-
   context "resource found" do
     let(:body)   { fixture('repos/forks.json') }
     let(:status) { 200 }
@@ -30,15 +29,8 @@ describe Github::Repos::Forks, '#list' do
       a_get(request_path).should have_been_made
     end
 
-    it "should return array of resources" do
-      forks = subject.list user, repo
-      forks.should be_an Array
-      forks.should have(1).items
-    end
-
-    it "should be a mash type" do
-      forks = subject.list user, repo
-      forks.first.should be_a Hashie::Mash
+    it_should_behave_like 'an array of resources' do
+      let(:requestable) { subject.list user, repo }
     end
 
     it "should get fork information" do
@@ -47,19 +39,14 @@ describe Github::Repos::Forks, '#list' do
     end
 
     it "should yield to a block" do
-      subject.should_receive(:list).with(user, repo).and_yield('web')
-      subject.list(user, repo) { |param| 'web' }
+      yielded = []
+      result = subject.list(user, repo) { |obj| yielded << obj }
+      yielded.should == result
     end
   end
 
-  context "resource not found" do
-    let(:body)   { "" }
-    let(:status) { [404, "Not Found"] }
-
-    it "should return 404 with a message 'Not Found'" do
-      expect {
-        subject.list user, repo
-      }.to raise_error(Github::Error::NotFound)
-    end
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.list user, repo }
   end
+
 end # list

data/spec/github/repos/get_spec.rb

@@ -44,14 +44,8 @@ describe Github::Repos, '#get' do
     end
   end
 
-  context "resource not found" do
-    let(:body)   { '' }
-    let(:status) { 404 }
-
-    it "should fail to get resource" do
-      expect {
-        subject.get user, repo
-      }.to raise_error(Github::Error::NotFound)
-    end
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.get user, repo }
   end
+
 end # get

data/spec/github/repos/list_spec.rb

@@ -3,6 +3,8 @@
 require 'spec_helper'
 
 describe Github::Repos, '#list' do
+  include Github::Jsonable
+
   let(:user) { 'peter-murach' }
   let(:repo) { 'github' }
   let(:request_path) { "/user/repos?access_token=#{OAUTH_TOKEN}" }
@@ -34,10 +36,8 @@ describe Github::Repos, '#list' do
       a_get(request_path).should have_been_made
     end
 
-    it "should return array of resources" do
-      repositories = subject.list
-      repositories.should be_an Array
-      repositories.should have(1).items
+    it_should_behave_like 'an array of resources' do
+      let(:requestable) { subject.list }
     end
 
     it "should return array of resources sorted by pushed_at time" do
@@ -50,9 +50,10 @@ describe Github::Repos, '#list' do
       repositories.first.name.should == 'Hello-World'
     end
 
-    it "should yield repositories to a block" do
-      subject.should_receive(:list).and_yield('octocat')
-      subject.list { |repo| 'octocat' }
+    it "should yield result to a block" do
+      yielded = []
+      result = subject.list { |obj| yielded << obj }
+      yielded.should == result
     end
   end
 

data/spec/github/repos_spec.rb

@@ -6,6 +6,8 @@ describe Github::Repos, 'integration' do
 
   after { reset_authentication_for subject }
 
+  it_should_behave_like 'api interface'
+
   its(:collaborators) { should be_a Github::Repos::Collaborators }
 
   its(:comments)      { should be_a Github::Repos::Comments }

data/spec/shared/api_interface_behaviour.rb

@@ -0,0 +1,15 @@
+# encoding: utf-8
+
+shared_examples_for 'api interface' do
+
+  it { should respond_to :endpoint }
+
+  it { should respond_to :site }
+
+  it { should respond_to :user }
+
+  it { should respond_to :repo }
+
+  it { should respond_to :adapter }
+
+end

data/spec/shared/array_of_resources_behaviour.rb

@@ -0,0 +1,15 @@
+# encoding: utf-8
+
+shared_examples_for 'an array of resources' do
+
+  it "should return array of resources" do
+    objects = requestable
+    objects.should be_an Array
+    objects.should have(1).items
+  end
+
+  it "should be a mash type" do
+    objects = requestable
+    objects.first.should be_a Hashie::Mash
+  end
+end

data/spec/shared/request_failure_behaviour.rb

@@ -0,0 +1,16 @@
+# encoding: utf-8
+
+shared_examples_for 'request failure' do
+
+  context "resource not found" do
+    let(:body)   { "" }
+    let(:status) { [404, "Not Found"] }
+
+    it "should fail to retrive resource" do
+      expect {
+        requestable
+      }.to raise_error(Github::Error::NotFound)
+    end
+  end
+
+end

data/spec/spec_helper.rb

@@ -16,7 +16,7 @@ end
 
 # Requires supporting files with custom matchers and macros, etc,
 # in ./support/ and its subdirectories.
-Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each {|f| require f}
+Dir["#{File.dirname(__FILE__)}/{support,shared}/**/*.rb"].each { |f| require f }
 
 module Github
   def reset!

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: github_api
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.8.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-11-04 00:00:00.000000000Z
+date: 2012-11-17 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: hashie
-  requirement: &2152546820 !ruby/object:Gem::Requirement
+  requirement: &2154232220 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,10 +21,10 @@ dependencies:
         version: 1.2.0
   type: :runtime
   prerelease: false
-  version_requirements: *2152546820
+  version_requirements: *2154232220
 - !ruby/object:Gem::Dependency
   name: faraday
-  requirement: &2152546320 !ruby/object:Gem::Requirement
+  requirement: &2154231720 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -32,10 +32,10 @@ dependencies:
         version: 0.8.1
   type: :runtime
   prerelease: false
-  version_requirements: *2152546320
+  version_requirements: *2154231720
 - !ruby/object:Gem::Dependency
   name: multi_json
-  requirement: &2152545860 !ruby/object:Gem::Requirement
+  requirement: &2154231260 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,10 +43,10 @@ dependencies:
         version: '1.3'
   type: :runtime
   prerelease: false
-  version_requirements: *2152545860
+  version_requirements: *2154231260
 - !ruby/object:Gem::Dependency
   name: oauth2
-  requirement: &2152545480 !ruby/object:Gem::Requirement
+  requirement: &2154230880 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2152545480
+  version_requirements: *2154230880
 - !ruby/object:Gem::Dependency
   name: nokogiri
-  requirement: &2152544940 !ruby/object:Gem::Requirement
+  requirement: &2154230340 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -65,10 +65,10 @@ dependencies:
         version: 1.5.2
   type: :runtime
   prerelease: false
-  version_requirements: *2152544940
+  version_requirements: *2154230340
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &2152544440 !ruby/object:Gem::Requirement
+  requirement: &2154229840 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,10 +76,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152544440
+  version_requirements: *2154229840
 - !ruby/object:Gem::Dependency
   name: cucumber
-  requirement: &2152543980 !ruby/object:Gem::Requirement
+  requirement: &2154229380 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -87,10 +87,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152543980
+  version_requirements: *2154229380
 - !ruby/object:Gem::Dependency
   name: webmock
-  requirement: &2152541440 !ruby/object:Gem::Requirement
+  requirement: &2154228920 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -98,10 +98,10 @@ dependencies:
         version: 1.8.0
   type: :development
   prerelease: false
-  version_requirements: *2152541440
+  version_requirements: *2154228920
 - !ruby/object:Gem::Dependency
   name: vcr
-  requirement: &2152540980 !ruby/object:Gem::Requirement
+  requirement: &2154228460 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -109,10 +109,10 @@ dependencies:
         version: 2.3.0
   type: :development
   prerelease: false
-  version_requirements: *2152540980
+  version_requirements: *2154228460
 - !ruby/object:Gem::Dependency
   name: simplecov
-  requirement: &2152540520 !ruby/object:Gem::Requirement
+  requirement: &2154228000 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -120,10 +120,10 @@ dependencies:
         version: 0.7.1
   type: :development
   prerelease: false
-  version_requirements: *2152540520
+  version_requirements: *2154228000
 - !ruby/object:Gem::Dependency
   name: guard
-  requirement: &2152540140 !ruby/object:Gem::Requirement
+  requirement: &2154227620 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -131,10 +131,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152540140
+  version_requirements: *2154227620
 - !ruby/object:Gem::Dependency
   name: guard-rspec
-  requirement: &2152539680 !ruby/object:Gem::Requirement
+  requirement: &2154227160 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -142,10 +142,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152539680
+  version_requirements: *2154227160
 - !ruby/object:Gem::Dependency
   name: guard-cucumber
-  requirement: &2152539260 !ruby/object:Gem::Requirement
+  requirement: &2154226740 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -153,10 +153,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152539260
+  version_requirements: *2154226740
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &2152538840 !ruby/object:Gem::Requirement
+  requirement: &2154226320 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -164,10 +164,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152538840
+  version_requirements: *2154226320
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &2152538420 !ruby/object:Gem::Requirement
+  requirement: &2154242280 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -175,7 +175,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152538420
+  version_requirements: *2154242280
 description: ! ' Ruby wrapper that supports all of the GitHub API v3 methods(nearly
   200). It''s build in a modular way, that is, you can either instantiate the whole
   api wrapper Github.new or use parts of it e.i. Github::Repos.new if working solely
@@ -383,6 +383,7 @@ files:
 - lib/github_api/request/jsonize.rb
 - lib/github_api/request/oauth2.rb
 - lib/github_api/request.rb
+- lib/github_api/requestable.rb
 - lib/github_api/resource.rb
 - lib/github_api/response/helpers.rb
 - lib/github_api/response/jsonize.rb
@@ -532,6 +533,8 @@ files:
 - spec/github/error/validations_spec.rb
 - spec/github/gists/comments_spec.rb
 - spec/github/gists_spec.rb
+- spec/github/git_data/blobs/create_spec.rb
+- spec/github/git_data/blobs/get_spec.rb
 - spec/github/git_data/blobs_spec.rb
 - spec/github/git_data/commits_spec.rb
 - spec/github/git_data/references_spec.rb
@@ -557,6 +560,10 @@ files:
 - spec/github/pull_requests_spec.rb
 - spec/github/repos/branch_spec.rb
 - spec/github/repos/branches_spec.rb
+- spec/github/repos/collaborators/add_spec.rb
+- spec/github/repos/collaborators/get_spec.rb
+- spec/github/repos/collaborators/list_spec.rb
+- spec/github/repos/collaborators/remove_spec.rb
 - spec/github/repos/collaborators_spec.rb
 - spec/github/repos/comments/create_spec.rb
 - spec/github/repos/comments/delete_spec.rb
@@ -610,6 +617,9 @@ files:
 - spec/github/validations_spec.rb
 - spec/github_spec.rb
 - spec/README.rdoc
+- spec/shared/api_interface_behaviour.rb
+- spec/shared/array_of_resources_behaviour.rb
+- spec/shared/request_failure_behaviour.rb
 - spec/spec_helper.rb
 - spec/support/authentication.rb
 - spec/support/base.rb
@@ -619,7 +629,7 @@ files:
 homepage: https://github.com/peter-murach/github
 licenses: []
 post_install_message: ! "\n--------------------------------------------------------------------------------\nThank
-  you for installing github_api-0.8.0.\n\nFor more information: https://github.com/peter-murach/github\n--------------------------------------------------------------------------------\n
+  you for installing github_api-0.8.1.\n\nFor more information: https://github.com/peter-murach/github\n--------------------------------------------------------------------------------\n
   \ "
 rdoc_options: []
 require_paths: