github_api 0.8.0 → 0.8.1

data/spec/github/activity/events/received_spec.rb

@@ -26,15 +26,8 @@ describe Github::Activity::Events, '#received' do
       a_get(request_path).should have_been_made
     end
 
-    it "should return array of resources" do
-      events = subject.received user
-      events.should be_an Array
-      events.should have(1).items
-    end
-
-    it "should be a mash type" do
-      events = subject.received user
-      events.first.should be_a Hashie::Mash
+    it_should_behave_like 'an array of resources' do
+      let(:requestable) { subject.received user }
     end
 
     it "should get event information" do
@@ -43,8 +36,9 @@ describe Github::Activity::Events, '#received' do
     end
 
     it "should yield to a block" do
-      subject.should_receive(:received).with(user).and_yield('web')
-      subject.received(user) { |param| 'web' }
+      yielded = []
+      result = subject.received(user) { |obj| yielded << obj }
+      yielded.should == result
     end
   end
 
@@ -56,15 +50,8 @@ describe Github::Activity::Events, '#received' do
       a_get(request_path).should have_been_made
     end
 
-    it "should return array of resources" do
-      events = subject.received user, :public => true
-      events.should be_an Array
-      events.should have(1).items
-    end
-
-    it "should be a mash type" do
-      events = subject.received user, :public => true
-      events.first.should be_a Hashie::Mash
+    it_should_behave_like 'an array of resources' do
+      let(:requestable) { subject.received user, :public => true }
     end
 
     it "should get event information" do
@@ -73,19 +60,13 @@ describe Github::Activity::Events, '#received' do
     end
 
     it "should yield to a block" do
-      subject.should_receive(:received).with(user).and_yield('web')
-      subject.received(user) { |param| 'web' }
+      yielded = []
+      result = subject.received(user, :public => true) { |obj| yielded << obj }
+      yielded.should == result
     end
   end
 
-  context "resource not found" do
-    let(:body) { '' }
-    let(:status) { [404, "Not Found"] }
-
-    it "should return 404 with a message 'Not Found'" do
-      expect {
-        subject.received user
-      }.to raise_error(Github::Error::NotFound)
-    end
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.received user }
   end
 end # received

data/spec/github/activity/events/repository_spec.rb

@@ -30,15 +30,8 @@ describe Github::Activity::Events, '#repository' do
       a_get(request_path).should have_been_made
     end
 
-    it "should return array of resources" do
-      events = subject.repository user, repo
-      events.should be_an Array
-      events.should have(1).items
-    end
-
-    it "should be a mash type" do
-      events = subject.repository user, repo
-      events.first.should be_a Hashie::Mash
+    it_should_behave_like 'an array of resources' do
+      let(:requestable) { subject.repository user, repo }
     end
 
     it "should get event information" do
@@ -47,19 +40,14 @@ describe Github::Activity::Events, '#repository' do
     end
 
     it "should yield to a block" do
-      subject.should_receive(:repository).with(user, repo).and_yield('web')
-      subject.repository(user, repo) { |param| 'web' }
+      yielded = []
+      result = subject.repository(user, repo) { |obj| yielded << obj }
+      yielded.should == result
     end
   end
 
-  context "resource not found" do
-    let(:body) { '' }
-    let(:status) { [404, "Not Found"] }
-
-    it "should return 404 with a message 'Not Found'" do
-      expect {
-        subject.repository user, repo
-      }.to raise_error(Github::Error::NotFound)
-    end
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.repository user, repo }
   end
+
 end # repository

data/spec/github/activity/events/user_org_spec.rb

@@ -28,15 +28,8 @@ describe Github::Activity::Events, '#user_org' do
       a_get(request_path).should have_been_made
     end
 
-    it "should return array of resources" do
-      events = subject.user_org user, org
-      events.should be_an Array
-      events.should have(1).items
-    end
-
-    it "should be a mash type" do
-      events = subject.user_org user, org
-      events.first.should be_a Hashie::Mash
+    it_should_behave_like 'an array of resources' do
+      let(:requestable) { subject.user_org user, org }
     end
 
     it "should get event information" do
@@ -45,19 +38,14 @@ describe Github::Activity::Events, '#user_org' do
     end
 
     it "should yield to a block" do
-      subject.should_receive(:user_org).with(user, org).and_yield('web')
-      subject.user_org(user, org) { |param| 'web' }
+      yielded = []
+      result = subject.user_org(user, org) { |obj| yielded << obj }
+      yielded.should == result
     end
   end
 
-  context "resource not found" do
-    let(:body) { '' }
-    let(:status) { [404, "Not Found"] }
-
-    it "should return 404 with a message 'Not Found'" do
-      expect {
-        subject.user_org user, org
-      }.to raise_error(Github::Error::NotFound)
-    end
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.user_org user, org }
   end
+
 end # user_org

data/spec/github/activity/notifications/list_spec.rb

@@ -35,10 +35,8 @@ describe Github::Activity::Notifications, '#list' do
         should have_been_made
     end
 
-    it "should return array of resources" do
-      notifications = subject.list
-      notifications.should be_an Array
-      notifications.should have(1).items
+    it_should_behave_like 'an array of resources' do
+      let(:requestable) { subject.list }
     end
 
     it "should get resource information" do
@@ -51,13 +49,8 @@ describe Github::Activity::Notifications, '#list' do
       subject.list { |repo| 'octocat' }
     end
 
-    context "resource not found for a user" do
-      let(:body) { '' }
-      let(:status) { [404, "Not Found"] }
-
-      it "should return 404 with a message 'Not Found'" do
-        expect { subject.list }.to raise_error(Github::Error::NotFound)
-      end
+    it_should_behave_like 'request failure' do
+      let(:requestable) { subject.list }
     end
   end
 

data/spec/github/activity/starring/list_spec.rb

@@ -25,8 +25,9 @@ describe Github::Activity::Starring, '#list' do
     end
 
     it "should yield iterator if block given" do
-      subject.should_receive(:list).with(user, repo).and_yield('github')
-      subject.list(user, repo) { |param| 'github' }
+      yielded = []
+      result = subject.list(user, repo) { |obj| yielded << obj }
+      yielded.should == result
     end
 
     it "should get the resources" do
@@ -34,31 +35,17 @@ describe Github::Activity::Starring, '#list' do
       a_get(request_path).should have_been_made
     end
 
-    it "should return array of resources" do
-      stargazers = subject.list user, repo
-      stargazers.should be_an Array
-      stargazers.should have(1).items
-    end
-
-    it "should return result of mash type" do
-      stargazers = subject.list user, repo
-      stargazers.first.should be_a Hashie::Mash
+    it_should_behave_like 'an array of resources' do
+      let(:requestable) { subject.list user, repo }
     end
 
     it "should get watcher information" do
       stargazers = subject.list user, repo
       stargazers.first.login.should == 'octocat'
     end
+  end
 
-    context "fail to find resource" do
-      let(:body) { '' }
-      let(:status) { 404 }
-
-      it "should return 404 not found message" do
-        expect {
-          subject.list user, repo
-        }.to raise_error(Github::Error::NotFound)
-      end
-    end
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.list user, repo }
   end
 end # list

data/spec/github/activity/watching/list_spec.rb

@@ -30,15 +30,8 @@ describe Github::Activity::Watching, '#list' do
     a_get(request_path).should have_been_made
   end
 
-  it "should return array of resources" do
-    watchers = subject.list user, repo
-    watchers.should be_an Array
-    watchers.should have(1).items
-  end
-
-  it "should return result of mash type" do
-    watchers = subject.list user, repo
-    watchers.first.should be_a Hashie::Mash
+  it_should_behave_like 'an array of resources' do
+    let(:requestable) { subject.list user, repo }
   end
 
   it "should get watcher information" do
@@ -46,14 +39,7 @@ describe Github::Activity::Watching, '#list' do
     watchers.first.login.should == 'octocat'
   end
 
-  context "fail to find resource" do
-    let(:body)   { '' }
-    let(:status) { 404 }
-
-    it "should return 404 not found message" do
-      expect {
-        subject.list user, repo
-      }.to raise_error(Github::Error::NotFound)
-    end
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.list user, repo }
   end
 end # list

data/spec/github/gists/comments_spec.rb

@@ -70,36 +70,36 @@ describe Github::Gists::Comments do
 
     context 'resource found' do
       before do
-        stub_get("/gists/comments/#{comment_id}").
+        stub_get("/gists/#{gist_id}/comments/#{comment_id}").
           to_return(:body => fixture('gists/comment.json'),
           :status => 200,
           :headers => {:content_type => "application/json; charset=utf-8"})
       end
 
       it "should fail to get resource without comment id" do
-        expect { github.gists.comments.get nil }.to raise_error(ArgumentError)
+        expect { github.gists.comments.get nil, nil }.to raise_error(ArgumentError)
       end
 
       it "should get the resource" do
-        github.gists.comments.get comment_id
-        a_get("/gists/comments/#{comment_id}").should have_been_made
+        github.gists.comments.get gist_id, comment_id
+        a_get("/gists/#{gist_id}/comments/#{comment_id}").should have_been_made
       end
 
       it "should get comment information" do
-        comment = github.gists.comments.get comment_id
+        comment = github.gists.comments.get gist_id, comment_id
         comment.id.should eq comment_id
         comment.user.login.should == 'octocat'
       end
 
       it "should return mash" do
-        comment = github.gists.comments.get comment_id
+        comment = github.gists.comments.get gist_id, comment_id
         comment.should be_a Hashie::Mash
       end
     end
 
     context 'resource not found' do
       before do
-        stub_get("/gists/comments/#{comment_id}").
+        stub_get("/gists/#{gist_id}/comments/#{comment_id}").
           to_return(:body => fixture('gists/comment.json'),
             :status => 404,
             :headers => {:content_type => "application/json; charset=utf-8"})
@@ -107,7 +107,7 @@ describe Github::Gists::Comments do
 
       it "should fail to retrive resource" do
         expect {
-          github.gists.comments.get comment_id
+          github.gists.comments.get gist_id, comment_id
         }.to raise_error(Github::Error::NotFound)
       end
     end
@@ -115,7 +115,8 @@ describe Github::Gists::Comments do
 
   describe "#create" do
     let(:inputs) {
-      { "body" =>"Just commenting for the sake of commenting", "unrelated" => true }
+      { "body" =>"Just commenting for the sake of commenting",
+        "unrelated" => true }
     }
 
     context "resouce created" do
@@ -172,7 +173,7 @@ describe Github::Gists::Comments do
 
     context "resouce edited" do
       before do
-        stub_patch("/gists/comments/#{comment_id}").
+        stub_patch("/gists/#{gist_id}/comments/#{comment_id}").
           with(inputs.except('unrelated')).
           to_return(:body => fixture('gists/comment.json'),
                 :status => 201,
@@ -181,29 +182,29 @@ describe Github::Gists::Comments do
 
       it "should fail to create resource if 'content' input is missing" do
         expect {
-          github.gists.comments.edit comment_id, inputs.except('body')
+          github.gists.comments.edit gist_id, comment_id, inputs.except('body')
         }.to raise_error(Github::Error::RequiredParams)
       end
 
       it "should create resource successfully" do
-        github.gists.comments.edit comment_id, inputs
-        a_patch("/gists/comments/#{comment_id}").with(inputs).should have_been_made
+        github.gists.comments.edit gist_id, comment_id, inputs
+        a_patch("/gists/#{gist_id}/comments/#{comment_id}").with(inputs).should have_been_made
       end
 
       it "should return the resource" do
-        comment = github.gists.comments.edit comment_id, inputs
+        comment = github.gists.comments.edit gist_id, comment_id, inputs
         comment.should be_a Hashie::Mash
       end
 
       it "should get the comment information" do
-        comment = github.gists.comments.edit comment_id, inputs
+        comment = github.gists.comments.edit gist_id, comment_id, inputs
         comment.user.login.should == 'octocat'
       end
     end
 
     context "failed to create resource" do
       before do
-        stub_patch("/gists/comments/#{comment_id}").with(inputs).
+        stub_patch("/gists/#{gist_id}/comments/#{comment_id}").with(inputs).
           to_return(:body => fixture('gists/comment.json'),
             :status => 404,
             :headers => {:content_type => "application/json; charset=utf-8"})
@@ -211,7 +212,7 @@ describe Github::Gists::Comments do
 
       it "should faile to retrieve resource" do
         expect {
-          github.gists.comments.edit comment_id, inputs
+          github.gists.comments.edit gist_id, comment_id, inputs
         }.to raise_error(Github::Error::NotFound)
       end
     end
@@ -220,25 +221,25 @@ describe Github::Gists::Comments do
   describe "#delete" do
     context "resouce deleted" do
       before do
-        stub_delete("/gists/comments/#{comment_id}").
+        stub_delete("/gists/#{gist_id}/comments/#{comment_id}").
           to_return(:body => '',
                 :status => 204,
                 :headers => {:content_type => "application/json; charset=utf-8"})
       end
 
       it "should fail to create resource if 'content' input is missing" do
-        expect { github.gists.comments.delete nil }.to raise_error(ArgumentError)
+        expect { github.gists.comments.delete gist_id, nil }.to raise_error(ArgumentError)
       end
 
       it "should create resource successfully" do
-        github.gists.comments.delete comment_id
-        a_delete("/gists/comments/#{comment_id}").should have_been_made
+        github.gists.comments.delete gist_id, comment_id
+        a_delete("/gists/#{gist_id}/comments/#{comment_id}").should have_been_made
       end
     end
 
     context "failed to create resource" do
       before do
-        stub_delete("/gists/comments/#{comment_id}").
+        stub_delete("/gists/#{gist_id}/comments/#{comment_id}").
           to_return(:body => fixture('gists/comment.json'),
             :status => 404,
             :headers => {:content_type => "application/json; charset=utf-8"})
@@ -246,7 +247,7 @@ describe Github::Gists::Comments do
 
       it "should faile to retrieve resource" do
         expect {
-          github.gists.comments.delete comment_id
+          github.gists.comments.delete gist_id, comment_id
         }.to raise_error(Github::Error::NotFound)
       end
     end

data/spec/github/git_data/blobs/create_spec.rb

@@ -0,0 +1,62 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::GitData::Blobs, '#create' do
+  let(:user) { 'peter-murach' }
+  let(:repo) { 'github' }
+  let(:sha) { "3a0f86fb8db8eea7ccbb9a95f325ddbedfb25e15" }
+  let(:request_path) { "/repos/#{user}/#{repo}/git/blobs" }
+  let(:inputs) {
+    {
+      "content" => "Content of the blob",
+      "encoding" =>  "utf-8",
+      "unrelated" => 'giberrish'
+    }
+  }
+
+  before {
+    stub_post(request_path).with(inputs.except('unrelated')).
+      to_return(:body => body, :status => status,
+        :headers => {:content_type => "application/json; charset=utf-8"})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  context "resouce created" do
+    let(:body) { fixture('git_data/blob_sha.json') }
+    let(:status) { 201 }
+
+    it "should fail to create resource if 'content' input is missing" do
+      expect {
+        subject.create user, repo, inputs.except('content')
+      }.to raise_error(Github::Error::RequiredParams)
+    end
+
+    it "should fail to create resource if 'encoding' input is missing" do
+      expect {
+        subject.create user, repo, inputs.except('encoding')
+      }.to raise_error(Github::Error::RequiredParams)
+    end
+
+    it "should create resource successfully" do
+      subject.create user, repo, inputs
+      a_post(request_path).with(inputs).should have_been_made
+    end
+
+    it "should return the resource" do
+      blob_sha = subject.create user, repo, inputs
+      blob_sha.should be_a Hashie::Mash
+    end
+
+    it "should get the blob information" do
+      blob_sha = subject.create user, repo, inputs
+      blob_sha.sha.should == sha
+    end
+  end
+
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.create user, repo, inputs }
+  end
+
+end # create