github_api 0.8.0 → 0.8.1

data/spec/github/git_data/blobs/get_spec.rb

@@ -0,0 +1,49 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::GitData::Blobs, '#get' do
+  let(:user) { 'peter-murach' }
+  let(:repo) { 'github' }
+  let(:sha) { "3a0f86fb8db8eea7ccbb9a95f325ddbedfb25e15" }
+  let(:request_path) { "/repos/#{user}/#{repo}/git/blobs/#{sha}" }
+
+  before {
+    stub_get(request_path).
+      to_return(:body => body, :status => status,
+        :headers => {:content_type => "application/json; charset=utf-8"})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  context "resource found" do
+    let(:body) { fixture('git_data/blob.json') }
+    let(:status) { 200 }
+
+    it { should respond_to :find }
+
+    it "should fail to get resource without sha" do
+      expect { subject.get user, repo, nil }.to raise_error(ArgumentError)
+    end
+
+    it "should get the resource" do
+      subject.get user, repo, sha
+      a_get(request_path).should have_been_made
+    end
+
+    it "should get blob information" do
+      blob = subject.get user, repo, sha
+      blob.content.should eql "Content of the blob"
+    end
+
+    it "should return mash" do
+      blob = subject.get user, repo, sha
+      blob.should be_a Hashie::Mash
+    end
+  end
+
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.get user, repo, sha }
+  end
+
+end # get

data/spec/github/git_data/blobs_spec.rb

@@ -3,123 +3,7 @@
 require 'spec_helper'
 
 describe Github::GitData::Blobs do
-  let(:github) { Github.new }
-  let(:user) { 'peter-murach' }
-  let(:repo) { 'github' }
-  let(:sha) { "3a0f86fb8db8eea7ccbb9a95f325ddbedfb25e15" }
-
-  after { github.user, github.repo, github.oauth_token = nil, nil, nil }
 
   it { described_class::VALID_BLOB_PARAM_NAMES.should_not be_nil }
 
-  describe "#get" do
-    it { github.git_data.blobs.should respond_to :find }
-
-    context "resource found" do
-      before do
-        stub_get("/repos/#{user}/#{repo}/git/blobs/#{sha}").
-          to_return(:body => fixture('git_data/blob.json'),
-            :status => 200,
-            :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should fail to get resource without sha" do
-        expect {
-          github.git_data.blobs.get user, repo, nil
-        }.to raise_error(ArgumentError)
-      end
-
-      it "should get the resource" do
-        github.git_data.blobs.get user, repo, sha
-        a_get("/repos/#{user}/#{repo}/git/blobs/#{sha}").should have_been_made
-      end
-
-      it "should get blob information" do
-        blob = github.git_data.blobs.get user, repo, sha
-        blob.content.should eql "Content of the blob"
-      end
-
-      it "should return mash" do
-        blob = github.git_data.blobs.get user, repo, sha
-        blob.should be_a Hashie::Mash
-      end
-    end
-
-    context "resource not found" do
-      before do
-        stub_get("/repos/#{user}/#{repo}/git/blobs/#{sha}").
-          to_return(:body => fixture('git_data/blob.json'),
-            :status => 404,
-            :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should fail to retrive resource" do
-        expect {
-          github.git_data.blobs.get user, repo, sha
-        }.to raise_error(Github::Error::NotFound)
-      end
-    end
-  end # get
-
-  describe "#create" do
-    let(:inputs) {
-      {
-        "content" => "Content of the blob",
-        "encoding" =>  "utf-8",
-        "unrelated" => 'giberrish'
-      }
-    }
-
-    context "resouce created" do
-      before do
-        stub_post("/repos/#{user}/#{repo}/git/blobs").
-          with(inputs.except('unrelated')).
-          to_return(:body => fixture('git_data/blob_sha.json'),
-            :status => 201,
-            :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should fail to create resource if 'content' input is missing" do
-        expect {
-          github.git_data.blobs.create user, repo, inputs.except('content')
-        }.to raise_error(Github::Error::RequiredParams)
-      end
-
-      it "should fail to create resource if 'encoding' input is missing" do
-        expect {
-          github.git_data.blobs.create user, repo, inputs.except('encoding')
-        }.to raise_error(Github::Error::RequiredParams)
-      end
-
-      it "should create resource successfully" do
-        github.git_data.blobs.create user, repo, inputs
-        a_post("/repos/#{user}/#{repo}/git/blobs").with(inputs).should have_been_made
-      end
-
-      it "should return the resource" do
-        blob_sha = github.git_data.blobs.create user, repo, inputs
-        blob_sha.should be_a Hashie::Mash
-      end
-
-      it "should get the blob information" do
-        blob_sha = github.git_data.blobs.create user, repo, inputs
-        blob_sha.sha.should == sha
-      end
-    end
-
-    context "failed to create resource" do
-      before do
-        stub_post("/repos/#{user}/#{repo}/git/blobs").with(inputs).
-          to_return(:body => fixture('git_data/blob_sha.json'), :status => 404, :headers => {:content_type => "application/json; charset=utf-8"})
-
-      end
-
-      it "should faile to retrieve resource" do
-        expect {
-          github.git_data.blobs.create user, repo, inputs
-        }.to raise_error(Github::Error::NotFound)
-      end
-    end
-  end # create
-
 end # Github::GitData::Blobs

data/spec/github/repos/branch_spec.rb

@@ -35,14 +35,8 @@ describe Github::Repos, '#branch' do
     end
   end
 
-  context "resource not found" do
-    let(:body)   { '' }
-    let(:status) { 404 }
-
-    it "should fail to get resource" do
-      expect {
-        subject.branch user, repo, branch
-      }.to raise_error(Github::Error::NotFound)
-    end
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.branch user, repo, branch }
   end
+
 end # branch

data/spec/github/repos/branches_spec.rb

@@ -31,10 +31,8 @@ describe Github::Repos, '#branches' do
       a_get(request_path).should have_been_made
     end
 
-    it "should return array of resources" do
-      branches = subject.branches user, repo
-      branches.should be_an Array
-      branches.should have(1).items
+    it_should_behave_like 'an array of resources' do
+      let(:requestable) { subject.branches user, repo }
     end
 
     it "should get branch information" do
@@ -49,14 +47,8 @@ describe Github::Repos, '#branches' do
     end
   end
 
-  context "resource not found" do
-    let(:body)   { '' }
-    let(:status) { 404 }
-
-    it "should fail to get resource" do
-      expect {
-        subject.branches user, repo
-      }.to raise_error(Github::Error::NotFound)
-    end
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.branches user, repo }
   end
+
 end # branches

data/spec/github/repos/collaborators/add_spec.rb

@@ -0,0 +1,37 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Repos::Collaborators, '#add' do
+  let(:user) { 'peter-murach' }
+  let(:repo) { 'github' }
+  let(:collaborator) { 'octocat' }
+  let(:request_path) { "/repos/#{user}/#{repo}/collaborators/#{collaborator}" }
+
+  before {
+    stub_put(request_path).
+      to_return(:body => body, :status => status,
+        :headers => {:content_type => "application/json; charset=utf-8"})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  context "resouce added" do
+    let(:body) { '' }
+    let(:status) { 204 }
+
+    it "should fail to add resource if 'collaborator' input is missing" do
+      expect { subject.add user, repo, nil }.to raise_error(ArgumentError)
+    end
+
+    it "should add resource successfully" do
+      subject.add user, repo, collaborator
+      a_put(request_path).should have_been_made
+    end
+  end
+
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.add user, repo, collaborator }
+  end
+
+end # add

data/spec/github/repos/collaborators/get_spec.rb

@@ -0,0 +1,51 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Repos::Collaborators, '#collaborator?' do
+  let(:user) { 'peter-murach' }
+  let(:repo) { 'github' }
+  let(:collaborator) { 'octocat' }
+  let(:request_path) { "/repos/#{user}/#{repo}/collaborators/#{collaborator}" }
+
+  before {
+    stub_get(request_path).
+      to_return(:body => body, :status => status,
+        :headers => {:content_type => "application/json; charset=utf-8"})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  context "resource found " do
+    let(:body) { '' }
+    let(:status) { 204 }
+
+    it "should fail to get resource without collaborator name" do
+      expect {
+        subject.collaborator? user, repo, nil
+      }.to raise_error(ArgumentError)
+    end
+
+    it "should get the resource" do
+      subject.collaborator? user, repo, collaborator
+      a_get(request_path).should have_been_made
+    end
+
+    it "should find collaborator" do
+      subject.should_receive(:collaborator?).
+        with(user, repo, collaborator) { true }
+      subject.collaborator? user, repo, collaborator
+    end
+  end
+
+  context "resource not found" do
+    let(:body) { '' }
+    let(:status) { 404 }
+
+    it "should fail to retrieve resource" do
+      subject.should_receive(:collaborator?).
+        with(user, repo, collaborator) { false }
+      subject.collaborator? user, repo, collaborator
+    end
+  end
+end # collaborator?

data/spec/github/repos/collaborators/list_spec.rb

@@ -0,0 +1,51 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Repos::Collaborators, '#list' do
+  let(:user) { 'peter-murach' }
+  let(:repo) { 'github' }
+  let(:request_path) { "/repos/#{user}/#{repo}/collaborators" }
+
+  before {
+    stub_get(request_path).
+      to_return(:body => body, :status => status,
+        :headers => {:content_type => "application/json; charset=utf-8"})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  context "resource found" do
+    let(:body) { fixture('repos/collaborators.json') }
+    let(:status) { 200 }
+
+    it "should fail to get resource without username" do
+      expect { subject.list }.to raise_error(ArgumentError)
+    end
+
+    it "should get the resources" do
+      subject.list user, repo
+      a_get(request_path).should have_been_made
+    end
+
+    it_should_behave_like 'an array of resources' do
+      let(:requestable) { subject.list user, repo }
+    end
+
+    it "should get collaborator information" do
+      collaborators = subject.list user, repo
+      collaborators.first.login.should == 'octocat'
+    end
+
+    it "should yield to a block" do
+      yielded = []
+      result = subject.list(user, repo) { |obj| yielded << obj }
+      yielded.should == result
+    end
+  end
+
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.list user, repo }
+  end
+
+end # list

data/spec/github/repos/collaborators/remove_spec.rb

@@ -0,0 +1,37 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Github::Repos::Collaborators, '#remove' do
+  let(:user) { 'peter-murach' }
+  let(:repo) { 'github' }
+  let(:collaborator) { 'octocat' }
+  let(:request_path) { "/repos/#{user}/#{repo}/collaborators/#{collaborator}" }
+
+  before {
+    stub_delete(request_path).
+      to_return(:body => body, :status => status,
+        :headers => {:content_type => "application/json; charset=utf-8"})
+  }
+
+  after { reset_authentication_for(subject) }
+
+  context "resouce removed" do
+    let(:body) { '' }
+    let(:status) { 204 }
+
+    it "should fail to add resource if 'collaborator' input is missing" do
+      expect { subject.remove user, repo, nil }.to raise_error(ArgumentError)
+    end
+
+    it "should add resource successfully" do
+      subject.remove user, repo, collaborator
+      a_delete(request_path).should have_been_made
+    end
+  end
+
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.remove user, repo, collaborator }
+  end
+
+end # remove

data/spec/github/repos/collaborators_spec.rb

@@ -1,182 +1,7 @@
 require 'spec_helper'
 
 describe Github::Repos::Collaborators do
-  let(:github) { Github.new }
-  let(:user) { 'peter-murach' }
-  let(:repo) { 'github' }
-  let(:collaborator) { 'octocat' }
 
-  after { github.user, github.repo, github.oauth_token = nil, nil, nil }
-
-  describe "#list" do
-    context "resource found" do
-      before do
-        stub_get("/repos/#{user}/#{repo}/collaborators").
-          to_return(:body => fixture('repos/collaborators.json'),
-            :status => 200,
-            :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should fail to get resource without username" do
-        expect {
-          github.repos.collaborators.list
-        }.to raise_error(ArgumentError)
-      end
-
-      it "should get the resources" do
-        github.repos.collaborators.list user, repo
-        a_get("/repos/#{user}/#{repo}/collaborators").should have_been_made
-      end
-
-      it "should return array of resources" do
-        collaborators = github.repos.collaborators.list user, repo
-        collaborators.should be_an Array
-        collaborators.should have(1).items
-      end
-
-      it "should be a mash type" do
-        collaborators = github.repos.collaborators.list user, repo
-        collaborators.first.should be_a Hashie::Mash
-      end
-
-      it "should get collaborator information" do
-        collaborators = github.repos.collaborators.list user, repo
-        collaborators.first.login.should == 'octocat'
-      end
-
-      it "should yield to a block" do
-        github.repos.collaborators.should_receive(:list).
-          with(user, repo).and_yield('web')
-        github.repos.collaborators.list(user, repo) { |param| 'web' }
-      end
-    end
-
-    context "resource not found" do
-      before do
-        stub_get("/repos/#{user}/#{repo}/collaborators").
-          to_return(:body => "", :status => [404, "Not Found"],
-            :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should return 404 with a message 'Not Found'" do
-        expect {
-          github.repos.collaborators.list user, repo
-        }.to raise_error(Github::Error::NotFound)
-      end
-    end
-  end # collaborators
-
-  describe "collaborator?" do
-    context "resource found " do
-      before do
-        stub_get("/repos/#{user}/#{repo}/collaborators/#{collaborator}").
-          to_return(:body => '', :status => 204,
-            :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should fail to get resource without collaborator name" do
-        expect {
-          github.repos.collaborators.collaborator? user, repo, nil
-        }.to raise_error(ArgumentError)
-      end
-
-      it "should get the resource" do
-        github.repos.collaborators.collaborator? user, repo, collaborator
-        a_get("/repos/#{user}/#{repo}/collaborators/#{collaborator}").
-          should have_been_made
-      end
-
-      it "should find collaborator" do
-        github.repos.should_receive(:collaborator?).
-          with(user, repo, collaborator) { true }
-        github.repos.collaborator? user, repo, collaborator
-      end
-    end
-
-    context "resource not found" do
-      before do
-        stub_get("/repos/#{user}/#{repo}/collaborators/#{collaborator}").
-          to_return(:body => '', :status => 404,
-            :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should fail to retrieve resource" do
-        github.repos.should_receive(:collaborator?).
-          with(user, repo, collaborator) { false }
-        github.repos.collaborator? user, repo, collaborator
-      end
-    end
-  end # collaborator?
-
-  describe "#add" do
-    context "resouce added" do
-      before do
-        stub_put("/repos/#{user}/#{repo}/collaborators/#{collaborator}").
-          to_return(:body => '', :status => 204,
-            :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should fail to add resource if 'collaborator' input is missing" do
-        expect {
-          github.repos.collaborators.add user, repo, nil
-        }.to raise_error(ArgumentError)
-      end
-
-      it "should add resource successfully" do
-        github.repos.collaborators.add user, repo, collaborator
-        a_put("/repos/#{user}/#{repo}/collaborators/#{collaborator}").should have_been_made
-      end
-    end
-
-    context "failed to add resource" do
-      before do
-        stub_put("/repos/#{user}/#{repo}/collaborators/#{collaborator}").
-          to_return(:body => '', :status => 404,
-            :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should fail to add resource" do
-        expect {
-          github.repos.collaborators.add user, repo, collaborator
-        }.to raise_error(Github::Error::NotFound)
-      end
-    end
-  end # add
-
-  describe "#remove" do
-    context "resouce removed" do
-      before do
-        stub_delete("/repos/#{user}/#{repo}/collaborators/#{collaborator}").
-          to_return(:body => '', :status => 204,
-            :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should fail to add resource if 'collaborator' input is missing" do
-        expect {
-          github.repos.collaborators.remove user, repo, nil
-        }.to raise_error(ArgumentError)
-      end
-
-      it "should add resource successfully" do
-        github.repos.collaborators.remove user, repo, collaborator
-        a_delete("/repos/#{user}/#{repo}/collaborators/#{collaborator}").
-          should have_been_made
-      end
-    end
-
-    context "failed to remove resource" do
-      before do
-        stub_delete("/repos/#{user}/#{repo}/collaborators/#{collaborator}").
-          to_return(:body => '', :status => 404,
-            :headers => {:content_type => "application/json; charset=utf-8"})
-      end
-
-      it "should fail to remove resource" do
-        expect {
-          github.repos.collaborators.remove user, repo, collaborator
-        }.to raise_error(Github::Error::NotFound)
-      end
-    end
-  end # remove
+  it_should_behave_like 'api interface'
 
 end # Github::Repos::Collaborators