github_api 0.8.0 → 0.8.1

data/spec/github/repos/comments/create_spec.rb

@@ -33,30 +33,6 @@ describe Github::Repos::Comments, '#create' do
       }.to raise_error(Github::Error::RequiredParams)
     end
 
-    it "should fail to create resource if 'commit_id' input is missing" do
-      expect {
-        subject.create user, repo, sha, inputs.except(:commit_id)
-      }.to raise_error(Github::Error::RequiredParams)
-    end
-
-    it "should fail to create resource if 'line' input is missing" do
-      expect {
-        subject.create user, repo, sha, inputs.except(:line)
-      }.to raise_error(Github::Error::RequiredParams)
-    end
-
-    it "should fail to create resource if 'path' input is missing" do
-      expect {
-        subject.create user, repo, sha, inputs.except(:path)
-      }.to raise_error(Github::Error::RequiredParams)
-    end
-
-    it "should fail to create resource if 'position' input is missing" do
-      expect {
-        subject.create user, repo, sha, inputs.except(:position)
-      }.to raise_error(Github::Error::RequiredParams)
-    end
-
     it "should create resource successfully" do
       subject.create user, repo, sha, inputs
       a_post(request_path).with(inputs).should have_been_made
@@ -73,14 +49,7 @@ describe Github::Repos::Comments, '#create' do
     end
   end
 
-  context "failed to create resource" do
-    let(:body)   { '' }
-    let(:status) { 404 }
-
-    it "should fail to retrieve resource" do
-      expect {
-        subject.create user, repo, sha, inputs
-      }.to raise_error(Github::Error::NotFound)
-    end
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.create user, repo, sha, inputs }
   end
 end # create

data/spec/github/repos/comments/delete_spec.rb

@@ -36,14 +36,8 @@ describe Github::Repos::Comments, '#delete' do
     end
   end
 
-  context "failed to delete resource" do
-    let(:body) { '' }
-    let(:status) { 404 }
-
-    it "should fail to find resource" do
-      expect {
-        subject.delete user, repo, comment_id
-      }.to raise_error(Github::Error::NotFound)
-    end
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.delete user, repo, comment_id }
   end
+
 end # delete

data/spec/github/repos/comments/get_spec.rb

@@ -41,14 +41,8 @@ describe Github::Repos::Comments, '#get' do
     end
   end
 
-  context "resource not found" do
-    let(:body)   { '' }
-    let(:status) { 404 }
-
-    it "should fail to retrive resource" do
-      expect {
-        subject.get user, repo, comment_id
-      }.to raise_error(Github::Error::NotFound)
-    end
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.get user, repo, comment_id }
   end
+
 end # get

data/spec/github/repos/comments/list_spec.rb

@@ -31,15 +31,8 @@ describe Github::Repos::Comments, '#list' do
         a_get(request_path).should have_been_made
       end
 
-      it "should return array of resources" do
-        repo_comments = subject.list user, repo
-        repo_comments.should be_an Array
-        repo_comments.should have(1).items
-      end
-
-      it "should be a mash type" do
-        repo_comments = subject.list user, repo
-        repo_comments.first.should be_a Hashie::Mash
+      it_should_behave_like 'an array of resources' do
+        let(:requestable) { subject.list user, repo }
       end
 
       it "should get commit comment information" do
@@ -48,21 +41,16 @@ describe Github::Repos::Comments, '#list' do
       end
 
       it "should yield to a block" do
-        subject.should_receive(:list).with(user, repo).and_yield('web')
-        subject.list(user, repo) { |param| 'web' }
+        yielded = []
+        result = subject.list(user, repo) { |obj| yielded << obj }
+        yielded.should == result
       end
     end
 
-    context "resource not found" do
-      let(:body) { '' }
-      let(:status) { [404, "Not Found"] }
-
-      it "should return 404 with a message 'Not Found'" do
-        expect {
-          subject.list user, repo
-        }.to raise_error(Github::Error::NotFound)
-      end
+    it_should_behave_like 'request failure' do
+      let(:requestable) { subject.list user, repo }
     end
+
   end # without sha
 
   context 'with sha' do
@@ -83,15 +71,8 @@ describe Github::Repos::Comments, '#list' do
         a_get(request_path).should have_been_made
       end
 
-      it "should return array of resources" do
-        commit_comments = subject.list user, repo, :sha => sha
-        commit_comments.should be_an Array
-        commit_comments.should have(1).items
-      end
-
-      it "should be a mash type" do
-        commit_comments = subject.list user, repo, :sha => sha
-        commit_comments.first.should be_a Hashie::Mash
+      it_should_behave_like 'an array of resources' do
+        let(:requestable) { subject.list user, repo, :sha => sha }
       end
 
       it "should get commit comment information" do
@@ -100,21 +81,16 @@ describe Github::Repos::Comments, '#list' do
       end
 
       it "should yield to a block" do
-        subject.should_receive(:list).with(user, repo, :sha=>sha).and_yield('web')
-        subject.list(user, repo, :sha => sha) { |param| 'web' }
+        yielded = []
+        result = subject.list(user, repo, :sha => sha) { |obj| yielded << obj }
+        yielded.should == result
       end
     end
 
-    context "resource not found" do
-      let(:body) { '' }
-      let(:status) { 404 }
-
-      it "should fail to retrive resource" do
-        expect {
-          subject.list user, repo, :sha => sha
-        }.to raise_error(Github::Error::NotFound)
-      end
+    it_should_behave_like 'request failure' do
+      let(:requestable) { subject.list user, repo, :sha => sha }
     end
+
   end # with sha
 
 end # list

data/spec/github/repos/comments/update_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Github::Repos::Comments, '#delete' do
+describe Github::Repos::Comments, '#update' do
   let(:user) { 'peter-murach' }
   let(:repo) { 'github' }
   let(:comment_id) { 1 }
@@ -41,14 +41,8 @@ describe Github::Repos::Comments, '#delete' do
     end
   end
 
-  context "failed to update resource" do
-    let(:body)   { '' }
-    let(:status) { 404 }
-
-    it "should fail to retrieve resource" do
-      expect {
-        subject.update user, repo, comment_id, inputs
-      }.to raise_error(Github::Error::NotFound)
-    end
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.update user, repo, comment_id, inputs }
   end
-end # update_comment
+
+end # update

data/spec/github/repos/commits/get_spec.rb

@@ -43,14 +43,8 @@ describe Github::Repos::Commits, '#get' do
     end
   end
 
-  context "resource not found" do
-    let(:body)   { '' }
-    let(:status) { 404 }
-
-    it "should fail to retrive resource" do
-      expect {
-        subject.get user, repo, sha
-      }.to raise_error(Github::Error::NotFound)
-    end
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.get user, repo, sha }
   end
+
 end # get

data/spec/github/repos/commits/list_spec.rb

@@ -19,6 +19,7 @@ describe Github::Repos::Commits, '#list' do
     let(:status) { 200 }
 
     it { should respond_to :all }
+
     it "should fail to get resource without username" do
       expect { subject.list }.to raise_error(ArgumentError)
     end
@@ -28,15 +29,8 @@ describe Github::Repos::Commits, '#list' do
       a_get(request_path).should have_been_made
     end
 
-    it "should return array of resources" do
-      commits = subject.list user, repo
-      commits.should be_an Array
-      commits.should have(1).items
-    end
-
-    it "should be a mash type" do
-      commits = subject.list user, repo
-      commits.first.should be_a Hashie::Mash
+    it_should_behave_like 'an array of resources' do
+      let(:requestable) { subject.list user, repo }
     end
 
     it "should get commit information" do
@@ -45,19 +39,14 @@ describe Github::Repos::Commits, '#list' do
     end
 
     it "should yield to a block" do
-      subject.should_receive(:list).with(user, repo).and_yield('web')
-      subject.list(user, repo) { |param| 'web' }
+      yielded = []
+      result = subject.list(user, repo) { |obj| yielded << obj }
+      yielded.should == result
     end
   end
 
-  context "resource not found" do
-    let(:body) { '' }
-    let(:status) { [404, "Not Found"] }
-
-    it "should return 404 with a message 'Not Found'" do
-      expect {
-        subject.list user, repo
-      }.to raise_error(Github::Error::NotFound)
-    end
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.list user, repo }
   end
+
 end # list

data/spec/github/repos/contributors_spec.rb

@@ -32,10 +32,8 @@ describe Github::Repos, '#contributors' do
       a_get(request_path).should have_been_made
     end
 
-    it "should return array of resources" do
-      contributors = subject.contributors user, repo
-      contributors.should be_an Array
-      contributors.should have(1).items
+    it_should_behave_like 'an array of resources' do
+      let(:requestable) { subject.contributors user, repo }
     end
 
     it "should get branch information" do
@@ -49,14 +47,8 @@ describe Github::Repos, '#contributors' do
     end
   end
 
-  context "resource not found" do
-    let(:body)   { '' }
-    let(:status) { 404 }
-
-    it "should fail to get resource" do
-      expect {
-        subject.contributors user, repo
-      }.to raise_error(Github::Error::NotFound)
-    end
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.contributors user, repo }
   end
+
 end # contributors

data/spec/github/repos/delete_spec.rb

@@ -31,13 +31,8 @@ describe Github::Repos, '#delete' do
     expect { subject.delete user, nil }.to raise_error(ArgumentError)
   end
 
-  context 'failed to delete' do
-    let(:status) { 404 }
-
-    it "should fail to delete resource that is not found" do
-      expect {
-        subject.delete user, repo
-      }.to raise_error(Github::Error::NotFound)
-    end
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.delete user, repo }
   end
+
 end # delete

data/spec/github/repos/downloads/create_spec.rb

@@ -53,14 +53,8 @@ describe Github::Repos::Downloads, '#create' do
     end
   end
 
-  context "failed to create resource" do
-    let(:body)   { "" }
-    let(:status) { [404, "Not Found"] }
-
-    it "should faile to retrieve resource" do
-      expect {
-        subject.create user, repo, inputs
-      }.to raise_error(Github::Error::NotFound)
-    end
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.create user, repo, inputs }
   end
+
 end # create

data/spec/github/repos/downloads/delete_spec.rb

@@ -35,14 +35,8 @@ describe Github::Repos::Downloads, '#delete' do
     end
   end
 
-  context "failed to delete resource" do
-    let(:body)   { "" }
-    let(:status) { [404, "Not Found"] }
-
-    it "should fail to find resource" do
-      expect {
-        subject.delete user, repo, download_id
-      }.to raise_error(Github::Error::NotFound)
-    end
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.delete user, repo, download_id }
   end
+
 end # delete

data/spec/github/repos/downloads/get_spec.rb

@@ -3,13 +3,12 @@
 require 'spec_helper'
 
 describe Github::Repos::Downloads, '#get' do
-  let(:github) { Github.new }
   let(:user) { 'peter-murach' }
   let(:repo) { 'github' }
   let(:download_id) { 1 }
   let(:request_path) { "/repos/#{user}/#{repo}/downloads/#{download_id}" }
 
-  after { reset_authentication_for(github) }
+  after { reset_authentication_for(subject) }
 
   before {
     stub_get(request_path).
@@ -28,7 +27,7 @@ describe Github::Repos::Downloads, '#get' do
     end
 
     it "should get the resource" do
-      github.repos.downloads.get user, repo, download_id
+      subject.get user, repo, download_id
       a_get(request_path).should have_been_made
     end
 
@@ -44,15 +43,9 @@ describe Github::Repos::Downloads, '#get' do
     end
   end
 
-  context "resource not found" do
-    let(:body) { "" }
-    let(:status) { [404, "Not Found"] }
-
-    it "should fail to retrive resource" do
-      expect {
-        subject.get user, repo, download_id
-      }.to raise_error(Github::Error::NotFound)
-    end
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.get user, repo, download_id }
   end
+
 end # get
 

data/spec/github/repos/downloads/list_spec.rb

@@ -30,15 +30,8 @@ describe Github::Repos::Downloads, '#list' do
       a_get(request_path).should have_been_made
     end
 
-    it "should return array of resources" do
-      downloads = subject.list user, repo
-      downloads.should be_an Array
-      downloads.should have(1).items
-    end
-
-    it "should be a mash type" do
-      downloads = subject.list user, repo
-      downloads.first.should be_a Hashie::Mash
+    it_should_behave_like 'an array of resources' do
+      let(:requestable) { subject.list user, repo }
     end
 
     it "should get download information" do
@@ -47,17 +40,14 @@ describe Github::Repos::Downloads, '#list' do
     end
 
     it "should yield to a block" do
-      subject.should_receive(:list).with(user, repo).and_yield('web')
-      subject.list(user, repo) { |param| 'web' }
+      yielded = []
+      result = subject.list(user, repo) { |obj| yielded << obj }
+      yielded.should == result
     end
   end
 
-  context "resource not found" do
-    let(:body)   { "" }
-    let(:status) { [404, "Not Found"] }
-
-    it "should return 404 with a message 'Not Found'" do
-      expect { subject.list user, repo }.to raise_error(Github::Error::NotFound)
-    end
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.list user, repo }
   end
+
 end # list

data/spec/github/repos/edit_spec.rb

@@ -53,14 +53,8 @@ describe Github::Repos, '#edit' do
     end
   end
 
-  context "failed to edit resource" do
-    let(:body)   { '' }
-    let(:status) { 404 }
-
-    it "should fail to find resource" do
-      expect {
-        subject.edit user, repo, inputs
-      }.to raise_error(Github::Error::NotFound)
-    end
+  it_should_behave_like 'request failure' do
+    let(:requestable) { subject.edit user, repo, inputs }
   end
+
 end # edit