finapps 5.0.3 → 5.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7cc8f3182020dea8fb734048141cf00d287e70d107e71006671b88ed2f81d9fa
-  data.tar.gz: 8d21a3acc5bb62ce331672b0bceff88d46096d49d3200d9e9e0129fece5a192e
+  metadata.gz: '095e2b6352f9f63b6ad47ff7dc24a5a57badbe81c07395b248cc8d2106b95e2e'
+  data.tar.gz: 75df3521c3058b8e5693a506b7cd7da232b434e38299aae0a34bc91361f6373a
 SHA512:
-  metadata.gz: 53ec19d9a43dccfa1b3ba605b4216a5001ab26e1c30bf1dbf318120e1648ea83486a467d94fbf87b4563c359bc194c2ca95bd531bb5086d141238b515d84c9ba
-  data.tar.gz: f30df20bf25322843b993c1a5bbf484e5d3eff0d9cd0b663bde45e013241279610c07a2d49abc3d2029a0d1a5a34b2dd87ae360ab55c8bf20e82c135048c23ca
+  metadata.gz: 471c9ab99b5048b6ccf6fe069b447182e2480b4d4d41923720576ddb580cce693fa9f71f115594aa8d6bc6ade620d0de4b6c2994f6b8851cfbf424b73c368d0c
+  data.tar.gz: 16fa7ed1754577cb389a5cfad5c511d35ae3b764a57292313a30fb38198e6ab341a6f5fc91c87b44a6c89246938406abfc302734d546da0fac5dd87a219ac0e4

data/.gitignore

@@ -28,3 +28,6 @@ mkmf.log
 .idea/
 /spec/tmp/*
 /Gemfile.lock
+
+# vim swap files
+*.swp

data/.rubocop.yml

@@ -13,12 +13,6 @@ Metrics/LineLength:
 Style/AccessModifierDeclarations:
   Enabled: false
 
-Layout/SpaceInsideBlockBraces:
-  # The space here provides no real gain in readability while consuming
-  # horizontal space that could be used for a better parameter name.
-  # Also {| differentiates better from a hash than { | does.
-  SpaceBeforeBlockParameters: false
-
 Style/CollectionMethods:
   Description: Preferred collection methods.
   StyleGuide: https://github.com/bbatsov/ruby-style-guide#map-find-select-reduce-size
@@ -98,4 +92,4 @@ Style/VariableInterpolation:
 Lint/HandleExceptions:
   Description: Don't suppress exception.
   StyleGuide: https://github.com/bbatsov/ruby-style-guide#dont-hide-exceptions
-  Enabled: false
+  Enabled: false

data/.tmuxinator.yml

@@ -0,0 +1,19 @@
+--- 
+name: ruby-client
+root: ~/projects/ruby-client/
+windows: 
+  - 
+    editor: 
+      layout: main-vertical
+      panes: 
+        - vim: $EDITOR
+        - bash: 
+          - git pull
+          - git status
+          - bundle
+  - 
+    guard: 
+      layout: even-horizontal
+      panes:
+        - guard:
+          - bundle exec guard

data/Guardfile

@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+# A sample Guardfile
+# More info at https://github.com/guard/guard#readme
+
+## Uncomment and set this to only include directories you want to watch
+# directories %w(app lib config test spec features) \
+#  .select{|d| Dir.exist?(d) ? d : UI.warning("Directory #{d} does not exist")}
+
+## Note: if you are using the `directories` clause above and you are not
+## watching the project directory ('.'), then you will want to move
+## the Guardfile to a watched dir and symlink it back, e.g.
+#
+#  $ mkdir config
+#  $ mv Guardfile config/
+#  $ ln -s config/Guardfile .
+#
+# and, you'll have to watch "config/Guardfile" instead of "Guardfile"
+
+# Note: The cmd option is now required due to the increasing number of ways
+#       rspec may be run, below are examples of the most common uses.
+#  * bundler: 'bundle exec rspec'
+#  * bundler binstubs: 'bin/rspec'
+#  * spring: 'bin/rspec' (This will use spring if running and you have
+#                          installed the spring binstubs per the docs)
+#  * zeus: 'zeus rspec' (requires the server to be started separately)
+#  * 'just' rspec: 'rspec'
+
+guard :rspec, cmd: 'bundle exec rspec' do
+  require 'guard/rspec/dsl'
+  dsl = Guard::RSpec::Dsl.new(self)
+
+  # RSpec files
+  rspec = dsl.rspec
+  watch(rspec.spec_helper) { rspec.spec_dir }
+  watch(rspec.spec_support) { rspec.spec_dir }
+  watch(rspec.spec_files)
+
+  # Ruby files
+  ruby = dsl.ruby
+  dsl.watch_spec_files_for(ruby.lib_files)
+end

data/finapps.gemspec

@@ -20,11 +20,13 @@ Gem::Specification.new do |spec|
   spec.test_files = Dir['spec/**/*.rb']
   spec.require_paths = ['lib']
 
-  spec.add_runtime_dependency     'finapps_core',               '~> 5.0',   '>= 5.0.0'
+  spec.add_runtime_dependency     'finapps_core',               '~> 5.0',   '>= 5.0.1'
 
   spec.add_development_dependency 'bundler',                    '~> 2.0',   '>= 2.0.2'
   spec.add_development_dependency 'codeclimate-test-reporter',  '~> 1.0',   '>= 1.0.9'
   spec.add_development_dependency 'gem-release',                '~> 2.0',   '>= 2.0.3'
+  spec.add_development_dependency 'guard',                      '~> 2.15',  '>= 2.15.0'
+  spec.add_development_dependency 'guard-rspec',                '~> 4.7',   '>= 4.7.3'
   spec.add_development_dependency 'rake',                       '~> 12.3',  '>= 12.3.2'
   spec.add_development_dependency 'rspec',                      '~> 3.8',   '>= 3.8.0'
   spec.add_development_dependency 'rubocop',                    '~> 0.73',  '>= 0.73.0'

data/lib/finapps.rb

@@ -6,16 +6,9 @@ require 'faraday_middleware'
 require 'finapps_core'
 require 'finapps/rest/version'
 require 'finapps/rest/consumers'
-require 'finapps/rest/consumer_institution_refreshes'
-require 'finapps/rest/consumer_institution_refresh'
 require 'finapps/rest/sessions'
 require 'finapps/rest/order_tokens'
 require 'finapps/rest/orders'
-require 'finapps/rest/institutions_forms'
-require 'finapps/rest/institutions'
-require 'finapps/rest/user_institutions_statuses'
-require 'finapps/rest/user_institutions'
-require 'finapps/rest/user_institutions_forms'
 require 'finapps/rest/order_reports'
 require 'finapps/rest/order_statuses'
 require 'finapps/rest/order_notifications'
@@ -37,6 +30,7 @@ require 'finapps/rest/portfolios_alerts'
 require 'finapps/rest/portfolios_consumers'
 require 'finapps/rest/consumers_portfolios'
 require 'finapps/rest/portfolio_reports'
+
 require 'finapps/rest/plaid/plaid_webhooks'
 
 require 'finapps/utils/query_builder'

data/lib/finapps/rest/client.rb

@@ -10,8 +10,6 @@ module FinApps
         alert_definitions
         alert_occurrences
         consumers_portfolios
-        institutions
-        institutions_forms
         orders
         order_assignments
         order_notifications
@@ -29,15 +27,9 @@ module FinApps
         portfolios_consumers
         portfolio_reports
         sessions
-        statements
         consumers
-        consumer_institution_refreshes
-        consumer_institution_refresh
         tenant_settings
         tenant_app_settings
-        user_institutions
-        user_institutions_forms
-        user_institutions_statuses
         version
         plaid_webhooks
       ].freeze
@@ -57,7 +49,8 @@ module FinApps
           class_name = camelize(symbol.to_s)
           variable = "@#{class_name.downcase}"
           unless instance_variable_defined? variable
-            klass = Object.const_get('FinApps').const_get('REST').const_get class_name
+            klass =
+              Object.const_get('FinApps').const_get('REST').const_get class_name
             instance_variable_set(variable, klass.new(self))
           end
           instance_variable_get(variable)
@@ -75,7 +68,9 @@ module FinApps
       def camelize(term)
         string = term.to_s
         string = string.sub(/^[a-z\d]*/) { $&.capitalize }
-        string.gsub(%r{(?:_|(/))([a-z\d]*)}) { Regexp.last_match(2).capitalize.to_s }
+        string.gsub(%r{(?:_|(/))([a-z\d]*)}) do
+          Regexp.last_match(2).capitalize.to_s
+        end
       end
     end
   end

data/lib/finapps/rest/consumers.rb

@@ -21,7 +21,8 @@ module FinApps
         not_blank(public_id, :public_id)
         not_blank(params, :params)
 
-        path = "#{end_point}/#{ERB::Util.url_encode(public_id)}#{'/password' if password_update?(params)}"
+        path =
+          "#{end_point}/#{ERB::Util.url_encode(public_id)}#{'/password' if password_update?(params)}"
         super params, path
       end
 

data/lib/finapps/rest/operators.rb

@@ -51,7 +51,9 @@ module FinApps
       private
 
       def validates(params)
-        params.key?(:password) && params[:password] && params.key?(:password_confirm) && params[:password_confirm]
+        params.key?(:password) && params[:password] &&
+          params.key?(:password_confirm) &&
+          params[:password_confirm]
       end
 
       def build_filter(params)
@@ -66,7 +68,11 @@ module FinApps
       end
 
       def role_query(role)
-        role.is_a?(Array) ? { "role": { "$in": role.map(&:to_i) } } : { "role": role.to_i }
+        if role.is_a?(Array)
+          { "role": { "$in": role.map(&:to_i) } }
+        else
+          { "role": role.to_i }
+        end
       end
     end
   end

data/lib/finapps/rest/order_reports.rb

@@ -8,7 +8,8 @@ module FinApps
         not_blank(format, :format)
         raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: format' unless accepted_format?(format)
 
-        path = "orders/#{ERB::Util.url_encode(id)}/report.#{ERB::Util.url_encode(format)}"
+        path =
+          "orders/#{ERB::Util.url_encode(id)}/report.#{ERB::Util.url_encode(format)}"
         super nil, path
       end
 

data/lib/finapps/rest/orders.rb

@@ -68,22 +68,24 @@ module FinApps
       def search_query(term)
         {
           "$or": [
-            { "public_id": {
-              "$regex": "^#{term}",
-              "$options": 'i'
-            } },
+            { "public_id": { "$regex": "^#{term}", "$options": 'i' } },
             { "applicant.last_name": term },
             { "assignment.last_name": term },
-            { "requestor.reference_no": {
-              "$regex": "^#{term}",
-              "$options": 'i'
-            } }
+            {
+              "requestor.reference_no": {
+                "$regex": "^#{term}", "$options": 'i'
+              }
+            }
           ]
         }
       end
 
       def status_query(status)
-        status.is_a?(Array) ? { "status": { "$in": status.map(&:to_i) } } : { "status": status.to_i }
+        if status.is_a?(Array)
+          { "status": { "$in": status.map(&:to_i) } }
+        else
+          { "status": status.to_i }
+        end
       end
 
       def assignment_query(assignment)

data/lib/finapps/rest/plaid/plaid_consumer_institutions.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+module FinApps
+  module REST
+    class PlaidConsumerInstitutions < FinAppsCore::REST::Resources # :nodoc:
+      def create(params)
+        super(params, 'p/institution/consumer')
+      end
+
+      def list
+        super 'p/institution/consumer'
+      end
+    end
+  end
+end

data/lib/finapps/rest/portfolios_alerts.rb

@@ -26,7 +26,8 @@ module FinApps
       private
 
       def build_path(portfolio_id, alert_id = nil)
-        alert_path = alert_id ? "alerts/#{ERB::Util.url_encode(alert_id)}" : 'alerts'
+        alert_path =
+          alert_id ? "alerts/#{ERB::Util.url_encode(alert_id)}" : 'alerts'
         "portfolios/#{ERB::Util.url_encode(portfolio_id)}/" + alert_path
       end
     end

data/lib/finapps/rest/portfolios_available_consumers.rb

@@ -8,7 +8,8 @@ module FinApps
       def list(portfolio_id, params = nil)
         not_blank(portfolio_id, :portfolio_id)
 
-        path = "portfolios/#{ERB::Util.url_encode(portfolio_id)}/consumers/available"
+        path =
+          "portfolios/#{ERB::Util.url_encode(portfolio_id)}/consumers/available"
         return super path if params.nil?
 
         raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params' unless params.is_a? Hash

data/lib/finapps/rest/portfolios_consumers.rb

@@ -37,7 +37,12 @@ module FinApps
       private
 
       def build_path(portfolio_id, consumer_id = nil)
-        consumer_path = consumer_id ? "consumers/#{ERB::Util.url_encode(consumer_id)}" : 'consumers'
+        consumer_path =
+          if consumer_id
+            "consumers/#{ERB::Util.url_encode(consumer_id)}"
+          else
+            'consumers'
+          end
         "portfolios/#{ERB::Util.url_encode(portfolio_id)}/" + consumer_path
       end
     end

data/lib/finapps/rest/products.rb

@@ -2,7 +2,6 @@
 
 module FinApps
   module REST
-    class Products < FinAppsCore::REST::Resources
-    end
+    class Products < FinAppsCore::REST::Resources; end
   end
 end

data/lib/finapps/rest/sessions.rb

@@ -15,7 +15,12 @@ module FinApps
         begin
           super params, path
         rescue FinAppsCore::ApiUnauthenticatedError
-          return [nil, ["Invalid #{path == CONSUMER_LOGIN ? 'Consumer' : 'Operator'} Identifier or Credentials"]]
+          return [
+            nil,
+            [
+              "Invalid #{path == CONSUMER_LOGIN ? 'Consumer' : 'Operator'} Identifier or Credentials"
+            ]
+          ]
         end
       end
 
@@ -26,7 +31,8 @@ module FinApps
       private
 
       def validates(params)
-        params.key?(:email) && params[:email] && params.key?(:password) && params[:password]
+        params.key?(:email) && params[:email] && params.key?(:password) &&
+          params[:password]
       end
     end
   end

data/lib/finapps/rest/statements.rb

@@ -7,7 +7,8 @@ module FinApps
         not_blank(account_id, :account_id)
         not_blank(document_id, :document_id)
 
-        path = "accounts/#{ERB::Util.url_encode(account_id)}/statement/#{ERB::Util.url_encode(document_id)}"
+        path =
+          "accounts/#{ERB::Util.url_encode(account_id)}/statement/#{ERB::Util.url_encode(document_id)}"
         super nil, path
       end
     end

data/lib/finapps/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module FinApps
-  VERSION = '5.0.3'
+  VERSION = '5.0.4'
 end

data/spec/rest/alert_definitions_spec.rb

@@ -16,7 +16,9 @@ RSpec.describe FinApps::REST::AlertDefinitions do
 
       it { expect { list }.not_to raise_error }
       it('returns an array') { expect(list).to be_a(Array) }
-      it('performs a get and returns the response') { expect(results).to respond_to(:records) }
+      it('performs a get and returns the response') do
+        expect(results).to have_key(:records)
+      end
       it('returns no error messages') { expect(errors).to be_empty }
     end
 
@@ -31,12 +33,15 @@ RSpec.describe FinApps::REST::AlertDefinitions do
 
       it { expect { list }.not_to raise_error }
       it('returns an array') { expect(list).to be_a(Array) }
-      it('performs a get and returns the response') { expect(results).to respond_to(:records) }
+      it('performs a get and returns the response') do
+        expect(results).to have_key(:records)
+      end
       it('returns no error messages') { expect(errors).to be_empty }
       it 'builds query and sends proper request' do
         list
-        url = "#{versioned_api_path}/portfolio/alerts/definitions?page=2&requested=25&" \
-        'sort=-created_date'
+        url =
+          "#{versioned_api_path}/portfolio/alerts/definitions?page=2&requested=25&" \
+            'sort=-created_date'
         expect(WebMock).to have_requested(:get, url)
       end
     end
@@ -56,11 +61,11 @@ RSpec.describe FinApps::REST::AlertDefinitions do
     context 'when valid id is provided' do
       let(:id) { 'valid_id' }
 
-      it { expect { show }.not_to raise_error(FinAppsCore::MissingArgumentsError) }
+      it { expect { show }.not_to raise_error }
       it('returns an array') { expect(show).to be_a(Array) }
       it('performs a get and returns the response') do
-        expect(results).to respond_to(:_id)
-        expect(results).to respond_to(:rule_name)
+        expect(results).to have_key(:_id)
+        expect(results).to have_key(:rule_name)
       end
       it('returns no error messages') { expect(errors).to be_empty }
     end

data/spec/rest/alert_occurrences_spec.rb

@@ -16,7 +16,9 @@ RSpec.describe FinApps::REST::AlertOccurrences do
 
       it { expect { list }.not_to raise_error }
       it('returns an array') { expect(list).to be_a(Array) }
-      it('performs a get and returns the response') { expect(results).to respond_to(:records) }
+      it('performs a get and returns the response') do
+        expect(results).to have_key(:records)
+      end
       it('returns no error messages') { expect(errors).to be_empty }
     end
 
@@ -27,16 +29,26 @@ RSpec.describe FinApps::REST::AlertOccurrences do
     end
 
     context 'when including valid params' do
-      let(:params) { { page: 2, sort: '-created_date', requested: 25, portfolio_id: 'valid_id' } }
+      let(:params) do
+        {
+          page: 2,
+          sort: '-created_date',
+          requested: 25,
+          portfolio_id: 'valid_id'
+        }
+      end
 
       it { expect { list }.not_to raise_error }
       it('returns an array') { expect(list).to be_a(Array) }
-      it('performs a get and returns the response') { expect(results).to respond_to(:records) }
+      it('performs a get and returns the response') do
+        expect(results).to have_key(:records)
+      end
       it('returns no error messages') { expect(errors).to be_empty }
       it 'builds query and sends proper request' do
         list
-        url = "#{versioned_api_path}/portfolio/alerts/occurrences?" \
-        'filter=%7B%22portfolio_id%22:%22valid_id%22%7D&page=2&requested=25&sort=-created_date'
+        url =
+          "#{versioned_api_path}/portfolio/alerts/occurrences?" \
+            'filter=%7B%22portfolio_id%22:%22valid_id%22%7D&page=2&requested=25&sort=-created_date'
         expect(WebMock).to have_requested(:get, url)
       end
     end