finapps 5.0.3 → 5.0.4

data/spec/rest/operators_password_resets_spec.rb

@@ -2,9 +2,12 @@
 
 require 'spec_helpers/client'
 
-RSpec.describe FinApps::REST::OperatorsPasswordResets, 'initialized with valid FinApps::Client object' do
+RSpec.describe FinApps::REST::OperatorsPasswordResets,
+               'initialized with valid FinApps::Client object' do
   include SpecHelpers::Client
-  subject(:operators_password_resets) { FinApps::REST::OperatorsPasswordResets.new(client) }
+  subject(:operators_password_resets) do
+    FinApps::REST::OperatorsPasswordResets.new(client)
+  end
 
   describe '#create' do
     let(:results) { create[0] }
@@ -13,13 +16,17 @@ RSpec.describe FinApps::REST::OperatorsPasswordResets, 'initialized with valid F
     context 'when missing params' do
       let(:create) { subject.create(nil) }
 
-      it { expect { create }.to raise_error(FinAppsCore::MissingArgumentsError) }
+      it do
+        expect { create }.to raise_error(FinAppsCore::MissingArgumentsError)
+      end
     end
 
     context 'for invalid params' do
       let(:create) { subject.create(params: 'invalid params') }
 
-      it { expect { create }.to raise_error(FinAppsCore::InvalidArgumentsError) }
+      it do
+        expect { create }.to raise_error(FinAppsCore::InvalidArgumentsError)
+      end
     end
 
     context 'for valid params' do
@@ -28,9 +35,9 @@ RSpec.describe FinApps::REST::OperatorsPasswordResets, 'initialized with valid F
       it { expect { create }.not_to raise_error }
       it('returns an array') { expect(create).to be_a(Array) }
       it('performs a post and returns the response') do
-        expect(results).to respond_to(:public_id)
-        expect(results).to respond_to(:token)
-        expect(results).to respond_to(:expiry_date)
+        expect(results).to have_key(:public_id)
+        expect(results).to have_key(:token)
+        expect(results).to have_key(:expiry_date)
       end
       it('returns no error messages') { expect(error_messages).to be_empty }
     end
@@ -43,7 +50,9 @@ RSpec.describe FinApps::REST::OperatorsPasswordResets, 'initialized with valid F
     context 'when missing params' do
       let(:update) { subject.update(nil) }
 
-      it { expect { update }.to raise_error(FinAppsCore::MissingArgumentsError) }
+      it do
+        expect { update }.to raise_error(FinAppsCore::MissingArgumentsError)
+      end
     end
 
     context 'for invalid params' do
@@ -62,8 +71,8 @@ RSpec.describe FinApps::REST::OperatorsPasswordResets, 'initialized with valid F
       it { expect { update }.not_to raise_error }
       it('returns an array') { expect(update).to be_a(Array) }
       it('performs a post and returns the response') do
-        expect(results).to respond_to(:public_id)
-        expect(results).to respond_to(:role)
+        expect(results).to have_key(:public_id)
+        expect(results).to have_key(:role)
       end
       it('returns no error messages') { expect(error_messages).to be_empty }
     end

data/spec/rest/operators_spec.rb

@@ -2,7 +2,8 @@
 
 require 'spec_helpers/client'
 
-RSpec.describe FinApps::REST::Operators, 'initialized with valid FinApps::Client object' do
+RSpec.describe FinApps::REST::Operators,
+               'initialized with valid FinApps::Client object' do
   include SpecHelpers::Client
   subject(:operators) { FinApps::REST::Operators.new(client) }
 
@@ -14,8 +15,12 @@ RSpec.describe FinApps::REST::Operators, 'initialized with valid FinApps::Client
     context 'when missing params' do
       let(:params) { nil }
       it { expect { list }.not_to raise_error }
-      it('performs a get and returns the response') { expect(results).to respond_to(:records) }
-      it('returns an array of records') { expect(results.records).to be_a(Array) }
+      it('performs a get and returns the response') do
+        expect(results).to have_key(:records)
+      end
+      it('returns an array of records') do
+        expect(results[:records]).to be_a(Array)
+      end
       it('returns no error messages') { expect(error_messages).to be_empty }
     end
 
@@ -26,16 +31,29 @@ RSpec.describe FinApps::REST::Operators, 'initialized with valid FinApps::Client
     end
 
     context 'when including valid params' do
-      let(:params) { { page: 2, sort: 'date_created', requested: 25, searchTerm: 'term', role: 2 } }
+      let(:params) do
+        {
+          page: 2,
+          sort: 'date_created',
+          requested: 25,
+          searchTerm: 'term',
+          role: 2
+        }
+      end
 
       it { expect { list }.not_to raise_error }
-      it('performs a get and returns the response') { expect(results).to respond_to(:records) }
-      it('returns an array of records') { expect(results.records).to be_a(Array) }
+      it('performs a get and returns the response') do
+        expect(results).to have_key(:records)
+      end
+      it('returns an array of records') do
+        expect(results[:records]).to be_a(Array)
+      end
       it('returns no error messages') { expect(error_messages).to be_empty }
       it 'builds query and sends proper request' do
         list
-        url = "#{versioned_api_path}/operators?filter=%7B%22last_name%22:%22term%22," \
-              '%22role%22:2%7D&page=2&requested=25&sort=date_created'
+        url =
+          "#{versioned_api_path}/operators?filter=%7B%22last_name%22:%22term%22," \
+            '%22role%22:2%7D&page=2&requested=25&sort=date_created'
         expect(WebMock).to have_requested(:get, url)
       end
     end
@@ -66,7 +84,9 @@ RSpec.describe FinApps::REST::Operators, 'initialized with valid FinApps::Client
 
       it { expect { show }.not_to raise_error }
       it('returns an array') { expect(show).to be_a(Array) }
-      it('performs a get and returns the response') { expect(results).to respond_to(:public_id) }
+      it('performs a get and returns the response') do
+        expect(results).to have_key(:public_id)
+      end
       it('returns no error messages') { expect(error_messages).to be_empty }
     end
   end
@@ -78,7 +98,9 @@ RSpec.describe FinApps::REST::Operators, 'initialized with valid FinApps::Client
     context 'when missing params' do
       let(:create) { subject.create(nil) }
 
-      it { expect { create }.to raise_error(FinAppsCore::MissingArgumentsError) }
+      it do
+        expect { create }.to raise_error(FinAppsCore::MissingArgumentsError)
+      end
     end
 
     context 'when invalid params are provided' do
@@ -97,8 +119,8 @@ RSpec.describe FinApps::REST::Operators, 'initialized with valid FinApps::Client
       it { expect { create }.not_to raise_error }
       it('returns an array') { expect(create).to be_a(Array) }
       it('performs a post and returns the response') do
-        expect(results).to respond_to(:public_id)
-        expect(results).to respond_to(:role)
+        expect(results).to have_key(:public_id)
+        expect(results).to have_key(:role)
       end
       it('returns no error messages') { expect(error_messages).to be_empty }
     end
@@ -111,13 +133,17 @@ RSpec.describe FinApps::REST::Operators, 'initialized with valid FinApps::Client
     context 'when missing id' do
       let(:update) { subject.update(nil, params: 'params') }
 
-      it { expect { update }.to raise_error(FinAppsCore::MissingArgumentsError) }
+      it do
+        expect { update }.to raise_error(FinAppsCore::MissingArgumentsError)
+      end
     end
 
     context 'when missing params' do
       let(:update) { subject.update(:valid_id, nil) }
 
-      it { expect { update }.to raise_error(FinAppsCore::MissingArgumentsError) }
+      it do
+        expect { update }.to raise_error(FinAppsCore::MissingArgumentsError)
+      end
     end
 
     context 'with invalid params' do
@@ -136,8 +162,8 @@ RSpec.describe FinApps::REST::Operators, 'initialized with valid FinApps::Client
       it { expect { update }.not_to raise_error }
       it('returns an array') { expect(update).to be_a(Array) }
       it('performs a put and returns the response') do
-        expect(results).to respond_to(:email)
-        expect(results).to respond_to(:role)
+        expect(results).to have_key(:email)
+        expect(results).to have_key(:role)
       end
       it('returns no error messages') { expect(error_messages).to be_empty }
     end
@@ -150,24 +176,34 @@ RSpec.describe FinApps::REST::Operators, 'initialized with valid FinApps::Client
     context 'when missing params' do
       let(:update_password) { subject.update_password(nil) }
 
-      it { expect { update_password }.to raise_error(FinAppsCore::MissingArgumentsError) }
+      it do
+        expect { update_password }.to raise_error(
+          FinAppsCore::MissingArgumentsError
+        )
+      end
     end
 
     context 'with invalid params' do
       let(:update_password) { subject.update_password(password: 'invalid') }
 
-      it { expect { update_password }.to raise_error(FinAppsCore::InvalidArgumentsError) }
+      it do
+        expect { update_password }.to raise_error(
+          FinAppsCore::InvalidArgumentsError
+        )
+      end
     end
 
     context 'with valid params' do
-      let(:valid_params) { { password: 'valid password', password_confirm: 'valid_password' } }
+      let(:valid_params) do
+        { password: 'valid password', password_confirm: 'valid_password' }
+      end
       let(:update_password) { subject.update_password(valid_params) }
 
       it { expect { update_password }.not_to raise_error }
       it('returns an array') { expect(update_password).to be_a(Array) }
       it('performs a post and returns the response') do
-        expect(results).to respond_to(:public_id)
-        expect(results).to respond_to(:role)
+        expect(results).to have_key(:public_id)
+        expect(results).to have_key(:role)
       end
       it('returns no error messages') { expect(error_messages).to be_empty }
     end
@@ -180,7 +216,9 @@ RSpec.describe FinApps::REST::Operators, 'initialized with valid FinApps::Client
     context 'when missing id' do
       let(:destroy) { subject.destroy(nil) }
 
-      it { expect { destroy }.to raise_error(FinAppsCore::MissingArgumentsError) }
+      it do
+        expect { destroy }.to raise_error(FinAppsCore::MissingArgumentsError)
+      end
     end
 
     context 'for invalid id' do

data/spec/rest/order_assignments_spec.rb

@@ -12,21 +12,27 @@ RSpec.describe FinApps::REST::OrderAssignments do
 
     context 'when missing id' do
       let(:update) { subject.update(nil, []) }
-      it('returns missing argument error') { expect { update }.to raise_error(FinAppsCore::MissingArgumentsError) }
+      it('returns missing argument error') do
+        expect { update }.to raise_error(FinAppsCore::MissingArgumentsError)
+      end
     end
 
     context 'when missing params' do
       let(:update) { subject.update(:valid_id, nil) }
-      it('returns missing argument error') { expect { update }.to raise_error(FinAppsCore::MissingArgumentsError) }
+      it('returns missing argument error') do
+        expect { update }.to raise_error(FinAppsCore::MissingArgumentsError)
+      end
     end
 
     context 'with invalid params' do
       let(:update) { subject.update(:valid_id, params: 'params') }
-      it('returns invalid argument error') { expect { update }.to raise_error(FinAppsCore::InvalidArgumentsError) }
+      it('returns invalid argument error') do
+        expect { update }.to raise_error(FinAppsCore::InvalidArgumentsError)
+      end
     end
 
     context 'with invalid operator' do
-      let(:update) { subject.update(:invalid_id, ['invalid']) }
+      let(:update) { subject.update(:invalid_id, %w[invalid]) }
 
       it { expect { update }.not_to raise_error }
       it('results is nil') { expect(results).to be_nil }
@@ -36,7 +42,7 @@ RSpec.describe FinApps::REST::OrderAssignments do
     end
 
     context 'with valid params' do
-      let(:update) { subject.update(:valid_id, ['valid']) }
+      let(:update) { subject.update(:valid_id, %w[valid]) }
 
       it { expect { update }.not_to raise_error }
       it('results is nil') { expect(results).to be_nil }

data/spec/rest/order_notifications_spec.rb

@@ -10,7 +10,9 @@ RSpec.describe FinApps::REST::OrderNotifications do
 
     context 'when missing id' do
       let(:update) { subject.update(nil) }
-      it('returns missing argument error') { expect { update }.to raise_error(FinAppsCore::MissingArgumentsError) }
+      it('returns missing argument error') do
+        expect { update }.to raise_error(FinAppsCore::MissingArgumentsError)
+      end
     end
 
     context 'when invalid id is provided' do
@@ -20,7 +22,9 @@ RSpec.describe FinApps::REST::OrderNotifications do
 
       it { expect { update }.not_to raise_error }
       it('results is nil') { expect(results).to be_nil }
-      it('error messages array is populated') { expect(error_messages.first.downcase).to eq('resource not found') }
+      it('error messages array is populated') do
+        expect(error_messages.first.downcase).to eq('resource not found')
+      end
     end
 
     context 'for valid id' do

data/spec/rest/order_refreshes_spec.rb

@@ -9,7 +9,9 @@ RSpec.describe FinApps::REST::OrderRefreshes do
   describe '#create' do
     context 'when missing id' do
       let(:create) { subject.create(nil) }
-      it { expect { create }.to raise_error(FinAppsCore::MissingArgumentsError) }
+      it do
+        expect { create }.to raise_error(FinAppsCore::MissingArgumentsError)
+      end
     end
 
     context 'when valid id is provided' do
@@ -17,10 +19,12 @@ RSpec.describe FinApps::REST::OrderRefreshes do
       it { expect { create }.not_to raise_error }
       it('returns an array') { expect(create).to be_a(Array) }
       it('performs a post and returns new refreshed order response') do
-        expect(create[RESULTS]).to respond_to(:public_id)
-        expect(create[RESULTS]).to respond_to(:original_order_id)
+        expect(create[RESULTS]).to have_key(:public_id)
+        expect(create[RESULTS]).to have_key(:original_order_id)
+      end
+      it('returns no error messages') do
+        expect(create[ERROR_MESSAGES]).to be_empty
       end
-      it('returns no error messages') { expect(create[ERROR_MESSAGES]).to be_empty }
     end
 
     context 'when invalid id is provided' do
@@ -29,7 +33,9 @@ RSpec.describe FinApps::REST::OrderRefreshes do
       it('returns an array') { expect(create).to be_a(Array) }
       it('results is nil') { expect(create[RESULTS]).to be_nil }
       it('error messages array is populated') do
-        expect(create[ERROR_MESSAGES].first.downcase).to eq('resource not found')
+        expect(create[ERROR_MESSAGES].first.downcase).to eq(
+          'resource not found'
+        )
       end
     end
   end

data/spec/rest/order_reports_spec.rb

@@ -10,24 +10,32 @@ RSpec.describe FinApps::REST::OrderReports do
   describe '#show' do
     context 'when missing id' do
       subject { order_report.show(nil, :pdf) }
-      it { expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError) }
+      it do
+        expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError)
+      end
     end
 
     context 'when missing format' do
       subject { order_report.show(:valid_id, nil) }
-      it { expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError) }
+      it do
+        expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError)
+      end
     end
 
     context 'when invalid format is provided' do
       subject { order_report.show(:valid_id, :xml) }
-      it { expect { subject }.to raise_error(FinAppsCore::InvalidArgumentsError) }
+      it do
+        expect { subject }.to raise_error(FinAppsCore::InvalidArgumentsError)
+      end
     end
 
     context 'when valid params are provided' do
       subject { order_report.show(:valid_id, :json) }
 
       it { expect { subject }.not_to raise_error }
-      it('performs a get and returns the response') { expect(subject[0]).to respond_to(:days_requested) }
+      it('performs a get and returns the response') do
+        expect(subject[0]).to have_key(:days_requested)
+      end
       it('returns no error messages') { expect(subject[1]).to be_empty }
     end
 
@@ -36,7 +44,9 @@ RSpec.describe FinApps::REST::OrderReports do
 
       it { expect { subject }.not_to raise_error }
       it('results is nil') { expect(subject[0]).to be_nil }
-      it('error messages array is populated') { expect(subject[1].first.downcase).to eq('resource not found') }
+      it('error messages array is populated') do
+        expect(subject[1].first.downcase).to eq('resource not found')
+      end
     end
   end
 end

data/spec/rest/order_statuses_spec.rb

@@ -6,15 +6,21 @@ RSpec.describe FinApps::REST::OrderStatuses do
   describe '#show' do
     context 'when missing id' do
       subject { FinApps::REST::OrderStatuses.new(client).show(nil) }
-      it { expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError) }
+      it do
+        expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError)
+      end
     end
 
     context 'when valid id is provided' do
       subject { FinApps::REST::OrderStatuses.new(client).show(:valid_id) }
 
       it { expect { subject }.not_to raise_error }
-      it('performs a get and returns the response') { expect(subject[RESULTS]).to respond_to(:status) }
-      it('returns no error messages') { expect(subject[ERROR_MESSAGES]).to be_empty }
+      it('performs a get and returns the response') do
+        expect(subject[RESULTS]).to have_key(:status)
+      end
+      it('returns no error messages') do
+        expect(subject[ERROR_MESSAGES]).to be_empty
+      end
     end
 
     context 'when invalid id is provided' do
@@ -23,7 +29,9 @@ RSpec.describe FinApps::REST::OrderStatuses do
       it { expect { subject }.not_to raise_error }
       it('results is nil') { expect(subject[RESULTS]).to be_nil }
       it('error messages array is populated') do
-        expect(subject[ERROR_MESSAGES].first.downcase).to eq('resource not found')
+        expect(subject[ERROR_MESSAGES].first.downcase).to eq(
+          'resource not found'
+        )
       end
     end
   end

data/spec/rest/order_tokens_spec.rb

@@ -2,7 +2,8 @@
 
 require 'spec_helpers/client'
 
-RSpec.describe FinApps::REST::OrderTokens, 'initialized with valid FinApps::Client object' do
+RSpec.describe FinApps::REST::OrderTokens,
+               'initialized with valid FinApps::Client object' do
   include SpecHelpers::Client
 
   describe '#show' do
@@ -11,14 +12,23 @@ RSpec.describe FinApps::REST::OrderTokens, 'initialized with valid FinApps::Clie
     let(:error_messages) { show[ERROR_MESSAGES] }
 
     context 'when missing token' do
-      it { expect { subject.show(nil) }.to raise_error(FinAppsCore::MissingArgumentsError, ': token') }
+      it do
+        expect { subject.show(nil) }.to raise_error(
+          FinAppsCore::MissingArgumentsError,
+          ': token'
+        )
+      end
     end
 
     context 'for valid token' do
       let(:show) { subject.show(:valid_token) }
       it { expect { show }.not_to raise_error }
-      it('results is a Hashie::Rash') { expect(results).to be_a(Hashie::Mash::Rash) }
-      it('results contains a consumer_id') { expect(results).to respond_to(:consumer_id) }
+      it('results is a Hashie::Rash') do
+        expect(results).to be_a(Hash)
+      end
+      it('results contains a consumer_id') do
+        expect(results).to have_key(:consumer_id)
+      end
       it('error_messages array is empty') { expect(error_messages).to eq([]) }
     end
 
@@ -26,7 +36,9 @@ RSpec.describe FinApps::REST::OrderTokens, 'initialized with valid FinApps::Clie
       let(:show) { subject.show(:invalid_token) }
       it { expect { show }.not_to raise_error }
       it('results is nil') { expect(results).to be_nil }
-      it('error messages array is populated') { expect(error_messages.first.downcase).to eq('resource not found') }
+      it('error messages array is populated') do
+        expect(error_messages.first.downcase).to eq('resource not found')
+      end
     end
   end
 end