finapps 5.0.3 → 5.0.4

data/spec/rest/portfolios_available_consumers_spec.rb

@@ -24,7 +24,9 @@ RSpec.describe FinApps::REST::PortfoliosAvailableConsumers do
 
       it { expect { list }.not_to raise_error }
       it('returns an array') { expect(list).to be_a(Array) }
-      it('performs a get and returns the response') { expect(results).to respond_to(:records) }
+      it('performs a get and returns the response') do
+        expect(results).to have_key(:records)
+      end
       it('returns no error messages') { expect(errors).to be_empty }
     end
 
@@ -41,12 +43,15 @@ RSpec.describe FinApps::REST::PortfoliosAvailableConsumers do
 
       it { expect { list }.not_to raise_error }
       it('returns an array') { expect(list).to be_a(Array) }
-      it('performs a get and returns the response') { expect(results).to respond_to(:records) }
+      it('performs a get and returns the response') do
+        expect(results).to have_key(:records)
+      end
       it('returns no error messages') { expect(errors).to be_empty }
       it 'builds query and sends proper request' do
         list
-        url = "#{versioned_api_path}/portfolios/#{id}/consumers/available?page=2&" \
-        'requested=25&sort=-created_date'
+        url =
+          "#{versioned_api_path}/portfolios/#{id}/consumers/available?page=2&" \
+            'requested=25&sort=-created_date'
         expect(WebMock).to have_requested(:get, url)
       end
     end

data/spec/rest/portfolios_consumers_spec.rb

@@ -31,7 +31,9 @@ RSpec.describe FinApps::REST::PortfoliosConsumers do
 
       it { expect { list }.not_to raise_error }
       it('returns an array') { expect(list).to be_a(Array) }
-      it('performs a get and returns the response') { expect(results).to respond_to(:records) }
+      it('performs a get and returns the response') do
+        expect(results).to have_key(:records)
+      end
       it('returns no error messages') { expect(errors).to be_empty }
     end
 
@@ -41,12 +43,15 @@ RSpec.describe FinApps::REST::PortfoliosConsumers do
 
       it { expect { list }.not_to raise_error }
       it('returns an array') { expect(list).to be_a(Array) }
-      it('performs a get and returns the response') { expect(results).to respond_to(:records) }
+      it('performs a get and returns the response') do
+        expect(results).to have_key(:records)
+      end
       it('returns no error messages') { expect(errors).to be_empty }
       it 'builds query and sends proper request' do
         list
-        url = "#{versioned_api_path}/portfolios/#{portfolio_id}/consumers?page=2&" \
-        'requested=25&sort=-created_date'
+        url =
+          "#{versioned_api_path}/portfolios/#{portfolio_id}/consumers?page=2&" \
+            'requested=25&sort=-created_date'
         expect(WebMock).to have_requested(:get, url)
       end
     end
@@ -72,14 +77,18 @@ RSpec.describe FinApps::REST::PortfoliosConsumers do
       let(:portfolio_id) { nil }
       let(:params) { 'valid_id' }
 
-      it { expect { create }.to raise_error(FinAppsCore::MissingArgumentsError) }
+      it do
+        expect { create }.to raise_error(FinAppsCore::MissingArgumentsError)
+      end
     end
 
     context 'when missing params' do
       let(:portfolio_id) { 'valid_id' }
       let(:params) { nil }
 
-      it { expect { create }.to raise_error(FinAppsCore::MissingArgumentsError) }
+      it do
+        expect { create }.to raise_error(FinAppsCore::MissingArgumentsError)
+      end
     end
 
     context 'for bulk subscribe' do
@@ -106,7 +115,9 @@ RSpec.describe FinApps::REST::PortfoliosConsumers do
         it('results is nil') { expect(results).to be_nil }
         it('error messages array is populated') do
           # this will break when client is fixed to expect new array error response
-          expect(errors.first.downcase).to eq('the server responded with status 400')
+          expect(errors.first.downcase).to eq(
+            'the server responded with status 400'
+          )
         end
       end
     end
@@ -122,7 +133,8 @@ RSpec.describe FinApps::REST::PortfoliosConsumers do
         it('returns no error messages') { expect(errors).to be_empty }
         it('builds correct url') do
           create
-          url = "#{versioned_api_path}/portfolios/#{portfolio_id}/consumers/#{params}"
+          url =
+            "#{versioned_api_path}/portfolios/#{portfolio_id}/consumers/#{params}"
           expect(WebMock).to have_requested(:post, url)
         end
       end
@@ -134,7 +146,9 @@ RSpec.describe FinApps::REST::PortfoliosConsumers do
         it { expect { create }.not_to raise_error }
         it('results is nil') { expect(results).to be_nil }
         it('error messages array is populated') do
-          expect(errors.first.downcase).to eq('consumer not eligible, no completed orders.')
+          expect(errors.first.downcase).to eq(
+            'consumer not eligible, no completed orders.'
+          )
         end
       end
     end
@@ -149,14 +163,18 @@ RSpec.describe FinApps::REST::PortfoliosConsumers do
       let(:portfolio_id) { nil }
       let(:consumer_id) { 'valid_id' }
 
-      it { expect { destroy }.to raise_error(FinAppsCore::MissingArgumentsError) }
+      it do
+        expect { destroy }.to raise_error(FinAppsCore::MissingArgumentsError)
+      end
     end
 
     context 'when missing consumer_id' do
       let(:portfolio_id) { 'valid_id' }
       let(:consumer_id) { nil }
 
-      it { expect { destroy }.to raise_error(FinAppsCore::MissingArgumentsError) }
+      it do
+        expect { destroy }.to raise_error(FinAppsCore::MissingArgumentsError)
+      end
     end
 
     context 'when valid ids are provided' do

data/spec/rest/portfolios_spec.rb

@@ -16,7 +16,9 @@ RSpec.describe FinApps::REST::Portfolios do
 
       it { expect { list }.not_to raise_error }
       it('returns an array') { expect(list).to be_a(Array) }
-      it('performs a get and returns the response') { expect(results).to respond_to(:records) }
+      it('performs a get and returns the response') do
+        expect(results).to have_key(:records)
+      end
       it('returns no error messages') { expect(errors).to be_empty }
     end
 
@@ -31,11 +33,14 @@ RSpec.describe FinApps::REST::Portfolios do
 
       it { expect { list }.not_to raise_error }
       it('returns an array') { expect(list).to be_a(Array) }
-      it('performs a get and returns the response') { expect(results).to respond_to(:records) }
+      it('performs a get and returns the response') do
+        expect(results).to have_key(:records)
+      end
       it('returns no error messages') { expect(errors).to be_empty }
       it 'builds query and sends proper request' do
         list
-        url = "#{versioned_api_path}/portfolios?page=2&requested=25&sort=-created_date"
+        url =
+          "#{versioned_api_path}/portfolios?page=2&requested=25&sort=-created_date"
         expect(WebMock).to have_requested(:get, url)
       end
     end
@@ -55,11 +60,11 @@ RSpec.describe FinApps::REST::Portfolios do
     context 'when valid id is provided' do
       let(:id) { 'valid_id' }
 
-      it { expect { show }.not_to raise_error(FinAppsCore::MissingArgumentsError) }
+      it { expect { show }.not_to raise_error }
       it('returns an array') { expect(show).to be_a(Array) }
       it('performs a get and returns the response') do
-        expect(results).to respond_to(:_id)
-        expect(results).to respond_to(:product)
+        expect(results).to have_key(:_id)
+        expect(results).to have_key(:product)
       end
       it('returns no error messages') { expect(errors).to be_empty }
     end
@@ -83,25 +88,39 @@ RSpec.describe FinApps::REST::Portfolios do
     context 'when missing params' do
       let(:params) { nil }
 
-      it { expect { create }.to raise_error(FinAppsCore::MissingArgumentsError) }
+      it do
+        expect { create }.to raise_error(FinAppsCore::MissingArgumentsError)
+      end
     end
 
     context 'when valid params are provided' do
-      let(:params) { { name: 'Account Checks', description: 'Some Check Stuff', product: 'valid' } }
+      let(:params) do
+        {
+          name: 'Account Checks',
+          description: 'Some Check Stuff',
+          product: 'valid'
+        }
+      end
 
-      it { expect { create }.not_to raise_error(FinAppsCore::MissingArgumentsError) }
+      it { expect { create }.not_to raise_error }
       it('returns an array') { expect(create).to be_a(Array) }
       it('performs a get and returns the response') do
-        expect(results).to respond_to(:_id)
-        expect(results).to respond_to(:product)
+        expect(results).to have_key(:_id)
+        expect(results).to have_key(:product)
       end
       it('returns no error messages') { expect(errors).to be_empty }
     end
 
     context 'when invalid params are provided' do
-      let(:params) { { name: 'Account Checks', description: 'Some Check Stuff', product: 'invalid' } }
+      let(:params) do
+        {
+          name: 'Account Checks',
+          description: 'Some Check Stuff',
+          product: 'invalid'
+        }
+      end
 
-      it { expect { create }.not_to raise_error(FinAppsCore::MissingArgumentsError) }
+      it { expect { create }.not_to raise_error }
       it('results is nil') { expect(results).to be_nil }
       it('error messages array is populated') do
         expect(errors.first.downcase).to eq('invalid request body')
@@ -118,34 +137,40 @@ RSpec.describe FinApps::REST::Portfolios do
       let(:id) { nil }
       let(:params) { { fake: 'data' } }
 
-      it { expect { update }.to raise_error(FinAppsCore::MissingArgumentsError) }
+      it do
+        expect { update }.to raise_error(FinAppsCore::MissingArgumentsError)
+      end
     end
 
     context 'when missing params' do
       let(:id) { 'valid_id' }
       let(:params) { nil }
 
-      it { expect { update }.to raise_error(FinAppsCore::MissingArgumentsError) }
+      it do
+        expect { update }.to raise_error(FinAppsCore::MissingArgumentsError)
+      end
     end
 
     context 'when invalid id or params are provided' do
       let(:id) { 'invalid_id' }
       let(:params) { { fake: 'data' } }
 
-      it { expect { update }.not_to raise_error(FinAppsCore::MissingArgumentsError) }
+      it { expect { update }.not_to raise_error }
       it('results is nil') { expect(results).to be_nil }
-      it('error messages array is populated') { expect(errors.first.downcase).to eq('resource not found') }
+      it('error messages array is populated') do
+        expect(errors.first.downcase).to eq('resource not found')
+      end
     end
 
     context 'when valid id and params are provided' do
       let(:id) { 'valid_id' }
       let(:params) { { fake: 'data' } }
 
-      it { expect { update }.not_to raise_error(FinAppsCore::MissingArgumentsError) }
+      it { expect { update }.not_to raise_error }
       it('returns an array') { expect(update).to be_a(Array) }
       it('performs a get and returns the response') do
-        expect(results).to respond_to(:_id)
-        expect(results).to respond_to(:product)
+        expect(results).to have_key(:_id)
+        expect(results).to have_key(:product)
       end
       it('returns no error messages') { expect(errors).to be_empty }
     end
@@ -159,7 +184,9 @@ RSpec.describe FinApps::REST::Portfolios do
     context 'when missing id' do
       let(:id) { nil }
 
-      it { expect { destroy }.to raise_error(FinAppsCore::MissingArgumentsError) }
+      it do
+        expect { destroy }.to raise_error(FinAppsCore::MissingArgumentsError)
+      end
     end
 
     context 'when invalid id is provided' do
@@ -167,7 +194,9 @@ RSpec.describe FinApps::REST::Portfolios do
 
       it { expect { destroy }.not_to raise_error }
       it('results is nil') { expect(results).to be_nil }
-      it('error messages array is populated') { expect(errors.first.downcase).to eq('resource not found') }
+      it('error messages array is populated') do
+        expect(errors.first.downcase).to eq('resource not found')
+      end
     end
 
     context 'when valid id is provided' do

data/spec/rest/products_spec.rb

@@ -2,7 +2,8 @@
 
 require 'spec_helpers/client'
 
-RSpec.describe FinApps::REST::Products, 'initialized with valid FinApps::Client object' do
+RSpec.describe FinApps::REST::Products,
+               'initialized with valid FinApps::Client object' do
   include SpecHelpers::Client
   subject(:products) { FinApps::REST::Products.new(client) }
 
@@ -14,7 +15,9 @@ RSpec.describe FinApps::REST::Products, 'initialized with valid FinApps::Client
 
       it { expect { list }.not_to raise_error }
       it('returns an array of records') { expect(results).to be_a(Array) }
-      it('performs a get and returns the response') { expect(results[0]).to respond_to(:code) }
+      it('performs a get and returns the response') do
+        expect(results[0]).to have_key(:code)
+      end
       it('returns no error messages') { expect(error_messages).to be_empty }
     end
   end

data/spec/rest/sessions_spec.rb

@@ -2,7 +2,8 @@
 
 require 'spec_helpers/client'
 
-RSpec.describe FinApps::REST::Sessions, 'initialized with valid FinApps::Client object' do
+RSpec.describe FinApps::REST::Sessions,
+               'initialized with valid FinApps::Client object' do
   include SpecHelpers::Client
   subject { FinApps::REST::Sessions.new(client) }
 
@@ -14,39 +15,60 @@ RSpec.describe FinApps::REST::Sessions, 'initialized with valid FinApps::Client
     context 'when missing email or password' do
       message = 'Invalid argument: params.'
       it do
-        expect { subject.create(email: nil, password: 'password') }
-          .to raise_error(FinAppsCore::InvalidArgumentsError, message)
+        expect do
+          subject.create(email: nil, password: 'password')
+        end.to raise_error(FinAppsCore::InvalidArgumentsError, message)
       end
       it do
-        expect { subject.create(email: 'email', password: nil) }
-          .to raise_error(FinAppsCore::InvalidArgumentsError, message)
+        expect { subject.create(email: 'email', password: nil) }.to raise_error(
+          FinAppsCore::InvalidArgumentsError,
+          message
+        )
       end
     end
 
     context 'for invalid credentials' do
-      let(:credentials) { { email: 'email@domain.com', password: 'invalid_password' } }
+      let(:credentials) do
+        { email: 'email@domain.com', password: 'invalid_password' }
+      end
 
       it { expect { create }.not_to raise_error }
       it('results is nil') { expect(results).to be_nil }
       error_message = 'Invalid Consumer Identifier or Credentials'
-      it('error_messages are populated') { expect(error_messages.first).to eq(error_message) }
+      it('error_messages are populated') do
+        expect(error_messages.first).to eq(error_message)
+      end
     end
 
     context 'for valid credentials' do
-      let(:credentials) { { email: 'email@domain.com', password: 'valid_password' } }
+      let(:credentials) do
+        { email: 'email@domain.com', password: 'valid_password' }
+      end
 
-      it('results is a Hashie::Rash') { expect(results).to be_a(Hashie::Mash::Rash) }
-      it('token value is in the result') { expect(results).to respond_to(:token) }
+      it('results is a Hashie::Rash') do
+        expect(results).to be_a(Hash)
+      end
+      it('token value is in the result') do
+        expect(results).to have_key(:token)
+      end
       it('error_messages is empty') { expect(error_messages).to be_empty }
     end
 
     context 'for valid credentials & path argument' do
       let(:create) { subject.create(credentials, 'operators/login') }
-      let(:credentials) { { email: 'email@domain.com', password: 'valid_password' } }
+      let(:credentials) do
+        { email: 'email@domain.com', password: 'valid_password' }
+      end
 
-      it('results is a Hashie::Rash') { expect(results).to be_a(Hashie::Mash::Rash) }
-      it('token value is in the result') { expect(results).to respond_to(:token) }
-      it('returns operator for operator path') { expect(results).to respond_to(:role) }
+      it('results is a Hashie::Rash') do
+        expect(results).to be_a(Hash)
+      end
+      it('token value is in the result') do
+        expect(results).to have_key(:token)
+      end
+      it('returns operator for operator path') do
+        expect(results).to have_key(:role)
+      end
       it('error_messages is empty') { expect(error_messages).to be_empty }
     end
   end

data/spec/rest/statements_spec.rb

@@ -21,8 +21,12 @@ RSpec.describe FinApps::REST::Statements do
       let(:show) { subject.show('valid_id', 'valid_id') }
       it { expect { show }.not_to raise_error }
       it('returns an array') { expect(show).to be_a(Array) }
-      it('performs a get and returns the response') { expect(show[RESULTS]).to respond_to(:data) }
-      it('returns no error messages') { expect(show[ERROR_MESSAGES]).to be_empty }
+      it('performs a get and returns the response') do
+        expect(show[RESULTS]).to have_key(:data)
+      end
+      it('returns no error messages') do
+        expect(show[ERROR_MESSAGES]).to be_empty
+      end
     end
 
     context 'when invalid ids are provided' do

data/spec/rest/tenant_app_settings_spec.rb

@@ -11,7 +11,7 @@ RSpec.describe FinApps::REST::TenantAppSettings do
 
     it { expect { show }.not_to raise_error }
     it('performs a get and returns the response') do
-      expect(show[RESULTS]).to respond_to(:pdf_statement_months)
+      expect(show[RESULTS]).to have_key(:pdf_statement_months)
     end
     it('returns no error messages') { expect(show[ERROR_MESSAGES]).to be_empty }
   end
@@ -21,15 +21,21 @@ RSpec.describe FinApps::REST::TenantAppSettings do
 
     context 'when missing params' do
       let(:params) { nil }
-      it { expect { update }.to raise_error(FinAppsCore::MissingArgumentsError) }
+      it do
+        expect { update }.to raise_error(FinAppsCore::MissingArgumentsError)
+      end
     end
 
     context 'when valid params are provided' do
       let(:params) { { pdf_statement_months: 2 } }
 
       it { expect { update }.not_to raise_error }
-      it('performs put and returns no content') { expect(update[RESULTS]).to be_nil }
-      it('error_messages array is empty') { expect(update[ERROR_MESSAGES]).to be_empty }
+      it('performs put and returns no content') do
+        expect(update[RESULTS]).to be_nil
+      end
+      it('error_messages array is empty') do
+        expect(update[ERROR_MESSAGES]).to be_empty
+      end
     end
 
     context 'when invalid params are provided' do
@@ -37,7 +43,9 @@ RSpec.describe FinApps::REST::TenantAppSettings do
 
       it { expect { update }.not_to raise_error }
       it('results is nil') { expect(update[RESULTS]).to be_nil }
-      it('error_messages array is populated') { expect(update[ERROR_MESSAGES]).not_to be_empty }
+      it('error_messages array is populated') do
+        expect(update[ERROR_MESSAGES]).not_to be_empty
+      end
     end
   end
 end