finapps 5.0.3 → 5.0.4

data/spec/rest/orders_spec.rb

@@ -8,7 +8,9 @@ RSpec.describe FinApps::REST::Orders do
   describe '#show' do
     context 'when missing params' do
       subject { FinApps::REST::Orders.new(client).show(nil) }
-      it { expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError) }
+      it do
+        expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError)
+      end
     end
 
     context 'when valid params are provided' do
@@ -17,30 +19,38 @@ RSpec.describe FinApps::REST::Orders do
       it { expect { subject }.not_to raise_error }
       it('returns an array') { expect(subject).to be_a(Array) }
       it('performs a get and returns the response') do
-        expect(subject[RESULTS]).to respond_to(:public_id)
-        expect(subject[RESULTS]).to respond_to(:consumer_id)
+        expect(subject[RESULTS]).to have_key(:public_id)
+        expect(subject[RESULTS]).to have_key(:consumer_id)
+      end
+      it('returns no error messages') do
+        expect(subject[ERROR_MESSAGES]).to be_empty
       end
-      it('returns no error messages') { expect(subject[ERROR_MESSAGES]).to be_empty }
     end
   end
 
   describe '#create' do
     context 'when missing params' do
       subject { FinApps::REST::Orders.new(client).create(nil) }
-      it { expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError) }
+      it do
+        expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError)
+      end
     end
 
     context 'when valid params are provided' do
       subject { FinApps::REST::Orders.new(client).create(valid_params) }
-      let(:valid_params) { { applicant: 'valid', institutions: 'valid', product: 'valid' } }
+      let(:valid_params) do
+        { applicant: 'valid', institutions: 'valid', product: 'valid' }
+      end
 
       it { expect { subject }.not_to raise_error }
       it('returns an array') { expect(subject).to be_a(Array) }
       it('performs a post and returns the response') do
-        expect(subject[RESULTS]).to respond_to(:public_id)
-        expect(subject[RESULTS]).to respond_to(:consumer_id)
+        expect(subject[RESULTS]).to have_key(:public_id)
+        expect(subject[RESULTS]).to have_key(:consumer_id)
+      end
+      it('returns no error messages') do
+        expect(subject[ERROR_MESSAGES]).to be_empty
       end
-      it('returns no error messages') { expect(subject[ERROR_MESSAGES]).to be_empty }
     end
 
     context 'when invalid params are provided' do
@@ -50,7 +60,9 @@ RSpec.describe FinApps::REST::Orders do
       it { expect { subject }.not_to raise_error }
       it('results is nil') { expect(subject[RESULTS]).to be_nil }
       it('error messages array is populated') do
-        expect(subject[ERROR_MESSAGES].first.downcase).to eq('invalid request body')
+        expect(subject[ERROR_MESSAGES].first.downcase).to eq(
+          'invalid request body'
+        )
       end
     end
   end
@@ -63,51 +75,73 @@ RSpec.describe FinApps::REST::Orders do
       it { expect { subject }.not_to raise_error }
 
       it('returns an array') { expect(subject).to be_a(Array) }
-      it('performs a get and returns the response') { expect(subject[RESULTS]).to respond_to(:orders) }
-      it('returns no error messages') { expect(subject[ERROR_MESSAGES]).to be_empty }
+      it('performs a get and returns the response') do
+        expect(subject[RESULTS]).to have_key(:orders)
+      end
+      it('returns no error messages') do
+        expect(subject[ERROR_MESSAGES]).to be_empty
+      end
     end
 
     context 'when invalid params are provided' do
       subject { FinApps::REST::Orders.new(client).list(invalid_params) }
       let(:invalid_params) { %w[this is an array] }
 
-      it { expect { subject }.to raise_error(FinAppsCore::InvalidArgumentsError) }
+      it do
+        expect { subject }.to raise_error(FinAppsCore::InvalidArgumentsError)
+      end
     end
 
     context 'when including valid params' do
       subject { FinApps::REST::Orders.new(client).list(params) }
       let(:params) do
-        { page: 2, sort: 'status', requested: 25, searchTerm: 'term', status: %w[1 7],
-          assignment: 'valid_operator', relation: ['valid_order_id'] }
+        {
+          page: 2,
+          sort: 'status',
+          requested: 25,
+          searchTerm: 'term',
+          status: %w[1 7],
+          assignment: 'valid_operator',
+          relation: %w[valid_order_id]
+        }
       end
 
       it { expect { subject }.not_to raise_error }
       it('returns an array') { expect(subject).to be_a(Array) }
-      it('performs a get and returns the response') { expect(subject[RESULTS]).to respond_to(:orders) }
-      it('each order contains a consumer_id') { expect(subject[RESULTS].orders).to all(have_key('consumer_id')) }
-      it('returns no error messages') { expect(subject[ERROR_MESSAGES]).to be_empty }
+      it('performs a get and returns the response') do
+        expect(subject[RESULTS]).to have_key(:orders)
+      end
+      it('each order contains a consumer_id') do
+        expect(subject[RESULTS][:orders]).to all(have_key(:consumer_id))
+      end
+      it('returns no error messages') do
+        expect(subject[ERROR_MESSAGES]).to be_empty
+      end
       it 'builds query and sends proper request' do
         subject
-        url = "#{versioned_api_path}/orders?filter=%7B%22$or%22:%5B%7B%22public_id%22:"  \
-              '%7B%22$regex%22:%22%5Eterm%22,%22$options%22:%22i%22%7D%7D,%7B%22applicant.last_name%22:%22term%22%7D' \
-              ',%7B%22assignment.last_name%22:%22term%22%7D,%7B%22requestor.reference_no%22:%7B%22$regex%22:%22%5E' \
-              'term%22,%22$options%22:%22i%22%7D%7D%5D,%22status%22:%7B%22$in%22:%5B1,7%5D%7D,%22assignment.' \
-              'operator_id%22:%22valid_operator%22%7D&page=2&requested=25&sort=status'
+        url =
+          "#{versioned_api_path}/orders?filter=%7B%22$or%22:%5B%7B%22public_id%22:" \
+            '%7B%22$regex%22:%22%5Eterm%22,%22$options%22:%22i%22%7D%7D,%7B%22applicant.last_name%22:%22term%22%7D' \
+            ',%7B%22assignment.last_name%22:%22term%22%7D,%7B%22requestor.reference_no%22:%7B%22$regex%22:%22%5E' \
+            'term%22,%22$options%22:%22i%22%7D%7D%5D,%22status%22:%7B%22$in%22:%5B1,7%5D%7D,%22assignment.' \
+            'operator_id%22:%22valid_operator%22%7D&page=2&requested=25&sort=status'
         expect(WebMock).to have_requested(:get, url)
       end
       it 'builds query and sends proper request with searchTerm/relation exclusivity' do
         params[:searchTerm] = nil
         subject
-        url = "#{versioned_api_path}/orders?filter=%7B%22status%22:%7B%22$in%22:%5B1," \
-              '7%5D%7D,%22assignment.operator_id%22:%22valid_operator%22,%22$or%22:%5B%7B%22public_id%22:%7B%22$in' \
-              '%22:%5B%22valid_order_id%22%5D%7D%7D,%7B%22original_order_id%22:%7B%22$in%22:%5B%22valid_order_id%22' \
-              '%5D%7D%7D%5D%7D&page=2&requested=25&sort=status'
+        url =
+          "#{versioned_api_path}/orders?filter=%7B%22status%22:%7B%22$in%22:%5B1," \
+            '7%5D%7D,%22assignment.operator_id%22:%22valid_operator%22,%22$or%22:%5B%7B%22public_id%22:%7B%22$in' \
+            '%22:%5B%22valid_order_id%22%5D%7D%7D,%7B%22original_order_id%22:%7B%22$in%22:%5B%22valid_order_id%22' \
+            '%5D%7D%7D%5D%7D&page=2&requested=25&sort=status'
         expect(WebMock).to have_requested(:get, url)
       end
       it 'builds null assignment query properly when supplied w/ empty string' do
         FinApps::REST::Orders.new(client).list(assignment: '')
 
-        url = "#{versioned_api_path}/orders?filter=%7B%22assignment.operator_id%22:null%7D"
+        url =
+          "#{versioned_api_path}/orders?filter=%7B%22assignment.operator_id%22:null%7D"
         expect(WebMock).to have_requested(:get, url)
       end
     end
@@ -118,12 +152,16 @@ RSpec.describe FinApps::REST::Orders do
 
     context 'when missing id' do
       let(:update) { subject.update(nil, :params) }
-      it('returns missing argument error') { expect { update }.to raise_error(FinAppsCore::MissingArgumentsError) }
+      it('returns missing argument error') do
+        expect { update }.to raise_error(FinAppsCore::MissingArgumentsError)
+      end
     end
 
     context 'when missing params' do
       let(:update) { subject.update(:id, nil) }
-      it('returns missing argument error') { expect { update }.to raise_error(FinAppsCore::MissingArgumentsError) }
+      it('returns missing argument error') do
+        expect { update }.to raise_error(FinAppsCore::MissingArgumentsError)
+      end
     end
 
     context 'when valid id and params are provided' do
@@ -143,7 +181,9 @@ RSpec.describe FinApps::REST::Orders do
 
       it { expect { update }.not_to raise_error }
       it('results is nil') { expect(results).to be_nil }
-      it('error messages array is populated') { expect(error_messages.first.downcase).to eq('resource not found') }
+      it('error messages array is populated') do
+        expect(error_messages.first.downcase).to eq('resource not found')
+      end
     end
 
     context 'when invalid params are provided' do
@@ -153,7 +193,9 @@ RSpec.describe FinApps::REST::Orders do
 
       it { expect { update }.not_to raise_error }
       it('results is nil') { expect(results).to be_nil }
-      it('error messages array is populated') { expect(error_messages.first.downcase).to eq('invalid request body') }
+      it('error messages array is populated') do
+        expect(error_messages.first.downcase).to eq('invalid request body')
+      end
     end
   end
 
@@ -162,7 +204,9 @@ RSpec.describe FinApps::REST::Orders do
 
     context 'when missing id' do
       let(:destroy) { subject.destroy(nil) }
-      it('returns missing argument error') { expect { destroy }.to raise_error(FinAppsCore::MissingArgumentsError) }
+      it('returns missing argument error') do
+        expect { destroy }.to raise_error(FinAppsCore::MissingArgumentsError)
+      end
     end
 
     context 'when invalid id is provided' do
@@ -172,7 +216,9 @@ RSpec.describe FinApps::REST::Orders do
 
       it { expect { destroy }.not_to raise_error }
       it('results is nil') { expect(results).to be_nil }
-      it('error messages array is populated') { expect(error_messages.first.downcase).to eq('resource not found') }
+      it('error messages array is populated') do
+        expect(error_messages.first.downcase).to eq('resource not found')
+      end
     end
 
     context 'for valid id' do

data/spec/rest/password_resets_spec.rb

@@ -6,23 +6,33 @@ RSpec.describe FinApps::REST::PasswordResets do
   describe '#create' do
     context 'when missing id' do
       subject { FinApps::REST::PasswordResets.new(client).create(nil) }
-      it { expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError) }
+      it do
+        expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError)
+      end
     end
 
     context 'when invalid id is provided' do
-      subject { FinApps::REST::PasswordResets.new(client).create(:invalid_user_id) }
+      subject do
+        FinApps::REST::PasswordResets.new(client).create(:invalid_user_id)
+      end
 
       it { expect { subject }.not_to raise_error }
       it('results is nil') { expect(subject[0]).to be_nil }
-      it('error messages array is populated') { expect(subject[1]).not_to be_nil }
+      it('error messages array is populated') do
+        expect(subject[1]).not_to be_nil
+      end
     end
 
     context 'when valid id is provided' do
-      subject { FinApps::REST::PasswordResets.new(client).create(:valid_user_id) }
+      subject do
+        FinApps::REST::PasswordResets.new(client).create(:valid_user_id)
+      end
 
       it { expect { subject }.not_to raise_error }
       it('returns an array') { expect(subject).to be_a(Array) }
-      it('performs a post and returns the response') { expect(subject[0]).to respond_to(:token) }
+      it('performs a post and returns the response') do
+        expect(subject[0]).to have_key(:token)
+      end
       it('returns no error messages') { expect(subject[1]).to be_empty }
     end
   end
@@ -33,36 +43,63 @@ RSpec.describe FinApps::REST::PasswordResets do
 
     context 'when missing id' do
       subject { FinApps::REST::PasswordResets.new(client).update(nil, :params) }
-      it { expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError) }
+      it do
+        expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError)
+      end
     end
 
     context 'when missing params' do
-      subject { FinApps::REST::PasswordResets.new(client).update(:valid_user_id, nil) }
-      it { expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError) }
+      subject do
+        FinApps::REST::PasswordResets.new(client).update(:valid_user_id, nil)
+      end
+      it do
+        expect { subject }.to raise_error(FinAppsCore::MissingArgumentsError)
+      end
     end
 
     context 'when invalid id is provided' do
-      subject { FinApps::REST::PasswordResets.new(client).update(:invalid_user_id, valid_params) }
+      subject do
+        FinApps::REST::PasswordResets.new(client).update(
+          :invalid_user_id,
+          valid_params
+        )
+      end
 
       it { expect { subject }.not_to raise_error }
       it('results is nil') { expect(subject[0]).to be_nil }
-      it('error messages array is populated') { expect(subject[1]).not_to be_nil }
+      it('error messages array is populated') do
+        expect(subject[1]).not_to be_nil
+      end
     end
 
     context 'when invalid params are provided' do
-      subject { FinApps::REST::PasswordResets.new(client).update(:valid_user_id, invalid_params) }
+      subject do
+        FinApps::REST::PasswordResets.new(client).update(
+          :valid_user_id,
+          invalid_params
+        )
+      end
 
       it { expect { subject }.not_to raise_error }
       it('results is nil') { expect(subject[0]).to be_nil }
-      it('error messages array is populated') { expect(subject[1]).not_to be_nil }
+      it('error messages array is populated') do
+        expect(subject[1]).not_to be_nil
+      end
     end
 
     context 'when valid params are provided' do
-      subject { FinApps::REST::PasswordResets.new(client).update(:valid_user_id, valid_params) }
+      subject do
+        FinApps::REST::PasswordResets.new(client).update(
+          :valid_user_id,
+          valid_params
+        )
+      end
 
       it { expect { subject }.not_to raise_error }
       it('returns an array') { expect(subject).to be_a(Array) }
-      it('performs a post and returns the response') { expect(subject[0]).to respond_to(:token) }
+      it('performs a post and returns the response') do
+        expect(subject[0]).to have_key(:token)
+      end
       it('returns no error messages') { expect(subject[1]).to be_empty }
     end
   end

data/spec/rest/plaid/plaid_webhooks_spec.rb

@@ -18,9 +18,11 @@ RSpec.describe FinApps::REST::PlaidWebhooks do
       it_behaves_like 'an API request'
 
       it('performs a post and returns the webhook url') do
-        expect(create[RESULTS]).to respond_to(:url)
+        expect(create[RESULTS]).to have_key(:url)
+      end
+      it('returns no error messages') do
+        expect(create[ERROR_MESSAGES]).to be_empty
       end
-      it('returns no error messages') { expect(create[ERROR_MESSAGES]).to be_empty }
     end
 
     context 'when invalid tenant token is provided' do
@@ -29,7 +31,9 @@ RSpec.describe FinApps::REST::PlaidWebhooks do
       it_behaves_like 'an API request'
       it('results is nil') { expect(create[RESULTS]).to be_nil }
       it('error messages array is populated') do
-        expect(create[ERROR_MESSAGES].first.downcase).to eq('resource not found')
+        expect(create[ERROR_MESSAGES].first.downcase).to eq(
+          'resource not found'
+        )
       end
     end
   end

data/spec/rest/portfolio_reports_spec.rb

@@ -16,7 +16,9 @@ RSpec.describe FinApps::REST::PortfolioReports do
 
       it { expect { list }.not_to raise_error }
       it('returns an array') { expect(list).to be_a(Array) }
-      it('performs a get and returns the response') { expect(results).to respond_to(:records) }
+      it('performs a get and returns the response') do
+        expect(results).to have_key(:records)
+      end
       it('returns no error messages') { expect(errors).to be_empty }
     end
 
@@ -31,12 +33,15 @@ RSpec.describe FinApps::REST::PortfolioReports do
 
       it { expect { list }.not_to raise_error }
       it('returns an array') { expect(list).to be_a(Array) }
-      it('performs a get and returns the response') { expect(results).to respond_to(:records) }
+      it('performs a get and returns the response') do
+        expect(results).to have_key(:records)
+      end
       it('returns no error messages') { expect(errors).to be_empty }
       it 'builds query and sends proper request' do
         list
-        url = "#{versioned_api_path}/portfolio/reports?page=2&requested=25&" \
-        'sort=-created_date'
+        url =
+          "#{versioned_api_path}/portfolio/reports?page=2&requested=25&" \
+            'sort=-created_date'
         expect(WebMock).to have_requested(:get, url)
       end
     end

data/spec/rest/portfolios_alerts_spec.rb

@@ -24,8 +24,8 @@ RSpec.describe FinApps::REST::PortfoliosAlerts do
       it('returns an array') { expect(list).to be_a(Array) }
       it('performs a get and returns array of alert definitions') do
         expect(results).to be_a(Array)
-        expect(results.first).to respond_to(:_id)
-        expect(results.first).to respond_to(:rule_name)
+        expect(results.first).to have_key(:_id)
+        expect(results.first).to have_key(:rule_name)
       end
       it('returns no error messages') { expect(errors).to be_empty }
     end
@@ -50,21 +50,25 @@ RSpec.describe FinApps::REST::PortfoliosAlerts do
       let(:portfolio_id) { nil }
       let(:alert_id) { 'valid_id' }
 
-      it { expect { create }.to raise_error(FinAppsCore::MissingArgumentsError) }
+      it do
+        expect { create }.to raise_error(FinAppsCore::MissingArgumentsError)
+      end
     end
 
     context 'when missing alert_id' do
       let(:portfolio_id) { 'valid_id' }
       let(:alert_id) { nil }
 
-      it { expect { create }.to raise_error(FinAppsCore::MissingArgumentsError) }
+      it do
+        expect { create }.to raise_error(FinAppsCore::MissingArgumentsError)
+      end
     end
 
     context 'when valid ids are provided' do
       let(:portfolio_id) { 'valid_id' }
       let(:alert_id) { portfolio_id }
 
-      it { expect { create }.not_to raise_error(FinAppsCore::MissingArgumentsError) }
+      it { expect { create }.not_to raise_error }
       it('returns an array') { expect(create).to be_a(Array) }
       it('results is nil') { expect(results).to be_nil }
       it('returns no error messages') { expect(errors).to be_empty }
@@ -74,7 +78,7 @@ RSpec.describe FinApps::REST::PortfoliosAlerts do
       let(:portfolio_id) { 'invalid_id' }
       let(:alert_id) { portfolio_id }
 
-      it { expect { create }.not_to raise_error(FinAppsCore::MissingArgumentsError) }
+      it { expect { create }.not_to raise_error }
       it('results is nil') { expect(results).to be_nil }
       it('error messages array is populated') do
         expect(errors.first.downcase).to eq('resource not found')
@@ -91,21 +95,25 @@ RSpec.describe FinApps::REST::PortfoliosAlerts do
       let(:portfolio_id) { nil }
       let(:alert_id) { 'valid_id' }
 
-      it { expect { destroy }.to raise_error(FinAppsCore::MissingArgumentsError) }
+      it do
+        expect { destroy }.to raise_error(FinAppsCore::MissingArgumentsError)
+      end
     end
 
     context 'when missing alert_id' do
       let(:portfolio_id) { 'valid_id' }
       let(:alert_id) { nil }
 
-      it { expect { destroy }.to raise_error(FinAppsCore::MissingArgumentsError) }
+      it do
+        expect { destroy }.to raise_error(FinAppsCore::MissingArgumentsError)
+      end
     end
 
     context 'when valid ids are provided' do
       let(:portfolio_id) { 'valid_id' }
       let(:alert_id) { portfolio_id }
 
-      it { expect { destroy }.not_to raise_error(FinAppsCore::MissingArgumentsError) }
+      it { expect { destroy }.not_to raise_error }
       it('returns an array') { expect(destroy).to be_a(Array) }
       it('results is nil') { expect(results).to be_nil }
       it('returns no error messages') { expect(errors).to be_empty }
@@ -115,7 +123,7 @@ RSpec.describe FinApps::REST::PortfoliosAlerts do
       let(:portfolio_id) { 'invalid_id' }
       let(:alert_id) { portfolio_id }
 
-      it { expect { destroy }.not_to raise_error(FinAppsCore::MissingArgumentsError) }
+      it { expect { destroy }.not_to raise_error }
       it('results is nil') { expect(results).to be_nil }
       it('error messages array is populated') do
         expect(errors.first.downcase).to eq('resource not found')