finapps 5.0.3 → 5.0.4

data/spec/rest/client_spec.rb

@@ -3,7 +3,9 @@
 RSpec.describe FinApps::REST::Client do
   describe '#new' do
     it 'raises for missing company_token' do
-      expect { FinApps::REST::Client.new nil }.to raise_error(FinAppsCore::MissingArgumentsError)
+      expect { FinApps::REST::Client.new nil }.to raise_error(
+        FinAppsCore::MissingArgumentsError
+      )
     end
   end
 
@@ -21,141 +23,197 @@ RSpec.describe FinApps::REST::Client do
     end
 
     describe '#alert_definitions' do
-      it { expect(subject.alert_definitions).to be_an_instance_of(FinApps::REST::AlertDefinitions) }
+      it do
+        expect(subject.alert_definitions).to be_an_instance_of(
+          FinApps::REST::AlertDefinitions
+        )
+      end
     end
 
     describe '#alert_occurrences' do
-      it { expect(subject.alert_occurrences).to be_an_instance_of(FinApps::REST::AlertOccurrences) }
+      it do
+        expect(subject.alert_occurrences).to be_an_instance_of(
+          FinApps::REST::AlertOccurrences
+        )
+      end
     end
 
     describe '#version' do
-      it { expect(subject.version).to be_an_instance_of(FinApps::REST::Version) }
+      it do
+        expect(subject.version).to be_an_instance_of(FinApps::REST::Version)
+      end
     end
 
     describe '#consumers' do
-      it { expect(subject.consumers).to be_an_instance_of(FinApps::REST::Consumers) }
-    end
-
-    describe '#consumer_institution_refreshes' do
       it do
-        expect(subject.consumer_institution_refreshes).to be_an_instance_of FinApps::REST::ConsumerInstitutionRefreshes
+        expect(subject.consumers).to be_an_instance_of(FinApps::REST::Consumers)
       end
     end
 
-    describe '#consumer_institution_refresh' do
+    describe '#plaid_webhooks' do
       it do
-        expect(subject.consumer_institution_refresh).to be_an_instance_of FinApps::REST::ConsumerInstitutionRefresh
+        expect(
+          subject.plaid_webhooks
+        ).to be_an_instance_of FinApps::REST::PlaidWebhooks
       end
     end
 
     describe '#sessions' do
-      it { expect(subject.sessions).to be_an_instance_of(FinApps::REST::Sessions) }
+      it do
+        expect(subject.sessions).to be_an_instance_of(FinApps::REST::Sessions)
+      end
     end
 
     describe '#order_assignments' do
-      it { expect(subject.order_assignments).to be_an_instance_of(FinApps::REST::OrderAssignments) }
+      it do
+        expect(subject.order_assignments).to be_an_instance_of(
+          FinApps::REST::OrderAssignments
+        )
+      end
     end
 
     describe '#order_statuses' do
-      it { expect(subject.order_notifications).to be_an_instance_of(FinApps::REST::OrderNotifications) }
+      it do
+        expect(subject.order_notifications).to be_an_instance_of(
+          FinApps::REST::OrderNotifications
+        )
+      end
     end
 
     describe '#order_statuses' do
-      it { expect(subject.order_statuses).to be_an_instance_of(FinApps::REST::OrderStatuses) }
+      it do
+        expect(subject.order_statuses).to be_an_instance_of(
+          FinApps::REST::OrderStatuses
+        )
+      end
     end
 
     describe '#order_refreshes' do
-      it { expect(subject.order_refreshes).to be_an_instance_of(FinApps::REST::OrderRefreshes) }
+      it do
+        expect(subject.order_refreshes).to be_an_instance_of(
+          FinApps::REST::OrderRefreshes
+        )
+      end
     end
 
     describe '#order_reports' do
-      it { expect(subject.order_reports).to be_an_instance_of(FinApps::REST::OrderReports) }
+      it do
+        expect(subject.order_reports).to be_an_instance_of(
+          FinApps::REST::OrderReports
+        )
+      end
     end
 
     describe '#order_tokens' do
-      it { expect(subject.order_tokens).to be_an_instance_of(FinApps::REST::OrderTokens) }
+      it do
+        expect(subject.order_tokens).to be_an_instance_of(
+          FinApps::REST::OrderTokens
+        )
+      end
     end
 
     describe '#orders' do
       it { expect(subject.orders).to be_an_instance_of(FinApps::REST::Orders) }
     end
 
-    describe '#institutions' do
-      it { expect(subject.institutions).to be_an_instance_of(FinApps::REST::Institutions) }
-    end
-
-    describe '#institutions_forms' do
-      it { expect(subject.institutions_forms).to be_an_instance_of(FinApps::REST::InstitutionsForms) }
-    end
-
-    describe '#user_institutions_statuses' do
-      it { expect(subject.user_institutions_statuses).to be_an_instance_of(FinApps::REST::UserInstitutionsStatuses) }
-    end
-
-    describe '#user_institutions' do
-      it { expect(subject.user_institutions).to be_an_instance_of(FinApps::REST::UserInstitutions) }
-    end
-
-    describe '#user_institutions_forms' do
-      it { expect(subject.user_institutions_forms).to be_an_instance_of(FinApps::REST::UserInstitutionsForms) }
-    end
-
     describe '#password_resets' do
-      it { expect(subject.password_resets).to be_an_instance_of(FinApps::REST::PasswordResets) }
+      it do
+        expect(subject.password_resets).to be_an_instance_of(
+          FinApps::REST::PasswordResets
+        )
+      end
     end
 
     describe '#operators_password_resets' do
-      it { expect(subject.operators_password_resets).to be_an_instance_of(FinApps::REST::OperatorsPasswordResets) }
+      it do
+        expect(subject.operators_password_resets).to be_an_instance_of(
+          FinApps::REST::OperatorsPasswordResets
+        )
+      end
     end
 
     describe '#operators' do
-      it { expect(subject.operators).to be_an_instance_of(FinApps::REST::Operators) }
+      it do
+        expect(subject.operators).to be_an_instance_of(FinApps::REST::Operators)
+      end
     end
 
     describe '#products' do
-      it { expect(subject.products).to be_an_instance_of(FinApps::REST::Products) }
+      it do
+        expect(subject.products).to be_an_instance_of(FinApps::REST::Products)
+      end
     end
 
     describe '#portfolios' do
-      it { expect(subject.portfolios).to be_an_instance_of(FinApps::REST::Portfolios) }
+      it do
+        expect(subject.portfolios).to be_an_instance_of(
+          FinApps::REST::Portfolios
+        )
+      end
     end
 
     describe '#portfolios_alerts' do
-      it { expect(subject.portfolios_alerts).to be_an_instance_of(FinApps::REST::PortfoliosAlerts) }
+      it do
+        expect(subject.portfolios_alerts).to be_an_instance_of(
+          FinApps::REST::PortfoliosAlerts
+        )
+      end
     end
 
     describe '#portfolios_available_consumers' do
-      it {
-        expect(subject.portfolios_available_consumers).to be_an_instance_of(FinApps::REST::PortfoliosAvailableConsumers)
-      }
+      it do
+        expect(subject.portfolios_available_consumers).to be_an_instance_of(
+          FinApps::REST::PortfoliosAvailableConsumers
+        )
+      end
     end
 
     describe '#portfolios_consumers' do
-      it { expect(subject.portfolios_consumers).to be_an_instance_of(FinApps::REST::PortfoliosConsumers) }
+      it do
+        expect(subject.portfolios_consumers).to be_an_instance_of(
+          FinApps::REST::PortfoliosConsumers
+        )
+      end
     end
 
     describe '#consumers_portfolios' do
-      it { expect(subject.consumers_portfolios).to be_an_instance_of(FinApps::REST::ConsumersPortfolios) }
+      it do
+        expect(subject.consumers_portfolios).to be_an_instance_of(
+          FinApps::REST::ConsumersPortfolios
+        )
+      end
     end
 
     describe '#portfolio_reports' do
-      it { expect(subject.portfolio_reports).to be_an_instance_of(FinApps::REST::PortfolioReports) }
-    end
-
-    describe '#statements' do
-      it { expect(subject.statements).to be_an_instance_of(FinApps::REST::Statements) }
+      it do
+        expect(subject.portfolio_reports).to be_an_instance_of(
+          FinApps::REST::PortfolioReports
+        )
+      end
     end
 
     describe '#tenant_settings' do
-      it { expect(subject.tenant_settings).to be_an_instance_of(FinApps::REST::TenantSettings) }
+      it do
+        expect(subject.tenant_settings).to be_an_instance_of(
+          FinApps::REST::TenantSettings
+        )
+      end
     end
 
     describe '#tenant_app_settings' do
-      it { expect(subject.tenant_app_settings).to be_an_instance_of(FinApps::REST::TenantAppSettings) }
+      it do
+        expect(subject.tenant_app_settings).to be_an_instance_of(
+          FinApps::REST::TenantAppSettings
+        )
+      end
     end
 
     describe '#plaid_webhooks' do
-      it { expect(subject.plaid_webhooks).to be_an_instance_of(FinApps::REST::PlaidWebhooks) }
+      it do
+        expect(subject.plaid_webhooks).to be_an_instance_of(
+          FinApps::REST::PlaidWebhooks
+        )
+      end
     end
   end
 end

data/spec/rest/consumers_portfolios_spec.rb

@@ -24,7 +24,9 @@ RSpec.describe FinApps::REST::ConsumersPortfolios do
 
       it { expect { list }.not_to raise_error }
       it('returns an array') { expect(list).to be_a(Array) }
-      it('performs a get and returns the response') { expect(results).to respond_to(:records) }
+      it('performs a get and returns the response') do
+        expect(results).to have_key(:records)
+      end
       it('returns no error messages') { expect(errors).to be_empty }
     end
 
@@ -41,12 +43,15 @@ RSpec.describe FinApps::REST::ConsumersPortfolios do
 
       it { expect { list }.not_to raise_error }
       it('returns an array') { expect(list).to be_a(Array) }
-      it('performs a get and returns the response') { expect(results).to respond_to(:records) }
+      it('performs a get and returns the response') do
+        expect(results).to have_key(:records)
+      end
       it('returns no error messages') { expect(errors).to be_empty }
       it 'builds query and sends proper request' do
         list
-        url = "#{versioned_api_path}/consumers/#{id}/portfolios?page=2&" \
-        'requested=25&sort=-created_date'
+        url =
+          "#{versioned_api_path}/consumers/#{id}/portfolios?page=2&" \
+            'requested=25&sort=-created_date'
         expect(WebMock).to have_requested(:get, url)
       end
     end

data/spec/rest/consumers_spec.rb

@@ -1,7 +1,8 @@
 # frozen_string_literal: true
 
 require 'spec_helpers/client'
-RSpec.describe FinApps::REST::Consumers, 'initialized with valid FinApps::Client object' do
+RSpec.describe FinApps::REST::Consumers,
+               'initialized with valid FinApps::Client object' do
   include SpecHelpers::Client
   subject(:users) { FinApps::REST::Consumers.new(client) }
   missing_public_id = ': public_id'
@@ -11,15 +12,23 @@ RSpec.describe FinApps::REST::Consumers, 'initialized with valid FinApps::Client
     let(:error_messages) { create[1] }
 
     context 'when missing params' do
-      it { expect { subject.create(nil) }.to raise_error(FinAppsCore::MissingArgumentsError) }
+      it do
+        expect { subject.create(nil) }.to raise_error(
+          FinAppsCore::MissingArgumentsError
+        )
+      end
     end
 
     context 'for valid params' do
       let(:create) { subject.create(email: 'email', password: 'password') }
 
       it { expect { create }.not_to raise_error }
-      it('results is a Hashie::Rash') { expect(results).to be_a(Hashie::Mash::Rash) }
-      it('performs a post and returns the response') { expect(results).to respond_to(:public_id) }
+      it('results is a Hash') do
+        expect(results).to be_a(Hash)
+      end
+      it('performs a post and returns the response') do
+        expect(results).to have_key(:public_id)
+      end
       it('error_messages array is empty') { expect(error_messages).to eq([]) }
     end
 
@@ -28,13 +37,20 @@ RSpec.describe FinApps::REST::Consumers, 'initialized with valid FinApps::Client
 
       it { expect { create }.not_to raise_error }
       it('results is nil') { expect(results).to be_nil }
-      it('error messages array is populated') { expect(error_messages.first.downcase).to eq('invalid request body') }
+      it('error messages array is populated') do
+        expect(error_messages.first.downcase).to eq('invalid request body')
+      end
     end
   end
 
   describe '#show' do
     context 'when missing public_id' do
-      it { expect { subject.show(nil) }.to raise_error(FinAppsCore::MissingArgumentsError, missing_public_id) }
+      it do
+        expect { subject.show(nil) }.to raise_error(
+          FinAppsCore::MissingArgumentsError,
+          missing_public_id
+        )
+      end
     end
 
     context 'for valid public_id' do
@@ -43,8 +59,12 @@ RSpec.describe FinApps::REST::Consumers, 'initialized with valid FinApps::Client
       let(:error_messages) { show[1] }
 
       it { expect { show }.not_to raise_error }
-      it('results is a Hashie::Rash') { expect(results).to be_a(Hashie::Mash::Rash) }
-      it('performs a get and returns the response') { expect(results).to respond_to(:public_id) }
+      it('results is a Hash') do
+        expect(results).to be_a(Hash)
+      end
+      it('performs a get and returns the response') do
+        expect(results).to have_key(:public_id)
+      end
       it('error_messages array is empty') { expect(error_messages).to eq([]) }
     end
 
@@ -55,13 +75,20 @@ RSpec.describe FinApps::REST::Consumers, 'initialized with valid FinApps::Client
 
       it { expect { show }.not_to raise_error }
       it('results is nil') { expect(results).to be_nil }
-      it('error messages array is populated') { expect(error_messages.first.downcase).to eq('resource not found') }
+      it('error messages array is populated') do
+        expect(error_messages.first.downcase).to eq('resource not found')
+      end
     end
   end
 
   describe '#update' do
     context 'when missing public_id' do
-      it { expect { subject.update(nil, {}) }.to raise_error(FinAppsCore::MissingArgumentsError, missing_public_id) }
+      it do
+        expect { subject.update(nil, {}) }.to raise_error(
+          FinAppsCore::MissingArgumentsError,
+          missing_public_id
+        )
+      end
     end
 
     context 'when updating user details' do
@@ -76,45 +103,72 @@ RSpec.describe FinApps::REST::Consumers, 'initialized with valid FinApps::Client
       end
 
       context 'for invalid public_id' do
-        let(:update) { subject.update(:invalid_public_id, postal_code: '33021') }
+        let(:update) do
+          subject.update(:invalid_public_id, postal_code: '33021')
+        end
         let(:results) { update[0] }
         let(:error_messages) { update[1] }
 
         it { expect { update }.not_to raise_error }
         it('results is nil') { expect(results).to be_nil }
         it('error messages array is populated') do
-          expect(error_messages.first.downcase).to eq('invalid user id specified.')
+          expect(error_messages.first.downcase).to eq(
+            'invalid user id specified.'
+          )
         end
       end
     end
 
     context 'when updating password' do
       context 'for valid public_id' do
-        let(:update) { subject.update(:valid_public_id, password: 'Aa123456!', password_confirm: 'Aa123456!') }
+        let(:update) do
+          subject.update(
+            :valid_public_id,
+            password: 'Aa123456!', password_confirm: 'Aa123456!'
+          )
+        end
         let(:results) { update[0] }
         let(:error_messages) { update[1] }
 
         it { expect { update }.not_to raise_error }
-        it('results is a Hashie::Rash') { expect(results).to be_a(Hashie::Mash::Rash) }
-        it('the public_id is on the results') { expect(results).to respond_to(:public_id) }
-        it('the new token is on the results') { expect(results).to respond_to(:token) }
+        it('results is a Hash') do
+          expect(results).to be_a(Hash)
+        end
+        it('the public_id is on the results') do
+          expect(results).to have_key(:public_id)
+        end
+        it('the new token is on the results') do
+          expect(results).to have_key(:token)
+        end
         it('error_messages array is empty') { expect(error_messages).to eq([]) }
       end
 
       context 'for invalid public_id' do
-        let(:update) { subject.update(:invalid_public_id, password: 'Aa123456!', password_confirm: 'Aa123456!') }
+        let(:update) do
+          subject.update(
+            :invalid_public_id,
+            password: 'Aa123456!', password_confirm: 'Aa123456!'
+          )
+        end
         let(:results) { update[0] }
         let(:error_messages) { update[1] }
 
         it { expect { update }.not_to raise_error }
         it('results is nil') { expect(results).to be_nil }
-        it('error messages array is populated') { expect(error_messages.first.downcase).to eq('resource not found') }
+        it('error messages array is populated') do
+          expect(error_messages.first.downcase).to eq('resource not found')
+        end
       end
     end
 
     describe '#destroy' do
       context 'when missing public_id' do
-        it { expect { subject.destroy(nil) }.to raise_error(FinAppsCore::MissingArgumentsError, missing_public_id) }
+        it do
+          expect { subject.destroy(nil) }.to raise_error(
+            FinAppsCore::MissingArgumentsError,
+            missing_public_id
+          )
+        end
       end
 
       context 'for valid public_id' do
@@ -134,7 +188,9 @@ RSpec.describe FinApps::REST::Consumers, 'initialized with valid FinApps::Client
 
         it { expect { destroy }.not_to raise_error }
         it('results is nil') { expect(results).to be_nil }
-        it('error messages array is populated') { expect(error_messages.first.downcase).to eq('resource not found') }
+        it('error messages array is populated') do
+          expect(error_messages.first.downcase).to eq('resource not found')
+        end
       end
     end
   end