fdlint 0.1.0

data/test/css/parser_test.rb

@@ -0,0 +1,276 @@
+# encoding: utf-8
+
+require_relative '../helper'
+
+require 'css/parser'
+
+
+module XRayTest
+  module CSS
+    class ParserTest < Test::Unit::TestCase 
+      ParseError = XRay::ParseError
+      include XRay::CSS
+
+      def test_parse_stylesheet_empty
+        css = "  \n "
+        sheet = parse_css css
+        assert_equal 0, sheet.statements.size
+      end
+
+      def test_parse_directive
+        css = '
+          @import "subs.css";
+          @import "print-main.css" print;
+          @-moz-border-radius print {
+            body { font-size: 10pt }
+          }
+          h1 { color: blue } 
+
+          @import url(http://style.china.alibaba.com/css/fdevlib2/grid/grid-min.css);
+        '
+        sheet = parse_css css
+        
+        at_rules = sheet.at_rules 
+        assert_equal 4, at_rules.size
+       
+        assert_equal 'import', at_rules[1].keyword.text
+        assert_equal '"print-main.css" print', at_rules[1].expression.text
+        assert_equal '-moz-border-radius', at_rules[2].keyword.text 
+        assert_equal 'url(http://style.china.alibaba.com/css/fdevlib2/grid/grid-min.css)', 
+            at_rules[3].expression.text 
+      end
+
+      def test_parse_ruleset
+        css = '
+          a { font-size: 12px }
+          { color: #fff } /* no selector */
+        '
+
+        sheet = parse_css css
+        rs = sheet.rulesets
+        assert_equal 2, rs.size
+
+        assert_equal 'a', rs[0].selector.text
+        assert_equal nil, rs[1].selector
+      end
+
+      def test_parse_selector
+        css = '
+          div, #header .mypart, .div ul li {
+              font-size: 12px;
+          }
+          ul, body a, .part ul:first {
+            background: #f00;
+          }
+
+          a[name="helloworld"], a {
+            color: #fff;
+          }
+        '
+
+        sheet = parse_css css
+        rs = sheet.rulesets
+        assert_equal 3, rs.length
+
+        assert_equal 'div, #header .mypart, .div ul li', rs[0].selector.text
+        assert_equal 3, rs[0].selector.simple_selectors.length
+
+        assert_equal 'ul, body a, .part ul:first', rs[1].selector.text
+        
+        assert_equal 'a[name="helloworld"]', rs[2].selector.simple_selectors[0].text
+      end
+
+      def test_parse_declarations
+        css = '
+          body {
+            ;;
+            color: #333;
+            ; 
+            font-size: 12px   
+          }
+
+          a:hover {
+            color: #ff7300    
+          }
+
+          #content {
+            font-size: 12px;
+            width: 952px;
+            background: #ffffff url(img/bg.png) no-repeat left top;
+          }
+        '
+
+        sheet = parse_css css
+        rs = sheet.rulesets
+        assert_equal 3, rs.size
+
+        decs = rs[0].declarations
+        assert_equal 2, decs.size
+        assert_equal 'color', decs[0].property.text
+        assert_equal '#333', decs[0].value.text
+        assert_equal 'font-size', decs[1].property.text
+        assert_equal '12px', decs[1].value.text
+
+        assert_equal 1, rs[1].declarations.size
+        
+        decs = rs[2].declarations
+        assert_equal 3, decs.size
+        assert_equal 'font-size', decs[0].property.text
+        assert_equal '12px', decs[0].value.text
+        assert_equal 'width', decs[1].property.text
+        assert_equal '952px', decs[1].value.text
+        assert_equal '#ffffff url(img/bg.png) no-repeat left top', decs[2].value.text
+      end
+
+      def test_parse_property
+        css = %q[
+          body {
+            color: #f00;
+            _color: #0ff;
+            *font-size: 12px;
+            background: '';
+            -moz-border-radius: ''
+          }
+        ]
+
+        sheet = parse_css css
+        decs = sheet.rulesets[0].declarations
+        assert_equal 'color', decs[0].property.text
+        assert_equal '_color', decs[1].property.text
+        assert_equal '*font-size', decs[2].property.text
+        assert_equal 'background', decs[3].property.text
+        assert_equal '-moz-border-radius', decs[4].property.text
+      end
+
+      def test_parse_value
+        css = %q[  
+          div ul>li:first {
+            content: '{123}hello"';
+            background: url("http://alibaba.com/{123}456");       
+            font-family: "Lucida Sans", Arial, "\6587\6CC9\9A7F\5FAE\7C73\9ED1";
+            font-size: ' ';
+            content: ''
+          }
+        ]
+
+        sheet = parse_css css
+        rs = sheet.rulesets[0]
+        decs = rs.declarations
+
+        assert_equal 'div ul>li:first', rs.selector.text
+        assert_equal %q/'{123}hello"'/, decs[0].value.text
+        assert_equal 'url("http://alibaba.com/{123}456")', decs[1].value.text
+        assert_equal '"Lucida Sans", Arial, "\6587\6CC9\9A7F\5FAE\7C73\9ED1"', 
+            decs[2].value.text
+        assert_equal "' '", decs[3].value.text
+        assert_equal "''", decs[4].value.text
+      end
+      
+      def test_parse_stylesheet_broken_01
+        css = 'body {'
+
+        assert_raise(ParseError) {
+          parse_css css
+        }
+
+        begin
+          parse_css css
+        rescue ParseError => e
+          pos = e.position
+          assert_equal 1, pos.row
+          assert_equal 7, pos.column
+        end
+      end
+
+      def test_parse_comment
+        css = '
+          /**
+           * this is comment
+           */
+          body {
+            font-size: 12px;
+            /**/
+            /**这个是中文注释*/ 
+          }
+          /*this is comment 2*/
+          
+          a { font-size: 14px; }
+        '
+
+        parser = create_parser css
+        parser.parse_stylesheet
+
+        comments = parser.comments
+        assert_equal 4, comments.size
+        assert_equal '/**这个是中文注释*/', comments[2].text
+      end
+
+      def test_parse_stylesheet_css3
+        css = <<END
+@charset: "utf-8";
+
+/** animation **/
+@-webkit-keyframes greenPulse {
+    from { background-color: #749a02; -webkit-box-shadow: 0 0 9px #333; }
+    50% { background-color: #91bd09; -webkit-box-shadow: 0 0 18px #91bd09; }
+    to { background-color: #749a02; -webkit-box-shadow: 0 0 9px #333; }
+}
+
+.green.button {
+    -webkit-animation-name: greenPulse;
+    -webkit-animation-duration: 2s;
+    -webkit-animation-iteration-count: infinite;
+}
+
+/** media query import **/
+@import url(color.css) screen and (color);
+
+/** media query **/
+@media all and (min-width:500px) {
+    .big {
+      font-size:120%;
+    }
+}
+
+@media screen and (color), projection and (color) {
+    .big {
+        font-size:120%;
+    }
+}
+END
+        sheet = parse_css css
+        assert_equal 6, sheet.statements.size
+        rule = sheet.at_rules[1]
+        
+        assert_equal '-webkit-keyframes', rule.keyword.text
+        rs = rule.block.rulesets
+        assert_equal 3, rs.size
+
+        assert_equal '50%', rs[1].selector.text
+        assert_equal '-webkit-box-shadow', rs[1].declarations[1].property.text
+        assert_equal '0 0 18px #91bd09', rs[1].declarations[1].value.text
+
+        rule = sheet.at_rules.last
+        assert_equal 'screen and (color), projection and (color)', rule.expression.text
+        
+        rs = rule.block.rulesets[0]
+        assert_equal '.big', rs.selector.text 
+        assert_equal 'font-size: 120%', rs.declarations[0].text
+      end
+
+      private
+
+      def create_parser(css)
+        Parser.new css, XRayTest::Logger.new
+      end
+
+      def parse_css(css, name = 'stylesheet')
+        parser = create_parser css
+        parser.send "parse_#{name}"
+      end
+
+
+
+    end
+  end
+end

data/test/css/rule/check_encoding_test.rb

@@ -0,0 +1,66 @@
+# encoding: utf-8
+
+require_relative '../../helper'
+
+require 'node'
+require 'css/struct'
+require 'css/rule/checklist'
+
+module XRayTest
+  module CSS
+    module Rule
+      
+      class CheckEncodingTest < Test::Unit::TestCase
+
+        def setup
+          @runner = XRay::Runner.new :encoding => 'gb2312'
+          @expect_err = XRay::LogEntry.new("File can't be read as gb2312 charset", :fatal) 
+        end
+
+        def test_check_utf8_file_well_written
+          check_file "#{FIXTURE_PATH}/css/utf8_good.css" do |results|
+            assert !has_encoding_error?(results), "如果没有指定css文件的编码，utf-8也是合法的"
+          end
+        end
+
+        def test_check_utf8_file_with_errors
+          check_file "#{FIXTURE_PATH}/css/utf8_using_star.css" do |results|
+            assert !has_encoding_error?(results), "如果没有指定css文件的编码，utf-8也是合法的"
+          end
+        end
+
+        def test_check_utf8_file_with_charset_declaraction
+          check_file "#{FIXTURE_PATH}/css/utf8_good_declaring_charset.css" do |results|
+            assert !has_encoding_error?(results), "带有@charset声明的文件应该可以被正确读取"
+          end
+        end
+
+        def test_check_gb2312_file_well_written
+          check_file "#{FIXTURE_PATH}/css/gb-good.css" do |results|
+            assert !has_encoding_error?(results), "GB2312的文件应该可以被正常读取"
+          end
+        end
+
+        def test_check_gb2312_file_with_errors
+          check_file "#{FIXTURE_PATH}/css/gb_using_star.css" do |results|
+            assert !has_encoding_error?(results), "GB2312的文件应该可以被正常读取"
+            assert results.any? { |r| r.message.include? '禁止使用星号选择符' }
+          end
+        end
+        
+        private
+        def check_file( file )
+          results = @runner.check_css_file file
+          yield results
+        end
+
+        def has_encoding_error?( results )
+          results.include? @expect_err
+        end
+
+
+      end
+
+    end
+  end
+end

data/test/css/rule/check_list_rule_test.rb

@@ -0,0 +1,167 @@
+# encoding: utf-8
+
+require_relative '../../helper'
+
+require 'node'
+require 'css/struct'
+require 'css/rule/checklist'
+
+module XRayTest
+  module CSS
+    module Rule
+      
+      class CheckListRuleTest < Test::Unit::TestCase
+
+        include XRay::CSS, XRay::CSS::Rule, XRay::Rule, XRay::Context
+
+        Node = XRay::Node
+        XRay::Rule.import_all
+
+        def setup
+          self.scope = :page
+        end
+
+        # selector
+
+        def test_check_selector_with_id
+
+          selector = Node.new '#mydiv a'
+          message, level = check_selector_with_id selector
+
+          assert_equal :error, level
+
+          selector = Node.new 'ul #mydiv dt'
+          ret = check_selector_with_id selector
+          assert_not_nil ret
+
+          selector = Node.new '.guide-part ul li'
+          ret = check_selector_with_id selector
+          assert_nil ret
+        end
+
+        def test_check_selector_with_global_tag 
+          selector = Node.new 'a'
+          message, level = check_selector_with_global_tag selector
+
+          assert_equal :error, level
+
+          selector = Node.new 'body'
+          message, level = check_selector_with_global_tag selector
+
+          assert_equal :error, level
+        end
+
+        def test_check_selector_level
+          selector = Node.new '.mypart .mysubpart ul li a'
+          message, level = check_selector_level selector
+
+          assert_equal :error, level
+          
+          selector = Node.new '.mypart ul li a'
+          ret = check_selector_level selector
+          assert_nil ret
+          
+          selector = Node.new 'html>div.mypart ul li a'
+          message, level = check_selector_level selector
+          assert_equal :error, level
+
+          selector = Node.new 'div.mypart ul li a'
+          ret = check_selector_level selector
+          assert_nil ret
+        end
+
+        def test_check_selector_with_star
+          selector = Node.new '* html'
+          message, level = check_selector_with_star selector
+
+          assert_equal :error, level
+        end
+
+        def test_check_declarations_sequence
+          
+        end
+
+        # declaration
+        
+        def test_check_good_declaration_font
+          sel = Node.new 'font'
+          expr = Node.new 'Arial'
+          dec = Declaration.new(sel, expr)
+
+          message, level = check_declaration_font dec
+          assert_equal nil, level
+        end
+
+        def test_check_declaration_font
+          sel = Node.new 'font'
+          expr = Node.new '宋体'
+          dec = Declaration.new(sel, expr)
+
+          message, level = check_declaration_font dec
+          assert_equal :error, level
+        end
+
+        def test_check_redefine_a_hover_color
+          selector = Node.new 'a:hover'
+          
+          prop = Node.new 'color'
+          expr = Node.new '#f00'
+          dec = Declaration.new(prop, expr)
+
+          ruleset = RuleSet.new(selector, [dec])
+
+          message, level = check_ruleset_redefine_a_hover_color ruleset
+          assert_equal :error, level
+        end
+
+        def test_check_redefine_lib_css
+          selector = Node.new '.fd-hide'
+          message, level = check_selector_redefine_lib_css selector
+          assert_equal :error, level
+
+          @scope = :lib
+          ret = check_selector_redefine_lib_css selector
+          assert_nil ret 
+        end
+        
+        def test_check_property_hack
+          props = %w(_background +font-size *color)
+          props.each do |prop|
+            prop = Node.new prop
+            message, level = check_property_hack prop
+            assert_equal :error, level
+          end
+        end
+
+        def test_check_property_slash_hack
+          prop = Node.new 'd\isplay'
+          message, level = check_property_hack prop
+          assert_equal :error, level
+        end
+
+        def test_check_selector_using_hack
+          selector = Node.new 'html*'
+          message, level = check_selector_using_hack selector
+          assert_equal :error, level
+        end
+
+        def test_check_value_use_css_expression
+          expr = Node.new 'expression(onfocus=this.blur())'
+          message, level = check_value_use_css_expression expr
+          assert_equal :error, level
+        end
+
+        def test_check_value_use_hack
+          exprs = %w(9px\0 #000\9)
+          exprs.each do |expr|
+            expr = Node.new expr
+            message, level = check_value_use_hack expr
+            assert_equal :error, level
+          end
+        end
+
+      end
+
+    end
+  end
+end

data/test/css/rule/compression_test.rb

@@ -0,0 +1,53 @@
+# encoding: utf-8
+require_relative '../../helper'
+
+require 'file_validator'
+require 'css/rule/check_compression_rule'
+
+module XRayTest
+  module CSS
+    module Rule
+      
+      class CompressionTest < Test::Unit::TestCase
+
+        def setup
+          @validator = XRay::FileValidator.new( :encoding => 'gb2312' )
+          @validator.add_validator XRay::CSS::Rule::CompressionChecker.new
+        end
+
+        def test_source_file_with_min
+          file = "#{FIXTURE_PATH}/css/empty.css"
+          results = @validator.check file
+
+          assert results.empty?, "同目录下有min文件，测试应通过"
+        end
+
+        def test_source_file_without_min
+          file = "#{FIXTURE_PATH}/css/import.css"
+          results = @validator.check file
+
+          expect_err = XRay::LogEntry.new('发布上线的文件需要压缩，命名规则如a.js->a-min.js，且两者在同一目录下', :error)
+          assert_equal [expect_err], results, "同目录下没有对应的min文件，测试不应通过"
+        end
+
+        def test_merge_file
+          file = 'merge.css'
+          results = @validator.check file
+
+          assert results.empty?, "merge文件不需要被压缩"
+        end
+
+        def test_min_file
+          file = 'test-min.css'
+          results = @validator.check file
+
+          assert results.empty?, "本身已经被压缩，不需要再检查"
+        end
+
+
+      end
+
+    end
+  end
+end
+

data/test/css/rule/file_name_test.rb

@@ -0,0 +1,76 @@
+# encoding: utf-8
+
+require_relative '../../helper'
+
+require 'node'
+require 'css/struct'
+require 'css/rule/checklist'
+
+module XRayTest
+  module CSS
+    module Rule
+      
+      class CheckFileNameTest < Test::Unit::TestCase
+
+        include XRay::Rule
+
+        def setup
+        end
+
+        def test_file_name_with_ad
+          check 'css/ad.css' do |results|
+            expect_err = ["路径和文件名中不应该出现ad", :error]
+            assert_equal [expect_err], results, "文件名中不应出现ad"
+          end
+        end
+
+        def test_path_name_with_ad
+          check "/css/adver/test.css" do |results|
+            expect_err = ["路径和文件名中不应该出现ad", :error] 
+            assert_equal [expect_err], results, "文件路径中不应出现ad"
+          end
+        end
+
+        def test_file_name_without_ad
+          check 'not-exsiting-file.css' do |results|
+            assert results.empty?, "文件名中不应出现ad,包括路径"
+          end
+        end
+
+        def test_file_name_with_underscore
+          check 'not_exsiting_file.css' do |results|
+            expect_err = ["文件名中单词的分隔符应该使用中横线“-”", :error] 
+            assert_equal [expect_err], results, "文件名中单词的分隔符应该使用中横线“-”"
+          end
+        end
+
+        def test_file_name_with_upcase
+          check 'someFile.css' do |results|
+            expect_err = ["文件夹和文件命名必须用小写字母", :error] 
+            assert_equal [expect_err], results, "文件夹和文件命名必须用小写字母"
+          end
+        end
+
+        def test_dir_name_with_minus
+          check 'test-post-offer/main.css' do |results|
+            expect_err = ["文件夹只有需要版本区分时才可用中横线分隔，如fdev-v3", :error] 
+            assert_equal [expect_err], results, "文件夹只有需要版本区分时才可用中横线分隔"
+          end
+        end
+
+        def test_dir_name_with_version_minus
+          check 'test-2/main.css' do |results|
+            assert results.empty?, "目录名字中带有版本号时可以用中横线"
+          end
+        end
+
+        protected
+        def check(file, &block)
+          yield check_css_file(file)
+        end
+
+      end
+
+    end
+  end
+end

data/test/fixtures/css/broken.css

@@ -0,0 +1,4 @@
+body {
+   
+ 
+ 

data/test/fixtures/css/cbu/36.css

@@ -0,0 +1,52 @@
+/**
+ * ����:���Ϸ���
+ * 
+ * @author qijun.weiqj
+ */
+
+/**
+ * company-name
+ */
+.skin-topbanner {
+	background: #fddde2 url(http://img.china.alibaba.com/images/app/winport/layout/diybackground/style/temp36/topbaner.jpg);
+}
+.wp-company-name .chinaname, .wp-company-name .chinaname:hover {
+	color: #990033;
+}
+.wp-company-name .enname, .wp-company-name .enname:hover {
+	color: #a23a5c;
+}
+
+/**
+ * top-nav
+ */
+.wp-top-nav {
+	border-top: 1px solid #fff;
+	border-bottom: 1px solid #fff;
+	background: #d51d5d url(http://img.china.alibaba.com/images/app/winport/layout/diybackground/style/temp36/header_menu.gif) repeat-x left top;
+}
+.wp-top-nav li a,
+.wp-top-nav li a:hover {
+	color: #fff;
+}
+.wp-top-nav li.selected a,
+.wp-top-nav li.selected a:hover {
+	background: url(http://img.china.alibaba.com/images/app/winport/layout/diybackground/style/temp36/header_menu_check.png) no-repeat left top;
+	_background: none;
+	_filter: progid:DXImageTransform.Microsoft.AlphaImageLoader(src=http://img.china.alibaba.com/images/app/winport/layout/diybackground/style/temp36/header_menu_check.png,sizingMethod=scale);
+	color: #c20606;
+}
+
+
+/**
+ * mod
+ */
+.mod .m-body {
+	border: 1px solid #ffe4e4;
+}
+.mod .m-header {
+	background: #333 url(http://img.china.alibaba.com/images/app/winport/layout/diybackground/style/temp36/body_cont_title.gif) repeat-x left top;
+	color: #fff;
+}
+
+