fdlint 0.1.0

data/test/js/expr/operate.rb

@@ -0,0 +1,145 @@
+module XRayTest
+  module JS
+    module Expr
+      
+      module Operate
+        
+        def test_parse_expr_postfix
+          jses = [
+            'hello++',
+            'i--',
+            'j\n++'
+          ]
+          exprs = [
+            '(++,hello,)',
+            '(--,i,)',
+            'j'      
+          ]
+          add_test :parse_expr_postfix, jses, exprs 
+        end
+
+        def test_parse_expr_unary
+          jses = [
+            '++i',
+            '-1',
+            'delete a[hello]',
+            '!a'
+          ] 
+          exprs = [
+            '(++,,i)',
+            '(-,,1)',
+            '(delete,,([,a,hello))',
+            '(!,,a)'
+          ]
+          add_test :parse_expr_unary, jses, exprs 
+        end
+
+        def test_parse_expr_mul
+          jses = [
+            'a * b / c % d * e / f'
+          ]
+          exprs = [
+            '(/,(*,(%,(/,(*,a,b),c),d),e),f)'
+          ]
+          add_test :parse_expr_mul, jses, exprs 
+        end
+
+        def test_parse_expr_add
+          jses = [
+            'a * b + c - d / e + f % d + a'
+          ]
+          exprs = [
+            '(+,(+,(-,(+,(*,a,b),c),(/,d,e)),(%,f,d)),a)'
+          ]
+          add_test :parse_expr_add, jses, exprs 
+        end
+
+        def test_parse_expr_shift
+          jses = [
+            'a << 123',
+            'a + 1 >> 1 + 2',
+            '1 * 100 >> 2 >>> 1 + 2 * 3 - 4'
+          ]
+          exprs = [
+            '(<<,a,123)',
+            '(>>,(+,a,1),(+,1,2))',
+            '(>>>,(>>,(*,1,100),2),(-,(+,1,(*,2,3)),4))'
+          ]
+          add_test :parse_expr_shift, jses, exprs 
+        end
+
+        def test_parse_expr_relation
+          jses = [
+            'a + 1 < b',
+            'a + 2 * 3 >= a++',
+            '++a-- > --b + c',
+            'instanceofA instanceof instanceofB',
+            'innameA in innameC'
+          ]
+          
+          exprs = [
+            '(<,(+,a,1),b)',
+            '(>=,(+,a,(*,2,3)),(++,a,))',
+            '(>,(++,,(--,a,)),(+,(--,,b),c))',
+            '(instanceof,instanceofA,instanceofB)',
+            '(in,innameA,innameC)'
+          ]
+
+          add_test :parse_expr_relation, jses, exprs
+        end
+
+        def test_parse_expr_equal
+          jses = [
+            'a + 1 === c',
+            'a + 1 * c !== 11 + 22 < 3',
+            'a + 1 < 3 == 1 << 3',
+            'a << 4 - 5 == 1 << 3 === 5'
+          ]
+
+          exprs = [
+            '(===,(+,a,1),c)',
+            '(!==,(+,a,(*,1,c)),(<,(+,11,22),3))',
+            '(==,(<,(+,a,1),3),(<<,1,3))',
+            '(===,(==,(<<,a,(-,4,5)),(<<,1,3)),5)' 
+          ]
+
+          add_test :parse_expr_equal, jses, exprs
+
+        end
+
+        def test_parse_expr_bit
+          jses = [
+            '1 & b + 1',
+            '1 & 2 ^ 3 & 4 ^ 5 + 6 & 7',
+            '1 + 2 | 3 + 4 & 5 ^ 6 | 7 - 8'
+          ]
+
+          exprs = [
+            '(&,1,(+,b,1))',
+            '(^,(^,(&,1,2),(&,3,4)),(&,(+,5,6),7))',
+            '(|,(|,(+,1,2),(^,(&,(+,3,4),5),6)),(-,7,8))' 
+          ]
+
+          add_test :parse_expr_bit_or, jses, exprs       
+        end
+
+
+        def test_parse_expr_logical
+          jses = [
+            'a + 1 == 0 && b - 1 > 3',
+            'a + 1 == 0 && b === c || a - b == c - d && c > 0'
+          ]
+
+          exprs = [
+            '(&&,(==,(+,a,1),0),(>,(-,b,1),3))',
+            '(||,(&&,(==,(+,a,1),0),(===,b,c)),(&&,(==,(-,a,b),(-,c,d)),(>,c,0)))'
+          ]
+
+          add_test :parse_expr_logical_or, jses, exprs
+        end
+
+      end
+
+    end
+  end
+end

data/test/js/expr/primary.rb

@@ -0,0 +1,89 @@
+module XRayTest
+  module JS
+    module Expr
+      
+      module Primary
+
+        def test_parse_expr_parentheses
+          expr = parse_js :parse_expr_parentheses, '(12.56)'
+
+          assert_equal 'parentheses', expr.type
+          assert_equal '12.56', expr.node.text
+        end
+
+        def test_parse_expr_array
+          js = '[123, 456, "hello world", /this is re/]'
+          expr = parse_js :parse_expr_array, js
+
+          assert_equal 'array', expr.type
+          assert_equal ['123', '456', '"hello world"', '/this is re/'], 
+              expr.node.elements.collect(&:text)
+        end
+
+        def test_parse_expr_object
+          js = '{
+            name: "hello 1234",
+            "key 2": 123.567e12,
+            12.59: 12.58,
+            18: /hello/    
+          }'
+
+          expr = parse_js :parse_expr_object, js
+
+          assert_equal 'object', expr.type
+
+          assert_equal ['name', '"key 2"', '12.59', '18'], 
+              expr.node.elements.collect(&:left).collect(&:text)
+
+          assert_equal ['"hello 1234"', '123.567e12', '12.58', '/hello/'],
+              expr.node.elements.collect(&:right).collect(&:text)
+        end
+        
+        def test_parse_expr_literal
+          jses = [
+            'this.a = 123',
+            'null === a',
+            'true === false',
+            'false === true',
+
+            '123 == a',
+            '.12 = b',
+            '0.123 = c',
+            '+123e+1 = d',
+            '123.123e-1 = e',
+            '12345.123e123',
+
+            '/\\\\/g,a = "bcd"'
+          ]
+
+          str1 = %q("hello this is a single line str\\"ing")
+          str2 = %q('hello this is a \'single line string')
+
+          str3 = '"hello this is an mutiline string\\
+          hello this is an mutiline string\\
+          hello this is an mutiline string"'
+
+          re1 = %q{/((?:\((?:\([^()]+\)|[^()]+)+\)|\[(?:\[[^\[\]]*\]|['"][^'"]*['"]|[^\[\]'"]+)+\]|\\.|[^ >+~,(\[\\]+)+|[>+~])(\s*,\s*)?((?:.|\r|\n)*)/g}
+
+          re2 = %q{/\/\*[^*]*\*+([^/][^*]*\*+)*\//gm}
+
+          jses << str1 << str2 << str3 << re1 << re2
+
+          exprs = jses.collect do |js|
+            parse_js :parse_expr_primary, js
+          end
+
+          eqs = %w(
+            this null true false
+            123 .12 0.123 +123e+1 123.123e-1 12345.123e123
+            /\\\\/g
+          )
+          eqs << str1 << str2 << str3 << re1 << re2
+          assert_equal eqs, exprs.collect(&:node).collect(&:text)
+        end
+
+      end
+    
+    end
+  end
+end

data/test/js/parser_test.rb

@@ -0,0 +1,98 @@
+# encoding: utf-8
+require File.expand_path('../helper', File.dirname(__FILE__))
+
+require 'js/parser'
+
+require_relative 'expr/expr'
+require_relative 'stat/stat'
+
+
+module XRayTest
+  module JS
+    class ParserTest < Test::Unit::TestCase 
+      include XRay::JS
+
+      include Expr::Expr
+      include Stat::Stat
+
+      
+      def test_parse_program()
+        js = '
+          /**
+           * this is mutiline comment
+           */
+          function say(name1, name2/*inline comment*/, name3) {
+            alert(name + " hello world");
+            console.debug(name2);
+            name1 + name2 + // line comment
+              name3;
+          }
+          ; // hello this is comment
+          var a = 1;
+          a++;
+        ' 
+        parser = create_parser(js)
+        program = parser.parse_program
+        elms = program.elements
+        
+        assert_equal 4, elms.length
+
+        s_comments = parser.singleline_comments
+        assert_equal 2, s_comments.length
+
+        m_comments = parser.mutiline_comments
+        assert_equal 2, m_comments.length
+      end 
+
+      def test_parse_function_declaration
+        js = '
+          function sum(a1, a2, a3) {
+            a1 = a2 + a3;
+            a2 = a2 * a3;
+            a3++;
+          }
+        ' 
+
+        parser = create_parser(js)
+        func = parser.parse_function_declaration
+
+        assert_equal 'sum', func.name.text
+        assert_equal '[a1,a2,a3]', func.parameters.text
+      end
+
+      def test_parse_singleline_comment
+        js = '
+          // this is simple comment
+          a = 123;
+        ' 
+        
+        comment = parse_js :parse_singleline_comment, js 
+        assert_equal '// this is simple comment', comment.text
+      end
+
+
+      def create_parser(js)
+        Parser.new js, XRayTest::Logger.new
+        
+      end
+
+      def parse_js(action, js)
+        parser = create_parser js
+        parser.send(action)
+      end
+
+      def add_test(action, jses, exprs)
+        if jses.class == String
+          jses = [jses]
+          exprs = [exprs]
+        end
+        jses.each_with_index do |js, index|
+          expr = parse_js action, js 
+          assert_equal exprs[index], expr.text
+        end
+      end
+    end
+  end
+end
+
+

data/test/js/rule/alert_check_test.rb

@@ -0,0 +1,37 @@
+# encoding: utf-8
+require_relative 'base_test'
+
+require 'js/rule/checklist'
+
+module XRayTest
+  module JS
+    module Rule
+      
+      class AlertCheckTest < BaseTest
+
+        def test_visit_alert
+          js = 'alert'
+          ret = visit js
+          assert_equal 1, ret.length
+        end
+       
+        def test_vist_window_alert
+          js = "window.alert"
+          ret = visit js
+          assert_equal [], ret
+        end 
+
+        private
+
+        def visit(js)
+          expr = parse js, 'expr_member'
+          rule = XRay::JS::Rule::ChecklistRule.new
+          rule.send :visit_expr_member, expr
+        end
+
+      end
+
+    end
+  end
+end
+

data/test/js/rule/all_test.rb

@@ -0,0 +1,23 @@
+require_relative '../../helper'
+
+require 'js/rule/all'
+
+module XRayTest
+  module JS
+    module Rule
+      
+      class AllTest < Test::Unit::TestCase
+        
+        def test_initialize
+          all = XRay::JS::Rule::All.new
+          
+          assert all.respond_to?(:each)
+          assert all.size > 0
+          assert all.size == all.rules.size
+        end 
+
+      end
+
+    end
+  end
+end

data/test/js/rule/base_test.rb

@@ -0,0 +1,34 @@
+require_relative '../../helper'
+
+require 'js/parser'
+require 'parser_visitable'
+
+module XRayTest
+
+  module JS
+    module Rule
+
+      class VisitableParser < XRay::JS::Parser
+          include XRay::ParserVisitable 
+      end
+
+      class BaseTest < Test::Unit::TestCase
+
+        def parse(js, action = 'parse_program')
+          parser = XRay::JS::Parser.new js, XRayTest::Logger.new
+          parser.send "parse_#{action}" 
+        end 
+
+        def parse_with_rule(js, rule, options = {})
+          parser = VisitableParser.new js, XRayTest::Logger.new
+          rule = rule.new if rule.is_a? Class
+          parser.add_visitor rule 
+          parser.parse_program
+          parser.results
+        end
+         
+      end
+
+    end
+  end
+end

data/test/js/rule/file_checker_test.rb

@@ -0,0 +1,131 @@
+# encoding: utf-8
+
+require_relative 'base_test'
+
+require 'js/rule/file_checker'
+
+module XRayTest
+  module JS
+    module Rule
+      
+      class FileCheckerTest < BaseTest
+          
+        def setup
+          @checker = XRay::JS::Rule::FileChecker.new 
+        end
+
+        def test_merge_file?
+          assert @checker.merge_file?('abc-merge.js')
+          assert @checker.merge_file?('abc-merge-12345.js')
+          assert @checker.merge_file?('abc-merge12345.js')
+          
+          assert !@checker.merge_file?('abc-merge.css')
+          assert !@checker.merge_file?('abc-merge.jss')
+          assert !@checker.merge_file?('-merge.js')
+          assert !@checker.merge_file?('abc-mergeabc.js')
+          assert !@checker.merge_file?('abc-merge-.js')
+        end
+
+        def test_min_file?
+          assert @checker.min_file?('abc-min.js') 
+          
+          assert !@checker.min_file?('abc-min.jss') 
+          assert !@checker.min_file?('-min.js') 
+          assert !@checker.min_file?('abc-min1.js') 
+        end
+
+        def test_grep_import_js_path
+          pathes = @checker.grep_import_js_path fixture_01
+          assert_equal 6, pathes.length
+          assert_equal %w(
+            http://style.china.alibaba.com/js/common/aliclick.js
+            http://style.china.alibaba.com/js/detail/xpclick.js
+            http://style.china.alibaba.com/js/lib/fdev-v4/widget/util/debug-min.js
+            http://style.china.alibaba.com/js/lib/fdev-v4/widget/web/alitalk-min.js
+            http://style.china.alibaba.com/js/lib/fdev-v4/widget/web/sweet-min.js
+            http://style.china.alibaba.com/js/lib/fdev-v4/widget/web/sweet-min.js
+          ), pathes.collect { |path| path[:url] }
+        end
+
+        def test_check_one_line_one_import
+          pathes = @checker.grep_import_js_path fixture_01
+          ret = []
+          pathes.each { |import| 
+            r = @checker.check_js_merge_importing import, pathes, "" 
+            ret.concat r 
+          }
+          assert_equal [
+              ["merge文件需要引用压缩版的js, 如a-min.js", :warn, 12, 63],
+              ["merge文件需要引用压缩版的js, 如a-min.js", :warn, 13, 62],
+              ["一行只能有一个import文件", :error, 18, 96], 
+              ["merge文件格式不正确", :error, 19, 1], 
+              ["merge文件格式不正确", :error, 20, 1]
+            ], ret
+        end
+
+        def test_has_doc_comment
+          js = '
+            /**
+             * 功能文件头必须要有文档注释
+             * 现在没有对doc格式进行规范
+             * 所以暂时不做文档注释内容检查
+             * 只检则有注释
+             */
+
+            i++;
+          '
+          assert @checker.has_doc_comment?(js)
+          
+          js = '
+            i++;
+          '
+          assert !@checker.has_doc_comment?(js)
+
+          js = '
+            /*
+             * 多行注释不属于文档注释
+             * 文档注释需要以/*开头
+             */
+          '
+          assert !@checker.has_doc_comment?(js)
+        end
+
+        def test_check_import_js_scope
+          #not implements
+        end
+
+        def test_check_import_js_exist_and_min
+          # not implements
+        end
+
+        def fixture_01
+<<END
+(function(){
+    ImportJavscript = {
+        url:function(url){
+            document.write('<script type="text/javascript" src="'+url+'"></scr'+'ipt>');
+        }
+    };
+})();
+
+/**
+ * 打点依赖库
+ */
+ImportJavscript.url('http://style.china.alibaba.com/js/common/aliclick.js');
+ImportJavscript.url(http://style.china.alibaba.com/js/detail/xpclick.js);
+
+/**
+ * 旺铺基础JS
+ */
+ImportJavscript.url("http://style.china.alibaba.com/js/lib/fdev-v4/widget/util/debug-min.js"); ImportJavscript.url("http://style.china.alibaba.com/js/lib/fdev-v4/widget/web/alitalk-min.js");
+ImportJavscript.url( 'http://style.china.alibaba.com/js/lib/fdev-v4/widget/web/sweet-min.js' ) ;
+ImportJavscript.url('http://style.china.alibaba.com/js/lib/fdev-v4/widget/web/sweet-min.js')
+END
+        end
+
+      end
+
+    end
+  end
+end
+

data/test/js/rule/jq_check_test.rb

@@ -0,0 +1,90 @@
+# encoding: utf-8
+require_relative 'base_test'
+
+require 'js/rule/checklist'
+
+module XRayTest
+  module JS
+    module Rule
+      
+      class JqCheckTest < BaseTest
+        def test_visit_expr_member
+          js = 'jQuery.noConflict'
+          ret = visit js
+          assert_equal 2, ret.length
+        end
+       
+        def test_check_direct_jquery_call
+          js = "jQuery.namespace"
+          ret = visit js
+          assert_equal [], ret
+          
+          jses = [
+            'jQuery.bind',
+            'jQuery[method]',
+            'jQuery(function($) {})',
+            'jQuery.extend'
+          ]
+
+          jses.each do |js|
+            r = visit js
+            assert r.include? ['禁止直接使用jQuery变量，使用全局闭包写法"(function($, NS){....})(jQuery,Namespace);"，jQuery.namespace例外', :error]
+          end
+        end 
+
+        def test_check_forbit_method_call
+          jses = %w(
+            $.sub
+            $.noConflict
+            jQuery.sub
+            jQuery.noConflict
+          )
+
+          jses.each do |js|
+            r = visit js
+            assert r.include?( ['禁止使用jQuery.sub()和jQuery.noConflict方法', :error] )
+          end
+        end
+
+        def test_check_data_call_param
+          jses = %w(
+            $.data("doc-config")
+            jQuery.data('doc-config')
+          )
+          jses.each do |js|
+            r = visit js
+            assert r.include? ['使用".data()"读写自定义属性时需要转化成驼峰形式', :error]
+          end
+        end
+
+        def test_check_ctor_selector
+          jses = [
+            "$('.myclass', div)",
+            "$('.myclass')",
+            "$('[name=123]')",
+            "$(':first')"
+          ]
+          
+          jses.each do |js|
+            r = visit js
+            assert r.include? ['使用选择器时，能确定tagName的，必须加上tagName', :warn]
+          end
+
+          js = '$()'
+          ret = visit js
+          assert_equal [], ret
+        end
+
+        private
+
+        def visit(js)
+          expr = parse js, 'expr_member'
+          rule = XRay::JS::Rule::ChecklistRule.new
+          rule.send :visit_expr_member, expr
+        end
+
+      end
+
+    end
+  end
+end