fdlint 0.1.0

data/rules.d/js.rule

@@ -0,0 +1,84 @@
+# encoding: utf-8
+# vi: filetype=ruby
+
+js
+
+check_statement do |stat|
+  ary = %w(empty var continue break return throw expression)
+  if ary.include?(stat.type) && !stat.end_with_semicolon?
+    ['所有语句结束带上分号', :error] 
+  end
+end
+
+check_stat_if do |stat|
+  if stat.true_part.type != 'block' ||
+      stat.false_part && stat.false_part.type != 'if' && stat.false_part.type != 'block'
+    
+    ['所有条件区域必须用花括号括起来', :error]
+  end
+end
+ 
+check_stat_if do |stat|
+  count = 0;
+  while stat.false_part && stat.false_part.type == 'if'
+    count += 1
+    stat = stat.false_part
+  end
+  count += 1 if stat.false_part
+  if count >= 3
+    ['3个条件及以上的条件语句用switch代替if else', :error] 
+  end
+end
+
+check_expr_new do |expr|
+  expr = expr.left 
+  expr = expr.left if expr.type == '('
+
+  if expr.type == 'id'
+    if expr.text == 'Object'
+      ['使用{}代替new Object()', :error]
+    elsif expr.text == 'Array'
+      ['使用[]代替new Array()', :error]
+    end 
+  end
+end
+
+check_expr_member do |expr|
+  expr = context.find_expr_member(expr) { |expr| expr.type == '(' }
+  checks = %w(
+    (.,window,eval)
+    eval
+  )
+  if expr && checks.include?(expr.left.text)
+    ['不允许使用eval', :error] 
+  end
+end
+
+check_expr_member do |expr|
+  if expr.left && expr.left.text == 'alert'
+    ['必须去掉临时调试代码。如果一定要使用alert功能，请使用 window.alert', :warn]
+  end
+end
+
+check_expr_member do |expr|
+  if expr.left
+    if expr.left.text =~ /(?<!this|self),_/
+      ['禁止调用对象的私有方法', :error]
+    end
+  end
+end
+ 
+check_expr_equal do |expr|
+  if expr.type == '==' || expr.type == '!='
+    ['避免使用==和!=操作符', :warn]
+  end
+end
+
+check_stat_try do |stat|
+  if stat.try_part.contains?('try') ||
+      stat.catch_part && (stat.catch_part.contains? 'try') ||
+      stat.finally_part && (stat.finally_part.contains? 'try')
+    ['try catch一般不允许嵌套，若嵌套，需要充分的理由', :warn]
+  end
+end
+

data/test/all_tests.rb

@@ -0,0 +1,84 @@
+gem 'test-unit' if defined? gem
+require 'test/unit'
+require 'test/unit/testsuite'
+require 'test/unit/ui/console/testrunner'
+
+unless Kernel.respond_to?(:require_relative)
+  module Kernel
+    def require_relative(path)
+      require File.expand_path(path.to_str, File.dirname(caller[0]))
+    end
+  end
+end
+
+require_relative 'parser_visitable_test'
+require_relative 'position_info_test'
+require_relative 'css/parser_test'
+require_relative 'css/mac_line_end_support_test'
+require_relative 'css/rule/check_list_rule_test'
+require_relative 'css/rule/check_encoding_test'
+require_relative 'css/rule/file_name_test'
+require_relative 'css/rule/compression_test'
+require_relative 'html/parser_test'
+require_relative 'html/rule_test'
+require_relative 'html/query_test'
+require_relative 'html/mixed_type_test'
+require_relative 'js/parser_test'
+require_relative 'js/rule_test'
+require_relative 'rule_dsl/dsl_basic_test'
+require_relative 'rule_dsl/importing_test'
+require_relative 'cli/cli_test'
+require_relative 'cli/type_test'
+require_relative 'cli/output_format_test'
+require_relative 'cli/log_level_test'
+require_relative 'runner/log_level_test'
+
+
+module XRayTest
+
+  class ALL < Test::Unit::TestSuite
+
+    def self.suite
+      tests = Test::Unit::TestSuite.new
+
+      tests << PositionInfoTest.suite
+      tests << ParserVisitableTest.suite
+      
+      #CSS
+      tests << CSS::ParserTest.suite
+      tests << CSS::MacLineEndSupportTest.suite
+      tests << CSS::Rule::CheckListRuleTest.suite
+      tests << CSS::Rule::CheckEncodingTest.suite
+      tests << CSS::Rule::CheckFileNameTest.suite
+      tests << CSS::Rule::CompressionTest.suite
+
+      #HTML
+      tests << HTML::ParserTest.suite
+      tests << HTML::RuleTest.suite
+      tests << HTML::QueryTest.suite
+      tests << HTML::MixedTypeTest.suite
+
+      #JS
+      tests << JS::ParserTest.suite
+      tests << JS::RuleTest.suite
+
+      #RULE
+      tests << Rule::DSLBasicTest.suite
+      tests << Rule::ImportingTest.suite
+
+      #CLI
+      tests << CLI::CLITest.suite
+      tests << CLI::TypeTest.suite
+      tests << CLI::OutputFormatTest.suite
+      tests << CLI::LogLevelTest.suite
+
+      #RUNNER
+      tests << Runner::LogLevelTest.suite
+
+      tests
+    end
+  end
+
+end
+
+Test::Unit::UI::Console::TestRunner.run( XRayTest::ALL )

data/test/cli/cli_test.rb

@@ -0,0 +1,70 @@
+# encoding: utf-8
+require 'test/unit'
+require_relative '../helper'
+
+module XRayTest
+
+  module CLI
+
+    class CLITest < Test::Unit::TestCase
+
+      def setup
+        @bin = File.expand_path(File.join File.dirname(__FILE__), '../../bin/fdlint')
+      end
+
+      def test_cli_main
+        if has_ruby? '1.9.1'
+          @cmd = "ruby1.9.1 #{@bin}"
+          do_all_test
+        else 
+          warn 'Skipping Ruby1.9 CLI Test!'
+        end
+      end
+
+      def do_all_test
+        public_methods.grep(/^do_test_/).each do |m|
+          send m
+        end
+      end
+
+      def do_test_check_html_file
+        res = `#{@cmd} #{FIXTURE_ABS_PATH}/html/syntax_err.html`
+        assert res.index "[FATAL] [3,1]"
+      end
+
+      def do_test_check_css_file
+        res = `#{@cmd} #{FIXTURE_ABS_PATH}/css/using_star.css`
+        assert res.include? '禁止使用星号选择符'
+      end
+
+      def do_test_check_js_file
+        res = `#{@cmd} #{FIXTURE_ABS_PATH}/js/scope-test.js`
+        assert res.include? '[ERROR] [13,10] 禁止使用未定义的变量(或全局变量)'
+        assert res.include? '[ERROR] [19,3] 禁止使用未定义的变量(或全局变量)'
+      end
+
+      unless `which cat`.empty?
+
+        def do_test_check_html_text
+          res = `cat #{FIXTURE_ABS_PATH}/html/syntax_err.html | #{@cmd}`
+          assert res.include? "[FATAL] [3,1]"
+        end
+
+        def do_test_check_css_text
+          res = `cat #{FIXTURE_ABS_PATH}/css/using_star.css | #{@cmd}`
+          assert res.include? '禁止使用星号选择符'
+        end
+
+        def do_test_check_js_text
+          res = `cat #{FIXTURE_ABS_PATH}/js/scope-test.js | #{@cmd}`
+          assert res.include? '[ERROR] [13,10] 禁止使用未定义的变量(或全局变量)'
+          assert res.include? '[ERROR] [19,3] 禁止使用未定义的变量(或全局变量)'
+        end
+
+      end
+
+    end
+
+  end
+
+end

data/test/cli/log_level_test.rb

@@ -0,0 +1,51 @@
+# encoding: utf-8
+require 'test/unit'
+require_relative '../helper'
+
+module XRayTest
+
+  module CLI
+
+    class LogLevelTest < Test::Unit::TestCase
+
+      def setup
+        @bin = File.expand_path(File.join File.dirname(__FILE__), '../../bin/fdlint')
+        @fixture = File.expand_path(File.join File.dirname(__FILE__), '../fixtures/html/mixed_log_levels.html')
+        @cmd = "ruby #{@bin} #{@fixture}"
+      end
+
+      unless `which cat`.empty?
+        def test_output_all_by_default
+          res = `#{@cmd}`
+          assert res.include? 'WARN'
+          assert res.include? 'ERROR'
+          assert res.include? 'FATAL'
+        end
+
+        def test_output_fatals
+          res = `#{@cmd} --level=fatal`
+          assert !res.include?('WARN')
+          assert !res.include?('ERROR')
+          assert res.include? 'FATAL'
+        end
+
+        def test_output_fatals_and_errors
+          res = `#{@cmd} --level=error`
+          assert !res.include?('WARN')
+          assert res.include?('ERROR')
+          assert res.include? 'FATAL'
+        end
+
+        def test_output_fatals_errors_and_warnings
+          res = `#{@cmd} --level=warn`
+          assert res.include?('WARN')
+          assert res.include?('ERROR')
+          assert res.include? 'FATAL'
+        end
+      end
+    end
+
+  end
+
+end
+

data/test/cli/output_format_test.rb

@@ -0,0 +1,47 @@
+# encoding: utf-8
+require 'test/unit'
+require_relative '../helper'
+
+module XRayTest
+
+  module CLI
+
+    class OutputFormatTest < Test::Unit::TestCase
+
+      @@bin = File.expand_path(File.join File.dirname(__FILE__), '../../bin/fdlint')
+      @@cmd = "ruby #{@@bin}"
+
+      def test_with_console_format
+        res = `#{@@cmd} #{FIXTURE_ABS_PATH}/css/empty.css`
+        assert res.include? "[OK] /home/qhwa/projects/fdlint/test/fixtures/css/empty.c"
+      end
+
+      def test_with_nocolor_format
+        res = `#{@@cmd} --format=nocolor #{FIXTURE_ABS_PATH}/css/empty.css`
+        assert res.include? "[OK] /home/qhwa/projects/fdlint/test/fixtures/css/empty.c"
+      end
+
+      def test_with_vim_format
+        res = `#{@@cmd} --format=vim #{FIXTURE_ABS_PATH}/css/empty.css`
+        assert res.empty?
+      end
+
+      def test_reulsts_with_vim_format
+        res = `#{@@cmd} --format=vim #{FIXTURE_ABS_PATH}/css/using_expr.css`
+        assert res.include? 'using_expr.css:[error]:5,7:禁止使用CSS表达式'
+        assert res.include? 'using_expr.css:[error]:6,6:禁止使用CSS表达式'
+      end
+
+      unless `which cat`.empty?
+        def test_results_with_vim_format_in_pipline
+          res = `cat #{FIXTURE_ABS_PATH}/css/using_expr.css | #{@@cmd} --format=vim `
+          assert res.include? '-:[error]:5,7:禁止使用CSS表达式'
+          assert res.include? '-:[error]:6,6:禁止使用CSS表达式'
+        end
+      end
+
+    end
+
+  end
+
+end

data/test/cli/type_test.rb

@@ -0,0 +1,77 @@
+# encoding: utf-8
+require 'test/unit'
+require_relative '../helper'
+
+module XRayTest
+
+  module CLI
+
+    class TypeTest < Test::Unit::TestCase
+
+      def setup
+        @bin = File.expand_path(File.join File.dirname(__FILE__), '../../bin/fdlint')
+      end
+
+      def test_cli_main
+        if has_ruby? '1.9.1'
+          @cmd = "ruby1.9.1 #{@bin}"
+          do_all_test
+        else 
+          warn 'Skipping Ruby1.9 CLI Test!'
+        end
+
+      end
+
+      def do_all_test
+        public_methods.grep(/^do_test_/).each do |m|
+          send m
+        end
+      end
+
+      def do_test_check_html_file
+        res = `#{@cmd} --html #{FIXTURE_ABS_PATH}/html/syntax_err.html`
+        assert res.index "[FATAL] [3,1]"
+      end
+
+      def do_test_check_js_file_with_html_type
+        res = `#{@cmd} --html #{FIXTURE_ABS_PATH}/js/scope-test.js`
+        assert res.empty?
+      end
+
+      def do_test_check_css_file
+        res = `#{@cmd} --css #{FIXTURE_ABS_PATH}/css/using_star.css`
+        assert res.include? '禁止使用星号选择符'
+      end
+
+      def do_test_check_js_file
+        res = `#{@cmd} --js #{FIXTURE_ABS_PATH}/js/scope-test.js`
+        assert res.include? '[ERROR] [13,10] 禁止使用未定义的变量(或全局变量)'
+        assert res.include? '[ERROR] [19,3] 禁止使用未定义的变量(或全局变量)'
+      end
+
+      unless `which cat`.empty?
+
+        def do_test_check_html_text
+          res = `cat #{FIXTURE_ABS_PATH}/html/syntax_err.html | #{@cmd} --html`
+          assert res.include? "[FATAL] [3,1]"
+        end
+
+        def do_test_check_css_text
+          res = `cat #{FIXTURE_ABS_PATH}/css/using_star.css | #{@cmd} --css`
+          assert res.include? '禁止使用星号选择符'
+        end
+
+        def do_test_check_js_text
+          res = `cat #{FIXTURE_ABS_PATH}/js/scope-test.js | #{@cmd} --js`
+          assert res.include? '[ERROR] [13,10] 禁止使用未定义的变量(或全局变量)'
+          assert res.include? '[ERROR] [19,3] 禁止使用未定义的变量(或全局变量)'
+        end
+
+      end
+
+    end
+
+  end
+
+end
+

data/test/css/mac_line_end_support_test.rb

@@ -0,0 +1,38 @@
+# encoding: utf-8
+
+require_relative '../helper'
+
+require 'node'
+require 'log_entry'
+require 'css/struct'
+require 'css/rule/checklist'
+
+module XRayTest
+  module CSS
+      
+    class MacLineEndSupportTest < Test::Unit::TestCase
+
+      def setup
+        @runner = XRay::Runner.new :encoding => 'gb2312'
+      end
+
+      def test_check_mac_line_end_with_good_css
+        file = "#{FIXTURE_PATH}/css/mac-line-sep-good.css"
+        results = @runner.check_css_file file
+
+        assert results.empty?, "Mac style line end should be supported"
+      end
+
+      def test_check_mac_line_end_with_error_css
+        file = "#{FIXTURE_PATH}/css/mac-line-sep-err.css"
+        results = @runner.check_css_file file
+
+        assert_equal 1, results.size, "check as usual"
+      end
+
+
+    end
+
+  end
+end
+