fdlint 0.1.0

data/test/js/rule/nest_try_catch_test.rb

@@ -0,0 +1,71 @@
+# encoding: utf-8
+require_relative 'base_test'
+
+require 'js/rule/checklist'
+
+module XRayTest
+  module JS
+    module Rule
+      
+      class NestTryCatchTest < BaseTest
+
+        def test_ok
+          js = '
+            try {
+                  
+            } catch (e) {
+                
+            }
+          '
+          ret = visit js
+          assert_equal [], ret
+        end
+
+        def test_fail
+          js = '
+            try {
+              if (a > 0) {
+                try {
+                    
+                } catch (e) {
+                    
+                }    
+              }   
+            } finally {
+                
+            }
+          '
+          ret = visit js
+          assert_equal [['try catch一般不允许嵌套，若嵌套，需要充分的理由', :warn]], ret
+        end
+        
+        def test_nest_in_finnally_part
+          js = '
+            try {
+              if (a > 0) {
+              }   
+            } finally {
+              try {
+                  
+              } catch (e) {
+                  
+              }    
+            }
+          '
+          ret = visit js
+          assert_equal [['try catch一般不允许嵌套，若嵌套，需要充分的理由', :warn]], ret
+        end
+        
+        private
+
+        def visit(js)
+          stat = parse js, 'stat_try'
+          rule = XRay::JS::Rule::ChecklistRule.new
+          rule.visit_stat_try stat
+        end
+
+      end
+
+    end
+  end
+end

data/test/js/rule/new_object_and_new_array_test.rb

@@ -0,0 +1,38 @@
+# encoding: utf-8
+require_relative 'base_test'
+
+require 'js/rule/checklist'
+
+module XRayTest
+  module JS
+    module Rule
+      
+      class NewObjectAndNewArrayTest < BaseTest
+
+        def test_default
+          js = '
+            new Object();
+          '
+          ret = visit js
+          assert_equal [['使用{}代替new Object()', :error]], ret
+
+          js = '
+            new Array();
+          '
+          ret = visit js
+          assert_equal [['使用[]代替new Array()', :error]], ret
+        end
+        
+        private
+
+        def visit(js)
+          expr = parse js, 'expr_new'
+          rule = XRay::JS::Rule::ChecklistRule.new
+          rule.visit_expr_new expr
+        end
+
+      end
+
+    end
+  end
+end

data/test/js/rule/no_eval_test.rb

@@ -0,0 +1,34 @@
+# encoding: utf-8
+require_relative 'base_test'
+
+require 'js/rule/checklist'
+
+module XRayTest
+  module JS
+    module Rule
+      
+      class NoEvalTest < BaseTest
+       
+        def test_no_eval
+          js = 'eval("a = 1 + 2 + 3")' 
+          ret = visit js
+          assert_equal [['不允许使用eval', :error]], ret
+
+          js = 'window.eval("1 + 2 + 3")'
+          ret = visit js
+          assert_equal [['不允许使用eval', :error]], ret
+        end 
+
+        private
+
+        def visit(js)
+          expr = parse js, 'expr_member'
+          rule = XRay::JS::Rule::ChecklistRule.new
+          rule.visit_expr_member expr
+        end
+
+      end
+
+    end
+  end
+end

data/test/js/rule/no_global_test.rb

@@ -0,0 +1,88 @@
+# encoding: utf-8
+require_relative 'base_test'
+
+require 'js/rule/no_global'
+
+module XRayTest
+  module JS
+    module Rule
+    
+      class NoGlobalTest < BaseTest
+        
+        class Parser < XRay::JS::Parser
+          include XRay::ParserVisitable 
+        end
+        
+        def test_main
+          js = '
+            var a = 1;
+            a++;
+            function hello() {
+            }
+            if (a < 100) {
+              var b;
+              (function(k) {
+                var c = 123;
+
+                function d(j) {
+                  a = 1000;
+                  z = 200; 
+                  k = 300;
+                  j = 400
+                }
+              })();    
+            }
+          '
+          
+          ret = parse js 
+          assert_equal 4, ret.length
+          assert_equal '(var,[(var=,a,1)],)', ret[0].node.text
+          assert_equal 'hello', ret[1].node.text
+          assert_equal '(var,[(var=,b,)],)', ret[2].node.text
+          assert_equal '(=,z,200)', ret[3].node.text
+        end
+
+        def test_scope_in_other_function
+          js = <<-JS
+          /**
+           * scope test fixture
+           */
+          (function($){
+              function test(){
+                  var temp;
+              }
+
+              var _createSeperator = function(){
+                   var _self = this,
+                      menuEl = _self.get('menuEl');
+                   temp = [a,b,c];
+                   return new Node(temp).appendTo(menuEl);
+
+               test = 123;
+
+              //var temp2;
+              temp2 = 234;
+                };
+
+          })(jQuery);
+          JS
+
+          ret = parse js 
+          assert_equal [
+            "禁止使用未定义的变量(或全局变量)",
+            "禁止使用未定义的变量(或全局变量)"
+          ], ret.map(&:message)
+          assert_equal '(=,temp,[a,b,c])', ret[0].node.text
+          assert_equal '(=,temp2,234)', ret[1].node.text
+          
+        end
+        
+        def parse(js)
+          parse_with_rule js, XRay::JS::Rule::NoGlobalRule
+        end
+
+      end
+      
+    end
+  end
+end

data/test/js/rule/private_method_check_test.rb

@@ -0,0 +1,58 @@
+# encoding: utf-8
+require_relative 'base_test'
+
+require 'js/rule/checklist'
+
+module XRayTest
+  module JS
+    module Rule
+      
+      class PrivateMethodCheckTest < BaseTest
+
+        def test_normal
+          js = 'a.check("good")'
+          ret = visit js
+          assert_equal [], ret
+        end
+       
+        def test_protected_called
+          js = "a._check('good')"
+          ret = visit js
+          assert_equal 1, ret.length
+        end 
+
+        def test_protected_called_via_apply
+          js = "a._check.call(a, 'good')"
+          ret = visit js
+          assert_equal 1, ret.length
+        end
+
+        def test_private_called
+          js = "a.__check('good')"
+          ret = visit js
+          assert_equal 1, ret.length
+        end
+
+        def test_good_case
+          js = "this.__check('good')"
+          ret = visit js
+          assert_equal [], ret
+
+          js = "self._check('good')"
+          ret = visit js
+          assert_equal [], ret
+        end
+
+        private
+
+        def visit(js)
+          expr = parse js, 'expr_member'
+          rule = XRay::JS::Rule::ChecklistRule.new
+          rule.send :visit_expr_member, expr
+        end
+
+      end
+
+    end
+  end
+end

data/test/js/rule/semicolon_test.rb

@@ -0,0 +1,63 @@
+# encoding: utf-8
+require_relative 'base_test'
+
+require 'js/rule/checklist'
+
+module XRayTest
+  module JS
+    module Rule
+      
+      class SemicolonTest < BaseTest
+        include XRay::JS::Rule
+
+        def setup
+          @msg = '所有语句结束带上分号'
+        end
+        
+        def test_block
+          js = '{
+            i = i++;   
+          }'
+          
+          ret = visit js, 'block'
+          assert_equal [], ret
+        end
+
+        def test_empty
+          ret = visit ';', 'empty'
+          assert_equal [], ret
+        end
+
+        def test_var
+          js = '
+            var a = 1, b = 2
+            a++;
+          '
+          ret = visit js, 'var'
+          assert_equal [[@msg, :error]], ret
+        end
+
+        def test_expression
+          js = '
+            a = i + 1 + 2 + 3 * 9
+            i++
+          '
+          ret = visit js, 'expression'
+          assert_equal [[@msg, :error]], ret
+        end
+
+        private
+        
+        def visit(js, type)
+          stat = parse js, :statement
+          assert_equal type, stat.type
+
+          rule = XRay::JS::Rule::ChecklistRule.new
+          rule.visit_statement stat
+        end
+
+      end
+
+    end
+  end
+end

data/test/js/rule/stat_if_with_brace_test.rb

@@ -0,0 +1,68 @@
+# encoding: utf-8
+require_relative 'base_test'
+
+require 'js/rule/checklist'
+
+module XRayTest
+  module JS
+    module Rule
+      
+      class StatIfWithBraceTest < BaseTest
+
+        def setup
+          @msg = '所有条件区域必须用花括号括起来'
+        end
+        
+        def test_ok
+          js = '
+            if (i == 0) {
+              i++; 
+            } else {
+              i--
+            }
+          '
+          ret = visit js
+          assert_equal [], ret
+        end
+
+        def test_fail_1
+          js = '
+            if (i > 0)
+              i--
+            hello();
+          '
+          ret = visit js
+          assert_equal [[@msg, :error]], ret
+        end
+
+        def test_fail_2
+          js = '
+            if (hello()) {
+              i--;    
+            } else i++;
+
+          '
+          ret = visit js
+          assert_equal [[@msg, :error]], ret
+        end
+
+        def test_fail_3
+          js = 'if (i) i--; else i++;'
+
+          ret = visit js
+          assert_equal [[@msg, :error]], ret
+        end
+
+        private
+
+        def visit(js)
+          stat = parse js, 'stat_if'
+          rule = XRay::JS::Rule::ChecklistRule.new
+          rule.visit_stat_if stat
+        end
+
+      end
+
+    end
+  end
+end

data/test/js/rule/stat_if_with_muti_else_test.rb

@@ -0,0 +1,68 @@
+# encoding: utf-8
+require_relative 'base_test'
+
+require 'js/rule/checklist'
+
+module XRayTest
+  module JS
+    module Rule
+      
+      class StatIfWithMutiElseTest < BaseTest
+
+        def setup
+          @msg = '3个条件及以上的条件语句用switch代替if else'
+        end
+        
+        def test_ok
+          js = '
+            if (a > 0) {
+                
+            } else if (a > 10) {
+                
+            } else {    
+
+            }
+          '
+          ret = visit js
+          assert_equal [], ret
+        end
+
+        def test_fail_1
+          js = '
+            if (a > 1) {
+            } else if (a > 20) {
+            } else if (a > 30) {
+            } else {
+            }
+          '
+          ret = visit js
+          assert_equal [[@msg, :error]], ret
+        end
+
+        def test_fail_2
+          js = '
+            if (a > 2) {
+            } else if (a > 40) {
+            } else if (a > 50) {
+            } else if (a > 60) {
+            }
+          '
+          ret = visit js
+          assert_equal [[@msg, :error]], ret
+        end
+
+
+
+        private
+
+        def visit(js)
+          stat = parse js, 'stat_if'
+          rule = XRay::JS::Rule::ChecklistRule.new
+          rule.visit_stat_if stat
+        end
+
+      end
+
+    end
+  end
+end

data/test/js/rule/use_strict_equal_test.rb

@@ -0,0 +1,44 @@
+# encoding: utf-8
+require_relative 'base_test'
+
+require 'js/rule/checklist'
+
+module XRayTest
+  module JS
+    module Rule
+      
+      class UseStrictEqualTest < BaseTest
+
+        def test_ok
+          js = 'i === 1 + 1 / 2'
+          ret = visit js
+          assert_equal [], ret 
+
+          js = 'i !== hello()'
+          ret = visit js
+          assert_equal [], ret
+        end
+
+        def test_fail
+          js = 'i == 1 + 1 / 2'
+          ret = visit js
+          assert_equal [['避免使用==和!=操作符', :warn]], ret
+
+          js = 'i != hello()'
+          ret = visit js
+          assert_equal [['避免使用==和!=操作符', :warn]], ret
+        end
+        
+        private
+
+        def visit(js)
+          expr = parse js, 'expr_equal'
+          rule = XRay::JS::Rule::ChecklistRule.new
+          rule.visit_expr_equal expr
+        end
+
+      end
+
+    end
+  end
+end

data/test/js/rule_test.rb

@@ -0,0 +1,47 @@
+gem 'test-unit' if defined? gem
+require 'test/unit'
+require 'test/unit/testsuite'
+require 'test/unit/ui/console/testrunner'
+
+require File.expand_path('../helper', File.dirname(__FILE__))
+
+module XRayTest
+  
+  module JS 
+
+    class RuleTest < Test::Unit::TestSuite
+      
+      NAMES = %w(
+        semicolon_test
+        stat_if_with_brace_test
+        stat_if_with_muti_else_test
+        no_eval_test
+        use_strict_equal_test
+        new_object_and_new_array_test
+        nest_try_catch_test
+        jq_check_test
+        no_global_test
+        all_test
+        file_checker_test
+        alert_check_test
+        private_method_check_test
+      )
+        
+      def self.suite
+        tests = Test::Unit::TestSuite.new
+        NAMES.each do |name|
+          require_relative "rule/#{name}"
+
+          name = name.gsub(/_(\w)/) { |m| m[1].chr.upcase }
+          name = name[0].chr.upcase + name[1..-1]
+
+          tests << Rule.const_get(name).suite
+        end
+        tests
+      end
+    end
+  end
+end
+
+Test::Unit::UI::Console::TestRunner.run(XRayTest::JS::RuleTest) if __FILE__ == $0
+

data/test/js/stat/if.rb

@@ -0,0 +1,26 @@
+module XRayTest
+  module JS
+    module Stat
+
+      module If
+        def test_parse_stat_if
+          js = '
+            if (a === b && c === d) {
+              hello("alibaba");    
+            } else {
+              other("taobao");    
+            }
+          ' 
+
+          stat = parse_js :parse_stat_if, js
+
+          assert_equal 'if', stat.type
+          assert_equal '(&&,(===,a,b),(===,c,d))', stat.condition.text
+          assert_equal '(block,[(expression,((,hello,["alibaba"]),)],)', stat.true_part.text
+          assert_equal '(block,[(expression,((,other,["taobao"]),)],)', stat.false_part.text
+        end
+      end
+      
+    end
+  end
+end