decidim 0.0.2 → 0.0.3

data/decidim-admin/spec/commands/create_static_page_spec.rb

@@ -21,7 +21,7 @@ module Decidim
           it "doesn't create a page" do
             expect do
               command.call
-            end.to_not change { StaticPage.count }
+            end.not_to change { StaticPage.count }
           end
         end
 

data/decidim-admin/spec/commands/destroy_category_spec.rb

@@ -24,7 +24,7 @@ module Decidim
           it "doesn't destroy the category" do
             expect do
               command.call
-            end.to_not change { Category.count }
+            end.not_to change { Category.count }
           end
         end
 

data/decidim-admin/spec/commands/destroy_feature_spec.rb

@@ -9,7 +9,7 @@ module Decidim
       context "when everything is ok" do
         it "destroys the feature" do
           subject.call
-          expect(Feature.where(id: feature.id)).to_not exist
+          expect(Feature.where(id: feature.id)).not_to exist
         end
 
         it "fires the hooks" do
@@ -23,7 +23,7 @@ module Decidim
 
           feature = results[:feature]
           expect(feature.id).to eq(feature.id)
-          expect(feature).to_not be_persisted
+          expect(feature).not_to be_persisted
         end
       end
     end

data/decidim-admin/spec/commands/destroy_participatory_process_step_spec.rb

@@ -32,7 +32,7 @@ describe Decidim::Admin::DestroyParticipatoryProcessStep, class: true do
 
       it "destroys the step" do
         subject.call(inactive_step)
-        expect(inactive_step).to_not be_persisted
+        expect(inactive_step).not_to be_persisted
       end
     end
   end

data/decidim-admin/spec/commands/update_category_spec.rb

@@ -43,7 +43,7 @@ module Decidim
             command.call
             category.reload
 
-            expect(translated(category.name)).to_not eq("New title")
+            expect(translated(category.name)).not_to eq("New title")
           end
         end
 

data/decidim-admin/spec/commands/update_feature_spec.rb

@@ -15,6 +15,7 @@ module Decidim
             ca: "La meva funcionalitat",
             es: "Mi funcionalidad"
           },
+          weight: 3,
           invalid?: !valid,
           valid?: valid,
           settings: {
@@ -39,6 +40,7 @@ module Decidim
           }.to broadcast(:ok)
 
           expect(feature["name"]["en"]).to eq("My feature")
+          expect(feature.weight).to eq(3)
           expect(feature.settings.dummy_global_attribute_1).to eq(true)
           expect(feature.settings.dummy_global_attribute_2).to eq(false)
 
@@ -71,7 +73,7 @@ module Decidim
           }.to broadcast(:invalid)
 
           feature.reload
-          expect(feature.name["en"]).to_not eq("My feature")
+          expect(feature.name["en"]).not_to eq("My feature")
         end
       end
     end

data/decidim-admin/spec/commands/update_organization_spec.rb

@@ -18,7 +18,8 @@ module Decidim
               description_en: "My description",
               description_es: "Mi descripción",
               description_ca: "La meva descripció",
-              show_statistics: false
+              show_statistics: false,
+              favicon: File.new(Decidim::Dev.asset("icon.png"))
             }
           }
         end
@@ -43,7 +44,7 @@ module Decidim
             command.call
             organization.reload
 
-            expect(organization.name).to_not eq("My super organization")
+            expect(organization.name).not_to eq("My super organization")
           end
         end
 
@@ -67,6 +68,15 @@ module Decidim
               expect(organization.homepage_image).to be_present
             end
           end
+
+          context "when there's a favicon in the params" do
+            it "does set a favicon for the organization" do
+              command.call
+              organization.reload
+
+              expect(organization.favicon.small).to be_present
+            end
+          end
         end
       end
     end

data/decidim-admin/spec/commands/update_static_page_spec.rb

@@ -29,7 +29,7 @@ module Decidim
             command.call
             page.reload
 
-            expect(page.slug).to_not eq("new_slug")
+            expect(page.slug).not_to eq("new_slug")
           end
         end
 

data/decidim-admin/spec/features/admin_manages_organization_admins_spec.rb

@@ -64,7 +64,7 @@ describe "Organization admins", type: :feature do
           click_link "Destroy"
         end
 
-        expect(page).to_not have_content(other_admin.name)
+        expect(page).not_to have_content(other_admin.name)
       end
     end
   end

data/decidim-admin/spec/features/admin_manages_organization_scopes_spec.rb

@@ -72,7 +72,7 @@ describe "Organization scopes", type: :feature do
         end
 
         within "table" do
-          expect(page).to_not have_content(scope.name)
+          expect(page).not_to have_content(scope.name)
         end
       end
     end

data/decidim-admin/spec/features/admin_manages_participatory_processes_spec.rb

@@ -88,7 +88,7 @@ describe "Admin manage participatory processes", type: :feature do
       end
 
       within "table" do
-        expect(page).to_not have_content(translated(participatory_process2.title))
+        expect(page).not_to have_content(translated(participatory_process2.title))
       end
     end
   end

data/decidim-admin/spec/features/static_pages_spec.rb

@@ -102,7 +102,7 @@ describe "Content pages", type: :feature do
         end
 
         within "table" do
-          expect(page).to_not have_content(translated(decidim_page.title))
+          expect(page).not_to have_content(translated(decidim_page.title))
         end
       end
 

data/decidim-admin/spec/forms/participatory_process_form_spec.rb

@@ -35,6 +35,7 @@ module Decidim
         }
       end
       let(:slug) { "slug" }
+      let(:attachement) { test_file("city.jpeg", "image/jpeg") }
       let(:attributes) do
         {
           "participatory_process" => {
@@ -50,10 +51,15 @@ module Decidim
             "short_description_en" => short_description[:en],
             "short_description_es" => short_description[:es],
             "short_description_ca" => short_description[:ca],
+            "hero_image" => attachement,
+            "banner_image" => attachement,
             "slug" => slug
           }
         }
       end
+      before do
+        Decidim::AttachmentUploader.enable_processing = true
+      end
 
       subject { described_class.from_params(attributes).with_context(current_organization: organization) }
 
@@ -61,6 +67,30 @@ module Decidim
         it { is_expected.to be_valid }
       end
 
+      context "when hero_image is too big" do
+        before do
+          allow(Decidim).to receive(:maximum_attachment_size).and_return(5.megabytes)
+          expect(subject.hero_image).to receive(:size).twice.and_return(6.megabytes)
+        end
+
+        it { is_expected.not_to be_valid }
+      end
+
+      context "when banner_image is too big" do
+        before do
+          allow(Decidim).to receive(:maximum_attachment_size).and_return(5.megabytes)
+          expect(subject.banner_image).to receive(:size).twice.and_return(6.megabytes)
+        end
+
+        it { is_expected.not_to be_valid }
+      end
+
+      context "when images are not the expected type" do
+        let(:attachement) { test_file("Exampledocument.pdf", "application/pdf") }
+
+        it { is_expected.not_to be_valid }
+      end
+
       context "when some language in title is missing" do
         let(:title) do
           {
@@ -116,8 +146,8 @@ module Decidim
           end
 
           it "is not valid" do
-            expect(subject).to_not be_valid
-            expect(subject.errors[:slug]).to_not be_empty
+            expect(subject).not_to be_valid
+            expect(subject.errors[:slug]).not_to be_empty
           end
         end
 

data/decidim-admin/spec/forms/participatory_process_step_form_spec.rb

@@ -92,9 +92,9 @@ module Decidim
         it "has an error" do
           subject.valid?
 
-          expect(subject.errors).to_not be_empty
-          expect(subject.errors[:end_date]).to_not be_empty
-          expect(subject.errors[:start_date]).to_not be_empty
+          expect(subject.errors).not_to be_empty
+          expect(subject.errors[:end_date]).not_to be_empty
+          expect(subject.errors[:start_date]).not_to be_empty
         end
       end
 

data/decidim-admin/spec/forms/scope_form_spec.rb

@@ -43,8 +43,8 @@ module Decidim
         end
 
         it "is not valid" do
-          expect(subject).to_not be_valid
-          expect(subject.errors[:name]).to_not be_empty
+          expect(subject).not_to be_valid
+          expect(subject.errors[:name]).not_to be_empty
         end
       end
 

data/decidim-admin/spec/forms/static_page_form_spec.rb

@@ -75,8 +75,8 @@ module Decidim
         end
 
         it "is not valid" do
-          expect(subject).to_not be_valid
-          expect(subject.errors[:slug]).to_not be_empty
+          expect(subject).not_to be_valid
+          expect(subject.errors[:slug]).not_to be_empty
         end
       end
 

data/decidim-admin/spec/helpers/feature_settings_helper_spec.rb

@@ -0,0 +1,56 @@
+require "spec_helper"
+
+module Decidim
+  module Admin
+    describe FeatureSettingsHelper do
+      let(:options) { double }
+      let(:attribute) { double(type: type) }
+      let(:type) { :boolean }
+      let(:name) { :test }
+
+      let(:form) do
+        double
+      end
+
+      def render_input
+        helper.settings_attribute_input(form, attribute, name, options)
+      end
+
+      describe "booleans" do
+        let(:type) { :boolean }
+
+        it "is supported" do
+          expect(form).to receive(:check_box).with(:test, options)
+          render_input
+        end
+      end
+
+      describe "numbers" do
+        let(:type) { :integer }
+
+        it "is supported" do
+          expect(form).to receive(:number_field).with(:test, options)
+          render_input
+        end
+      end
+
+      describe "strings" do
+        let(:type) { :string }
+
+        it "is supported" do
+          expect(form).to receive(:text_field).with(:test, options)
+          render_input
+        end
+      end
+
+      describe "texts" do
+        let(:type) { :text }
+
+        it "is supported" do
+          expect(form).to receive(:text_area).with(:test, options)
+          render_input
+        end
+      end
+    end
+  end
+end

data/decidim-admin/spec/models/abilities/admin_user_spec.rb

@@ -4,7 +4,7 @@ require "spec_helper"
 describe Decidim::Admin::Abilities::AdminUser do
   let(:user) { build(:user, :admin) }
 
-  subject { described_class.new(user) }
+  subject { described_class.new(user, {}) }
 
   context "when the user is not an admin" do
     let(:user) { build(:user) }
@@ -17,8 +17,9 @@ describe Decidim::Admin::Abilities::AdminUser do
 
   it { is_expected.to be_able_to(:manage, Decidim::ParticipatoryProcess) }
   it { is_expected.to be_able_to(:manage, Decidim::ParticipatoryProcessStep) }
-  it { is_expected.to be_able_to(:manage, Decidim::ParticipatoryProcessAttachment) }
+  it { is_expected.to be_able_to(:manage, Decidim::Attachment) }
   it { is_expected.to be_able_to(:manage, Decidim::Scope) }
+  it { is_expected.to be_able_to(:manage, :admin_users) }
 
   it { is_expected.to be_able_to(:create, Decidim::StaticPage) }
   it { is_expected.to be_able_to(:update, Decidim::StaticPage) }
@@ -39,10 +40,10 @@ describe Decidim::Admin::Abilities::AdminUser do
     let(:page) { build(:static_page, :default) }
     let(:form) { Decidim::Admin::StaticPageForm.new(slug: page.slug) }
 
-    it { is_expected.to_not be_able_to(:update_slug, page) }
-    it { is_expected.to_not be_able_to(:update_slug, form) }
-    it { is_expected.to_not be_able_to(:destroy, page) }
-    it { is_expected.to_not be_able_to(:destroy, form) }
+    it { is_expected.not_to be_able_to(:update_slug, page) }
+    it { is_expected.not_to be_able_to(:update_slug, form) }
+    it { is_expected.not_to be_able_to(:destroy, page) }
+    it { is_expected.not_to be_able_to(:destroy, form) }
   end
 
   context "when a page is not default one" do

data/decidim-admin/spec/models/abilities/participatory_process_admin_spec.rb

@@ -5,14 +5,9 @@ describe Decidim::Admin::Abilities::ParticipatoryProcessAdmin do
   let(:user) { build(:user) }
   let(:user_process) { create :participatory_process, organization: user.organization }
 
-  subject { described_class.new(user) }
+  subject { described_class.new(user, {}) }
 
   context "when the user does not admin any process" do
-    it "doesn't have any permission" do
-      expect(subject.permissions[:can]).to be_empty
-      expect(subject.permissions[:cannot]).to be_empty
-    end
-
     it { is_expected.not_to be_able_to(:read, :admin_dashboard) }
   end
 
@@ -22,11 +17,11 @@ describe Decidim::Admin::Abilities::ParticipatoryProcessAdmin do
     let(:unmanaged_process_step) { create :participatory_process_step, participatory_process: unmanaged_process }
     let(:user_process_attachment) do
       Decidim::AttachmentUploader.enable_processing = true
-      create :participatory_process_attachment, participatory_process: user_process
+      create :attachment, attached_to: user_process
     end
     let(:unmanaged_process_attachment) do
       Decidim::AttachmentUploader.enable_processing = true
-      create :participatory_process_attachment, participatory_process: unmanaged_process
+      create :attachment, attached_to: unmanaged_process
     end
 
     before do
@@ -41,6 +36,8 @@ describe Decidim::Admin::Abilities::ParticipatoryProcessAdmin do
     it { is_expected.not_to be_able_to(:create, Decidim::ParticipatoryProcess) }
     it { is_expected.not_to be_able_to(:manage, unmanaged_process) }
 
+    it { is_expected.not_to be_able_to(:manage, :admin_users) }
+
     it { is_expected.to be_able_to(:manage, user_process_step) }
     it { is_expected.not_to be_able_to(:manage, unmanaged_process_step) }
 

data/decidim-admin/spec/shared/manage_process_admins_examples.rb

@@ -49,7 +49,7 @@ RSpec.shared_examples "manage process admins examples" do
       end
 
       within "#process_admins table" do
-        expect(page).to_not have_content(other_user.email)
+        expect(page).not_to have_content(other_user.email)
       end
     end
   end

data/decidim-admin/spec/shared/manage_process_attachments_examples.rb

@@ -1,10 +1,9 @@
 # -*- coding: utf-8 -*-
 # frozen_string_literal: true
+require "decidim/admin/test/manage_attachments_examples"
+
 RSpec.shared_examples "manage process attachments examples" do
-  let!(:attachment) do
-    Decidim::AttachmentUploader.enable_processing = true
-    create(:participatory_process_attachment, participatory_process: participatory_process)
-  end
+  let(:attached_to) { participatory_process }
 
   before do
     switch_to_host(organization.host)
@@ -13,94 +12,5 @@ RSpec.shared_examples "manage process attachments examples" do
     click_link "Attachments"
   end
 
-  it "lists all the attachments for the process" do
-    within "#attachments table" do
-      expect(page).to have_content(translated(attachment.title, locale: :en))
-      expect(page).to have_content(attachment.file_type)
-    end
-  end
-
-  it "can view an attachment details" do
-    within "#attachments table" do
-      click_link translated(attachment.title, locale: :en)
-    end
-
-    expect(page).to have_content(stripped(translated(attachment.title, locale: :en)))
-    expect(page).to have_content(stripped(translated(attachment.description, locale: :en)))
-    expect(page).to have_content(attachment.file_type)
-    expect(page).to have_css("img[src~='#{attachment.thumbnail_url}']")
-  end
-
-  it "can add attachments to a process" do
-    find("#attachments .actions .new").click
-
-    within ".new_participatory_process_attachment" do
-      fill_in_i18n(
-        :participatory_process_attachment_title,
-        "#title-tabs",
-        en: "Very Important Document",
-        es: "Documento Muy Importante",
-        ca: "Document Molt Important"
-      )
-
-      fill_in_i18n(
-        :participatory_process_attachment_description,
-        "#description-tabs",
-        en: "This document contains important information",
-        es: "Este documento contiene información importante",
-        ca: "Aquest document conté informació important"
-      )
-
-      attach_file :participatory_process_attachment_file, File.join(File.dirname(__FILE__), "..", "..", "..", "decidim-dev", "spec", "support", "Exampledocument.pdf")
-      find("*[type=submit]").click
-    end
-
-    within ".flash" do
-      expect(page).to have_content("successfully")
-    end
-
-    within "#attachments table" do
-      expect(page).to have_link("Very Important Document")
-    end
-  end
-
-  it "can delete an attachment from a process" do
-    within find("tr", text: stripped(translated(attachment.title))) do
-      click_link "Destroy"
-    end
-
-    within ".flash" do
-      expect(page).to have_content("successfully")
-    end
-
-    expect(page).to_not have_content(translated(attachment.title, locale: :en))
-  end
-
-  it "can update an attachment" do
-    within "#attachments" do
-      within find("tr", text: stripped(translated(attachment.title))) do
-        click_link "Edit"
-      end
-    end
-
-    within ".edit_participatory_process_attachment" do
-      fill_in_i18n(
-        :participatory_process_attachment_title,
-        "#title-tabs",
-        en: "This is a nice photo",
-        es: "Una foto muy guay",
-        ca: "Aquesta foto és ben xula"
-      )
-
-      find("*[type=submit]").click
-    end
-
-    within ".flash" do
-      expect(page).to have_content("successfully")
-    end
-
-    within "#attachments table" do
-      expect(page).to have_link("This is a nice photo")
-    end
-  end
+  it_behaves_like "manage attachments examples"
 end