decidim 0.0.2 → 0.0.3

data/decidim-budgets/spec/commands/remove_line_item_spec.rb

@@ -0,0 +1,31 @@
+require "spec_helper"
+
+describe Decidim::Budgets::RemoveLineItem do
+  let(:user) { create(:user) }
+  let(:feature) { create(:budget_feature, organization: user.organization) }
+  let(:project) { create(:project, feature: feature) }
+  let(:order) { create(:order, user: user, feature: feature) }
+  let(:line_item) { create(:line_item, order: order, project: project) }
+
+  subject { described_class.new(order, project) }
+
+  context "when everything is ok" do
+    it "broadcasts ok" do
+      expect { subject.call }.to broadcast(:ok)
+    end
+
+    it "removes a line item from the order" do
+      subject.call
+      last_order = Decidim::Budgets::Order.last
+      expect(last_order.line_items.collect(&:project)).to be_empty
+    end
+  end
+
+  context "when the order is checked out" do
+    let!(:order) { create(:order,user: user, feature: feature, checked_out_at: Time.zone.now) }
+
+    it "broadcasts invalid" do
+      expect { subject.call }.to broadcast(:invalid)
+    end
+  end
+end

data/decidim-budgets/spec/commands/update_project_spec.rb

@@ -0,0 +1,65 @@
+require "spec_helper"
+
+describe Decidim::Budgets::Admin::UpdateProject do
+  let(:project) { create :project }
+  let(:organization) { project.feature.organization }
+  let(:scope) { create :scope, organization: organization }
+  let(:category) { create :category, participatory_process: project.feature.participatory_process }
+  let(:participatory_process) { project.feature.participatory_process }
+  let(:proposal_feature) do
+    create(:feature, manifest_name: :proposals, participatory_process: participatory_process)
+  end
+  let(:proposals) do
+    create_list(
+      :proposal,
+      3,
+      feature: proposal_feature
+    )
+  end
+  let(:form) do
+    double(
+      :invalid? => invalid,
+      title: {en: "title"},
+      description: {en: "description"},
+      short_description: {en: "short_description"},
+      budget: 10_000_000,
+      proposal_ids: proposals.map(&:id),
+      scope: scope,
+      category: category
+    )
+  end
+  let(:invalid) { false }
+
+  subject { described_class.new(form, project) }
+
+  context "when the form is not valid" do
+    let(:invalid) { true }
+
+    it "is not valid" do
+      expect { subject.call }.to broadcast(:invalid)
+    end
+  end
+
+  context "when everything is ok" do
+    it "updates the project" do
+      subject.call
+      expect(translated(project.title)).to eq "title"
+    end
+
+    it "sets the scope" do
+      subject.call
+      expect(project.scope).to eq scope
+    end
+
+    it "sets the category" do
+      subject.call
+      expect(project.category).to eq category
+    end
+
+    it "links proposals" do
+      subject.call
+      linked_proposals = project.linked_resources(:proposals, "included_proposals")
+      expect(linked_proposals).to match_array(proposals)
+    end
+  end
+end

data/decidim-budgets/spec/factories.rb

@@ -0,0 +1,4 @@
+require "decidim/core/test/factories"
+require "decidim/admin/test/factories"
+require "decidim/budgets/test/factories"
+require "decidim/proposals/test/factories"

data/decidim-budgets/spec/features/admin_manages_projects_spec.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+require_relative "../shared/admin_shared_context"
+require_relative "../shared/manage_projects_examples"
+
+describe "Admin manages projects", type: :feature do
+  include_context "admin"
+  it_behaves_like "manage projects"
+
+  before do
+    switch_to_host(organization.host)
+    login_as user, scope: :user
+    visit decidim_admin.manage_feature_path(participatory_process_id: participatory_process, feature_id: current_feature)
+  end
+end

data/decidim-budgets/spec/features/orders_spec.rb

@@ -0,0 +1,149 @@
+# frozen_string_literal: true
+require "spec_helper"
+
+describe "Orders", type: :feature do
+  include_context "feature"
+  let(:manifest_name) { "budgets" }
+
+  let!(:user) { create :user, :confirmed, organization: organization }
+  let!(:projects) { create_list(:project, 3, feature: feature, budget: 25_000_000) }
+  let(:project) { projects.first }
+
+  let!(:feature) do
+    create(:budget_feature,
+           :with_total_budget_and_vote_threshold_percent,
+           manifest: manifest,
+           participatory_process: participatory_process)
+  end
+
+  context "when the user is not logged in" do
+    it "is given the option to sign in" do
+      visit_feature
+
+      within "#project-#{project.id}-item" do
+        page.find('.budget--list__action').click
+      end
+
+      expect(page).to have_css('#loginModal', visible: true)
+    end
+  end
+
+  context "when the user is logged in" do
+    before do
+      login_as user, scope: :user
+      visit_feature
+    end
+
+    context "and has not a pending order" do
+      it "adds a project to the current order" do
+        within "#project-#{project.id}-item" do
+          page.find('.budget--list__action').click
+        end
+
+        expect(page).to have_selector '.budget-list__data--added', count: 1
+
+        expect(page).to have_content "ASSIGNED: €25,000,000"
+        expect(page).to have_content "1 project selected"
+
+        within ".budget-summary__selected" do
+          expect(page).to have_content project.title[I18n.locale]
+        end
+
+        within ".budget-summary__progressbox" do
+          expect(page).to have_content "25%"
+          expect(page).to have_selector("button.small:disabled")
+        end
+      end
+    end
+
+    context "and has pending order" do
+      let!(:order) { create(:order, user: user, feature: feature) }
+      let!(:line_item) { create(:line_item, order: order, project: project) }
+
+      it "removes a project from the current order" do
+        visit_feature
+        expect(page).to have_content "ASSIGNED: €25,000,000"
+
+        within "#project-#{project.id}-item" do
+          page.find('.budget--list__action').click
+        end
+
+        expect(page).to have_content "ASSIGNED: €0"
+        expect(page).not_to have_content "1 project selected"
+        expect(page).not_to have_selector ".budget-summary__selected"
+
+        within ".budget-summary__progressbox" do
+          expect(page).to have_content "0%"
+        end
+
+        expect(page).not_to have_selector '.budget-list__data--added'
+      end
+
+      context "and try to vote a project that exceed the total budget" do
+        let!(:expensive_project) { create(:project, feature: feature, budget: 250_000_000) }
+
+        it "cannot add the project" do
+          visit_feature
+
+          within "#project-#{expensive_project.id}-item" do
+            page.find('.budget--list__action').click
+          end
+
+          expect(page).to have_css('#budget-excess', visible: true)
+        end
+      end
+
+      context "and add another project exceeding vote threshold" do
+        let!(:other_project) { create(:project, feature: feature, budget: 50_000_000) }
+
+        it "can complete the checkout process" do
+          visit_feature
+
+          within "#project-#{other_project.id}-item" do
+            page.find('.budget--list__action').click
+          end
+
+          expect(page).to have_selector '.budget-list__data--added', count: 2
+
+          within ".budget-summary__progressbox" do
+            page.find('.button.small').click
+          end
+
+          expect(page).to have_css('#budget-confirm', visible: true)
+
+          within "#budget-confirm" do
+            page.find('.button.expanded').click
+          end
+
+          expect(page).to have_content("successfully")
+
+          within ".budget-summary__progressbox" do
+            expect(page).not_to have_selector("button.small")
+          end
+        end
+      end
+    end
+
+    context "and has a finished order" do
+      let!(:order) { create(:order, user: user, feature: feature, checked_out_at: Time.current) }
+
+      it "can cancel the order" do
+        visit_feature
+
+        within ".budget-summary" do
+          page.find('.cancel-order').click
+        end
+
+        expect(page).to have_content("successfully")
+
+        within ".budget-summary__progressbox" do
+          expect(page).to have_selector("button.small:disabled")
+        end
+
+        within ".budget-summary" do
+          expect(page).not_to have_selector('.cancel-order')
+        end
+      end
+    end
+  end
+end

data/decidim-budgets/spec/features/process_admin_manages_projects_spec.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+require_relative "../shared/admin_shared_context"
+require_relative "../shared/manage_projects_examples"
+
+describe "Process admin manages projects", type: :feature do
+  include_context "admin"
+  let(:user) { process_admin }
+  it_behaves_like "manage projects"
+
+  before do
+    switch_to_host(organization.host)
+    login_as user, scope: :user
+    visit decidim_admin.manage_feature_path(participatory_process_id: participatory_process, feature_id: current_feature)
+  end
+end

data/decidim-budgets/spec/forms/project_form_spec.rb

@@ -0,0 +1,115 @@
+# frozen_literal_string: true
+
+require "spec_helper"
+
+describe Decidim::Budgets::Admin::ProjectForm do
+  let(:organization) { create(:organization, available_locales: [:en]) }
+  let(:context) do
+    {
+      current_organization: organization,
+      current_feature: current_feature
+    }
+  end
+  let(:participatory_process) { create :participatory_process, organization: organization }
+  let(:current_feature) { create :budget_feature, participatory_process: participatory_process }
+  let(:title) do
+    Decidim::Faker::Localized.sentence(3)
+  end
+  let(:description) do
+    Decidim::Faker::Localized.sentence(3)
+  end
+  let(:short_description) do
+    Decidim::Faker::Localized.sentence(3)
+  end
+  let(:budget) { Faker::Number.number(8) }
+  let(:scope) { create :scope, organization: organization }
+  let(:scope_id) { scope.id }
+  let(:category) { create :category, participatory_process: participatory_process }
+  let(:category_id) { category.id }
+  let(:attributes) do
+    {
+      decidim_scope_id: scope_id,
+      decidim_category_id: category_id,
+      title_en: title[:en],
+      description_en: description[:en],
+      short_description_en: short_description[:en],
+      budget: budget
+    }
+  end
+
+  subject { described_class.from_params(attributes).with_context(context) }
+
+  it { is_expected.to be_valid }
+
+  describe "when title is missing" do
+    let(:title) { { en: nil } }
+
+    it { is_expected.not_to be_valid }
+  end
+
+  describe "when description is missing" do
+    let(:description) { { en: nil } }
+
+    it { is_expected.not_to be_valid }
+  end
+
+  describe "when short_description is missing" do
+    let(:short_description) { { en: nil } }
+
+    it { is_expected.not_to be_valid }
+  end
+
+  describe "when budget is missing" do
+    let(:budget) { nil }
+
+    it { is_expected.not_to be_valid }
+  end
+
+  describe "when budget is less or equal 0" do
+    let(:budget) { 0 }
+
+    it { is_expected.not_to be_valid }
+  end
+
+  describe "when the scope does not exist" do
+    let(:scope_id) { scope.id + 10 }
+
+    it { is_expected.not_to be_valid }
+  end
+
+  describe "when the category does not exist" do
+    let(:category_id) { category.id + 10 }
+
+    it { is_expected.not_to be_valid }
+  end
+
+  context "with proposals" do
+    let(:proposals_feature) { create :feature, manifest_name: :proposals, participatory_process: participatory_process }
+    let!(:proposal) { create :proposal, feature: proposals_feature }
+
+    describe "#proposals" do
+      it "returns the available proposals in a way suitable for the form" do
+        expect(subject.proposals)
+          .to eq([[proposal.title, proposal.id]])
+      end
+    end
+
+    describe "#map_model" do
+      let(:project) do
+        create(
+          :project,
+          feature: current_feature,
+          scope: scope,
+          category: category
+        )
+      end
+
+      subject { described_class.from_model(project).with_context(context) }
+
+      it "sets the proposal_ids correctly" do
+        project.link_resources([proposal], "included_proposals")
+        expect(subject.proposal_ids).to eq [proposal.id]
+      end
+    end
+  end
+end

data/decidim-budgets/spec/models/line_item_spec.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+describe Decidim::Budgets::LineItem do
+  let(:line_item) { build :line_item }
+  subject { line_item }
+
+  describe "validations" do
+    it "is valid" do
+      expect(subject).to be_valid
+    end
+
+    it "is invalid when order is not present" do
+      subject.order = nil
+      expect(subject).to be_invalid
+    end
+
+    it "is invalid when project is not present" do
+      subject.project = nil
+      expect(subject).to be_invalid
+    end
+
+    it "is invalid when the same litem item exists" do
+      subject.save
+      new_line_item = build :line_item, order: subject.order, project: subject.project
+      expect(new_line_item).to be_invalid
+    end
+
+    it "is invalid when order and project are from a different feature" do
+      subject.order = build(:order)
+      expect(subject).to be_invalid
+    end
+  end
+end

data/decidim-budgets/spec/models/order_spec.rb

@@ -0,0 +1,45 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+describe Decidim::Budgets::Order do
+  let(:order) { build :order }
+  subject { order }
+
+  describe "validations" do
+    it "is valid" do
+      expect(subject).to be_valid
+    end
+
+    it "is invalid when user is not present" do
+      subject.user = nil
+      expect(subject).to be_invalid
+    end
+
+    it "is invalid when feature is not present" do
+      subject.feature = nil
+      expect(subject).to be_invalid
+    end
+
+    it "is unique for each user and feature" do
+      subject.save
+      new_order = build :order, user: subject.user, feature: subject.feature
+      expect(new_order).to be_invalid
+    end
+  end
+
+  describe "#total_budget" do
+    it "returns the sum of project budgets" do
+      subject.projects << build(:project, feature: subject.feature)
+
+      expect(subject.total_budget).to eq(subject.projects.sum(&:budget))
+    end
+  end
+
+  describe "#checked_out?" do
+    it "returns true if the checked_out_at attribute is present" do
+      subject.checked_out_at = Time.zone.now
+      expect(subject).to be_checked_out
+    end
+  end
+end