decidim 0.0.2 → 0.0.3

data/decidim-results/spec/features/process_admin_manages_results_spec.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+require_relative "../shared/admin_shared_context"
+require_relative "../shared/manage_results_examples"
+
+describe "Process admin manages results", type: :feature do
+  include_context "admin"
+  let(:user) { process_admin }
+  it_behaves_like "manage results"
+
+  before do
+    switch_to_host(organization.host)
+    login_as user, scope: :user
+    visit decidim_admin.manage_feature_path(participatory_process_id: participatory_process, feature_id: current_feature)
+  end
+end

data/decidim-results/spec/forms/result_form_spec.rb

@@ -0,0 +1,91 @@
+# frozen_literal_string: true
+
+require "spec_helper"
+
+describe Decidim::Results::Admin::ResultForm do
+  let(:organization) { create(:organization, available_locales: [:en]) }
+  let(:context) do
+    {
+      current_organization: organization,
+      current_feature: current_feature
+    }
+  end
+  let(:participatory_process) { create :participatory_process, organization: organization }
+  let(:current_feature) { create :feature, participatory_process: participatory_process, manifest_name: "results" }
+  let(:title) do
+    Decidim::Faker::Localized.sentence(3)
+  end
+  let(:description) do
+    Decidim::Faker::Localized.sentence(3)
+  end
+  let(:scope) { create :scope, organization: organization }
+  let(:scope_id) { scope.id }
+  let(:category) { create :category, participatory_process: participatory_process }
+  let(:category_id) { category.id }
+  let(:attributes) do
+    {
+      decidim_scope_id: scope_id,
+      decidim_category_id: category_id,
+      title_en: title[:en],
+      description_en: description[:en],
+    }
+  end
+
+  subject { described_class.from_params(attributes).with_context(context) }
+
+  it { is_expected.to be_valid }
+
+  describe "when title is missing" do
+    let(:title) { { en: nil } }
+
+    it { is_expected.not_to be_valid }
+  end
+
+  describe "when description is missing" do
+    let(:description) { { en: nil } }
+
+    it { is_expected.not_to be_valid }
+  end
+
+  describe "when the scope does not exist" do
+    let(:scope_id) { scope.id + 10 }
+
+    it { is_expected.not_to be_valid }
+  end
+
+  describe "when the category does not exist" do
+    let(:category_id) { category.id + 10 }
+
+    it { is_expected.not_to be_valid }
+  end
+
+  context "with proposals" do
+    let(:proposals_feature) { create :feature, manifest_name: :proposals, participatory_process: participatory_process }
+    let!(:proposal) { create :proposal, feature: proposals_feature }
+
+    describe "#proposals" do
+      it "returns the available proposals in a way suitable for the form" do
+        expect(subject.proposals)
+          .to eq([[proposal.title, proposal.id]])
+      end
+    end
+
+    describe "#map_model" do
+      let(:result) do
+        create(
+          :result,
+          feature: current_feature,
+          scope: scope,
+          category: category
+        )
+      end
+
+      subject { described_class.from_model(result).with_context(context) }
+
+      it "sets the proposal_ids correctly" do
+        result.link_resources([proposal], "included_proposals")
+        expect(subject.proposal_ids).to eq [proposal.id]
+      end
+    end
+  end
+end

data/decidim-results/spec/models/result_spec.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Decidim
+  module Results
+    describe Result do
+      let(:result) { build :result }
+      subject { result }
+
+      it { is_expected.to be_valid }
+
+      include_examples "has feature"
+      include_examples "has scope"
+      include_examples "has category"
+    end
+  end
+end

data/decidim-results/spec/services/result_search_spec.rb

@@ -0,0 +1,97 @@
+require "spec_helper"
+
+describe Decidim::Results::ResultSearch do
+  let(:current_feature) { create :feature, manifest_name: "results" }
+  let(:scope1) { create :scope, organization: current_feature.organization }
+  let(:scope2) { create :scope, organization: current_feature.organization }
+  let(:parent_category) { create :category, participatory_process: current_feature.participatory_process }
+  let(:subcategory) { create :subcategory, parent: parent_category }
+  let!(:result1) do
+    create(
+      :result,
+      feature: current_feature,
+      category: parent_category,
+      scope: scope1
+    )
+  end
+  let!(:result2) do
+    create(
+      :result,
+      feature: current_feature,
+      category: subcategory,
+      scope: scope2
+    )
+  end
+  let(:external_result) { create :result }
+  let(:feature_id) { current_feature.id }
+  let(:organization_id) { current_feature.organization.id }
+  let(:default_params) { { feature: current_feature } }
+  let(:params) { default_params }
+
+  subject { described_class.new(params) }
+
+  describe "base query" do
+    context "when no feature is passed" do
+      let(:default_params) { { feature: nil } }
+
+      it "raises an error" do
+        expect{ subject.results }.to raise_error(StandardError, "Missing feature")
+      end
+    end
+  end
+
+  describe "filters" do
+    context "feature_id" do
+      it "only returns results from the given feature" do
+        external_result = create(:result)
+
+        expect(subject.results).not_to include(external_result)
+      end
+    end
+
+    context "scope_id" do
+      context "when a single id is being sent" do
+        let(:params) { default_params.merge(scope_id: scope1.id) }
+
+        it "filters results by scope" do
+          expect(subject.results).to eq [result1]
+        end
+      end
+
+      context "when multiple ids are sent" do
+        let(:params) { default_params.merge(scope_id: [scope2.id, scope1.id]) }
+
+        it "filters results by scope" do
+          expect(subject.results).to match_array [result1,result2]
+        end
+      end
+    end
+
+    context "category_id" do
+      context "when the given category has no subcategories" do
+        let(:params) { default_params.merge(category_id: subcategory.id) }
+
+        it "returns only results from the given category" do
+          expect(subject.results).to eq [result2]
+        end
+      end
+
+      context "when the given category has some subcategories" do
+        let(:params) { default_params.merge(category_id: parent_category.id) }
+
+        it "returns results from this category and its children's" do
+          expect(subject.results).to match_array [result2, result1]
+        end
+      end
+
+      context "when the category does not belong to the current feature" do
+        let(:external_category) { create :category }
+        let(:params) { default_params.merge(category_id: external_category.id) }
+
+        it "returns an empty array" do
+          expect(subject.results).to eq []
+        end
+      end
+    end
+  end
+end

data/decidim-results/spec/services/result_stats_calculator_spec.rb

@@ -0,0 +1,93 @@
+require "spec_helper"
+
+describe Decidim::Results::ResultStatsCalculator do
+  let(:current_feature) { create :feature, manifest_name: :results }
+  let(:participatory_process) { current_feature.participatory_process }
+  let(:scope) { create :scope, organization: current_feature.organization }
+  let(:parent_category) { create :category, participatory_process: current_feature.participatory_process }
+  let!(:result) do
+    create(
+      :result,
+      feature: current_feature,
+      category: parent_category,
+      scope: scope
+    )
+  end
+  let(:meetings_feature) do
+    create(:feature, manifest_name: :meetings, participatory_process: participatory_process)
+  end
+  let(:meetings) do
+    create_list(
+      :meeting,
+      3,
+      feature: meetings_feature,
+      attendees_count: 2,
+      contributions_count: 5
+    )
+  end
+  let(:proposals_feature) do
+    create(:feature, manifest_name: :proposals, participatory_process: participatory_process)
+  end
+  let(:proposals) do
+    create_list(
+      :proposal,
+      3,
+      feature: proposals_feature
+    )
+  end
+
+  before do
+    result.link_resources(proposals, "included_proposals")
+    result.link_resources(meetings, "meetings_through_proposals")
+  end
+
+  subject { described_class.new(result) }
+
+  describe "meetings_count" do
+    it "counts the related meetings" do
+      expect(subject.meetings_count).to eq 3
+    end
+  end
+
+  describe "attendees_count" do
+    it "counts the attendees of the related meetings" do
+      expect(subject.attendees_count).to eq 6
+    end
+  end
+
+  describe "contributions_count" do
+    it "counts the contributions of the related meetings" do
+      expect(subject.contributions_count).to eq 15
+    end
+  end
+
+  describe "proposals_count" do
+    it "counts the related proposals" do
+      expect(subject.proposals_count).to eq 3
+    end
+  end
+
+  describe "votes_count" do
+    before do
+      proposals.each do |proposal|
+        create(:proposal_vote, proposal: proposal)
+      end
+    end
+
+    it "counts the votes of the related proposals" do
+      expect(subject.votes_count).to eq 3
+    end
+  end
+
+  describe "comments_count" do
+    before do
+      proposals.each do |proposal|
+        create(:comment, commentable: proposal)
+      end
+    end
+
+    it "counts the comments of the related proposals" do
+      expect(subject.proposals_count).to eq 3
+    end
+  end
+end

data/decidim-results/spec/shared/admin_shared_context.rb

@@ -0,0 +1,11 @@
+RSpec.shared_context "admin" do
+  let(:organization) { create(:organization) }
+  let!(:user) { create(:user, :admin, :confirmed, organization: organization, email: "admin@decidim.org") }
+  let(:participatory_process) { create(:participatory_process, organization: organization) }
+  let(:process_admin) { create :user, :confirmed, organization: organization }
+  let!(:user_role) { create :participatory_process_user_role, user: process_admin, participatory_process: participatory_process }
+  let(:current_feature) { create :feature, participatory_process: participatory_process, manifest_name: "results" }
+  let(:scope) { create :scope, organization: organization }
+  let!(:category) { create :category, participatory_process: participatory_process }
+  let!(:result) { create :result, scope: scope, feature: current_feature }
+end

data/decidim-results/spec/shared/manage_results_examples.rb

@@ -0,0 +1,96 @@
+# -*- coding: utf-8 -*-
+# frozen_string_literal: true
+RSpec.shared_examples "manage results" do
+  it "updates a result" do
+    within find("tr", text: translated(result.title)) do
+      click_link "Edit"
+    end
+
+    within ".edit_result" do
+      fill_in_i18n(
+        :result_title,
+        "#title-tabs",
+        en: "My new title",
+        es: "Mi nuevo título",
+        ca: "El meu nou títol"
+      )
+
+      find("*[type=submit]").click
+    end
+
+    within ".flash" do
+      expect(page).to have_content("successfully")
+    end
+
+    within "table" do
+      expect(page).to have_content("My new title")
+    end
+  end
+
+  context "previewing results" do
+    it "allows the user to preview the result" do
+      new_window = window_opened_by { click_link translated(result.title) }
+
+      within_window new_window do
+        expect(current_path).to eq decidim_results.result_path(id: result.id, participatory_process_id: participatory_process.id, feature_id: current_feature.id)
+        expect(page).to have_content(translated(result.title))
+      end
+    end
+  end
+
+  it "creates a new result" do
+    find(".actions .new").click
+
+    within ".new_result" do
+      fill_in_i18n(
+        :result_title,
+        "#title-tabs",
+        en: "My result",
+        es: "Mi result",
+        ca: "El meu result"
+      )
+      fill_in_i18n_editor(
+        :result_description,
+        "#description-tabs",
+        en: "A longer description",
+        es: "Descripción más larga",
+        ca: "Descripció més llarga"
+      )
+
+      select scope.name, from: :result_decidim_scope_id
+      select translated(category.name), from: :result_decidim_category_id
+
+      find("*[type=submit]").click
+    end
+
+    within ".flash" do
+      expect(page).to have_content("successfully")
+    end
+
+    within "table" do
+      expect(page).to have_content("My result")
+    end
+  end
+
+  context "deleting a result" do
+    let!(:result2) { create(:result, feature: current_feature) }
+
+    before do
+      visit current_path
+    end
+
+    it "deletes a result" do
+      within find("tr", text: translated(result2.title)) do
+        click_link "Delete"
+      end
+
+      within ".flash" do
+        expect(page).to have_content("successfully")
+      end
+
+      within "table" do
+        expect(page).not_to have_content(translated(result2.title))
+      end
+    end
+  end
+end

data/decidim-results/spec/spec_helper.rb

@@ -0,0 +1,2 @@
+ENV["ENGINE_NAME"] = File.dirname(File.dirname(__FILE__)).split("/").last
+require "decidim/dev/test/base_spec_helper"

data/decidim-system/app/assets/javascripts/decidim/system/application.js.es6

@@ -1,11 +1,9 @@
 // = require jquery
 // = require jquery_ujs
 // = require foundation
-// = require turbolinks
 // = require decidim/editor
 // = require_self
 
-$(document).on('turbolinks:load', () => {
+$(() => {
   $(document).foundation();
 });
-