decidim 0.0.2 → 0.0.3

data/decidim-meetings/spec/controllers/meetings_controller_spec.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+require "spec_helper"
+
+module Decidim
+  module Meetings
+    describe MeetingsController, type: :controller do
+      let(:organization) { create(:organization) }
+      let(:feature) { create(:feature, organization: organization, manifest_name: "meetings") }
+      let(:meeting) { create(:meeting, feature: feature) }
+
+      load_routes Decidim::Meetings::ListEngine
+
+      before do
+        @request.env["decidim.current_organization"] = organization
+        @request.env["decidim.current_participatory_process"] = feature.participatory_process
+        @request.env["decidim.current_feature"] = feature
+      end
+
+      describe "GET static_map" do
+        let(:params) do
+          {
+            id: meeting.id,
+            feature_id: feature.id,
+            participatory_process_id: feature.participatory_process.id
+          }
+        end
+        let(:data) { "1234" }
+
+        it "generates a static map image data using the StaticMapGenerator" do
+          generator = double()
+
+          expect(StaticMapGenerator).to receive(:new).with(meeting).and_return(generator)
+          expect(generator).to receive(:data).and_return(data)
+          expect(controller).to receive(:send_data).with(data, type: "image/jpeg", disposition: "inline")
+
+          get :static_map, format: "image/jpeg", params: params
+        end
+      end
+    end
+  end
+end

data/decidim-meetings/spec/factories.rb

@@ -1,16 +1,6 @@
 require "decidim/core/test/factories"
 require "decidim/admin/test/factories"
+require "decidim/proposals/test/factories"
+require "decidim/results/test/factories"
 
-FactoryGirl.define do
-  factory :meeting, class: Decidim::Meetings::Meeting do
-    title { Decidim::Faker::Localized.sentence(3) }
-    description { Decidim::Faker::Localized.wrapped("<p>", "</p>") { Decidim::Faker::Localized.sentence(4) } }
-    short_description { Decidim::Faker::Localized.wrapped("<p>", "</p>") { Decidim::Faker::Localized.sentence(4) } }
-    location { Decidim::Faker::Localized.wrapped("<p>", "</p>") { Decidim::Faker::Localized.sentence(4) } }
-    location_hints { Decidim::Faker::Localized.wrapped("<p>", "</p>") { Decidim::Faker::Localized.sentence(4) } }
-    address { Faker::Lorem.sentence(3) }
-    start_time { 1.day.from_now }
-    end_time { start_time.advance(hours: 2) }
-    feature
-  end
-end
+require "decidim/meetings/test/factories"

data/decidim-meetings/spec/features/admin_manages_meetings_attachments_spec.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+require_relative "../shared/admin_shared_context"
+require_relative "../shared/manage_attachments_examples"
+
+describe "Admin manages meetings attachments", type: :feature do
+  include_context "admin"
+  it_behaves_like "manage meetings attachments"
+end

data/decidim-meetings/spec/features/explore_meetings_spec.rb

@@ -40,7 +40,6 @@ describe "Explore meetings", type: :feature do
     it "shows all meeting info" do
       expect(page).to have_i18n_content(meeting.title)
       expect(page).to have_i18n_content(meeting.description)
-      expect(page).to have_i18n_content(meeting.short_description)
       expect(page).to have_i18n_content(meeting.location)
       expect(page).to have_i18n_content(meeting.location_hints)
       expect(page).to have_content(meeting.address)
@@ -103,5 +102,60 @@ describe "Explore meetings", type: :feature do
         expect(page).to have_checked_field(meeting.scope.name)
       end
     end
+
+    context "with linked proposals" do
+      let(:proposal_feature) do
+        create(:feature, manifest_name: :proposals, participatory_process: meeting.feature.participatory_process)
+      end
+      let(:proposals) { create_list(:proposal, 3, feature: proposal_feature) }
+
+      before do
+        meeting.link_resources(proposals, "proposals_from_meeting")
+        visit current_path
+      end
+
+      it "shows related proposals" do
+        proposals.each do |proposal|
+          expect(page).to have_content(proposal.title)
+          expect(page).to have_content(proposal.author_name)
+          expect(page).to have_content(proposal.votes.size)
+        end
+      end
+    end
+
+    context "with linked results" do
+      let(:result_feature) do
+        create(:feature, manifest_name: :results, participatory_process: meeting.feature.participatory_process)
+      end
+      let(:results) { create_list(:result, 3, feature: result_feature) }
+
+      before do
+        meeting.link_resources(results, "meetings_through_proposals")
+        visit current_path
+      end
+
+      it "shows related results" do
+        results.each do |result|
+          expect(page).to have_i18n_content(result.title)
+        end
+      end
+    end
+
+    let(:attached_to) { meeting }
+    it_behaves_like "has attachments"
+
+    context "when the meeting is closed" do
+      let(:meeting) { create(:meeting, :closed, feature: current_feature) }
+
+      it "shows the closing report" do
+        expect(page).to have_i18n_content(meeting.closing_report)
+
+        within ".definition-data" do
+          expect(page).to have_content(meeting.attendees_count)
+          expect(page).to have_content(meeting.contributions_count)
+          expect(page).to have_content(meeting.attending_organizations)
+        end
+      end
+    end
   end
 end

data/decidim-meetings/spec/features/process_admin_manages_meetings_attachments_spec.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+require_relative "../shared/admin_shared_context"
+require_relative "../shared/manage_attachments_examples"
+
+describe "Process admin manages meetings attachments", type: :feature do
+  include_context "admin"
+  let(:user) { process_admin }
+
+  it_behaves_like "manage meetings attachments"
+end

data/decidim-meetings/spec/forms/close_meeting_form_spec.rb

@@ -0,0 +1,90 @@
+# -*- coding: utf-8 -*-
+# frozen_literal_string: true
+
+require "spec_helper"
+
+module Decidim
+  module Meetings
+    module Admin
+      describe CloseMeetingForm do
+        let(:meeting) { create(:meeting) }
+        let(:attributes) do
+          {
+            closing_report: closing_report,
+            attendees_count: attendees_count,
+            contributions_count: contributions_count,
+            attending_organizations: attending_organizations
+          }
+        end
+        let(:closing_report) { { en: "It went great", ca: "Ha anat molt bé", es: "Ha ido muy bien" } }
+        let(:attendees_count) { 10 }
+        let(:contributions_count) { 20 }
+        let(:attending_organizations) { "Foo, bar & baz" }
+        let(:context) { { current_organization: meeting.organization } }
+
+        subject { described_class.from_params(attributes).with_context(context) }
+
+        it { is_expected.to be_valid }
+
+        describe "closed_at" do
+          it "is set by default" do
+            expect(subject.closed_at).to be_kind_of(Time)
+          end
+        end
+
+        describe "when closing_report is missing" do
+          let(:closing_report) { { en: nil } }
+
+          it { is_expected.not_to be_valid }
+        end
+
+        describe "when attendees_count is missing" do
+          let(:attendees_count) { nil }
+
+          it { is_expected.not_to be_valid }
+        end
+
+        describe "when attendees_count is invalid" do
+          let(:attendees_count) { "a" }
+
+          it { is_expected.not_to be_valid }
+        end
+
+        describe "when contributions_count is missing" do
+          let(:contributions_count) { nil }
+
+          it { is_expected.not_to be_valid }
+        end
+
+        describe "when contributions_count is invalid" do
+          let(:contributions_count) { "a" }
+
+          it { is_expected.not_to be_valid }
+        end
+
+        describe "map_model" do
+          let(:proposal_feature) do
+            create(:feature, manifest_name: :proposals, participatory_process: meeting.feature.participatory_process)
+          end
+          let(:proposals) { create_list(:proposal, 3, feature: proposal_feature) }
+          let(:meeting) { create(:meeting) }
+          before do
+            meeting.link_resources(proposals, "proposals_from_meeting")
+          end
+
+          subject { described_class.from_model(meeting) }
+
+          it "sets the proposals scope" do
+            expect(subject.proposals).to match_array(proposals)
+          end
+
+          context "when the meeting is already linked to some proposals" do
+            it "sets the proposal_ids" do
+              expect(subject.proposal_ids).to match_array(proposals.map(&:id))
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/decidim-meetings/spec/forms/meeting_form_spec.rb

@@ -11,7 +11,7 @@ describe Decidim::Meetings::Admin::MeetingForm do
     }
   end
   let(:participatory_process) { create :participatory_process, organization: organization }
-  let(:current_feature) { create :feature, participatory_process: participatory_process }
+  let(:current_feature) { create :feature, participatory_process: participatory_process, manifest_name: "meetings" }
   let(:title) do
     Decidim::Faker::Localized.sentence(3)
   end
@@ -65,12 +65,6 @@ describe Decidim::Meetings::Admin::MeetingForm do
     it { is_expected.not_to be_valid }
   end
 
-  describe "when short_description is missing" do
-    let(:short_description) { { en: nil } }
-
-    it { is_expected.not_to be_valid }
-  end
-
   describe "when location is missing" do
     let(:location) { { en: nil } }
 

data/decidim-meetings/spec/models/meeting_spec.rb

@@ -2,29 +2,47 @@
 
 require "spec_helper"
 
-describe Decidim::Meetings::Meeting do
-  let(:meeting) { build :meeting }
-  subject { meeting }
-
-  it { is_expected.to be_valid }
-
-  context "without a title" do
-    let(:meeting) { build :meeting, title: nil }
-
-    it { is_expected.not_to be_valid }
-  end
-
-  context "when the scope is from another organization" do
-    let(:scope) { create :scope }
-    let(:meeting) { build :meeting, scope: scope }
-
-    it { is_expected.not_to be_valid }
-  end
-
-  context "when the category is from another organization" do
-    let(:category) { create :category }
-    let(:meeting) { build :meeting, category: category }
-
-    it { is_expected.not_to be_valid }
+module Decidim
+  module Meetings
+    describe Meeting do
+      let(:address) { ::Faker::Lorem.sentence(3) }
+      let(:meeting) { build :meeting, address: address }
+
+      subject { meeting }
+
+      it { is_expected.to be_valid }
+
+      include_examples "has feature"
+      include_examples "has scope"
+      include_examples "has category"
+
+      context "without a title" do
+        let(:meeting) { build :meeting, title: nil }
+
+        it { is_expected.not_to be_valid }
+      end
+
+      context "when geocoding is enabled" do
+        let(:address) { "Carrer del Pare Llaurador, 113" }
+        let(:latitude) { 40.1234 }
+        let(:longitude) { 2.1234 }
+
+        before do
+          Geocoder::Lookup::Test.add_stub(
+            address,
+            [{
+              "latitude" => latitude,
+              "longitude" => longitude
+            }]
+          )
+        end
+
+        it "geocodes address and find latitude and longitude" do
+          subject.geocode
+          expect(subject.latitude).to eq(latitude)
+          expect(subject.longitude).to eq(longitude)
+        end
+      end
+    end
   end
 end

data/decidim-meetings/spec/services/meeting_search_spec.rb

@@ -1,7 +1,7 @@
 require "spec_helper"
 
 describe Decidim::Meetings::MeetingSearch do
-  let(:current_feature) { create :feature }
+  let(:current_feature) { create :feature, manifest_name: "meetings" }
   let(:scope1) { create :scope, organization: current_feature.organization }
   let(:scope2) { create :scope, organization: current_feature.organization }
   let(:parent_category) { create :category, participatory_process: current_feature.participatory_process }
@@ -127,20 +127,4 @@ describe Decidim::Meetings::MeetingSearch do
       end
     end
   end
-
-  context "pagination" do
-    let(:params) do
-      default_params.merge(
-        per_page: 2
-      )
-    end
-
-    it "filters the meetings per page" do
-      create(:meeting, feature: current_feature)
-      meetings = subject.results
-
-      expect(meetings.total_pages).to eq(2)
-      expect(meetings.total_count).to eq(3)
-    end
-  end
 end

data/decidim-meetings/spec/services/static_map_generator_spec.rb

@@ -0,0 +1,33 @@
+require "spec_helper"
+
+module Decidim
+  module Meetings
+    describe StaticMapGenerator do
+      let(:meeting) { create(:meeting) }
+      let(:options) do
+        {
+          zoom: 10,
+          width: 200,
+          height: 200
+        }
+      end
+      let(:body) { "1234" }
+      subject { described_class.new(meeting, options) }
+
+      before do
+        Decidim.geocoder = {
+          here_app_id: '1234',
+          here_app_code: '5678'
+        }
+
+        stub_request(:get, Regexp.new(StaticMapGenerator::BASE_HOST)).to_return(body: body)
+      end
+
+      describe "#data" do
+        it "returns the request body" do
+          expect(subject.data).to eq(body)
+        end
+      end
+    end
+  end
+end

data/decidim-meetings/spec/shared/manage_attachments_examples.rb

@@ -0,0 +1,17 @@
+require "decidim/admin/test/manage_attachments_examples"
+
+RSpec.shared_examples "manage meetings attachments" do
+  let(:attached_to) { meeting }
+
+  before do
+    switch_to_host(organization.host)
+    login_as user, scope: :user
+    visit decidim_admin.manage_feature_path(participatory_process_id: participatory_process, feature_id: current_feature)
+    within find("tr", text: translated(meeting.title)) do
+
+      click_link "Attachments"
+    end
+  end
+
+  it_behaves_like "manage attachments examples"
+end

data/decidim-meetings/spec/shared/manage_meetings_examples.rb

@@ -63,13 +63,6 @@ RSpec.shared_examples "manage meetings" do
         es: "Location hints",
         ca: "Location hints"
       )
-      fill_in_i18n_editor(
-        :meeting_short_description,
-        "#short_description-tabs",
-        en: "Short description",
-        es: "Descripción corta",
-        ca: "Descripció curta"
-      )
       fill_in_i18n_editor(
         :meeting_description,
         "#description-tabs",
@@ -114,7 +107,64 @@ RSpec.shared_examples "manage meetings" do
       end
 
       within "table" do
-        expect(page).to_not have_content(translated(meeting2.title))
+        expect(page).not_to have_content(translated(meeting2.title))
+      end
+    end
+  end
+
+  context "closing a meeting" do
+    let(:proposal_feature) do
+      create(:feature, manifest_name: :proposals, participatory_process: meeting.feature.participatory_process)
+    end
+    let!(:proposals) { create_list(:proposal, 3, feature: proposal_feature) }
+
+    it "closes a meeting with a report" do
+      within find("tr", text: translated(meeting.title)) do
+        click_link "Close"
+      end
+
+      within ".edit_close_meeting" do
+        fill_in_i18n(
+          :close_meeting_closing_report,
+          "#closing_report-tabs",
+          en: "The meeting was great!",
+          es: "El encuentro fue genial",
+          ca: "La trobada va ser genial"
+        )
+        fill_in :close_meeting_attendees_count, with: 12
+        fill_in :close_meeting_contributions_count, with: 44
+        fill_in :close_meeting_attending_organizations, with: "Neighbours Association, Group of People Complaining About Something and Other People"
+        select proposals.first.title, from: :close_meeting_proposal_ids
+        click_button "Close"
+      end
+
+      within ".flash" do
+        expect(page).to have_content("Meeting successfully closed")
+      end
+
+      within find("tr", text: translated(meeting.title)) do
+        within find("td:nth-child(4)") do
+          expect(page).to have_content("Yes")
+        end
+      end
+    end
+
+    context "when a meeting has alredy been closed" do
+      let!(:meeting) { create(:meeting, :closed, feature: current_feature) }
+
+      it "can update the information" do
+        within find("tr", text: translated(meeting.title)) do
+          click_link "Close"
+        end
+
+        within ".edit_close_meeting" do
+          fill_in :close_meeting_attendees_count, with: 22
+          click_button "Close"
+        end
+
+        within ".flash" do
+          expect(page).to have_content("Meeting successfully closed")
+        end
       end
     end
   end