decidim-proposals 0.23.6 → 0.24.0.rc1

data/lib/decidim/proposals/proposal_creator.rb

@@ -0,0 +1,98 @@
+# frozen_string_literal: true
+
+module Decidim
+  module Proposals
+    # This class is responsible for creating the imported proposals
+    # and must be included in proposals component's import manifest.
+    class ProposalCreator < Decidim::Admin::Import::Creator
+      # Retuns the resource class to be created with the provided data.
+      def self.resource_klass
+        Decidim::Proposals::Proposal
+      end
+
+      # Produces a proposal from parsed data
+      #
+      # Returns a proposal
+      def produce
+        resource.add_coauthor(context[:current_user], user_group: context[:user_group])
+
+        resource
+      end
+
+      # Saves the proposal
+      def finish!
+        super # resource.save!
+        notify(resource)
+        publish(resource)
+      end
+
+      private
+
+      attr_reader :context
+
+      def resource
+        @resource ||= Decidim::Proposals::Proposal.new(
+          category: category,
+          scope: scope,
+          title: title,
+          body: body,
+          component: component,
+          published_at: Time.current
+        )
+      end
+
+      def category
+        id = data.has_key?(:category) ? data[:category]["id"] : data[:"category/id"].to_i
+        Decidim::Category.find_by(id: id)
+      end
+
+      def scope
+        id = data.has_key?(:scope) ? data[:scope]["id"] : data[:"scope/id"].to_i
+        Decidim::Scope.find_by(id: id)
+      end
+
+      def title
+        locale_hasher("title", available_locales)
+      end
+
+      def body
+        locale_hasher("body", available_locales)
+      end
+
+      def available_locales
+        @available_locales ||= component.participatory_space.organization.available_locales
+      end
+
+      def component
+        context[:current_component]
+      end
+
+      def notify(proposal)
+        return if proposal.coauthorships.empty?
+
+        Decidim::EventsManager.publish(
+          event: "decidim.events.proposals.proposal_published",
+          event_class: Decidim::Proposals::PublishProposalEvent,
+          resource: proposal,
+          followers: coauthors_followers(proposal)
+        )
+      end
+
+      def publish(proposal)
+        Decidim::EventsManager.publish(
+          event: "decidim.events.proposals.proposal_published",
+          event_class: Decidim::Proposals::PublishProposalEvent,
+          resource: proposal,
+          followers: proposal.participatory_space.followers - coauthors_followers(proposal),
+          extra: {
+            participatory_space: true
+          }
+        )
+      end
+
+      def coauthors_followers(proposal)
+        @coauthors_followers ||= proposal.authors.flat_map(&:followers)
+      end
+    end
+  end
+end

data/lib/decidim/proposals/test/factories.rb

@@ -262,19 +262,21 @@ FactoryBot.define do
       if skip_injection
         Decidim::Faker::Localized.localized { generate(:title) }
       else
-        Decidim::Faker::Localized.localized { "<script>alert(\"TITLE\");</script> " + generate(:title) }
+        Decidim::Faker::Localized.localized { "<script>alert(\"TITLE\");</script> #{generate(:title)}" }
       end
     end
     body do
       if skip_injection
-        Decidim::Faker::Localized.localized { Faker::Lorem.sentences(3).join("\n") }
+        Decidim::Faker::Localized.localized { Faker::Lorem.sentences(number: 3).join("\n") }
       else
-        Decidim::Faker::Localized.localized { "<script>alert(\"TITLE\");</script> " + Faker::Lorem.sentences(3).join("\n") }
+        Decidim::Faker::Localized.localized { "<script>alert(\"TITLE\");</script> #{Faker::Lorem.sentences(number: 3).join("\n")}" }
       end
     end
     component { create(:proposal_component) }
     published_at { Time.current }
     address { "#{Faker::Address.street_name}, #{Faker::Address.city}" }
+    latitude { Faker::Address.latitude }
+    longitude { Faker::Address.longitude }
 
     after(:build) do |proposal, evaluator|
       proposal.title = if evaluator.title.is_a?(String)
@@ -409,6 +411,18 @@ FactoryBot.define do
         create_list(:proposal_amendment, 5, amendable: proposal)
       end
     end
+
+    trait :with_photo do
+      after :create do |proposal|
+        proposal.attachments << create(:attachment, :with_image, attached_to: proposal)
+      end
+    end
+
+    trait :with_document do
+      after :create do |proposal|
+        proposal.attachments << create(:attachment, :with_pdf, attached_to: proposal)
+      end
+    end
   end
 
   factory :proposal_vote, class: "Decidim::Proposals::ProposalVote" do
@@ -424,7 +438,7 @@ FactoryBot.define do
   end
 
   factory :proposal_note, class: "Decidim::Proposals::ProposalNote" do
-    body { Faker::Lorem.sentences(3).join("\n") }
+    body { Faker::Lorem.sentences(number: 3).join("\n") }
     proposal { build(:proposal) }
     author { build(:user, organization: proposal.organization) }
   end
@@ -436,8 +450,8 @@ FactoryBot.define do
       user_groups { [] }
     end
 
-    title { "<script>alert(\"TITLE\");</script> " + generate(:title) }
-    body { "<script>alert(\"BODY\");</script>\n" + Faker::Lorem.sentences(3).join("\n") }
+    title { "<script>alert(\"TITLE\");</script> #{generate(:title)}" }
+    body { "<script>alert(\"BODY\");</script>\n#{Faker::Lorem.sentences(number: 3).join("\n")}" }
     component { create(:proposal_component) }
     address { "#{Faker::Address.street_name}, #{Faker::Address.city}" }
     state { "open" }
@@ -467,8 +481,8 @@ FactoryBot.define do
   end
 
   factory :participatory_text, class: "Decidim::Proposals::ParticipatoryText" do
-    title { { en: "<script>alert(\"TITLE\");</script> " + generate(:title) } }
-    description { { en: "<script>alert(\"DESCRIPTION\");</script>\n" + Faker::Lorem.sentences(3).join("\n") } }
+    title { { en: "<script>alert(\"TITLE\");</script> #{generate(:title)}" } }
+    description { { en: "<script>alert(\"DESCRIPTION\");</script>\n#{Faker::Lorem.sentences(number: 3).join("\n")}" } }
     component { create(:proposal_component) }
   end
 

data/lib/decidim/proposals/version.rb

@@ -4,7 +4,7 @@ module Decidim
   # This holds decidim-proposals version.
   module Proposals
     def self.version
-      "0.23.6"
+      "0.24.0.rc1"
     end
   end
 end

data/lib/decidim/proposals.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "decidim/proposals/admin"
+require "decidim/proposals/api"
 require "decidim/proposals/engine"
 require "decidim/proposals/admin_engine"
 require "decidim/proposals/component"
@@ -11,6 +12,7 @@ module Decidim
   # allows users to create proposals in a participatory process.
   module Proposals
     autoload :ProposalSerializer, "decidim/proposals/proposal_serializer"
+    autoload :ProposalCreator, "decidim/proposals/proposal_creator"
     autoload :CommentableProposal, "decidim/proposals/commentable_proposal"
     autoload :CommentableCollaborativeDraft, "decidim/proposals/commentable_collaborative_draft"
     autoload :MarkdownToProposals, "decidim/proposals/markdown_to_proposals"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: decidim-proposals
 version: !ruby/object:Gem::Version
-  version: 0.23.6
+  version: 0.24.0.rc1
 platform: ruby
 authors:
 - Josep Jaume Rey Peroy
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-05-10 00:00:00.000000000 Z
+date: 2021-03-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: acts_as_list
@@ -60,42 +60,42 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.23.6
+        version: 0.24.0.rc1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.23.6
+        version: 0.24.0.rc1
 - !ruby/object:Gem::Dependency
   name: decidim-core
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.23.6
+        version: 0.24.0.rc1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.23.6
+        version: 0.24.0.rc1
 - !ruby/object:Gem::Dependency
   name: doc2text
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.4.2
+        version: 0.4.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.4.2
+        version: 0.4.3
 - !ruby/object:Gem::Dependency
   name: kaminari
   requirement: !ruby/object:Gem::Requirement
@@ -136,98 +136,104 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.4'
+        version: '3.5'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.5.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.4'
+        version: '3.5'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.5.1
 - !ruby/object:Gem::Dependency
   name: decidim-admin
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.23.6
+        version: 0.24.0.rc1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.23.6
+        version: 0.24.0.rc1
 - !ruby/object:Gem::Dependency
   name: decidim-assemblies
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.23.6
+        version: 0.24.0.rc1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.23.6
+        version: 0.24.0.rc1
 - !ruby/object:Gem::Dependency
   name: decidim-budgets
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.23.6
+        version: 0.24.0.rc1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.23.6
+        version: 0.24.0.rc1
 - !ruby/object:Gem::Dependency
   name: decidim-dev
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.23.6
+        version: 0.24.0.rc1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.23.6
+        version: 0.24.0.rc1
 - !ruby/object:Gem::Dependency
   name: decidim-meetings
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.23.6
+        version: 0.24.0.rc1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.23.6
+        version: 0.24.0.rc1
 - !ruby/object:Gem::Dependency
   name: decidim-participatory_processes
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.23.6
+        version: 0.24.0.rc1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.23.6
+        version: 0.24.0.rc1
 description: A proposals component for decidim's participatory spaces.
 email:
 - josepjaume@gmail.com
@@ -252,12 +258,19 @@ files:
 - app/assets/javascripts/decidim/proposals/admin/proposals_form.js.es6
 - app/assets/javascripts/decidim/proposals/admin/proposals_picker.js.es6
 - app/assets/javascripts/decidim/proposals/utils.js.es6
+- app/assets/stylesheets/decidim/proposals/_proposals.css.scss
+- app/assets/stylesheets/decidim/proposals/proposals/_preview.css.scss
 - app/cells/decidim/proposals/collaborative_draft_cell.rb
 - app/cells/decidim/proposals/collaborative_draft_link_to_proposal/show.erb
 - app/cells/decidim/proposals/collaborative_draft_link_to_proposal_cell.rb
 - app/cells/decidim/proposals/collaborative_draft_m/footer.erb
 - app/cells/decidim/proposals/collaborative_draft_m/tags.erb
 - app/cells/decidim/proposals/collaborative_draft_m_cell.rb
+- app/cells/decidim/proposals/collaborative_drafts/reported_content/show.erb
+- app/cells/decidim/proposals/collaborative_drafts/reported_content_cell.rb
+- app/cells/decidim/proposals/content_blocks/highlighted_proposals/elements.erb
+- app/cells/decidim/proposals/content_blocks/highlighted_proposals/heading.erb
+- app/cells/decidim/proposals/content_blocks/highlighted_proposals_cell.rb
 - app/cells/decidim/proposals/cost_report/show.erb
 - app/cells/decidim/proposals/cost_report_cell.rb
 - app/cells/decidim/proposals/highlighted_proposals/show.erb
@@ -284,6 +297,8 @@ files:
 - app/cells/decidim/proposals/proposals_picker/proposals.erb
 - app/cells/decidim/proposals/proposals_picker/show.erb
 - app/cells/decidim/proposals/proposals_picker_cell.rb
+- app/cells/decidim/proposals/reported_content/show.erb
+- app/cells/decidim/proposals/reported_content_cell.rb
 - app/commands/decidim/proposals/accept_access_to_collaborative_draft.rb
 - app/commands/decidim/proposals/admin/answer_proposal.rb
 - app/commands/decidim/proposals/admin/assign_proposals_to_valuator.rb
@@ -304,7 +319,6 @@ files:
 - app/commands/decidim/proposals/admin/update_proposal_scope.rb
 - app/commands/decidim/proposals/create_collaborative_draft.rb
 - app/commands/decidim/proposals/create_proposal.rb
-- app/commands/decidim/proposals/create_proposal_export.rb
 - app/commands/decidim/proposals/destroy_proposal.rb
 - app/commands/decidim/proposals/gallery_methods.rb
 - app/commands/decidim/proposals/hashtags_methods.rb
@@ -388,7 +402,6 @@ files:
 - app/helpers/decidim/proposals/map_helper.rb
 - app/helpers/decidim/proposals/participatory_texts_helper.rb
 - app/helpers/decidim/proposals/proposal_cells_helper.rb
-- app/helpers/decidim/proposals/proposal_endorsements_helper.rb
 - app/helpers/decidim/proposals/proposal_votes_helper.rb
 - app/helpers/decidim/proposals/proposal_wizard_helper.rb
 - app/helpers/decidim/proposals/proposals_helper.rb
@@ -422,18 +435,12 @@ files:
 - app/queries/decidim/proposals/metrics/proposal_participants_metric_measure.rb
 - app/queries/decidim/proposals/metrics/proposals_metric_manage.rb
 - app/queries/decidim/proposals/metrics/votes_metric_manage.rb
-- app/queries/decidim/proposals/similar_collaborative_drafts.rb
 - app/queries/decidim/proposals/similar_proposals.rb
 - app/services/decidim/proposals/collaborative_draft_search.rb
 - app/services/decidim/proposals/diff_renderer.rb
 - app/services/decidim/proposals/proposal_builder.rb
 - app/services/decidim/proposals/proposal_search.rb
-- app/types/decidim/proposals/proposal_input_filter.rb
-- app/types/decidim/proposals/proposal_input_sort.rb
-- app/types/decidim/proposals/proposal_type.rb
-- app/types/decidim/proposals/proposals_type.rb
 - app/validators/proposal_length_validator.rb
-- app/views/decidim/participatory_processes/participatory_process_groups/_highlighted_proposals.html.erb
 - app/views/decidim/proposals/admin/participatory_texts/_article-preview.html.erb
 - app/views/decidim/proposals/admin/participatory_texts/_bulk-actions.html.erb
 - app/views/decidim/proposals/admin/participatory_texts/index.html.erb
@@ -472,8 +479,7 @@ files:
 - app/views/decidim/proposals/collaborative_drafts/_reject_request_access_form.html.erb
 - app/views/decidim/proposals/collaborative_drafts/_request_access_form.html.erb
 - app/views/decidim/proposals/collaborative_drafts/_wizard_aside.html.erb
-- app/views/decidim/proposals/collaborative_drafts/compare.html.erb
-- app/views/decidim/proposals/collaborative_drafts/complete.html.erb
+- app/views/decidim/proposals/collaborative_drafts/_wizard_header.html.erb
 - app/views/decidim/proposals/collaborative_drafts/edit.html.erb
 - app/views/decidim/proposals/collaborative_drafts/index.html.erb
 - app/views/decidim/proposals/collaborative_drafts/index.js.erb
@@ -481,6 +487,7 @@ files:
 - app/views/decidim/proposals/collaborative_drafts/show.html.erb
 - app/views/decidim/proposals/proposal_votes/update_buttons_and_counters.js.erb
 - app/views/decidim/proposals/proposals/_count.html.erb
+- app/views/decidim/proposals/proposals/_dynamic_map_instructions.html.erb
 - app/views/decidim/proposals/proposals/_edit_form_fields.html.erb
 - app/views/decidim/proposals/proposals/_endorsements_card_row.html.erb
 - app/views/decidim/proposals/proposals/_filters.html.erb
@@ -488,7 +495,6 @@ files:
 - app/views/decidim/proposals/proposals/_linked_proposals.html.erb
 - app/views/decidim/proposals/proposals/_proposal.html.erb
 - app/views/decidim/proposals/proposals/_proposal_badge.html.erb
-- app/views/decidim/proposals/proposals/_proposal_preview.html.erb
 - app/views/decidim/proposals/proposals/_proposal_similar.html.erb
 - app/views/decidim/proposals/proposals/_proposals.html.erb
 - app/views/decidim/proposals/proposals/_remaining_votes_count.html.erb
@@ -631,14 +637,19 @@ files:
 - db/migrate/20200708091228_move_proposals_fields_to_i18n.rb
 - db/migrate/20200730131631_move_proposal_endorsed_event_notifications_to_resource_endorsed_event.rb
 - db/migrate/20200827154156_add_commentable_counter_cache_to_proposals.rb
+- db/migrate/20200915151348_fix_proposals_data_to_ensure_title_and_body_are_hashes.rb
 - db/migrate/20201002085508_fix_proposals_data.rb
 - db/migrate/20210127115628_fix_answered_proposals_after_copy.rb
-- db/migrate/20210318082934_fix_counters_for_copied_proposals.rb
+- lib/decidim/api/proposal_input_filter.rb
+- lib/decidim/api/proposal_input_sort.rb
+- lib/decidim/api/proposal_type.rb
+- lib/decidim/api/proposals_type.rb
 - lib/decidim/content_parsers/proposal_parser.rb
 - lib/decidim/content_renderers/proposal_renderer.rb
 - lib/decidim/proposals.rb
 - lib/decidim/proposals/admin.rb
 - lib/decidim/proposals/admin_engine.rb
+- lib/decidim/proposals/api.rb
 - lib/decidim/proposals/commentable_collaborative_draft.rb
 - lib/decidim/proposals/commentable_proposal.rb
 - lib/decidim/proposals/component.rb
@@ -647,6 +658,7 @@ files:
 - lib/decidim/proposals/markdown_to_proposals.rb
 - lib/decidim/proposals/odt_to_markdown.rb
 - lib/decidim/proposals/participatory_text_section.rb
+- lib/decidim/proposals/proposal_creator.rb
 - lib/decidim/proposals/proposal_serializer.rb
 - lib/decidim/proposals/test/capybara_proposals_picker.rb
 - lib/decidim/proposals/test/factories.rb
@@ -664,14 +676,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.6'
+      version: '2.7'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.2
 signing_key:
 specification_version: 4
 summary: Decidim proposals module

data/app/commands/decidim/proposals/create_proposal_export.rb

@@ -1,37 +0,0 @@
-# frozen_string_literal: true
-
-module Decidim
-  module Proposals
-    # A command with all the business logic when a user creates a new proposal.
-    class CreateProposalExport < Rectify::Command
-      # Public: Initializes the command.
-      #
-      # form         - A form object with the params.
-      # current_user - The current user.
-      def initialize(participatory_process)
-        @participatory_process = participatory_process
-      end
-
-      # Executes the command. Broadcasts these events:
-      #
-      # - :ok when everything is valid, together with the proposal.
-      # - :invalid if the proposal wasn't valid and we couldn't proceed.
-      #
-      # Returns nothing.
-      def call
-        return broadcast(:invalid) if participatory_process.invalid?
-
-        create_proposal_export
-        broadcast(:ok, export)
-      end
-
-      private
-
-      attr_reader :participatory_process
-
-      def create_proposal_export
-        ProposalsExporterJob.perform_later(participatory_process)
-      end
-    end
-  end
-end

data/app/queries/decidim/proposals/similar_collaborative_drafts.rb

@@ -1,52 +0,0 @@
-# frozen_string_literal: true
-
-module Decidim
-  module Proposals
-    # Class used to retrieve similar collaborative_drafts.
-    class SimilarCollaborativeDrafts < Rectify::Query
-      include Decidim::TranslationsHelper
-
-      # Syntactic sugar to initialize the class and return the queried objects.
-      #
-      # component - Decidim::CurrentComponent
-      # collaborative_draft - Decidim::Proposals::CollaborativeDraft
-      def self.for(component, collaborative_draft)
-        new(component, collaborative_draft).query
-      end
-
-      # Initializes the class.
-      #
-      # component - Decidim::CurrentComponent
-      # collaborative_draft - Decidim::Proposals::CollaborativeDraft
-      def initialize(component, collaborative_draft)
-        @component = component
-        @collaborative_draft = collaborative_draft
-      end
-
-      # Retrieves similar collaborative_drafts
-      def query
-        Decidim::Proposals::CollaborativeDraft
-          .where(component: @component)
-          .where(
-            "GREATEST(#{title_similarity}, #{body_similarity}) >= ?",
-            @collaborative_draft[:title],
-            @collaborative_draft[:body],
-            Decidim::Proposals.similarity_threshold
-          )
-          .limit(Decidim::Proposals.similarity_limit)
-      end
-
-      private
-
-      attr_reader :collaborative_draft
-
-      def title_similarity
-        "similarity(title, ?)"
-      end
-
-      def body_similarity
-        "similarity(body, ?)"
-      end
-    end
-  end
-end