decidim-proposals 0.21.0 → 0.22.0

data/app/commands/decidim/proposals/attachment_methods.rb

@@ -1,43 +0,0 @@
-# frozen_string_literal: true
-
-module Decidim
-  module Proposals
-    # A module with all the attachment common methods for proposals
-    # and collaborative draft commands.
-    module AttachmentMethods
-      private
-
-      def build_attachment
-        @attachment = Attachment.new(
-          title: @form.attachment.title,
-          file: @form.attachment.file,
-          attached_to: @attached_to
-        )
-      end
-
-      def attachment_invalid?
-        if attachment.invalid? && attachment.errors.has_key?(:file)
-          @form.attachment.errors.add :file, attachment.errors[:file]
-          true
-        end
-      end
-
-      def attachment_present?
-        @form.attachment.file.present?
-      end
-
-      def create_attachment
-        attachment.attached_to = @attached_to
-        attachment.save!
-      end
-
-      def attachments_allowed?
-        @form.current_component.settings.attachments_allowed?
-      end
-
-      def process_attachments?
-        attachments_allowed? && attachment_present?
-      end
-    end
-  end
-end

data/app/commands/decidim/proposals/endorse_proposal.rb

@@ -1,59 +0,0 @@
-# frozen_string_literal: true
-
-module Decidim
-  module Proposals
-    # A command with all the business logic when a user endorses a proposal.
-    class EndorseProposal < Rectify::Command
-      # Public: Initializes the command.
-      #
-      # proposal     - A Decidim::Proposals::Proposal object.
-      # current_user - The current user.
-      # current_group_id- (optional) The current_grup that is endorsing the Proposal.
-      def initialize(proposal, current_user, current_group_id = nil)
-        @proposal = proposal
-        @current_user = current_user
-        @current_group_id = current_group_id
-      end
-
-      # Executes the command. Broadcasts these events:
-      #
-      # - :ok when everything is valid, together with the proposal vote.
-      # - :invalid if the form wasn't valid and we couldn't proceed.
-      #
-      # Returns nothing.
-      def call
-        endorsement = build_proposal_endorsement
-        if endorsement.save
-          notify_endorser_followers
-          broadcast(:ok, endorsement)
-        else
-          broadcast(:invalid)
-        end
-      end
-
-      private
-
-      def build_proposal_endorsement
-        endorsement = @proposal.endorsements.build(author: @current_user)
-        endorsement.user_group = user_groups.find(@current_group_id) if @current_group_id.present?
-        endorsement
-      end
-
-      def user_groups
-        Decidim::UserGroups::ManageableUserGroups.for(@current_user).verified
-      end
-
-      def notify_endorser_followers
-        Decidim::EventsManager.publish(
-          event: "decidim.events.proposals.proposal_endorsed",
-          event_class: Decidim::Proposals::ProposalEndorsedEvent,
-          resource: @proposal,
-          followers: @current_user.followers,
-          extra: {
-            endorser_id: @current_user.id
-          }
-        )
-      end
-    end
-  end
-end

data/app/commands/decidim/proposals/unendorse_proposal.rb

@@ -1,40 +0,0 @@
-# frozen_string_literal: true
-
-module Decidim
-  module Proposals
-    # A command with all the business logic when a user or organization unendorses a proposal.
-    class UnendorseProposal < Rectify::Command
-      # Public: Initializes the command.
-      #
-      # proposal     - A Decidim::Proposals::Proposal object.
-      # current_user - The current user.
-      # current_group- (optional) The current_group that is unendorsing from the Proposal.
-      def initialize(proposal, current_user, current_group = nil)
-        @proposal = proposal
-        @current_user = current_user
-        @current_group = current_group
-      end
-
-      # Executes the command. Broadcasts these events:
-      #
-      # - :ok when everything is valid, together with the proposal.
-      # - :invalid if the form wasn't valid and we couldn't proceed.
-      #
-      # Returns nothing.
-      def call
-        destroy_proposal_endorsement
-        broadcast(:ok, @proposal)
-      end
-
-      private
-
-      def destroy_proposal_endorsement
-        query = @proposal.endorsements.where(
-          author: @current_user,
-          decidim_user_group_id: @current_group&.id
-        )
-        query.destroy_all
-      end
-    end
-  end
-end

data/app/controllers/decidim/proposals/proposal_endorsements_controller.rb

@@ -1,60 +0,0 @@
-# frozen_string_literal: true
-
-module Decidim
-  module Proposals
-    # Exposes the proposal endorsement resource so that users can endorse proposals.
-    class ProposalEndorsementsController < Decidim::Proposals::ApplicationController
-      helper_method :proposal
-
-      before_action :authenticate_user!
-
-      def create
-        enforce_permission_to :endorse, :proposal, proposal: proposal
-        @from_proposals_list = params[:from_proposals_list] == "true"
-        user_group_id = params[:user_group_id]
-
-        EndorseProposal.call(proposal, current_user, user_group_id) do
-          on(:ok) do
-            proposal.reload
-            render :update_buttons_and_counters
-          end
-
-          on(:invalid) do
-            render json: { error: I18n.t("proposal_endorsements.create.error", scope: "decidim.proposals") }, status: :unprocessable_entity
-          end
-        end
-      end
-
-      def destroy
-        enforce_permission_to :unendorse, :proposal, proposal: proposal
-        @from_proposals_list = params[:from_proposals_list] == "true"
-        user_group_id = params[:user_group_id]
-        user_group = user_groups.find(user_group_id) if user_group_id
-
-        UnendorseProposal.call(proposal, current_user, user_group) do
-          on(:ok) do
-            proposal.reload
-            render :update_buttons_and_counters
-          end
-        end
-      end
-
-      def identities
-        enforce_permission_to :endorse, :proposal, proposal: proposal
-
-        @user_verified_groups = Decidim::UserGroups::ManageableUserGroups.for(current_user).verified
-        render :identities, layout: false
-      end
-
-      private
-
-      def user_groups
-        Decidim::UserGroups::ManageableUserGroups.for(current_user).verified
-      end
-
-      def proposal
-        @proposal ||= Proposal.where(component: current_component).find(params[:proposal_id])
-      end
-    end
-  end
-end

data/app/models/decidim/proposals/proposal_endorsement.rb

@@ -1,37 +0,0 @@
-# frozen_string_literal: true
-
-module Decidim
-  module Proposals
-    # A proposal can include an endorsement per user or group.
-    class ProposalEndorsement < ApplicationRecord
-      include Decidim::Authorable
-
-      belongs_to :proposal, foreign_key: "decidim_proposal_id", class_name: "Decidim::Proposals::Proposal", counter_cache: true
-
-      validates :proposal, uniqueness: { scope: [:author, :user_group] }
-      validate :author_and_proposal_same_organization
-      validate :proposal_not_rejected
-
-      scope :for_listing, -> { order(:decidim_user_group_id, :created_at) }
-
-      private
-
-      def organization
-        proposal&.component&.organization
-      end
-
-      # Private: check if the proposal and the author have the same organization
-      def author_and_proposal_same_organization
-        return if !proposal || !author
-
-        errors.add(:proposal, :invalid) unless author.organization == proposal.organization
-      end
-
-      def proposal_not_rejected
-        return unless proposal
-
-        errors.add(:proposal, :invalid) if proposal.rejected?
-      end
-    end
-  end
-end

data/app/views/decidim/proposals/proposal_endorsements/_identity.html.erb

@@ -1,9 +0,0 @@
-<li class="<%= selected ? "selected" : "" %>" data-method="<%= http_method.to_s.upcase %>" data-url="<%= current_endorsement_url %>">
-  <div class="author-data author-data--small">
-    <div class="author-data__main">
-      <%== cell("decidim/author", identity, skip_profile_link: true).profile %>
-    </div>
-  </div>
-
-  <%= icon("circle-check", class: "icon--big #{selected ? '' : 'invisible'}") %>
-</li>

data/app/views/decidim/proposals/proposal_endorsements/identities.html.erb

@@ -1,12 +0,0 @@
-<div class="reveal__header reveal__header--nomargin reveal__bg p-s">
-  <h6 class="heading6 m-none"><%= t ".select_identity" %></h6>
-</div>
-<ul class="reveal__list">
-<%= render_endorsement_identity(proposal, current_user) %>
-<% @user_verified_groups.each do |user_group| %>
-  <%= render_endorsement_identity(proposal, current_user, user_group) %>
-<% end %>
-</ul>
-<div class="reveal__footer reveal__bg text-right p-s">
-  <button class="button button--nomargin button--sc" type="button" data-close><%= t(".done") %></button>
-</div>

data/app/views/decidim/proposals/proposal_endorsements/update_buttons_and_counters.js.erb

@@ -1,20 +0,0 @@
-<% if Decidim::UserGroups::ManageableUserGroups.for(current_user).verified.empty? %>
-update_main_page_button();
-<% end %>
-update_identities_rows();
-
-function update_main_page_button() {
-  var $proposalEndorsementButton = $('#proposal-<%= proposal.id %>-endorsement-button');
-  morphdom($proposalEndorsementButton[0], '<%= j(endorsement_button(proposal, false)).strip.html_safe %>');
-}
-function update_identities_rows() {
-  <% fully_endorsed= fully_endorsed?(proposal, current_user) %>
-  var $proposalEndorsementsRowCount = $('#proposal-<%= proposal.id %>-endorsements-count');
-  morphdom($proposalEndorsementsRowCount[0], '<%= j(render_endorsements_count_card_part(proposal, fully_endorsed)).strip.html_safe %>');
-  var $proposalEndorsementsRowButton = $($('#select-identity-button')[0]);
-  <% if fully_endorsed %>
-    $proposalEndorsementsRowButton.addClass('success')
-  <% else %>
-    $proposalEndorsementsRowButton.removeClass('success')
-  <% end %>
-}

data/app/views/decidim/proposals/proposals/_endorsement_button.html.erb

@@ -1,11 +0,0 @@
-<div id="proposal-<%= proposal.id %>-endorsement-button<%= user_group&.id ? "-#{user_group.id}" : "" %>">
-  <% if !current_user %>
-      <%= action_authorized_button_to :endorse, endorse_label, current_endorsement_url, resource: proposal, class: "button #{endorsement_button_classes(from_proposals_list)} secondary" %>
-  <% else %>
-    <% if proposal.endorsed_by?(current_user, user_group) %>
-      <%= action_authorized_button_to :endorse, unendorse_label, current_endorsement_url, resource: proposal, method: :delete, remote: true, class: "button #{endorsement_button_classes(from_proposals_list)} success", id: "endorsement_button" %>
-    <% else %>
-      <%= action_authorized_button_to :endorse, endorse_label, current_endorsement_url, resource: proposal, remote: true, data: {}, class: "button #{endorsement_button_classes(from_proposals_list)} secondary" %>
-    <% end %>
-  <% end %>
-</div>

data/app/views/decidim/proposals/proposals/_endorsement_identities_cabin.html.erb

@@ -1,13 +0,0 @@
-<%= javascript_include_tag "decidim/proposals/identity_selector_dialog" %>
-<% if current_user && Decidim::UserGroups::ManageableUserGroups.for(current_user).verified.any? %>
-  <button id="select-identity-button" type="button" name="button" class="button small compact light button--sc <%= fully_endorsed ? "success": "secondary" %>">
-    <%= t(".endorse") %>
-  </button>
-
-  <div class="reveal collapse"
-       id="user-identities"
-       data-reveal data-refresh-url="<%= identities_proposal_proposal_endorsement_path(proposal) %>">
-  </div>
-<% else %>
-    <%= endorsement_button(proposal, false) %>
-<% end %>

data/app/views/decidim/proposals/versions/_version.html.erb

@@ -1,20 +0,0 @@
-<div class="card--list__item">
-  <div class="card--list__text">
-    <div>
-      <%= link_to resource_version_path(index) do %>
-        <h6 class="card--list__heading heading6">
-          <%= t(".version_index", index: index + 1) %>
-        </h6>
-      <% end %>
-      <div class="author-data">
-        <%= render_resource_editor(version) %>
-        <%= l version.created_at, format: :decidim_short %>
-      </div>
-    </div>
-  </div>
-  <div class="card--list__data">
-    <%= link_to resource_version_path(index), class: "card--list__data__icon" do %>
-      <%= icon "chevron-right" %>
-    <% end %>
-  </div>
-</div>